[Buildbot-commits] [buildbot/buildbot] 2de7c6: Build steps should retry if the slave is lost

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 2de7c6c2b806150dc1aed3edea1b398f5c51ecd4
      https://github.com/buildbot/buildbot/commit/2de7c6c2b806150dc1aed3edea1b398f5c51ecd4
  Author: Shawn Wilsher <sdwilsh at fb.com>
  Date:   2014-01-15 (Wed, 15 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/source/bzr.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/darcs.py
    M master/buildbot/steps/source/git.py
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/steps/source/mtn.py
    M master/buildbot/steps/source/p4.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_steps_source_bzr.py
    M master/buildbot/test/unit/test_steps_source_cvs.py
    M master/buildbot/test/unit/test_steps_source_darcs.py
    M master/buildbot/test/unit/test_steps_source_git.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py
    M master/buildbot/test/unit/test_steps_source_mtn.py
    M master/buildbot/test/unit/test_steps_source_p4.py
    M master/buildbot/test/unit/test_steps_source_svn.py

  Log Message:
  -----------
  Build steps should retry if the slave is lost

If the slave is lost, it's not a failure of buildbot or the build
running, so we should just retry the job.  A bunch of the source
control steps already did this as well as `LoggingBuildstep`, but
this change centralizes all that logic into `Buildslave`.  All a
consumer has to do is add `Buildstep.failed` as an error handler and
everything will just work.

Since this is fixed in master, but broken on 0.8.8 for source control,
this change adds explicit tests to ensure that this isn't broken in the
future as well (since these tests were not added when the fix was added
originally).


  Commit: 9ff54e64bd23b8e8fbda959d35eb5b354be85e24
      https://github.com/buildbot/buildbot/commit/9ff54e64bd23b8e8fbda959d35eb5b354be85e24
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-16 (Thu, 16 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/source/bzr.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/darcs.py
    M master/buildbot/steps/source/git.py
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/steps/source/mtn.py
    M master/buildbot/steps/source/p4.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_steps_source_bzr.py
    M master/buildbot/test/unit/test_steps_source_cvs.py
    M master/buildbot/test/unit/test_steps_source_darcs.py
    M master/buildbot/test/unit/test_steps_source_git.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py
    M master/buildbot/test/unit/test_steps_source_mtn.py
    M master/buildbot/test/unit/test_steps_source_p4.py
    M master/buildbot/test/unit/test_steps_source_svn.py

  Log Message:
  -----------
  Merge sdwilsh/buildbot:pr-retry-on-slave-lost (PR #1049)

+pep8, pyflakes


  Commit: b271005c50b1f4cdabea0ac08604b5867d2a1f42
      https://github.com/buildbot/buildbot/commit/b271005c50b1f4cdabea0ac08604b5867d2a1f42
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-16 (Thu, 16 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  re-add checkDisconnect as a stub for compatibility, and mention in relnotes


  Commit: d58abf0a1cb82c492388d8ebe2c9b216f207ae34
      https://github.com/buildbot/buildbot/commit/d58abf0a1cb82c492388d8ebe2c9b216f207ae34
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-16 (Thu, 16 Jan 2014)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  pyflakes


Compare: https://github.com/buildbot/buildbot/compare/b7f7e9a8845a...d58abf0a1cb8