[Buildbot-commits] [Buildbot] #2657: P4Source should include P4TICKETS environent variable or all P4 environment variables

[Buildbot trac]

#2657: P4Source should include P4TICKETS environent variable or all P4 environment
variables
------------------------+-----------------------
Reporter:  Robin.Emery  |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  undecided
 Version:  0.8.8        |   Keywords:  P4Source
------------------------+-----------------------
 The P4Source change source class includes a set of P4* environment
 variables, however this is not the full set of variables used by the
 Perforce client.

 An example of how this can be a problem:
 To avoid storing the Perforce build account password in plain text, the
 Perforce server can issue a login ticket that has an extremely long
 expiration such that it does not practically expire. The account can be
 restricted at the Perforce server side to particular IPs, read-only etc. A
 manual login is made once and the ticket is stored.

 The p4 client looks for the ticket based on the P4TICKETS variable or at
 $HOME/.p4tickets. Neither P4TICKETS or HOME are copied to the environment
 of the p4 command run by P4Source. Using this method, P4Source fails to
 poll the depot as there are no credentials for the p4user.

 This can be worked-around by appending variables to the env_vars list of
 an instance of P4Source.

 The full list of variables is here (although P4TICKETS is described as
 "esoteric"):
 http://www.perforce.com/perforce/doc.current/manuals/cmdref/envars.html

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2657>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation