[Buildbot-commits] [Buildbot] #739: HTML logs are included in pickles

[Buildbot trac]

#739: HTML logs are included in pickles
---------------------+--------------------
Reporter:  marcusl   |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.+
 Version:  0.7.12    |  Resolution:
Keywords:  sprint    |
---------------------+--------------------

Comment (by jpommerening):

 Hey! I'm working on a fix: https://github.com/buildbot/buildbot/pull/1077

 The main problem with HTML-logs (in my opinion) is that they can not (yet)
 be streamed from the slaves. So if you have a 5MB log, you first have to
 collect the whole contents into an enormous string and pass it to
 `BuildStepStatus.addHTMLLog`. The fact that it will stay in memory and
 will stay there for as long as the whole `BuildStatus` instance lives only
 makes matters worse.

 OTOH, for small stack traces like the `err.html`, keeping them in memory
 may be the way to go…

 Another thing I'm not really comfortable with is the way the `HTMLLogFile`
 class serves as a kind of hint for the web status to handle it
 differently.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/739#comment:12>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation