[Buildbot-commits] [buildbot/buildbot] 2a53d7: Put workdir calculation in base Buildstep class

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 2a53d7ba59df4fed53fdee0b4d924c407d5c3ab6
      https://github.com/buildbot/buildbot/commit/2a53d7ba59df4fed53fdee0b4d924c407d5c3ab6
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/shell.py
    M master/docs/developer/cls-buildsteps.rst

  Log Message:
  -----------
  Put workdir calculation in base Buildstep class

The one is ShellCommand is generic logic enough to
be useful in base class.

Mark setDefaultWorkdir as deprecated

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: deead8673d7e5282fef255e4b1ae7f2b6b26407b
      https://github.com/buildbot/buildbot/commit/deead8673d7e5282fef255e4b1ae7f2b6b26407b
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/package/rpm/rpmbuild.py
    M master/buildbot/steps/shell.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_steps_master.py
    M master/buildbot/test/util/steps.py
    M master/docs/developer/cls-buildsteps.rst

  Log Message:
  -----------
  Put workdir calculation in base Buildstep class

The one is ShellCommand is generic logic enough to
be useful in base class.

Mark setDefaultWorkdir as deprecated

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 7fe48c3d0ca954751765d794a6224372080ef8a9
      https://github.com/buildbot/buildbot/commit/7fe48c3d0ca954751765d794a6224372080ef8a9
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  add relnote

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 4d0ae825bf8894796d370f52f2444e52c16dc635
      https://github.com/buildbot/buildbot/commit/4d0ae825bf8894796d370f52f2444e52c16dc635
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  some details on callable(workdir) behaviour

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: aa18a7e7a0cb815e199dba674ea799463f8f4de1
      https://github.com/buildbot/buildbot/commit/aa18a7e7a0cb815e199dba674ea799463f8f4de1
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/master.py
    M master/buildbot/steps/package/deb/pbuilder.py
    M master/buildbot/steps/package/rpm/rpmbuild.py
    M master/buildbot/steps/shell.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/repo.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/util/steps.py
    M master/docs/developer/cls-buildsteps.rst

  Log Message:
  -----------
  Change workdir to a property

remove getWorkdir(), as its semantics is really the same as an accessor

Remove all setDefaultWorkdir() usage, and effectively mark it as deprecated

remove other getWorkdir similar implementation

MasterShellCommand use another property, as using buildFactory's workdir does not really make sense

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 1d3cb7ad58b439ab2ab4f56ab35ca9945467e346
      https://github.com/buildbot/buildbot/commit/1d3cb7ad58b439ab2ab4f56ab35ca9945467e346
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/steps/shell.py

  Log Message:
  -----------
  improve comment about workdir in shellcommand

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: db305a8444a17771e3f3e4bf92e6555d7ae31fcb
      https://github.com/buildbot/buildbot/commit/db305a8444a17771e3f3e4bf92e6555d7ae31fcb
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/test/unit/test_steps_master.py

  Log Message:
  -----------
  wantDefaultWorkdir is not actually not needed

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: d48cd56d50b73c9cae564355a67b3323c90c6ca9
      https://github.com/buildbot/buildbot/commit/d48cd56d50b73c9cae564355a67b3323c90c6ca9
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  update release note


  Commit: 88869700d9187b54ee13409191fd83c708ba9b49
      https://github.com/buildbot/buildbot/commit/88869700d9187b54ee13409191fd83c708ba9b49
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-12-29 (Mon, 29 Dec 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  enhance code clarity


  Commit: cabe65f95b2424984fe7783802e0267b7d977db3
      https://github.com/buildbot/buildbot/commit/cabe65f95b2424984fe7783802e0267b7d977db3
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2014-12-30 (Tue, 30 Dec 2014)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/master.py
    M master/buildbot/steps/package/deb/pbuilder.py
    M master/buildbot/steps/package/rpm/rpmbuild.py
    M master/buildbot/steps/shell.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/repo.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/util/steps.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge pull request #1467 from tardyp/workdir

Put workdir calculation in base Buildstep class


Compare: https://github.com/buildbot/buildbot/compare/33ed29b8ea9e...cabe65f95b24