[Buildbot-commits] [buildbot/buildbot] a4247c: fix nonfunctional test case

GitHub noreply at github.com
Wed Dec 10 16:07:54 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: a4247c256e45c20e04393c015eac0413fbbd4054
      https://github.com/buildbot/buildbot/commit/a4247c256e45c20e04393c015eac0413fbbd4054
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-12-09 (Tue, 09 Dec 2014)

  Changed paths:
    M master/buildbot/test/unit/test_db_logs.py

  Log Message:
  -----------
  fix nonfunctional test case


  Commit: 2add1d92b0643abf62621d71f4d1928326220c2f
      https://github.com/buildbot/buildbot/commit/2add1d92b0643abf62621d71f4d1928326220c2f
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-12-09 (Tue, 09 Dec 2014)

  Changed paths:
    M master/buildbot/db/logs.py
    M master/buildbot/test/fake/fakedb.py
    M master/buildbot/test/unit/test_db_logs.py

  Log Message:
  -----------
  Fix off-by-one error in log chunk handling

The extra `- 1` here caused single blank lines to be skipped when
chopping un-requested lines of the end of a response.  Earlier tests,
even if they had actually been running, would not have discovered this
as they did not test blank lines.  Fixes #3101.


  Commit: 8b7fec7aa46c56f9b64ce27784edae44709ba3ef
      https://github.com/buildbot/buildbot/commit/8b7fec7aa46c56f9b64ce27784edae44709ba3ef
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2014-12-10 (Wed, 10 Dec 2014)

  Changed paths:
    M master/buildbot/db/logs.py
    M master/buildbot/test/fake/fakedb.py
    M master/buildbot/test/unit/test_db_logs.py

  Log Message:
  -----------
  Merge pull request #1436 from djmitche/bug3101

Fix off-by-one error in log handling of blank lines


Compare: https://github.com/buildbot/buildbot/compare/48253f6b12c7...8b7fec7aa46c


More information about the Commits mailing list