[Buildbot-commits] [buildbot/buildbot] 19293f: Try changes compared to master branch when using g...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 19293f1651477547cee6711690cc52e3c714ef3f
      https://github.com/buildbot/buildbot/commit/19293f1651477547cee6711690cc52e3c714ef3f
  Author: Vadim Zeitlin <vadim at zeitlins.org>
  Date:   2014-11-29 (Sat, 29 Nov 2014)

  Changed paths:
    M master/buildbot/clients/tryclient.py

  Log Message:
  -----------
  Try changes compared to master branch when using git by default.

If the current branch has no tracking branch, use master as the base revision,
otherwise the branch itself was used and we were left with an empty diff if
there were no uncommitted changes.

Signed-off-by: Vadim Zeitlin <vadim at zeitlins.org>


  Commit: cc1c4d38910a5c621d37918ae284e18af124e0e7
      https://github.com/buildbot/buildbot/commit/cc1c4d38910a5c621d37918ae284e18af124e0e7
  Author: Vadim Zeitlin <vadim at zeitlins.org>
  Date:   2014-11-29 (Sat, 29 Nov 2014)

  Changed paths:
    M master/buildbot/clients/tryclient.py

  Log Message:
  -----------
  Give a more understandable message in "try" when there are no changes.

The error message "object of type 'NoneType' has no len()" given in this case
before was particularly cryptic, provide something more intelligible if the
diff turns out to be empty.


  Commit: 489f7943cc8a842f5685a8d90b9c07a9a0705a66
      https://github.com/buildbot/buildbot/commit/489f7943cc8a842f5685a8d90b9c07a9a0705a66
  Author: Vadim Zeitlin <vadim at zeitlins.org>
  Date:   2014-11-29 (Sat, 29 Nov 2014)

  Changed paths:
    M master/buildbot/clients/tryclient.py
    M master/buildbot/test/integration/test_try_client.py

  Log Message:
  -----------
  Ensure full path to ssh command is used in the try client.

Using just "ssh" doesn't work under Windows where the native CreateProcess()
function used by spawnProcess() requires the full path as its argument, so
using ssh connection method simply always failed before.

Adding a "ssh_command" config option allowing to explicitly specify the
command to use might be a good idea as well, but for now just take the first
"ssh" in PATH.

Signed-off-by: Vadim Zeitlin <vadim at zeitlins.org>


  Commit: f7788eb5114ed45faf8c4560c508abed20556969
      https://github.com/buildbot/buildbot/commit/f7788eb5114ed45faf8c4560c508abed20556969
  Author: Vadim Zeitlin <vadim at zeitlins.org>
  Date:   2014-11-29 (Sat, 29 Nov 2014)

  Changed paths:
    M master/buildbot/clients/tryclient.py
    M master/buildbot/scripts/runner.py
    M master/docs/manual/cmdline.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Allow specifying the ssh command to use in "try" subcommand.

This is especially useful under Windows, where something other than ssh[.exe]
is often used (e.g. plink from PuTTY).

Signed-off-by: Vadim Zeitlin <vadim at zeitlins.org>


  Commit: f917d383d343c2e5b5d0ec90bb5379aff5651385
      https://github.com/buildbot/buildbot/commit/f917d383d343c2e5b5d0ec90bb5379aff5651385
  Author: Vadim Zeitlin <vadim at zeitlins.org>
  Date:   2014-11-30 (Sun, 30 Nov 2014)

  Changed paths:
    M master/buildbot/clients/tryclient.py

  Log Message:
  -----------
  Use standard shlex.split() for splitting ssh command under POSIX.

This method can't be used under Windows as it handles backslashes specially
while they are just path separators under Windows, but we should still use it
under the other systems to provide familiar semantics there.


  Commit: a34f1f87bb1f1103c770bfbcf2d31eaf81eb6075
      https://github.com/buildbot/buildbot/commit/a34f1f87bb1f1103c770bfbcf2d31eaf81eb6075
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2014-12-02 (Tue, 02 Dec 2014)

  Changed paths:
    M master/buildbot/clients/tryclient.py
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/integration/test_try_client.py
    M master/docs/manual/cmdline.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge pull request #1391 from vadz/try-fixes

Miscellaneous fixes for try subcommand.


Compare: https://github.com/buildbot/buildbot/compare/82a08abdf96b...a34f1f87bb1f