[Buildbot-commits] [buildbot/buildbot] c5a4ad: Fix #2735 pep8 > 1.4.6 has more errors

GitHub noreply at github.com
Sun Apr 20 13:05:34 UTC 2014


  Branch: refs/heads/nine
  Home:   https://github.com/buildbot/buildbot
  Commit: c5a4ad0d3308fbb0a0680887cf0781cc6e69e0a9
      https://github.com/buildbot/buildbot/commit/c5a4ad0d3308fbb0a0680887cf0781cc6e69e0a9
  Author: Mihai Martalogu <mmartalo at cisco.com>
  Date:   2014-04-20 (Sun, 20 Apr 2014)

  Changed paths:
    M .travis.yml
    M master/buildbot/changes/bonsaipoller.py
    M master/buildbot/changes/gitpoller.py
    M master/buildbot/changes/mail.py
    M master/buildbot/clients/gtkPanes.py
    M master/buildbot/locks.py
    M master/buildbot/monkeypatches/sqlalchemy2189.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/factory.py
    M master/buildbot/process/properties.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/schedulers/base.py
    M master/buildbot/schedulers/forcesched.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/scripts/runner.py
    M master/buildbot/status/build.py
    M master/buildbot/status/builder.py
    M master/buildbot/status/mail.py
    M master/buildbot/status/progress.py
    M master/buildbot/status/slave.py
    M master/buildbot/status/web/baseweb.py
    M master/buildbot/status/web/change_hook.py
    M master/buildbot/status/web/hooks/github.py
    M master/buildbot/status/web/hooks/gitlab.py
    M master/buildbot/status/web/hooks/poller.py
    M master/buildbot/status/web/slaves.py
    M master/buildbot/status/web/status_json.py
    M master/buildbot/status/web/waterfall.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/test/fake/botmaster.py
    M master/buildbot/test/integration/test_custom_buildstep.py
    M master/buildbot/test/test_extra_coverage.py
    M master/buildbot/test/unit/test_buildslave_libvirt.py
    M master/buildbot/test/unit/test_config.py
    M master/buildbot/test/unit/test_db_buildrequests.py
    M master/buildbot/test/unit/test_db_changes.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/util/croniter.py
    M master/buildbot/util/maildir.py
    M master/contrib/SimpleConfig.py
    M master/contrib/buildbot_json.py
    M master/contrib/git_buildbot.py
    M master/contrib/hgbuildbot.py
    M master/contrib/svnpoller.py
    M master/contrib/windows/buildbot_service.py
    M master/docs/conf.py
    M slave/buildslave/commands/base.py
    M slave/buildslave/test/unit/test_commands_bk.py
    M slave/contrib/windows/buildbot_service.py

  Log Message:
  -----------
  Fix #2735 pep8 > 1.4.6 has more errors


  Commit: eba6d1c2b9c73c715288575fe58bfa7962538dd1
      https://github.com/buildbot/buildbot/commit/eba6d1c2b9c73c715288575fe58bfa7962538dd1
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-04-20 (Sun, 20 Apr 2014)

  Changed paths:
    M .travis.yml
    M master/buildbot/changes/bonsaipoller.py
    M master/buildbot/changes/gitpoller.py
    M master/buildbot/changes/mail.py
    M master/buildbot/clients/gtkPanes.py
    M master/buildbot/locks.py
    M master/buildbot/monkeypatches/sqlalchemy2189.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/factory.py
    M master/buildbot/process/properties.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/schedulers/base.py
    M master/buildbot/schedulers/forcesched.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/scripts/runner.py
    M master/buildbot/status/build.py
    M master/buildbot/status/builder.py
    M master/buildbot/status/mail.py
    M master/buildbot/status/progress.py
    M master/buildbot/status/slave.py
    M master/buildbot/status/web/baseweb.py
    M master/buildbot/status/web/change_hook.py
    M master/buildbot/status/web/hooks/github.py
    M master/buildbot/status/web/hooks/gitlab.py
    M master/buildbot/status/web/hooks/poller.py
    M master/buildbot/status/web/slaves.py
    M master/buildbot/status/web/status_json.py
    M master/buildbot/status/web/waterfall.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/test/fake/botmaster.py
    M master/buildbot/test/integration/test_custom_buildstep.py
    M master/buildbot/test/test_extra_coverage.py
    M master/buildbot/test/unit/test_buildslave_libvirt.py
    M master/buildbot/test/unit/test_config.py
    M master/buildbot/test/unit/test_db_buildrequests.py
    M master/buildbot/test/unit/test_db_changes.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/util/croniter.py
    M master/buildbot/util/maildir.py
    M master/contrib/SimpleConfig.py
    M master/contrib/buildbot_json.py
    M master/contrib/git_buildbot.py
    M master/contrib/hgbuildbot.py
    M master/contrib/svnpoller.py
    M master/contrib/windows/buildbot_service.py
    M master/docs/conf.py
    M slave/buildslave/commands/base.py
    M slave/buildslave/test/unit/test_commands_bk.py
    M slave/contrib/windows/buildbot_service.py

  Log Message:
  -----------
  Merge mmartalo/buildbot:2735 (PR #1137)

+autopep8 (?!)


  Commit: 78965ded730692c43027c036937b9faa3814c97f
      https://github.com/buildbot/buildbot/commit/78965ded730692c43027c036937b9faa3814c97f
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-04-20 (Sun, 20 Apr 2014)

  Changed paths:
    M .travis.yml
    M common/pep8rc
    M master/buildbot/changes/bonsaipoller.py
    M master/buildbot/changes/gitpoller.py
    M master/buildbot/changes/mail.py
    M master/buildbot/data/buildsets.py
    M master/buildbot/locks.py
    M master/buildbot/monkeypatches/sqlalchemy2189.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/factory.py
    M master/buildbot/process/properties.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/schedulers/base.py
    M master/buildbot/schedulers/forcesched.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/scripts/runner.py
    M master/buildbot/status/build.py
    M master/buildbot/status/mail.py
    M master/buildbot/status/progress.py
    M master/buildbot/status/slave.py
    M master/buildbot/status/web/change_hook.py
    M master/buildbot/status/web/hooks/github.py
    M master/buildbot/status/web/hooks/gitlab.py
    M master/buildbot/status/web/hooks/poller.py
    M master/buildbot/status/words.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/test/fake/botmaster.py
    M master/buildbot/test/integration/test_custom_buildstep.py
    M master/buildbot/test/test_extra_coverage.py
    M master/buildbot/test/unit/test_buildslave_libvirt.py
    M master/buildbot/test/unit/test_changes_gitpoller.py
    M master/buildbot/test/unit/test_config.py
    M master/buildbot/test/unit/test_db_buildrequests.py
    M master/buildbot/test/unit/test_db_changes.py
    M master/buildbot/test/unit/test_schedulers_triggerable.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/test/unit/test_test_util_validation.py
    M master/buildbot/test/unit/test_www_ldapuserinfo.py
    M master/buildbot/util/croniter.py
    M master/buildbot/util/maildir.py
    M master/buildbot/util/service.py
    M master/buildbot/www/rest.py
    M master/buildbot/www/service.py
    M master/buildbot/www/sse.py
    M master/buildbot/www/websocket.py
    M master/contrib/SimpleConfig.py
    M master/contrib/buildbot_json.py
    M master/contrib/git_buildbot.py
    M master/contrib/hgbuildbot.py
    M master/contrib/svnpoller.py
    M master/contrib/windows/buildbot_service.py
    M master/docs/conf.py
    M slave/buildslave/commands/base.py
    M slave/buildslave/test/unit/test_commands_bk.py
    M slave/contrib/windows/buildbot_service.py

  Log Message:
  -----------
  Merge pep8 changes into nine, plus more

This ignores E123 because pep8 wants indentation to look like

     def test_SourcedPropertiesValidator(self):
   self.doValidationTest(validation.SourcedPropertiesValidator(),
                         good=[
                             {u'pname': ('{"a":"b"}', u'test')},
   ], bad=[
                             None, 1, "hi",
                             {u'pname': {'a': 'b'}},  # no source
                             # name not unicode
                             {'pname': ({'a': 'b'}, u'test')},
                             # source not unicode
                             {u'pname': ({'a': 'b'}, 'test')},
                             # self is not json-able
                             {u'pname': (self, u'test')},
   ])

which is ugly and most likely a bug in pep8.


Compare: https://github.com/buildbot/buildbot/compare/10205b41770c...78965ded7306


More information about the Commits mailing list