[Buildbot-commits] [buildbot/buildbot] 6812fd: Avoid extra DB lookups in BuildRequest

GitHub noreply at github.com
Sun Apr 6 02:41:57 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 6812fd5e7449245c0e34f587682e41ecaf5ccc1a
      https://github.com/buildbot/buildbot/commit/6812fd5e7449245c0e34f587682e41ecaf5ccc1a
  Author: Andrew Gallagher <agallagher at fb.com>
  Date:   2014-04-05 (Sat, 05 Apr 2014)

  Changed paths:
    M master/buildbot/status/builder.py
    M master/buildbot/status/buildrequest.py

  Log Message:
  -----------
  Avoid extra DB lookups in BuildRequest

When returning the list of pending build requests,
BuilderStatus.getPendingBuildRequests loads on brdicts
just to grab the brid to pass into the BuildRequest
constructor.  This brdict is then reloaded from the DB
if virtually any of the BuildRequest methods are called.
To avoid this extra lookup, this diff adds an extra
constructor parameter to thread the brdict into the
BuildRequest object.


  Commit: 2f9c8b8ef0f757c164dacdc95442b5cce2900830
      https://github.com/buildbot/buildbot/commit/2f9c8b8ef0f757c164dacdc95442b5cce2900830
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-04-05 (Sat, 05 Apr 2014)

  Changed paths:
    M master/buildbot/status/builder.py
    M master/buildbot/status/buildrequest.py

  Log Message:
  -----------
  Merge andrewjcg/buildbot:brdict (PR #1124)


Compare: https://github.com/buildbot/buildbot/compare/db15a05da2aa...2f9c8b8ef0f7


More information about the Commits mailing list