[Buildbot-commits] [buildbot/buildbot] f82012: buildbot.status.mail: improve email address regexp

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: f82012bf535b3224cc3eccd915afc6a66ecd35c3
      https://github.com/buildbot/buildbot/commit/f82012bf535b3224cc3eccd915afc6a66ecd35c3
  Author: Olof Johansson <olofjn at axis.com>
  Date:   2013-09-20 (Fri, 20 Sep 2013)

  Changed paths:
    M master/buildbot/status/mail.py
    M master/buildbot/test/unit/test_status_mail.py

  Log Message:
  -----------
  buildbot.status.mail: improve email address regexp

The previous email regexp contained some flaws; the intentions
of the regexp and the implemention had some gaps that would make it
hard to rely on.

This rewrite should match any valid email address, but it does not
give any guarantees that what it matches is a valid address. An
increased level of complexity is (hopefully) compensated by a comment
explaining the reasoning behind the regexp. This is accompanied by
unit tests; you are encouraged to add any corner case addresses in
either the test for valid or invalid addresses.


  Commit: 7c710af3068f7cb7e8a87e590587f4fc9b4b4c7c
      https://github.com/buildbot/buildbot/commit/7c710af3068f7cb7e8a87e590587f4fc9b4b4c7c
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-09-27 (Fri, 27 Sep 2013)

  Changed paths:
    M master/buildbot/status/mail.py
    M master/buildbot/test/unit/test_status_mail.py

  Log Message:
  -----------
  Merge branch 'topic/mail_status_addr_validation' of git://github.com/olof/buildbot

Conflicts:
	master/buildbot/status/mail.py


Compare: https://github.com/buildbot/buildbot/compare/b582658f131b...7c710af3068f