[Buildbot-commits] [Buildbot] #438: Mercurial does not update to the right revision when building a tag from a named branch

[Buildbot trac]

#438: Mercurial does not update to the right revision when building a tag from a
named branch
----------------------+-----------------------
Reporter:  cdevienne  |       Owner:  Callek
    Type:  defect     |      Status:  assigned
Priority:  major      |   Milestone:  0.8.+
 Version:  0.8.5      |  Resolution:
Keywords:  hg         |
----------------------+-----------------------

Comment (by pepsiman):

 The mercurial steps can operate in full or incremental mode.

 full mode can use clean, fresh or clobber methods.

 The clean and fresh methods currently use "pull --rev rev".

 Using "pull --rev rev" might sometimes be faster than "pull", but it does
 the wrong thing when given a tag.

 I'd like to change from this:
 {{{
 #!rst
 ================ ============== ============== ========================
 full                                           incremental
 ---------------------------------------------- ------------------------
 clobber          clean          fresh          None
 ================ ============== ============== ========================
 rmdir            purge          purge --all
 clone            pull --rev rev                pull
 ---------------- ----------------------------- ------------------------
 update --clean --rev rev
 =======================================================================
 }}}

 to this:
 {{{
 #!rst
 ================ ============== ============== ========================
 full                                           incremental
 ---------------------------------------------- ------------------------
 clobber          clean          fresh          None
 ================ ============== ============== ========================
 rmdir            purge          purge --all
 clone            pull
 ---------------- ------------------------------------------------------
 update --clean --rev rev
 =======================================================================
 }}}

 Patch:
 {{{
 --- a/master/buildbot/steps/source/mercurial.py
 +++ b/master/buildbot/steps/source/mercurial.py
 @@ -226,8 +226,6 @@ class Mercurial(Source):

      def _pullUpdate(self, res):
          command = ['pull' , self.repourl]
 -        if self.revision:
 -            command.extend(['--rev', self.revision])
          d = self._dovccmd(command)
          d.addCallback(self._checkBranchChange)
          return d
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/438#comment:14>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation