[Buildbot-commits] [Buildbot] #2557: regression: changes with long comments break the p4 poller against mysql
Buildbot trac
trac at buildbot.net
Mon Sep 2 15:06:19 UTC 2013
#2557: regression: changes with long comments break the p4 poller against mysql
--------------------+------------------------
Reporter: dberger | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.8 | Resolution:
Keywords: |
--------------------+------------------------
Comment (by dustin):
I think of this error - added in #2114 - as a safety check. Really truly,
we should allow arbitrary-length comments. For other length-limited
fields, though, we should be pushing back to the parts of Buildbot
supplying the data, allowing *those* tools to do the truncation or raise
an error, as appropriate.
So I don't want to merge this as-is, but I think it's a good fix for your
specific situation. If you want to work on a patch (to nine) that changes
the comments to a TEXT field, that'd be even better.
--
Ticket URL: <http://trac.buildbot.net/ticket/2557#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list