[Buildbot-commits] [buildbot/buildbot] 3c5931: Explicitly state that used /bin/bash shell in Make...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 3c593164c652f0189992527051887e6b18fd439e
      https://github.com/buildbot/buildbot/commit/3c593164c652f0189992527051887e6b18fd439e
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-10-17 (Thu, 17 Oct 2013)

  Changed paths:
    M master/docs/Makefile

  Log Message:
  -----------
  Explicitly state that used /bin/bash shell in Makefile

Code

    $(shell if [[ `tar --version` =~ "bsdtar" ]]; ...

written using Bash double-bracket conditions syntax.  When (default on
some platforms) /bin/sh interpreter used this code outputs error (but
luckily works as required):

    /bin/sh: 1: [[: not found


  Commit: 7b1d4d833a3d425d4b8b0617d16a0f9ed8d7e8ca
      https://github.com/buildbot/buildbot/commit/7b1d4d833a3d425d4b8b0617d16a0f9ed8d7e8ca
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-10-17 (Thu, 17 Oct 2013)

  Changed paths:
    M master/docs/Makefile

  Log Message:
  -----------
  Use declaration-time expansion assignment for $(shell ...) variables

Not important in this case actually, but recommended for such cases in
general (so that shell expression evaluated only once).


  Commit: c377e20eb2585702d9d25d16fd2a2e1cf0e329a2
      https://github.com/buildbot/buildbot/commit/c377e20eb2585702d9d25d16fd2a2e1cf0e329a2
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-10-22 (Tue, 22 Oct 2013)

  Changed paths:
    M master/docs/Makefile

  Log Message:
  -----------
  Use make conditions instead bash conditions

Suggested by @jpommerening.


  Commit: 281faae2acb4a79baa056ccf7dbd62253fe3156c
      https://github.com/buildbot/buildbot/commit/281faae2acb4a79baa056ccf7dbd62253fe3156c
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-10-22 (Tue, 22 Oct 2013)

  Changed paths:
    M master/docs/Makefile

  Log Message:
  -----------
  Add missed spaces around ':='


  Commit: ab7d62fb70eb048528ce3bf71d517dbab79669e6
      https://github.com/buildbot/buildbot/commit/ab7d62fb70eb048528ce3bf71d517dbab79669e6
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-10-22 (Tue, 22 Oct 2013)

  Changed paths:
    M master/docs/Makefile

  Log Message:
  -----------
  Merge branch 'fix_docs_makefile' of git://github.com/vrutsky/buildbot


Compare: https://github.com/buildbot/buildbot/compare/8d6d3a2e20e0...ab7d62fb70eb