[Buildbot-commits] [buildbot/buildbot] f20309: removed duplicate key assignment in dictionary

GitHub noreply at github.com
Wed Oct 16 20:25:30 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: f20309a3182372e51625cc486bd2a06a9cbf51af
      https://github.com/buildbot/buildbot/commit/f20309a3182372e51625cc486bd2a06a9cbf51af
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-10-14 (Mon, 14 Oct 2013)

  Changed paths:
    M master/buildbot/status/web/base.py

  Log Message:
  -----------
  removed duplicate key assignment in dictionary

Remove second assignment to 'text' key. It seems that
buildbot.status.builder.BuildStatus.getText() always
returns a list of strings, so the first assignment:

  'text': " ".join(build.getText()),

should be sufficient.

This fixes 'duplicate-key (W0109)' pylint warning.


  Commit: 979f1ba0c3b4e3fe904f543197fb0e5c7885d4f3
      https://github.com/buildbot/buildbot/commit/979f1ba0c3b4e3fe904f543197fb0e5c7885d4f3
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-10-14 (Mon, 14 Oct 2013)

  Changed paths:
    M common/pylintrc

  Log Message:
  -----------
  enable duplicate-key (W0109) pylint check


  Commit: 6e24ca112e1e65d4915d7b5d9138aceaa7d672cc
      https://github.com/buildbot/buildbot/commit/6e24ca112e1e65d4915d7b5d9138aceaa7d672cc
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-10-16 (Wed, 16 Oct 2013)

  Changed paths:
    M common/pylintrc
    M master/buildbot/status/web/base.py

  Log Message:
  -----------
  Merge branch 'pylint-duplicate-key' of git://github.com/elmirjagudin/buildbot


Compare: https://github.com/buildbot/buildbot/compare/1b4b68fdf941...6e24ca112e1e


More information about the Commits mailing list