[Buildbot-commits] [Buildbot] #2593: Repo master-side manifestBranch not marked renderable

[Buildbot trac]

#2593: Repo master-side manifestBranch not marked renderable
------------------------------+----------------------------------
Reporter:  alistair.strachan  |      Owner:
    Type:  defect             |     Status:  new
Priority:  minor              |  Milestone:  undecided
 Version:  0.8.8              |   Keywords:  repo, manifestBranch
------------------------------+----------------------------------
 This seems like an oversight. As can be seen here:

 https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source/repo.py

 ..and as present in the 0.8.8 release, the manifestBranch parameter to
 Repo is not in the "renderables" list. I discovered if I try to use (or
 interpolate) a property it doesn't get renderered properly e.g.:

 f.addStep(Repo(name="repo", haltOnFailure=True, manifestURL=manifestUrl,
 manifestBranch=Property("branch"), manifestFile=manifestFile))

 Or

 f.addStep(Repo(name="repo", haltOnFailure=True, manifestURL=manifestUrl,
 manifestBranch=Interpolate("%(prop:branch)s"), manifestFile=manifestFile))

 Both fail to render the branch text. This parameter seems like an obvious
 parameter to support property interpolation with, since the repo step runs
 as part of the builder, and that is parameterized by branch. The upstream
 manifest.git may shadow the builder branches.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2593>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation