[Buildbot-commits] [Buildbot] #624: Add Latent BuildSlave for DRMAA supporting systems
Buildbot trac
trac at buildbot.net
Tue Nov 19 15:30:51 UTC 2013
#624: Add Latent BuildSlave for DRMAA supporting systems
---------------------------+-----------------------
Reporter: smackware | Owner:
Type: enhancement | Status: reopened
Priority: major | Milestone: 0.8.+
Version: | Resolution:
Keywords: virtualization |
---------------------------+-----------------------
Comment (by mvpel):
Thanks for the pointer - I've forked the Github repo, so I'll plan to
convert things into a branch when I have some time this week. I found a
typo or two in any case, and perhaps I'll use the exercise of converting
run_buildslave into Python as an educational exercise. Reaching for
/bin/sh is a 30-year-old habit for me, and from what I've learned over the
last couple of months Python seems pretty spiffy.
With some further research, I found the "kill_sig=SIGHUP" Condor
directive, which results in a HUP signal being sent to the run_buildslave
script instead of a TERM, so that should mean that the "trap" wouldn't be
required since a HUP would propagate to the buildslave child, which would
close out due to the --allow-shutdown=signal.
However, having the trap would allow the startup script to try to append
the twistd.log file somewhere before exiting, or whatever else - but like
you said perhaps that's not worth the effort.
And after reading up on Python function arguments, I'm going to turn the
nativeSpecification pieces into default-value keyword arguments, so the
creator of the HTCondor latent slave in master.cfg can adjust them as
appropriate, and perhaps a way to sanity-check and accept arbitrary submit
description directives - perhaps something as simple as a string list
called "extra_submit_descriptions".
--
Ticket URL: <http://trac.buildbot.net/ticket/624#comment:16>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list