[Buildbot-commits] [buildbot/buildbot] fa6aee: Fix Git failures when master-side Gerrit step used

GitHub noreply at github.com
Fri Nov 15 22:29:14 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: fa6aeee5c63ace8d4117d9937972905a74f8d9a4
      https://github.com/buildbot/buildbot/commit/fa6aeee5c63ace8d4117d9937972905a74f8d9a4
  Author: Kevin Funk <kevin.funk at kdab.com>
  Date:   2013-11-06 (Wed, 06 Nov 2013)

  Changed paths:
    M master/buildbot/steps/source/gerrit.py

  Log Message:
  -----------
  Fix Git failures when master-side Gerrit step used

The Git step fetches from the wrong branch when being notified by
Gerrit 'ref-updated' events. In that case, branch=None is passed to
Git.startVC(...), hence the resulting git-fetch call tries to fetch HEAD
instead of the desired branch.

This was likely a typo from the original author.


  Commit: 93447bbef41d125cd897adbba37ce3155d62c5c1
      https://github.com/buildbot/buildbot/commit/93447bbef41d125cd897adbba37ce3155d62c5c1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-11-15 (Fri, 15 Nov 2013)

  Changed paths:
    M master/buildbot/steps/source/gerrit.py

  Log Message:
  -----------
  Merge branch 'fix-gerrit-step' of git://github.com/krf/buildbot


Compare: https://github.com/buildbot/buildbot/compare/20c2e51d74c8...93447bbef41d


More information about the Commits mailing list