[Buildbot-commits] [Buildbot] #2041: use consumeErrors for all gatherResults calls

[Buildbot trac]

#2041: use consumeErrors for all gatherResults calls
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.8
 Version:  0.8.4p1      |  Resolution:  fixed
Keywords:  sprint       |
------------------------+---------------------
Changes (by dustin):

 * status:  assigned => closed
 * resolution:   => fixed


Old description:

> gatherResults does not, by default, pass consumeErrors to the underlying
> !DeferredList.  But http://twistedmatrix.com/trac/ticket/5159 would add
> this as a parameter.  When (if) that gets merged, Buildbot should monkey-
> patch it into older versions of Twisted, and use it universally.
>
> This will prevent unnecessary "unhandled exception" logs, where we *have*
> handled the exception as part of the gathered results.

New description:

 gatherResults does not, by default, pass consumeErrors to the underlying
 !DeferredList.  But http://twistedmatrix.com/trac/ticket/5159 would add
 this as a parameter.  When (if) that gets merged, Buildbot should monkey-
 patch it into older versions of Twisted, and use it universally.

 This will prevent unnecessary "unhandled exception" logs, where we *have*
 handled the exception as part of the gathered results.

--

Comment:

 This was already fixed in master, but the bug not closed - Daniel just
 spent a lot of time studying the background of it to find it already
 complete :(

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2041#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation