[Buildbot-commits] [Buildbot] #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL"

[Buildbot trac]

#2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be
NULL"
-------------------------+----------------------
Reporter:  thomaswayden  |       Owner:
    Type:  defect        |      Status:  new
Priority:  major         |   Milestone:  0.8.7p1
 Version:  0.8.7p1       |  Resolution:
Keywords:                |
-------------------------+----------------------
Changes (by dustin):

 * type:  undecided => defect
 * milestone:  undecided => 0.8.7p1


Comment:

 So it's very hard to say what *you* are doing wrong to tickle this bug,
 but I see what we're doing wrong.  Basically, repository has to be set to
 something, and the default value here is `None`.

 This should fix it up:
 {{{
 #! diff
 diff --git a/master/buildbot/schedulers/base.py
 b/master/buildbot/schedulers/base.py
 index 6c4ccf1..a552525 100644
 --- a/master/buildbot/schedulers/base.py
 +++ b/master/buildbot/schedulers/base.py
 @@ -344,7 +344,7 @@ class BaseScheduler(service.MultiService,
 ComparableMixin, StateMixin):
              # add sourcestamp to the new setid
              yield self.master.db.sourcestamps.addSourceStamp(
                          codebase=codebase,
 -                        repository=ss.get('repository', None),
 +                        repository=ss.get('repository', ''),
                          branch=ss.get('branch', None),
                          revision=ss.get('revision', None),
                          project=ss.get('project', ''),
 }}}

 How is the build containing the Trigger step being initiated?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2478#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation