[Buildbot-commits] [Buildbot] #2467: source.SVN incorrectly handles repositories with special character in URL
Buildbot trac
trac at buildbot.net
Wed Mar 20 18:40:08 UTC 2013
#2467: source.SVN incorrectly handles repositories with special character in URL
------------------------+--------------------
Reporter: rutsky | Owner:
Type: defect | Status: new
Priority: major | Milestone: 0.8.8
Version: 0.8.7 | Resolution:
Keywords: svn, simple |
------------------------+--------------------
Old description:
> buildbot.steps.source.SVN checks is currently fetched repository is the
> same as set in configuration by running `svn info` and comparing returned
> URL with URL from configuration (see _sourcedirIsUpdatable()).
>
> If URL in configuration contains special characters or spaces, like
> "svn://example.org/my repo/", `svn info` returns URL in internal
> "canonical" form: "svn://example.org/my%20repo/". So Buildbot always
> thinks that repository changed, removes it and checks out again.
>
> As workaround you can specify URL in Buildbot configuration in canonical
> form: "svn://example.org/my%20repo/".
>
> P.S. Also, why parsing `svn info` result and not call `svn info --xml`
> and use XML reader?
New description:
buildbot.steps.source.SVN checks is currently fetched repository is the
same as set in configuration by running `svn info` and comparing returned
URL with URL from configuration (see _sourcedirIsUpdatable()).
If URL in configuration contains special characters or spaces, like
"svn://example.org/my repo/", `svn info` returns URL in internal
"canonical" form: "svn://example.org/my%20repo/". So Buildbot always
thinks that repository changed, removes it and checks out again.
As workaround you can specify URL in Buildbot configuration in canonical
form: "svn://example.org/my%20repo/".
P.S. Also, why parsing `svn info` result and not call `svn info --xml` and
use XML reader?
--
Comment (by dustin):
But that canonicalize function is *not* simple!
--
Ticket URL: <http://trac.buildbot.net/ticket/2467#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list