[Buildbot-commits] [Buildbot] #708: Incorporate bzr_poller.py and add more docs

[Buildbot trac]

#708: Incorporate bzr_poller.py and add more docs
-----------------------------+--------------------
Reporter:  dustin            |       Owner:
    Type:  enhancement       |      Status:  new
Priority:  patches-accepted  |   Milestone:  0.8.+
 Version:  master            |  Resolution:
Keywords:  bzr               |
-----------------------------+--------------------

Comment (by gracinet):

 Current status (branch bzrpoller of my github fork)

 * This !BzrPoller passed a real-life test
 * I have a first working unit test, relying on ```mock``` to replace
 bzrlib.

 I'd need some adviced on the preferred way to proceed with those tests,
 here. Gary provided a separate ```generate_change``` function, primarily
 for code factorization between the hook and the poller.

 The current (draft) unit tests replace all ```bzrlib```` calls, including
 those made by this ```generate_change``` by mocks. That's a bit cumbersome
 for the writer and the reader, and I don't think there's much value in
 going down to that detail: if ```bzrlib`` API changes, the tests won't see
 it anyway (of course).

 We could very well mock the ```generate_change``` function instead. What
 do you think ?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/708#comment:21>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation