[Buildbot-commits] [Buildbot] #1854: FileUpload never times out

[Buildbot trac]

#1854: FileUpload never times out
-----------------------------------------+---------------------
Reporter:  exarkun                       |       Owner:  juanl
    Type:  defect                        |      Status:  closed
Priority:  critical                      |   Milestone:  0.8.+
 Version:  0.8.2                         |  Resolution:  fixed
Keywords:  transfer master-slave sprint  |
-----------------------------------------+---------------------
Changes (by dustin):

 * status:  accepted => closed
 * resolution:   => fixed


Old description:

> If a slave loses its connection to the master without sending a FIN or
> RST (eg, because of network issues) while a `FileUpload` step is running,
> the build that step is part of never finishes, the master never notices
> the slave disconnected, and the slave can never reconnect until the
> master is restarted.  After the master is restarted, the build is left in
> a weird state where it appears incomplete rather than failed.

New description:

 If a slave loses its connection to the master without sending a FIN or RST
 (eg, because of network issues) while a `FileUpload` step is running, the
 build that step is part of never finishes, the master never notices the
 slave disconnected, and the slave can never reconnect until the master is
 restarted.  After the master is restarted, the build is left in a weird
 state where it appears incomplete rather than failed.

--

Comment:

 I don't think there's any "might" involved.  You've demonstrated
 conclusively that this is no longer a problem.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1854#comment:14>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation