[Buildbot-commits] [buildbot/buildbot] c4a40d: unit test config.ConfigErrors.__str__() method

GitHub noreply at github.com
Mon Mar 11 13:15:46 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: c4a40d30240bdc9f1237ac9ba0083d69dc9ffdf1
      https://github.com/buildbot/buildbot/commit/c4a40d30240bdc9f1237ac9ba0083d69dc9ffdf1
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  unit test config.ConfigErrors.__str__() method

Added unit test on config.ConfigErrors.__str__() method


  Commit: 1beffde8ee4f703023529adbcba692fc08743818
      https://github.com/buildbot/buildbot/commit/1beffde8ee4f703023529adbcba692fc08743818
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  unit test configure file open error in MasterConfig.loadConfig()

Added a unit test that simulates IOError when opening configure file in
config.MasterConfig.loadConfig(). Check that the expected ConfigErrors
exception is rised.


  Commit: 7cc54916bdfb792e83bb4884ed1271bdc7d9eea7
      https://github.com/buildbot/buildbot/commit/7cc54916bdfb792e83bb4884ed1271bdc7d9eea7
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/config.py

  Log Message:
  -----------
  removed unreachable code in config.MasterConfig.loadConfig()

The call to error() with global _errors set to None, will raise
an exception. Thus following 'raise errors' is never reached.


  Commit: 31b3c1e39fa377e607a5f38ebeeb21bfc50811cc
      https://github.com/buildbot/buildbot/commit/31b3c1e39fa377e607a5f38ebeeb21bfc50811cc
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  unit test on loading 'codebaseGenerator' master parameter

Added unit tests on code in buildbot.config.MasterConfig.load_global()
that loads 'codebaseGenerator' master configuration parameter. Test
both loading correct parameter and invalid.


  Commit: ba0529e179af616f6927189fba579b2476188280
      https://github.com/buildbot/buildbot/commit/ba0529e179af616f6927189fba579b2476188280
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  unit test error paths in MasterConfig.load_status()

Test that invalid 'status' option in master config file is
handled properly.


  Commit: 628eaee6c5cfc4ab83972e7fd59fb22c8acb586f
      https://github.com/buildbot/buildbot/commit/628eaee6c5cfc4ab83972e7fd59fb22c8acb586f
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  unit test error paths in BuilderConfig.__init__()

Test that invalid nextSlave, nextBuild, canStartBuild and
env arguments to BuilderConfig constructor are handled properly.


  Commit: d54df6145022389562ac85054fe2590f61c9f4ab
      https://github.com/buildbot/buildbot/commit/d54df6145022389562ac85054fe2590f61c9f4ab
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-05 (Tue, 05 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  updated buildbot.config.MasterConfig.check_locks() unit tests

Updated unit tests of buildbot.config.MasterConfig.check_locks()
method to use lock objects wrapped inside LockAccess objects.
Nowadays this is the recommended style of specifying locks in the
documentation.

Add one new unit test to check that using 'bare' lock objects still
works.


  Commit: 130bbad600dfcd65d9599bb8ab325b3a5381abaf
      https://github.com/buildbot/buildbot/commit/130bbad600dfcd65d9599bb8ab325b3a5381abaf
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  use self.patch() to override open() in unit test

Using TestCase.patch() method to override buildin open() in a unit test is
much cleaner.


  Commit: acfa823027400c8e5732242f6fc2d4d4778ce86b
      https://github.com/buildbot/buildbot/commit/acfa823027400c8e5732242f6fc2d4d4778ce86b
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-03-11 (Mon, 11 Mar 2013)

  Changed paths:
    M master/buildbot/config.py
    M master/buildbot/test/unit/test_config.py

  Log Message:
  -----------
  Merge branch 'config-unit-tests' of git://github.com/elmirjagudin/buildbot


  Commit: ede1de82c209e4b924f0a1d594371016a3879876
      https://github.com/buildbot/buildbot/commit/ede1de82c209e4b924f0a1d594371016a3879876
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-03-11 (Mon, 11 Mar 2013)

  Changed paths:
    M master/contrib/post_build_request.py

  Log Message:
  -----------
  fix typo


Compare: https://github.com/buildbot/buildbot/compare/16d87bb28817...ede1de82c209


More information about the Commits mailing list