[Buildbot-commits] [Buildbot] #2469: Can't have two HgPoller instances for two branches of the same repo

[Buildbot]

#2469: Can't have two HgPoller instances for two branches of the same repo
----------------------+-----------------------
Reporter:  gracinet   |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.7p1    |   Keywords:
----------------------+-----------------------
 This is because the service name is only made of the url, not of the
 combination of url and branch, and twisted does not allow that:

 {{{
  --- <exception caught here> ---
           File "/home/buildbot/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 1071, in _inlineCallbacks
             result = g.send(result)
           File "/home/buildbot/lib/python2.6/site-
 packages/buildbot/changes/manager.py", line 62, in reconfigService
             src.setServiceParent(self)
           File "/home/buildbot/lib/python2.6/site-
 packages/twisted/application/service.py", line 186, in setServiceParent
             self.parent.addService(self)
           File "/home/buildbot/lib/python2.6/site-
 packages/twisted/application/service.py", line 303, in addService
             " '%s'" % service.name)
         exceptions.RuntimeError: cannot have two services with same name
 'http://myrepo.example/'
 }}}

 Fix is really easy : just combine ```repourl``` and ```branch``` to get
 the service name.
 No time to do it properly right now, noted for future.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2469>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation