[Buildbot-commits] [buildbot/buildbot] a151c3: db_poller isn't getting adjusted

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: a151c353222214182e6b016155e7788c33e1deeb
      https://github.com/buildbot/buildbot/commit/a151c353222214182e6b016155e7788c33e1deeb
  Author: Maria <mariangemarcano at gmail.com>
  Date:   2013-03-06 (Wed, 06 Mar 2013)

  Changed paths:
    M master/buildbot/master.py

  Log Message:
  -----------
  db_poller isn't getting adjusted

At the time we call def reconfigService(self, new_config):
self.config.db['db_poll_interval']  has the new value already assigned,
so this comparison is never true
https://github.com/buildbot/buildbot/blob/master/master/buildbot/master.py#L303
if (self.config.db['db_poll_interval']   !=
new_config.db['db_poll_interval'])

and the db_poller isn't getting adjusted, changed the reconfigService
implementations to store initial configuration in object attributes, and
compare those attributes to new_config.


  Commit: df705bf445f906d0bab74b0aa5bcbc1f4ac01081
      https://github.com/buildbot/buildbot/commit/df705bf445f906d0bab74b0aa5bcbc1f4ac01081
  Author: mariangemarcano <mariangemarcano at gmail.com>
  Date:   2013-03-06 (Wed, 06 Mar 2013)

  Changed paths:
    M master/buildbot/master.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  code review fixes

- change configured_url -> configured_db_url
- put all of the config-handling code in reconfigService
- add release notes


  Commit: ceae3951e740d7bc948cd7478c017394a11991d7
      https://github.com/buildbot/buildbot/commit/ceae3951e740d7bc948cd7478c017394a11991d7
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-03-07 (Thu, 07 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_master.py

  Log Message:
  -----------
  change tests to correspond


  Commit: 8e9433a024a448e4a65d3b154498ca21b7e0107c
      https://github.com/buildbot/buildbot/commit/8e9433a024a448e4a65d3b154498ca21b7e0107c
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-03-07 (Thu, 07 Mar 2013)

  Changed paths:
    M master/buildbot/master.py
    M master/buildbot/test/unit/test_master.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge branch 'pull639'


Compare: https://github.com/buildbot/buildbot/compare/ce98565e187b...8e9433a024a4