[Buildbot-commits] [Buildbot] #998: better handling for tags in changesources

[Buildbot]

#998: better handling for tags in changesources
------------------------------+--------------------
Reporter:  chrb               |       Owner:
    Type:  enhancement        |      Status:  new
Priority:  major              |   Milestone:  1.0.+
 Version:  0.8.1              |  Resolution:
Keywords:  git, hg, svn, git  |
------------------------------+--------------------
Changes (by dustin):

 * keywords:  git, hg, svn => git, hg, svn, git


Old description:

> git_buildbot.py currently ignores tags ("Ignoring refname
> `refs/tags/TEST': Not a branch"). We have a build process that generates
> package versions from tags, so when tags are pushed the packages should
> be rebuilt. I hacked git_buildbot.py to do this:
>
> {{{
>         m = re.match(r"^refs\/tags\/(.+)$", refname)
>         if m:
>             logging.info("Tag detected: %s"%refname)
>             c = {'revision': m.group(1),
>                  'comments': 'tag %s'%m.group(1),
>                  'branch': m.group(1),
>             }
>             c['category'] = 'default'
>             c['repository'] = unicode(repository, encoding=encoding)
>             c['who'] = 'The Tagger'
>             c['files'] = ['none']
>             changes.append(c)
>         else:
> }}}
>
> Obviously hardcoding "commit" details like this is a poor solution but it
> works. It would be nice to have proper support for tags in git_buildbot,
> so that the correct commit details are passed on.

New description:

 git_buildbot.py currently ignores tags ("Ignoring refname
 `refs/tags/TEST': Not a branch"). We have a build process that generates
 package versions from tags, so when tags are pushed the packages should be
 rebuilt. I hacked git_buildbot.py to do this:

 {{{
         m = re.match(r"^refs\/tags\/(.+)$", refname)
         if m:
             logging.info("Tag detected: %s"%refname)
             c = {'revision': m.group(1),
                  'comments': 'tag %s'%m.group(1),
                  'branch': m.group(1),
             }
             c['category'] = 'default'
             c['repository'] = unicode(repository, encoding=encoding)
             c['who'] = 'The Tagger'
             c['files'] = ['none']
             changes.append(c)
         else:
 }}}

 Obviously hardcoding "commit" details like this is a poor solution but it
 works. It would be nice to have proper support for tags in git_buildbot,
 so that the correct commit details are passed on.


 Dupes:
  * #2374

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/998#comment:10>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation