From nobody at buildbot.net Fri Mar 1 00:45:44 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 00:45:44 -0000 Subject: [Buildbot-commits] [Buildbot] #339: inline logs in HTML Emails and capture errors in Compile In-Reply-To: <035.703840e8341f8372589deee485b8783c@buildbot.net> References: <035.703840e8341f8372589deee485b8783c@buildbot.net> Message-ID: <050.8e4673d8dafc7e68d0e105df958e9a22@buildbot.net> #339: inline logs in HTML Emails and capture errors in Compile -----------------------------+--------------------- Reporter: tzz | Owner: dustin Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.7.8 | Resolution: Keywords: mail | -----------------------------+--------------------- Changes (by dustin): * priority: minor => patches-accepted -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 00:48:50 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 00:48:50 -0000 Subject: [Buildbot-commits] [Buildbot] #356: doxygen build step In-Reply-To: <039.477365ad82f2af20c2af95d45a24fbf6@buildbot.net> References: <039.477365ad82f2af20c2af95d45a24fbf6@buildbot.net> Message-ID: <054.42c8e4af798283734558fbed74b5c7b4@buildbot.net> #356: doxygen build step -----------------------------+----------------------- Reporter: ashcrow | Owner: ashcrow Type: enhancement | Status: assigned Priority: patches-accepted | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: | -----------------------------+----------------------- Changes (by dustin): * priority: minor => patches-accepted -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:08:48 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:08:48 -0000 Subject: [Buildbot-commits] [Buildbot] #795: Allow switching ETA estimation method in master.cfg In-Reply-To: <039.cf274d0a325fcbe0b3a585861055d51d@buildbot.net> References: <039.cf274d0a325fcbe0b3a585861055d51d@buildbot.net> Message-ID: <054.a8a9b97e8c7b5c910fdd00c269fd63be@buildbot.net> #795: Allow switching ETA estimation method in master.cfg -----------------------------+---------------------- Reporter: toinbis | Owner: toinbis Type: enhancement | Status: closed Priority: patches-accepted | Milestone: 1.0.+ Version: 0.8.0 | Resolution: fixed Keywords: web | -----------------------------+---------------------- Changes (by dustin): * priority: minor => patches-accepted * status: assigned => closed * resolution: => fixed * milestone: 0.8.+ => 1.0.+ Comment: This is a cool idea, but pretty futuristic. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:07:26 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:07:26 -0000 Subject: [Buildbot-commits] [Buildbot] #751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out In-Reply-To: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net> References: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net> Message-ID: <054.19a79b2aa1e2514d3a11868bc9e15e19@buildbot.net> #751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out -------------------------+----------------------- Reporter: Fabrice | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: kill, sprint | -------------------------+----------------------- Changes (by dustin): * keywords: kill => kill, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:09:35 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:09:35 -0000 Subject: [Buildbot-commits] [Buildbot] #796: Implement UI elements: build's progress bar & build time charts In-Reply-To: <039.5288826bced2ec68e6d01d7e72e0c127@buildbot.net> References: <039.5288826bced2ec68e6d01d7e72e0c127@buildbot.net> Message-ID: <054.7aaf722acef679268dc18584affec703@buildbot.net> #796: Implement UI elements: build's progress bar & build time charts ------------------------+----------------------- Reporter: toinbis | Owner: toinbis Type: enhancement | Status: assigned Priority: minor | Milestone: 1.0.+ Version: 0.8.0 | Resolution: Keywords: web | ------------------------+----------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ Comment: This would be a cool addition to the JS UI, but probably not for a long time.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:24:46 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:24:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) In-Reply-To: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> References: <039.7e16ba417216f6a0b728cbcfebbff56e@buildbot.net> Message-ID: <054.3ef792a3d93d3f47e9113dd0d6492677@buildbot.net> #1703: Use a shorter timeout for old slave disconnection (perhaps based on configuration) -------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: master-slave | -------------------------+-------------------- Changes (by dustin): * keywords: => master-slave -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:26:12 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:26:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1848: Cookies to remember web usernames In-Reply-To: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> References: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> Message-ID: <056.ff59db8c2d3ac8c8183ab6818e2c6523@buildbot.net> #1848: Cookies to remember web usernames ------------------------+----------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: web, users | ------------------------+----------------------- Changes (by dustin): * keywords: web => web, users * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:27:17 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:27:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1950: EC2 docs need updating to new AWS terminology In-Reply-To: <038.804edab703f26dcac940eae9cbb6d1c5@buildbot.net> References: <038.804edab703f26dcac940eae9cbb6d1c5@buildbot.net> Message-ID: <053.340b5fc387e60124f9e4bf53ea84fda0@buildbot.net> #1950: EC2 docs need updating to new AWS terminology ---------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: docs, virtualization | ---------------------------------+-------------------- Changes (by dustin): * keywords: docs => docs, virtualization Comment: Sigh.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:25:45 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:25:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1769: Try schedulers do not allow you to set patch subdir In-Reply-To: <038.0223e4c4db105277a548f1d6eda5d860@buildbot.net> References: <038.0223e4c4db105277a548f1d6eda5d860@buildbot.net> Message-ID: <053.40b929dd99e28ce285018e47c1a4dc82@buildbot.net> #1769: Try schedulers do not allow you to set patch subdir --------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: wontfix Keywords: try | --------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: see #896 - no need to re-implement subdirs in that version. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:26:48 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:26:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1887: on builders page, please show step(s) in progress In-Reply-To: <035.c0ba9c705b35745f093cd7d2ee286f20@buildbot.net> References: <035.c0ba9c705b35745f093cd7d2ee286f20@buildbot.net> Message-ID: <050.09e6e694404180f9fa26066d8c6ae6e6@buildbot.net> #1887: on builders page, please show step(s) in progress ------------------------+-------------------- Reporter: gg0 | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.3 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * keywords: => web * milestone: 0.8.+ => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:26:35 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:26:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1868: Support for Dummy slaves and/or Builders that don't require slaves In-Reply-To: <038.760e4461d05bed406fe50982bba74537@buildbot.net> References: <038.760e4461d05bed406fe50982bba74537@buildbot.net> Message-ID: <053.24dc2f9486ad229f54a90ab4bae7b75b@buildbot.net> #1868: Support for Dummy slaves and/or Builders that don't require slaves ------------------------+-------------------- Reporter: catlee | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 1.0.+ Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.+ => 1.0.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:29:19 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:29:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1968: Multi-prefix support for PBChangeSource In-Reply-To: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> References: <037.6e39d558ae82ef5d43aec9db24951f82@buildbot.net> Message-ID: <052.a369249b0f86f0fab12f26e1fa2dff64@buildbot.net> #1968: Multi-prefix support for PBChangeSource ------------------------+---------------------- Reporter: LoTek | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: wontfix Keywords: try | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: I think this would be better accomplished with a smarter svn hook and codebases now. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:13:23 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:13:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2047: incorporate buildbot.master.LogRotation into buildbot.config In-Reply-To: <038.30a5cc03c86d7fd70209d2f44c1c9c3e@buildbot.net> References: <038.30a5cc03c86d7fd70209d2f44c1c9c3e@buildbot.net> Message-ID: <053.dba6147b4e89e6051686bc67717ed9fa@buildbot.net> #2047: incorporate buildbot.master.LogRotation into buildbot.config ------------------------+---------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: invalid Keywords: sprint | ------------------------+---------------------- Changes (by dustin): * status: assigned => closed * resolution: => invalid Comment: Come to think of it, no - this object exists as a way to get config from buildbot.tac into the buildmaster. It's a not very subtle, but it's not the same as !BuildbotConfig, and I can't think of a more subtle way of handling it, especially without changing users' existing `buildbot.tac` files. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:06:10 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:06:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2032: Log tracebacks in separate logfile (not in twistd.log) In-Reply-To: <040.44f394313b3e8aab92ed7143cac39f9c@buildbot.net> References: <040.44f394313b3e8aab92ed7143cac39f9c@buildbot.net> Message-ID: <055.4ce43c74cd69bbeaddf708e7e6ea0769@buildbot.net> #2032: Log tracebacks in separate logfile (not in twistd.log) -----------------------------+-------------------- Reporter: bdbaddog | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: metrics | -----------------------------+-------------------- Changes (by dustin): * keywords: => metrics * priority: minor => patches-accepted Comment: This would be cool to handle via metrics alerts. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:08:13 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:08:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2045: Implicit limit of 1000 builders per slave In-Reply-To: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> References: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net> Message-ID: <050.6b4960d16425d3185ff810816e8bc83b@buildbot.net> #2045: Implicit limit of 1000 builders per slave -------------------------+------------------------- Reporter: xrg | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.4 | Resolution: worksforme Keywords: master-slave | -------------------------+------------------------- Changes (by dustin): * keywords: performance => master-slave * status: new => closed * resolution: => worksforme Comment: This workaround is useful for folks running into this limit. The real fix is a new master/slave protocol. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:08:30 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:08:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2047: incorporate buildbot.master.LogRotation into buildbot.config In-Reply-To: <038.30a5cc03c86d7fd70209d2f44c1c9c3e@buildbot.net> References: <038.30a5cc03c86d7fd70209d2f44c1c9c3e@buildbot.net> Message-ID: <053.fd9ed5d2d6827dee392d0c46a532638c@buildbot.net> #2047: incorporate buildbot.master.LogRotation into buildbot.config ------------------------+----------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: assigned Priority: minor | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: sprint | ------------------------+----------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 00:51:02 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 00:51:02 -0000 Subject: [Buildbot-commits] [Buildbot] #738: Record true start/end time for build steps In-Reply-To: <038.6ff50e5b95ac721c4035f5bb0017b756@buildbot.net> References: <038.6ff50e5b95ac721c4035f5bb0017b756@buildbot.net> Message-ID: <053.7aadc7e0709604d8ecff37a97a784499@buildbot.net> #738: Record true start/end time for build steps ------------------------+----------------------- Reporter: catlee | Owner: toinbis Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.+ Version: | Resolution: Keywords: sprint | ------------------------+----------------------- Changes (by dustin): * keywords: => sprint * milestone: 0.8.+ => 0.9.+ Comment: This would involve some protocol changes, so some care will be required in the implementation. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 02:57:12 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 02:57:12 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.2a8aacfdcccdd74a4fd5df306c2985cc@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Description changed by dustin: Old description: > We have a "try" client defined which looks for a patch in a local > repository on a developer's system, patches it up, and submits it to > Buildbot. It's very ad-hoc, isn't very configurable, and hasn't gotten a > lot of love. > > Now that we have a force scheduler, the better solution is for the try > client to talk to a force scheduler, preferably using HTTP. The client > should also capture and send e-mail address of the submitter so that > notifications can be sent. > > This allows lots of flexibility on the master side: users can set up as > many force schedulers as they like, with different builders, properties, > permissions, and so on. > > To make this project a summer's worth, it should aim to implement: > * a new try client > * improved support for DVCS's, where patches aren't required, but where > the client must send a repository > * protocol support in or for the force scheduler > * per-scheduler authentication/authorization > * migration information for users of the existing try functionality New description: We have a "try" client defined which looks for a patch in a local repository on a developer's system, patches it up, and submits it to Buildbot. It's very ad-hoc, isn't very configurable, and hasn't gotten a lot of love. Now that we have a force scheduler, the better solution is for the try client to talk to a force scheduler, preferably using HTTP. The client should also capture and send e-mail address of the submitter so that notifications can be sent. This allows lots of flexibility on the master side: users can set up as many force schedulers as they like, with different builders, properties, permissions, and so on. =scope= To make this project a summer's worth, it should aim to implement: * a new try client * improved support for DVCS's, where patches aren't required, but where the client must send a repository * protocol support in or for the force scheduler * per-scheduler authentication/authorization * migration information for users of the existing try functionality -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 02:57:42 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 02:57:42 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.65e231c6b18505e86ae2aff53563c4c7@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Description changed by dustin: Old description: > We have a "try" client defined which looks for a patch in a local > repository on a developer's system, patches it up, and submits it to > Buildbot. It's very ad-hoc, isn't very configurable, and hasn't gotten a > lot of love. > > Now that we have a force scheduler, the better solution is for the try > client to talk to a force scheduler, preferably using HTTP. The client > should also capture and send e-mail address of the submitter so that > notifications can be sent. > > This allows lots of flexibility on the master side: users can set up as > many force schedulers as they like, with different builders, properties, > permissions, and so on. > > =scope= > > To make this project a summer's worth, it should aim to implement: > * a new try client > * improved support for DVCS's, where patches aren't required, but where > the client must send a repository > * protocol support in or for the force scheduler > * per-scheduler authentication/authorization > * migration information for users of the existing try functionality New description: We have a "try" client defined which looks for a patch in a local repository on a developer's system, patches it up, and submits it to Buildbot. It's very ad-hoc, isn't very configurable, and hasn't gotten a lot of love. Now that we have a force scheduler, the better solution is for the try client to talk to a force scheduler, preferably using HTTP. The client should also capture and send e-mail address of the submitter so that notifications can be sent. This allows lots of flexibility on the master side: users can set up as many force schedulers as they like, with different builders, properties, permissions, and so on. == scope == To make this project a summer's worth, it should aim to implement: * a new try client * improved support for DVCS's, where patches aren't required, but where the client must send a repository * protocol support in or for the force scheduler * per-scheduler authentication/authorization * migration information for users of the existing try functionality -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:16:27 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:16:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1848: Cookies to remember web usernames In-Reply-To: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> References: <041.c7ad4e6001681bf1a08277684316ffbb@buildbot.net> Message-ID: <056.6c805d6d17d01eabf3c9795c2a4b7336@buildbot.net> #1848: Cookies to remember web usernames ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: fixed Keywords: web, users | ------------------------+--------------------- Changes (by dustin): * status: reopened => closed * resolution: => fixed Comment: That's #1873. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:06:24 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:06:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1997: Gather metrics on query times In-Reply-To: <038.4bd8ecf10d4329234239e94424221dc5@buildbot.net> References: <038.4bd8ecf10d4329234239e94424221dc5@buildbot.net> Message-ID: <053.0cc8c64c22fa6f2c7a4cdf5f89106802@buildbot.net> #1997: Gather metrics on query times ----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: metrics, sprint | ----------------------------+-------------------- Changes (by dustin): * keywords: metrics => metrics, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:29:54 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:29:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2315: test_master.py tests change singal handling but don't restore state afterwards. In-Reply-To: <042.84da69ac6d596210034004d2e7f64578@buildbot.net> References: <042.84da69ac6d596210034004d2e7f64578@buildbot.net> Message-ID: <057.5ffb4c678f53d84f044f647df1a92b47@buildbot.net> #2315: test_master.py tests change singal handling but don't restore state afterwards. --------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: tests, sprint | --------------------------+-------------------- Changes (by dustin): * keywords: tests => tests, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:40:45 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:40:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2459: full metrics support In-Reply-To: <038.928d5399b234c0e08857ca379b828e1a@buildbot.net> References: <038.928d5399b234c0e08857ca379b828e1a@buildbot.net> Message-ID: <053.911f50e9aef96f2c17a2c3dc909d8497@buildbot.net> #2459: full metrics support -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: metrics | -------------------------+-------------------- Changes (by dustin): * type: enhancement => project-idea -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:20:15 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:20:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2112: Adding a large batch of changes seems to run at about 7 changes/s. In-Reply-To: <042.387ab9bf04f6b1118c006875a47221cf@buildbot.net> References: <042.387ab9bf04f6b1118c006875a47221cf@buildbot.net> Message-ID: <057.5d12d8da4095ce534ab8b5379adb2cbc@buildbot.net> #2112: Adding a large batch of changes seems to run at about 7 changes/s. --------------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: master | Resolution: Keywords: performance, sprint | --------------------------------+-------------------- Changes (by dustin): * keywords: performance => performance, sprint * milestone: 0.8.+ => 0.9.+ Comment: Let's measure this in nine and see if there's anything that can be done. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:42:24 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:42:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2416: Slave backward compatibility is not documented In-Reply-To: <041.8adb5e221f184aefcd2f70688df6d6a8@buildbot.net> References: <041.8adb5e221f184aefcd2f70688df6d6a8@buildbot.net> Message-ID: <056.8dc35b248f56a7df4ddb9f84fedade4a@buildbot.net> #2416: Slave backward compatibility is not documented -----------------------------+-------------------- Reporter: techtonik | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: docs | -----------------------------+-------------------- Changes (by dustin): * keywords: => docs -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:04:08 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:04:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2459: full metrics support Message-ID: <038.928d5399b234c0e08857ca379b828e1a@buildbot.net> #2459: full metrics support ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Keywords: metrics ------------------------+--------------------- A while back, Chris AtLee added some nice metrics code to Buildbot (#1945 / `master/buildbot/process/metrics.py`). However, the metrics it gathers are not accessible anywhere. The system gathers counts, times, running averages, and "alarms". == scope == This project would involve expanding that support, adding access to the metrics data via the Data API, and adding a flexible system to notify admins on alarms. It would also be helpful to alarms support a little more flexible, so it can be used to handle everything from logged tracebacks on a master to oversized builder queues to disconnected slaves. See the bugs below for related tasks. == Relevant Bugs == [[TicketQuery(order=priority,status!=closed,keywords~=metrics,format=table,col=summary|owner)]] -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:33:00 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:33:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2360: Buildbot updates to wrong SVN version In-Reply-To: <038.11009f86c0b3735bfb4e7e525859d2a7@buildbot.net> References: <038.11009f86c0b3735bfb4e7e525859d2a7@buildbot.net> Message-ID: <053.0e0a3c186f7b98257c1b7b3b5de41019@buildbot.net> #2360: Buildbot updates to wrong SVN version ----------------------------+--------------------- Reporter: flashm | Owner: Type: support-request | Status: closed Priority: major | Milestone: 0.8.7 Version: 0.8.6p1 | Resolution: fixed Keywords: svn projrepo | ----------------------------+--------------------- Changes (by dustin): * status: reopened => closed * type: defect => support-request * resolution: => fixed Comment: Your main trunk and externals should be different codebases. Then, when a change arrives for the external (e.g., 301), the schedulers will trigger a build against trunk=8000 (or latest or however you configure it) and external=301. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:36:52 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:36:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2381: SVN export method can't export single files In-Reply-To: <039.46a2f1fea1e274ea3c1f2b0330ffb35a@buildbot.net> References: <039.46a2f1fea1e274ea3c1f2b0330ffb35a@buildbot.net> Message-ID: <054.cd3d773bb40ce07c017be4b0c2c56e38@buildbot.net> #2381: SVN export method can't export single files ------------------------+-------------------- Reporter: Quentin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: svn, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: svn => svn, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:38:43 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:38:43 -0000 Subject: [Buildbot-commits] [Buildbot] #708: Incorporate bzr_poller.py and add more docs In-Reply-To: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> References: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> Message-ID: <053.abd09aa275e4cdcb789ed7bef0dc35e8@buildbot.net> #708: Incorporate bzr_poller.py and add more docs -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: master | Resolution: Keywords: bzr | -----------------------------+-------------------- Comment (by dustin): gracinet, any update here? Having asked for Gary's help, I think we have an obligation to see this through! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:36:26 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:36:26 -0000 Subject: [Buildbot-commits] [Buildbot] #998: better handling for tags in changesources In-Reply-To: <036.92225bad6a92f142c6531bf660f7d90a@buildbot.net> References: <036.92225bad6a92f142c6531bf660f7d90a@buildbot.net> Message-ID: <051.833c0a3f8713d680a30bc9a5471077bb@buildbot.net> #998: better handling for tags in changesources ------------------------------+-------------------- Reporter: chrb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.1 | Resolution: Keywords: git, hg, svn, git | ------------------------------+-------------------- Changes (by dustin): * keywords: git, hg, svn => git, hg, svn, git Old description: > git_buildbot.py currently ignores tags ("Ignoring refname > `refs/tags/TEST': Not a branch"). We have a build process that generates > package versions from tags, so when tags are pushed the packages should > be rebuilt. I hacked git_buildbot.py to do this: > > {{{ > m = re.match(r"^refs\/tags\/(.+)$", refname) > if m: > logging.info("Tag detected: %s"%refname) > c = {'revision': m.group(1), > 'comments': 'tag %s'%m.group(1), > 'branch': m.group(1), > } > c['category'] = 'default' > c['repository'] = unicode(repository, encoding=encoding) > c['who'] = 'The Tagger' > c['files'] = ['none'] > changes.append(c) > else: > }}} > > Obviously hardcoding "commit" details like this is a poor solution but it > works. It would be nice to have proper support for tags in git_buildbot, > so that the correct commit details are passed on. New description: git_buildbot.py currently ignores tags ("Ignoring refname `refs/tags/TEST': Not a branch"). We have a build process that generates package versions from tags, so when tags are pushed the packages should be rebuilt. I hacked git_buildbot.py to do this: {{{ m = re.match(r"^refs\/tags\/(.+)$", refname) if m: logging.info("Tag detected: %s"%refname) c = {'revision': m.group(1), 'comments': 'tag %s'%m.group(1), 'branch': m.group(1), } c['category'] = 'default' c['repository'] = unicode(repository, encoding=encoding) c['who'] = 'The Tagger' c['files'] = ['none'] changes.append(c) else: }}} Obviously hardcoding "commit" details like this is a poor solution but it works. It would be nice to have proper support for tags in git_buildbot, so that the correct commit details are passed on. Dupes: * #2374 -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:37:23 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:37:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2422: SVN checkout can't get "Last Changed Rev". In-Reply-To: <045.46732d2a661fca799a762766e8790c02@buildbot.net> References: <045.46732d2a661fca799a762766e8790c02@buildbot.net> Message-ID: <060.5f6b057fd8b70e28498dc0fdd2c76cd3@buildbot.net> #2422: SVN checkout can't get "Last Changed Rev". --------------------------+------------------------- Reporter: khamilton2012 | Owner: jaredgrubb Type: enhancement | Status: accepted Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, sprint | --------------------------+------------------------- Changes (by dustin): * keywords: svn => svn, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:47:11 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:47:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.27a1af7408ebb7361938203686601c9b@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+------------------------- Reporter: dank | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: worksforme Keywords: | ------------------------+------------------------- Comment (by dank): To be picky, the command I posted is a workaround, not a fix. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:29:41 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:29:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2275: Use encool or the like to generate unicode tests. In-Reply-To: <042.b7146d8bbf73509d6cfb21d5645a4aff@buildbot.net> References: <042.b7146d8bbf73509d6cfb21d5645a4aff@buildbot.net> Message-ID: <057.01093032694a46fa96c00b7df603c3f3@buildbot.net> #2275: Use encool or the like to generate unicode tests. ----------------------------+---------------------- Reporter: tom.prince | Owner: Type: task | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: invalid Keywords: tests, encoding | ----------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => invalid Comment: I'm happy to see encool output used in tests, but I don't think this needs a bug dedicated to the purpose. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:36:02 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:36:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2374: Recognize newly-added git tags as changes In-Reply-To: <035.bcf7acdcdbf754d5bb6273033c7e82f0@buildbot.net> References: <035.bcf7acdcdbf754d5bb6273033c7e82f0@buildbot.net> Message-ID: <050.c27af11b74d6e07988592d5b1bddeedf@buildbot.net> #2374: Recognize newly-added git tags as changes ------------------------+------------------------ Reporter: LRN | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.9.+ Version: | Resolution: duplicate Keywords: git | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate * milestone: 0.8.+ => 0.9.+ Comment: The really hard part here is representing tags correctly as changes. That's #998 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:23:19 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:23:19 -0000 Subject: [Buildbot-commits] [Buildbot] #1066: Notification for backed up builder In-Reply-To: <037.19b9d4ebc2a055115895b0e20f6aeacf@buildbot.net> References: <037.19b9d4ebc2a055115895b0e20f6aeacf@buildbot.net> Message-ID: <052.0c5a6368bf9d304434d74d666ea223d7@buildbot.net> #1066: Notification for backed up builder --------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.2 | Resolution: Keywords: mail, metrics | --------------------------+-------------------- Changes (by dustin): * keywords: mail, => mail, metrics * milestone: 0.8.+ => 0.9.+ Comment: The metrics stuff has basic support for alerts. It'd be great to add more. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:19:27 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:19:27 -0000 Subject: [Buildbot-commits] [Buildbot] #978: Changes should have multiple users In-Reply-To: <041.98f857cbb54e3c6c85643e2bff7f4435@buildbot.net> References: <041.98f857cbb54e3c6c85643e2bff7f4435@buildbot.net> Message-ID: <056.8d70be287f9db3e6f2d0f8116c9eea20@buildbot.net> #978: Changes should have multiple users -----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: git, users | -----------------------+-------------------- Comment (by dustin): c.f. #2048 - it would be good to allow MailNotifier to be selective about who it emails. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:22:36 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:22:36 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler (was: Try should capture and send e-mail address of the submitter so that notifications can be sent) In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.75ceed9ad0682e4df944a86a95c2e05c@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Changes (by dustin): * priority: minor => major * type: enhancement => project-idea * milestone: 0.8.+ => 0.9.+ Old description: > That way, a "try-builder" can be configured to always send notfications > so that each try-submitter knows how the build went. New description: We have a "try" client defined which looks for a patch in a local repository on a developer's system, patches it up, and submits it to Buildbot. It's very ad-hoc, isn't very configurable, and hasn't gotten a lot of love. Now that we have a force scheduler, the better solution is for the try client to talk to a force scheduler, preferably using HTTP. The client should also capture and send e-mail address of the submitter so that notifications can be sent. This allows lots of flexibility on the master side: users can set up as many force schedulers as they like, with different builders, properties, permissions, and so on. To make this project a summer's worth, it should aim to implement: * a new try client * improved support for DVCS's, where patches aren't required, but where the client must send a repository * protocol support in or for the force scheduler * per-scheduler authentication/authorization * migration information for users of the existing try functionality -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:18:57 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:18:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2048: Also adding 'committer' to interested users for MailNotifier In-Reply-To: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net> References: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net> Message-ID: <051.22d0fb278dee918e3c040f8714fd7000@buildbot.net> #2048: Also adding 'committer' to interested users for MailNotifier ------------------------+------------------------ Reporter: deng | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: duplicate Keywords: users | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: dupe #978 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:25:40 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:25:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2222: master-side git step doesn't support reference repos. In-Reply-To: <042.5952e6fcb38fe92bbd45d04287640e0d@buildbot.net> References: <042.5952e6fcb38fe92bbd45d04287640e0d@buildbot.net> Message-ID: <057.c09b7c589d04c88654a5874e6a5388ec@buildbot.net> #2222: master-side git step doesn't support reference repos. -------------------------------------------------+------------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: git simple, master-side-source-steps | sprint | -------------------------------------------------+------------------------- Changes (by dustin): * keywords: git simple, master-side-source-steps => git simple, master- side-source-steps sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:26:38 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:26:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2228: Allow specific ForceSchedulers to be associated with specific WebStatuses. In-Reply-To: <042.cdddcb9d6783b39e9977c48990d4ef8b@buildbot.net> References: <042.cdddcb9d6783b39e9977c48990d4ef8b@buildbot.net> Message-ID: <057.78adc1c3cdbc569444a79df941433337@buildbot.net> #2228: Allow specific ForceSchedulers to be associated with specific WebStatuses. -------------------------------+------------------------- Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.0 Version: master | Resolution: Keywords: web, force, sprint | -------------------------------+------------------------- Changes (by dustin): * milestone: 0.8.+ => 0.9.0 Comment: Actually, I'd rather look at how to represent force schedulers in the data API in nine. Each scheduler should be individually addressable. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:29:00 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:29:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2273: Performance items In-Reply-To: <038.89e3b106fc3acc71d6fe483eed162418@buildbot.net> References: <038.89e3b106fc3acc71d6fe483eed162418@buildbot.net> Message-ID: <053.b4b86dcb82a8e220163292675549c3c1@buildbot.net> #2273: Performance items --------------------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: performance, sprint | --------------------------------+-------------------- Changes (by dustin): * keywords: performance => performance, sprint Comment: `getBuildsForRevision` will go away in nine, so I'm not too worried about that. However, the SVNPoller problem could be fixed. The simplest solution is probably to defer the XML parsing to a thread. That gets UI responsiveness, and may get some parallelism depending on how friendly `parseString` is to the GIL. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:21:52 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:21:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2113: documentation for status_gerrit In-Reply-To: <038.344b9f94a669d5823f7671a264ad3755@buildbot.net> References: <038.344b9f94a669d5823f7671a264ad3755@buildbot.net> Message-ID: <053.4f927724778a90da333ad9bfb989c4d2@buildbot.net> #2113: documentation for status_gerrit ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: It's documented now, as of 0.8.5, although it could certainly use better information. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:24:52 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:24:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2197: Add tests for web change_hooks. In-Reply-To: <042.8d180ec059bf78ad9915a6fbaf12f5ba@buildbot.net> References: <042.8d180ec059bf78ad9915a6fbaf12f5ba@buildbot.net> Message-ID: <057.c647f3ee40c128c31997119ee622933f@buildbot.net> #2197: Add tests for web change_hooks. -------------------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: web, sprint, tests | -------------------------------+-------------------- Changes (by dustin): * keywords: web => web, sprint, tests Comment: This is a good chance for someone to learn a bit about the codebase while writing tests. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 03:23:46 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 03:23:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2123: Changes sent over the wire should be compressed In-Reply-To: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> References: <036.8cceb3fe6a6edabb86fbef518ee3826f@buildbot.net> Message-ID: <051.dd0cf2c1459295ef4dbed0bfaaba0466@buildbot.net> #2123: Changes sent over the wire should be compressed ------------------------+------------------------- Reporter: dank | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: worksforme Keywords: | ------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: This is related both to replacing try with force (#896) and a new master/slave protocol (#2437). Once both of those are fixed, this will be fixed. Until then, the fix here is good enough. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 1 01:12:23 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 01 Mar 2013 01:12:23 -0000 Subject: [Buildbot-commits] [Buildbot] #925: Add branch support to svn_buildbot.py In-Reply-To: <036.7dca884ededb6dafabb569b94ac7c66a@buildbot.net> References: <036.7dca884ededb6dafabb569b94ac7c66a@buildbot.net> Message-ID: <051.96c397a139d8c07aa13f33c269f9a80f@buildbot.net> #925: Add branch support to svn_buildbot.py -------------------------+---------------------- Reporter: Hbot | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.1 | Resolution: invalid Keywords: svn projrepo | -------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => invalid Comment: I'm not even sure what this means. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 1 21:56:22 2013 From: noreply at github.com (GitHub) Date: Fri, 01 Mar 2013 13:56:22 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 5f5c26: fix example Message-ID: <513124069d9af_41318ddaf0769fa@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5f5c26fb8ba84038d3ed5ba70585bb2355e19afc https://github.com/buildbot/buildbot/commit/5f5c26fb8ba84038d3ed5ba70585bb2355e19afc Author: Dustin J. Mitchell Date: 2013-03-01 (Fri, 01 Mar 2013) Changed paths: M master/docs/manual/customization.rst Log Message: ----------- fix example From nobody at buildbot.net Sat Mar 2 15:33:28 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:33:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick up where it left off In-Reply-To: <039.102ff57836737161cb59529187ff8b02@buildbot.net> References: <039.102ff57836737161cb59529187ff8b02@buildbot.net> Message-ID: <054.652ba1401c8fdaf0639f7dae726f4633@buildbot.net> #2061: patch: make P4Poller pick up where it left off -----------------------------+-------------------- Reporter: dberger | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: p4, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: p4 => p4, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:35:14 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:35:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2185: GerritChangeSource: owner email can be missing In-Reply-To: <039.707d8b986e252d06445abb3b8223c4d3@buildbot.net> References: <039.707d8b986e252d06445abb3b8223c4d3@buildbot.net> Message-ID: <054.963b7a4c6ca4725e967da49a7edc6382@buildbot.net> #2185: GerritChangeSource: owner email can be missing -----------------------------+-------------------- Reporter: sanxiyn | Owner: Type: defect | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: gerrit, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: gerrit => gerrit, sprint Comment: This will need some familiarity with gerrit. The fix should come with some tests, too. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:37:45 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:37:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2290: Solaris patch command is not compatible with GNU patch In-Reply-To: <041.03089ee44b943867186c2d8216f12ef2@buildbot.net> References: <041.03089ee44b943867186c2d8216f12ef2@buildbot.net> Message-ID: <056.c48b35bda4de41277068fb5b88544d77@buildbot.net> #2290: Solaris patch command is not compatible with GNU patch -----------------------------+-------------------- Reporter: adiroiban | Owner: Type: defect | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: patch => sprint Comment: The attached pull request needs documentation and tests, and is only for the slave-side command. This should be ported to the master-side source steps as well, and docs/tests added. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:46:42 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:46:42 -0000 Subject: [Buildbot-commits] [Buildbot] #68: New mechanism for monitoring buildbot startup In-Reply-To: <039.592b19946618ac245ee0d41afdd879a6@buildbot.net> References: <039.592b19946618ac245ee0d41afdd879a6@buildbot.net> Message-ID: <054.ebdecf8520c80b6c8fb39248a85009b3@buildbot.net> #68: New mechanism for monitoring buildbot startup --------------------+------------------------- Reporter: joduinn | Owner: tom.prince Type: defect | Status: assigned Priority: major | Milestone: 0.8.8 Version: 0.7.5 | Resolution: Keywords: sprint | --------------------+------------------------- Comment (by dustin): The fix here is, I think, for the startup script to set up an IPC channel with the new process, and then use that to get status information from the master. That channel could be a PB listener on a random port, listening only on 127.0.0.1, plus a random username/password. When the master first starts up, it would connect to this port and authenticate, then send both Twisted log information and state changes (starting, configuring, running, failed, etc.) to the script. This could work on most systems, although it will run afoul of the Windows firewall if python.exe is not given an exclusion. For that, I think we could add a '--no-wait' option that simply starts the master and skips the rest. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:48:52 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:48:52 -0000 Subject: [Buildbot-commits] [Buildbot] #75: IM status targets In-Reply-To: <038.077cde644a25b8ae82acb2a21287d86e@buildbot.net> References: <038.077cde644a25b8ae82acb2a21287d86e@buildbot.net> Message-ID: <053.9c36acff71de597d2fdc397fc467bab1@buildbot.net> #75: IM status targets -----------------------------+--------------------- Reporter: warner | Owner: warner Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.9.+ Version: 0.7.5 | Resolution: Keywords: irc | -----------------------------+--------------------- Changes (by dustin): * priority: major => patches-accepted * milestone: 0.8.8 => 0.9.+ Comment: As mentioned in the pull req, at this point this should be implemented in nine. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:49:28 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:49:28 -0000 Subject: [Buildbot-commits] [Buildbot] #538: web server does not use gzip encoding In-Reply-To: <040.7f2cf6f4d9dd1ba3c2c3b9d78a2b3394@buildbot.net> References: <040.7f2cf6f4d9dd1ba3c2c3b9d78a2b3394@buildbot.net> Message-ID: <055.9ed3539b15894af316d24e74a0817b90@buildbot.net> #538: web server does not use gzip encoding ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: web, sprint | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.8 => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:50:03 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:50:03 -0000 Subject: [Buildbot-commits] [Buildbot] #950: link rebuild pages to the build that they were a rebuild of In-Reply-To: <037.72a453f175e110a22dc5fd3fbe4a0dcc@buildbot.net> References: <037.72a453f175e110a22dc5fd3fbe4a0dcc@buildbot.net> Message-ID: <052.61237509b53e5a35cf516682f262d58b@buildbot.net> #950: link rebuild pages to the build that they were a rebuild of ------------------------+-------------------- Reporter: zooko | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.1 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.8 => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:50:51 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:50:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1038: Audit TimerService / other looping calls In-Reply-To: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> References: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> Message-ID: <053.262c1519ff048dbea65b28f37c6baba7@buildbot.net> #1038: Audit TimerService / other looping calls -------------------+-------------------- Reporter: catlee | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.1 | Resolution: Keywords: simple | -------------------+-------------------- Comment (by dustin): tom, is there anything left here? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:53:15 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:53:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1688: there should be some way to retry builds that fail in setupBuild without submitting new Changes. In-Reply-To: <040.cf0839495386f26c7888290ad64ef90a@buildbot.net> References: <040.cf0839495386f26c7888290ad64ef90a@buildbot.net> Message-ID: <055.d003515ac4de7e24af4e429d5714743a@buildbot.net> #1688: there should be some way to retry builds that fail in setupBuild without submitting new Changes. ------------------------+------------------------- Reporter: bhearsum | Owner: jaredgrubb Type: enhancement | Status: assigned Priority: major | Milestone: 0.9.0 Version: 0.8.2 | Resolution: Keywords: | ------------------------+------------------------- Changes (by dustin): * milestone: 0.8.8 => 0.9.0 Comment: This is something we should revisit in the updated build-claiming code in 0.9.0. Builds should either be started or build requests unclaimed, in any circumstance. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:56:04 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:56:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1801: refactor slave/buildslave/runprocess.py In-Reply-To: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net> References: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net> Message-ID: <053.3498aa8ae4e75483a74aeaa909f52005@buildbot.net> #1801: refactor slave/buildslave/runprocess.py -------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.3p1 | Resolution: Keywords: kill, sprint | -------------------------+-------------------- Changes (by dustin): * keywords: kill => kill, sprint Comment: This would be a good pure-python refactoring project. There are decent tests for runprocess to ensure compatibility. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:56:58 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:56:58 -0000 Subject: [Buildbot-commits] [Buildbot] #1821: scheduler usability improvements In-Reply-To: <038.38073a6e2654ee7a291ee089b013a6d2@buildbot.net> References: <038.38073a6e2654ee7a291ee089b013a6d2@buildbot.net> Message-ID: <053.da8b128a4c3d532c786fbb8b63528705@buildbot.net> #1821: scheduler usability improvements ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.8 Version: master | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:58:02 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:58:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2041: use consumeErrors for all gatherResults calls In-Reply-To: <038.bbed7febfd6ab9b9ebbf4afc55e309e1@buildbot.net> References: <038.bbed7febfd6ab9b9ebbf4afc55e309e1@buildbot.net> Message-ID: <053.c98efac34769c1d931430b69830533b9@buildbot.net> #2041: use consumeErrors for all gatherResults calls ------------------------+----------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.8 Version: 0.8.4p1 | Resolution: Keywords: sprint | ------------------------+----------------------- Changes (by dustin): * keywords: => sprint Comment: This will be a good grep-and-edit fix for someone not terribly familiar with the codebase, but familiar with Python. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 15:59:11 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 15:59:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2106: Buildbot requires pycrypto to setup even an unencrypted manhole In-Reply-To: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> References: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> Message-ID: <057.f58a9cb738f95169a8d5fb66a66dd1bd@buildbot.net> #2106: Buildbot requires pycrypto to setup even an unencrypted manhole ---------------------------+-------------------- Reporter: jollyroger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.4p2 | Resolution: Keywords: sprint, simple | ---------------------------+-------------------- Changes (by dustin): * keywords: sprint => sprint, simple Comment: This is a pretty simple change to the way imports work, along with some manual testing. Testing imports and their lack using trial is probably more trouble than it's worth. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:02:43 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:02:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2226: Add a buildstep that just renders stuff into a log file. In-Reply-To: <042.15bf7a88e35697a03e04984a593c5ce0@buildbot.net> References: <042.15bf7a88e35697a03e04984a593c5ce0@buildbot.net> Message-ID: <057.851c741adcdf52271885d1afc58023cf@buildbot.net> #2226: Add a buildstep that just renders stuff into a log file. ---------------------------+------------------------- Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.5 | Resolution: Keywords: sprint, simple | ---------------------------+------------------------- Changes (by dustin): * keywords: sprint => sprint, simple Comment: This should be a gentle introduction to adding a new step to the Buildbot codebase, with code, docs, and tests. The code Tom points to in the description is MPL-1-licensed, so it can't be imported verbatim into Buildbot. It's also pretty simple. So ideally the implementation here would be done in a "clean-room" fashion, by someone who hasn't looked at the above link. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:03:45 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:03:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2366: Connect with github's commit status API In-Reply-To: <038.e6221459b7d772be340f40d18ec170a6@buildbot.net> References: <038.e6221459b7d772be340f40d18ec170a6@buildbot.net> Message-ID: <053.6ec87f47aa8b626bbc29d6d99119169f@buildbot.net> #2366: Connect with github's commit status API ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.6p1 | Resolution: Keywords: git | ------------------------+-------------------- Comment (by dustin): And https://github.com/buildbot/buildbot/issues/635 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:04:45 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:04:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2368: Error describing step In-Reply-To: <040.7f56f403fe02ccc7970732c2f642a966@buildbot.net> References: <040.7f56f403fe02ccc7970732c2f642a966@buildbot.net> Message-ID: <055.2bcc0a0934bc27ff5d53ca2847da735a@buildbot.net> #2368: Error describing step ---------------------+--------------------- Reporter: pepsiman | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: master | Resolution: fixed Keywords: | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Let's call this fixed. The `describe` function is still a mess, though. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:06:54 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:06:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2419: Svn update is failing with different language In-Reply-To: <037.d09b95a389cdf41938cfbb5ab9287554@buildbot.net> References: <037.d09b95a389cdf41938cfbb5ab9287554@buildbot.net> Message-ID: <052.b7b143cb99a81ceb56b0c62c44f09060@buildbot.net> #2419: Svn update is failing with different language -----------------------+--------------------- Reporter: Alice | Owner: Alice Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: svn,update | -----------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: {{{ commit b5768a4cf6521b1cd2e4a113c5e210d9759d133a Author: Shriram Kunchanapalli Date: Sun Jan 13 01:11:12 2013 +0530 Builds on language environment patch from Alice for ticket 2419 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:08:37 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:08:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1929: refactor BotMaster.cleanShutdown In-Reply-To: <038.8e3bf05e4c72fcd375f458b0c6548227@buildbot.net> References: <038.8e3bf05e4c72fcd375f458b0c6548227@buildbot.net> Message-ID: <053.38f4f53689195ae04d64096b200e4894@buildbot.net> #1929: refactor BotMaster.cleanShutdown ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: 0.8.8 => 0.9.+ Comment: Let's not make any more changes to BRD in the 0.8.x series, please! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:10:56 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:10:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2375: SVN._sourcedirIsUpdatable checks for locale-dependant string and fails on French and Norvegian In-Reply-To: <039.76a16325bce35739108177f7aee27eac@buildbot.net> References: <039.76a16325bce35739108177f7aee27eac@buildbot.net> Message-ID: <054.e5c8042692e0247de56b85d8df0c8749@buildbot.net> #2375: SVN._sourcedirIsUpdatable checks for locale-dependant string and fails on French and Norvegian --------------------+--------------------- Reporter: Quentin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.8 Version: 0.8.7 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: ShriramK fixed this using --xml: {{{ commit 7df0f7bd8f58f557fecee3b893ffe54ad4c6a12b Author: Shriram Kunchanapalli Date: Sat Jan 26 23:08:16 2013 +0530 Modified as per recent comments in pull request and discussion on IRC. Added test changes for failure conditions for parseGotRevision }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:12:39 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:12:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2385: UnicodeDecode error in runprocess.py In-Reply-To: <042.9fb9a5653f267e6238dfcc83076d7a2e@buildbot.net> References: <042.9fb9a5653f267e6238dfcc83076d7a2e@buildbot.net> Message-ID: <057.58a8352c23d87c99b43fbaa9c78dd36b@buildbot.net> #2385: UnicodeDecode error in runprocess.py -----------------------+-------------------- Reporter: roger_fong | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.7 | Resolution: Keywords: encoding | -----------------------+-------------------- Changes (by dustin): * milestone: 0.8.8 => 0.9.+ Comment: All log data is unicode in nine, so this shouldn't be a problem. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:13:39 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:13:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2392: try needs better error messages when vc isn't passed. In-Reply-To: <042.697650c3209aa6a2aa14e86554e22211@buildbot.net> References: <042.697650c3209aa6a2aa14e86554e22211@buildbot.net> Message-ID: <057.7c74ce840c0db75a6ec3b0c8479de890@buildbot.net> #2392: try needs better error messages when vc isn't passed. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.8 Version: 0.8.7 | Resolution: Keywords: try | -----------------------+-------------------- Comment (by dustin): Is there more to do here? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:14:30 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:14:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2400: Logging in does not clear "Authentication failed" message In-Reply-To: <036.990563bb95c7d8a2fcecc316a03779c5@buildbot.net> References: <036.990563bb95c7d8a2fcecc316a03779c5@buildbot.net> Message-ID: <051.418594cb8dfd02cce48cc41847c99fb2@buildbot.net> #2400: Logging in does not clear "Authentication failed" message -------------------+-------------------- Reporter: dank | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.8 Version: 0.8.7 | Resolution: Keywords: web | -------------------+-------------------- Comment (by dustin): ShriramK, do you want to finish this up so we can get it merged? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:16:25 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:16:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2310: upgrade-master doesn't support master.cfg located outside of basedir In-Reply-To: <038.821f792fd746d7847d807ccb9ec39eb4@buildbot.net> References: <038.821f792fd746d7847d807ccb9ec39eb4@buildbot.net> Message-ID: <053.14329d6d8dfe9b6d5c802a137ca486d8@buildbot.net> #2310: upgrade-master doesn't support master.cfg located outside of basedir -----------------------------+----------------------- Reporter: KeiKun | Owner: Type: enhancement | Status: assigned Priority: patches-accepted | Milestone: 0.8.8 Version: 0.8.6p1 | Resolution: Keywords: simple | -----------------------------+----------------------- Description changed by dustin: Old description: > Some buildbot subcommands (e.g., buildbot checkconfig) currently assume > that its configuration file is named master.cfg, and is located in the > master's basedir. This is not always the case. The name location of the > config file is specified in the master's basedir, so it isn't difficult > to find. > > All of the buildbot subcommands should support a master.cfg that is not > in the default location. Tests should verify that this is the case. > > At least 'buildbot checkconfig' and 'buildbot upgrade-master' do not work > correctly. New description: Some buildbot subcommands (e.g., buildbot checkconfig) currently assume that Buildbot's configuration file is named master.cfg, and is located in the master's basedir. This is not always the case. The name amd location of the config file are specified in the master's buildbot.tac, which is always in the basedir. All of the buildbot subcommands should support a master.cfg that is not in the default location. Tests should verify that this is the case. At least 'buildbot checkconfig' and 'buildbot upgrade-master' do not work correctly. -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:21:44 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:21:44 -0000 Subject: [Buildbot-commits] [Buildbot] #593: Flexible default logging. In-Reply-To: <036.c3e04619608372e892fa072cae93348f@buildbot.net> References: <036.c3e04619608372e892fa072cae93348f@buildbot.net> Message-ID: <051.d28c5f624919b70111c468f7ce90a698@buildbot.net> #593: Flexible default logging. -------------------+-------------------- Reporter: verm | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.11 | Resolution: Keywords: | -------------------+-------------------- Description changed by dustin: Old description: > At the moment it's possible to specify logging (using default > configurations) in only one way, which is to supply logfiles={} > > This has the disadvantage of streaming data in real time. Not all logs > during the build process require realtime streaming. > > Another issue is the stdio log, this copies both stdin and stderr to the > same log file. > > It would be nice to have three specific features added to the default > logging mech: > > 1. Specify different logfiles for stdin/stderr or other named pipes. > 1. Specify a logfile that should only be uploaded at the _end_ of the > build step, whether it fails or succeeds. For example uploading > config.status and config.log at the end running ./configure in a gnu > autoconf setup. > 1. The ability to specify a callback to filter a log file through. For > instance: > {{{ > log(, , master>) > }}} > This would allow for filtering output from utilities that allow for > custom log file output, such as `cl` from MSVC, or other utilities that > may provided XML or other normalised output methods. > > Related: > * #615 New description: At the moment it's possible to specify logging (using default configurations) in only one way, which is to supply logfiles={} This has the disadvantage of streaming data in real time. Not all logs during the build process require realtime streaming. Another issue is the stdio log, this copies both stdin and stderr to the same log file. It would be nice to have three specific features added to the default logging mech: 1. Specify different logfiles for stdin/stderr or other named pipes. 1. Specify a logfile that should only be uploaded at the _end_ of the build step, whether it fails or succeeds. For example uploading config.status and config.log at the end running ./configure in a gnu autoconf setup. 1. The ability to specify a callback to filter a log file through. For instance: {{{ log(, , ) }}} This would allow for filtering output from utilities that allow for custom log file output, such as `cl` from MSVC, or other utilities that may provided XML or other normalised output methods. Related: * #615 * #1699 -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:23:01 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:23:01 -0000 Subject: [Buildbot-commits] [Buildbot] #708: Incorporate bzr_poller.py and add more docs In-Reply-To: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> References: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> Message-ID: <053.42a5b3bf82fa9121e3bae964faf57342@buildbot.net> #708: Incorporate bzr_poller.py and add more docs -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: master | Resolution: Keywords: bzr | -----------------------------+-------------------- Comment (by gracinet): I do have a working version, but it does not have unit tests yet, and is not overall tested enough in the wild (only our testing server runs it). I agree that it's been too long already, but am in a difficult position wrt other work that I need to sort out. Would somewhere around march 15 or 16 be an acceptable target ? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:23:50 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:23:50 -0000 Subject: [Buildbot-commits] [Buildbot] #778: 'latest' revision get's stuck on grid views when source step fails In-Reply-To: <039.27a06b248f9920dc90571d9fde33c0c5@buildbot.net> References: <039.27a06b248f9920dc90571d9fde33c0c5@buildbot.net> Message-ID: <054.d22a3913ebaf9f6a55fbf470f8c8a230@buildbot.net> #778: 'latest' revision get's stuck on grid views when source step fails --------------------+-------------------- Reporter: marcusl | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.12 | Resolution: Keywords: web | --------------------+-------------------- Comment (by dustin): This will be fixed by getting rid of relative sourcestamps. The overall plan is that builds have sets of sourcestamps that are not necessarily the same as those attached to the original buildset. So, buildsets can have relative sourcestamps, but the build will replace those with absolute sourcestamps once it runs the corresponding source step. Then all status displays - not just the grid - will be able to display the revision it *actually* built, rather than "latest". -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:24:30 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:24:30 -0000 Subject: [Buildbot-commits] [Buildbot] #779: rewrite the HTMLResource classes to fill the context from the asDict() In-Reply-To: <038.4dc8d988fe10c58e984f8b08ea1e0bb4@buildbot.net> References: <038.4dc8d988fe10c58e984f8b08ea1e0bb4@buildbot.net> Message-ID: <053.3eec244a85469a47f138abec572e66c1@buildbot.net> #779: rewrite the HTMLResource classes to fill the context from the asDict() ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.7.12 | Resolution: wontfix Keywords: web | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: `asDict` will be going away, and the entire new web UI is based on its replacement, the data API. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:25:20 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:25:20 -0000 Subject: [Buildbot-commits] [Buildbot] #871: JS UI should have an easy means for users to customize page templates (was: user customized jinja templates should be able to extend default templates) In-Reply-To: <041.5b3a8e992837b70491b44658e8d91ace@buildbot.net> References: <041.5b3a8e992837b70491b44658e8d91ace@buildbot.net> Message-ID: <056.f13209ca91d207d8fef0ac80ec7650d3@buildbot.net> #871: JS UI should have an easy means for users to customize page templates ------------------------+----------------------- Reporter: cdadhemar | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: web | ------------------------+----------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:26:01 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:26:01 -0000 Subject: [Buildbot-commits] [Buildbot] #904: implement build filtering in web ui In-Reply-To: <040.0b0cd4cb20328af40458771e6938ba6b@buildbot.net> References: <040.0b0cd4cb20328af40458771e6938ba6b@buildbot.net> Message-ID: <055.729beeb2cb15dc8703ef10e39f464ba3@buildbot.net> #904: implement build filtering in web ui --------------------------+-------------------- Reporter: bhearsum | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: web, database | --------------------------+-------------------- Comment (by dustin): This is really just a special case of #789, then. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:26:23 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:26:23 -0000 Subject: [Buildbot-commits] [Buildbot] #789: Source stamp filtering, sorting, and clustering in web views In-Reply-To: <039.e54bab987922e2f005f08fb8c265248d@buildbot.net> References: <039.e54bab987922e2f005f08fb8c265248d@buildbot.net> Message-ID: <054.b39d9931d4e6e42e457e3eb5d2aeb43d@buildbot.net> #789: Source stamp filtering, sorting, and clustering in web views ---------------------+-------------------- Reporter: marcusl | Owner: Type: task | Status: new Priority: critical | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: web | ---------------------+-------------------- Description changed by dustin: Old description: > The current "revision" column/row in the grid view isn't enough if there > are builds from different repositories. > > By grouping by repository (and showing said repository) we get a better > display of what's actually going on. > > I believe showing the latest build for each rev/builder config is what we > still want to do here. > > Related: > * #775 > * #525 > * #534 > * #873 > * #928 > * #1015 New description: The current "revision" column/row in the grid view isn't enough if there are builds from different repositories. By grouping by repository (and showing said repository) we get a better display of what's actually going on. I believe showing the latest build for each rev/builder config is what we still want to do here. Related: * #775 * #525 * #534 * #873 * #928 * #904 * #1015 -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:27:29 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:27:29 -0000 Subject: [Buildbot-commits] [Buildbot] #1730: normalize name of the width/numbuilds parameter In-Reply-To: <038.36dd9fc8761274fe1d2f7b3a08ef11bd@buildbot.net> References: <038.36dd9fc8761274fe1d2f7b3a08ef11bd@buildbot.net> Message-ID: <053.16755d031112eb45a27bdefe59bee185@buildbot.net> #1730: normalize name of the width/numbuilds parameter ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Resolution: wontfix Keywords: web | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: This parameter will go away in nine, anyway. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:29:57 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:29:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1941: status json creates a full set of Resources ahead of time In-Reply-To: <038.e4dc834881b307fe50b5be379fa844bb@buildbot.net> References: <038.e4dc834881b307fe50b5be379fa844bb@buildbot.net> Message-ID: <053.5e0b414163458f28d432ede817a2686b@buildbot.net> #1941: status json creates a full set of Resources ahead of time -----------------------------+------------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Resolution: worksforme Keywords: web, performance | -----------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: This will be removed in nine, so nothing to fix. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:30:42 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:30:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2023: RemoteShellCommand undocumented In-Reply-To: <041.cd5a8776020f25009f80ace70131fa13@buildbot.net> References: <041.cd5a8776020f25009f80ace70131fa13@buildbot.net> Message-ID: <056.4f9e7efd847333496e35126d7805107e@buildbot.net> #2023: RemoteShellCommand undocumented ----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.4p1 | Resolution: Keywords: docs | ----------------------+-------------------- Changes (by dustin): * milestone: 0.9.+ => 1.0.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:32:30 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:32:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2418: Can't sort SourceStamp listing in Jinja2 build.html template In-Reply-To: <044.fe788632f524388eea09125bb0afa05a@buildbot.net> References: <044.fe788632f524388eea09125bb0afa05a@buildbot.net> Message-ID: <059.b7191e13934cb11a5517b2758b468c94@buildbot.net> #2418: Can't sort SourceStamp listing in Jinja2 build.html template -------------------------+-------------------- Reporter: mikesorrenti | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: web | -------------------------+-------------------- Changes (by dustin): * keywords: SourceStamp sort web => web * milestone: undecided => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:32:51 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:32:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2418: Can't sort SourceStamp listing in Jinja2 build.html template In-Reply-To: <044.fe788632f524388eea09125bb0afa05a@buildbot.net> References: <044.fe788632f524388eea09125bb0afa05a@buildbot.net> Message-ID: <059.3727506049e6539dc0d49935b8378a5e@buildbot.net> #2418: Can't sort SourceStamp listing in Jinja2 build.html template -------------------------+-------------------- Reporter: mikesorrenti | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: web | -------------------------+-------------------- Comment (by dustin): (In fact, the SourceStamp class no longer exists in the 'nine' branch) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:33:35 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:33:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2235: common testing support for multiple API layers with the same signature In-Reply-To: <038.1fe376c73ad14d1cdd26c80ef02670c1@buildbot.net> References: <038.1fe376c73ad14d1cdd26c80ef02670c1@buildbot.net> Message-ID: <053.eafd3c7dea7e1b9f20ca5547d3855225@buildbot.net> #2235: common testing support for multiple API layers with the same signature ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Resolution: fixed Keywords: tests | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: The interface tests address this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:34:17 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:34:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2071: Force Build per builder security, property In-Reply-To: <038.9e5dd19a9a377a1b558ed2dedd7e774b@buildbot.net> References: <038.9e5dd19a9a377a1b558ed2dedd7e774b@buildbot.net> Message-ID: <053.ca05ff7a375fb9e28dfe77250c4d2f33@buildbot.net> #2071: Force Build per builder security, property ------------------------+------------------------ Reporter: jachen | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.4p2 | Resolution: duplicate Keywords: web, force | ------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: In fact, this is just a special case of #896 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:34:32 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:34:32 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.62500aea3f4af087e1ad0d28bfcbb5b7@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Changes (by dustin): * cc: jachen (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:35:37 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:35:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2109: Need method to limit the number of concurrent builds to start for a builder regardless of # of buildslaves assigned In-Reply-To: <040.c074e51c81e649fdf4f8ba7ef42680b1@buildbot.net> References: <040.c074e51c81e649fdf4f8ba7ef42680b1@buildbot.net> Message-ID: <055.99d5426b5c30ba5134ad449964a9f09f@buildbot.net> #2109: Need method to limit the number of concurrent builds to start for a builder regardless of # of buildslaves assigned ------------------------+--------------------- Reporter: bdbaddog | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Resolution: fixed Keywords: buildcoord | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Jared's changes to the build chooser now take locks into consideration, so this should be fixed. Can you confirm, when those are released? Please re-open if I've lied. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:36:00 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:36:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2121: Allow limited-scope Perforce checkouts In-Reply-To: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> References: <038.2d3e83e9c8fe3c7a2852341a9be765e7@buildbot.net> Message-ID: <053.ae2453b234202efa4e845e0d932d281e@buildbot.net> #2121: Allow limited-scope Perforce checkouts -----------------------------+-------------------- Reporter: gmcnew | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.9.+ Version: 0.8.4p2 | Resolution: Keywords: p4 | -----------------------------+-------------------- Changes (by dustin): * priority: major => patches-accepted -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:44:55 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:44:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2234: have a better-defined approach to mocking In-Reply-To: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> References: <038.3f03218cf576664488eee36dd4b5b887@buildbot.net> Message-ID: <053.4041dd116b940a98e8abcc8e2cbb35e0@buildbot.net> #2234: have a better-defined approach to mocking ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: tests | ------------------------+--------------------- Comment (by dustin): This is coming along nicely in nine. DB methods are 100% covered: fakes and real methods both pass the same set of tests automatically, and their arg specs are compared automatically. The fake Data API update methods' arg specs are compared; their behavior is not significant enough to test. Most of the status mocks will go away along with the classes they're mocking. The scheduler tests now use the real `addBuildsetFor..` methods from their base class, all of which call back to `self.data.updates.addBuildset`, which is mocked. I'll leave this open as a reminder to check on progress. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:47:26 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:47:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2224: Support MySQL partitioning In-Reply-To: <038.407e30bc95d777b71e4bf74b2d50fcc5@buildbot.net> References: <038.407e30bc95d777b71e4bf74b2d50fcc5@buildbot.net> Message-ID: <053.95a1f7032f2cae759ea532c4e26f6d9e@buildbot.net> #2224: Support MySQL partitioning ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.2 | Resolution: Keywords: database | ------------------------+-------------------- Comment (by dustin): This done here for Mozpool: https://github.com/mozilla/mozpool/blob/master/sql/schema.sql I think that the Buildbot support for this would basically involve changing the SQL used to prune builds, logs, etc. Instead of running a 'DELETE' query, Buildbot would invoke a partition-updating function. We could supply that function in a contrib script. Nine currently doesn't prune anything, so this will need to wait a bit. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:51:29 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:51:29 -0000 Subject: [Buildbot-commits] [Buildbot] #540: overhaul ETA calculation In-Reply-To: <040.92953aafe7562adb1b4d7d14c9032354@buildbot.net> References: <040.92953aafe7562adb1b4d7d14c9032354@buildbot.net> Message-ID: <055.558f039aecaced1db4a219f10e8eb1db@buildbot.net> #540: overhaul ETA calculation ------------------------+----------------------- Reporter: ipv6guru | Owner: warner Type: enhancement | Status: assigned Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+----------------------- Changes (by dustin): * cc: eta (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:51:38 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:51:38 -0000 Subject: [Buildbot-commits] [Buildbot] #174: Persist ETA data across restarts In-Reply-To: <037.88c16bd0c2a2cf0da12862548b2a0329@buildbot.net> References: <037.88c16bd0c2a2cf0da12862548b2a0329@buildbot.net> Message-ID: <052.184c064f3d22059ce8ddde4eea06a420@buildbot.net> #174: Persist ETA data across restarts ------------------------+----------------------- Reporter: gward | Owner: toinbis Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.+ Version: 0.7.6 | Resolution: Keywords: eta | ------------------------+----------------------- Changes (by dustin): * keywords: => eta -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:51:47 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:51:47 -0000 Subject: [Buildbot-commits] [Buildbot] #540: overhaul ETA calculation In-Reply-To: <040.92953aafe7562adb1b4d7d14c9032354@buildbot.net> References: <040.92953aafe7562adb1b4d7d14c9032354@buildbot.net> Message-ID: <055.e07466506cad9f12d9c4ea083907f8ef@buildbot.net> #540: overhaul ETA calculation ------------------------+----------------------- Reporter: ipv6guru | Owner: warner Type: enhancement | Status: assigned Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: eta | ------------------------+----------------------- Changes (by dustin): * cc: eta (removed) * keywords: => eta -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:53:48 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:53:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2359: Support extracting steps from annotated logs In-Reply-To: <036.c087e53371eae1054036850ebc7547aa@buildbot.net> References: <036.c087e53371eae1054036850ebc7547aa@buildbot.net> Message-ID: <051.0fbdec0096c3ebbf9cde59b422c3f73d@buildbot.net> #2359: Support extracting steps from annotated logs ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: master | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * cc: aki (added) Comment: This would interface very well with Aki Sasaki's Mozharness. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:54:18 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:54:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2349: Show alert text on web pages that the config has been modified since last reload In-Reply-To: <038.07713a51feac324b07262186daf5e65b@buildbot.net> References: <038.07713a51feac324b07262186daf5e65b@buildbot.net> Message-ID: <053.638048bda825eac8359dea93998082bf@buildbot.net> #2349: Show alert text on web pages that the config has been modified since last reload ------------------------+-------------------- Reporter: johnkw | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.6p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * cc: metrics (added) Comment: This could be a metrics alert. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:55:23 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:55:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2173: Add mail option "failure or change" In-Reply-To: <038.9466ce838746c9d9e406432d6a5c3f07@buildbot.net> References: <038.9466ce838746c9d9e406432d6a5c3f07@buildbot.net> Message-ID: <053.6652b74cf40f7b7aa798afe65c8c638a@buildbot.net> #2173: Add mail option "failure or change" ------------------------+-------------------- Reporter: kwerle | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.5 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * cc: mail (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:56:08 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:56:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1845: MailNotifier: Add ability to send an All-Passed email when all builders succeed . In-Reply-To: <038.a8bc89d73aa1bdae66c1b1d37e7f335d@buildbot.net> References: <038.a8bc89d73aa1bdae66c1b1d37e7f335d@buildbot.net> Message-ID: <053.d14441e3e74822c91da3f51941e746df@buildbot.net> #1845: MailNotifier: Add ability to send an All-Passed email when all builders succeed . ------------------------+-------------------- Reporter: cpeyer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * cc: mail (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 16:57:15 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 16:57:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1828: buildbot utilities should be separate package In-Reply-To: <038.0d6ac88a02be7f4801831dfee30c607b@buildbot.net> References: <038.0d6ac88a02be7f4801831dfee30c607b@buildbot.net> Message-ID: <053.8b7860f46c8f5e5ea3a9868b20f35d64@buildbot.net> #1828: buildbot utilities should be separate package ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: master | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:04:39 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:04:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2460: Build a plugin architecture Message-ID: <038.6919b566108f7f458af744f94de142c3@buildbot.net> #2460: Build a plugin architecture -------------------------+------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Keywords: -------------------------+------------------- It should be possible for users to add extra functionality to Buildbot by installing additional packages from pypi. The extra functionality should include * change sources * build steps * status plugins * web UI components The setuptools entry-points support can help here. Once this is complete, long-term unmaintained code currently distributed with Buildbot should be moved to external projects (still in the Buildbot github organization) where it can be maintained - or not - by its users. We should produce simple "hello-world" templates for each type of plugin, so that users have somewhere to start. == scope == This project will involve understanding how Python packages are built, tested, documented, and distributed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:05:15 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:05:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1828: buildbot utilities should be separate package In-Reply-To: <038.0d6ac88a02be7f4801831dfee30c607b@buildbot.net> References: <038.0d6ac88a02be7f4801831dfee30c607b@buildbot.net> Message-ID: <053.9cfcfdaf73f41fe597e93f6320b38970@buildbot.net> #1828: buildbot utilities should be separate package ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: master | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by dustin): See also #2460. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:05:39 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:05:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2460: Build a plugin architecture In-Reply-To: <038.6919b566108f7f458af744f94de142c3@buildbot.net> References: <038.6919b566108f7f458af744f94de142c3@buildbot.net> Message-ID: <053.42b3d1537d9b9c500ddfcca043da3573@buildbot.net> #2460: Build a plugin architecture -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Description changed by dustin: Old description: > It should be possible for users to add extra functionality to Buildbot by > installing additional packages from pypi. The extra functionality should > include > * change sources > * build steps > * status plugins > * web UI components > > The setuptools entry-points support can help here. > > Once this is complete, long-term unmaintained code currently distributed > with Buildbot should be moved to external projects (still in the Buildbot > github organization) where it can be maintained - or not - by its users. > > We should produce simple "hello-world" templates for each type of plugin, > so that users have somewhere to start. > > == scope == > > This project will involve understanding how Python packages are built, > tested, documented, and distributed. New description: It should be possible for users to add extra functionality to Buildbot by installing additional packages from pypi. The extra functionality should include * change sources * build steps * status plugins * web UI components * utility scripts (#1828) The setuptools entry-points support can help here. Once this is complete, long-term unmaintained code currently distributed with Buildbot should be moved to external projects (still in the Buildbot github organization) where it can be maintained - or not - by its users. We should produce simple "hello-world" templates for each type of plugin, so that users have somewhere to start. == scope == This project will involve understanding how Python packages are built, tested, documented, and distributed. -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:06:08 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:06:08 -0000 Subject: [Buildbot-commits] [Buildbot] #738: Record true start/end time for build steps In-Reply-To: <038.6ff50e5b95ac721c4035f5bb0017b756@buildbot.net> References: <038.6ff50e5b95ac721c4035f5bb0017b756@buildbot.net> Message-ID: <053.92ee9e2f42670cabda3962933eac2cd3@buildbot.net> #738: Record true start/end time for build steps ------------------------+----------------------- Reporter: catlee | Owner: toinbis Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.+ Version: | Resolution: Keywords: sprint, eta | ------------------------+----------------------- Changes (by dustin): * keywords: sprint => sprint, eta -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:08:33 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:08:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1824: Dependent build depends on scheduler property In-Reply-To: <038.5e9d2be315d14148cde444957abc6f92@buildbot.net> References: <038.5e9d2be315d14148cde444957abc6f92@buildbot.net> Message-ID: <053.cf0df4764c8295778b773ed4fc5c5cf8@buildbot.net> #1824: Dependent build depends on scheduler property -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.9.0 Version: master | Resolution: Keywords: database, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: database => database, sprint Comment: We now have a schedulers table with unique id's per scheduler, so this is much more practical. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:12:13 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:12:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods In-Reply-To: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> References: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> Message-ID: <053.cb609ff0338d0da2d09ecf890a2aa7a5@buildbot.net> #2237: Schedulers should have names and reconfigService methods -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: reconfig, sprint | -----------------------------+-------------------- Changes (by dustin): * keywords: reconfig => reconfig, sprint -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:14:01 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:14:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2283: make sure *.master is always set In-Reply-To: <038.cbabe2b8635d5dffe5a2f5a19f2c211c@buildbot.net> References: <038.cbabe2b8635d5dffe5a2f5a19f2c211c@buildbot.net> Message-ID: <053.2952cf2682414f0758aab56a66316afa@buildbot.net> #2283: make sure *.master is always set ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.0 Version: master | Resolution: wontfix Keywords: | ------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => wontfix Comment: Getting this value set everywhere hasn't turned out to be any great difficulty. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:15:44 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:15:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2378: when is a deprecated argument to master.addChange but that is how web hooks pass in changes In-Reply-To: <042.21ec17a3f8d70aed151f24dd4fb4c254@buildbot.net> References: <042.21ec17a3f8d70aed151f24dd4fb4c254@buildbot.net> Message-ID: <057.09293d2cdf8f01a17cfab6fc869020b6@buildbot.net> #2378: when is a deprecated argument to master.addChange but that is how web hooks pass in changes -----------------------+----------------------- Reporter: tom.prince | Owner: dustin Type: defect | Status: assigned Priority: major | Milestone: 0.9.0 Version: 0.8.7 | Resolution: Keywords: | -----------------------+----------------------- Changes (by dustin): * owner: => dustin * status: new => assigned Comment: This is an adjustment I'll need to make before nine is released. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:16:10 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:16:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2425: Generating revlink on a Mercurial repository In-Reply-To: <044.6a0520edf46110bb342fb1d2a1b97952@buildbot.net> References: <044.6a0520edf46110bb342fb1d2a1b97952@buildbot.net> Message-ID: <059.540a348eadb393e898480bafa080ac30@buildbot.net> #2425: Generating revlink on a Mercurial repository -------------------------+-------------------- Reporter: mariamarcano | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.7p1 | Resolution: Keywords: web | -------------------------+-------------------- Changes (by dustin): * keywords: => web -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:18:32 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:18:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1729: Need indices on sourcestamps.branch, sourcestamps.revision In-Reply-To: <038.c1dbef0f1097d9136229989274618d24@buildbot.net> References: <038.c1dbef0f1097d9136229989274618d24@buildbot.net> Message-ID: <053.53fcb31187e85810b572c13c2065f82c@buildbot.net> #1729: Need indices on sourcestamps.branch, sourcestamps.revision -------------------------------------+----------------------- Reporter: catlee | Owner: dustin Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.0 Version: 0.8.2 | Resolution: Keywords: database, sprint, simple | -------------------------------------+----------------------- Changes (by dustin): * keywords: database => database, sprint, simple Comment: This will be a pretty simple improvement to nine. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:20:08 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:20:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2257: incomplete URL sanitization for buildstep names In-Reply-To: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> References: <039.603ad79b3cf36206f418fa3f92f6af40@buildbot.net> Message-ID: <054.4e6a3ef82a1e856469520ee72fc9b242@buildbot.net> #2257: incomplete URL sanitization for buildstep names --------------------+-------------------- Reporter: brendan | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: web | --------------------+-------------------- Comment (by dustin): The solution in nine is, for the moment, not to include builder names in URLs. Step names are identifiers, and one of the excluded characters in the definition of an identifier is '/'. Builds will eventually grow identifiers of their own, and be usable in URLs. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:28:36 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:28:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1788: MQ options In-Reply-To: <038.562d4de9cecd700250275a2eb5a51f11@buildbot.net> References: <038.562d4de9cecd700250275a2eb5a51f11@buildbot.net> Message-ID: <053.f0df4c08f10ffdcfdc82959ab69f7bc7@buildbot.net> #1788: MQ options -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: | -------------------------+-------------------- Changes (by dustin): * cc: ewong (added) * type: enhancement => project-idea * milestone: 1.0.+ => 0.9.+ Old description: > When Buildbot adopts an MQ framework, there are a number of choices. > Among them: > > * http://morbidq.com/ > * http://code.google.com/p/coilmq/ > * zeromq New description: When Buildbot adopts an MQ framework, there are a number of choices. Among them: * pure-python, internal implementation (no network, only a single master) * pure-python, internal implementation that uses TCP or UDP between masters * http://morbidq.com/ * http://code.google.com/p/coilmq/ * txamqp * zeromq The first is already implemented in 'nine', but we need more. The more difficult part of this project is to ensure that messages are only delivered after the corresponding database changes are visible. The issue is a race condition between message passing and database replication. Imagine you have a large Buildbot installation with several replicated MySQL servers and a redundant RabbitMQ cluster. One buildbot master writes changes to a build to the database (an UPDATE operation), then sends a message describing the change. On another master, some service gets the message and queries a different MySQL server to see the build's new status. If the message arrives before the database replication occurs, then this master will see stale data. That will lead to a lot of subtle, rare bugs. == scope == This project would involve separate tasks: * implement one or more of the above MQ plugins (mostly just coding) * solve the data-ordering problem (requiring some CS theory) -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 17:48:05 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 17:48:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2375: SVN._sourcedirIsUpdatable checks for locale-dependant string and fails on French and Norvegian In-Reply-To: <039.76a16325bce35739108177f7aee27eac@buildbot.net> References: <039.76a16325bce35739108177f7aee27eac@buildbot.net> Message-ID: <054.349f526b02391c26d82f042d40ee0bf1@buildbot.net> #2375: SVN._sourcedirIsUpdatable checks for locale-dependant string and fails on French and Norvegian --------------------+----------------------- Reporter: Quentin | Owner: Type: defect | Status: reopened Priority: minor | Milestone: 0.8.8 Version: 0.8.7 | Resolution: Keywords: | --------------------+----------------------- Changes (by dustin): * status: closed => reopened * resolution: fixed => Comment: Sorry, that fix was for another bug. This bug is about sourceDirIsUpdatable, specifically. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 19:25:17 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 19:25:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2461: Add support for providing and graphing data charts of metrics over time. Message-ID: <035.e7dbeb1ff209523ffe365bc7355d9def@buildbot.net> #2461: Add support for providing and graphing data charts of metrics over time. -------------------------+-------------------------------------------- Reporter: juj | Owner: Type: project-idea | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: visualization graphing metrics -------------------------+-------------------------------------------- The project idea description contained too many links, and trac rejects it as spam, so find the description of the ticket here instead: https://dl.dropbox.com/u/40949268/code/buildbot_visualization_projectidea.txt -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 21:50:52 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 21:50:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2461: Add support for providing and graphing data charts of metrics over time. In-Reply-To: <035.e7dbeb1ff209523ffe365bc7355d9def@buildbot.net> References: <035.e7dbeb1ff209523ffe365bc7355d9def@buildbot.net> Message-ID: <050.a2a50e78fdcec96e7d2ffbd658efb7ea@buildbot.net> #2461: Add support for providing and graphing data charts of metrics over time. -------------------------+-------------------- Reporter: juj | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Changes (by dustin): * keywords: visualization graphing metrics => * milestone: undecided => 0.9.+ Old description: > The project idea description contained too many links, and trac rejects > it as spam, so find the description of the ticket here instead: > > https://dl.dropbox.com/u/40949268/code/buildbot_visualization_projectidea.txt New description: This is a feature request I would find extremely useful, and it's also one that would probably be a good one for GSoC, since it's a new feature with visually concrete results, which can make it more compelling/tractable for a new developer to get interested in. I maintain a continuous testing architecture for the Emscripten C++->JS compiler project (https://github.com/kripken/emscripten). It has an extensive unit testing and benchmarking suite, which prints a lot of graphable metrics out as the result of its run. The buildbot page is openly accessible at http://clb.demon.fi:8112/waterfall . More explanation at the bottom of the page here https://github.com/kripken/emscripten/wiki . While maintaining the buildbot, I've often wondered about the following: * How do build times vary over time? Are we optimizing the compiler, or is it getting more bloated and slowing down over time? Which commits caused big regressions/improvements? * How do buildbot task run times vary over time? These are already logged at the end of stdio with lines "program finished with exit code 0 elapsedTime=1060.951319", which we'd like to graph over time. * How does runtime execution performance of compiled apps change over time? Emscripten has runtime benchmarks tester that tests runtime performance: http://clb.demon.fi:8112/builders/ubuntu-emcc-incoming- tests/builds/175/steps/Benchmarks/logs/stdio . Which commits caused big regressions/improvements? * How does compiled code size vary over time? There are some test apps that get built and stored after each commit: http://clb.demon.fi/dump/emcc /win-emcc-incoming-code-test/ . Which commits caused big regressions/improvements? To be able to measure these kind of quality concerns, visual graphing could be the answer. Being able to feed custom data fields into a data storage inside buildbot, and having a built-in data grapher integrated to buildbot HTTP server to visually compare metrics over time would be immensely helpful. The architecture should be somehow custom-driven so that the buildbot config files can control what data to generate and feed into graphs, since most of the above data points are specific to the project in question. Utilizing existing free graphing solutions would be expected, see for reference: * http://raphaeljs.com/analytics.html * https://www.reverserisk.com/ico/ (line graphs) * etc. -- Comment: This is a great idea, but it needs a bit more design work before it can become a GSoC project. We've found over the years that large-scale design work isn't suitable for GSoC. In particular, I'd like to see a more detailed information on * how the data would be gathered from builds * how the data would be stored * how users would configure all of this all within the framework of the 'nine' branch. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 2 22:21:53 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 22:21:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1038: Audit TimerService / other looping calls In-Reply-To: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> References: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> Message-ID: <053.e0f769757faf4d19cde656489f02b913@buildbot.net> #1038: Audit TimerService / other looping calls -------------------+--------------------- Reporter: catlee | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.1 | Resolution: fixed Keywords: simple | -------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: A grep shows nothing left. I added a spot of docs, but otherwise this is done. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 2 22:22:05 2013 From: noreply at github.com (GitHub) Date: Sat, 02 Mar 2013 14:22:05 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] ff2acf: add warning about LoopingCall and TimerService; re... Message-ID: <51327b8debaac_5c8c18ddaf0772a0@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ff2acf8cb58489a82811b4b5891f00ac36e63e35 https://github.com/buildbot/buildbot/commit/ff2acf8cb58489a82811b4b5891f00ac36e63e35 Author: Dustin J. Mitchell Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- add warning about LoopingCall and TimerService; refs #1038 From nobody at buildbot.net Sat Mar 2 22:22:07 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 02 Mar 2013 22:22:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1038: Audit TimerService / other looping calls In-Reply-To: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> References: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> Message-ID: <053.a61d7308ae6c8d396c36a45df791bb57@buildbot.net> #1038: Audit TimerService / other looping calls -------------------+--------------------- Reporter: catlee | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.1 | Resolution: fixed Keywords: simple | -------------------+--------------------- Comment (by Dustin J. Mitchell): add warning about LoopingCall and TimerService; refs #1038 Changeset: ff2acf8cb58489a82811b4b5891f00ac36e63e35 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 3 15:55:41 2013 From: noreply at github.com (GitHub) Date: Sun, 03 Mar 2013 07:55:41 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 4766c9: BuildslaveChoiceParameter and EnforceChosenSlave: ... Message-ID: <5133727dae665_b5715a6ae4566df@sh3.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4766c95e947ea637b8cddaa0bdbc8b082cbf95aa https://github.com/buildbot/buildbot/commit/4766c95e947ea637b8cddaa0bdbc8b082cbf95aa Author: Jared Grubb Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_builder.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- BuildslaveChoiceParameter and EnforceChosenSlave: force scheduler hooks for explicit slave control Commit: 3be4839eb7c93ad18f55a78c08d7a5c2574266f6 https://github.com/buildbot/buildbot/commit/3be4839eb7c93ad18f55a78c08d7a5c2574266f6 Author: Jared Grubb Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_builder.py M master/docs/manual/cfg-schedulers.rst Log Message: ----------- enforceChosenSlave: address review comments Commit: 3c8373d51ff87948c60dce45c05c4b2188761ac0 https://github.com/buildbot/buildbot/commit/3c8373d51ff87948c60dce45c05c4b2188761ac0 Author: Dustin J. Mitchell Date: 2013-03-03 (Sun, 03 Mar 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/unit/test_process_builder.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'BuildslaveChoiceParameter' of git://github.com/jaredgrubb/buildbot Compare: https://github.com/buildbot/buildbot/compare/ff2acf8cb584...3c8373d51ff8 From noreply at github.com Sun Mar 3 15:58:06 2013 From: noreply at github.com (GitHub) Date: Sun, 03 Mar 2013 07:58:06 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 066b0e: Fixes #1808: use different treeStableTimer in AnyB... Message-ID: <5133730ebd108_130818ddaf07818b@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 066b0e54554e6a52c873a3d703b309184225d081 https://github.com/buildbot/buildbot/commit/066b0e54554e6a52c873a3d703b309184225d081 Author: Jared Grubb Date: 2013-02-27 (Wed, 27 Feb 2013) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/schedulers/basic.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_basic.py M master/docs/relnotes/index.rst Log Message: ----------- Fixes #1808: use different treeStableTimer in AnyBranchScheduler for different sources Commit: 198029d0df4eedb0d57cb2082fb461d3382cd581 https://github.com/buildbot/buildbot/commit/198029d0df4eedb0d57cb2082fb461d3382cd581 Author: Dustin J. Mitchell Date: 2013-03-03 (Sun, 03 Mar 2013) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/schedulers/basic.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_basic.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'treeStableTimer' of git://github.com/jaredgrubb/buildbot Compare: https://github.com/buildbot/buildbot/compare/3c8373d51ff8...198029d0df4e From nobody at buildbot.net Sun Mar 3 15:58:09 2013 From: nobody at buildbot.net (Buildbot) Date: Sun, 03 Mar 2013 15:58:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> Message-ID: <054.761e369740b7dcff0509c9be9930f1ce@buildbot.net> #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp --------------------+------------------------- Reporter: aivarsk | Owner: jaredgrubb Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: sprint | --------------------+------------------------- Changes (by Jared Grubb): * status: assigned => closed * resolution: => fixed Comment: Fixes #1808: use different treeStableTimer in AnyBranchScheduler for different sources Changeset: 066b0e54554e6a52c873a3d703b309184225d081 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 3 22:48:56 2013 From: noreply at github.com (GitHub) Date: Sun, 03 Mar 2013 14:48:56 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 88974e: SVN: Add option to use 'last chnaged' revision rat... Message-ID: <5133d358582dc_319218ddaf0805d9@sh2.rs.github.com.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 88974e7532e393e89ab7d88e4cbbe35d3d980eb7 https://github.com/buildbot/buildbot/commit/88974e7532e393e89ab7d88e4cbbe35d3d980eb7 Author: Jared Grubb Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- SVN: Add option to use 'last chnaged' revision rather than global revision Commit: 6dfff6abd91def6701aab9279730c19efceedde4 https://github.com/buildbot/buildbot/commit/6dfff6abd91def6701aab9279730c19efceedde4 Author: Dustin J. Mitchell Date: 2013-03-03 (Sun, 03 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'SvnLastChangedRev' of git://github.com/jaredgrubb/buildbot Compare: https://github.com/buildbot/buildbot/compare/198029d0df4e...6dfff6abd91d From nobody at buildbot.net Tue Mar 5 03:16:27 2013 From: nobody at buildbot.net (Buildbot) Date: Tue, 05 Mar 2013 03:16:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2462: add a master-side p4 step Message-ID: <038.08192b7f2b9cb9b85648d0fcaf5876ee@buildbot.net> #2462: add a master-side p4 step ------------------------+------------------------------------------ Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Keywords: p4, master-side-source-steps ------------------------+------------------------------------------ There isn't one right now. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 5 14:38:25 2013 From: nobody at buildbot.net (Buildbot) Date: Tue, 05 Mar 2013 14:38:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2463: SVN export does not recieve username/password Message-ID: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> #2463: SVN export does not recieve username/password --------------------+------------------------- Reporter: cscott | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: svn, export --------------------+------------------------- the 'svn export' command isn't being run with _dovccmd, so it's not getting the username attached. This most readily manifests itself when running the svn export step in a build started by the anybranch scheduler, triggerable scheduler or by rebuilding. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 5 14:57:30 2013 From: nobody at buildbot.net (Buildbot) Date: Tue, 05 Mar 2013 14:57:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2463: SVN export does not recieve username/password In-Reply-To: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> References: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> Message-ID: <053.f9b5dd9bccde6e8974ec5ef655cce5fd@buildbot.net> #2463: SVN export does not recieve username/password ------------------------+------------------------ Reporter: cscott | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: svn, export | ------------------------+------------------------ Changes (by ShriramK): * cc: kshriram18@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 5 15:07:39 2013 From: nobody at buildbot.net (Buildbot) Date: Tue, 05 Mar 2013 15:07:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2463: SVN export does not recieve username/password In-Reply-To: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> References: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> Message-ID: <053.8eb3a255b9aca7b5f1f11b70c5969503@buildbot.net> #2463: SVN export does not recieve username/password ------------------------------------------+----------------------- Reporter: cscott | Owner: ShriramK Type: defect | Status: assigned Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: Keywords: svn, master-side-source-steps | ------------------------------------------+----------------------- Changes (by dustin): * keywords: svn, export => svn, master-side-source-steps * owner: => ShriramK * status: new => assigned * milestone: undecided => 0.8.8 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 6 01:04:31 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 01:04:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2360: Buildbot updates to wrong SVN version In-Reply-To: <038.11009f86c0b3735bfb4e7e525859d2a7@buildbot.net> References: <038.11009f86c0b3735bfb4e7e525859d2a7@buildbot.net> Message-ID: <053.4c8026e7610be24760f2007c66115dc1@buildbot.net> #2360: Buildbot updates to wrong SVN version ----------------------------+--------------------- Reporter: flashm | Owner: Type: support-request | Status: closed Priority: major | Milestone: 0.8.7 Version: 0.8.6p1 | Resolution: fixed Keywords: svn projrepo | ----------------------------+--------------------- Comment (by flashm): Thank you. I didn't realize that "codebase" is a feature name. =) By the way, it might be a good idea to disable externals processing in main SVN source step then. Unfortunately, in my case it is not a solution, because our project contains about 40 different externals (yea, that's extremely ugly and bad, but I can't change this for now). It would be a pain to manually specify all these externals. Moreover, even if I autogenerate buildbot config, these externals can change over time, which means that buildbot config can become invalid after an update, which is undesirable. Anyway, I guess I'll stick with alwaysUseLatest for now. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 6 02:32:06 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 02:32:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2464: gitpoller dying Message-ID: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> #2464: gitpoller dying ----------------------+----------------------- Reporter: virgilg | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- After a buildmaster restart (buildmaster 0.8.7p1 on OS X 10.8.2) we're getting the following traceback: 2013-03-05 15:02:14-0800 [-] /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/utils.py:25: exceptions.DeprecationWarning: Argument strings and environment keys/values passed to reactor.spawnProcess should be str, not unicode. 2013-03-05 15:02:14-0800 [-] gitpoller: processing 0 changes: [] from "https://gitrepo.domain.com/Project/branch" 2013-03-05 15:02:14-0800 [-] while polling for changes Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1101, in gotResult _inlineCallbacks(r, g, deferred) --- --- File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1043, in _inlineCallbacks result = result.throwExceptionIntoGenerator(g) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/Library/Python/2.7/site- packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 109, in poll [self.repourl] + refspecs, path=self.workdir) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/Library/Python/2.7/site- packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 238, in _convert_nonzero_to_failure % (code, stderr)) exceptions.EnvironmentError: command failed with exit code 128: fatal: https://gitrepo.domain.com/Project/branch/info/refs not found: did you run git update-server-info on the server? The work directory looks fine. ~/buildmaster/gitpoller_work/Project-Branch-Version$ ls -al total 16 drwxr-xr-x 7 buildbot staff 238 Mar 5 18:22 . drwxr-xr-x 8 buildbot staff 272 Feb 28 14:31 .. -rw-r--r-- 1 buildbot staff 0 Mar 5 18:22 FETCH_HEAD -rw-r--r-- 1 buildbot staff 23 Feb 26 20:27 HEAD -rw-r--r-- 1 buildbot staff 85 Mar 5 18:22 config drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 objects drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 refs -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 6 10:23:15 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 10:23:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2465: "retry" option for checking out sources seems obsolete Message-ID: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> #2465: "retry" option for checking out sources seems obsolete ----------------------+----------------------- Reporter: hwoarang | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- Hi The website mentions the "retry" option here http://buildbot.net/buildbot/docs/latest/manual/cfg-buildsteps.html but looking at the source code, the "retry" option appears to be part of the /steps/source/oldsource.py which, if I understand correctly, should not be used anymore. Could you please update the documentation on the website to mention that this option is a Noop for new sources? Or could you bring it back as I find this option very useful when running multiple builders at the same time where all of them are cloning the same repository? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 6 10:43:30 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 10:43:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2466: Grid view should support multiple codebases Message-ID: <038.bb5f28357a1ddfd6d910f75e31849e5d@buildbot.net> #2466: Grid view should support multiple codebases ----------------------------+-------------------------------------------- Reporter: rutsky | Owner: Type: support-request | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Keywords: grid, tgrid, multiple codebase ----------------------------+-------------------------------------------- When using multiple codebases in builder Grid View and Transformed Grid View don't display build statuses and as revision displays revision of first codebase. See attached screenshots for examples. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 6 13:40:37 2013 From: noreply at github.com (GitHub) Date: Wed, 06 Mar 2013 05:40:37 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 7fa697: add buildrequests filtering by branch and project Message-ID: <51374755ae86c_5d4a10561342117e@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7fa6976f59ba6c42696cecee3f27fac9bd188472 https://github.com/buildbot/buildbot/commit/7fa6976f59ba6c42696cecee3f27fac9bd188472 Author: Jorge Gonzalez Date: 2013-02-28 (Thu, 28 Feb 2013) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py M master/docs/developer/database.rst M master/docs/relnotes/index.rst Log Message: ----------- add buildrequests filtering by branch and project Change-Id: I6b865a565a2bfc68be32e86f2e0d2172d768a60c Commit: c0041154525580eac66a59f96804a72fd1cb38c5 https://github.com/buildbot/buildbot/commit/c0041154525580eac66a59f96804a72fd1cb38c5 Author: Dustin J. Mitchell Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py M master/docs/developer/database.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'et_scheduler_local_max' of git://github.com/jgonzalezmendez/buildbot Compare: https://github.com/buildbot/buildbot/compare/6dfff6abd91d...c00411545255 From nobody at buildbot.net Wed Mar 6 15:40:14 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 15:40:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2467: source.SVN incorrectly handles repositories with special character in URL Message-ID: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> #2467: source.SVN incorrectly handles repositories with special character in URL -------------------+----------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Keywords: svn -------------------+----------------------- buildbot.steps.source.SVN checks is currently fetched repository is the same as set in configuration by running `svn info` and comparing returned URL with URL from configuration (see _sourcedirIsUpdatable()). If URL in configuration contains special characters or spaces, like "svn://example.org/my repo/", `svn info` returns URL in internal "canonical" form: "svn://example.org/my%20repo/". So Buildbot always thinks that repository changed, removes it and checks out again. As workaround you can specify URL in Buildbot configuration in canonical form: "svn://example.org/my%20repo/". P.S. Also, why parsing `svn info` result and not call `svn info --xml` and use XML reader? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 6 15:51:18 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 15:51:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2468: source.SVN doesn't obfuscate Subversion password Message-ID: <038.1701f17be2409a0a4c11aea03e7f3664@buildbot.net> #2468: source.SVN doesn't obfuscate Subversion password -------------------+----------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Keywords: -------------------+----------------------- buildbot.steps.source.SVN doesn't obfuscate Subversion password. As I see in code it obfuscates in slave-side SVN implementation, but not in master-side SVN. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 6 18:31:30 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 06 Mar 2013 18:31:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2466: Grid view should support multiple codebases In-Reply-To: <038.bb5f28357a1ddfd6d910f75e31849e5d@buildbot.net> References: <038.bb5f28357a1ddfd6d910f75e31849e5d@buildbot.net> Message-ID: <053.63194e298b6676fcf776ae6ec35e88af@buildbot.net> #2466: Grid view should support multiple codebases -------------------------------------------+------------------------ Reporter: rutsky | Owner: Type: support-request | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Resolution: Keywords: grid, tgrid, multiple codebase | -------------------------------------------+------------------------ Comment (by rutsky): I implemented fix for this issue, see https://github.com/buildbot/buildbot/pull/653. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 8 02:17:04 2013 From: noreply at github.com (GitHub) Date: Thu, 07 Mar 2013 18:17:04 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 6d9b35: Ignore std error on version discovery Message-ID: <51394a20cb9a1_521d6a412c24760@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6d9b3568b7fe8b8132acfa394cd8cb12997dae33 https://github.com/buildbot/buildbot/commit/6d9b3568b7fe8b8132acfa394cd8cb12997dae33 Author: Jorge Gonzalez Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/__init__.py Log Message: ----------- Ignore std error on version discovery git may print warnings out that can confuse the parsing, and std error could never provide a trustworthy errorn number anyway. (In my case, it was providing a tag name which provided a valid but undesirable match, so I was ending up with the wrong version number) Change-Id: I61bccacfff20fd4afd8ac8d73b69e2deab50d1c7 Commit: 775ee59465d1726f25a53594dee4a9bd8c1f3b88 https://github.com/buildbot/buildbot/commit/775ee59465d1726f25a53594dee4a9bd8c1f3b88 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/__init__.py Log Message: ----------- Merge branch 'et_setup_version' of git://github.com/jgonzalezmendez/buildbot Compare: https://github.com/buildbot/buildbot/compare/c00411545255...775ee59465d1 From noreply at github.com Fri Mar 8 02:27:04 2013 From: noreply at github.com (GitHub) Date: Thu, 07 Mar 2013 18:27:04 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 6a726a: Fix "proeprty" typo Message-ID: <51394c78c7e97_24b8106d12c2265@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6a726a75e7ca9948f4557b9aa320abc22a581e73 https://github.com/buildbot/buildbot/commit/6a726a75e7ca9948f4557b9aa320abc22a581e73 Author: Vladimir Rutsky Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/steps/source/base.py Log Message: ----------- Fix "proeprty" typo Commit: 8a07172c3a6ad8ebbc506d4415cf30c80bfd7a89 https://github.com/buildbot/buildbot/commit/8a07172c3a6ad8ebbc506d4415cf30c80bfd7a89 Author: Vladimir Rutsky Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- Fix PATCHLEVEL -> LEVEL typo Commit: 3c36ea75aceb36812e7e9663029a1a35e9cd22c4 https://github.com/buildbot/buildbot/commit/3c36ea75aceb36812e7e9663029a1a35e9cd22c4 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/sourcestamp.py M master/buildbot/steps/source/base.py Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/775ee59465d1...3c36ea75aceb From noreply at github.com Fri Mar 8 02:47:47 2013 From: noreply at github.com (GitHub) Date: Thu, 07 Mar 2013 18:47:47 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 9f9713: Handle multiple codebases in Grid and Transposed G... Message-ID: <51395153bd049_308952a1348694b@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9f97131df7f2920c1fc4deb8f96e37891afce59c https://github.com/buildbot/buildbot/commit/9f97131df7f2920c1fc4deb8f96e37891afce59c Author: Vladimir Rutsky Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py M master/buildbot/status/web/templates/grid_macros.html Log Message: ----------- Handle multiple codebases in Grid and Transposed Grid views Commit: ce98565e187b276ed80b29311b16a44d89c1f651 https://github.com/buildbot/buildbot/commit/ce98565e187b276ed80b29311b16a44d89c1f651 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py M master/buildbot/status/web/templates/grid_macros.html Log Message: ----------- Merge branch 'multiple_codebases_grids_view' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/3c36ea75aceb...ce98565e187b From noreply at github.com Fri Mar 8 03:08:19 2013 From: noreply at github.com (GitHub) Date: Thu, 07 Mar 2013 19:08:19 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] a151c3: db_poller isn't getting adjusted Message-ID: <51395623196c_381ed3813c915d7@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a151c353222214182e6b016155e7788c33e1deeb https://github.com/buildbot/buildbot/commit/a151c353222214182e6b016155e7788c33e1deeb Author: Maria Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/master.py Log Message: ----------- db_poller isn't getting adjusted At the time we call def reconfigService(self, new_config): self.config.db['db_poll_interval'] has the new value already assigned, so this comparison is never true https://github.com/buildbot/buildbot/blob/master/master/buildbot/master.py#L303 if (self.config.db['db_poll_interval'] != new_config.db['db_poll_interval']) and the db_poller isn't getting adjusted, changed the reconfigService implementations to store initial configuration in object attributes, and compare those attributes to new_config. Commit: df705bf445f906d0bab74b0aa5bcbc1f4ac01081 https://github.com/buildbot/buildbot/commit/df705bf445f906d0bab74b0aa5bcbc1f4ac01081 Author: mariangemarcano Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/master.py M master/docs/relnotes/index.rst Log Message: ----------- code review fixes - change configured_url -> configured_db_url - put all of the config-handling code in reconfigService - add release notes Commit: ceae3951e740d7bc948cd7478c017394a11991d7 https://github.com/buildbot/buildbot/commit/ceae3951e740d7bc948cd7478c017394a11991d7 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/test/unit/test_master.py Log Message: ----------- change tests to correspond Commit: 8e9433a024a448e4a65d3b154498ca21b7e0107c https://github.com/buildbot/buildbot/commit/8e9433a024a448e4a65d3b154498ca21b7e0107c Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/master.py M master/buildbot/test/unit/test_master.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pull639' Compare: https://github.com/buildbot/buildbot/compare/ce98565e187b...8e9433a024a4 From noreply at github.com Fri Mar 8 03:15:00 2013 From: noreply at github.com (GitHub) Date: Thu, 07 Mar 2013 19:15:00 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] 1e5c28: Uses XML output format of svn info to fetch url Message-ID: <513957b457988_3c85aec130109b8@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1e5c281380b267775c14ab53a3153f848286bd35 https://github.com/buildbot/buildbot/commit/1e5c281380b267775c14ab53a3153f848286bd35 Author: Shriram Kunchanapalli Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py Log Message: ----------- Uses XML output format of svn info to fetch url Regex was used with svn info output to fetch url value in SVN._sourcedirIsUpdatable. French and Norvegian svn versions use respective language names for url value and not 'URL' in regex. XML Output format of svn info resolves it Fixes http://trac.buildbot.net/ticket/2375 Commit: 3fc9d4096cadab7de57f8f922e6648d6c3b9633a https://github.com/buildbot/buildbot/commit/3fc9d4096cadab7de57f8f922e6648d6c3b9633a Author: Shriram Kunchanapalli Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes svn tests to match url value in XML output format of svn info Commit: 0feb7c5ca2d488b677721bf99e78dcdabd1b3b31 https://github.com/buildbot/buildbot/commit/0feb7c5ca2d488b677721bf99e78dcdabd1b3b31 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Merge branch '2375fix' of git://github.com/ShriramK/buildbot Commit: 16d87bb288171d3fe081f2978c294eda87c1a6bc https://github.com/buildbot/buildbot/commit/16d87bb288171d3fe081f2978c294eda87c1a6bc Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- pyflakes Compare: https://github.com/buildbot/buildbot/compare/8e9433a024a4...16d87bb28817 From nobody at buildbot.net Fri Mar 8 03:46:55 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 08 Mar 2013 03:46:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2465: "retry" option for checking out sources seems obsolete In-Reply-To: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> References: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> Message-ID: <055.abd176a8e425b3746161c93459166e22@buildbot.net> #2465: "retry" option for checking out sources seems obsolete --------------------------------------------+-------------------- Reporter: hwoarang | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: master-side-source-steps sprint | --------------------------------------------+-------------------- Changes (by dustin): * keywords: => master-side-source-steps sprint * type: undecided => defect * milestone: undecided => 0.8.+ Comment: It's present for git and repo, but missing for svn (#2357), bzr, cvs, and mercurial. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 8 03:47:40 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 08 Mar 2013 03:47:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2466: Grid view should support multiple codebases In-Reply-To: <038.bb5f28357a1ddfd6d910f75e31849e5d@buildbot.net> References: <038.bb5f28357a1ddfd6d910f75e31849e5d@buildbot.net> Message-ID: <053.73cf541a1f29e87b713ade5b5cdbe310@buildbot.net> #2466: Grid view should support multiple codebases -------------------------------------------+------------------------ Reporter: rutsky | Owner: Type: support-request | Status: closed Priority: major | Milestone: undecided Version: 0.8.7 | Resolution: fixed Keywords: grid, tgrid, multiple codebase | -------------------------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Thanks! The fix is merged -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 8 03:49:48 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 08 Mar 2013 03:49:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2468: source.SVN doesn't obfuscate Subversion password In-Reply-To: <038.1701f17be2409a0a4c11aea03e7f3664@buildbot.net> References: <038.1701f17be2409a0a4c11aea03e7f3664@buildbot.net> Message-ID: <053.4883ee07288549df9af52081159e2935@buildbot.net> #2468: source.SVN doesn't obfuscate Subversion password -----------------------------------------+-------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7 | Resolution: Keywords: master-side-source-steps svn | -----------------------------------------+-------------------- Changes (by dustin): * keywords: => master-side-source-steps svn * milestone: undecided => 0.8.+ Comment: This depends on #1748. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 8 03:52:06 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 08 Mar 2013 03:52:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2467: source.SVN incorrectly handles repositories with special character in URL In-Reply-To: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> References: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> Message-ID: <053.30b0bdf6d7dd837f5fe358b2237d541e@buildbot.net> #2467: source.SVN incorrectly handles repositories with special character in URL -------------------+------------------------ Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Resolution: Keywords: svn | -------------------+------------------------ Changes (by dustin): * cc: ShriramK (added) Comment: ShriramK just landed a patch to use `svn info --xml` instead for #2375. Can you verify that it works properly? https://github.com/buildbot/buildbot/commit/1e5c281380b267775c14ab53a3153f848286bd35 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 8 10:09:14 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 08 Mar 2013 10:09:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2465: "retry" option for checking out sources seems obsolete In-Reply-To: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> References: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> Message-ID: <055.00560f9c9aa42290cedda4b0fcdb9357@buildbot.net> #2465: "retry" option for checking out sources seems obsolete --------------------------------------------+-------------------- Reporter: hwoarang | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: master-side-source-steps sprint | --------------------------------------------+-------------------- Comment (by hwoarang): Are you sure that this is supposed to work in Git? I have retry=(60, 10) and whenever git fetch/clone fails, I see no retries. I see that steps/source/base.py accepts a retry= option, but this option is never used in steps/source/git.py. Do I miss something? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 8 18:21:26 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 08 Mar 2013 18:21:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2469: Can't have two HgPoller instances for two branches of the same repo Message-ID: <040.1a292f452986a056d69be41ed922883c@buildbot.net> #2469: Can't have two HgPoller instances for two branches of the same repo ----------------------+----------------------- Reporter: gracinet | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- This is because the service name is only made of the url, not of the combination of url and branch, and twisted does not allow that: {{{ --- --- File "/home/buildbot/lib/python2.6/site- packages/twisted/internet/defer.py", line 1071, in _inlineCallbacks result = g.send(result) File "/home/buildbot/lib/python2.6/site- packages/buildbot/changes/manager.py", line 62, in reconfigService src.setServiceParent(self) File "/home/buildbot/lib/python2.6/site- packages/twisted/application/service.py", line 186, in setServiceParent self.parent.addService(self) File "/home/buildbot/lib/python2.6/site- packages/twisted/application/service.py", line 303, in addService " '%s'" % service.name) exceptions.RuntimeError: cannot have two services with same name 'http://myrepo.example/' }}} Fix is really easy : just combine ```repourl``` and ```branch``` to get the service name. No time to do it properly right now, noted for future. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 9 18:04:16 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 09 Mar 2013 18:04:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods In-Reply-To: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> References: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> Message-ID: <053.4bdb0df7c7f2e27d838364d0cc7296e0@buildbot.net> #2237: Schedulers should have names and reconfigService methods -----------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: fixed Keywords: reconfig, sprint | -----------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This is fixed already in https://github.com/buildbot/buildbot/commit/b4fb9fbf2243db6d091202f58ced453483fecd29 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 9 20:11:25 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 09 Mar 2013 20:11:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1038: Audit TimerService / other looping calls In-Reply-To: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> References: <038.4c96b15288faad52c58d8f2a564849bf@buildbot.net> Message-ID: <053.186b4c6f0012c2a2b65a877e341e8727@buildbot.net> #1038: Audit TimerService / other looping calls -------------------+--------------------- Reporter: catlee | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.1 | Resolution: fixed Keywords: simple | -------------------+--------------------- Comment (by Dustin J. Mitchell): add warning about LoopingCall and TimerService; refs #1038 Changeset: ff2acf8cb58489a82811b4b5891f00ac36e63e35 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 9 20:11:24 2013 From: noreply at github.com (GitHub) Date: Sat, 09 Mar 2013 12:11:24 -0800 Subject: [Buildbot-commits] [buildbot/buildbot] b5768a: Builds on language environment patch from Alice fo... Message-ID: <513b976cbd8a_47fd129f134849ee@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: b5768a4cf6521b1cd2e4a113c5e210d9759d133a https://github.com/buildbot/buildbot/commit/b5768a4cf6521b1cd2e4a113c5e210d9759d133a Author: Shriram Kunchanapalli Date: 2013-01-12 (Sat, 12 Jan 2013) Changed paths: M master/buildbot/steps/source/svn.py Log Message: ----------- Builds on language environment patch from Alice for ticket 2419 Commit: b975815821a246b6df6cf6fe7b13b5edbe0b399b https://github.com/buildbot/buildbot/commit/b975815821a246b6df6cf6fe7b13b5edbe0b399b Author: Shriram Kunchanapalli Date: 2013-01-17 (Thu, 17 Jan 2013) Changed paths: M master/buildbot/steps/source/svn.py Log Message: ----------- As per irc discussion with tomprince, wrapped 'getElementsByTagName' in try and added code for storing in Step log file. Addresses log.err issue in pull request comment Commit: 7ec49b2183865e11a3d068be80acdb5c19284086 https://github.com/buildbot/buildbot/commit/7ec49b2183865e11a3d068be80acdb5c19284086 Author: Shriram Kunchanapalli Date: 2013-01-20 (Sun, 20 Jan 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Partial Test changes for 2419fix Commit: 7df0f7bd8f58f557fecee3b893ffe54ad4c6a12b https://github.com/buildbot/buildbot/commit/7df0f7bd8f58f557fecee3b893ffe54ad4c6a12b Author: Shriram Kunchanapalli Date: 2013-01-26 (Sat, 26 Jan 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Modified as per recent comments in pull request and discussion on IRC. Added test changes for failure conditions for parseGotRevision Commit: 163c0083031bfab46c82b0053affad0ad371335a https://github.com/buildbot/buildbot/commit/163c0083031bfab46c82b0053affad0ad371335a Author: Shriram Kunchanapalli Date: 2013-01-26 (Sat, 26 Jan 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes the function definition with the proper check in test revision for integer value case Commit: becafc679a1e386f22bda9fae38e3c5087dba04a https://github.com/buildbot/buildbot/commit/becafc679a1e386f22bda9fae38e3c5087dba04a Author: Shriram Kunchanapalli Date: 2013-02-12 (Tue, 12 Feb 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes incorrect symbol used in test function, and indentation Commit: 82ccb0418d2dfc7c2c21e70a5fe620f6e95523e8 https://github.com/buildbot/buildbot/commit/82ccb0418d2dfc7c2c21e70a5fe620f6e95523e8 Author: Shriram Kunchanapalli Date: 2013-02-16 (Sat, 16 Feb 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes test_corrupt_xml and updated broken test_revision_non_integer Commit: 101c137666ca961dbe4583bf2bd8f16eb31b5a75 https://github.com/buildbot/buildbot/commit/101c137666ca961dbe4583bf2bd8f16eb31b5a75 Author: Shriram Kunchanapalli Date: 2013-02-19 (Tue, 19 Feb 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes test_revision_noninteger function Commit: a90720c28d15b3ec7f1d38b9f14b9e56800946ef https://github.com/buildbot/buildbot/commit/a90720c28d15b3ec7f1d38b9f14b9e56800946ef Author: Shriram Kunchanapalli Date: 2013-02-20 (Wed, 20 Feb 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes test_getUnversionedFiles_corrupted_xml test Commit: ff574533773bd3bc978befa4c965bca1f097a733 https://github.com/buildbot/buildbot/commit/ff574533773bd3bc978befa4c965bca1f097a733 Author: Jared Grubb Date: 2013-02-23 (Sat, 23 Feb 2013) Changed paths: M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/templates/forms.html M master/buildbot/test/unit/test_schedulers_forcesched.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- DynamicChoiceStringParameter: a base class for dynamic lists in ForceScheduler Provide a better mechanism for generating dynamic content for ForceScheduler, and adjust the InheritBuildParameter to use this new base class. Commit: 1076819a51f96b76ae013bc14a7225b07b54d342 https://github.com/buildbot/buildbot/commit/1076819a51f96b76ae013bc14a7225b07b54d342 Author: Jared Grubb Date: 2013-02-24 (Sun, 24 Feb 2013) Changed paths: M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/templates/forms.html M master/buildbot/test/unit/test_schedulers_forcesched.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- ChoiceStringParameter.getChoices: use a member function instead of DynamicStringChoiceParameter Commit: 247ff445cd50fdf191ee6439f0553a88178ded65 https://github.com/buildbot/buildbot/commit/247ff445cd50fdf191ee6439f0553a88178ded65 Author: Jared Grubb Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- ChoiceStringParameter.getChoices: a bit more documentation Commit: 8b32e52d2d9dd9a35683c1bdb51e13d7f2a4f8bb https://github.com/buildbot/buildbot/commit/8b32e52d2d9dd9a35683c1bdb51e13d7f2a4f8bb Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- cli: removed unreachable code in scripts.runner Removed unreachable code in scripts.runner.SendChangeOptions.postOptions() method. 'who' and 'master' are listed as required options for 'sendchange' subcommand. The postOptions() will not be called unless both 'who' and 'master' options are specified. Commit: 80d5819a20be6b80ef3795f3e148854e2127e12e https://github.com/buildbot/buildbot/commit/80d5819a20be6b80ef3795f3e148854e2127e12e Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- unit tests of invalid 'buildbot user' command's options Unit tests on exception code paths in scripts.runner.UserOptions.postOptions(). Check that various invalid options combinations for 'buildbot user' subcommand raises the usage.UsageError exception. Commit: 838dfdb6fc796aec8fdf47f5139b1dcfe704647d https://github.com/buildbot/buildbot/commit/838dfdb6fc796aec8fdf47f5139b1dcfe704647d Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- cli: broke-out code to validate master option into a function Commit: b19daf57d49b644a10d0ce79e75979e4aa12dfca https://github.com/buildbot/buildbot/commit/b19daf57d49b644a10d0ce79e75979e4aa12dfca Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- cli: validate master option for 'buildbot sendchange' command If master (-m, --master) option is not valid, print user friendly error message "master must have the form 'hostname:port'". Commit: 41f22d8be699523012f5e01b31027f5eae5717f1 https://github.com/buildbot/buildbot/commit/41f22d8be699523012f5e01b31027f5eae5717f1 Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- cli: validate master option for 'statuslog' and 'statusgui' commands For 'buildbot statuslog' and 'buildbot statusgui' subcommands, validate master (-m, --master) option. If not valid print user friendly error message "master must have the form 'hostname:port'". Commit: 3d3c8bad8c7957b7b06658211d866432c4ad4ded https://github.com/buildbot/buildbot/commit/3d3c8bad8c7957b7b06658211d866432c4ad4ded Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- cli: validate master option for 'buildbot debugclient' command If master (-m, --master) option is not valid, print user friendly error message "master must have the form 'hostname:port'". Commit: 055896ae8bbfc29142032cf7a0c1a41c9dc38ae5 https://github.com/buildbot/buildbot/commit/055896ae8bbfc29142032cf7a0c1a41c9dc38ae5 Author: Elmir Jagudin Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- cli: validate master option for 'buildbot try' command When connection type 'pb' is specified, check that master option (-m, --master) is present and have valid syntax. If master is missing or have invalid syntax, print user friendly error message. Commit: ede2a911e3229bf4bf2fa3180d6252a06adf082a https://github.com/buildbot/buildbot/commit/ede2a911e3229bf4bf2fa3180d6252a06adf082a Author: Dustin J. Mitchell Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'cli-option-master' of git://github.com/elmirjagudin/buildbot Commit: c599ace35673804f48951ff20781ec40027bdbac https://github.com/buildbot/buildbot/commit/c599ace35673804f48951ff20781ec40027bdbac Author: Dustin J. Mitchell Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/templates/forms.html M master/buildbot/test/unit/test_schedulers_forcesched.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'DynamicParameter' of git://github.com/jaredgrubb/buildbot Commit: 100a4cee48a711a0e13d0f4c3168c7ef8d56b555 https://github.com/buildbot/buildbot/commit/100a4cee48a711a0e13d0f4c3168c7ef8d56b555 Author: Sean Kelly Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- Fix latent buildslave's _soft_disconnect method This derives entirely from https://gist.github.com/seankelly/5034964, primarily written by Jc2k. Commit: dfbcaf84bef1c25af210f29dfd4a2c3380b91bde https://github.com/buildbot/buildbot/commit/dfbcaf84bef1c25af210f29dfd4a2c3380b91bde Author: Dustin J. Mitchell Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/buildslave.py M master/docs/relnotes/index.rst Log Message: ----------- cleanup * add relnote * add a comment * wrap long line * and add some error handling Commit: 532a0ed5a62839b5ac9ea36d152de1fc3c91d6c2 https://github.com/buildbot/buildbot/commit/532a0ed5a62839b5ac9ea36d152de1fc3c91d6c2 Author: Dustin J. Mitchell Date: 2013-02-25 (Mon, 25 Feb 2013) Changed paths: M master/buildbot/buildslave.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pull646' Commit: a62e36630c56fa6c9b528db8e606974fec8b9419 https://github.com/buildbot/buildbot/commit/a62e36630c56fa6c9b528db8e606974fec8b9419 Author: Shriram Kunchanapalli Date: 2013-02-27 (Wed, 27 Feb 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Merge remote-tracking branch 'origin/2419fix' into 2419fix Commit: 066b0e54554e6a52c873a3d703b309184225d081 https://github.com/buildbot/buildbot/commit/066b0e54554e6a52c873a3d703b309184225d081 Author: Jared Grubb Date: 2013-02-27 (Wed, 27 Feb 2013) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/schedulers/basic.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_basic.py M master/docs/relnotes/index.rst Log Message: ----------- Fixes #1808: use different treeStableTimer in AnyBranchScheduler for different sources Commit: 0b6661afbfab7005102cbd4a76a86624b7133199 https://github.com/buildbot/buildbot/commit/0b6661afbfab7005102cbd4a76a86624b7133199 Author: Tom Prince Date: 2013-02-27 (Wed, 27 Feb 2013) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- Remove suggestion that multi-codebase builds support is elusive. Commit: c30fb36e899c65d91134b2121a629119bdea6c12 https://github.com/buildbot/buildbot/commit/c30fb36e899c65d91134b2121a629119bdea6c12 Author: Dustin J. Mitchell Date: 2013-02-27 (Wed, 27 Feb 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Merge branch '2419fix' of git://github.com/ShriramK/buildbot Commit: 67d1a69a375221a528139954d2d3294eb8d8c31e https://github.com/buildbot/buildbot/commit/67d1a69a375221a528139954d2d3294eb8d8c31e Author: Dustin J. Mitchell Date: 2013-02-27 (Wed, 27 Feb 2013) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- fix small docs errors Commit: 7fa6976f59ba6c42696cecee3f27fac9bd188472 https://github.com/buildbot/buildbot/commit/7fa6976f59ba6c42696cecee3f27fac9bd188472 Author: Jorge Gonzalez Date: 2013-02-28 (Thu, 28 Feb 2013) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py M master/docs/developer/database.rst M master/docs/relnotes/index.rst Log Message: ----------- add buildrequests filtering by branch and project Change-Id: I6b865a565a2bfc68be32e86f2e0d2172d768a60c Commit: 5f5c26fb8ba84038d3ed5ba70585bb2355e19afc https://github.com/buildbot/buildbot/commit/5f5c26fb8ba84038d3ed5ba70585bb2355e19afc Author: Dustin J. Mitchell Date: 2013-03-01 (Fri, 01 Mar 2013) Changed paths: M master/docs/manual/customization.rst Log Message: ----------- fix example Commit: 88974e7532e393e89ab7d88e4cbbe35d3d980eb7 https://github.com/buildbot/buildbot/commit/88974e7532e393e89ab7d88e4cbbe35d3d980eb7 Author: Jared Grubb Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- SVN: Add option to use 'last chnaged' revision rather than global revision Commit: 4766c95e947ea637b8cddaa0bdbc8b082cbf95aa https://github.com/buildbot/buildbot/commit/4766c95e947ea637b8cddaa0bdbc8b082cbf95aa Author: Jared Grubb Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_builder.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- BuildslaveChoiceParameter and EnforceChosenSlave: force scheduler hooks for explicit slave control Commit: 3be4839eb7c93ad18f55a78c08d7a5c2574266f6 https://github.com/buildbot/buildbot/commit/3be4839eb7c93ad18f55a78c08d7a5c2574266f6 Author: Jared Grubb Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_builder.py M master/docs/manual/cfg-schedulers.rst Log Message: ----------- enforceChosenSlave: address review comments Commit: ff2acf8cb58489a82811b4b5891f00ac36e63e35 https://github.com/buildbot/buildbot/commit/ff2acf8cb58489a82811b4b5891f00ac36e63e35 Author: Dustin J. Mitchell Date: 2013-03-02 (Sat, 02 Mar 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- add warning about LoopingCall and TimerService; refs #1038 Commit: 3c8373d51ff87948c60dce45c05c4b2188761ac0 https://github.com/buildbot/buildbot/commit/3c8373d51ff87948c60dce45c05c4b2188761ac0 Author: Dustin J. Mitchell Date: 2013-03-03 (Sun, 03 Mar 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/unit/test_process_builder.py M master/docs/manual/cfg-schedulers.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'BuildslaveChoiceParameter' of git://github.com/jaredgrubb/buildbot Commit: 198029d0df4eedb0d57cb2082fb461d3382cd581 https://github.com/buildbot/buildbot/commit/198029d0df4eedb0d57cb2082fb461d3382cd581 Author: Dustin J. Mitchell Date: 2013-03-03 (Sun, 03 Mar 2013) Changed paths: M master/buildbot/db/schedulers.py M master/buildbot/schedulers/basic.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_schedulers_basic.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'treeStableTimer' of git://github.com/jaredgrubb/buildbot Commit: 6dfff6abd91def6701aab9279730c19efceedde4 https://github.com/buildbot/buildbot/commit/6dfff6abd91def6701aab9279730c19efceedde4 Author: Dustin J. Mitchell Date: 2013-03-03 (Sun, 03 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'SvnLastChangedRev' of git://github.com/jaredgrubb/buildbot Commit: 6d9b3568b7fe8b8132acfa394cd8cb12997dae33 https://github.com/buildbot/buildbot/commit/6d9b3568b7fe8b8132acfa394cd8cb12997dae33 Author: Jorge Gonzalez Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/__init__.py Log Message: ----------- Ignore std error on version discovery git may print warnings out that can confuse the parsing, and std error could never provide a trustworthy errorn number anyway. (In my case, it was providing a tag name which provided a valid but undesirable match, so I was ending up with the wrong version number) Change-Id: I61bccacfff20fd4afd8ac8d73b69e2deab50d1c7 Commit: 6a726a75e7ca9948f4557b9aa320abc22a581e73 https://github.com/buildbot/buildbot/commit/6a726a75e7ca9948f4557b9aa320abc22a581e73 Author: Vladimir Rutsky Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/steps/source/base.py Log Message: ----------- Fix "proeprty" typo Commit: 8a07172c3a6ad8ebbc506d4415cf30c80bfd7a89 https://github.com/buildbot/buildbot/commit/8a07172c3a6ad8ebbc506d4415cf30c80bfd7a89 Author: Vladimir Rutsky Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- Fix PATCHLEVEL -> LEVEL typo Commit: c0041154525580eac66a59f96804a72fd1cb38c5 https://github.com/buildbot/buildbot/commit/c0041154525580eac66a59f96804a72fd1cb38c5 Author: Dustin J. Mitchell Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/test/unit/test_db_buildrequests.py M master/docs/developer/database.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'et_scheduler_local_max' of git://github.com/jgonzalezmendez/buildbot Commit: 1e5c281380b267775c14ab53a3153f848286bd35 https://github.com/buildbot/buildbot/commit/1e5c281380b267775c14ab53a3153f848286bd35 Author: Shriram Kunchanapalli Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py Log Message: ----------- Uses XML output format of svn info to fetch url Regex was used with svn info output to fetch url value in SVN._sourcedirIsUpdatable. French and Norvegian svn versions use respective language names for url value and not 'URL' in regex. XML Output format of svn info resolves it Fixes http://trac.buildbot.net/ticket/2375 Commit: 3fc9d4096cadab7de57f8f922e6648d6c3b9633a https://github.com/buildbot/buildbot/commit/3fc9d4096cadab7de57f8f922e6648d6c3b9633a Author: Shriram Kunchanapalli Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Fixes svn tests to match url value in XML output format of svn info Commit: a151c353222214182e6b016155e7788c33e1deeb https://github.com/buildbot/buildbot/commit/a151c353222214182e6b016155e7788c33e1deeb Author: Maria Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/master.py Log Message: ----------- db_poller isn't getting adjusted At the time we call def reconfigService(self, new_config): self.config.db['db_poll_interval'] has the new value already assigned, so this comparison is never true https://github.com/buildbot/buildbot/blob/master/master/buildbot/master.py#L303 if (self.config.db['db_poll_interval'] != new_config.db['db_poll_interval']) and the db_poller isn't getting adjusted, changed the reconfigService implementations to store initial configuration in object attributes, and compare those attributes to new_config. Commit: df705bf445f906d0bab74b0aa5bcbc1f4ac01081 https://github.com/buildbot/buildbot/commit/df705bf445f906d0bab74b0aa5bcbc1f4ac01081 Author: mariangemarcano Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/master.py M master/docs/relnotes/index.rst Log Message: ----------- code review fixes - change configured_url -> configured_db_url - put all of the config-handling code in reconfigService - add release notes Commit: 9f97131df7f2920c1fc4deb8f96e37891afce59c https://github.com/buildbot/buildbot/commit/9f97131df7f2920c1fc4deb8f96e37891afce59c Author: Vladimir Rutsky Date: 2013-03-06 (Wed, 06 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py M master/buildbot/status/web/templates/grid_macros.html Log Message: ----------- Handle multiple codebases in Grid and Transposed Grid views Commit: 775ee59465d1726f25a53594dee4a9bd8c1f3b88 https://github.com/buildbot/buildbot/commit/775ee59465d1726f25a53594dee4a9bd8c1f3b88 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/__init__.py Log Message: ----------- Merge branch 'et_setup_version' of git://github.com/jgonzalezmendez/buildbot Commit: 3c36ea75aceb36812e7e9663029a1a35e9cd22c4 https://github.com/buildbot/buildbot/commit/3c36ea75aceb36812e7e9663029a1a35e9cd22c4 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/sourcestamp.py M master/buildbot/steps/source/base.py Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Commit: ce98565e187b276ed80b29311b16a44d89c1f651 https://github.com/buildbot/buildbot/commit/ce98565e187b276ed80b29311b16a44d89c1f651 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py M master/buildbot/status/web/templates/grid_macros.html Log Message: ----------- Merge branch 'multiple_codebases_grids_view' of git://github.com/vrutsky/buildbot Commit: ceae3951e740d7bc948cd7478c017394a11991d7 https://github.com/buildbot/buildbot/commit/ceae3951e740d7bc948cd7478c017394a11991d7 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/test/unit/test_master.py Log Message: ----------- change tests to correspond Commit: 8e9433a024a448e4a65d3b154498ca21b7e0107c https://github.com/buildbot/buildbot/commit/8e9433a024a448e4a65d3b154498ca21b7e0107c Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/master.py M master/buildbot/test/unit/test_master.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pull639' Commit: 0feb7c5ca2d488b677721bf99e78dcdabd1b3b31 https://github.com/buildbot/buildbot/commit/0feb7c5ca2d488b677721bf99e78dcdabd1b3b31 Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Merge branch '2375fix' of git://github.com/ShriramK/buildbot Commit: 16d87bb288171d3fe081f2978c294eda87c1a6bc https://github.com/buildbot/buildbot/commit/16d87bb288171d3fe081f2978c294eda87c1a6bc Author: Dustin J. Mitchell Date: 2013-03-07 (Thu, 07 Mar 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- pyflakes Commit: c524031279da0122f913b0eee49e876d7db9d5a7 https://github.com/buildbot/buildbot/commit/c524031279da0122f913b0eee49e876d7db9d5a7 Author: Dustin J. Mitchell Date: 2013-03-09 (Sat, 09 Mar 2013) Changed paths: M README.md Log Message: ----------- add a few README.md items Commit: 3fca306ec0e18cea71ab3371b791824b84177e89 https://github.com/buildbot/buildbot/commit/3fca306ec0e18cea71ab3371b791824b84177e89 Author: Dustin J. Mitchell Date: 2013-03-09 (Sat, 09 Mar 2013) Changed paths: M master/buildbot/__init__.py M master/buildbot/buildslave.py M master/buildbot/db/buildrequests.py M master/buildbot/db/schedulers.py M master/buildbot/master.py M master/buildbot/process/builder.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/forcesched.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/templates/forms.html M master/buildbot/status/web/templates/grid_macros.html M master/buildbot/steps/source/base.py M master/buildbot/steps/source/svn.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_db_schedulers.py M master/buildbot/test/unit/test_master.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/db.rst M master/docs/developer/style.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/customization.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/a8a4e115b736...3fca306ec0e1 From nobody at buildbot.net Sat Mar 9 20:11:25 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 09 Mar 2013 20:11:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net> Message-ID: <054.c64672773cea87b021a80c86c60404e0@buildbot.net> #1808: Scheduler with treeStableTimer "merges" changes to multiple projects into single SourceStamp --------------------+------------------------- Reporter: aivarsk | Owner: jaredgrubb Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: sprint | --------------------+------------------------- Comment (by Jared Grubb): Fixes #1808: use different treeStableTimer in AnyBranchScheduler for different sources Changeset: 066b0e54554e6a52c873a3d703b309184225d081 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 9 20:24:02 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 09 Mar 2013 20:24:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2464: gitpoller dying In-Reply-To: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> References: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> Message-ID: <054.fcc95fe1ae396ba7d8bbd813a7f2adac@buildbot.net> #2464: gitpoller dying ----------------------+------------------------ Reporter: virgilg | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Description changed by dustin: Old description: > After a buildmaster restart (buildmaster 0.8.7p1 on OS X 10.8.2) we're > getting the following traceback: > > 2013-03-05 15:02:14-0800 [-] > /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/utils.py:25: > exceptions.DeprecationWarning: Argument strings and environment > keys/values passed to reactor.spawnProcess should be str, not unicode. > 2013-03-05 15:02:14-0800 [-] gitpoller: processing 0 changes: [] from > "https://gitrepo.domain.com/Project/branch" > 2013-03-05 15:02:14-0800 [-] while polling for changes > Traceback (most recent call last): > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 368, in callback > self._startRunCallbacks(result) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 464, in _startRunCallbacks > self._runCallbacks() > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 551, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 1101, in gotResult > _inlineCallbacks(r, g, deferred) > --- --- > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 1043, in _inlineCallbacks > result = result.throwExceptionIntoGenerator(g) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/python/failure.py", > line 382, in throwExceptionIntoGenerator > return g.throw(self.type, self.value, self.tb) > File "/Library/Python/2.7/site- > packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line > 109, in poll > [self.repourl] + refspecs, path=self.workdir) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 551, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File "/Library/Python/2.7/site- > packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line > 238, in _convert_nonzero_to_failure > % (code, stderr)) > exceptions.EnvironmentError: command failed with exit code 128: > fatal: https://gitrepo.domain.com/Project/branch/info/refs not found: did > you run git update-server-info on the server? > > The work directory looks fine. > ~/buildmaster/gitpoller_work/Project-Branch-Version$ ls -al > total 16 > drwxr-xr-x 7 buildbot staff 238 Mar 5 18:22 . > drwxr-xr-x 8 buildbot staff 272 Feb 28 14:31 .. > -rw-r--r-- 1 buildbot staff 0 Mar 5 18:22 FETCH_HEAD > -rw-r--r-- 1 buildbot staff 23 Feb 26 20:27 HEAD > -rw-r--r-- 1 buildbot staff 85 Mar 5 18:22 config > drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 objects > drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 refs New description: After a buildmaster restart (buildmaster 0.8.7p1 on OS X 10.8.2) we're getting the following traceback: {{{ 2013-03-05 15:02:14-0800 [-] /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/utils.py:25: exceptions.DeprecationWarning: Argument strings and environment keys/values passed to reactor.spawnProcess should be str, not unicode. 2013-03-05 15:02:14-0800 [-] gitpoller: processing 0 changes: [] from "https://gitrepo.domain.com/Project/branch" 2013-03-05 15:02:14-0800 [-] while polling for changes Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1101, in gotResult _inlineCallbacks(r, g, deferred) --- --- File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1043, in _inlineCallbacks result = result.throwExceptionIntoGenerator(g) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/Library/Python/2.7/site- packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 109, in poll [self.repourl] + refspecs, path=self.workdir) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/Library/Python/2.7/site- packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 238, in _convert_nonzero_to_failure % (code, stderr)) exceptions.EnvironmentError: command failed with exit code 128: fatal: https://gitrepo.domain.com/Project/branch/info/refs not found: did you run git update-server-info on the server? }}} The work directory looks fine. {{{ ~/buildmaster/gitpoller_work/Project-Branch-Version$ ls -al total 16 drwxr-xr-x 7 buildbot staff 238 Mar 5 18:22 . drwxr-xr-x 8 buildbot staff 272 Feb 28 14:31 .. -rw-r--r-- 1 buildbot staff 0 Mar 5 18:22 FETCH_HEAD -rw-r--r-- 1 buildbot staff 23 Feb 26 20:27 HEAD -rw-r--r-- 1 buildbot staff 85 Mar 5 18:22 config drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 objects drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 refs }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 9 20:25:18 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 09 Mar 2013 20:25:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2464: gitpoller dying In-Reply-To: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> References: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> Message-ID: <054.7bbcbce594d37ccfae49477e4338d419@buildbot.net> #2464: gitpoller dying ----------------------------+---------------------- Reporter: virgilg | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: | ----------------------------+---------------------- Changes (by dustin): * type: undecided => support-request * milestone: undecided => ongoing Comment: That looks like a git error. *Did* you run git update-server-info on the server? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Mar 9 20:59:19 2013 From: nobody at buildbot.net (Buildbot) Date: Sat, 09 Mar 2013 20:59:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2464: gitpoller dying In-Reply-To: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> References: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> Message-ID: <054.a86181b690ce0b45e7f8896fe7423662@buildbot.net> #2464: gitpoller dying ----------------------------+---------------------- Reporter: virgilg | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: | ----------------------------+---------------------- Comment (by virgilg): It certainly looks like a git error, but I can't run git update-server- info because I don't control the server. I was more concerned about the traceback - should buildbot try and catch the exception in gitpoller.py or leave it fail like this? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 11 02:54:07 2013 From: noreply at github.com (GitHub) Date: Sun, 10 Mar 2013 19:54:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dc3b52: add an 'identifier' type Message-ID: <513d474f27d08_72d04211343868f@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: dc3b5217b907d8148db6b850bcedafd9a264f4d3 https://github.com/buildbot/buildbot/commit/dc3b5217b907d8148db6b850bcedafd9a264f4d3 Author: Dustin J. Mitchell Date: 2013-03-10 (Sun, 10 Mar 2013) Changed paths: A master/buildbot/test/unit/test_util_typechecks.py M master/buildbot/test/util/validation.py A master/buildbot/util/typechecks.py M master/docs/developer/db.rst M master/docs/developer/utils.rst Log Message: ----------- add an 'identifier' type Commit: 666a92d642024c12c47735b8b6f0c272ce8353da https://github.com/buildbot/buildbot/commit/666a92d642024c12c47735b8b6f0c272ce8353da Author: Dustin J. Mitchell Date: 2013-03-10 (Sun, 10 Mar 2013) Changed paths: A master/buildbot/test/unit/test_util_typechecks.py M master/buildbot/test/util/validation.py A master/buildbot/util/typechecks.py M master/docs/developer/db.rst M master/docs/developer/utils.rst Log Message: ----------- Merge branch '9/ident' into nine Compare: https://github.com/buildbot/buildbot/compare/3fca306ec0e1...666a92d64202 From nobody at buildbot.net Mon Mar 11 13:05:36 2013 From: nobody at buildbot.net (Buildbot) Date: Mon, 11 Mar 2013 13:05:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2465: "retry" option for checking out sources seems obsolete In-Reply-To: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> References: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> Message-ID: <055.ed18497d71bd59b513bd24f2be74b6d2@buildbot.net> #2465: "retry" option for checking out sources seems obsolete --------------------------------------------+-------------------- Reporter: hwoarang | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: master-side-source-steps sprint | --------------------------------------------+-------------------- Comment (by dustin): I'm thinking of `retryFetch`, but you're right - that's not the same. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 11 13:15:46 2013 From: noreply at github.com (GitHub) Date: Mon, 11 Mar 2013 06:15:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c4a40d: unit test config.ConfigErrors.__str__() method Message-ID: <513dd90258748_7e3353d13071233@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c4a40d30240bdc9f1237ac9ba0083d69dc9ffdf1 https://github.com/buildbot/buildbot/commit/c4a40d30240bdc9f1237ac9ba0083d69dc9ffdf1 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test config.ConfigErrors.__str__() method Added unit test on config.ConfigErrors.__str__() method Commit: 1beffde8ee4f703023529adbcba692fc08743818 https://github.com/buildbot/buildbot/commit/1beffde8ee4f703023529adbcba692fc08743818 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test configure file open error in MasterConfig.loadConfig() Added a unit test that simulates IOError when opening configure file in config.MasterConfig.loadConfig(). Check that the expected ConfigErrors exception is rised. Commit: 7cc54916bdfb792e83bb4884ed1271bdc7d9eea7 https://github.com/buildbot/buildbot/commit/7cc54916bdfb792e83bb4884ed1271bdc7d9eea7 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/config.py Log Message: ----------- removed unreachable code in config.MasterConfig.loadConfig() The call to error() with global _errors set to None, will raise an exception. Thus following 'raise errors' is never reached. Commit: 31b3c1e39fa377e607a5f38ebeeb21bfc50811cc https://github.com/buildbot/buildbot/commit/31b3c1e39fa377e607a5f38ebeeb21bfc50811cc Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test on loading 'codebaseGenerator' master parameter Added unit tests on code in buildbot.config.MasterConfig.load_global() that loads 'codebaseGenerator' master configuration parameter. Test both loading correct parameter and invalid. Commit: ba0529e179af616f6927189fba579b2476188280 https://github.com/buildbot/buildbot/commit/ba0529e179af616f6927189fba579b2476188280 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test error paths in MasterConfig.load_status() Test that invalid 'status' option in master config file is handled properly. Commit: 628eaee6c5cfc4ab83972e7fd59fb22c8acb586f https://github.com/buildbot/buildbot/commit/628eaee6c5cfc4ab83972e7fd59fb22c8acb586f Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test error paths in BuilderConfig.__init__() Test that invalid nextSlave, nextBuild, canStartBuild and env arguments to BuilderConfig constructor are handled properly. Commit: d54df6145022389562ac85054fe2590f61c9f4ab https://github.com/buildbot/buildbot/commit/d54df6145022389562ac85054fe2590f61c9f4ab Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- updated buildbot.config.MasterConfig.check_locks() unit tests Updated unit tests of buildbot.config.MasterConfig.check_locks() method to use lock objects wrapped inside LockAccess objects. Nowadays this is the recommended style of specifying locks in the documentation. Add one new unit test to check that using 'bare' lock objects still works. Commit: 130bbad600dfcd65d9599bb8ab325b3a5381abaf https://github.com/buildbot/buildbot/commit/130bbad600dfcd65d9599bb8ab325b3a5381abaf Author: Elmir Jagudin Date: 2013-03-08 (Fri, 08 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- use self.patch() to override open() in unit test Using TestCase.patch() method to override buildin open() in a unit test is much cleaner. Commit: acfa823027400c8e5732242f6fc2d4d4778ce86b https://github.com/buildbot/buildbot/commit/acfa823027400c8e5732242f6fc2d4d4778ce86b Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Merge branch 'config-unit-tests' of git://github.com/elmirjagudin/buildbot Commit: ede1de82c209e4b924f0a1d594371016a3879876 https://github.com/buildbot/buildbot/commit/ede1de82c209e4b924f0a1d594371016a3879876 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/contrib/post_build_request.py Log Message: ----------- fix typo Compare: https://github.com/buildbot/buildbot/compare/16d87bb28817...ede1de82c209 From nobody at buildbot.net Mon Mar 11 20:35:41 2013 From: nobody at buildbot.net (Buildbot) Date: Mon, 11 Mar 2013 20:35:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2451: multiple events_ already exist In-Reply-To: <039.9824594468ddf045bef4131e8d1a1623@buildbot.net> References: <039.9824594468ddf045bef4131e8d1a1623@buildbot.net> Message-ID: <054.606ed9b8c4da449db03e30889a7c5c24@buildbot.net> #2451: multiple events_ already exist ----------------------+------------------------ Reporter: virgilg | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): The patch in #2450 seems to fix this - or at least make it not occur. virgilg's going to add {{{ #! patch diff --git a/master/buildbot/status/persistent_queue.py b/master/buildbot/status/persistent_queue.py index 0106a21..a4e5c11 100644 --- a/master/buildbot/status/persistent_queue.py +++ b/master/buildbot/status/persistent_queue.py @@ -151,6 +151,7 @@ class DiskQueue(object): self._nbItems = 0 # The actual items id start at one. self.firstItemId = 0 + print "DQ %d - init - lastItemId = 0" % (id(self),) self.lastItemId = 0 self._loadFromDisk() @@ -164,6 +165,7 @@ class DiskQueue(object): self.firstItemId = id + 1 else: self._nbItems += 1 + print "DQ %d - pushItem - lastItemId += 1 -> %d" % (id(self), self.lastItemId+1) self.lastItemId += 1 path = os.path.join(self.path, str(self.lastItemId)) if os.path.exists(path): @@ -245,6 +247,7 @@ class DiskQueue(object): if self._nbItems: self.firstItemId = files[0] self.lastItemId = files[-1] + print "DQ %d - _loadFromDisk - lastItemId = %d" % (id(self), self.lastItemId) class PersistentQueue(object): }}} and reproduce. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 12 03:04:54 2013 From: nobody at buildbot.net (Buildbot) Date: Tue, 12 Mar 2013 03:04:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2464: gitpoller dying In-Reply-To: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> References: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> Message-ID: <054.d5609b392efdbaa87fe5f080c30cfe6f@buildbot.net> #2464: gitpoller dying ---------------------------+-------------------- Reporter: virgilg | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: simple, sprint | ---------------------------+-------------------- Changes (by dustin): * keywords: => simple, sprint * type: support-request => enhancement * milestone: ongoing => 0.8.+ Comment: Well, it caught it and reported it to you, basically. Although in this case most of the traceback was unnecessary, in general it's helpful for us Buildbotters to see the whole traceback when something goes awry. It wouldn't be a bad patch to catch !EnvironmentError and do something more sensible with it. Otherwise, I'm not so worried about it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Mar 12 19:02:30 2013 From: nobody at buildbot.net (Buildbot) Date: Tue, 12 Mar 2013 19:02:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2437: New Master-Slave Protocol In-Reply-To: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> References: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> Message-ID: <053.edf0bc38bd5bf84673a7146a919fde8a@buildbot.net> #2437: New Master-Slave Protocol -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Changes (by jaredgrubb): * cc: jaredgrubb@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 13 01:46:30 2013 From: noreply at github.com (GitHub) Date: Tue, 12 Mar 2013 18:46:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e8d2d3: don't try to detect bug1810 more than once Message-ID: <513fda76af0f2_244687213459654@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e8d2d3927ef71a1b972d8e28e38e1c7f30906478 https://github.com/buildbot/buildbot/commit/e8d2d3927ef71a1b972d8e28e38e1c7f30906478 Author: Dustin J. Mitchell Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- don't try to detect bug1810 more than once From noreply at github.com Wed Mar 13 01:52:27 2013 From: noreply at github.com (GitHub) Date: Tue, 12 Mar 2013 18:52:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9ecd9b: fix pyflakes Message-ID: <513fdbdbdda63_18286f912c4049e@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9ecd9bac3e4da47aed0ff73879b700882a242ac2 https://github.com/buildbot/buildbot/commit/9ecd9bac3e4da47aed0ff73879b700882a242ac2 Author: Dustin J. Mitchell Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/status/logfile.py M master/buildbot/test/unit/test_scripts_start.py Log Message: ----------- fix pyflakes From noreply at github.com Wed Mar 13 02:03:42 2013 From: noreply at github.com (GitHub) Date: Tue, 12 Mar 2013 19:03:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] babdbe: correct fix for pyflakes Message-ID: <513fde7e7fe29_6f717c4138400b9@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: babdbe970477b12d8e2070801cbf3407c33e686e https://github.com/buildbot/buildbot/commit/babdbe970477b12d8e2070801cbf3407c33e686e Author: Dustin J. Mitchell Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/test/unit/test_scripts_start.py Log Message: ----------- correct fix for pyflakes From nobody at buildbot.net Wed Mar 13 12:33:51 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 13 Mar 2013 12:33:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2467: source.SVN incorrectly handles repositories with special character in URL In-Reply-To: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> References: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> Message-ID: <053.ccda05a1ab7bebb6389021f7d347c0c9@buildbot.net> #2467: source.SVN incorrectly handles repositories with special character in URL -------------------+------------------------ Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Resolution: Keywords: svn | -------------------+------------------------ Comment (by rutsky): "svn info --xml" is unrelated to this issue actually. This bug report about comparison of Subversion repository URL-s. Error-prone code is this: {{{defer.returnValue(extractedurl == self.repourl)}}} in {{{_sourcedirIsUpdatable()}}} method (buildbot/steps/source/svn.py). {{{self.repourl}}} is converted in Subversion with {{{svn_uri_canonicalize()}}} function (https://svn.apache.org/repos/asf/subversion/trunk/subversion/libsvn_subr/dirent_uri.c), so correct comparison should look like {{{defer.returnValue(extractedurl == EMULATE_svn_uri_canonicalize(self.repourl))}}} {{{EMULATE_svn_uri_canonicalize()}}}-like function should be implemented with same logic as Subversion's {{{svn_uri_canonicalize()}}}. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 13 12:58:45 2013 From: noreply at github.com (GitHub) Date: Wed, 13 Mar 2013 05:58:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7fd588: check if valid base dir on 'buildslave upgrade-sla... Message-ID: <51407805b822e_637141413c8890@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7fd588dbf7c215364cb348527eda3873d608d222 https://github.com/buildbot/buildbot/commit/7fd588dbf7c215364cb348527eda3873d608d222 Author: Elmir Jagudin Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M slave/buildslave/scripts/runner.py A slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- check if valid base dir on 'buildslave upgrade-slave' Check if we got a valid slave base dir on 'buildslave upgrade-slave' cli command. If not, print error message and exit. Commit: d73475e1ef6baa443b272afaa04396f39c3d0042 https://github.com/buildbot/buildbot/commit/d73475e1ef6baa443b272afaa04396f39c3d0042 Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M slave/buildslave/scripts/runner.py A slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'upgrade-slave-chk-basedir' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/babdbe970477...d73475e1ef6b From nobody at buildbot.net Wed Mar 13 14:59:55 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 13 Mar 2013 14:59:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2409: Use DeferredLock.run in preference to .acquire + .release. In-Reply-To: <042.a933674536b648553a0f9a92a682bc6b@buildbot.net> References: <042.a933674536b648553a0f9a92a682bc6b@buildbot.net> Message-ID: <057.1b49723f0c62fcc6f64269e9ff36db3a@buildbot.net> #2409: Use DeferredLock.run in preference to .acquire + .release. --------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: Keywords: simple sprint | --------------------------+-------------------- Changes (by dustin): * type: task => enhancement -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 13 16:04:20 2013 From: noreply at github.com (GitHub) Date: Wed, 13 Mar 2013 09:04:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 928fa0: update README.md with :runner: for sprint tasks Message-ID: <5140a38491e1b_23c593b138267e2@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 928fa098a1f24a0b5c6ab154ecd715e9a1e33f99 https://github.com/buildbot/buildbot/commit/928fa098a1f24a0b5c6ab154ecd715e9a1e33f99 Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M README.md Log Message: ----------- update README.md with :runner: for sprint tasks From noreply at github.com Wed Mar 13 18:03:05 2013 From: noreply at github.com (GitHub) Date: Wed, 13 Mar 2013 11:03:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dce694: add Pierre to MAINTAINERS.txt Message-ID: <5140bf597c038_52eb111613c8312e@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dce6945d9b5d9d409a559b3e8a6134a896cb9318 https://github.com/buildbot/buildbot/commit/dce6945d9b5d9d409a559b3e8a6134a896cb9318 Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M MAINTAINERS.txt Log Message: ----------- add Pierre to MAINTAINERS.txt From nobody at buildbot.net Wed Mar 13 18:11:03 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 13 Mar 2013 18:11:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2470: relicense documentation under GPLv2 Message-ID: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> #2470: relicense documentation under GPLv2 ------------------------+-------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: minor | Milestone: 0.8.8 Version: 0.8.7p1 | Keywords: docs ------------------------+-------------------- Since I was a lad, the Buildbot docs have said {{{ Copying and distribution of this file, with or without modification, are permitted in any medium without royalty provided the copyright notice and this notice are preserved. }}} which is different from the GPLv2 license that applies to the rest of the project. We should make those match, both for consistency and to make it obvious that the entire project is licensed under an OSI-approved license. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 13 18:18:29 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 13 Mar 2013 18:18:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2470: relicense documentation under GPLv2 In-Reply-To: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> References: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> Message-ID: <053.7bbf5ec53fcb9fce98b10b94afecea8c@buildbot.net> #2470: relicense documentation under GPLv2 ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: minor | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: Keywords: docs | ------------------------+--------------------- Comment (by warner): sounds good to me! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Mar 13 19:12:07 2013 From: nobody at buildbot.net (Buildbot) Date: Wed, 13 Mar 2013 19:12:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2470: relicense documentation under GPLv2 In-Reply-To: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> References: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> Message-ID: <053.78cced98441aef4f36363e000488df14@buildbot.net> #2470: relicense documentation under GPLv2 ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Include docs under GPLv2. Fixes #2470. The docs were previously under an unspecified free-with-copyright clause, which appears to allow such relicensing. Anyway, Warner is OK with the change. Changeset: 094ec10056019feebc243de9fa95d0d402398e7e -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 13 19:12:06 2013 From: noreply at github.com (GitHub) Date: Wed, 13 Mar 2013 12:12:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 094ec1: Include docs under GPLv2. Message-ID: <5140cf864885b_305ff7812c391cb@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 094ec10056019feebc243de9fa95d0d402398e7e https://github.com/buildbot/buildbot/commit/094ec10056019feebc243de9fa95d0d402398e7e Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/docs/index.rst Log Message: ----------- Include docs under GPLv2. Fixes #2470. The docs were previously under an unspecified free-with-copyright clause, which appears to allow such relicensing. Anyway, Warner is OK with the change. From nobody at buildbot.net Thu Mar 14 10:46:43 2013 From: nobody at buildbot.net (Buildbot) Date: Thu, 14 Mar 2013 10:46:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1019: buildbot.net isn't a good mail-sender In-Reply-To: <038.b43b22f572357e15ade829210d7884dd@buildbot.net> References: <038.b43b22f572357e15ade829210d7884dd@buildbot.net> Message-ID: <053.0ed4ffbd309fe6c40087905f81cf2a1a@buildbot.net> #1019: buildbot.net isn't a good mail-sender -------------------+----------------------- Reporter: dustin | Owner: verm Type: task | Status: assigned Priority: major | Milestone: ongoing Version: 0.8.1 | Resolution: Keywords: admin | -------------------+----------------------- Old description: > speakeasy.net, at least, refuses to accept email from us: > > Oct 20 13:59:47 buildbot postfix/smtp[10148]: 6AECD98072: host > mx02.speakeasy.net[69.17.117.60] said: 450 4.7.1 Client host rejected: > cannot find your reverse hostname, [67.18.176.221] (in reply to RCPT TO > command) > > I'll ping warner about this, but it will probably get fixed when we re- > host buildbot.net on another system somehow. New description: speakeasy.net, at least, refuses to accept email from us: Oct 20 13:59:47 buildbot postfix/smtp[10148]: 6AECD98072: host mx02.speakeasy.net[69.17.117.60] said: 450 4.7.1 Client host rejected: cannot find your reverse hostname, [67.18.176.221] (in reply to RCPT TO command) I'll ping warner about this, but it will probably get fixed when we re- host buildbot.net on another system somehow. -- Comment (by verm): testing mailer. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 14 21:46:53 2013 From: noreply at github.com (GitHub) Date: Thu, 14 Mar 2013 14:46:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e64675: Add a step resource, logs, and logchunks Message-ID: <5142454d626ea_215dd4b138409b2@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: e646754e71692fe304591b09752a3911299ceffe https://github.com/buildbot/buildbot/commit/e646754e71692fe304591b09752a3911299ceffe Author: Dustin J. Mitchell Date: 2013-03-10 (Sun, 10 Mar 2013) Changed paths: M README.md M master/buildbot/data/builds.py M master/buildbot/data/connector.py A master/buildbot/data/logs.py A master/buildbot/data/steps.py A master/buildbot/db/logs.py A master/buildbot/db/migrate/versions/028_statusdb_tables.py M master/buildbot/db/model.py A master/buildbot/db/steps.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_data_builds.py A master/buildbot/test/unit/test_data_logs.py A master/buildbot/test/unit/test_data_steps.py A master/buildbot/test/unit/test_db_logs.py A master/buildbot/test/unit/test_db_migrate_versions_028_statusdb_tables.py A master/buildbot/test/unit/test_db_steps.py M master/buildbot/test/unit/test_test_util_validation.py M master/buildbot/test/util/validation.py M master/buildbot/util/pathmatch.py M master/docs/developer/data.rst M master/docs/developer/db.rst M master/docs/developer/rtype-build.rst A master/docs/developer/rtype-log.rst A master/docs/developer/rtype-logchunk.rst A master/docs/developer/rtype-step.rst M master/docs/developer/tests.rst Log Message: ----------- Add a step resource, logs, and logchunks Commit: 5a2eac36f83c690d74b5320ece5c11cedef8487b https://github.com/buildbot/buildbot/commit/5a2eac36f83c690d74b5320ece5c11cedef8487b Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/test/unit/test_data_logs.py M master/buildbot/test/unit/test_db_logs.py M master/buildbot/test/unit/test_test_util_validation.py Log Message: ----------- fix tests to use identifiers Commit: fdcbb09d7b6c587aafdc5b97aae1f9f84ff3f863 https://github.com/buildbot/buildbot/commit/fdcbb09d7b6c587aafdc5b97aae1f9f84ff3f863 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/data/base.py M master/buildbot/data/logs.py M master/buildbot/data/steps.py Log Message: ----------- factor out common code for navigating the builder/build/step/log hierarchy Commit: ac57132cc692bcd41d8d0996c263ff4ad3b93021 https://github.com/buildbot/buildbot/commit/ac57132cc692bcd41d8d0996c263ff4ad3b93021 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/data/base.py M master/buildbot/data/builders.py M master/buildbot/data/builds.py M master/buildbot/data/buildsets.py M master/buildbot/data/changes.py M master/buildbot/data/connector.py M master/buildbot/data/logs.py M master/buildbot/data/masters.py M master/buildbot/data/schedulers.py M master/buildbot/data/sourcestamps.py M master/buildbot/data/steps.py M master/buildbot/data/testhooks.py M master/buildbot/test/unit/test_data_base.py M master/buildbot/test/unit/test_data_connector.py M master/buildbot/test/util/endpoint.py Log Message: ----------- Use URI-like strings to specify paths Commit: 17859e682d5eecef76d961d65851b94d454ccde9 https://github.com/buildbot/buildbot/commit/17859e682d5eecef76d961d65851b94d454ccde9 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/data/builders.py M master/buildbot/data/builds.py M master/buildbot/data/buildsets.py M master/buildbot/data/changes.py M master/buildbot/data/logs.py M master/buildbot/data/masters.py M master/buildbot/data/schedulers.py M master/buildbot/data/sourcestamps.py M master/buildbot/data/steps.py M master/buildbot/test/unit/test_data_connector.py M master/buildbot/test/unit/test_util_pathmatch.py M master/buildbot/util/pathmatch.py Log Message: ----------- use 'i:xx' for identifiers and 'n:xxx' for numbers Commit: 39493be8a49d72e81afe63d5b393e6adbcc21722 https://github.com/buildbot/buildbot/commit/39493be8a49d72e81afe63d5b393e6adbcc21722 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/data/logs.py M master/buildbot/data/steps.py M master/docs/developer/rtype-log.rst M master/docs/developer/rtype-logchunk.rst M master/docs/developer/rtype-step.rst Log Message: ----------- omit the /number/ to identify steps by number Commit: d30bbeb72a25288a16be98dc0897484720ff0357 https://github.com/buildbot/buildbot/commit/d30bbeb72a25288a16be98dc0897484720ff0357 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M README.md Log Message: ----------- update README.md Commit: 55be8ae8c41b5aa924d999e9f65bfa610d6ffcbc https://github.com/buildbot/buildbot/commit/55be8ae8c41b5aa924d999e9f65bfa610d6ffcbc Author: Dustin J. Mitchell Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/data/connector.py A master/buildbot/data/logchunks.py M master/buildbot/data/logs.py A master/buildbot/test/unit/test_data_logchunks.py M master/buildbot/test/unit/test_data_logs.py M master/docs/developer/rtype-log.rst M master/docs/developer/rtype-logchunk.rst M master/docs/developer/rtype-step.rst Log Message: ----------- move logchunks to their own resource type and module Commit: a80e97e178356fa63cc8596198347be00fd09de3 https://github.com/buildbot/buildbot/commit/a80e97e178356fa63cc8596198347be00fd09de3 Author: Dustin J. Mitchell Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/docs/developer/data.rst M master/docs/developer/utils.rst Log Message: ----------- update documentation for pathPatterns Commit: 419ba18fd0d7380800864282c0cb4972a2a8a5e0 https://github.com/buildbot/buildbot/commit/419ba18fd0d7380800864282c0cb4972a2a8a5e0 Author: Dustin J. Mitchell Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M README.md Log Message: ----------- update README.md Commit: 29c6cbce608d0d7262c9cb1d8dacba02ef760914 https://github.com/buildbot/buildbot/commit/29c6cbce608d0d7262c9cb1d8dacba02ef760914 Author: Dustin J. Mitchell Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M README.md M master/buildbot/data/base.py M master/buildbot/data/builders.py M master/buildbot/data/builds.py M master/buildbot/data/buildsets.py M master/buildbot/data/changes.py M master/buildbot/data/connector.py A master/buildbot/data/logchunks.py A master/buildbot/data/logs.py M master/buildbot/data/masters.py M master/buildbot/data/schedulers.py M master/buildbot/data/sourcestamps.py A master/buildbot/data/steps.py M master/buildbot/data/testhooks.py A master/buildbot/db/logs.py A master/buildbot/db/migrate/versions/028_statusdb_tables.py M master/buildbot/db/model.py A master/buildbot/db/steps.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_data_base.py M master/buildbot/test/unit/test_data_builds.py M master/buildbot/test/unit/test_data_connector.py A master/buildbot/test/unit/test_data_logchunks.py A master/buildbot/test/unit/test_data_logs.py A master/buildbot/test/unit/test_data_steps.py A master/buildbot/test/unit/test_db_logs.py A master/buildbot/test/unit/test_db_migrate_versions_028_statusdb_tables.py A master/buildbot/test/unit/test_db_steps.py M master/buildbot/test/unit/test_test_util_validation.py M master/buildbot/test/unit/test_util_pathmatch.py M master/buildbot/test/util/endpoint.py M master/buildbot/test/util/validation.py M master/buildbot/util/pathmatch.py M master/docs/developer/data.rst M master/docs/developer/db.rst M master/docs/developer/rtype-build.rst A master/docs/developer/rtype-log.rst A master/docs/developer/rtype-logchunk.rst A master/docs/developer/rtype-step.rst M master/docs/developer/tests.rst M master/docs/developer/utils.rst Log Message: ----------- Merge branch '9/statusdb' into nine Commit: 627fab66383415ecda2193b0bc591d05815e08f7 https://github.com/buildbot/buildbot/commit/627fab66383415ecda2193b0bc591d05815e08f7 Author: Dustin J. Mitchell Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/test/unit/test_data_logchunks.py M master/buildbot/test/unit/test_data_logs.py Log Message: ----------- pyflakes Compare: https://github.com/buildbot/buildbot/compare/928fa098a1f2...627fab663834 From nobody at buildbot.net Fri Mar 15 12:03:49 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 12:03:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods In-Reply-To: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> References: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> Message-ID: <053.d398ff92fc5f5e5e45e319d466841c1c@buildbot.net> #2237: Schedulers should have names and reconfigService methods -----------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: fixed Keywords: reconfig, sprint | -----------------------------+--------------------- Comment (by keeper): Hi Dustin, This is not fixed already. commit which you linked explicitly says about it: {{{ Schedulers are still stopped and re-started at every reconfiguration; this may be changed in the future. }}} This problem is seen in configurations with many triggered builders. Once reconfiguration is done - builder which triggered another build and waits for finish will be aborted. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 19:54:33 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 19:54:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2471: can't stop build, two builds are advancing at the same time Message-ID: <039.aa4ed22cdc5596b4b566f01d50600601@buildbot.net> #2471: can't stop build, two builds are advancing at the same time ----------------------+----------------------- Reporter: virgilg | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- Per the screenshot, there was a build (103) that is hanging at a git checkout step. I force triggered 104, went and cancelled 103, but I can't cancel it. The "Stop This Build" button doesn't do anything. See screenshot. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 20:39:25 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 20:39:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2449: Buildbot fails to capture output In-Reply-To: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> References: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> Message-ID: <052.c188f69f729a339b0006fc665cba6427@buildbot.net> #2449: Buildbot fails to capture output --------------------+-------------------- Reporter: swebb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by swebb): Got another box exhibiting this bug. This time it's a Debian 6.0 i386 box. Log contents: {{{ (view as text) make check VG=1 VERBOSE=1 in dir /home/buildbot/buildslave/clamav-debian-60-i386/build (timeout 1200 secs) watching logfiles {} argv: ['make', 'check', 'VG=1', 'VERBOSE=1'] environment: HOME=/home/buildbot LANG=en_US.UTF-8 LOGNAME=buildbot LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.dz=01;31:*.gz=01;31:*.lz=01;31:*.xz=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.rar=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.jpg=01;35:*.jpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.axv=01;35:*.anx=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.axa=00;36:*.oga=00;36:*.spx=00;36:*.xspf=00;36: MAIL=/var/mail/buildbot OLDPWD=/home/buildbot PATH=/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games PWD=/home/buildbot/buildslave/clamav-debian-60-i386/build SHELL=/usr/local/bin/bash SHLVL=1 TERM=xterm-256color USER=buildbot _=/usr/local/bin/buildslave using PTY: False Making check in libltdl make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libltdl' make check-am make[2]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libltdl' make[2]: Nothing to be done for `check-am'. make[2]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libltdl' make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libltdl' Making check in libclamav make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav' make check-recursive make[2]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav' Making check in c++ make[3]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav/c++' make check-am make[4]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav/c++' make[4]: Nothing to be done for `check-am'. make[4]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav/c++' make[3]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav/c++' make[3]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav' GEN version.h.tmp GEN version.h make[3]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav' make[2]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav' make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/libclamav' Making check in clamscan make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamscan' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamscan' Making check in clamd make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamd' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamd' Making check in clamdscan make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamdscan' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamdscan' Making check in freshclam make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/freshclam' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/freshclam' Making check in sigtool make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/sigtool' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/sigtool' Making check in clamconf make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamconf' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamconf' Making check in database make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/database' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/database' Making check in docs make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/docs' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/docs' Making check in etc make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/etc' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/etc' Making check in clamav-milter make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamav-milter' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamav-milter' Making check in test make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/test' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/test' Making check in clamdtop make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamdtop' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clamdtop' Making check in clambc make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clambc' make[1]: Nothing to be done for `check'. make[1]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/clambc' Making check in unit_tests make[1]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/unit_tests' make check_clamav check_clamd check_freshclam.sh check_sigtool.sh check_unit_vg.sh check1_clamscan.sh check2_clamd.sh check3_clamd.sh check4_clamd.sh check5_clamd_vg.sh check6_clamd_vg.sh check7_clamd_hg.sh check8_clamd_hg.sh check9_clamscan_vg.sh make[2]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/unit_tests' cp input/clamav.hdb clamav.hdb CC check_clamav-check_clamav.o CC check_clamav-check_jsnorm.o CC check_clamav-check_str.o CC check_clamav-check_regex.o CC check_clamav-check_disasm.o CC check_clamav-check_uniq.o CC check_clamav-check_matchers.o CC check_clamav-check_htmlnorm.o CC check_clamav-check_bytecode.o CCLD check_clamav CC check_clamd-check_clamd.o CCLD check_clamd make[2]: Nothing to be done for `check_freshclam.sh'. make[2]: Nothing to be done for `check_sigtool.sh'. cat ../unit_tests/.split/split.clam-phish-exeaa ../unit_tests/.split/split .clam-phish-exeab > clam-phish-exe make[2]: Nothing to be done for `check1_clamscan.sh'. make[2]: Nothing to be done for `check2_clamd.sh'. make[2]: Nothing to be done for `check3_clamd.sh'. make[2]: Nothing to be done for `check4_clamd.sh'. make[2]: Nothing to be done for `check5_clamd_vg.sh'. make[2]: Nothing to be done for `check6_clamd_vg.sh'. make[2]: Nothing to be done for `check7_clamd_hg.sh'. make[2]: Nothing to be done for `check8_clamd_hg.sh'. make[2]: Nothing to be done for `check9_clamscan_vg.sh'. make[2]: Leaving directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/unit_tests' make check-TESTS make[2]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/unit_tests' make[3]: Entering directory `/home/buildbot/buildslave/clamav- debian-60-i386/build/unit_tests' FAIL: check_clamav PASS: check_freshclam.sh PASS: check_sigtool.sh command timed out: 1200 seconds without output, attempting to kill process killed by signal 9 program finished with exit code -1 elapsedTime=1283.774557 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 21:41:58 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 21:41:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2356: Buildbot doesn't interrupt master-side source steps (was: Buildbot doesn't interrupt SVN source step) In-Reply-To: <038.b3c924236585f33303ff27706d58cee3@buildbot.net> References: <038.b3c924236585f33303ff27706d58cee3@buildbot.net> Message-ID: <053.b793cb1c0eb3669ff794a997d1a99a6d@buildbot.net> #2356: Buildbot doesn't interrupt master-side source steps -------------------------------------+-------------------- Reporter: flashm | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.8 Version: 0.8.6p1 | Resolution: Keywords: master-side-source-steps | -------------------------------------+-------------------- Changes (by dustin): * keywords: svn => master-side-source-steps Comment: Same for git in #2471 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 21:42:42 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 21:42:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2471: can't stop build, two builds are advancing at the same time In-Reply-To: <039.aa4ed22cdc5596b4b566f01d50600601@buildbot.net> References: <039.aa4ed22cdc5596b4b566f01d50600601@buildbot.net> Message-ID: <054.e87ea807c1fad9ec7d22349e4e5387fd@buildbot.net> #2471: can't stop build, two builds are advancing at the same time --------------------+------------------------ Reporter: virgilg | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: duplicate Keywords: | --------------------+------------------------ Changes (by dustin): * status: new => closed * type: undecided => defect * resolution: => duplicate * milestone: undecided => 0.8.8 Comment: Well, there's nothing wrong with having two builds running at once - that's normal. However, not cancelling source steps is a bug - #2356. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 21:48:21 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 21:48:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2449: Buildbot fails to capture output In-Reply-To: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> References: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> Message-ID: <052.6f2a387e19de585eb31b1dce6ceab57c@buildbot.net> #2449: Buildbot fails to capture output --------------------+-------------------- Reporter: swebb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by dustin): There are at least two possible reasons for this to occur: * Buildbot sometimes loses the ability to track output on both Windows and Linux * The build process produces no output for >1200s on both Windows and Linux Occam's razor suggests that the second is more likely. Do you have any data or evidence that can rule one of those out? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 21:53:06 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 21:53:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2449: Buildbot fails to capture output In-Reply-To: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> References: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> Message-ID: <052.da3bcdf2d82a22a5c7e8fd32fc4e28a8@buildbot.net> #2449: Buildbot fails to capture output --------------------+-------------------- Reporter: swebb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by swebb): I understand. However, when I run builds myself on the affected machines, the most time I spend without seeing any output is 10sec. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 22:05:52 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 22:05:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2449: Buildbot fails to capture output In-Reply-To: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> References: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> Message-ID: <052.ab5d6b5a0bb018ebc30a182e9eee1b74@buildbot.net> #2449: Buildbot fails to capture output --------------------+-------------------- Reporter: swebb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by dustin): Tom suggests this may be due to output buffering of some form when not connected to a terminal. If this is the case, then setting usePty=True will help. Since you mention this only happens periodically, it's possible that there's a race condition in the tes code which only causes a hang in a small fraction of cases -- manual testing wouldn't necessarily catch that. Have you tried running the task repeatedly by hand? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 22:27:58 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 22:27:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2467: source.SVN incorrectly handles repositories with special character in URL In-Reply-To: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> References: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> Message-ID: <053.4fbc2b0331132cc88ccc9349f15e1c33@buildbot.net> #2467: source.SVN incorrectly handles repositories with special character in URL ------------------------+-------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.7 | Resolution: Keywords: svn, simple | ------------------------+-------------------- Changes (by dustin): * keywords: svn => svn, simple * milestone: undecided => 0.8.8 Comment: Ah -- good advice as to how to implement this. I think that leaves the bug at "simple", meaning it should be fixable without too much research. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Mar 15 22:30:59 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 22:30:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2449: Buildbot fails to capture output In-Reply-To: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> References: <037.12eb527fa9db1e8946b3d4409bf88378@buildbot.net> Message-ID: <052.c116db0f9746938782502a7328dbf754@buildbot.net> #2449: Buildbot fails to capture output --------------------+-------------------- Reporter: swebb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by swebb): Yeah, we run the task several times a day by hand (unit tests on our code) on several OSs. I'll give usePty=True a try within the next couple days. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 15 22:35:32 2013 From: noreply at github.com (GitHub) Date: Fri, 15 Mar 2013 15:35:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 50aa43: Tests on windows was fixed Message-ID: <5143a2348a8a7_9cded713c630@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 50aa4364c5462c2e4369ff3ddbf43e4eded42020 https://github.com/buildbot/buildbot/commit/50aa4364c5462c2e4369ff3ddbf43e4eded42020 Author: Aleksey Vasenev Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_repo.py Log Message: ----------- Tests on windows was fixed Commit: a70cc78e88d1712497d60c825e048e685c7506b1 https://github.com/buildbot/buildbot/commit/a70cc78e88d1712497d60c825e048e685c7506b1 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_repo.py Log Message: ----------- Merge branch 'tests_fix' of git://github.com/Ratio2/buildbot Compare: https://github.com/buildbot/buildbot/compare/094ec1005601...a70cc78e88d1 From noreply at github.com Fri Mar 15 22:35:47 2013 From: noreply at github.com (GitHub) Date: Fri, 15 Mar 2013 15:35:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c4a40d: unit test config.ConfigErrors.__str__() method Message-ID: <5143a2431459e_36d461713c8121d@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: c4a40d30240bdc9f1237ac9ba0083d69dc9ffdf1 https://github.com/buildbot/buildbot/commit/c4a40d30240bdc9f1237ac9ba0083d69dc9ffdf1 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test config.ConfigErrors.__str__() method Added unit test on config.ConfigErrors.__str__() method Commit: 1beffde8ee4f703023529adbcba692fc08743818 https://github.com/buildbot/buildbot/commit/1beffde8ee4f703023529adbcba692fc08743818 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test configure file open error in MasterConfig.loadConfig() Added a unit test that simulates IOError when opening configure file in config.MasterConfig.loadConfig(). Check that the expected ConfigErrors exception is rised. Commit: 7cc54916bdfb792e83bb4884ed1271bdc7d9eea7 https://github.com/buildbot/buildbot/commit/7cc54916bdfb792e83bb4884ed1271bdc7d9eea7 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/config.py Log Message: ----------- removed unreachable code in config.MasterConfig.loadConfig() The call to error() with global _errors set to None, will raise an exception. Thus following 'raise errors' is never reached. Commit: 31b3c1e39fa377e607a5f38ebeeb21bfc50811cc https://github.com/buildbot/buildbot/commit/31b3c1e39fa377e607a5f38ebeeb21bfc50811cc Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test on loading 'codebaseGenerator' master parameter Added unit tests on code in buildbot.config.MasterConfig.load_global() that loads 'codebaseGenerator' master configuration parameter. Test both loading correct parameter and invalid. Commit: ba0529e179af616f6927189fba579b2476188280 https://github.com/buildbot/buildbot/commit/ba0529e179af616f6927189fba579b2476188280 Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test error paths in MasterConfig.load_status() Test that invalid 'status' option in master config file is handled properly. Commit: 628eaee6c5cfc4ab83972e7fd59fb22c8acb586f https://github.com/buildbot/buildbot/commit/628eaee6c5cfc4ab83972e7fd59fb22c8acb586f Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- unit test error paths in BuilderConfig.__init__() Test that invalid nextSlave, nextBuild, canStartBuild and env arguments to BuilderConfig constructor are handled properly. Commit: d54df6145022389562ac85054fe2590f61c9f4ab https://github.com/buildbot/buildbot/commit/d54df6145022389562ac85054fe2590f61c9f4ab Author: Elmir Jagudin Date: 2013-03-05 (Tue, 05 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- updated buildbot.config.MasterConfig.check_locks() unit tests Updated unit tests of buildbot.config.MasterConfig.check_locks() method to use lock objects wrapped inside LockAccess objects. Nowadays this is the recommended style of specifying locks in the documentation. Add one new unit test to check that using 'bare' lock objects still works. Commit: 130bbad600dfcd65d9599bb8ab325b3a5381abaf https://github.com/buildbot/buildbot/commit/130bbad600dfcd65d9599bb8ab325b3a5381abaf Author: Elmir Jagudin Date: 2013-03-08 (Fri, 08 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- use self.patch() to override open() in unit test Using TestCase.patch() method to override buildin open() in a unit test is much cleaner. Commit: acfa823027400c8e5732242f6fc2d4d4778ce86b https://github.com/buildbot/buildbot/commit/acfa823027400c8e5732242f6fc2d4d4778ce86b Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Merge branch 'config-unit-tests' of git://github.com/elmirjagudin/buildbot Commit: ede1de82c209e4b924f0a1d594371016a3879876 https://github.com/buildbot/buildbot/commit/ede1de82c209e4b924f0a1d594371016a3879876 Author: Dustin J. Mitchell Date: 2013-03-11 (Mon, 11 Mar 2013) Changed paths: M master/contrib/post_build_request.py Log Message: ----------- fix typo Commit: e8d2d3927ef71a1b972d8e28e38e1c7f30906478 https://github.com/buildbot/buildbot/commit/e8d2d3927ef71a1b972d8e28e38e1c7f30906478 Author: Dustin J. Mitchell Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- don't try to detect bug1810 more than once Commit: 9ecd9bac3e4da47aed0ff73879b700882a242ac2 https://github.com/buildbot/buildbot/commit/9ecd9bac3e4da47aed0ff73879b700882a242ac2 Author: Dustin J. Mitchell Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/status/logfile.py M master/buildbot/test/unit/test_scripts_start.py Log Message: ----------- fix pyflakes Commit: babdbe970477b12d8e2070801cbf3407c33e686e https://github.com/buildbot/buildbot/commit/babdbe970477b12d8e2070801cbf3407c33e686e Author: Dustin J. Mitchell Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/test/unit/test_scripts_start.py Log Message: ----------- correct fix for pyflakes Commit: 7fd588dbf7c215364cb348527eda3873d608d222 https://github.com/buildbot/buildbot/commit/7fd588dbf7c215364cb348527eda3873d608d222 Author: Elmir Jagudin Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M slave/buildslave/scripts/runner.py A slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- check if valid base dir on 'buildslave upgrade-slave' Check if we got a valid slave base dir on 'buildslave upgrade-slave' cli command. If not, print error message and exit. Commit: d73475e1ef6baa443b272afaa04396f39c3d0042 https://github.com/buildbot/buildbot/commit/d73475e1ef6baa443b272afaa04396f39c3d0042 Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M slave/buildslave/scripts/runner.py A slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'upgrade-slave-chk-basedir' of git://github.com/elmirjagudin/buildbot Commit: dce6945d9b5d9d409a559b3e8a6134a896cb9318 https://github.com/buildbot/buildbot/commit/dce6945d9b5d9d409a559b3e8a6134a896cb9318 Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M MAINTAINERS.txt Log Message: ----------- add Pierre to MAINTAINERS.txt Commit: 094ec10056019feebc243de9fa95d0d402398e7e https://github.com/buildbot/buildbot/commit/094ec10056019feebc243de9fa95d0d402398e7e Author: Dustin J. Mitchell Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/docs/index.rst Log Message: ----------- Include docs under GPLv2. Fixes #2470. The docs were previously under an unspecified free-with-copyright clause, which appears to allow such relicensing. Anyway, Warner is OK with the change. Commit: 50aa4364c5462c2e4369ff3ddbf43e4eded42020 https://github.com/buildbot/buildbot/commit/50aa4364c5462c2e4369ff3ddbf43e4eded42020 Author: Aleksey Vasenev Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_repo.py Log Message: ----------- Tests on windows was fixed Commit: a70cc78e88d1712497d60c825e048e685c7506b1 https://github.com/buildbot/buildbot/commit/a70cc78e88d1712497d60c825e048e685c7506b1 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_repo.py Log Message: ----------- Merge branch 'tests_fix' of git://github.com/Ratio2/buildbot Commit: 8ff8f310a23c56cd687c22177a957a2cf5833ae0 https://github.com/buildbot/buildbot/commit/8ff8f310a23c56cd687c22177a957a2cf5833ae0 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M MAINTAINERS.txt M master/buildbot/config.py M master/buildbot/db/pool.py M master/buildbot/status/logfile.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_repo.py M master/contrib/post_build_request.py M master/docs/index.rst M slave/buildslave/scripts/runner.py A slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/627fab663834...8ff8f310a23c From nobody at buildbot.net Fri Mar 15 22:35:49 2013 From: nobody at buildbot.net (Buildbot) Date: Fri, 15 Mar 2013 22:35:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2470: relicense documentation under GPLv2 In-Reply-To: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> References: <038.36ad87ab3bb95beb7df754d47a485fc5@buildbot.net> Message-ID: <053.00bf8eaf6dbc764eed46e00e87c73395@buildbot.net> #2470: relicense documentation under GPLv2 ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: docs | ------------------------+--------------------- Comment (by Dustin J. Mitchell): Include docs under GPLv2. Fixes #2470. The docs were previously under an unspecified free-with-copyright clause, which appears to allow such relicensing. Anyway, Warner is OK with the change. Changeset: 094ec10056019feebc243de9fa95d0d402398e7e -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Mar 15 23:26:36 2013 From: noreply at github.com (GitHub) Date: Fri, 15 Mar 2013 16:26:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 12b561: unit test 'buildbot --verbose' cli option Message-ID: <5143ae2c189bc_3066a06130161d3@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 12b56130782e675b8d645826e2670a78ea9083b6 https://github.com/buildbot/buildbot/commit/12b56130782e675b8d645826e2670a78ea9083b6 Author: Elmir Jagudin Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- unit test 'buildbot --verbose' cli option Test that '--verbose' option for buildbot command enables logging to stderr. Commit: d555796acf43174a745a2dcee66e5a794e109b43 https://github.com/buildbot/buildbot/commit/d555796acf43174a745a2dcee66e5a794e109b43 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'buildbot-cli-test' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/a70cc78e88d1...d555796acf43 From noreply at github.com Sat Mar 16 00:13:31 2013 From: noreply at github.com (GitHub) Date: Fri, 15 Mar 2013 17:13:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 928803: Remove redundant space Message-ID: <5143b92b28600_5245e3d12c660c8@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 928803b4e6146ee3748847b28649c3335c49e7d2 https://github.com/buildbot/buildbot/commit/928803b4e6146ee3748847b28649c3335c49e7d2 Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/__init__.py Log Message: ----------- Remove redundant space Commit: b9f07f88066cd63b5032f9ed483f3d7449f3dfaa https://github.com/buildbot/buildbot/commit/b9f07f88066cd63b5032f9ed483f3d7449f3dfaa Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/scripts/runner.py M slave/buildslave/scripts/runner.py Log Message: ----------- Typo: "intechangeably" Commit: 28afe45516ceaebe375460ceafa8a0c71753923f https://github.com/buildbot/buildbot/commit/28afe45516ceaebe375460ceafa8a0c71753923f Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/status/web/logs.py Log Message: ----------- Remove redundant brackets Commit: c9a4ebba1f75e6f11d29375ec510cfefca7edbe4 https://github.com/buildbot/buildbot/commit/c9a4ebba1f75e6f11d29375ec510cfefca7edbe4 Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- Add dot at the end of sentence Commit: e726b4829ca413d7cdfbd9b83100e2ea294d29a2 https://github.com/buildbot/buildbot/commit/e726b4829ca413d7cdfbd9b83100e2ea294d29a2 Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- Remove "Callbacks" capitalization Commit: 6e7300f4e2ad9aeb3ff9796c6a79011f6f377acd https://github.com/buildbot/buildbot/commit/6e7300f4e2ad9aeb3ff9796c6a79011f6f377acd Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- Fix indent Commit: 13431142fc75fa23b68c319c4b829e1ecf5579b8 https://github.com/buildbot/buildbot/commit/13431142fc75fa23b68c319c4b829e1ecf5579b8 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/__init__.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/logs.py M master/docs/developer/style.rst M slave/buildslave/scripts/runner.py Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/d555796acf43...13431142fc75 From noreply at github.com Sat Mar 16 01:23:32 2013 From: noreply at github.com (GitHub) Date: Fri, 15 Mar 2013 18:23:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 986bfe: Windows service was fixed Message-ID: <5143c99430594_3b07c513c907e@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 986bfeebe9b4da2b5bf2609e6178f5a0dddc3d96 https://github.com/buildbot/buildbot/commit/986bfeebe9b4da2b5bf2609e6178f5a0dddc3d96 Author: Aleksey Vasenev Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Windows service was fixed Commit: 525f82ab71862041d4d1c7ac468bf3d48a2231ad https://github.com/buildbot/buildbot/commit/525f82ab71862041d4d1c7ac468bf3d48a2231ad Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'windows_service_fix' of git://github.com/Ratio2/buildbot Compare: https://github.com/buildbot/buildbot/compare/13431142fc75...525f82ab7186 From trac at buildbot.net Sat Mar 16 08:25:24 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 16 Mar 2013 08:25:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1019: buildbot.net isn't a good mail-sender In-Reply-To: <038.b43b22f572357e15ade829210d7884dd@buildbot.net> References: <038.b43b22f572357e15ade829210d7884dd@buildbot.net> Message-ID: <053.f66d24a465b32bea873df83a352f58f3@buildbot.net> #1019: buildbot.net isn't a good mail-sender -------------------+---------------------- Reporter: dustin | Owner: verm Type: task | Status: closed Priority: major | Milestone: ongoing Version: | Resolution: fixed Keywords: admin | -------------------+---------------------- Changes (by verm): * status: assigned => closed * version: 0.8.1 => * resolution: => fixed Old description: > speakeasy.net, at least, refuses to accept email from us: > > Oct 20 13:59:47 buildbot postfix/smtp[10148]: 6AECD98072: host > mx02.speakeasy.net[69.17.117.60] said: 450 4.7.1 Client host rejected: > cannot find your reverse hostname, [67.18.176.221] (in reply to RCPT TO > command) > > I'll ping warner about this, but it will probably get fixed when we re- > host buildbot.net on another system somehow. New description: speakeasy.net, at least, refuses to accept email from us: Oct 20 13:59:47 buildbot postfix/smtp[10148]: 6AECD98072: host mx02.speakeasy.net[69.17.117.60] said: 450 4.7.1 Client host rejected: cannot find your reverse hostname, [67.18.176.221] (in reply to RCPT TO command) I'll ping warner about this, but it will probably get fixed when we re- host buildbot.net on another system somehow. -- Comment: trac was migrated to a new host which has a proper DNS setup everything should be fine now. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Mar 16 08:26:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 16 Mar 2013 08:26:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2262: filter what parts of trac get indexed In-Reply-To: <038.e0b1aad886ec853be686a74f8fe6839a@buildbot.net> References: <038.e0b1aad886ec853be686a74f8fe6839a@buildbot.net> Message-ID: <053.25297404c416ced566bae17267f37efc@buildbot.net> #2262: filter what parts of trac get indexed -------------------+----------------------- Reporter: dustin | Owner: verm Type: task | Status: accepted Priority: major | Milestone: ongoing Version: | Resolution: Keywords: admin | -------------------+----------------------- Changes (by verm): * owner: => verm * status: new => accepted -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Mar 16 08:27:23 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 16 Mar 2013 08:27:23 -0000 Subject: [Buildbot-commits] [Buildbot] #2262: filter what parts of trac get indexed In-Reply-To: <038.e0b1aad886ec853be686a74f8fe6839a@buildbot.net> References: <038.e0b1aad886ec853be686a74f8fe6839a@buildbot.net> Message-ID: <053.5b45bdd6c9517d85d0bbf747cf192ab8@buildbot.net> #2262: filter what parts of trac get indexed -------------------+---------------------- Reporter: dustin | Owner: verm Type: task | Status: closed Priority: major | Milestone: ongoing Version: | Resolution: fixed Keywords: admin | -------------------+---------------------- Changes (by verm): * status: accepted => closed * resolution: => fixed Comment: I've added a robots.txt. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Mar 16 16:23:55 2013 From: noreply at github.com (GitHub) Date: Sat, 16 Mar 2013 09:23:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e247c2: Output for user Command-line Tool was fixed Message-ID: <51449c9b8752b_1de673012c9185e@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e247c2b1515a1e194b5124f13bd5a7b08b41ad90 https://github.com/buildbot/buildbot/commit/e247c2b1515a1e194b5124f13bd5a7b08b41ad90 Author: Aleksey Vasenev Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- Output for user Command-line Tool was fixed Commit: 430c0c8423da83fa42d25b178b7cfc7de540a850 https://github.com/buildbot/buildbot/commit/430c0c8423da83fa42d25b178b7cfc7de540a850 Author: Aleksey Vasenev Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- Unnecessary code removed Commit: 50e5f625e2e2df27eb3ebc318887162a452acf30 https://github.com/buildbot/buildbot/commit/50e5f625e2e2df27eb3ebc318887162a452acf30 Author: Aleksey Vasenev Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- None output was suppressed Commit: 2bb5705d40eecef281a00eda2bc5a535d5add412 https://github.com/buildbot/buildbot/commit/2bb5705d40eecef281a00eda2bc5a535d5add412 Author: Dustin J. Mitchell Date: 2013-03-16 (Sat, 16 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- Merge branch 'user_command_fix' of git://github.com/Ratio2/buildbot Compare: https://github.com/buildbot/buildbot/compare/525f82ab7186...2bb5705d40ee From trac at buildbot.net Sat Mar 16 16:36:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 16 Mar 2013 16:36:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods In-Reply-To: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> References: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> Message-ID: <053.6da67673ce1e874be3d8a97ee599a239@buildbot.net> #2237: Schedulers should have names and reconfigService methods -----------------------------+----------------------- Reporter: dustin | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: reconfig, sprint | -----------------------------+----------------------- Changes (by dustin): * status: closed => reopened * resolution: fixed => Comment: You're right, that only half-fixed the problem: {{{ + # find any schedulers that don't know how to reconfig, and, if they + # have changed, add them to both removed and added, so that we + # run the new version. While we're at it, find any schedulers whose + # fully qualified class name has changed, and consider those a removal + # and re-add as well. }}} So, schedulers with a `reconfigService` method won't get removed and re- added, but so far none of the schedulers have such a method. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Mar 16 17:45:42 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 16 Mar 2013 17:45:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2237: Schedulers should have names and reconfigService methods In-Reply-To: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> References: <038.ea3c9e9516640ac3c188109e2069c7a7@buildbot.net> Message-ID: <053.4ff6fdec9f37509ab9bf23c0ae707240@buildbot.net> #2237: Schedulers should have names and reconfigService methods -----------------------------+----------------------- Reporter: dustin | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: reconfig, sprint | -----------------------------+----------------------- Comment (by dustin): Thanks for calling me out on that error, by the way! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Mar 17 01:14:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 17 Mar 2013 01:14:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2472: Implement persona in nine Message-ID: <038.2853f060711f88577d8851a2bdd1c42d@buildbot.net> #2472: Implement persona in nine ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.7p1 | Keywords: web ------------------------+------------------- Let's make it easiest to use Persona for authentication. Let's not implement our own password store, since that's easy to mess up and security-sensitive and requires lots of extra equipment (password changes, forgotten passwords, secure storage, and so on). We should still be able to support other Twisted Cred plugins. The interface should be to provide a uid to the remainder of the web UI, which can be used for authorization Some guy named Brian Warner wrote a tool for this: https://github.com/warner/browserid-cred -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Mar 18 02:00:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 18 Mar 2013 02:00:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2106: Buildbot requires pycrypto to setup even an unencrypted manhole In-Reply-To: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> References: <042.b881d87fc9ffff62fed02b40b1d6272b@buildbot.net> Message-ID: <057.0cf44a1f248e1f32bc6187aa41d7a045@buildbot.net> #2106: Buildbot requires pycrypto to setup even an unencrypted manhole ---------------------------+--------------------- Reporter: jollyroger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.4p2 | Resolution: fixed Keywords: sprint, simple | ---------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This was fixed in January, but with a typo in the commit message. Oops! {{{ commit eb1d34bd7d5fcffc50851bacd635f19d95968e74 Author: Tom Prince Date: Sat Jan 26 12:14:36 2013 -0700 Don't require pycrpyto for telnet manhole. Fixes #2160. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Mar 18 05:18:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 18 Mar 2013 05:18:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2186: github change_hook needs security by default In-Reply-To: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> References: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> Message-ID: <055.f36f2f21b59b6dcfb29f6f196ba8816c@buildbot.net> #2186: github change_hook needs security by default ------------------------------+-------------------- Reporter: stefanha | Owner: Type: enhancement | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: github web sprint | ------------------------------+-------------------- Comment (by marchael): I wrote simple patch for basic auth https://github.com/buildbot/buildbot/pull/657 It didn't merged for now, but I hope it will be. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Mar 18 16:20:45 2013 From: noreply at github.com (GitHub) Date: Mon, 18 Mar 2013 09:20:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 48b3aa: show_events does opposite of that was written Message-ID: <51473edd6e252_5b04dcf12c148cb@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 48b3aa1e74d7c2fb2052b4232da69258d817aa25 https://github.com/buildbot/buildbot/commit/48b3aa1e74d7c2fb2052b4232da69258d817aa25 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html Log Message: ----------- show_events does opposite of that was written Commit: 7a1abe8f56b6e27cfbc3f3ad9226d65c1ca9c66c https://github.com/buildbot/buildbot/commit/7a1abe8f56b6e27cfbc3f3ad9226d65c1ca9c66c Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- Add closing bracket Commit: b5e95fc2489a0d56c212ad875d4e538788ff6112 https://github.com/buildbot/buildbot/commit/b5e95fc2489a0d56c212ad875d4e538788ff6112 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- Add missing bracket. Should fix code formatting Commit: 1de633c7c0c07233d5286d4373c771ffa63530d9 https://github.com/buildbot/buildbot/commit/1de633c7c0c07233d5286d4373c771ffa63530d9 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/libvirtbuildslave.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Replace "doesnt" with "doesn't" Commit: d39de9b6d286e6ea91748212026d9ca9f3461626 https://github.com/buildbot/buildbot/commit/d39de9b6d286e6ea91748212026d9ca9f3461626 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/libvirtbuildslave.py Log Message: ----------- Fix indent Commit: 78e5fdff6ab49c6af06fa197b90e8c083c235b4a https://github.com/buildbot/buildbot/commit/78e5fdff6ab49c6af06fa197b90e8c083c235b4a Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/process/builder.py Log Message: ----------- Remove unnecessary backslash Commit: 41e2fcd1e887efc916a82e02d28cc87206b87e77 https://github.com/buildbot/buildbot/commit/41e2fcd1e887efc916a82e02d28cc87206b87e77 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-schedulers.rst Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Commit: 3132b5888406d47245d55188e7788204e9c7d474 https://github.com/buildbot/buildbot/commit/3132b5888406d47245d55188e7788204e9c7d474 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/libvirtbuildslave.py M master/buildbot/process/builder.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Merge branch 'typos2' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/2bb5705d40ee...3132b5888406 From noreply at github.com Mon Mar 18 16:38:45 2013 From: noreply at github.com (GitHub) Date: Mon, 18 Mar 2013 09:38:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5bcd70: Added basic HTTP auth for /change_hook/github Message-ID: <51474315cb1c9_6969f5012c307dd@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5bcd700e0ff7e65a4488b8fff31a49dd96544023 https://github.com/buildbot/buildbot/commit/5bcd700e0ff7e65a4488b8fff31a49dd96544023 Author: Michael Mayorov Date: 2013-03-10 (Sun, 10 Mar 2013) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- Added basic HTTP auth for /change_hook/github Commit: c988de81b16a310154f57c07e89b29e5f4dec83f https://github.com/buildbot/buildbot/commit/c988de81b16a310154f57c07e89b29e5f4dec83f Author: Michael Mayorov Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Added information about ``change_hook_auth`` option Commit: 0468561b4c9386a6bbfe07c56eb32c9c4f5f6449 https://github.com/buildbot/buildbot/commit/0468561b4c9386a6bbfe07c56eb32c9c4f5f6449 Author: Michael Mayorov Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Small fix in documentation about ``change_hook_auth`` Commit: 81bcb66b46d89f21bcc9e2185c17ae32d9fc52dd https://github.com/buildbot/buildbot/commit/81bcb66b46d89f21bcc9e2185c17ae32d9fc52dd Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge branch '2186-change-hook-auth' of git://github.com/MichaelMayorov/buildbot Commit: 867d9548a15f3b24b86d02be78c0f4126fa01dc0 https://github.com/buildbot/buildbot/commit/867d9548a15f3b24b86d02be78c0f4126fa01dc0 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- minor docs edits Compare: https://github.com/buildbot/buildbot/compare/3132b5888406...867d9548a15f From trac at buildbot.net Mon Mar 18 16:38:41 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 18 Mar 2013 16:38:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2186: github change_hook needs security by default In-Reply-To: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> References: <040.b0011a230d9ec9a00c8a78bbb647063d@buildbot.net> Message-ID: <055.65e86d2db6a71b1046f5be2e267d3a15@buildbot.net> #2186: github change_hook needs security by default ------------------------------+--------------------- Reporter: stefanha | Owner: Type: enhancement | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.8.5 | Resolution: fixed Keywords: github web sprint | ------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Old description: > The github change_hook allows Github POST requests to trigger builds. It > is part of WebStatus and can be accessed via > http://server/change_hook/github. > > The buildbot documentation does not explain the security implications of > enabling this change_hook. From what I can tell there are no checks in > place to ensure the HTTP request is really from Github. > > Anyone who pokes this URL will be able to trigger builds. It's also not > clear to me whether builds are restricted to just the git repositories > configured on the buildmaster or whether the repo URL from the HTTP > request will be used. > > Please document the security implications of the github change_hook. > > I suggest supporting a secret token that can be configured both on the > buildmaster and github side. If the HTTP request does not include the > secret token then it will be denied. One way of doing this would be to > customize the github change_hook URI, e.g. > http://server/change_hook/1e505aa83c25910, so that it is not guessable. New description: The github change_hook allows Github POST requests to trigger builds. It is part of WebStatus and can be accessed via http://server/change_hook/github. The buildbot documentation does not explain the security implications of enabling this change_hook. From what I can tell there are no checks in place to ensure the HTTP request is really from Github. Anyone who pokes this URL will be able to trigger builds. It's also not clear to me whether builds are restricted to just the git repositories configured on the buildmaster or whether the repo URL from the HTTP request will be used. Please document the security implications of the github change_hook. I suggest supporting a secret token that can be configured both on the buildmaster and github side. If the HTTP request does not include the secret token then it will be denied. One way of doing this would be to customize the github change_hook URI, e.g. http://server/change_hook/1e505aa83c25910, so that it is not guessable. -- Comment: Merged! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Mar 18 23:59:14 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 18 Mar 2013 23:59:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.2208108f74dcefab8feb901ede634a9d@buildbot.net> #1854: FileUpload never times out -----------------------------------------+----------------------- Reporter: exarkun | Owner: juanl Type: defect | Status: accepted Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer master-slave sprint | -----------------------------------------+----------------------- Comment (by juanl): related conversation on the message board: http://sourceforge.net/mailarchive/message.php?msg_id=29042423 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 19 00:35:22 2013 From: noreply at github.com (GitHub) Date: Mon, 18 Mar 2013 17:35:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1b905f: Fix indentation Message-ID: <5147b2c9ccc94_44d0c3512c425f4@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1b905fcf6126f3b5a06aaf0400aeb0615ce77c0d https://github.com/buildbot/buildbot/commit/1b905fcf6126f3b5a06aaf0400aeb0615ce77c0d Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/libvirtbuildslave.py M master/contrib/windows/buildbot_service.py Log Message: ----------- Fix indentation Commit: afd33b4512acbca435e94bce08ebc5c0f7cf4e2d https://github.com/buildbot/buildbot/commit/afd33b4512acbca435e94bce08ebc5c0f7cf4e2d Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/buildslave.py M master/buildbot/libvirtbuildslave.py M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Typos: possibilty, prefined, builtbot, explictly Commit: 5efb4b5e53173760cbffecefc6a7fc4959e3c26d https://github.com/buildbot/buildbot/commit/5efb4b5e53173760cbffecefc6a7fc4959e3c26d Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/buildslave.py M master/buildbot/config.py M master/buildbot/libvirtbuildslave.py M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/867d9548a15f...5efb4b5e5317 From trac at buildbot.net Tue Mar 19 01:20:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 01:20:22 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.bca05bbc33ae69b7f8a68b603e6c10fe@buildbot.net> #1854: FileUpload never times out -----------------------------------------+----------------------- Reporter: exarkun | Owner: juanl Type: defect | Status: accepted Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: transfer master-slave sprint | -----------------------------------------+----------------------- Comment (by juanl): It appears that this ticket might no longer be valid. I've installed v0.8.2 master and slave on the same machine, started a fileUpload with a large file, brought down the loopback interface, and waited for the master to sense the slave disconnect. In this case the build step will hang, remaining in the in-process (yellow) state. Even after the slave reconnects, the step will remain in the in-process state - even though new builds can be started. Using v0.8.7p1 master and slave and the same procedure above I see the build will be properly interrupted and marked as having incurred an exception. Here is a bash script that sets up a v0.8.2 or v0.8.7p1 test environment for recreating this issue. http://pastebin.mozilla.org/2226893 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 19 03:17:33 2013 From: noreply at github.com (GitHub) Date: Mon, 18 Mar 2013 20:17:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0b44df: Fix LibVirtSlave example and add connection argume... Message-ID: <5147d8cd6b09f_92097313c3608b@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0b44dfa451aff51dbe86ea5f4edd5c03ba7f619b https://github.com/buildbot/buildbot/commit/0b44dfa451aff51dbe86ea5f4edd5c03ba7f619b Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Fix LibVirtSlave example and add connection argument description to docs Commit: 34e7d0c36cf38f5c260f3859faa4de6997cae686 https://github.com/buildbot/buildbot/commit/34e7d0c36cf38f5c260f3859faa4de6997cae686 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Merge branch 'libvirt_slave_docs_fix' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/5efb4b5e5317...34e7d0c36cf3 From trac at buildbot.net Tue Mar 19 03:55:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 03:55:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1854: FileUpload never times out In-Reply-To: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> References: <039.e7bfab756d445121a2e0b7af56f23535@buildbot.net> Message-ID: <054.1791f3d0bdb18e6f92dbef1704ed3725@buildbot.net> #1854: FileUpload never times out -----------------------------------------+--------------------- Reporter: exarkun | Owner: juanl Type: defect | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.8.2 | Resolution: fixed Keywords: transfer master-slave sprint | -----------------------------------------+--------------------- Changes (by dustin): * status: accepted => closed * resolution: => fixed Old description: > If a slave loses its connection to the master without sending a FIN or > RST (eg, because of network issues) while a `FileUpload` step is running, > the build that step is part of never finishes, the master never notices > the slave disconnected, and the slave can never reconnect until the > master is restarted. After the master is restarted, the build is left in > a weird state where it appears incomplete rather than failed. New description: If a slave loses its connection to the master without sending a FIN or RST (eg, because of network issues) while a `FileUpload` step is running, the build that step is part of never finishes, the master never notices the slave disconnected, and the slave can never reconnect until the master is restarted. After the master is restarted, the build is left in a weird state where it appears incomplete rather than failed. -- Comment: I don't think there's any "might" involved. You've demonstrated conclusively that this is no longer a problem. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 19 04:30:57 2013 From: noreply at github.com (GitHub) Date: Mon, 18 Mar 2013 21:30:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1a7e2b: Ticket #2409 Message-ID: <5147ea015abad_381af38130739d3@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1a7e2b2520a23fcee90b3e61289187146c4452b1 https://github.com/buildbot/buildbot/commit/1a7e2b2520a23fcee90b3e61289187146c4452b1 Author: sunya7a Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py Log Message: ----------- Ticket #2409 Using DeferredLock.run() in favor of .acquire and .release in master/buildbot/process/buildrequestdistributor.py Commit: c6f1f05aa4d954f7c6f8e8f6ceac9c41dbece5b8 https://github.com/buildbot/buildbot/commit/c6f1f05aa4d954f7c6f8e8f6ceac9c41dbece5b8 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py Log Message: ----------- Merge branch 'master' of git://github.com/sunya7a/buildbot Compare: https://github.com/buildbot/buildbot/compare/34e7d0c36cf3...c6f1f05aa4d9 From trac at buildbot.net Tue Mar 19 04:32:20 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 04:32:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2409: Use DeferredLock.run in preference to .acquire + .release. In-Reply-To: <042.a933674536b648553a0f9a92a682bc6b@buildbot.net> References: <042.a933674536b648553a0f9a92a682bc6b@buildbot.net> Message-ID: <057.775c54c096bfe31149df49ae0fb9d52e@buildbot.net> #2409: Use DeferredLock.run in preference to .acquire + .release. --------------------------+--------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: simple sprint | --------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Old description: > The only remaining use of a locks that I see is in botmaster.py, in > _maybeStartBuildsOn. > > See Tom's fix in the ticket comments for an example of the transformation > he's suggesting. New description: The only remaining use of a locks that I see is in botmaster.py, in _maybeStartBuildsOn. See Tom's fix in the ticket comments for an example of the transformation he's suggesting. -- Comment: {{{ commit c6f1f05aa4d954f7c6f8e8f6ceac9c41dbece5b8 Merge: 34e7d0c 1a7e2b2 Author: Dustin J. Mitchell Date: Tue Mar 19 00:20:57 2013 -0400 Merge branch 'master' of git://github.com/sunya7a/buildbot }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Mar 19 15:38:05 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 15:38:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 Message-ID: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 --------------------+----------------------- Reporter: johnt | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: git --------------------+----------------------- buildbot.steps.source.git.Git allows the use of a branch option to choose a branch or tag but will not work with a tag if the git version is older than 1.7.10. The issue and the workaround are discussed here: http://stackoverflow.com/questions/14650146/git-couldnt-find-remote-ref- for-a-tag-or-commit-hash workaround is to pass 'refs/tags/' rather than just '' (tested and working) this should be detailed in the documentation -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Mar 19 17:12:47 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 17:12:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 In-Reply-To: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> References: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> Message-ID: <052.8d6bc5b04224c003cd960b005ad1f14b@buildbot.net> #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 --------------------+------------------------ Reporter: johnt | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: git | --------------------+------------------------ Comment (by dustin): 1.7.10 was released in June 2012. Is it worth making changes in Buildbot to support it at this point, given the presence of a workaround? If so, can you give an example of a configuration that doesn't work? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Mar 19 17:39:52 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 17:39:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2474: SVN step doesnt recover from 1.7 upgrade requirement Message-ID: <042.59df0997c25ab0cc7245dc5f36211961@buildbot.net> #2474: SVN step doesnt recover from 1.7 upgrade requirement -----------------------+----------------------- Reporter: jaredgrubb | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: svn -----------------------+----------------------- To reproduce: * buildslave has SVN 1.6 * have a step check something out * buildslave upgrades to SVN 1.7 * build step runs on that same working dir checkout Observe: * SVN 1.7 wants to upgrade the directory and fails to do any operations, so SVN step fails Expect: * The SVN step could: * upgrade * clobber and check out fresh It would be nice if the SVN step could recover from an old SVN checkout. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 19 17:56:37 2013 From: noreply at github.com (GitHub) Date: Tue, 19 Mar 2013 10:56:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a6f82c: Upgrade tests for 0.8.7 Message-ID: <5148a6d5a1f1b_52d3aab130164ac@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a6f82caae87e2e3ba0587ef9d3b393c6e0c0eb66 https://github.com/buildbot/buildbot/commit/a6f82caae87e2e3ba0587ef9d3b393c6e0c0eb66 Author: Erik Stephens Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/integration/v087p1-README.txt A master/buildbot/test/integration/v087p1.tgz Log Message: ----------- Upgrade tests for 0.8.7 Commit: 9048a0af6e5e16999cc35d534cebc4c44131509f https://github.com/buildbot/buildbot/commit/9048a0af6e5e16999cc35d534cebc4c44131509f Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/integration/v087p1-README.txt A master/buildbot/test/integration/v087p1.tgz Log Message: ----------- Merge branch 'bug2439' of git://github.com/orvant/buildbot Compare: https://github.com/buildbot/buildbot/compare/c6f1f05aa4d9...9048a0af6e5e From noreply at github.com Tue Mar 19 17:56:45 2013 From: noreply at github.com (GitHub) Date: Tue, 19 Mar 2013 10:56:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 98e77e: call addBuild with correct parameters Message-ID: <5148a6dd8f05a_23aa85b13c767be@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 98e77e1f25b23374d872422f2459efa48488db83 https://github.com/buildbot/buildbot/commit/98e77e1f25b23374d872422f2459efa48488db83 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/process/builder.py Log Message: ----------- call addBuild with correct parameters From noreply at github.com Tue Mar 19 18:36:30 2013 From: noreply at github.com (GitHub) Date: Tue, 19 Mar 2013 11:36:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 16e9ed: rebuild the sqlite DB on sqlite-3.6.20 for compati... Message-ID: <5148b02eb9325_4d6696313846811@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 16e9edeb925a2847c43c1aa5273d3f5992c1911a https://github.com/buildbot/buildbot/commit/16e9edeb925a2847c43c1aa5273d3f5992c1911a Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/integration/v087p1.tgz Log Message: ----------- rebuild the sqlite DB on sqlite-3.6.20 for compatibility From trac at buildbot.net Tue Mar 19 19:42:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 19:42:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2474: SVN step doesnt recover from 1.7 upgrade requirement In-Reply-To: <042.59df0997c25ab0cc7245dc5f36211961@buildbot.net> References: <042.59df0997c25ab0cc7245dc5f36211961@buildbot.net> Message-ID: <057.6575e13eb463a7f24a285dcb6ab77e1e@buildbot.net> #2474: SVN step doesnt recover from 1.7 upgrade requirement ------------------------+-------------------- Reporter: jaredgrubb | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: svn, sprint | ------------------------+-------------------- Changes (by dustin): * keywords: svn => svn, sprint * type: undecided => defect * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 19 20:28:14 2013 From: noreply at github.com (GitHub) Date: Tue, 19 Mar 2013 13:28:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b75a8e: Fix to ticket #2310: make loadConfig check for a c... Message-ID: <5148ca5e2c4fa_52f4728134919ac@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b75a8ef15638b03b45380cdf281942fc51e1a72c https://github.com/buildbot/buildbot/commit/b75a8ef15638b03b45380cdf281942fc51e1a72c Author: ian mccowan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/config.py Log Message: ----------- Fix to ticket #2310: make loadConfig check for a configfile path in the .tac file if the default location doesn't exist Commit: 9f378f209851f618e4f7f0485424be675f538cde https://github.com/buildbot/buildbot/commit/9f378f209851f618e4f7f0485424be675f538cde Author: ian mccowan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- Add a test that getting the config file path from the .tac file works Commit: 47182ecf7e4e91721da3119c42d5f5794a2c27f0 https://github.com/buildbot/buildbot/commit/47182ecf7e4e91721da3119c42d5f5794a2c27f0 Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Address code review comment: https://github.com/buildbot/buildbot/pull/673#issuecomment-15095930 and fall back to the .tac config location before calling loadConfig Commit: 11f0a6565e27e7c08886e574c4a00fcbe33794aa https://github.com/buildbot/buildbot/commit/11f0a6565e27e7c08886e574c4a00fcbe33794aa Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_upgrade_master.py Log Message: ----------- Fix the way in which we fail with unfound configs to pass the unit tests. loadConfig must take a full path, not try to prepend the basedir, because it may take a fully qualified path as specified in the .tac. Commit: 9e0c9d3d227523015ea2fccb46705010c04ee126 https://github.com/buildbot/buildbot/commit/9e0c9d3d227523015ea2fccb46705010c04ee126 Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/scripts/upgrade_master.py Log Message: ----------- Fix the "checking" message in upgrade-master to accommodate a config file from the .tac Commit: 7f029641aff8ab1bbdecb3e1d914a99d5b92a224 https://github.com/buildbot/buildbot/commit/7f029641aff8ab1bbdecb3e1d914a99d5b92a224 Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_base.py Log Message: ----------- Move .tac-fallback unit tests to test_scripts_base; reinstate basedir prepending to filename in loadConfig Commit: 69fc8c7a0ca7084b3b2e5ea93c613cdec3ffc2d6 https://github.com/buildbot/buildbot/commit/69fc8c7a0ca7084b3b2e5ea93c613cdec3ffc2d6 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_upgrade_master.py Log Message: ----------- Merge branch 'ticket2310' of git://github.com/imccowan/buildbot Compare: https://github.com/buildbot/buildbot/compare/16e9edeb925a...69fc8c7a0ca7 From trac at buildbot.net Tue Mar 19 20:28:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 20:28:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2310: upgrade-master doesn't support master.cfg located outside of basedir In-Reply-To: <038.821f792fd746d7847d807ccb9ec39eb4@buildbot.net> References: <038.821f792fd746d7847d807ccb9ec39eb4@buildbot.net> Message-ID: <053.5b11bddd188e019dcd9a4ea16fa05813@buildbot.net> #2310: upgrade-master doesn't support master.cfg located outside of basedir -----------------------------+--------------------- Reporter: KeiKun | Owner: Type: enhancement | Status: closed Priority: patches-accepted | Milestone: 0.8.8 Version: 0.8.6p1 | Resolution: fixed Keywords: simple | -----------------------------+--------------------- Changes (by dustin): * status: assigned => closed * resolution: => fixed Old description: > Some buildbot subcommands (e.g., buildbot checkconfig) currently assume > that Buildbot's configuration file is named master.cfg, and is located in > the master's basedir. This is not always the case. The name amd > location of the config file are specified in the master's buildbot.tac, > which is always in the basedir. > > All of the buildbot subcommands should support a master.cfg that is not > in the default location. Tests should verify that this is the case. > > At least 'buildbot checkconfig' and 'buildbot upgrade-master' do not work > correctly. New description: Some buildbot subcommands (e.g., buildbot checkconfig) currently assume that Buildbot's configuration file is named master.cfg, and is located in the master's basedir. This is not always the case. The name amd location of the config file are specified in the master's buildbot.tac, which is always in the basedir. All of the buildbot subcommands should support a master.cfg that is not in the default location. Tests should verify that this is the case. At least 'buildbot checkconfig' and 'buildbot upgrade-master' do not work correctly. -- Comment: {{{ commit 69fc8c7a0ca7084b3b2e5ea93c613cdec3ffc2d6 Merge: 16e9ede 7f02964 Author: Dustin J. Mitchell Date: Tue Mar 19 16:26:44 2013 -0400 Merge branch 'ticket2310' of git://github.com/imccowan/buildbot }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Mar 19 21:42:38 2013 From: noreply at github.com (GitHub) Date: Tue, 19 Mar 2013 14:42:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] aa09a2: Added optimization chapter to master manual. Message-ID: <5148dbce22d8_1c8897412c46783@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: aa09a2bafdf7b207b03167598abf3e7db754de68 https://github.com/buildbot/buildbot/commit/aa09a2bafdf7b207b03167598abf3e7db754de68 Author: Vasily Litvinov Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/docs/manual/index.rst A master/docs/manual/optimization.rst Log Message: ----------- Added optimization chapter to master manual. For now it contains a snippet on speeding up properties load from a database if the properties are strings Commit: b290a4590a3e76090d519dee3a106ff571e7629f https://github.com/buildbot/buildbot/commit/b290a4590a3e76090d519dee3a106ff571e7629f Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/docs/manual/index.rst A master/docs/manual/optimization.rst Log Message: ----------- Merge branch 'docs_optimization_chapter' of git://github.com/JustAMan/buildbot Compare: https://github.com/buildbot/buildbot/compare/69fc8c7a0ca7...b290a4590a3e From trac at buildbot.net Tue Mar 19 23:01:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 19 Mar 2013 23:01:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2475: MaildirService will fail if started and stopped repeatedly Message-ID: <038.bbb4fc36a536df9a0e46c00de7f0da17@buildbot.net> #2475: MaildirService will fail if started and stopped repeatedly --------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Keywords: simple --------------------+-------------------- This class adds a child service in `startService`, but doesn't remove it in `stopService`. This means if it is started and stopped and started again, it will have two child services. This doesn't actually hurt anything in practice, but it's wrong and will bite someone someday. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 20 00:40:42 2013 From: noreply at github.com (GitHub) Date: Tue, 19 Mar 2013 17:40:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 261c39: fix test failures on mock==0.7.2 Message-ID: <51490589f2a5e_763bef513c84479@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 261c39198f71a5a124ab50cac662a1b75beb3c53 https://github.com/buildbot/buildbot/commit/261c39198f71a5a124ab50cac662a1b75beb3c53 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- fix test failures on mock==0.7.2 Commit: f8040afc5c9758750b17fd8665f874ff2fcee064 https://github.com/buildbot/buildbot/commit/f8040afc5c9758750b17fd8665f874ff2fcee064 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/locks.py M master/buildbot/test/unit/test_config.py Log Message: ----------- fix test failures on mock==0.6.0 Commit: 4f54edb807926197dd4b4bbc15987bd829a292fe https://github.com/buildbot/buildbot/commit/4f54edb807926197dd4b4bbc15987bd829a292fe Author: Vasily Litvinov Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Added caching the results of getRecentBuilds() method - should speed up grid page generation Commit: 3931b6f4bce90901c748c1ac85f6fca937203441 https://github.com/buildbot/buildbot/commit/3931b6f4bce90901c748c1ac85f6fca937203441 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- fix pyflakes Commit: 62b48bc7b4cb457e42093c05a5d06c9c4bef92e3 https://github.com/buildbot/buildbot/commit/62b48bc7b4cb457e42093c05a5d06c9c4bef92e3 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Merge branch 'grid_speedup' of git://github.com/JustAMan/buildbot Compare: https://github.com/buildbot/buildbot/compare/b290a4590a3e...62b48bc7b4cb From trac at buildbot.net Wed Mar 20 11:04:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 20 Mar 2013 11:04:35 -0000 Subject: [Buildbot-commits] [Buildbot] #708: Incorporate bzr_poller.py and add more docs In-Reply-To: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> References: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> Message-ID: <053.976c2c54ee643b0778cd789c93be3b68@buildbot.net> #708: Incorporate bzr_poller.py and add more docs -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: master | Resolution: Keywords: bzr | -----------------------------+-------------------- Comment (by gracinet): Current status (branch bzrpoller of my github fork) * This !BzrPoller passed a real-life test * I have a first working unit test, relying on ```mock``` to replace bzrlib. I'd need some adviced on the preferred way to proceed with those tests, here. Gary provided a separate ```generate_change``` function, primarily for code factorization between the hook and the poller. The current (draft) unit tests replace all ```bzrlib```` calls, including those made by this ```generate_change``` by mocks. That's a bit cumbersome for the writer and the reader, and I don't think there's much value in going down to that detail: if ```bzrlib`` API changes, the tests won't see it anyway (of course). We could very well mock the ```generate_change``` function instead. What do you think ? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Mar 20 13:11:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 20 Mar 2013 13:11:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2293: Simplify MSYS+buildslave integration In-Reply-To: <035.3549ecee3c19691488379fe51a7bf365@buildbot.net> References: <035.3549ecee3c19691488379fe51a7bf365@buildbot.net> Message-ID: <050.1f57882219d1fb66037b3dcd27ffef00@buildbot.net> #2293: Simplify MSYS+buildslave integration -----------------------------+-------------------- Reporter: LRN | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | -----------------------------+-------------------- Comment (by LRN): What is the status of this ticket? Is anything being done, or the whole idea is unacceptable? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Mar 20 14:36:02 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 20 Mar 2013 14:36:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2293: Simplify MSYS+buildslave integration In-Reply-To: <035.3549ecee3c19691488379fe51a7bf365@buildbot.net> References: <035.3549ecee3c19691488379fe51a7bf365@buildbot.net> Message-ID: <050.be069cfc51ca05ac0774952f29bfabdb@buildbot.net> #2293: Simplify MSYS+buildslave integration -----------------------------+-------------------- Reporter: LRN | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | -----------------------------+-------------------- Old description: > Right now buildslave runs ALL [[ShellCommand]]s using COMSPEC. > > This is bad, because COMSPEC is defined to Windows shell interpreter, not > Bash (or any other shell). Moreover, buildslave will add "/c" to the > command it gets from COMSPEC, if it isn't there already. So even if user > re-defines COMSPEC to call a POSIX-compliant shell (which doesn't really > work well - see below), it still gets extra "/c", which prevents it from > working correctly. > > Re-defining COMSPEC is a bad idea anyway, because certain programs (such > as libtool) may internally rely on COMSPEC to run things. They expect > COMSPEC to point to Windows shell interpreter, and when it isn't...well, > you can imagine what happens. > > I propose to add an environment variable that can be set for buildslave, > which will point to a POSIX-compliant shell to use (i.e. > x:/foo/bar/bin/sh.exe --login). > It also places the command that should be run into a script file, and > makes the shell run that file instead of passing the command as its > argument. The reason is that it's easier to handle quoting that way ("-c" > option only takes one argument, so it can be difficult to fit large > commands into it), and also changes current directory as needed. > > Directory change is needed because of the --login option. Using --login > is necessary for shell to source the right initialization files (which, > among other things, set up the PATH and several other environment > variables), however it has a side-effect of setting current directory to > "~". New description: Right now buildslave runs ALL [[ShellCommand]]s using COMSPEC. This is bad, because COMSPEC is defined to Windows shell interpreter, not Bash (or any other shell). Moreover, buildslave will add "/c" to the command it gets from COMSPEC, if it isn't there already. So even if user re-defines COMSPEC to call a POSIX-compliant shell (which doesn't really work well - see below), it still gets extra "/c", which prevents it from working correctly. Re-defining COMSPEC is a bad idea anyway, because certain programs (such as libtool) may internally rely on COMSPEC to run things. They expect COMSPEC to point to Windows shell interpreter, and when it isn't...well, you can imagine what happens. I propose to add an environment variable that can be set for buildslave, which will point to a POSIX-compliant shell to use (i.e. x:/foo/bar/bin/sh.exe --login). It also places the command that should be run into a script file, and makes the shell run that file instead of passing the command as its argument. The reason is that it's easier to handle quoting that way ("-c" option only takes one argument, so it can be difficult to fit large commands into it), and also changes current directory as needed. Directory change is needed because of the --login option. Using --login is necessary for shell to source the right initialization files (which, among other things, set up the PATH and several other environment variables), however it has a side-effect of setting current directory to "~". -- Comment (by dustin): Neither - the idea is acceptable, but to my knowledge nothing is being done. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Mar 20 18:40:08 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 20 Mar 2013 18:40:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2467: source.SVN incorrectly handles repositories with special character in URL In-Reply-To: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> References: <038.29e2017d8be667b80e9979e30ba1c025@buildbot.net> Message-ID: <053.a55ec23aa574ee5b0571c2c74c0e8027@buildbot.net> #2467: source.SVN incorrectly handles repositories with special character in URL ------------------------+-------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.7 | Resolution: Keywords: svn, simple | ------------------------+-------------------- Old description: > buildbot.steps.source.SVN checks is currently fetched repository is the > same as set in configuration by running `svn info` and comparing returned > URL with URL from configuration (see _sourcedirIsUpdatable()). > > If URL in configuration contains special characters or spaces, like > "svn://example.org/my repo/", `svn info` returns URL in internal > "canonical" form: "svn://example.org/my%20repo/". So Buildbot always > thinks that repository changed, removes it and checks out again. > > As workaround you can specify URL in Buildbot configuration in canonical > form: "svn://example.org/my%20repo/". > > P.S. Also, why parsing `svn info` result and not call `svn info --xml` > and use XML reader? New description: buildbot.steps.source.SVN checks is currently fetched repository is the same as set in configuration by running `svn info` and comparing returned URL with URL from configuration (see _sourcedirIsUpdatable()). If URL in configuration contains special characters or spaces, like "svn://example.org/my repo/", `svn info` returns URL in internal "canonical" form: "svn://example.org/my%20repo/". So Buildbot always thinks that repository changed, removes it and checks out again. As workaround you can specify URL in Buildbot configuration in canonical form: "svn://example.org/my%20repo/". P.S. Also, why parsing `svn info` result and not call `svn info --xml` and use XML reader? -- Comment (by dustin): But that canonicalize function is *not* simple! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 20 20:54:35 2013 From: noreply at github.com (GitHub) Date: Wed, 20 Mar 2013 13:54:35 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 19bb21: maildir bug fixed, allowed maildir to be started a... Message-ID: <514a220b504ff_366562113c29935@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 19bb212d14ba460d611bfae152aa853d847ebfec https://github.com/buildbot/buildbot/commit/19bb212d14ba460d611bfae152aa853d847ebfec Author: Joana Botto Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py Log Message: ----------- maildir bug fixed, allowed maildir to be started and stopped repeatly Fixes #2475 Commit: 2ab94b7339d5c3a598ee83b40bd9b477a6b14710 https://github.com/buildbot/buildbot/commit/2ab94b7339d5c3a598ee83b40bd9b477a6b14710 Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py Log Message: ----------- Merge branch 'maildir_bug' of git://github.com/jbotto/buildbot Compare: https://github.com/buildbot/buildbot/compare/62b48bc7b4cb...2ab94b7339d5 From noreply at github.com Wed Mar 20 21:20:38 2013 From: noreply at github.com (GitHub) Date: Wed, 20 Mar 2013 14:20:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b540d7: changed the unit test to AssertEqual Message-ID: <514a2826212ba_1bfb76c12c42537@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b540d7a08bccf2ed8138f0d257dfec7914a79238 https://github.com/buildbot/buildbot/commit/b540d7a08bccf2ed8138f0d257dfec7914a79238 Author: Joana Botto Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py Log Message: ----------- changed the unit test to AssertEqual Commit: 1213d2ae7df2e96283226e1c57ae49089557b92e https://github.com/buildbot/buildbot/commit/1213d2ae7df2e96283226e1c57ae49089557b92e Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py Log Message: ----------- Merge branch 'maildir_bug' of git://github.com/jbotto/buildbot Compare: https://github.com/buildbot/buildbot/compare/2ab94b7339d5...1213d2ae7df2 From trac at buildbot.net Wed Mar 20 21:33:06 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 20 Mar 2013 21:33:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2475: MaildirService will fail if started and stopped repeatedly In-Reply-To: <038.bbb4fc36a536df9a0e46c00de7f0da17@buildbot.net> References: <038.bbb4fc36a536df9a0e46c00de7f0da17@buildbot.net> Message-ID: <053.3a6f4050803d20f4e49eede52253e37c@buildbot.net> #2475: MaildirService will fail if started and stopped repeatedly --------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: fixed Keywords: simple | --------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Fixed by jbotto: {{{ commit 19bb212d14ba460d611bfae152aa853d847ebfec Author: Joana Botto Date: Wed Mar 20 13:31:10 2013 -0700 maildir bug fixed, allowed maildir to be started and stopped repeatly Fixes #2475 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Mar 20 21:34:13 2013 From: noreply at github.com (GitHub) Date: Wed, 20 Mar 2013 14:34:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d18b9d: Add SetProperty build step Message-ID: <514a2b55b760_563862e13424733@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d18b9d21f25f27e28b1007722d91c7c0da6d5fa2 https://github.com/buildbot/buildbot/commit/d18b9d21f25f27e28b1007722d91c7c0da6d5fa2 Author: Jake Watkins Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Add SetProperty build step Commit: 6dff575856afbd4198e9cbe4914513940bd8a290 https://github.com/buildbot/buildbot/commit/6dff575856afbd4198e9cbe4914513940bd8a290 Author: Jake Watkins Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Rename SetProperty step in buildbot.steps.shell to SetPropertyFromCommand Commit: 816429a73c9a4cd4b9483de0e5cf88f05efef835 https://github.com/buildbot/buildbot/commit/816429a73c9a4cd4b9483de0e5cf88f05efef835 Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pycon2013-sprints' of git://github.com/dividehex/buildbot (relnotes edited) Compare: https://github.com/buildbot/buildbot/compare/1213d2ae7df2...816429a73c9a From trac at buildbot.net Thu Mar 21 00:07:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 00:07:56 -0000 Subject: [Buildbot-commits] [Buildbot] #708: Incorporate bzr_poller.py and add more docs In-Reply-To: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> References: <038.493ebe47318ffd7630fc2757d22b566e@buildbot.net> Message-ID: <053.57211bad30188855e815fa1788046c83@buildbot.net> #708: Incorporate bzr_poller.py and add more docs -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: master | Resolution: Keywords: bzr | -----------------------------+-------------------- Comment (by dustin): How likely is it that the bzrlib API will change? That's a real risk, but mocking it would have the advantage of letting us test against the "old" and "new" APIs if it did change. I'd have to see your tests to give more specific advice, but it sounds like you're on the right track. Maybe clean it up and post a preliminary pull request so Tom and I can have a look? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 00:10:28 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 00:10:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2476: tutorial "buildbot create-master master" fails with ImportError Message-ID: <040.ab2d7771ecf23d15d3d27bf5f97be8cc@buildbot.net> #2476: tutorial "buildbot create-master master" fails with ImportError ----------------------+----------------------- Reporter: kennethd | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- due to an incompatibility with sqlalchemy-migrate==0.7.2 and SQLAlchemy==0.8.0 {{{ (sandbox)kenneth at dhalgren:/tmp/bb$ buildbot create-master master Traceback (most recent call last): File "/tmp/bb/sandbox/bin/buildbot", line 5, in pkg_resources.run_script('buildbot==0.8.7p1', 'buildbot') File "build/bdist.linux-i686/egg/pkg_resources.py", line 489, in run_script File "build/bdist.linux-i686/egg/pkg_resources.py", line 1207, in run_script File "/tmp/bb/sandbox/lib/python2.6/site- packages/buildbot-0.8.7p1-py2.6.egg/EGG-INFO/scripts/buildbot", line 4, in runner.run() File "/tmp/bb/sandbox/lib/python2.6/site- packages/buildbot-0.8.7p1-py2.6.egg/buildbot/scripts/runner.py", line 696, in run subcommandFunction = reflect.namedObject(subconfig.subcommandFunction) File "/tmp/bb/sandbox/lib/python2.6/site- packages/Twisted-12.3.0-py2.6-linux-i686.egg/twisted/python/_reflectpy3.py", line 95, in namedObject module = namedModule('.'.join(classSplit[:-1])) File "/tmp/bb/sandbox/lib/python2.6/site- packages/Twisted-12.3.0-py2.6-linux-i686.egg/twisted/python/_reflectpy3.py", line 82, in namedModule topLevel = __import__(name) File "/tmp/bb/sandbox/lib/python2.6/site- packages/buildbot-0.8.7p1-py2.6.egg/buildbot/scripts/create_master.py", line 23, in from buildbot.db import connector File "/tmp/bb/sandbox/lib/python2.6/site- packages/buildbot-0.8.7p1-py2.6.egg/buildbot/db/connector.py", line 22, in from buildbot.db import pool, model, changes, schedulers, sourcestamps, sourcestampsets File "/tmp/bb/sandbox/lib/python2.6/site- packages/buildbot-0.8.7p1-py2.6.egg/buildbot/db/model.py", line 18, in import migrate.versioning.schema File "/tmp/bb/sandbox/lib/python2.6/site- packages/sqlalchemy_migrate-0.7.2-py2.6.egg/migrate/versioning/schema.py", line 10, in from sqlalchemy import exceptions as sa_exceptions ImportError: cannot import name exceptions }}} see https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=156 i tried doing the following, but my edit didn't "take", it went ahead & tried to install 0.8.0 anyway: {{{ (sandbox)kenneth at dhalgren:/tmp/bb2$ easy_install -b ./.build --dry-run buildbot (sandbox)kenneth at dhalgren:/tmp/bb2$ cp .build/buildbot/setup.py ./.build/buildbot/setup.py.ORIG (sandbox)kenneth at dhalgren:/tmp/bb2$ vim .build/buildbot/setup.py (sandbox)kenneth at dhalgren:/tmp/bb2$ diff .build/buildbot/setup.py ./.build/buildbot/setup.py.ORIG 192c192 < 'sqlalchemy >= 0.6, <= 0.7.10', # sqlalchemy-migrate not compatible with sqlalchemy 0.8.0 --- > 'sqlalchemy >= 0.6', (sandbox)kenneth at dhalgren:/tmp/bb2$ easy_install -b ./.build buildbot }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 00:32:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 00:32:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2476: tutorial "buildbot create-master master" fails with ImportError In-Reply-To: <040.ab2d7771ecf23d15d3d27bf5f97be8cc@buildbot.net> References: <040.ab2d7771ecf23d15d3d27bf5f97be8cc@buildbot.net> Message-ID: <055.3e183edcf0d0250dcfa55300866553d8@buildbot.net> #2476: tutorial "buildbot create-master master" fails with ImportError ----------------------+------------------------ Reporter: kennethd | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by kennethd): workaround installing from source with same edit as above: {{{ kenneth at dhalgren:/tmp$ mkdir bbtut && cd bbtut kenneth at dhalgren:/tmp/bbtut$ virtualenv --no-site-packages sandbox kenneth at dhalgren:/tmp/bbtut$ source sandbox/bin/activate (sandbox)kenneth at dhalgren:/tmp/bbtut$ mkdir src && cd src (sandbox)kenneth at dhalgren:/tmp/bbtut/src$ wget https://buildbot.googlecode.com/files/buildbot-0.8.7p1.tar.gz (sandbox)kenneth at dhalgren:/tmp/bbtut/src$ tar xzf buildbot-0.8.7p1.tar.gz (sandbox)kenneth at dhalgren:/tmp/bbtut/src$ cp buildbot-0.8.7p1/setup.py buildbot-0.8.7p1/setup.py.ORIG (sandbox)kenneth at dhalgren:/tmp/bbtut/src$ vim buildbot-0.8.7p1/setup.py (sandbox)kenneth at dhalgren:/tmp/bbtut/src$ diff buildbot-0.8.7p1/setup.py buildbot-0.8.7p1/setup.py.ORIG 192c192 < 'sqlalchemy >= 0.6, <= 0.7.10', --- > 'sqlalchemy >= 0.6', (sandbox)kenneth at dhalgren:/tmp/bbtut/src$ cd buildbot-0.8.7p1/ (sandbox)kenneth at dhalgren:/tmp/bbtut/src/buildbot-0.8.7p1$ ./setup.py install (sandbox)kenneth at dhalgren:/tmp/bbtut/src/buildbot-0.8.7p1$ cd ../../ (sandbox)kenneth at dhalgren:/tmp/bbtut$ which buildbot /tmp/bbtut/sandbox/bin/buildbot }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 00:34:52 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 00:34:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2476: tutorial "buildbot create-master master" fails with ImportError In-Reply-To: <040.ab2d7771ecf23d15d3d27bf5f97be8cc@buildbot.net> References: <040.ab2d7771ecf23d15d3d27bf5f97be8cc@buildbot.net> Message-ID: <055.1094d330082bff30534c770321a3b892@buildbot.net> #2476: tutorial "buildbot create-master master" fails with ImportError ---------------------+--------------------- Reporter: kennethd | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: | ---------------------+--------------------- Changes (by dustin): * status: new => closed * type: undecided => defect * resolution: => fixed * milestone: undecided => 0.8.8 Comment: Yeah, that fix has already been merged in master. We're about to release 0.8.8 which will contain this fix. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 21 00:35:40 2013 From: noreply at github.com (GitHub) Date: Wed, 20 Mar 2013 17:35:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5bbff2: Ticket #2226 - Added build step LogRenderable Message-ID: <514a55dc80df9_3b90b731302329d@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5bbff249920d504a33f18a69a5061d3209ba4caf https://github.com/buildbot/buildbot/commit/5bbff249920d504a33f18a69a5061d3209ba4caf Author: Joana Botto Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Ticket #2226 - Added build step LogRenderable Commit: 572c149dcfa45c8b02f67d5f9ad5bdc54047c9c4 https://github.com/buildbot/buildbot/commit/572c149dcfa45c8b02f67d5f9ad5bdc54047c9c4 Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug_2226' of git://github.com/jbotto/buildbot Compare: https://github.com/buildbot/buildbot/compare/816429a73c9a...572c149dcfa4 From trac at buildbot.net Thu Mar 21 00:35:48 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 00:35:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2226: Add a buildstep that just renders stuff into a log file. In-Reply-To: <042.15bf7a88e35697a03e04984a593c5ce0@buildbot.net> References: <042.15bf7a88e35697a03e04984a593c5ce0@buildbot.net> Message-ID: <057.a215b55d9acb4d3c22bfb2e18562908a@buildbot.net> #2226: Add a buildstep that just renders stuff into a log file. ---------------------------+------------------------- Reporter: tom.prince | Owner: tom.prince Type: enhancement | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.5 | Resolution: fixed Keywords: sprint, simple | ---------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: {{{ commit 5bbff249920d504a33f18a69a5061d3209ba4caf Author: Joana Botto Date: Wed Mar 20 17:08:34 2013 -0700 Ticket #2226 - Added build step LogRenderable }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 01:48:42 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 01:48:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2477: Create command line tool to get and search build step log files Message-ID: <040.868fe6728ee5c3321acf876efe3f7c49@buildbot.net> #2477: Create command line tool to get and search build step log files ------------------------+----------------------- Reporter: bdbaddog | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ------------------------+----------------------- As this will be required to get logs in Nine, and useful now. buildbot_log builder_name build_id buildstep_name log_name -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 01:53:29 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 01:53:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2477: Create command line tool to get and search build step log files In-Reply-To: <040.868fe6728ee5c3321acf876efe3f7c49@buildbot.net> References: <040.868fe6728ee5c3321acf876efe3f7c49@buildbot.net> Message-ID: <055.72f890e391aae8fb95846dd2307f3709@buildbot.net> #2477: Create command line tool to get and search build step log files ------------------------+-------------------- Reporter: bdbaddog | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by dustin): * keywords: => sprint * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 10:10:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 10:10:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" Message-ID: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" -------------------------+----------------------- Reporter: thomaswayden | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: -------------------------+----------------------- When the build of project A finishes, I'm trying to kick off a build of the latest revision of project B with the bits from A installed. So at the end of my build steps I added: {{{ trigger.Trigger(schedulerNames=['projectB-trigger'], alwaysUseLatest = True) }}} But the corresponding Triggerable is never called and I have this in my master log: {{{ 2013-03-21 01:16:52+0100 [-] releaseLocks(): [] 2013-03-21 01:16:52+0100 [-] step 'Buildit' complete: success 2013-03-21 01:16:53+0100 [-] releaseLocks(): [] 2013-03-21 01:16:53+0100 [-] step 'trigger' complete: success 2013-03-21 01:16:53+0100 [-] : build finished 2013-03-21 01:16:54+0100 [-] setting expectations for next time 2013-03-21 01:16:54+0100 [-] new expectations: 2473.42296886 seconds 2013-03-21 01:16:55+0100 [-] releaseLocks(): [] 2013-03-21 01:16:58+0100 [-] (ignored) while invoking Triggerable schedulers: Traceback (most recent call last): File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 422, in errback self._startRunCallbacks(fail) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 489, in _startRunCallbacks self._runCallbacks() File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 576, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 1127, in gotResult _inlineCallbacks(r, g, deferred) --- --- File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 1069, in _inlineCallbacks result = result.throwExceptionIntoGenerator(g) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/buildbot/schedulers/base.py", line 356, in addBuildsetForSourceStampSetDetails sourcestampsetid=new_setid) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/python/threadpool.py", line 172, in _worker result = context.call(ctx, function, *args, **kwargs) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/python/context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/twisted/python/context.py", line 81, in callWithContext return func(*args,**kw) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/buildbot/db/pool.py", line 182, in __thd rv = callable(arg, *args, **kwargs) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/buildbot/db/sourcestamps.py", line 64, in thd sourcestampsetid=sourcestampsetid)) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/sqlalchemy/engine/base.py", line 1449, in execute params) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/sqlalchemy/engine/base.py", line 1584, in _execute_clauseelement compiled_sql, distilled_params File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/sqlalchemy/engine/base.py", line 1698, in _execute_context context) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/sqlalchemy/engine/base.py", line 1691, in _execute_context context) File "/Users/test/buildbot/sandbox/lib/python2.7/site- packages/sqlalchemy/engine/default.py", line 331, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.IntegrityError: (IntegrityError) sourcestamps.repository may not be NULL u'INSERT INTO sourcestamps (branch, revision, patchid, repository, codebase, project, sourcestampsetid) VALUES (?, ?, ?, ?, ?, ?, ?)' (None, None, None, None, '', '', 80) }}} I'm running the latest version (0.8.7p1). Am I doing anything wrong? Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 21 17:32:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 17:32:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" In-Reply-To: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> References: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> Message-ID: <059.bc3e9f102f5cd16613615a61d60dfe2d@buildbot.net> #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" -------------------------+---------------------- Reporter: thomaswayden | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7p1 Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+---------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.7p1 Comment: So it's very hard to say what *you* are doing wrong to tickle this bug, but I see what we're doing wrong. Basically, repository has to be set to something, and the default value here is `None`. This should fix it up: {{{ #! diff diff --git a/master/buildbot/schedulers/base.py b/master/buildbot/schedulers/base.py index 6c4ccf1..a552525 100644 --- a/master/buildbot/schedulers/base.py +++ b/master/buildbot/schedulers/base.py @@ -344,7 +344,7 @@ class BaseScheduler(service.MultiService, ComparableMixin, StateMixin): # add sourcestamp to the new setid yield self.master.db.sourcestamps.addSourceStamp( codebase=codebase, - repository=ss.get('repository', None), + repository=ss.get('repository', ''), branch=ss.get('branch', None), revision=ss.get('revision', None), project=ss.get('project', ''), }}} How is the build containing the Trigger step being initiated? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 21 17:39:59 2013 From: noreply at github.com (GitHub) Date: Thu, 21 Mar 2013 10:39:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec78fb: Use '' as a default for repository Message-ID: <514b45ef40111_2f90a71138589af@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ec78fb793f3a520454e85c758ed8098aa02ef4fb https://github.com/buildbot/buildbot/commit/ec78fb793f3a520454e85c758ed8098aa02ef4fb Author: Dustin J. Mitchell Date: 2013-03-21 (Thu, 21 Mar 2013) Changed paths: M master/buildbot/schedulers/base.py Log Message: ----------- Use '' as a default for repository Refs #2478. From trac at buildbot.net Thu Mar 21 17:40:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 17:40:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" In-Reply-To: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> References: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> Message-ID: <059.5a9bfa1c26fc1965acfd0f3492abfbfa@buildbot.net> #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" -------------------------+---------------------- Reporter: thomaswayden | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7p1 Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+---------------------- Comment (by dustin): I committed the fix above to master. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Mar 21 17:53:27 2013 From: noreply at github.com (GitHub) Date: Thu, 21 Mar 2013 10:53:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5bcd70: Added basic HTTP auth for /change_hook/github Message-ID: <514b4917ee53c_63c810021383193b@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 5bcd700e0ff7e65a4488b8fff31a49dd96544023 https://github.com/buildbot/buildbot/commit/5bcd700e0ff7e65a4488b8fff31a49dd96544023 Author: Michael Mayorov Date: 2013-03-10 (Sun, 10 Mar 2013) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- Added basic HTTP auth for /change_hook/github Commit: e247c2b1515a1e194b5124f13bd5a7b08b41ad90 https://github.com/buildbot/buildbot/commit/e247c2b1515a1e194b5124f13bd5a7b08b41ad90 Author: Aleksey Vasenev Date: 2013-03-12 (Tue, 12 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- Output for user Command-line Tool was fixed Commit: 430c0c8423da83fa42d25b178b7cfc7de540a850 https://github.com/buildbot/buildbot/commit/430c0c8423da83fa42d25b178b7cfc7de540a850 Author: Aleksey Vasenev Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- Unnecessary code removed Commit: c988de81b16a310154f57c07e89b29e5f4dec83f https://github.com/buildbot/buildbot/commit/c988de81b16a310154f57c07e89b29e5f4dec83f Author: Michael Mayorov Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Added information about ``change_hook_auth`` option Commit: 0468561b4c9386a6bbfe07c56eb32c9c4f5f6449 https://github.com/buildbot/buildbot/commit/0468561b4c9386a6bbfe07c56eb32c9c4f5f6449 Author: Michael Mayorov Date: 2013-03-13 (Wed, 13 Mar 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Small fix in documentation about ``change_hook_auth`` Commit: 50e5f625e2e2df27eb3ebc318887162a452acf30 https://github.com/buildbot/buildbot/commit/50e5f625e2e2df27eb3ebc318887162a452acf30 Author: Aleksey Vasenev Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- None output was suppressed Commit: 12b56130782e675b8d645826e2670a78ea9083b6 https://github.com/buildbot/buildbot/commit/12b56130782e675b8d645826e2670a78ea9083b6 Author: Elmir Jagudin Date: 2013-03-14 (Thu, 14 Mar 2013) Changed paths: M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- unit test 'buildbot --verbose' cli option Test that '--verbose' option for buildbot command enables logging to stderr. Commit: 986bfeebe9b4da2b5bf2609e6178f5a0dddc3d96 https://github.com/buildbot/buildbot/commit/986bfeebe9b4da2b5bf2609e6178f5a0dddc3d96 Author: Aleksey Vasenev Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Windows service was fixed Commit: 928803b4e6146ee3748847b28649c3335c49e7d2 https://github.com/buildbot/buildbot/commit/928803b4e6146ee3748847b28649c3335c49e7d2 Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/__init__.py Log Message: ----------- Remove redundant space Commit: b9f07f88066cd63b5032f9ed483f3d7449f3dfaa https://github.com/buildbot/buildbot/commit/b9f07f88066cd63b5032f9ed483f3d7449f3dfaa Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/scripts/runner.py M slave/buildslave/scripts/runner.py Log Message: ----------- Typo: "intechangeably" Commit: 28afe45516ceaebe375460ceafa8a0c71753923f https://github.com/buildbot/buildbot/commit/28afe45516ceaebe375460ceafa8a0c71753923f Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/status/web/logs.py Log Message: ----------- Remove redundant brackets Commit: c9a4ebba1f75e6f11d29375ec510cfefca7edbe4 https://github.com/buildbot/buildbot/commit/c9a4ebba1f75e6f11d29375ec510cfefca7edbe4 Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- Add dot at the end of sentence Commit: e726b4829ca413d7cdfbd9b83100e2ea294d29a2 https://github.com/buildbot/buildbot/commit/e726b4829ca413d7cdfbd9b83100e2ea294d29a2 Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- Remove "Callbacks" capitalization Commit: 6e7300f4e2ad9aeb3ff9796c6a79011f6f377acd https://github.com/buildbot/buildbot/commit/6e7300f4e2ad9aeb3ff9796c6a79011f6f377acd Author: Vladimir Rutsky Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- Fix indent Commit: d555796acf43174a745a2dcee66e5a794e109b43 https://github.com/buildbot/buildbot/commit/d555796acf43174a745a2dcee66e5a794e109b43 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'buildbot-cli-test' of git://github.com/elmirjagudin/buildbot Commit: 13431142fc75fa23b68c319c4b829e1ecf5579b8 https://github.com/buildbot/buildbot/commit/13431142fc75fa23b68c319c4b829e1ecf5579b8 Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/buildbot/__init__.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/logs.py M master/docs/developer/style.rst M slave/buildslave/scripts/runner.py Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Commit: 525f82ab71862041d4d1c7ac468bf3d48a2231ad https://github.com/buildbot/buildbot/commit/525f82ab71862041d4d1c7ac468bf3d48a2231ad Author: Dustin J. Mitchell Date: 2013-03-15 (Fri, 15 Mar 2013) Changed paths: M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'windows_service_fix' of git://github.com/Ratio2/buildbot Commit: 2bb5705d40eecef281a00eda2bc5a535d5add412 https://github.com/buildbot/buildbot/commit/2bb5705d40eecef281a00eda2bc5a535d5add412 Author: Dustin J. Mitchell Date: 2013-03-16 (Sat, 16 Mar 2013) Changed paths: M master/buildbot/scripts/user.py Log Message: ----------- Merge branch 'user_command_fix' of git://github.com/Ratio2/buildbot Commit: 48b3aa1e74d7c2fb2052b4232da69258d817aa25 https://github.com/buildbot/buildbot/commit/48b3aa1e74d7c2fb2052b4232da69258d817aa25 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html Log Message: ----------- show_events does opposite of that was written Commit: 7a1abe8f56b6e27cfbc3f3ad9226d65c1ca9c66c https://github.com/buildbot/buildbot/commit/7a1abe8f56b6e27cfbc3f3ad9226d65c1ca9c66c Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- Add closing bracket Commit: b5e95fc2489a0d56c212ad875d4e538788ff6112 https://github.com/buildbot/buildbot/commit/b5e95fc2489a0d56c212ad875d4e538788ff6112 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-schedulers.rst Log Message: ----------- Add missing bracket. Should fix code formatting Commit: 1de633c7c0c07233d5286d4373c771ffa63530d9 https://github.com/buildbot/buildbot/commit/1de633c7c0c07233d5286d4373c771ffa63530d9 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/libvirtbuildslave.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Replace "doesnt" with "doesn't" Commit: d39de9b6d286e6ea91748212026d9ca9f3461626 https://github.com/buildbot/buildbot/commit/d39de9b6d286e6ea91748212026d9ca9f3461626 Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/libvirtbuildslave.py Log Message: ----------- Fix indent Commit: 78e5fdff6ab49c6af06fa197b90e8c083c235b4a https://github.com/buildbot/buildbot/commit/78e5fdff6ab49c6af06fa197b90e8c083c235b4a Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/process/builder.py Log Message: ----------- Remove unnecessary backslash Commit: 41e2fcd1e887efc916a82e02d28cc87206b87e77 https://github.com/buildbot/buildbot/commit/41e2fcd1e887efc916a82e02d28cc87206b87e77 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-schedulers.rst Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Commit: 3132b5888406d47245d55188e7788204e9c7d474 https://github.com/buildbot/buildbot/commit/3132b5888406d47245d55188e7788204e9c7d474 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/libvirtbuildslave.py M master/buildbot/process/builder.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- Merge branch 'typos2' of git://github.com/vrutsky/buildbot Commit: 81bcb66b46d89f21bcc9e2185c17ae32d9fc52dd https://github.com/buildbot/buildbot/commit/81bcb66b46d89f21bcc9e2185c17ae32d9fc52dd Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge branch '2186-change-hook-auth' of git://github.com/MichaelMayorov/buildbot Commit: 867d9548a15f3b24b86d02be78c0f4126fa01dc0 https://github.com/buildbot/buildbot/commit/867d9548a15f3b24b86d02be78c0f4126fa01dc0 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- minor docs edits Commit: 1b905fcf6126f3b5a06aaf0400aeb0615ce77c0d https://github.com/buildbot/buildbot/commit/1b905fcf6126f3b5a06aaf0400aeb0615ce77c0d Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/libvirtbuildslave.py M master/contrib/windows/buildbot_service.py Log Message: ----------- Fix indentation Commit: afd33b4512acbca435e94bce08ebc5c0f7cf4e2d https://github.com/buildbot/buildbot/commit/afd33b4512acbca435e94bce08ebc5c0f7cf4e2d Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/buildslave.py M master/buildbot/libvirtbuildslave.py M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Typos: possibilty, prefined, builtbot, explictly Commit: 0b44dfa451aff51dbe86ea5f4edd5c03ba7f619b https://github.com/buildbot/buildbot/commit/0b44dfa451aff51dbe86ea5f4edd5c03ba7f619b Author: Vladimir Rutsky Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Fix LibVirtSlave example and add connection argument description to docs Commit: 1a7e2b2520a23fcee90b3e61289187146c4452b1 https://github.com/buildbot/buildbot/commit/1a7e2b2520a23fcee90b3e61289187146c4452b1 Author: sunya7a Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py Log Message: ----------- Ticket #2409 Using DeferredLock.run() in favor of .acquire and .release in master/buildbot/process/buildrequestdistributor.py Commit: a6f82caae87e2e3ba0587ef9d3b393c6e0c0eb66 https://github.com/buildbot/buildbot/commit/a6f82caae87e2e3ba0587ef9d3b393c6e0c0eb66 Author: Erik Stephens Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/integration/v087p1-README.txt A master/buildbot/test/integration/v087p1.tgz Log Message: ----------- Upgrade tests for 0.8.7 Commit: b75a8ef15638b03b45380cdf281942fc51e1a72c https://github.com/buildbot/buildbot/commit/b75a8ef15638b03b45380cdf281942fc51e1a72c Author: ian mccowan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/config.py Log Message: ----------- Fix to ticket #2310: make loadConfig check for a configfile path in the .tac file if the default location doesn't exist Commit: 9f378f209851f618e4f7f0485424be675f538cde https://github.com/buildbot/buildbot/commit/9f378f209851f618e4f7f0485424be675f538cde Author: ian mccowan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- Add a test that getting the config file path from the .tac file works Commit: 5efb4b5e53173760cbffecefc6a7fc4959e3c26d https://github.com/buildbot/buildbot/commit/5efb4b5e53173760cbffecefc6a7fc4959e3c26d Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/buildslave.py M master/buildbot/config.py M master/buildbot/libvirtbuildslave.py M master/contrib/windows/buildbot_service.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'typos' of git://github.com/vrutsky/buildbot Commit: 34e7d0c36cf38f5c260f3859faa4de6997cae686 https://github.com/buildbot/buildbot/commit/34e7d0c36cf38f5c260f3859faa4de6997cae686 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Merge branch 'libvirt_slave_docs_fix' of git://github.com/vrutsky/buildbot Commit: c6f1f05aa4d954f7c6f8e8f6ceac9c41dbece5b8 https://github.com/buildbot/buildbot/commit/c6f1f05aa4d954f7c6f8e8f6ceac9c41dbece5b8 Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py Log Message: ----------- Merge branch 'master' of git://github.com/sunya7a/buildbot Commit: 9048a0af6e5e16999cc35d534cebc4c44131509f https://github.com/buildbot/buildbot/commit/9048a0af6e5e16999cc35d534cebc4c44131509f Author: Dustin J. Mitchell Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/integration/v087p1-README.txt A master/buildbot/test/integration/v087p1.tgz Log Message: ----------- Merge branch 'bug2439' of git://github.com/orvant/buildbot Commit: 47182ecf7e4e91721da3119c42d5f5794a2c27f0 https://github.com/buildbot/buildbot/commit/47182ecf7e4e91721da3119c42d5f5794a2c27f0 Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Address code review comment: https://github.com/buildbot/buildbot/pull/673#issuecomment-15095930 and fall back to the .tac config location before calling loadConfig Commit: 16e9edeb925a2847c43c1aa5273d3f5992c1911a https://github.com/buildbot/buildbot/commit/16e9edeb925a2847c43c1aa5273d3f5992c1911a Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/integration/v087p1.tgz Log Message: ----------- rebuild the sqlite DB on sqlite-3.6.20 for compatibility Commit: 11f0a6565e27e7c08886e574c4a00fcbe33794aa https://github.com/buildbot/buildbot/commit/11f0a6565e27e7c08886e574c4a00fcbe33794aa Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_upgrade_master.py Log Message: ----------- Fix the way in which we fail with unfound configs to pass the unit tests. loadConfig must take a full path, not try to prepend the basedir, because it may take a fully qualified path as specified in the .tac. Commit: 9e0c9d3d227523015ea2fccb46705010c04ee126 https://github.com/buildbot/buildbot/commit/9e0c9d3d227523015ea2fccb46705010c04ee126 Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/scripts/upgrade_master.py Log Message: ----------- Fix the "checking" message in upgrade-master to accommodate a config file from the .tac Commit: 7f029641aff8ab1bbdecb3e1d914a99d5b92a224 https://github.com/buildbot/buildbot/commit/7f029641aff8ab1bbdecb3e1d914a99d5b92a224 Author: ian mccowan Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_base.py Log Message: ----------- Move .tac-fallback unit tests to test_scripts_base; reinstate basedir prepending to filename in loadConfig Commit: 69fc8c7a0ca7084b3b2e5ea93c613cdec3ffc2d6 https://github.com/buildbot/buildbot/commit/69fc8c7a0ca7084b3b2e5ea93c613cdec3ffc2d6 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/config.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_upgrade_master.py Log Message: ----------- Merge branch 'ticket2310' of git://github.com/imccowan/buildbot Commit: aa09a2bafdf7b207b03167598abf3e7db754de68 https://github.com/buildbot/buildbot/commit/aa09a2bafdf7b207b03167598abf3e7db754de68 Author: Vasily Litvinov Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/docs/manual/index.rst A master/docs/manual/optimization.rst Log Message: ----------- Added optimization chapter to master manual. For now it contains a snippet on speeding up properties load from a database if the properties are strings Commit: b290a4590a3e76090d519dee3a106ff571e7629f https://github.com/buildbot/buildbot/commit/b290a4590a3e76090d519dee3a106ff571e7629f Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/docs/manual/index.rst A master/docs/manual/optimization.rst Log Message: ----------- Merge branch 'docs_optimization_chapter' of git://github.com/JustAMan/buildbot Commit: 261c39198f71a5a124ab50cac662a1b75beb3c53 https://github.com/buildbot/buildbot/commit/261c39198f71a5a124ab50cac662a1b75beb3c53 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- fix test failures on mock==0.7.2 Commit: f8040afc5c9758750b17fd8665f874ff2fcee064 https://github.com/buildbot/buildbot/commit/f8040afc5c9758750b17fd8665f874ff2fcee064 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/locks.py M master/buildbot/test/unit/test_config.py Log Message: ----------- fix test failures on mock==0.6.0 Commit: 4f54edb807926197dd4b4bbc15987bd829a292fe https://github.com/buildbot/buildbot/commit/4f54edb807926197dd4b4bbc15987bd829a292fe Author: Vasily Litvinov Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Added caching the results of getRecentBuilds() method - should speed up grid page generation Commit: 3931b6f4bce90901c748c1ac85f6fca937203441 https://github.com/buildbot/buildbot/commit/3931b6f4bce90901c748c1ac85f6fca937203441 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_config.py Log Message: ----------- fix pyflakes Commit: 62b48bc7b4cb457e42093c05a5d06c9c4bef92e3 https://github.com/buildbot/buildbot/commit/62b48bc7b4cb457e42093c05a5d06c9c4bef92e3 Author: Dustin J. Mitchell Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Merge branch 'grid_speedup' of git://github.com/JustAMan/buildbot Commit: d18b9d21f25f27e28b1007722d91c7c0da6d5fa2 https://github.com/buildbot/buildbot/commit/d18b9d21f25f27e28b1007722d91c7c0da6d5fa2 Author: Jake Watkins Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Add SetProperty build step Commit: 6dff575856afbd4198e9cbe4914513940bd8a290 https://github.com/buildbot/buildbot/commit/6dff575856afbd4198e9cbe4914513940bd8a290 Author: Jake Watkins Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Rename SetProperty step in buildbot.steps.shell to SetPropertyFromCommand Commit: 19bb212d14ba460d611bfae152aa853d847ebfec https://github.com/buildbot/buildbot/commit/19bb212d14ba460d611bfae152aa853d847ebfec Author: Joana Botto Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py Log Message: ----------- maildir bug fixed, allowed maildir to be started and stopped repeatly Fixes #2475 Commit: 2ab94b7339d5c3a598ee83b40bd9b477a6b14710 https://github.com/buildbot/buildbot/commit/2ab94b7339d5c3a598ee83b40bd9b477a6b14710 Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py Log Message: ----------- Merge branch 'maildir_bug' of git://github.com/jbotto/buildbot Commit: b540d7a08bccf2ed8138f0d257dfec7914a79238 https://github.com/buildbot/buildbot/commit/b540d7a08bccf2ed8138f0d257dfec7914a79238 Author: Joana Botto Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py Log Message: ----------- changed the unit test to AssertEqual Commit: 1213d2ae7df2e96283226e1c57ae49089557b92e https://github.com/buildbot/buildbot/commit/1213d2ae7df2e96283226e1c57ae49089557b92e Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/test/unit/test_util_maildir.py Log Message: ----------- Merge branch 'maildir_bug' of git://github.com/jbotto/buildbot Commit: 816429a73c9a4cd4b9483de0e5cf88f05efef835 https://github.com/buildbot/buildbot/commit/816429a73c9a4cd4b9483de0e5cf88f05efef835 Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pycon2013-sprints' of git://github.com/dividehex/buildbot (relnotes edited) Commit: 5bbff249920d504a33f18a69a5061d3209ba4caf https://github.com/buildbot/buildbot/commit/5bbff249920d504a33f18a69a5061d3209ba4caf Author: Joana Botto Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Ticket #2226 - Added build step LogRenderable Commit: 572c149dcfa45c8b02f67d5f9ad5bdc54047c9c4 https://github.com/buildbot/buildbot/commit/572c149dcfa45c8b02f67d5f9ad5bdc54047c9c4 Author: Dustin J. Mitchell Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/master.py M master/buildbot/test/unit/test_steps_master.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug_2226' of git://github.com/jbotto/buildbot Commit: ec78fb793f3a520454e85c758ed8098aa02ef4fb https://github.com/buildbot/buildbot/commit/ec78fb793f3a520454e85c758ed8098aa02ef4fb Author: Dustin J. Mitchell Date: 2013-03-21 (Thu, 21 Mar 2013) Changed paths: M master/buildbot/schedulers/base.py Log Message: ----------- Use '' as a default for repository Refs #2478. Commit: b4dece37549521ad2a3d23a9afdd870ae09367f9 https://github.com/buildbot/buildbot/commit/b4dece37549521ad2a3d23a9afdd870ae09367f9 Author: Dustin J. Mitchell Date: 2013-03-21 (Thu, 21 Mar 2013) Changed paths: M master/buildbot/__init__.py M master/buildbot/buildslave.py M master/buildbot/config.py M master/buildbot/libvirtbuildslave.py M master/buildbot/locks.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/runner.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/scripts/user.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/grid.py M master/buildbot/status/web/logs.py M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/steps/master.py M master/buildbot/steps/shell.py M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/integration/v087p1-README.txt A master/buildbot/test/integration/v087p1.tgz M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_scripts_upgrade_master.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py M master/contrib/windows/buildbot_service.py M master/docs/developer/style.rst M master/docs/manual/cfg-buildslaves.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/index.rst A master/docs/manual/optimization.rst M master/docs/relnotes/index.rst M slave/buildslave/scripts/runner.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'master' into nine Conflicts: master/buildbot/schedulers/base.py master/buildbot/test/unit/test_steps_trigger.py Compare: https://github.com/buildbot/buildbot/compare/98e77e1f25b2...b4dece375495 From trac at buildbot.net Thu Mar 21 20:46:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 21 Mar 2013 20:46:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2479: master creation fails with nine if buildbot-www is not installed with pip Message-ID: <038.18e0bfce40f7c558da8a02fefdc3eb25@buildbot.net> #2479: master creation fails with nine if buildbot-www is not installed with pip -------------------+------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.9.+ Version: master | Keywords: -------------------+------------------- When I was creating a development environment for buildbot nine, I installed buildbot-www using 'python setup.py install'. However, if I tried to create a master using that setup I hit the following traceback: {{{ (sandbox)[tflink at localhost buildbot_work]$ buildbot create-master master mkdir /home/tflink/buildbot_work/master creating /home/tflink/buildbot_work/master/master.cfg.sample populating public_html/ populating templates/ Traceback (most recent call last): File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 1214, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 1071, in _inlineCallbacks result = g.send(result) File "/home/tflink/buildbot_work/src/master/buildbot/scripts/create_master.py", line 145, in createMaster yield createDB(config) File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 1214, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) --- --- File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/twisted/internet/defer.py", line 1071, in _inlineCallbacks result = g.send(result) File "/home/tflink/buildbot_work/src/master/buildbot/scripts/create_master.py", line 128, in createDB master = BuildMaster(config['basedir']) File "/home/tflink/buildbot_work/src/master/buildbot/master.py", line 82, in __init__ self.create_child_services() File "/home/tflink/buildbot_work/src/master/buildbot/master.py", line 146, in create_child_services self.www = wwwservice.WWWService(self) File "/home/tflink/buildbot_work/src/master/buildbot/www/service.py", line 36, in __init__ for ep in pkg_resources.iter_entry_points('buildbot.www') ] File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/setuptools-0.6c11-py2.7.egg/pkg_resources.py", line 1954, in load File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/buildbot_www-0.8.7p1_778_g98e77e1-py2.7.egg/buildbot_www.py", line 59, in ep = Application() File "/home/tflink/buildbot_work/sandbox/lib/python2.7/site- packages/buildbot_www-0.8.7p1_778_g98e77e1-py2.7.egg/buildbot_www.py", line 52, in __init__ self.version = open(verfile).read().strip() exceptions.IOError: [Errno 2] No such file or directory: '/home/tflink/buildbot_work/sandbox/share/buildbot/dist/buildbot- version.txt' }}} Once I installed buildbot-www with pip, I was able to create a master without issue -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Mar 22 00:44:06 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 22 Mar 2013 00:44:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2479: master creation fails with nine if buildbot-www is not installed with pip In-Reply-To: <038.18e0bfce40f7c558da8a02fefdc3eb25@buildbot.net> References: <038.18e0bfce40f7c558da8a02fefdc3eb25@buildbot.net> Message-ID: <053.0d01c3b0d29ec41d31b6e9827e5445ad@buildbot.net> #2479: master creation fails with nine if buildbot-www is not installed with pip -------------------+----------------------- Reporter: tflink | Owner: dustin Type: defect | Status: assigned Priority: minor | Milestone: 0.9.0 Version: master | Resolution: Keywords: | -------------------+----------------------- Changes (by dustin): * owner: => dustin * status: new => assigned * milestone: 0.9.+ => 0.9.0 Comment: I need to fix up the setup and install process here - the existing design still assumes Dojo's build.sh. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Mar 22 10:25:05 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 22 Mar 2013 10:25:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" In-Reply-To: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> References: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> Message-ID: <059.d932b8fc52c077346d2e29d5d6feb671@buildbot.net> #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" -------------------------+---------------------- Reporter: thomaswayden | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.7p1 Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+---------------------- Comment (by thomaswayden): I confirm this fixes it, thanks a lot! The build containing the Trigger step is initiated by a SVNPoller + SingleBranchScheduler. It triggers a build of a different project, hosted on Git (and usually triggered by GitPoller + SingleBranchScheduler). So I need alwaysUseLatest = True. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Mar 25 17:53:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 25 Mar 2013 17:53:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure Message-ID: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure ----------------------+----------------------- Reporter: dank | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- buildbots with more than ten masters using GitPoller against the same git server via ssh seem to fail to notice changes. The only indication of error is messages like ssh_exchange_identification: Connection closed by remote host in twisted.log on the master. This happens because the ssh daemon drops incoming connections when they exceed the MaxStartups or MaxSessions limits from sshd.conf. Both default to 10. Users can raise those limits, but it'd be better to avoid the thundering herd in the first place. A workaround is for the user to fuzz the pollIntervals, e.g. GitPoller(repourl, branches=branchnames, pollinterval=300 + random.uniform(-10, 10)) A fix might be to build the fuzzing into GitPoller or PollingChangeSource, so users didn't have to worry about it. Perhaps add a pollIntervalFuzz parameter that defaults to 10. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Mar 26 00:15:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 26 Mar 2013 00:15:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure In-Reply-To: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> References: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> Message-ID: <051.7cfaae14b7e0ea50314bc4439e984a64@buildbot.net> #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure ----------------------+------------------------ Reporter: dank | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dank): (FWIW, I've also seen folks request fuzzing on schedulers, http://permalink.gmane.org/gmane.comp.python.buildbot.devel/1262 ) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Mar 26 01:24:50 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 26 Mar 2013 01:24:50 -0000 Subject: [Buildbot-commits] [Buildbot] #581: Automatic builder creation for new branches In-Reply-To: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> References: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> Message-ID: <056.ca48564ac855cf52fca4bcd861347e03@buildbot.net> #581: Automatic builder creation for new branches ------------------------+--------------------- Reporter: mhoermann | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+--------------------- Changes (by aidanfeldman): * cc: aidan.feldman@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Mar 26 18:37:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 26 Mar 2013 18:37:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" In-Reply-To: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> References: <044.999930fb12f9b5e596c37678c8743164@buildbot.net> Message-ID: <059.9f4a0500d9163cc2b8df09825807fa17@buildbot.net> #2478: Triggerable schedulers not triggered, "sourcestamps.repository may not be NULL" -------------------------+--------------------- Reporter: thomaswayden | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: | -------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed * milestone: 0.8.7p1 => 0.8.8 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Mar 28 13:22:33 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 28 Mar 2013 13:22:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2041: use consumeErrors for all gatherResults calls In-Reply-To: <038.bbed7febfd6ab9b9ebbf4afc55e309e1@buildbot.net> References: <038.bbed7febfd6ab9b9ebbf4afc55e309e1@buildbot.net> Message-ID: <053.e314e0d16d3642718a03bf6542438ea6@buildbot.net> #2041: use consumeErrors for all gatherResults calls ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.4p1 | Resolution: fixed Keywords: sprint | ------------------------+--------------------- Changes (by dustin): * status: assigned => closed * resolution: => fixed Old description: > gatherResults does not, by default, pass consumeErrors to the underlying > !DeferredList. But http://twistedmatrix.com/trac/ticket/5159 would add > this as a parameter. When (if) that gets merged, Buildbot should monkey- > patch it into older versions of Twisted, and use it universally. > > This will prevent unnecessary "unhandled exception" logs, where we *have* > handled the exception as part of the gathered results. New description: gatherResults does not, by default, pass consumeErrors to the underlying !DeferredList. But http://twistedmatrix.com/trac/ticket/5159 would add this as a parameter. When (if) that gets merged, Buildbot should monkey- patch it into older versions of Twisted, and use it universally. This will prevent unnecessary "unhandled exception" logs, where we *have* handled the exception as part of the gathered results. -- Comment: This was already fixed in master, but the bug not closed - Daniel just spent a lot of time studying the background of it to find it already complete :( -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Mar 29 03:15:20 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 29 Mar 2013 03:15:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure In-Reply-To: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> References: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> Message-ID: <051.8796f53a8fad6a9ebed528b4ee511592@buildbot.net> #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure ----------------------+------------------------ Reporter: dank | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): This might be interesting to implement in #2442 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Mar 29 03:15:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 29 Mar 2013 03:15:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2442: Generic polling utility with support for stopping a service In-Reply-To: <038.ddc9c895bc9763d734efcd54a106df94@buildbot.net> References: <038.ddc9c895bc9763d734efcd54a106df94@buildbot.net> Message-ID: <053.7cb3c8317774cbf01226b0aef3269e0c@buildbot.net> #2442: Generic polling utility with support for stopping a service ------------------------+--------------------- Reporter: dustin | Owner: dustin Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: sprint | ------------------------+--------------------- Old description: > !LoopingCall and !TimedService are OK, but it's hard to make sure they > stop looping before stopService is complete. This pattern repeats all > over Buildbot, with some confusing, difficult-to-test code as the result. > > We should have some generic support for this, well-tested, and used > throughout. New description: !LoopingCall and !TimedService are OK, but it's hard to make sure they stop looping before stopService is complete. This pattern repeats all over Buildbot, with some confusing, difficult-to-test code as the result. We should have some generic support for this, well-tested, and used throughout. -- Comment (by dustin): See #2480 which suggests adding some randomization to spread out events that would otherwise fire at exactly the same time. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Mar 30 20:22:06 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 30 Mar 2013 20:22:06 -0000 Subject: [Buildbot-commits] [Buildbot] #387: TerminateProcess fails in buildbot_service.py In-Reply-To: <038.e56964fe350d217620d07b1b844dc128@buildbot.net> References: <038.e56964fe350d217620d07b1b844dc128@buildbot.net> Message-ID: <053.5b5f7dd97c5a93ecb487117d46e31be8@buildbot.net> #387: TerminateProcess fails in buildbot_service.py --------------------+-------------------- Reporter: griels | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.5 | Resolution: Keywords: windows | --------------------+-------------------- Comment (by LRN): Here's some [[http://trac.buildbot.net/attachment/ticket/387/kill.py|code]] . You can use it as application (pass pid as its first argument). The code itself can be copied into runprocess.py, and you can call safe_termiate_process_by_pid () on W32 instead of running taskkill. This code (unlike the one i posted at tigris.org) is actually tested with a buildslave. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 31 03:35:19 2013 From: noreply at github.com (GitHub) Date: Sat, 30 Mar 2013 20:35:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 504b8b: moved isBuildslaveDir() to it's own module Message-ID: <5157aef7a6292_1e485e013c8983c@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 504b8b47fb8c03a524d30fec4ac91a2557e5a2a8 https://github.com/buildbot/buildbot/commit/504b8b47fb8c03a524d30fec4ac91a2557e5a2a8 Author: Elmir Jagudin Date: 2013-03-21 (Thu, 21 Mar 2013) Changed paths: A slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- moved isBuildslaveDir() to it's own module Moved isBuildslaveDir() function from buildslave.scripts.runner module to a new buildslave.scripts.base module. This way it is possible for to move logic for checking that 'buildslave start' is run with valid buildslave base directory inside buildslave.scripts.startup.start() function. Commit: 446f15ea070b32f5986bdc6612954511b296f3f2 https://github.com/buildbot/buildbot/commit/446f15ea070b32f5986bdc6612954511b296f3f2 Author: Elmir Jagudin Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py A slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- changed error handling in buildslave.scripts.base.isBuildslaveDir() - Catch open/read errors while reading buildbot.tac, and print error message. - Print affected file and directory in error messages to ease troublshooting. - Moved all error messages inside isBuildslaveDir() Commit: f61420c63c56a2c19f4acfd77feadfcb3dcf443b https://github.com/buildbot/buildbot/commit/f61420c63c56a2c19f4acfd77feadfcb3dcf443b Author: Elmir Jagudin Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/restart.py M master/buildbot/scripts/start.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_upgrade_master.py Log Message: ----------- changed error handling in buildslave.scripts.base.isBuildmasterDir() - Catch open/read errors while reading buildbot.tac, and print error message. - Print affected file and directory in error messages to ease troublshooting. - Moved all error messages inside isBuildmasterDir() Commit: 0952711e5faf11c5e2a52c277c2aa49079ceca84 https://github.com/buildbot/buildbot/commit/0952711e5faf11c5e2a52c277c2aa49079ceca84 Author: Dustin J. Mitchell Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/restart.py M master/buildbot/scripts/start.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_upgrade_master.py A slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py A slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'basedir-checks' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/ec78fb793f3a...0952711e5faf From noreply at github.com Sun Mar 31 03:49:12 2013 From: noreply at github.com (GitHub) Date: Sat, 30 Mar 2013 20:49:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b5607c: py25 fixes Message-ID: <5157b238bb538_25bef2113869676@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b5607c9929cf8e0dc269cc7f36c094d66822a054 https://github.com/buildbot/buildbot/commit/b5607c9929cf8e0dc269cc7f36c094d66822a054 Author: Dustin J. Mitchell Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M slave/buildslave/scripts/base.py Log Message: ----------- py25 fixes From trac at buildbot.net Sun Mar 31 18:04:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 31 Mar 2013 18:04:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2481: CopyDirectory missing from buildbot.steps.slave in 0.8.7p1 Message-ID: <040.91ba96fe5beb97a56486636c7107a6d9@buildbot.net> #2481: CopyDirectory missing from buildbot.steps.slave in 0.8.7p1 -----------------------------+--------------------------------- Reporter: bhristov | Owner: Type: defect | Status: new Priority: patches-accepted | Milestone: undecided Version: 0.8.7p1 | Keywords: steps, slaves, copy -----------------------------+--------------------------------- Working on Ubuntu 12.04, I did pip install buildbot --upgrade to get the latest version (0.8.7p1). It installs in /usr/local/lib/python2.7/dist- packages/buildbot, and is successful (typing buildbot --version prints 0.8.7p1). However, when I try to add a CopyDirectory step to one of my builers, I get Traceback (most recent call last): ... File "/var/lib/buildbot/masters/master.cfg", line 116, in from buildbot.steps.slave import CopyDirectory exceptions.ImportError: cannot import name CopyDirectory Indeed, inspecting the source of buildbot/steps/slave.py reveals that CopyDirectory is not there, contrary to what documentation states and to what is seen on your repository (https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/slave.py) I copied the definition from the repository to the file in my library and it now works but it might cause more problems if this omission is not rectified or mentioned in the docs. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Mar 31 18:30:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 31 Mar 2013 18:30:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2481: CopyDirectory missing from buildbot.steps.slave in 0.8.7p1 In-Reply-To: <040.91ba96fe5beb97a56486636c7107a6d9@buildbot.net> References: <040.91ba96fe5beb97a56486636c7107a6d9@buildbot.net> Message-ID: <055.a7deb5f4413d95fe1770f1096e1e45a3@buildbot.net> #2481: CopyDirectory missing from buildbot.steps.slave in 0.8.7p1 --------------------------------+------------------------ Reporter: bhristov | Owner: Type: defect | Status: closed Priority: patches-accepted | Milestone: undecided Version: 0.8.7p1 | Resolution: invalid Keywords: steps, slaves, copy | --------------------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => invalid Comment: !CopyDirectory wasn't present in 0.8.7p1. It's only in the "latest" docs, which are for the master (un-released) branch. We should have a new release out shortly (right, tom? ;) ) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Mar 31 19:31:02 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 31 Mar 2013 19:31:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2481: CopyDirectory missing from buildbot.steps.slave in 0.8.7p1 In-Reply-To: <040.91ba96fe5beb97a56486636c7107a6d9@buildbot.net> References: <040.91ba96fe5beb97a56486636c7107a6d9@buildbot.net> Message-ID: <055.06679fc4dae36d0e375b07d6f79e86ac@buildbot.net> #2481: CopyDirectory missing from buildbot.steps.slave in 0.8.7p1 --------------------------------+------------------------ Reporter: bhristov | Owner: Type: defect | Status: closed Priority: patches-accepted | Milestone: undecided Version: 0.8.7p1 | Resolution: invalid Keywords: steps, slaves, copy | --------------------------------+------------------------ Comment (by bhristov): Oh, right. So I've basically been using something that's not out yet -- good to know! I like it though so I'll continue using it :) Thanks for the help! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Mar 31 22:38:06 2013 From: noreply at github.com (GitHub) Date: Sun, 31 Mar 2013 15:38:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 504b8b: moved isBuildslaveDir() to it's own module Message-ID: <5158bacec53a8_6492a7113858950@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 504b8b47fb8c03a524d30fec4ac91a2557e5a2a8 https://github.com/buildbot/buildbot/commit/504b8b47fb8c03a524d30fec4ac91a2557e5a2a8 Author: Elmir Jagudin Date: 2013-03-21 (Thu, 21 Mar 2013) Changed paths: A slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- moved isBuildslaveDir() to it's own module Moved isBuildslaveDir() function from buildslave.scripts.runner module to a new buildslave.scripts.base module. This way it is possible for to move logic for checking that 'buildslave start' is run with valid buildslave base directory inside buildslave.scripts.startup.start() function. Commit: 446f15ea070b32f5986bdc6612954511b296f3f2 https://github.com/buildbot/buildbot/commit/446f15ea070b32f5986bdc6612954511b296f3f2 Author: Elmir Jagudin Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py A slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- changed error handling in buildslave.scripts.base.isBuildslaveDir() - Catch open/read errors while reading buildbot.tac, and print error message. - Print affected file and directory in error messages to ease troublshooting. - Moved all error messages inside isBuildslaveDir() Commit: f61420c63c56a2c19f4acfd77feadfcb3dcf443b https://github.com/buildbot/buildbot/commit/f61420c63c56a2c19f4acfd77feadfcb3dcf443b Author: Elmir Jagudin Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/restart.py M master/buildbot/scripts/start.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_upgrade_master.py Log Message: ----------- changed error handling in buildslave.scripts.base.isBuildmasterDir() - Catch open/read errors while reading buildbot.tac, and print error message. - Print affected file and directory in error messages to ease troublshooting. - Moved all error messages inside isBuildmasterDir() Commit: 0952711e5faf11c5e2a52c277c2aa49079ceca84 https://github.com/buildbot/buildbot/commit/0952711e5faf11c5e2a52c277c2aa49079ceca84 Author: Dustin J. Mitchell Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/restart.py M master/buildbot/scripts/start.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_upgrade_master.py A slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py A slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'basedir-checks' of git://github.com/elmirjagudin/buildbot Commit: b5607c9929cf8e0dc269cc7f36c094d66822a054 https://github.com/buildbot/buildbot/commit/b5607c9929cf8e0dc269cc7f36c094d66822a054 Author: Dustin J. Mitchell Date: 2013-03-30 (Sat, 30 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M slave/buildslave/scripts/base.py Log Message: ----------- py25 fixes Commit: 2d73bf0d872f9283896ded25a9c08bf1fa47b74c https://github.com/buildbot/buildbot/commit/2d73bf0d872f9283896ded25a9c08bf1fa47b74c Author: Dustin J. Mitchell Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/restart.py M master/buildbot/scripts/start.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_upgrade_master.py A slave/buildslave/scripts/base.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py A slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'master' into nine Commit: d87c87794e3128388dd34c358dbfa93cd7d8097f https://github.com/buildbot/buildbot/commit/d87c87794e3128388dd34c358dbfa93cd7d8097f Author: Dustin J. Mitchell Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_steps.py Log Message: ----------- support older simplejson, which sometimes fails to return unicode from dumps Compare: https://github.com/buildbot/buildbot/compare/b4dece375495...d87c87794e31 From trac at buildbot.net Sun Mar 31 23:43:10 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 31 Mar 2013 23:43:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2461: Add support for providing and graphing data charts of build statistics over time. (was: Add support for providing and graphing data charts of metrics over time.) In-Reply-To: <035.e7dbeb1ff209523ffe365bc7355d9def@buildbot.net> References: <035.e7dbeb1ff209523ffe365bc7355d9def@buildbot.net> Message-ID: <050.48db447e2f77dd25e2f9fa5eca744009@buildbot.net> #2461: Add support for providing and graphing data charts of build statistics over time. -------------------------+-------------------- Reporter: juj | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Description changed by dustin: Old description: > This is a feature request I would find extremely useful, and it's also > one that would probably be a good one for GSoC, since it's a new feature > with visually concrete results, which can make it more > compelling/tractable for a new developer to get interested in. > > I maintain a continuous testing architecture for the Emscripten C++->JS > compiler project (https://github.com/kripken/emscripten). It has an > extensive unit testing and benchmarking suite, which prints a lot of > graphable metrics out as the result of its run. The buildbot page is > openly accessible at http://clb.demon.fi:8112/waterfall . More > explanation at the bottom of the page here > https://github.com/kripken/emscripten/wiki . While maintaining the > buildbot, I've often wondered about the following: > > * How do build times vary over time? Are we optimizing the compiler, or > is it getting more bloated and slowing down over time? Which commits > caused big regressions/improvements? > * How do buildbot task run times vary over time? These are already > logged at the end of stdio with lines "program finished with exit code 0 > elapsedTime=1060.951319", which we'd like to graph over time. > * How does runtime execution performance of compiled apps change over > time? Emscripten has runtime benchmarks tester that tests runtime > performance: http://clb.demon.fi:8112/builders/ubuntu-emcc-incoming- > tests/builds/175/steps/Benchmarks/logs/stdio . Which commits caused big > regressions/improvements? > * How does compiled code size vary over time? There are some test apps > that get built and stored after each commit: > http://clb.demon.fi/dump/emcc/win-emcc-incoming-code-test/ . Which > commits caused big regressions/improvements? > > To be able to measure these kind of quality concerns, visual graphing > could be the answer. Being able to feed custom data fields into a data > storage inside buildbot, and having a built-in data grapher integrated to > buildbot HTTP server to visually compare metrics over time would be > immensely helpful. > > The architecture should be somehow custom-driven so that the buildbot > config files can control what data to generate and feed into graphs, > since most of the above data points are specific to the project in > question. > > Utilizing existing free graphing solutions would be expected, see for > reference: > * http://raphaeljs.com/analytics.html > * https://www.reverserisk.com/ico/ (line graphs) > * etc. New description: This is a feature request I would find extremely useful, and it's also one that would probably be a good one for GSoC, since it's a new feature with visually concrete results, which can make it more compelling/tractable for a new developer to get interested in. I maintain a continuous testing architecture for the Emscripten C++->JS compiler project (https://github.com/kripken/emscripten). It has an extensive unit testing and benchmarking suite, which prints a lot of graphable metrics out as the result of its run. The buildbot page is openly accessible at http://clb.demon.fi:8112/waterfall . More explanation at the bottom of the page here https://github.com/kripken/emscripten/wiki . While maintaining the buildbot, I've often wondered about the following: * How do build times vary over time? Are we optimizing the compiler, or is it getting more bloated and slowing down over time? Which commits caused big regressions/improvements? * How do buildbot task run times vary over time? These are already logged at the end of stdio with lines "program finished with exit code 0 elapsedTime=1060.951319", which we'd like to graph over time. * How does runtime execution performance of compiled apps change over time? Emscripten has runtime benchmarks tester that tests runtime performance: http://clb.demon.fi:8112/builders/ubuntu-emcc-incoming- tests/builds/175/steps/Benchmarks/logs/stdio . Which commits caused big regressions/improvements? * How does compiled code size vary over time? There are some test apps that get built and stored after each commit: http://clb.demon.fi/dump/emcc /win-emcc-incoming-code-test/ . Which commits caused big regressions/improvements? To be able to measure these kind of quality concerns, visual graphing could be the answer. Being able to feed custom data fields into a data storage inside buildbot, and having a built-in data grapher integrated to buildbot HTTP server to visually compare metrics over time would be immensely helpful. The architecture should be somehow custom-driven so that the buildbot config files can control what data to generate and feed into graphs, since most of the above data points are specific to the project in question. Utilizing existing free graphing solutions would be expected, see for reference: * http://raphaeljs.com/analytics.html * https://www.reverserisk.com/ico/ (line graphs) * etc. -- -- Ticket URL: Buildbot Buildbot: build/test automation