[Buildbot-commits] [buildbot/buildbot] d3b9ce: Add test for checking generated .tac file

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: d3b9ce11d67d2dfe0d372917d80b4e1fcd19dc44
      https://github.com/buildbot/buildbot/commit/d3b9ce11d67d2dfe0d372917d80b4e1fcd19dc44
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_create_slave.py

  Log Message:
  -----------
  Add test for checking generated .tac file

It checks that .tac file is valid Python script by exec()-uting it with
mocked globals imports, such as twisted.application.service.Application
and buildslave.bot.BuildSlave.
Then it checks, that Application was created and stored in global
variable "application" (as .tac specification requires); checks that
BuildSlave created with passed arguments and attached to application.


  Commit: 7f557d5f225b42e19eb6d7e9787ce57711fdf07e
      https://github.com/buildbot/buildbot/commit/7f557d5f225b42e19eb6d7e9787ce57711fdf07e
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_create_slave.py

  Log Message:
  -----------
  Add tests for basedir containing quotes, spaces and backslashes

Quotes test failing with master Buildbot.

In one of the older Buildbot releases I tried to create slave on Windows
end ended with invalid .tac file due to something like this:

  basedir = 'C:\basedir\'

Looks like this is fixed in master, but adding test won't hurt.


  Commit: 48447b43c94d8a55ee4900a2819ed7486170d75d
      https://github.com/buildbot/buildbot/commit/48447b43c94d8a55ee4900a2819ed7486170d75d
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/scripts/create_slave.py

  Log Message:
  -----------
  Fix handling basedir with quotes


  Commit: a252a91485700467b13b990592186d111a002421
      https://github.com/buildbot/buildbot/commit/a252a91485700467b13b990592186d111a002421
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Add tests for invalid --umask and --allow-shutdown options

Currently fails.


  Commit: 247d0f3ce8976d8efbf9ec8e688d8d4ea5fc7e6b
      https://github.com/buildbot/buildbot/commit/247d0f3ce8976d8efbf9ec8e688d8d4ea5fc7e6b
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py

  Log Message:
  -----------
  Handle invalid --umask and --allow-shutdown options


  Commit: 12dc3f4b4a0c8bbb83c5aac17bdfc19fa0dcb38e
      https://github.com/buildbot/buildbot/commit/12dc3f4b4a0c8bbb83c5aac17bdfc19fa0dcb38e
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_create_slave.py

  Log Message:
  -----------
  Add test for handling special characters in all options fields

Currently fails.


  Commit: 66a5a8db5efb1531444def57da237f7495403445
      https://github.com/buildbot/buildbot/commit/66a5a8db5efb1531444def57da237f7495403445
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/scripts/create_slave.py

  Log Message:
  -----------
  Fix options fields writing in .tac file


  Commit: 1d12db6aa257cd5ab7948ff087b29860eb2d05e6
      https://github.com/buildbot/buildbot/commit/1d12db6aa257cd5ab7948ff087b29860eb2d05e6
  Author: Vladimir Rutsky <altsysrq at gmail.com>
  Date:   2013-07-03 (Wed, 03 Jul 2013)

  Changed paths:
    M slave/buildslave/scripts/create_slave.py

  Log Message:
  -----------
  Write "log-size" as numeric, since it's always integer


  Commit: 059a37ad9348162e9080dcc25037ea7f1c12de5a
      https://github.com/buildbot/buildbot/commit/059a37ad9348162e9080dcc25037ea7f1c12de5a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-07-06 (Sat, 06 Jul 2013)

  Changed paths:
    M slave/buildslave/scripts/create_slave.py
    M slave/buildslave/scripts/runner.py
    M slave/buildslave/test/unit/test_scripts_create_slave.py
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Merge branch 'slave_tac_check_and_fix' of git://github.com/vrutsky/buildbot


Compare: https://github.com/buildbot/buildbot/compare/99e57e6577dc...059a37ad9348