[Buildbot-commits] [Buildbot] #2527: Bug in oldsource.py class _ComputeRepositoryURL

[Buildbot trac]

#2527: Bug in oldsource.py class _ComputeRepositoryURL
-------------------+-----------------------
Reporter:  Jani    |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  undecided
 Version:  0.8.5   |   Keywords:
-------------------+-----------------------
 Hello,

 OS: Ubuntu 12.04.2 LTS
 Buildbot: 0.8.5-2
 Python: 2.7.3

 In steps/source/oldsource.py there is class _ComputeRepositoryURL(object),
 but it seems not to use the 'object' and returns some string always.

 This causes a problem in class Bzr(Source) later in the same file on line
 1105 where it has:

 if self.repourl:
    assert not branch # we need baseURL= to use branches
    self.args['repourl'] = self.repourl

 because the self.repourl is always true, even if I send baseURL in
 buildbot config and assertion always occurs.

 I used a hack to make this work for us by adding:

 self.org_repourl = repourl

 and then testing later

 if self.org_repourl:
    assert not branch # we need baseURL= to use branchess
    self.args['repourl'] = self.repourl

 and so I managed to avoid the assertion.

 Best regards,
 Jani

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2527>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation