[Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual

[Buildbot trac]

#2521: Replace deprecated method unittest.TestCase.assert_() with newer
assertEqual/NotEqual
------------------------+------------------------
Reporter:  rutsky       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.7p1      |  Resolution:
Keywords:  tests        |
------------------------+------------------------

Comment (by rutsky):

 Only now I noticed, that Buildbot mostly uses Twisted's
 [https://twistedmatrix.com/documents/current/core/development/policy/test-
 standard.html unittest] module which already extends unittest in some way.

 So adding unittest2 as additional dependency is bad idea --- better to
 monkey-patch Twisted implementation if it doesn't have any required
 feature.

 Also I found that Tom Prince recently
 [https://twistedmatrix.com/trac/ticket/6350 reviewed] extending of
 Twisted's `TestCase`.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2521#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation