From trac at buildbot.net Mon Jul 1 07:14:42 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Jul 2013 07:14:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual Message-ID: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+----------------------- Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: tests ------------------------+----------------------- Some of tests use deprecated `unittest.TestCase.assert_()` method, like in [https://github.com/buildbot/buildbot/blob/master/master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py#L110 test_changes_mail_CVSMaildirSource.py]: {{{ self.assert_(chdict['revision'] == '2010-08-11 04:56:44') }}} When such test fails developer only know, that `chdict['revision']` is not `'2010-08-11 04:56:44'`, but he doesn't know which value it actually has --- that is often required for proper problem analysis. Use for modern `assertEqual()`, `assertNotEqual()` solves this problem. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 1 07:21:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Jul 2013 07:21:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual In-Reply-To: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> References: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> Message-ID: <053.5feb6a28e8eb288a43db3c4b088dd574@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+------------------------ Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: tests | ------------------------+------------------------ Comment (by rutsky): Also, it's tempting to use other modern methods, such as `assertIsNone()` and `assertIn()`, that was introduced in Python 2.7's unittest module. Maybe use separate unittest2 module (backport of unittest for older Python) instead provided with Python unittest? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 1 07:54:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Jul 2013 07:54:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual In-Reply-To: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> References: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> Message-ID: <053.34657fdd800030d308a216b32d84256b@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+------------------------ Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: tests | ------------------------+------------------------ Comment (by rutsky): I made pull request that replace `assert_()` in master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py: https://github.com/buildbot/buildbot/pull/781 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 1 09:02:21 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Jul 2013 09:02:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2522: test_changes_mail_CVSMaildirSource fails in some timezones Message-ID: <038.1caa23f1ad143c235ef01364850ad217@buildbot.net> #2522: test_changes_mail_CVSMaildirSource fails in some timezones ----------------------+----------------------- Reporter: rutsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Keywords: ----------------------+----------------------- Some of CVSMaildirSource tests fails in few timezones: {{{ $ TZ=Europe/Moscow trial buildbot.test.unit.test_changes_mail_CVSMaildirSource buildbot.test.unit.test_changes_mail_CVSMaildirSource TestCVSMaildirSource test_CVSMaildirSource_create_change_from_cvs1_11msg ... [FAIL] test_CVSMaildirSource_create_change_from_cvs1_12_with_no_path ... [OK] test_CVSMaildirSource_create_change_from_cvs1_12msg ... [FAIL] test_CVSMaildirSource_create_change_with_bad_cvsmode ... [OK] test_CVSMaildirSource_create_change_with_branch ... [OK] test_CVSMaildirSource_create_change_with_category ... [OK] test_CVSMaildirSource_create_change_with_no_comment ... [OK] test_CVSMaildirSource_create_change_with_no_files ... [OK] test_CVSMaildirSource_create_change_with_no_project ... [OK] test_CVSMaildirSource_create_change_with_no_repository ... [OK] test_CVSMaildirSource_create_change_with_property ... [OK] =============================================================================== [FAIL] Traceback (most recent call last): File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 138, in maybeDeferred result = f(*args, **kw) File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux- x86_64.egg/twisted/internet/_utilspy3.py", line 41, in runWithWarningsSuppressed reraise(exc_info[1], exc_info[2]) File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux- x86_64.egg/twisted/internet/_utilspy3.py", line 37, in runWithWarningsSuppressed result = f(*a, **kw) File "/home/bob/stuff/buildbot/git/master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py", line 87, in test_CVSMaildirSource_create_change_from_cvs1_11msg self.assertEqual(chdict['revision'], '2010-08-07 11:11:49') File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux- x86_64.egg/twisted/trial/_synctest.py", line 356, in assertEqual % (msg, pformat(first), pformat(second))) twisted.trial.unittest.FailTest: not equal: a = '2010-08-07 12:11:49' b = '2010-08-07 11:11:49' buildbot.test.unit.test_changes_mail_CVSMaildirSource.TestCVSMaildirSource.test_CVSMaildirSource_create_change_from_cvs1_11msg =============================================================================== [FAIL] Traceback (most recent call last): File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 138, in maybeDeferred result = f(*args, **kw) File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux- x86_64.egg/twisted/internet/_utilspy3.py", line 41, in runWithWarningsSuppressed reraise(exc_info[1], exc_info[2]) File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux- x86_64.egg/twisted/internet/_utilspy3.py", line 37, in runWithWarningsSuppressed result = f(*a, **kw) File "/home/bob/stuff/buildbot/git/master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py", line 110, in test_CVSMaildirSource_create_change_from_cvs1_12msg self.assertEqual(chdict['revision'], '2010-08-11 04:56:44') File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux- x86_64.egg/twisted/trial/_synctest.py", line 356, in assertEqual % (msg, pformat(first), pformat(second))) twisted.trial.unittest.FailTest: not equal: a = '2010-08-11 05:56:44' b = '2010-08-11 04:56:44' buildbot.test.unit.test_changes_mail_CVSMaildirSource.TestCVSMaildirSource.test_CVSMaildirSource_create_change_from_cvs1_12msg ------------------------------------------------------------------------------- Ran 11 tests in 0.017s FAILED (failures=2, successes=9) }}} My guess is this is somehow related to Daylight Saving Time. I tested timezones available in my system (Ubuntu 12.04) and here is the list of zones in which tests fails: {{{ $ for tz in `find /usr/share/zoneinfo/posix/ -exec bash -c 'T={}; echo ${T#/usr/share/zoneinfo/posix/}' \;`; do TZ=$tz trial buildbot.test.unit.test_changes_mail_CVSMaildirSource > /dev/null || echo $tz; done Atlantic/Stanley W-SU Europe/Volgograd Europe/Kaliningrad Europe/Moscow Europe/Samara Europe/Minsk America/Argentina/San_Luis Pacific/Fakaofo Pacific/Apia Asia/Krasnoyarsk Asia/Omsk Asia/Magadan Asia/Sakhalin Asia/Yekaterinburg Asia/Novosibirsk Asia/Anadyr Asia/Novokuznetsk Asia/Vladivostok Asia/Irkutsk Asia/Kamchatka Asia/Yakutsk }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 1 20:29:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Jul 2013 20:29:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2523: "subscribe_to" function for "DBConnector" class Message-ID: <040.0678a4504dc2bc30ec7e044732c21159@buildbot.net> #2523: "subscribe_to" function for "DBConnector" class ----------------------+----------------------- Reporter: hanguang | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- I noted that "subscribe_to" function for "DBConnector" class is not supported anymore after 0.8.3. Is there an alternative function or work- around available? Thanks. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 00:13:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 00:13:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2523: "subscribe_to" function for "DBConnector" class In-Reply-To: <040.0678a4504dc2bc30ec7e044732c21159@buildbot.net> References: <040.0678a4504dc2bc30ec7e044732c21159@buildbot.net> Message-ID: <055.a18d2ec0fe0631fb38d45bd0ea83b153@buildbot.net> #2523: "subscribe_to" function for "DBConnector" class ----------------------------+------------------------ Reporter: hanguang | Owner: Type: support-request | Status: closed Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: fixed Keywords: | ----------------------------+------------------------ Changes (by dustin): * status: new => closed * type: undecided => support-request * resolution: => fixed Comment: answered on-list: http://thread.gmane.org/gmane.comp.python.buildbot.devel/9471 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 00:52:17 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 00:52:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2516: Buildbot on Github have low resolution icon In-Reply-To: <038.3e9b955685b452d2a33eb54eac3c2b8e@buildbot.net> References: <038.3e9b955685b452d2a33eb54eac3c2b8e@buildbot.net> Message-ID: <053.ab839f801b84d1bd750b7b1f51954273@buildbot.net> #2516: Buildbot on Github have low resolution icon ------------------------+---------------------- Reporter: rutsky | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: ongoing Version: | Resolution: fixed Keywords: | ------------------------+---------------------- Changes (by dustin): * status: new => closed * type: undecided => enhancement * resolution: => fixed * milestone: undecided => ongoing Comment: fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 00:53:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 00:53:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2517: Automatically check docs.buildbot.net/buildbot.net for broken links and invalid HTML/CSS In-Reply-To: <038.8898b91ba492d31b4c77976ca6f6a0c0@buildbot.net> References: <038.8898b91ba492d31b4c77976ca6f6a0c0@buildbot.net> Message-ID: <053.0fb8918be7042f0b89d20b0e315d48a9@buildbot.net> #2517: Automatically check docs.buildbot.net/buildbot.net for broken links and invalid HTML/CSS --------------------+---------------------- Reporter: rutsky | Owner: Type: task | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: web | --------------------+---------------------- Changes (by dustin): * type: enhancement => task * milestone: undecided => ongoing Comment: Sounds like a good plan. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 01:37:04 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 01:37:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2518: Mercurial Doesn't Support Named Branches In-Reply-To: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> References: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> Message-ID: <053.52e627186f42e892893d6dd4fc8484f4@buildbot.net> #2518: Mercurial Doesn't Support Named Branches ---------------------+------------------------ Reporter: dbrady | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): My read of the manpage suggests that `--rev` is optional, and its presence makes no difference. That means that your patch is essentially a no-op. Does it really make a difference, and if so, can you point me to the hg docs that describe that difference? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jul 2 01:40:24 2013 From: noreply at github.com (GitHub) Date: Mon, 01 Jul 2013 18:40:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5a4f00: Backport docs highlighting check monkey-patch for ... Message-ID: <51d22f88eab88_27cda1bddc1862b5@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5a4f0069bb7fdc80a0b4dfe3bce5d17c7f0645de https://github.com/buildbot/buildbot/commit/5a4f0069bb7fdc80a0b4dfe3bce5d17c7f0645de Author: Vladimir Rutsky Date: 2013-06-28 (Fri, 28 Jun 2013) Changed paths: M master/docs/conf.py Log Message: ----------- Backport docs highlighting check monkey-patch for Sphinx starting from v0.6.6 Currently host that builds documentation uses Sphinx v1.0.7. This monkey-patched tested with Sphinx (few) versions starting from v1.0, because Buildbot's master/docs/bbdocs/ext.py depends on features introduced there (Sphinx Domains). Commit: c6e10b7913158abac313e581f1af25c0a1b06420 https://github.com/buildbot/buildbot/commit/c6e10b7913158abac313e581f1af25c0a1b06420 Author: Vladimir Rutsky Date: 2013-06-28 (Fri, 28 Jun 2013) Changed paths: M master/docs/manual/cfg-global.rst Log Message: ----------- Fix highligting issue with Sphinx 1.0 (and in 1.0.7) Old Sphinx versions not highlighted unparsable Python code (new one does). Commit: 74e4c8558c229ac2c3c15edb78178078fd662602 https://github.com/buildbot/buildbot/commit/74e4c8558c229ac2c3c15edb78178078fd662602 Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/docs/conf.py M master/docs/manual/cfg-global.rst Log Message: ----------- Merge branch 'backport_docs_highlighting_monkey_patch' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/991b5a9cbe7d...74e4c8558c22 From noreply at github.com Tue Jul 2 01:41:55 2013 From: noreply at github.com (GitHub) Date: Mon, 01 Jul 2013 18:41:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b430db: Fix typos: "defered", "accecpts", "atomicitiy" Message-ID: <51d22fe3e5ace_27a86b7de41539a0@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b430db8ad440f0dd4e624b3b4f33762daf326bcc https://github.com/buildbot/buildbot/commit/b430db8ad440f0dd4e624b3b4f33762daf326bcc Author: Vladimir Rutsky Date: 2013-06-28 (Fri, 28 Jun 2013) Changed paths: M master/buildbot/changes/hgpoller.py M master/buildbot/changes/mail.py M master/buildbot/db/changes.py M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- Fix typos: "defered", "accecpts", "atomicitiy" Commit: 5557d18ec57f44a940819a363c6dc55eaa1c5c34 https://github.com/buildbot/buildbot/commit/5557d18ec57f44a940819a363c6dc55eaa1c5c34 Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/changes/hgpoller.py M master/buildbot/changes/mail.py M master/buildbot/db/changes.py M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- Merge branch 'typos4' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/74e4c8558c22...5557d18ec57f From trac at buildbot.net Tue Jul 2 01:44:42 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 01:44:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2519: Git source step should update refs In-Reply-To: <039.d876796e0eff61861e659c8129e19d8a@buildbot.net> References: <039.d876796e0eff61861e659c8129e19d8a@buildbot.net> Message-ID: <054.8c0ac054ab58544b7bbab36bb077c2e2@buildbot.net> #2519: Git source step should update refs ----------------------+------------------------ Reporter: exarkun | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by dustin): The current implementation tries not to fetch branches that it has not been asked to build. I'm not sure what you mean by "branch refs in the clone" - is it failing to find the right source code? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 01:46:33 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 01:46:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2520: Wrong link on "Buildbot Tests" in wiki In-Reply-To: <038.f604728707bbe310f9ddd7f8cde61da6@buildbot.net> References: <038.f604728707bbe310f9ddd7f8cde61da6@buildbot.net> Message-ID: <053.ce08432fdd26c7fe1ca458f5f1828c7b@buildbot.net> #2520: Wrong link on "Buildbot Tests" in wiki ----------------------+------------------------ Reporter: rutsky | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: fixed Keywords: wiki | ----------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => fixed Comment: It's a wiki; you can edit it too! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 01:50:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 01:50:55 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.b3a4a1d5f88f900c64ae0e8401b7d93e@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Old description: > well today i tried everything to get Obfuscated to work but i couldn't > > my dilemma is that i have a shell script to upload the built project to > an ftp, i do this by placing the script in my system folder > > i wanted to generalize the process by making the script take the > user/pass in args to the calling of this script, but if i do that then > it's publicly visible to everyone who has access to my waterfall and logs > > what i want is the ability to hide the command being executed or part of > it. > > P.S. if obfuscated already does that, don't blame me i read the docs, > searched google and asked on irc, i was told i can;t use obfuscated in > buildmaster factories, and i couldn't find out where o use it or how!. New description: well today i tried everything to get Obfuscated to work but i couldn't my dilemma is that i have a shell script to upload the built project to an ftp, i do this by placing the script in my system folder i wanted to generalize the process by making the script take the user/pass in args to the calling of this script, but if i do that then it's publicly visible to everyone who has access to my waterfall and logs what i want is the ability to hide the command being executed or part of it. P.S. if obfuscated already does that, don't blame me i read the docs, searched google and asked on irc, i was told i can;t use obfuscated in buildmaster factories, and i couldn't find out where o use it or how!. -- Comment (by dustin): Does that solution work? The command is echoed in a few places on the slave, too, I believe. Perhaps not for the svn step, but for shell commands in general. I think that the web status is a bit late to hide that information - it means that we need to have a way of persisting the "hidden" state all the way from the slave, to the master, through the db and mq interfaces, and into the web UI. And in the 'nine' world, we would need to do the access control at the REST API layer. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jul 2 01:59:49 2013 From: noreply at github.com (GitHub) Date: Mon, 01 Jul 2013 18:59:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dd6124: check that configured cache sizes are >= 1 Message-ID: <51d2341512e17_761652fddc100238@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: dd61249984320d5ee8affd258d1a83d7177772f6 https://github.com/buildbot/buildbot/commit/dd61249984320d5ee8affd258d1a83d7177772f6 Author: Elmir Jagudin Date: 2013-06-30 (Sun, 30 Jun 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- check that configured cache sizes are >= 1 LRU cache implementation assumes that the cache is at least 1 element large. Catch invalid master configurations where cache sizes less then 1 are specified. Commit: f1278831b6eb656bd80cc6ed9fd802af885fcdd5 https://github.com/buildbot/buildbot/commit/f1278831b6eb656bd80cc6ed9fd802af885fcdd5 Author: Vladimir Rutsky Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py Log Message: ----------- Replace use of deprecated unittest.TestCase.assert_() with assertEqual/NotEqual etc methods If newer version of unittest will be used, self.assertEqual(..., None) should be replaced with self.assertNone(...), same with not equal to None checks. Commit: a305b707313854f23311f25168c3c7bea083381f https://github.com/buildbot/buildbot/commit/a305b707313854f23311f25168c3c7bea083381f Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py Log Message: ----------- Merge branch 'replace_assert_in_CVSMaildirSource_tests' of git://github.com/vrutsky/buildbot Commit: 0f2a819262f7a2c48f58ded7c1d094b6f9d23b9b https://github.com/buildbot/buildbot/commit/0f2a819262f7a2c48f58ded7c1d094b6f9d23b9b Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Merge branch 'check-cache-sizes' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/5557d18ec57f...0f2a819262f7 From trac at buildbot.net Tue Jul 2 01:59:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 01:59:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2518: Mercurial Doesn't Support Named Branches In-Reply-To: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> References: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> Message-ID: <053.d2e1d95935cc96f4e555d7647ce84aa3@buildbot.net> #2518: Mercurial Doesn't Support Named Branches ---------------------+------------------------ Reporter: dbrady | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dbrady): The issue is that the branch name is being passed to the --rev parameter. It would be fine if a valid revision followed the --rev parameter, which will be the case if self.revision is not null (which is checked right above). -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 02:20:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 02:20:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2518: Mercurial Doesn't Support Named Branches In-Reply-To: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> References: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> Message-ID: <053.79c13c77a8afc91bad3b2f2b4d58a288@buildbot.net> #2518: Mercurial Doesn't Support Named Branches ---------------------+------------------------ Reporter: dbrady | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dbrady): Actually, I just tried this again, and it seems you are correct. I think I was chasing a red herring. There's still a bug in there somewhere, as I am not getting the correct branch some of the time, but I'll close this bug, as I'm clearly wrong here. My apologies. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 02:21:34 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 02:21:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2518: Mercurial Doesn't Support Named Branches In-Reply-To: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> References: <038.17f6b40039abddb94c5f33bb2cacad88@buildbot.net> Message-ID: <053.711a7b61feea58fdd088f8d78b4c05a2@buildbot.net> #2518: Mercurial Doesn't Support Named Branches ---------------------+------------------------ Reporter: dbrady | Owner: Type: defect | Status: closed Priority: critical | Milestone: undecided Version: 0.8.7p1 | Resolution: invalid Keywords: | ---------------------+------------------------ Changes (by dbrady): * status: new => closed * resolution: => invalid -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 06:18:50 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 06:18:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2520: Wrong link on "Buildbot Tests" in wiki In-Reply-To: <038.f604728707bbe310f9ddd7f8cde61da6@buildbot.net> References: <038.f604728707bbe310f9ddd7f8cde61da6@buildbot.net> Message-ID: <053.90405ce879cc7809802161e6261b22ea@buildbot.net> #2520: Wrong link on "Buildbot Tests" in wiki ----------------------+------------------------ Reporter: rutsky | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: fixed Keywords: wiki | ----------------------+------------------------ Comment (by rutsky): Oh, really! I searched edit button in top menu and didn't find it because it's at the end of the page. :) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 06:54:59 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 06:54:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.0e7da75a5e1399ac33548277fb61bb61@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 08:52:41 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 08:52:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.9bfb23c562c231d3ed877b34e1053907@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by rutsky): Replying to [comment:9 dustin]: > Does that solution work? The command is echoed in a few places on the slave, too, I believe. Perhaps not for the svn step, but for shell commands in general. I think it should work. On the slave side (real, fake) tuples are handled in `Obfuscated` class, so if arguments were obfuscated by it before (like in slave-side svn step), it will be obfuscated now too. I didn't found other places where command arguments leaked, except into Twisted logs, like `log.msg(...)`. > I think that the web status is a bit late to hide that information - it means that we need to have a way of persisting the "hidden" state all the way from the slave, to the master, through the db and mq interfaces, and into the web UI. And in the 'nine' world, we would need to do the access control at the REST API layer. Currently all commands on slave started through `buildbot.process.buildstep.RemoteCommand` (or subclasses of it). I thought that since slave outputs exactly same command arguments as passed through `RemoteCommand` and since `RemoteCommand` handles all output, it is possible to write into output logs command arguments directly from `RemoteCommand`, and handle obfuscation on master side in `RemoteCommand`. I had ideas about separating output from buildslave described in [#comment8], but they are raw for now, and such implementation only for command arguments obfuscating is overkill. So if approach implemented in my branch works, should I finish it (write tests, documentation)? Or you have better suggestions about how obfuscating should be done? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 13:15:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 13:15:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2519: Git source step should update refs In-Reply-To: <039.d876796e0eff61861e659c8129e19d8a@buildbot.net> References: <039.d876796e0eff61861e659c8129e19d8a@buildbot.net> Message-ID: <054.6daa64a7e8046e74717d9891d4b56286@buildbot.net> #2519: Git source step should update refs ----------------------+------------------------ Reporter: exarkun | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by exarkun): > The current implementation tries not to fetch branches that it has not been asked to build. A mode where it just fetched everything would be nice, then. > I'm not sure what you mean by "branch refs in the clone" - is it failing to find the right source code? Yes - for any branch which is not the branch being built. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jul 2 13:28:14 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Jul 2013 06:28:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b0c72d: Fix typos: "identifing", "provices", "Reponds" Message-ID: <51d2d56e8d9ed_27cda1bddc2444f7@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: b0c72d00dce2829de44b324191e8f0e7c1284611 https://github.com/buildbot/buildbot/commit/b0c72d00dce2829de44b324191e8f0e7c1284611 Author: Vladimir Rutsky Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/buildbot/process/properties.py M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/change_hook.py M master/buildbot/status/web/hooks/github.py M master/contrib/bitbucket_buildbot.py M master/contrib/github_buildbot.py Log Message: ----------- Fix typos: "identifing", "provices", "Reponds" Commit: bb5af74cf3dbe554c7ef5a5dcfb8c39075059c57 https://github.com/buildbot/buildbot/commit/bb5af74cf3dbe554c7ef5a5dcfb8c39075059c57 Author: Vladimir Rutsky Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/docs/conf.py Log Message: ----------- Add monkey patch that fails docs build if unhightlighted code block found Commit: e25405472f1fcb88aa0cb4a4b1d88ee663d0cafa https://github.com/buildbot/buildbot/commit/e25405472f1fcb88aa0cb4a4b1d88ee663d0cafa Author: Vladimir Rutsky Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/docs/developer/cls-buildsteps.rst M master/docs/developer/style.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-global.rst M master/docs/manual/cfg-properties.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/customization.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst Log Message: ----------- Fix syntax errors in Python examples in docs Only syntax fixed, without checking is examples are semantically correct. Commit: 22f11d552263a10dafe0ee12edcebb16b7597df3 https://github.com/buildbot/buildbot/commit/22f11d552263a10dafe0ee12edcebb16b7597df3 Author: adieu Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: A master/buildbot/status/web/hooks/gitlab.py Log Message: ----------- Add gitlab webhook based on existing github webhook. Commit: 35b6fcbf3e246af6673350380a9fde5478f88890 https://github.com/buildbot/buildbot/commit/35b6fcbf3e246af6673350380a9fde5478f88890 Author: Dustin J. Mitchell Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/buildbot/process/properties.py M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/change_hook.py M master/buildbot/status/web/hooks/github.py M master/contrib/bitbucket_buildbot.py M master/contrib/github_buildbot.py Log Message: ----------- Merge branch 'typos3' of git://github.com/vrutsky/buildbot Commit: b358f2098ee5971f4992d755765a572d8f78169c https://github.com/buildbot/buildbot/commit/b358f2098ee5971f4992d755765a572d8f78169c Author: Ross Guarino Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/setup.py Log Message: ----------- Added the db.types package to setup.py Fixed some import errors because the setup was not set up right. Commit: e546e094b096de1b9e51e9222904e5fdc7aa3570 https://github.com/buildbot/buildbot/commit/e546e094b096de1b9e51e9222904e5fdc7aa3570 Author: Ross Guarino Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/buildbot/status/web/authz.py Log Message: ----------- Added a default for view in the web.authz module. I added a default to true for the view in the master.status.web.authz module. If there is no view specified in the master config then the master will behave the same as it did before view was added. If view is explicitly set in the master.cfg that argument will be used. Commit: 6a112151f54f8330b5dca243515017e12f552922 https://github.com/buildbot/buildbot/commit/6a112151f54f8330b5dca243515017e12f552922 Author: Vladimir Rutsky Date: 2013-06-24 (Mon, 24 Jun 2013) Changed paths: M master/docs/conf.py Log Message: ----------- Output warning about not highlighted block through Sphinx' warn() Sphinx' warn() function stores information about position of processing code, so now error message contains exact position of error. Commit: 92e835777430e02ad2041ffe17c6db6e75e0b005 https://github.com/buildbot/buildbot/commit/92e835777430e02ad2041ffe17c6db6e75e0b005 Author: Vladimir Rutsky Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/tour.rst Log Message: ----------- Fix highlighting for P4 stuff, config files, logs, IRC commands, exceptions Hightlighted as "none". Commit: f4156538bfdb3707fbca0cf5c4fdfd2e5be30cc0 https://github.com/buildbot/buildbot/commit/f4156538bfdb3707fbca0cf5c4fdfd2e5be30cc0 Author: Vladimir Rutsky Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/0.8.6.rst M master/docs/relnotes/0.8.7.rst M master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst Log Message: ----------- Fix highlighting for command line examples Highlight as "bash". Commit: 84dc337a81d18012e690723d12bd961ccf900e63 https://github.com/buildbot/buildbot/commit/84dc337a81d18012e690723d12bd961ccf900e63 Author: Vladimir Rutsky Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/docs/manual/cfg-intro.rst M master/docs/manual/cfg-properties.rst Log Message: ----------- Fix highlighting of notes Note that there is one new TODO about missing code example. Commit: 4146f067428ef2963c89043bd43499e4dfa77f7b https://github.com/buildbot/buildbot/commit/4146f067428ef2963c89043bd43499e4dfa77f7b Author: Vladimir Rutsky Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Fix IRC logs highlighting Highlight as "irc". Commit: e8ef280b5ab6601eb172562fbbe1df03891f535b https://github.com/buildbot/buildbot/commit/e8ef280b5ab6601eb172562fbbe1df03891f535b Author: Vladimir Rutsky Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/docs/conf.py Log Message: ----------- Add Sphinx version checking for highlighting check monkey-patch If Sphinx is older than 1.1 warning message will arise and monkey-patch will not be applied. Monkey-patch should work with Sphinx versions starting from 1.1, but I managed to test it starting from version 1.1.3 due to this bug: https://bitbucket.org/birkenfeld/sphinx/issue/853/attributeerror-reporter-instance-has-no Commit: 90d2172c749249e51d4e6830d71810169cf6c12f https://github.com/buildbot/buildbot/commit/90d2172c749249e51d4e6830d71810169cf6c12f Author: Olly Betts Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/buildbot/status/web/files/robots.txt Log Message: ----------- Remove duplicate robots.txt entry Commit: 282164395fe04abf94a27f118c01e6c82c9b71b8 https://github.com/buildbot/buildbot/commit/282164395fe04abf94a27f118c01e6c82c9b71b8 Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/buildbot/status/web/files/robots.txt Log Message: ----------- Merge branch 'patch-1' of git://github.com/ojwb/buildbot Commit: 0b89660e7af0211034741a4e6b3f9f3942cbee52 https://github.com/buildbot/buildbot/commit/0b89660e7af0211034741a4e6b3f9f3942cbee52 Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/docs/conf.py M master/docs/developer/cls-buildsteps.rst M master/docs/developer/style.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-global.rst M master/docs/manual/cfg-intro.rst M master/docs/manual/cfg-properties.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/customization.rst M master/docs/relnotes/0.8.6.rst M master/docs/relnotes/0.8.7.rst M master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst Log Message: ----------- Merge branch 'doc_highlighting_2511' of git://github.com/vrutsky/buildbot Commit: a1abe9bbcddfae3fe23d7fb59e57cf807e6a82f3 https://github.com/buildbot/buildbot/commit/a1abe9bbcddfae3fe23d7fb59e57cf807e6a82f3 Author: adieu Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/buildbot/status/web/hooks/gitlab.py M master/buildbot/test/fake/web.py A master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst Log Message: ----------- Add tests and docs for gitlab hook. Commit: 21323555305b309c4b7704124e0b349975f3defc https://github.com/buildbot/buildbot/commit/21323555305b309c4b7704124e0b349975f3defc Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/setup.py Log Message: ----------- Merge branch 'hotfix-import' of git://github.com/rguarino/buildbot Commit: 69819714316cb55d3ee38542c76c1f26babb4b4e https://github.com/buildbot/buildbot/commit/69819714316cb55d3ee38542c76c1f26babb4b4e Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/buildbot/status/web/authz.py Log Message: ----------- Merge branch 'hotfix-authz' of git://github.com/rguarino/buildbot Commit: 2260f67d2f8d0045984e4306ba44fe7a9cd63cee https://github.com/buildbot/buildbot/commit/2260f67d2f8d0045984e4306ba44fe7a9cd63cee Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: A master/buildbot/status/web/hooks/gitlab.py M master/buildbot/test/fake/web.py A master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'gitlab' of git://github.com/adieu/buildbot Minor fixes to docs for highlighting Commit: ceb29701e7fa9bbac2d2e46c155c30b63c918c22 https://github.com/buildbot/buildbot/commit/ceb29701e7fa9bbac2d2e46c155c30b63c918c22 Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/buildbot/test/unit/test_status_web_authz_Authz.py Log Message: ----------- fix tests for authz view default Commit: e8a004b14d62972d31ba2e77c388b808bd816fcb https://github.com/buildbot/buildbot/commit/e8a004b14d62972d31ba2e77c388b808bd816fcb Author: Dustin J. Mitchell Date: 2013-06-25 (Tue, 25 Jun 2013) Changed paths: M master/buildbot/test/unit/test_scripts_start.py Log Message: ----------- wait for the started buildbot to stop before finishing the test case Commit: 91031f7f6363fc0921b61796301d64b0fd3cfc52 https://github.com/buildbot/buildbot/commit/91031f7f6363fc0921b61796301d64b0fd3cfc52 Author: Srinu P Date: 2013-06-26 (Wed, 26 Jun 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- New function svnUriCanonical to canonicalize SVN URIs before matching it with extracted URI from SVN repository. This commit fixes bug 2467 Commit: 991b5a9cbe7dcc5169a2d33c0d67cb26cf8c371a https://github.com/buildbot/buildbot/commit/991b5a9cbe7dcc5169a2d33c0d67cb26cf8c371a Author: Dustin J. Mitchell Date: 2013-06-26 (Wed, 26 Jun 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- Merge branch 'bug2467-squash' of git://github.com/srinupiits/buildbot Commit: 5a4f0069bb7fdc80a0b4dfe3bce5d17c7f0645de https://github.com/buildbot/buildbot/commit/5a4f0069bb7fdc80a0b4dfe3bce5d17c7f0645de Author: Vladimir Rutsky Date: 2013-06-28 (Fri, 28 Jun 2013) Changed paths: M master/docs/conf.py Log Message: ----------- Backport docs highlighting check monkey-patch for Sphinx starting from v0.6.6 Currently host that builds documentation uses Sphinx v1.0.7. This monkey-patched tested with Sphinx (few) versions starting from v1.0, because Buildbot's master/docs/bbdocs/ext.py depends on features introduced there (Sphinx Domains). Commit: c6e10b7913158abac313e581f1af25c0a1b06420 https://github.com/buildbot/buildbot/commit/c6e10b7913158abac313e581f1af25c0a1b06420 Author: Vladimir Rutsky Date: 2013-06-28 (Fri, 28 Jun 2013) Changed paths: M master/docs/manual/cfg-global.rst Log Message: ----------- Fix highligting issue with Sphinx 1.0 (and in 1.0.7) Old Sphinx versions not highlighted unparsable Python code (new one does). Commit: b430db8ad440f0dd4e624b3b4f33762daf326bcc https://github.com/buildbot/buildbot/commit/b430db8ad440f0dd4e624b3b4f33762daf326bcc Author: Vladimir Rutsky Date: 2013-06-28 (Fri, 28 Jun 2013) Changed paths: M master/buildbot/changes/hgpoller.py M master/buildbot/changes/mail.py M master/buildbot/db/changes.py M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- Fix typos: "defered", "accecpts", "atomicitiy" Commit: dd61249984320d5ee8affd258d1a83d7177772f6 https://github.com/buildbot/buildbot/commit/dd61249984320d5ee8affd258d1a83d7177772f6 Author: Elmir Jagudin Date: 2013-06-30 (Sun, 30 Jun 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- check that configured cache sizes are >= 1 LRU cache implementation assumes that the cache is at least 1 element large. Catch invalid master configurations where cache sizes less then 1 are specified. Commit: f1278831b6eb656bd80cc6ed9fd802af885fcdd5 https://github.com/buildbot/buildbot/commit/f1278831b6eb656bd80cc6ed9fd802af885fcdd5 Author: Vladimir Rutsky Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py Log Message: ----------- Replace use of deprecated unittest.TestCase.assert_() with assertEqual/NotEqual etc methods If newer version of unittest will be used, self.assertEqual(..., None) should be replaced with self.assertNone(...), same with not equal to None checks. Commit: 74e4c8558c229ac2c3c15edb78178078fd662602 https://github.com/buildbot/buildbot/commit/74e4c8558c229ac2c3c15edb78178078fd662602 Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/docs/conf.py M master/docs/manual/cfg-global.rst Log Message: ----------- Merge branch 'backport_docs_highlighting_monkey_patch' of git://github.com/vrutsky/buildbot Commit: 5557d18ec57f44a940819a363c6dc55eaa1c5c34 https://github.com/buildbot/buildbot/commit/5557d18ec57f44a940819a363c6dc55eaa1c5c34 Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/changes/hgpoller.py M master/buildbot/changes/mail.py M master/buildbot/db/changes.py M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- Merge branch 'typos4' of git://github.com/vrutsky/buildbot Commit: a305b707313854f23311f25168c3c7bea083381f https://github.com/buildbot/buildbot/commit/a305b707313854f23311f25168c3c7bea083381f Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py Log Message: ----------- Merge branch 'replace_assert_in_CVSMaildirSource_tests' of git://github.com/vrutsky/buildbot Commit: 0f2a819262f7a2c48f58ded7c1d094b6f9d23b9b https://github.com/buildbot/buildbot/commit/0f2a819262f7a2c48f58ded7c1d094b6f9d23b9b Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Merge branch 'check-cache-sizes' of git://github.com/elmirjagudin/buildbot Commit: 24105ecbe0043431672f5c08f2da252bbe69081f https://github.com/buildbot/buildbot/commit/24105ecbe0043431672f5c08f2da252bbe69081f Author: Dustin J. Mitchell Date: 2013-07-01 (Mon, 01 Jul 2013) Changed paths: M master/buildbot/changes/hgpoller.py M master/buildbot/changes/mail.py M master/buildbot/config.py M master/buildbot/db/changes.py M master/buildbot/process/properties.py M master/buildbot/schedulers/forcesched.py M master/buildbot/status/web/authz.py M master/buildbot/status/web/change_hook.py M master/buildbot/status/web/files/robots.txt M master/buildbot/status/web/hooks/github.py A master/buildbot/status/web/hooks/gitlab.py M master/buildbot/steps/source/svn.py M master/buildbot/test/fake/web.py M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_status_web_authz_Authz.py A master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py M master/buildbot/test/unit/test_steps_source_svn.py M master/contrib/bitbucket_buildbot.py M master/contrib/github_buildbot.py M master/docs/conf.py M master/docs/developer/cls-buildsteps.rst M master/docs/developer/style.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-global.rst M master/docs/manual/cfg-intro.rst M master/docs/manual/cfg-properties.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/customization.rst M master/docs/relnotes/0.8.6.rst M master/docs/relnotes/0.8.7.rst M master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst M master/setup.py Log Message: ----------- Merge branch 'master' into nine Conflicts: master/buildbot/process/builder.py Commit: 3411c41d68b47f5892961ad96349a28ebe06a2ba https://github.com/buildbot/buildbot/commit/3411c41d68b47f5892961ad96349a28ebe06a2ba Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/docs/developer/cls-resultspec.rst M master/docs/developer/www.rst M master/docs/manual/cfg-global.rst Log Message: ----------- fix up docs and highlighting Compare: https://github.com/buildbot/buildbot/compare/8fb0efe477ab...3411c41d68b4 From trac at buildbot.net Tue Jul 2 14:23:54 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 14:23:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2524: Property('buildnumber') returns None on first build Message-ID: <040.972272ba14612ef040663db4400cbdf1@buildbot.net> #2524: Property('buildnumber') returns None on first build ---------------------+----------------------- Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ---------------------+----------------------- When using Property() in ShellCommand it will always fail on the first build - at least when reading the 'buildnumber' property. I created a default master/slave and added this one line to the default factory. factory.addStep(ShellCommand(command=["echo", Property('buildnumber')], description=Interpolate('build #%(prop:buildnumber)s'))) And when running the first build you will see this in the build #0 stdio: argv: ['echo', 'None'] But on build #1 (second build) you will see the correct value: argv: ['echo', '1'] -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jul 2 19:47:13 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Jul 2013 12:47:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fbc243: Fix typos, add missing dot Message-ID: <51d32e416919a_797c4f5de46001f@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fbc243ce12b58b4e4c519b1ce2bd8f13cddef8f5 https://github.com/buildbot/buildbot/commit/fbc243ce12b58b4e4c519b1ce2bd8f13cddef8f5 Author: Vladimir Rutsky Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py M master/buildbot/status/web/authz.py M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py M master/docs/conf.py M master/docs/developer/tests.rst M master/docs/tutorial/firstrun.rst M slave/buildslave/bot.py M slave/buildslave/runprocess.py Log Message: ----------- Fix typos, add missing dot Typos: "eveything", "formatated", "afer", "loking", "buildbot.test.regrssions", "eror", "concatentate". Commit: 99945d34187e0cee9598b8576ee5855affe06f73 https://github.com/buildbot/buildbot/commit/99945d34187e0cee9598b8576ee5855affe06f73 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py M master/buildbot/status/web/authz.py M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py M master/docs/conf.py M master/docs/developer/tests.rst M master/docs/tutorial/firstrun.rst M slave/buildslave/bot.py M slave/buildslave/runprocess.py Log Message: ----------- Merge pull request #783 from vrutsky/typos Fix typos Compare: https://github.com/buildbot/buildbot/compare/0f2a819262f7...99945d34187e From trac at buildbot.net Tue Jul 2 20:46:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 20:46:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual In-Reply-To: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> References: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> Message-ID: <053.b831b96ca0b3baf3c6328483bea3a67b@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+------------------------ Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: tests | ------------------------+------------------------ Comment (by rutsky): Only now I noticed, that Buildbot mostly uses Twisted's [https://twistedmatrix.com/documents/current/core/development/policy/test- standard.html unittest] module which already extends unittest in some way. So adding unittest2 as additional dependency is bad idea --- better to monkey-patch Twisted implementation if it doesn't have any required feature. Also I found that Tom Prince recently [https://twistedmatrix.com/trac/ticket/6350 reviewed] extending of Twisted's `TestCase`. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 21:14:31 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 21:14:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2324: Please add the ability to automatically delete unused build directories In-Reply-To: <036.2be0902f81c813e1ff32ffdce42f2e8d@buildbot.net> References: <036.2be0902f81c813e1ff32ffdce42f2e8d@buildbot.net> Message-ID: <051.11198b216578eb2e27486600ef1f08d1@buildbot.net> #2324: Please add the ability to automatically delete unused build directories ------------------------+-------------------- Reporter: smat | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 2 22:18:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 02 Jul 2013 22:18:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2525: Uninterruptible git step Message-ID: <039.6fc3d6efa946a969c853f18cc7a793df@buildbot.net> #2525: Uninterruptible git step --------------------+----------------------- Reporter: brendan | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: git --------------------+----------------------- The rust buildbot (http://buildbot.rust-lang.org) ran into a situation this weekend where a few builds got stuck in an uninterruptible infinite loop in the git checkout step. The git step was configured mode='incremental', retryFetch=True, clobberOnFailure=True. I believe that while this was going on, the git revision that the step was supposed to check out was removed from the source repository. Here's an example step, including several attempts to interrupt it: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/201 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jul 3 00:11:12 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Jul 2013 17:11:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 59cf5a: fix gitlab tests to not rely on json error message... Message-ID: <51d36c20c28ba_5307c29de086452@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 59cf5ad1ec36d2bb42e2f8aad78312f1b857a4b5 https://github.com/buildbot/buildbot/commit/59cf5ad1ec36d2bb42e2f8aad78312f1b857a4b5 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/status/web/hooks/gitlab.py M master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py Log Message: ----------- fix gitlab tests to not rely on json error messages Commit: 4f1c7b2add75145b8f10aac9207b5a858da9747a https://github.com/buildbot/buildbot/commit/4f1c7b2add75145b8f10aac9207b5a858da9747a Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: R master/buildbot/test/unit/test_status_web_change_hook.py R master/buildbot/test/unit/test_status_web_change_hooks_bitbucket.py R master/buildbot/test/unit/test_status_web_change_hooks_github.py R master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py R master/buildbot/test/unit/test_status_web_change_hooks_googlecode.py R master/buildbot/test/unit/test_status_web_change_hooks_poller.py A master/buildbot/test/unit/test_status_web_hook.py A master/buildbot/test/unit/test_status_web_hooks_bitbucket.py A master/buildbot/test/unit/test_status_web_hooks_github.py A master/buildbot/test/unit/test_status_web_hooks_gitlab.py A master/buildbot/test/unit/test_status_web_hooks_googlecode.py A master/buildbot/test/unit/test_status_web_hooks_poller.py Log Message: ----------- rename tests to correspond to the tested modules Compare: https://github.com/buildbot/buildbot/compare/99945d34187e...4f1c7b2add75 From noreply at github.com Wed Jul 3 00:12:33 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Jul 2013 17:12:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fbc243: Fix typos, add missing dot Message-ID: <51d36c71d3570_5645d81ddc16565f@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: fbc243ce12b58b4e4c519b1ce2bd8f13cddef8f5 https://github.com/buildbot/buildbot/commit/fbc243ce12b58b4e4c519b1ce2bd8f13cddef8f5 Author: Vladimir Rutsky Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py M master/buildbot/status/web/authz.py M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py M master/docs/conf.py M master/docs/developer/tests.rst M master/docs/tutorial/firstrun.rst M slave/buildslave/bot.py M slave/buildslave/runprocess.py Log Message: ----------- Fix typos, add missing dot Typos: "eveything", "formatated", "afer", "loking", "buildbot.test.regrssions", "eror", "concatentate". Commit: 99945d34187e0cee9598b8576ee5855affe06f73 https://github.com/buildbot/buildbot/commit/99945d34187e0cee9598b8576ee5855affe06f73 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py M master/buildbot/status/web/authz.py M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py M master/docs/conf.py M master/docs/developer/tests.rst M master/docs/tutorial/firstrun.rst M slave/buildslave/bot.py M slave/buildslave/runprocess.py Log Message: ----------- Merge pull request #783 from vrutsky/typos Fix typos Commit: 59cf5ad1ec36d2bb42e2f8aad78312f1b857a4b5 https://github.com/buildbot/buildbot/commit/59cf5ad1ec36d2bb42e2f8aad78312f1b857a4b5 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/status/web/hooks/gitlab.py M master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py Log Message: ----------- fix gitlab tests to not rely on json error messages Commit: 4f1c7b2add75145b8f10aac9207b5a858da9747a https://github.com/buildbot/buildbot/commit/4f1c7b2add75145b8f10aac9207b5a858da9747a Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: R master/buildbot/test/unit/test_status_web_change_hook.py R master/buildbot/test/unit/test_status_web_change_hooks_bitbucket.py R master/buildbot/test/unit/test_status_web_change_hooks_github.py R master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py R master/buildbot/test/unit/test_status_web_change_hooks_googlecode.py R master/buildbot/test/unit/test_status_web_change_hooks_poller.py A master/buildbot/test/unit/test_status_web_hook.py A master/buildbot/test/unit/test_status_web_hooks_bitbucket.py A master/buildbot/test/unit/test_status_web_hooks_github.py A master/buildbot/test/unit/test_status_web_hooks_gitlab.py A master/buildbot/test/unit/test_status_web_hooks_googlecode.py A master/buildbot/test/unit/test_status_web_hooks_poller.py Log Message: ----------- rename tests to correspond to the tested modules Commit: 863bd39d3d20ef69a0194a831fb427b13a560968 https://github.com/buildbot/buildbot/commit/863bd39d3d20ef69a0194a831fb427b13a560968 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py M master/buildbot/status/web/authz.py M master/buildbot/status/web/hooks/gitlab.py M master/buildbot/test/unit/test_changes_mail_CVSMaildirSource.py R master/buildbot/test/unit/test_status_web_change_hook.py R master/buildbot/test/unit/test_status_web_change_hooks_bitbucket.py R master/buildbot/test/unit/test_status_web_change_hooks_github.py R master/buildbot/test/unit/test_status_web_change_hooks_gitlab.py R master/buildbot/test/unit/test_status_web_change_hooks_googlecode.py R master/buildbot/test/unit/test_status_web_change_hooks_poller.py A master/buildbot/test/unit/test_status_web_hook.py A master/buildbot/test/unit/test_status_web_hooks_bitbucket.py A master/buildbot/test/unit/test_status_web_hooks_github.py A master/buildbot/test/unit/test_status_web_hooks_gitlab.py A master/buildbot/test/unit/test_status_web_hooks_googlecode.py A master/buildbot/test/unit/test_status_web_hooks_poller.py M master/docs/conf.py M master/docs/developer/tests.rst M master/docs/tutorial/firstrun.rst M slave/buildslave/bot.py M slave/buildslave/runprocess.py Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/3411c41d68b4...863bd39d3d20 From trac at buildbot.net Wed Jul 3 00:13:01 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 03 Jul 2013 00:13:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail Message-ID: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+----------------------- Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ---------------------+----------------------- I have a set of build factories containing steps with descriptions which access properties that fail with the following exception: {{{ Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 576, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 828, in _cbDeferred self.callback(self.resultList) File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 381, in callback self._startRunCallbacks(result) File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 489, in _startRunCallbacks self._runCallbacks() --- --- File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 576, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/waterfall.py", line 426, in call_content brcounts, request, ctx) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/waterfall.py", line 490, in content_with_db_data sourceEvents)) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/waterfall.py", line 743, in phase2 b = IBox(block[i]).getBox(request) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/waterfall.py", line 173, in getBox text = text[:] exceptions.AttributeError: Interpolate instance has no attribute '__getitem__' }}} Some observations: 1. Both Property() and Interpolate() fail. 2. These exceptions seem happen until the last step has started - they synchronize access to avoid running more than one test on a slave. 3. The exception happens whether it's a predefined property (i.e. buildnumber), or my custom property (test_build_num). Steps to reproduce: 1. Expand the attached archive (bbtest.tgz) 2. Run "make start" to create and start the master/slaves. 3. Force a build of "Android Builder". The first build will fail as expected (see bug #2524) 4. Force a second build of "Android Builder". 5. Wait 15 seconds. (the build takes 10, and each tester takes 6). 6. Reload the waterfall page. If you continue to reload the page until the last tester has started then the exception is not thrown and the property value is displayed correctly. '''Note 1''': You can reset to a clean state easily by running "make clean". '''Note 2''': Switching to master.cfg.noprops will allow the tests to work correctly, but without correct titles. '''Note 3''': This config is slightly Linux centric (note /tmp dir usage). -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jul 3 03:39:42 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Jul 2013 20:39:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ae1f42: fix postgres tests Message-ID: <51d39cfe491a0_3841b83ddc12421d@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: ae1f429ca1d354dd9d2113b1d3d5ed42cae80120 https://github.com/buildbot/buildbot/commit/ae1f429ca1d354dd9d2113b1d3d5ed42cae80120 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/buildbot/test/regressions/test_bad_change_properties_rows.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_db_changes.py M master/buildbot/test/unit/test_db_changesources.py M master/buildbot/test/unit/test_db_schedulers.py M master/buildbot/test/unit/test_db_users.py Log Message: ----------- fix postgres tests From noreply at github.com Wed Jul 3 03:54:38 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Jul 2013 20:54:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d326f4: remove support for sqlalchemy-migrage-0.6.1 Message-ID: <51d3a07e73118_7a6f9f1dd4697bd@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: d326f4f17fe681086a79a38b55d3a31016f1c1c1 https://github.com/buildbot/buildbot/commit/d326f4f17fe681086a79a38b55d3a31016f1c1c1 Author: Dustin J. Mitchell Date: 2013-07-02 (Tue, 02 Jul 2013) Changed paths: M master/docs/manual/installation.rst M master/docs/relnotes/index.rst M master/setup.py Log Message: ----------- remove support for sqlalchemy-migrage-0.6.1 From trac at buildbot.net Wed Jul 3 12:37:41 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 03 Jul 2013 12:37:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2527: Bug in oldsource.py class _ComputeRepositoryURL Message-ID: <036.efedf592eb1823440f8abd4426f264ae@buildbot.net> #2527: Bug in oldsource.py class _ComputeRepositoryURL -------------------+----------------------- Reporter: Jani | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Keywords: -------------------+----------------------- Hello, OS: Ubuntu 12.04.2 LTS Buildbot: 0.8.5-2 Python: 2.7.3 In steps/source/oldsource.py there is class _ComputeRepositoryURL(object), but it seems not to use the 'object' and returns some string always. This causes a problem in class Bzr(Source) later in the same file on line 1105 where it has: if self.repourl: assert not branch # we need baseURL= to use branches self.args['repourl'] = self.repourl because the self.repourl is always true, even if I send baseURL in buildbot config and assertion always occurs. I used a hack to make this work for us by adding: self.org_repourl = repourl and then testing later if self.org_repourl: assert not branch # we need baseURL= to use branchess self.args['repourl'] = self.repourl and so I managed to avoid the assertion. Best regards, Jani -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 01:48:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 01:48:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2522: test_changes_mail_CVSMaildirSource fails in some timezones In-Reply-To: <038.1caa23f1ad143c235ef01364850ad217@buildbot.net> References: <038.1caa23f1ad143c235ef01364850ad217@buildbot.net> Message-ID: <053.e131742c35e8265c4319c9dd7fe99882@buildbot.net> #2522: test_changes_mail_CVSMaildirSource fails in some timezones ----------------------+------------------------ Reporter: rutsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): Well, that's a weird set of timezones to have trouble. Also, I can't reproduce this, at least not with `Europe/Moscow` or `America/Argentina/San_Luis`. All of the calculations on that date should be done in UTC. Does that time somehow overlap with DST? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 01:54:48 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 01:54:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.ddaaf5693d0cebabd0e753bce55f5e64@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by dustin): I like your approach. However, I don't want to lose the list-flattening behavior altogether - logs of complex configs rely on that. I also don't want to dedicate tuples to always mean obfuscation. Rather, let's use tuples as an "escape", so for example `('obfuscate', 'real-secret', '****')` means to run `real-secret` but display `****`. Then, later, we can add some other escapes if necessary. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 01:59:18 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 01:59:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2519: Git source step should support full (all-refs) fetches (was: Git source step should update refs) In-Reply-To: <039.d876796e0eff61861e659c8129e19d8a@buildbot.net> References: <039.d876796e0eff61861e659c8129e19d8a@buildbot.net> Message-ID: <054.39d211a246482004755f21d009b013a5@buildbot.net> #2519: Git source step should support full (all-refs) fetches ------------------------+-------------------- Reporter: exarkun | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: git | ------------------------+-------------------- Changes (by dustin): * type: undecided => enhancement * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 02:00:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 02:00:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2524: Property('buildnumber') returns None on first build In-Reply-To: <040.972272ba14612ef040663db4400cbdf1@buildbot.net> References: <040.972272ba14612ef040663db4400cbdf1@buildbot.net> Message-ID: <055.4abe305121fc18198adec9c4f8a070d4@buildbot.net> #2524: Property('buildnumber') returns None on first build ---------------------+-------------------- Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.9.0 Comment: We'll be assigning build numbers much earlier in the process in nine. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 02:03:04 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 02:03:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual In-Reply-To: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> References: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> Message-ID: <053.bf0c543cede5e213f26525af0ac03fc2@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+------------------------ Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: tests | ------------------------+------------------------ Comment (by dustin): That pull request is merged. The lack of "modern" assertions is annoying, but not fatal. Is there anything else to do in this bug? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 08:52:01 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 08:52:01 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.f950f258a80fc6e0da02d78927511c00@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by rutsky): I think even better to use special class for escaping, like {{{ command=["echo", Obfuscate("real", "fake")] }}} (as it done on slave side with slave-svn step). It's explicitly typed, no chances that someone will make a typo in `'obfuscate'` string or accidentally pass argument in tuple that has "escape" semantics. Never done passing custom classes through PerspectiveBroker protocol, but I think this shouldn't be hard. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 09:12:09 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 09:12:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual In-Reply-To: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> References: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> Message-ID: <053.8441f41631b394ff4f69c5e770202452@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+------------------------ Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: tests | ------------------------+------------------------ Comment (by rutsky): I would like to replace other use of `assert_()` in Buildbot --- my pull request fixed this issue only in test_changes_mail_CVSMaildirSource.py. Later I'll make pull requests that replaces `assert_()` in other places (there are two or five files more as I remember). -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 20:52:28 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 20:52:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2429: Web authentication should use twisted.cred. In-Reply-To: <042.c7eb86d5086767acafddd095ab884222@buildbot.net> References: <042.c7eb86d5086767acafddd095ab884222@buildbot.net> Message-ID: <057.95e15b3777bb2ec5a1a07f757fcdd816@buildbot.net> #2429: Web authentication should use twisted.cred. ------------------------+-------------------- Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: web auth | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 20:52:41 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 20:52:41 -0000 Subject: [Buildbot-commits] [Buildbot] #482: LDAP authentication of build requests In-Reply-To: <040.ba56d4728076dfff67e07dc7875fdac0@buildbot.net> References: <040.ba56d4728076dfff67e07dc7875fdac0@buildbot.net> Message-ID: <055.34cc47dcfca5137707c1b550baad2857@buildbot.net> #482: LDAP authentication of build requests -----------------------------+------------------------- Reporter: ipv6guru | Owner: jollyroger Type: enhancement | Status: accepted Priority: patches-accepted | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: | -----------------------------+------------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 20:55:04 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 20:55:04 -0000 Subject: [Buildbot-commits] [Buildbot] #518: allow complete rebuild during force In-Reply-To: <040.552f63dffbe457d99f43e8c92ff2d8f0@buildbot.net> References: <040.552f63dffbe457d99f43e8c92ff2d8f0@buildbot.net> Message-ID: <055.4532233b2839807a654ce9bbf7d50f91@buildbot.net> #518: allow complete rebuild during force ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Jul 5 21:49:35 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Jul 2013 14:49:35 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c7fc98: Don't check that builders are defined in multi-mas... Message-ID: <51d73f6f3ac80_1689dffde0874ad@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: c7fc9806c3361267c37dcf896be4ce701fd60301 https://github.com/buildbot/buildbot/commit/c7fc9806c3361267c37dcf896be4ce701fd60301 Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Don't check that builders are defined in multi-master mode This fixes an error identified by Yassert LEBON . From noreply at github.com Fri Jul 5 22:02:51 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Jul 2013 15:02:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1d8e00: Merge remote-tracking branch 'org/buildbot-0.8.8' ... Message-ID: <51d7428be1b45_289e141fdd8102240@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1d8e0057ea8f8ef9fc61db10cf6240a63112b3c7 https://github.com/buildbot/buildbot/commit/1d8e0057ea8f8ef9fc61db10cf6240a63112b3c7 Author: Dustin J. Mitchell Date: 2013-06-05 (Wed, 05 Jun 2013) Changed paths: M common/generate_buildbot_api_documentation.sh M master/buildbot/buildslave/__init__.py M master/buildbot/db/schedulers.py M master/buildbot/master.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/schedulers/forcesched.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/grid.py M master/buildbot/status/words.py M master/buildbot/steps/python_twisted.py M master/buildbot/steps/slave.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/oldsource.py M master/buildbot/steps/source/repo.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_status_words.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/unit/test_steps_source_svn.py M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/installation.rst M master/docs/relnotes/0.8.7.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/further.rst M slave/buildslave/scripts/runner.py Log Message: ----------- Merge remote-tracking branch 'org/buildbot-0.8.8' into buildbot-0.8.8 Commit: eb8526ce01be362032ca345f845f0042e9785cdd https://github.com/buildbot/buildbot/commit/eb8526ce01be362032ca345f845f0042e9785cdd Author: Tom Prince Date: 2013-06-05 (Wed, 05 Jun 2013) Changed paths: M master/buildbot/process/build.py M master/docs/relnotes/index.rst Log Message: ----------- Reintroduce deprecated `workdir` property. It is unfortunatley named, but dropping it now doesn't provide a clear migration path. Supporting both for at least a version allows smoother migration. Commit: 4ea0e5fd6c579d6b85421a774ea00efa731c2e1a https://github.com/buildbot/buildbot/commit/4ea0e5fd6c579d6b85421a774ea00efa731c2e1a Author: Tom Prince Date: 2013-06-06 (Thu, 06 Jun 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py Log Message: ----------- Rework locating config file for checkconfig and upgrade-master. This changes the logic of checkconfig so that, 1. If a file is passed, that file is used. 2. If a directory is passed containing `buildbot.tac`, that file is loaded and `configfile` is defined there, that file is used. 3. If `buildbot.tac` doesn't exist, or doesn't define `configfile`, `master.cfg` from that directory is used. The logic for upgrade-master is similar, except only directories are supported, so (1) is skipped. Commit: 5fd5273241de3e1e3a93cfe259d6cc882bf796a4 https://github.com/buildbot/buildbot/commit/5fd5273241de3e1e3a93cfe259d6cc882bf796a4 Author: Tom Prince Date: 2013-06-06 (Thu, 06 Jun 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- Use twisted.python.deprecate.deprecatedModuleAttribute to deprecate SetProperty. Commit: 6b06d23eb425b00fe96c8e98633ff77d98b58d54 https://github.com/buildbot/buildbot/commit/6b06d23eb425b00fe96c8e98633ff77d98b58d54 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/base.py A master/buildbot/buildslave/ec2.py A master/buildbot/buildslave/libvirt.py M master/buildbot/buildslave/openstack.py M master/buildbot/ec2buildslave.py M master/buildbot/libvirtbuildslave.py R master/buildbot/test/unit/test_buildslave.py A master/buildbot/test/unit/test_buildslave_base.py A master/buildbot/test/unit/test_buildslave_libvirt.py R master/buildbot/test/unit/test_libvirtbuildslave.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/index.rst Log Message: ----------- Move buildslave code around to match organization of openstack latent slave. Commit: 18533b22faba8e69246e65e54e7cee0e0466621d https://github.com/buildbot/buildbot/commit/18533b22faba8e69246e65e54e7cee0e0466621d Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_checkconfig.py Log Message: ----------- Report `SyntaxError` or `ImportError` from `checkconfig` and `upgrade-master`. Commit: 479ab7f275d96b1814db93a2e69e70033b5fefc0 https://github.com/buildbot/buildbot/commit/479ab7f275d96b1814db93a2e69e70033b5fefc0 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py Log Message: ----------- Merge 'locate-config': Rework locating config file for checkconfig and upgrade-master. This changes the logic of checkconfig so that, 1. If a file is passed, that file is used. 2. If a directory is passed containing buildbot.tac, that file is loaded and configfile is defined there, that file is used. 3. If buildbot.tac doesn't exist, or doesn't define configfile, master.cfg from that directory is used. The logic for upgrade-master is similar, except only directories are supported, so (1) is skipped. Commit: 1465f9d26e4dd2edd75703706ed57eb6f75d012e https://github.com/buildbot/buildbot/commit/1465f9d26e4dd2edd75703706ed57eb6f75d012e Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py Log Message: ----------- Fix python2.5 syntax errors. Commit: c7fc9806c3361267c37dcf896be4ce701fd60301 https://github.com/buildbot/buildbot/commit/c7fc9806c3361267c37dcf896be4ce701fd60301 Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Don't check that builders are defined in multi-master mode This fixes an error identified by Yassert LEBON . Commit: 99e57e6577dca2361ac3fe1f36f0cad19387c10f https://github.com/buildbot/buildbot/commit/99e57e6577dca2361ac3fe1f36f0cad19387c10f Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/base.py A master/buildbot/buildslave/ec2.py A master/buildbot/buildslave/libvirt.py M master/buildbot/buildslave/openstack.py M master/buildbot/config.py M master/buildbot/ec2buildslave.py M master/buildbot/libvirtbuildslave.py M master/buildbot/process/build.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/steps/shell.py R master/buildbot/test/unit/test_buildslave.py A master/buildbot/test/unit/test_buildslave_base.py A master/buildbot/test/unit/test_buildslave_libvirt.py M master/buildbot/test/unit/test_config.py R master/buildbot/test/unit/test_libvirtbuildslave.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/0.8.8.rst Log Message: ----------- Merge branch 'buildbot-0.8.8' Compare: https://github.com/buildbot/buildbot/compare/4f1c7b2add75...99e57e6577dc From noreply at github.com Fri Jul 5 22:10:00 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Jul 2013 15:10:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1d8e00: Merge remote-tracking branch 'org/buildbot-0.8.8' ... Message-ID: <51d744389c2b0_2e50122dde02814@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 1d8e0057ea8f8ef9fc61db10cf6240a63112b3c7 https://github.com/buildbot/buildbot/commit/1d8e0057ea8f8ef9fc61db10cf6240a63112b3c7 Author: Dustin J. Mitchell Date: 2013-06-05 (Wed, 05 Jun 2013) Changed paths: M common/generate_buildbot_api_documentation.sh M master/buildbot/buildslave/__init__.py M master/buildbot/db/schedulers.py M master/buildbot/master.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/schedulers/forcesched.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/grid.py M master/buildbot/status/words.py M master/buildbot/steps/python_twisted.py M master/buildbot/steps/slave.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/oldsource.py M master/buildbot/steps/source/repo.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_status_words.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_slave.py M master/buildbot/test/unit/test_steps_source_svn.py M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/installation.rst M master/docs/relnotes/0.8.7.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/further.rst M slave/buildslave/scripts/runner.py Log Message: ----------- Merge remote-tracking branch 'org/buildbot-0.8.8' into buildbot-0.8.8 Commit: eb8526ce01be362032ca345f845f0042e9785cdd https://github.com/buildbot/buildbot/commit/eb8526ce01be362032ca345f845f0042e9785cdd Author: Tom Prince Date: 2013-06-05 (Wed, 05 Jun 2013) Changed paths: M master/buildbot/process/build.py M master/docs/relnotes/index.rst Log Message: ----------- Reintroduce deprecated `workdir` property. It is unfortunatley named, but dropping it now doesn't provide a clear migration path. Supporting both for at least a version allows smoother migration. Commit: 4ea0e5fd6c579d6b85421a774ea00efa731c2e1a https://github.com/buildbot/buildbot/commit/4ea0e5fd6c579d6b85421a774ea00efa731c2e1a Author: Tom Prince Date: 2013-06-06 (Thu, 06 Jun 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py Log Message: ----------- Rework locating config file for checkconfig and upgrade-master. This changes the logic of checkconfig so that, 1. If a file is passed, that file is used. 2. If a directory is passed containing `buildbot.tac`, that file is loaded and `configfile` is defined there, that file is used. 3. If `buildbot.tac` doesn't exist, or doesn't define `configfile`, `master.cfg` from that directory is used. The logic for upgrade-master is similar, except only directories are supported, so (1) is skipped. Commit: 5fd5273241de3e1e3a93cfe259d6cc882bf796a4 https://github.com/buildbot/buildbot/commit/5fd5273241de3e1e3a93cfe259d6cc882bf796a4 Author: Tom Prince Date: 2013-06-06 (Thu, 06 Jun 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- Use twisted.python.deprecate.deprecatedModuleAttribute to deprecate SetProperty. Commit: 6b06d23eb425b00fe96c8e98633ff77d98b58d54 https://github.com/buildbot/buildbot/commit/6b06d23eb425b00fe96c8e98633ff77d98b58d54 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/base.py A master/buildbot/buildslave/ec2.py A master/buildbot/buildslave/libvirt.py M master/buildbot/buildslave/openstack.py M master/buildbot/ec2buildslave.py M master/buildbot/libvirtbuildslave.py R master/buildbot/test/unit/test_buildslave.py A master/buildbot/test/unit/test_buildslave_base.py A master/buildbot/test/unit/test_buildslave_libvirt.py R master/buildbot/test/unit/test_libvirtbuildslave.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/index.rst Log Message: ----------- Move buildslave code around to match organization of openstack latent slave. Commit: 18533b22faba8e69246e65e54e7cee0e0466621d https://github.com/buildbot/buildbot/commit/18533b22faba8e69246e65e54e7cee0e0466621d Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_checkconfig.py Log Message: ----------- Report `SyntaxError` or `ImportError` from `checkconfig` and `upgrade-master`. Commit: 479ab7f275d96b1814db93a2e69e70033b5fefc0 https://github.com/buildbot/buildbot/commit/479ab7f275d96b1814db93a2e69e70033b5fefc0 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py Log Message: ----------- Merge 'locate-config': Rework locating config file for checkconfig and upgrade-master. This changes the logic of checkconfig so that, 1. If a file is passed, that file is used. 2. If a directory is passed containing buildbot.tac, that file is loaded and configfile is defined there, that file is used. 3. If buildbot.tac doesn't exist, or doesn't define configfile, master.cfg from that directory is used. The logic for upgrade-master is similar, except only directories are supported, so (1) is skipped. Commit: 1465f9d26e4dd2edd75703706ed57eb6f75d012e https://github.com/buildbot/buildbot/commit/1465f9d26e4dd2edd75703706ed57eb6f75d012e Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py Log Message: ----------- Fix python2.5 syntax errors. Commit: c7fc9806c3361267c37dcf896be4ce701fd60301 https://github.com/buildbot/buildbot/commit/c7fc9806c3361267c37dcf896be4ce701fd60301 Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/config.py M master/buildbot/test/unit/test_config.py Log Message: ----------- Don't check that builders are defined in multi-master mode This fixes an error identified by Yassert LEBON . Commit: 99e57e6577dca2361ac3fe1f36f0cad19387c10f https://github.com/buildbot/buildbot/commit/99e57e6577dca2361ac3fe1f36f0cad19387c10f Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/base.py A master/buildbot/buildslave/ec2.py A master/buildbot/buildslave/libvirt.py M master/buildbot/buildslave/openstack.py M master/buildbot/config.py M master/buildbot/ec2buildslave.py M master/buildbot/libvirtbuildslave.py M master/buildbot/process/build.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/steps/shell.py R master/buildbot/test/unit/test_buildslave.py A master/buildbot/test/unit/test_buildslave_base.py A master/buildbot/test/unit/test_buildslave_libvirt.py M master/buildbot/test/unit/test_config.py R master/buildbot/test/unit/test_libvirtbuildslave.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/0.8.8.rst Log Message: ----------- Merge branch 'buildbot-0.8.8' Commit: 3de2de4bca9bf81463ac74b776e8696d2a3ac6cd https://github.com/buildbot/buildbot/commit/3de2de4bca9bf81463ac74b776e8696d2a3ac6cd Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/base.py A master/buildbot/buildslave/ec2.py A master/buildbot/buildslave/libvirt.py M master/buildbot/buildslave/openstack.py M master/buildbot/config.py M master/buildbot/ec2buildslave.py M master/buildbot/libvirtbuildslave.py M master/buildbot/process/build.py M master/buildbot/scripts/base.py M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/upgrade_master.py M master/buildbot/steps/shell.py R master/buildbot/test/unit/test_buildslave.py A master/buildbot/test/unit/test_buildslave_base.py A master/buildbot/test/unit/test_buildslave_libvirt.py M master/buildbot/test/unit/test_config.py R master/buildbot/test/unit/test_libvirtbuildslave.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/0.8.8.rst Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/d326f4f17fe6...3de2de4bca9b From trac at buildbot.net Fri Jul 5 22:43:40 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:43:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2528: UnicodeEncodeError when using unicode subject in MailNotifier Message-ID: <038.bdf4b7e4f6480ab9ca4879fd20e367d9@buildbot.net> #2528: UnicodeEncodeError when using unicode subject in MailNotifier -------------------+----------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -------------------+----------------------- Buildbot raises `UnicodeEncodeError` when trying to use `MailNotifier` with unicode subject: {{{ from buildbot.status.mail import MailNotifier mn = MailNotifier(fromaddr="buildbot at example.org", lookup="example.org", subject=u"Schr?dinger") c['status'].append(mn) }}} exception: {{{ 2013-07-06 02:40:59+0400 [-] while starting BuildMaster Traceback (most recent call last): File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 1127, in gotResult _inlineCallbacks(r, g, deferred) File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 1071, in _inlineCallbacks result = g.send(result) File "/home/bob/stuff/buildbot/git/master/buildbot/config.py", line 730, in reconfigService yield svc.reconfigService(new_config) File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 1214, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) --- --- File "/home/bob/stuff/buildbot/env/local/lib/python2.7/site- packages/Twisted-12.3.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 1071, in _inlineCallbacks result = g.send(result) File "/home/bob/stuff/buildbot/git/master/buildbot/status/master.py", line 88, in reconfigService sr.setServiceParent(self) File "/home/bob/stuff/buildbot/git/master/buildbot/status/mail.py", line 391, in setServiceParent self.master_status.subscribe(self) File "/home/bob/stuff/buildbot/git/master/buildbot/status/master.py", line 317, in subscribe self.announceNewBuilder(target, name, self.getBuilder(name)) File "/home/bob/stuff/buildbot/git/master/buildbot/status/master.py", line 327, in announceNewBuilder builder_status.subscribe(t) File "/home/bob/stuff/buildbot/git/master/buildbot/status/builder.py", line 437, in subscribe self.status._builder_subscribe(self.name, receiver) File "/home/bob/stuff/buildbot/git/master/buildbot/status/master.py", line 446, in _builder_subscribe self._builder_observers.add(buildername, watcher) File "/home/bob/stuff/buildbot/git/master/buildbot/util/bbcollections.py", line 26, in add self.d[key].add(value) File "/home/bob/stuff/buildbot/git/master/buildbot/util/__init__.py", line 82, in __hash__ return hash(tuple(map(str, alist))) exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 4: ordinal not in range(128) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:44:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:44:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.a0cb5a0c4c2087cde116b0b0738a9b4a@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by dustin): We're planning to get rid of PB, so I'd prefer to stick to simple data structures instead. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:44:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:44:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.71799ce47d3ff495f553a9f3841cc0af@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by dustin): (planning meaning, that's marchael's GSoC project) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:45:47 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:45:47 -0000 Subject: [Buildbot-commits] [Buildbot] #521: authenticated slave-master connections In-Reply-To: <040.ba800d2fe59bbad97170974bf658600f@buildbot.net> References: <040.ba800d2fe59bbad97170974bf658600f@buildbot.net> Message-ID: <055.dab254a7ff43b2d3e9a4a852ef07d5fc@buildbot.net> #521: authenticated slave-master connections ------------------------+-------------------- Reporter: ipv6guru | Owner: Type: enhancement | Status: new Priority: major | Milestone: 2.0.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:48:09 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:48:09 -0000 Subject: [Buildbot-commits] [Buildbot] #581: Automatic builder creation for new branches In-Reply-To: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> References: <041.279f3c2d7a648bd6f8a842c8d5c1c124@buildbot.net> Message-ID: <056.7f645ab2b15263727f1038acaea67e48@buildbot.net> #581: Automatic builder creation for new branches ------------------------+--------------------- Reporter: mhoermann | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.10 | Resolution: Keywords: | ------------------------+--------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:53:17 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:53:17 -0000 Subject: [Buildbot-commits] [Buildbot] #595: RFE: Allow FileDownload from arbitrary file object In-Reply-To: <039.f1b505a045c08c0d3c482804d19e43ef@buildbot.net> References: <039.f1b505a045c08c0d3c482804d19e43ef@buildbot.net> Message-ID: <054.d9a37e721bc38ef8f4d07e879c643ed9@buildbot.net> #595: RFE: Allow FileDownload from arbitrary file object ------------------------+-------------------- Reporter: ddunbar | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.7.11 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:58:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:58:11 -0000 Subject: [Buildbot-commits] [Buildbot] #674: Give better caching directives for static files in web interface In-Reply-To: <039.a6b102657e858d83ef39472e1924e658@buildbot.net> References: <039.a6b102657e858d83ef39472e1924e658@buildbot.net> Message-ID: <054.b8dba0059eb772acc7071928801e8fa8@buildbot.net> #674: Give better caching directives for static files in web interface ------------------------+----------------------- Reporter: Nicolas | Owner: Type: enhancement | Status: assigned Priority: minor | Milestone: 0.9.+ Version: | Resolution: Keywords: web | ------------------------+----------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 22:58:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 22:58:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2528: ComparableMixin's __hash__ fails when a comparable attribute is unicode (was: UnicodeEncodeError when using unicode subject in MailNotifier) In-Reply-To: <038.bdf4b7e4f6480ab9ca4879fd20e367d9@buildbot.net> References: <038.bdf4b7e4f6480ab9ca4879fd20e367d9@buildbot.net> Message-ID: <053.28695d39c66c2fb827bcb37fb74dea01@buildbot.net> #2528: ComparableMixin's __hash__ fails when a comparable attribute is unicode -------------------+-------------------- Reporter: rutsky | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ Comment: I think that the fix here is to not try to convert everything to a string before hashing it, but I'm not entirely sure. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:02:04 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:02:04 -0000 Subject: [Buildbot-commits] [Buildbot] #778: 'latest' revision get's stuck on grid views when source step fails In-Reply-To: <039.27a06b248f9920dc90571d9fde33c0c5@buildbot.net> References: <039.27a06b248f9920dc90571d9fde33c0c5@buildbot.net> Message-ID: <054.c79eb74ee5aed36c74f21b1081122b94@buildbot.net> #778: 'latest' revision get's stuck on grid views when source step fails --------------------+-------------------- Reporter: marcusl | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.7.12 | Resolution: Keywords: web | --------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:03:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:03:58 -0000 Subject: [Buildbot-commits] [Buildbot] #956: Send an email notification to the person who forces/rebuilds a build In-Reply-To: <053.90a141f4d7d39441567be12e2bab5e39@buildbot.net> References: <053.90a141f4d7d39441567be12e2bab5e39@buildbot.net> Message-ID: <068.781f7be4f8338ad6746cc969db6e8967@buildbot.net> #956: Send an email notification to the person who forces/rebuilds a build ------------------------+-------------------- Reporter: yogawa@? | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: mail, users | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:09:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:09:55 -0000 Subject: [Buildbot-commits] [Buildbot] #960: Convert all buildbot classes to new style, i.e. inherit from object. In-Reply-To: <038.d2790722df76541e40fedfc676770414@buildbot.net> References: <038.d2790722df76541e40fedfc676770414@buildbot.net> Message-ID: <053.a04169261a38a1261dd03526677e7767@buildbot.net> #960: Convert all buildbot classes to new style, i.e. inherit from object. -------------------+-------------------- Reporter: maruel | Owner: Type: task | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.1 | Resolution: Keywords: tests | -------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:14:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:14:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1044: Problems to running an slave on Windows XP In-Reply-To: <040.af193039d9df894cbd298524c2187b54@buildbot.net> References: <040.af193039d9df894cbd298524c2187b54@buildbot.net> Message-ID: <055.42bde5a4ff514e22c5e581d3f0102207@buildbot.net> #1044: Problems to running an slave on Windows XP ----------------------------+---------------------- Reporter: acamargo | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.1 | Resolution: Keywords: windows | ----------------------------+---------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:15:43 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:15:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1696: use twisted.web.Guard for authentication In-Reply-To: <038.c7736385ae029f93dfece0a95e26bc84@buildbot.net> References: <038.c7736385ae029f93dfece0a95e26bc84@buildbot.net> Message-ID: <053.e96fcf8e9b9e2a0ab22ba6f9e58a186c@buildbot.net> #1696: use twisted.web.Guard for authentication ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.2 | Resolution: Keywords: web, | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:16:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:16:25 -0000 Subject: [Buildbot-commits] [Buildbot] #1728: Git: add support for setting additional information via Git notes In-Reply-To: <043.8b1d4a52e38fd8f9864e8e19f915c616@buildbot.net> References: <043.8b1d4a52e38fd8f9864e8e19f915c616@buildbot.net> Message-ID: <058.6da4b198bb18dd35f364d699fb922864@buildbot.net> #1728: Git: add support for setting additional information via Git notes ------------------------+-------------------- Reporter: PiotrSikora | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.2 | Resolution: Keywords: git, gerrit | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:26:46 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:26:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.ef38786c46b6efe33f0b49fb62af657b@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by rutsky): Then maybe still use class scheme like `command=["echo", Obfuscate("real", "fake")]` in user code and translate `Obfuscate` class to tuple with "escape" code `('obfuscate', 'real', 'fake')` in `buildbot.steps.shell.ShellCommand` before sending command to slave? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:31:23 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:31:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1795: add python script slave-side command In-Reply-To: <038.e85839bcaeecc89b05fe39de8747e2e9@buildbot.net> References: <038.e85839bcaeecc89b05fe39de8747e2e9@buildbot.net> Message-ID: <053.648c48b435eaa4c735c62fe01f65ff96@buildbot.net> #1795: add python script slave-side command ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.3p1 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:35:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:35:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.47746dbf1583b5823fea2902eced308a@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: assigned Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: windows | ----------------------+----------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:36:15 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:36:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1884: transfer steps should include progress info In-Reply-To: <038.959cbfda66e15d0d2f7b00bfece81d58@buildbot.net> References: <038.959cbfda66e15d0d2f7b00bfece81d58@buildbot.net> Message-ID: <053.105533bebdbabdd30681d23d08c72c60@buildbot.net> #1884: transfer steps should include progress info ------------------------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: web, transfer, master-slave, sprint | ------------------------------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:37:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:37:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1926: GET requests on target URLs of POST forms should be refused In-Reply-To: <038.b71206413f158ff9f352fac93471a431@buildbot.net> References: <038.b71206413f158ff9f352fac93471a431@buildbot.net> Message-ID: <053.94a6e5d59ad05945827c78f2146e69f5@buildbot.net> #1926: GET requests on target URLs of POST forms should be refused ------------------------+-------------------- Reporter: pitrou | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.0 Version: 0.8.3 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 5 23:38:59 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Jul 2013 23:38:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1942: Allow slaves to be authenticated with other cred modules In-Reply-To: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> References: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> Message-ID: <056.6786aa85be40810d436d9bb38dd69c9f@buildbot.net> #1942: Allow slaves to be authenticated with other cred modules ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 10:33:00 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 10:33:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2073: buildbot is unable to delete subdirectories of the build dir that have non-ASCII names under Windows In-Reply-To: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> References: <042.e46ce6f3d9f38cabd09dcaa4bcf63163@buildbot.net> Message-ID: <057.b48e3cb5f7b051be29dde16e05a631fc@buildbot.net> #2073: buildbot is unable to delete subdirectories of the build dir that have non- ASCII names under Windows ------------------------------+------------------------- Reporter: davidsarah | Owner: davidsarah Type: defect | Status: accepted Priority: major | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: Keywords: encoding, windows | ------------------------------+------------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:05:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:05:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2108: BuildBot uses incorrect method for default location of Visual Studios In-Reply-To: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> References: <045.85ed2bd6655c4fd7b0274987c6dd1583@buildbot.net> Message-ID: <060.21cc99452b4d3c49a8d00e84c957b3de@buildbot.net> #2108: BuildBot uses incorrect method for default location of Visual Studios --------------------------+-------------------- Reporter: TemporalBeing | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows | --------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:12:46 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:12:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2268: Grid display is very slow when there is lots of history, and multple projects. In-Reply-To: <042.53bad4ed907978e45669fe62ed5f2960@buildbot.net> References: <042.53bad4ed907978e45669fe62ed5f2960@buildbot.net> Message-ID: <057.a4f35f3915ef6dc8a6c361b9541e8323@buildbot.net> #2268: Grid display is very slow when there is lots of history, and multple projects. -----------------------+-------------------- Reporter: tom.prince | Owner: Type: task | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.2 | Resolution: Keywords: web | -----------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:14:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:14:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2273: Performance items In-Reply-To: <038.89e3b106fc3acc71d6fe483eed162418@buildbot.net> References: <038.89e3b106fc3acc71d6fe483eed162418@buildbot.net> Message-ID: <053.f94d377d4b9e074715bc2425593ea351@buildbot.net> #2273: Performance items --------------------------------+-------------------- Reporter: szager | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: performance, sprint | --------------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:15:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:15:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2293: Simplify MSYS+buildslave integration In-Reply-To: <035.3549ecee3c19691488379fe51a7bf365@buildbot.net> References: <035.3549ecee3c19691488379fe51a7bf365@buildbot.net> Message-ID: <050.2d2941873c57ff78077ae0f8a39c03d7@buildbot.net> #2293: Simplify MSYS+buildslave integration -----------------------------+-------------------- Reporter: LRN | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: windows | -----------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:18:51 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:18:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2381: SVN export method can't export single files In-Reply-To: <039.46a2f1fea1e274ea3c1f2b0330ffb35a@buildbot.net> References: <039.46a2f1fea1e274ea3c1f2b0330ffb35a@buildbot.net> Message-ID: <054.5ce4e4e6aa8ab8fbe7b41a9fe75add76@buildbot.net> #2381: SVN export method can't export single files ------------------------+-------------------- Reporter: Quentin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: svn, sprint | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:19:46 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:19:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2400: Logging in does not clear "Authentication failed" message In-Reply-To: <036.990563bb95c7d8a2fcecc316a03779c5@buildbot.net> References: <036.990563bb95c7d8a2fcecc316a03779c5@buildbot.net> Message-ID: <051.cfbcaff6773b94d8312cb6561cd5283e@buildbot.net> #2400: Logging in does not clear "Authentication failed" message -------------------+-------------------- Reporter: dank | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.8 Version: 0.8.7 | Resolution: Keywords: web | -------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:22:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:22:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2436: Full Integration for User Support In-Reply-To: <038.6e2705361565bbb6049d480a7be9f93c@buildbot.net> References: <038.6e2705361565bbb6049d480a7be9f93c@buildbot.net> Message-ID: <053.b43f92debef2fea4d8193f8815b1f651@buildbot.net> #2436: Full Integration for User Support -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: users | -------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 11:26:01 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 11:26:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2437: New Master-Slave Protocol In-Reply-To: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> References: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> Message-ID: <053.5ddc9f1fdce37eb4734a3db6f1d72686@buildbot.net> #2437: New Master-Slave Protocol -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 14:42:08 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 14:42:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.b9f5fdc834fc0f3921d05bcd652bf335@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): The problem is that a step's properties are only rendered when the step starts, so the waterfall is trying to display something that's not yet rendered. I think this is a dupe - we hear about this issue a lot. I could have sworn we applied a band-aid of trying to render the descriptions early, and falling back to something bland if the rendering failed. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 14:43:24 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 14:43:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2527: Bug in oldsource.py class _ComputeRepositoryURL In-Reply-To: <036.efedf592eb1823440f8abd4426f264ae@buildbot.net> References: <036.efedf592eb1823440f8abd4426f264ae@buildbot.net> Message-ID: <051.763696ade0610e70d443bf380fea931b@buildbot.net> #2527: Bug in oldsource.py class _ComputeRepositoryURL -------------------+-------------------- Reporter: Jani | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ Comment: Does the new master-side step show the same problem? I'm disinclined to fix oldsource.py. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 14:45:06 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 14:45:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual In-Reply-To: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> References: <038.b1f1b93e77d921488fe9e980ad4ac087@buildbot.net> Message-ID: <053.164c9b68cdcaefc5f400a210f6b01d58@buildbot.net> #2521: Replace deprecated method unittest.TestCase.assert_() with newer assertEqual/NotEqual ------------------------+------------------------ Reporter: rutsky | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: tests | ------------------------+------------------------ Comment (by dustin): Ah, great. I assume a simple replacement with `failUnless` would be a good start, followed by using `assertEqual` or the like where the assertion condition is a comparison operator. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 6 14:47:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 06 Jul 2013 14:47:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.b3ca7c27604bd59598aa5c7761e3f460@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by dustin): That sounds like a good plan. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jul 6 19:58:29 2013 From: noreply at github.com (GitHub) Date: Sat, 06 Jul 2013 12:58:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d3b9ce: Add test for checking generated .tac file Message-ID: <51d876e52c3d9_389612c5dd465251@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d3b9ce11d67d2dfe0d372917d80b4e1fcd19dc44 https://github.com/buildbot/buildbot/commit/d3b9ce11d67d2dfe0d372917d80b4e1fcd19dc44 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Add test for checking generated .tac file It checks that .tac file is valid Python script by exec()-uting it with mocked globals imports, such as twisted.application.service.Application and buildslave.bot.BuildSlave. Then it checks, that Application was created and stored in global variable "application" (as .tac specification requires); checks that BuildSlave created with passed arguments and attached to application. Commit: 7f557d5f225b42e19eb6d7e9787ce57711fdf07e https://github.com/buildbot/buildbot/commit/7f557d5f225b42e19eb6d7e9787ce57711fdf07e Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Add tests for basedir containing quotes, spaces and backslashes Quotes test failing with master Buildbot. In one of the older Buildbot releases I tried to create slave on Windows end ended with invalid .tac file due to something like this: basedir = 'C:\basedir\' Looks like this is fixed in master, but adding test won't hurt. Commit: 48447b43c94d8a55ee4900a2819ed7486170d75d https://github.com/buildbot/buildbot/commit/48447b43c94d8a55ee4900a2819ed7486170d75d Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- Fix handling basedir with quotes Commit: a252a91485700467b13b990592186d111a002421 https://github.com/buildbot/buildbot/commit/a252a91485700467b13b990592186d111a002421 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Add tests for invalid --umask and --allow-shutdown options Currently fails. Commit: 247d0f3ce8976d8efbf9ec8e688d8d4ea5fc7e6b https://github.com/buildbot/buildbot/commit/247d0f3ce8976d8efbf9ec8e688d8d4ea5fc7e6b Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- Handle invalid --umask and --allow-shutdown options Commit: 12dc3f4b4a0c8bbb83c5aac17bdfc19fa0dcb38e https://github.com/buildbot/buildbot/commit/12dc3f4b4a0c8bbb83c5aac17bdfc19fa0dcb38e Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Add test for handling special characters in all options fields Currently fails. Commit: 66a5a8db5efb1531444def57da237f7495403445 https://github.com/buildbot/buildbot/commit/66a5a8db5efb1531444def57da237f7495403445 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- Fix options fields writing in .tac file Commit: 1d12db6aa257cd5ab7948ff087b29860eb2d05e6 https://github.com/buildbot/buildbot/commit/1d12db6aa257cd5ab7948ff087b29860eb2d05e6 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- Write "log-size" as numeric, since it's always integer Commit: 059a37ad9348162e9080dcc25037ea7f1c12de5a https://github.com/buildbot/buildbot/commit/059a37ad9348162e9080dcc25037ea7f1c12de5a Author: Dustin J. Mitchell Date: 2013-07-06 (Sat, 06 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_create_slave.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'slave_tac_check_and_fix' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/99e57e6577dc...059a37ad9348 From noreply at github.com Sun Jul 7 00:09:36 2013 From: noreply at github.com (GitHub) Date: Sat, 06 Jul 2013 17:09:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 97dc56: buildslaves db and data Message-ID: <51d8b1c0ed190_3946d93dd451419@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 97dc5669d106b9f333ffdaf9e84e8885127538aa https://github.com/buildbot/buildbot/commit/97dc5669d106b9f333ffdaf9e84e8885127538aa Author: Dustin J. Mitchell Date: 2013-07-05 (Fri, 05 Jul 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/data/builds.py A master/buildbot/data/buildslaves.py M master/buildbot/data/types.py M master/buildbot/db/builds.py M master/buildbot/db/buildslaves.py M master/buildbot/db/migrate/versions/029_replace_builds_table.py A master/buildbot/db/migrate/versions/032_slave_connections.py M master/buildbot/db/model.py M master/buildbot/process/botmaster.py M master/buildbot/process/builder.py M master/buildbot/status/web/builder.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_buildslave_base.py M master/buildbot/test/unit/test_data_builds.py A master/buildbot/test/unit/test_data_buildslaves.py M master/buildbot/test/unit/test_data_logchunks.py M master/buildbot/test/unit/test_data_logs.py M master/buildbot/test/unit/test_data_steps.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_db_buildslaves.py M master/buildbot/test/unit/test_db_logs.py A master/buildbot/test/unit/test_db_migrate_versions_032_slave_connections.py M master/buildbot/test/unit/test_db_steps.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/util/validation.py M master/docs/developer/db.rst M master/docs/developer/rtype-build.rst Log Message: ----------- buildslaves db and data Add DB support for tracking where slaves are configured and where they are connected, and a basic data API layer atop that. Commit: 29c13a77873872d3e77c920fb198ee78b577f43f https://github.com/buildbot/buildbot/commit/29c13a77873872d3e77c920fb198ee78b577f43f Author: Dustin J. Mitchell Date: 2013-07-06 (Sat, 06 Jul 2013) Changed paths: M master/docs/developer/data.rst M master/docs/developer/db.rst A master/docs/developer/rtype-buildslave.rst Log Message: ----------- docs for buildslave resource type Commit: 1896a8759b6e0fc2466a6067f8b8f7f1e0ab3454 https://github.com/buildbot/buildbot/commit/1896a8759b6e0fc2466a6067f8b8f7f1e0ab3454 Author: Dustin J. Mitchell Date: 2013-07-06 (Sat, 06 Jul 2013) Changed paths: M master/buildbot/test/fake/fakedb.py Log Message: ----------- minor tweaks Compare: https://github.com/buildbot/buildbot/compare/3de2de4bca9b...1896a8759b6e From noreply at github.com Sun Jul 7 03:06:11 2013 From: noreply at github.com (GitHub) Date: Sat, 06 Jul 2013 20:06:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c815fc: fix merge error regarding id key in buildslavedict... Message-ID: <51d8db23bb728_744b138bde0428df@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: c815fc9b3b142526b5506037c379ad240b164631 https://github.com/buildbot/buildbot/commit/c815fc9b3b142526b5506037c379ad240b164631 Author: Dustin J. Mitchell Date: 2013-07-06 (Sat, 06 Jul 2013) Changed paths: M master/buildbot/test/unit/test_db_buildslaves.py M master/docs/developer/db.rst Log Message: ----------- fix merge error regarding id key in buildslavedicts From noreply at github.com Mon Jul 8 13:00:10 2013 From: noreply at github.com (GitHub) Date: Mon, 08 Jul 2013 06:00:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 815fad: fixed PEP8 violation Message-ID: <51dab7daaa58e_284f813ddc74763@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 815fad842a9a6cf18366a7e777e95e0897a1fe72 https://github.com/buildbot/buildbot/commit/815fad842a9a6cf18366a7e777e95e0897a1fe72 Author: Elmir Jagudin Date: 2013-07-04 (Thu, 04 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_base.py Log Message: ----------- fixed PEP8 violation Commit: f61a9241bbf36df71bb395d818b25673aeb1e141 https://github.com/buildbot/buildbot/commit/f61a9241bbf36df71bb395d818b25673aeb1e141 Author: Elmir Jagudin Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- create slave: use OS specific path in messages Commit: a4cbf6ff56b2b8700fbfcd15cee7ade957377b58 https://github.com/buildbot/buildbot/commit/a4cbf6ff56b2b8700fbfcd15cee7ade957377b58 Author: Elmir Jagudin Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- use OS specific paths in unit tests Commit: 270ae42dbb073cccaea70f4cbf1046922620e112 https://github.com/buildbot/buildbot/commit/270ae42dbb073cccaea70f4cbf1046922620e112 Author: Dustin J. Mitchell Date: 2013-07-08 (Mon, 08 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Merge branch 'fix-utests-win' of https://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/059a37ad9348...270ae42dbb07 From noreply at github.com Tue Jul 9 02:35:28 2013 From: noreply at github.com (GitHub) Date: Mon, 08 Jul 2013 19:35:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 866794: Master-side source steps support patches. Fixes #2... Message-ID: <51db76f0a434c_2efc4e1de48702c@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 866794ae336a8fce92e005aad1e8e416961e387d https://github.com/buildbot/buildbot/commit/866794ae336a8fce92e005aad1e8e416961e387d Author: Srinu P Date: 2013-07-08 (Mon, 08 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Master-side source steps support patches. Fixes #2098 Commit: 9cd7f9a097f16bc8e0e1f8dbcf52b1946b5c1756 https://github.com/buildbot/buildbot/commit/9cd7f9a097f16bc8e0e1f8dbcf52b1946b5c1756 Author: Dustin J. Mitchell Date: 2013-07-08 (Mon, 08 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2098-squash' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/270ae42dbb07...9cd7f9a097f1 From noreply at github.com Tue Jul 9 22:34:39 2013 From: noreply at github.com (GitHub) Date: Tue, 09 Jul 2013 15:34:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec85bd: Docs: update some index references Message-ID: <51dc8fffaba9_24b9a5dde0790b5@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3 https://github.com/buildbot/buildbot/commit/ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3 Author: Jared Grubb Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/docs/developer/cls-iproperties.rst M master/docs/developer/cls-irenderable.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-properties.rst Log Message: ----------- Docs: update some index references Commit: 789dedd66cf7b4064ce5f8ad0582717c336692ea https://github.com/buildbot/buildbot/commit/789dedd66cf7b4064ce5f8ad0582717c336692ea Author: Pierre Tardy Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- repo codingStyle fixes - repo step and unit tests are now pep8 compliant - fixed camelCase for repo step parameters - removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable - added test on repo download from changesource - update doc and release notes Signed-off-by: Pierre Tardy Commit: 75149f365576a97d2d7a486aab2aa00774991b28 https://github.com/buildbot/buildbot/commit/75149f365576a97d2d7a486aab2aa00774991b28 Author: Pierre Tardy Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- repo: add RepoDownloadsFromChangeSource renderable Suggestion from Tom to put this away from the step code. In cunjunction with FlattenList, this works well. + some more minor review handling Signed-off-by: Pierre Tardy Commit: dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51 https://github.com/buildbot/buildbot/commit/dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51 Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Update release notes. Commit: 1199199a3f4ce54a85a30f959ba5a4fee2f179db https://github.com/buildbot/buildbot/commit/1199199a3f4ce54a85a30f959ba5a4fee2f179db Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'repo-coding-style' into buildbot-0.8.8. - repo step and unit tests are now pep8 compliant - fixed camelCase for repo step parameters - removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable - added test on repo download from changesource - update doc and release notes Commit: cc8913b76c4932465f496c7262a4afb81ec1fe78 https://github.com/buildbot/buildbot/commit/cc8913b76c4932465f496c7262a4afb81ec1fe78 Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Revert adding slave-side support for sudo. Adding sudo to a command can easily be handled by on the master-side. Also, different people will have different expectations, which a single argument isn't enough to capture. See https://github.com/fabric/fabric/issues/503 for some discussions. This reverts commit b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e, reversing changes made to d0cd62b6049759d89b09b1512dab2268132fd30d. Compare: https://github.com/buildbot/buildbot/compare/c7fc9806c336...cc8913b76c49 From noreply at github.com Fri Jul 12 21:57:36 2013 From: noreply at github.com (GitHub) Date: Fri, 12 Jul 2013 14:57:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0c8c77: more careful tracking of buildslaveid in AbstractB... Message-ID: <51e07bd07d0b5_29fe12a5de0713fc@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 0c8c775afaa3579ea42a15aaa215c44ed7a85390 https://github.com/buildbot/buildbot/commit/0c8c775afaa3579ea42a15aaa215c44ed7a85390 Author: Dustin J. Mitchell Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/test/unit/test_buildslave_base.py Log Message: ----------- more careful tracking of buildslaveid in AbstractBuildSlave Commit: 48e904936ec84fd6964f7b7fdeb094520be0da0f https://github.com/buildbot/buildbot/commit/48e904936ec84fd6964f7b7fdeb094520be0da0f Author: Dustin J. Mitchell Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M master/buildbot/process/builder.py M master/buildbot/test/unit/test_data_builds.py M master/buildbot/test/unit/test_data_logchunks.py M master/buildbot/test/unit/test_data_logs.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_status_mail.py M master/docs/developer/rtype-build.rst Log Message: ----------- integrate buildslaves and builds Commit: f4f0519922d4f52fb17c7c10b6e7915202ed7774 https://github.com/buildbot/buildbot/commit/f4f0519922d4f52fb17c7c10b6e7915202ed7774 Author: Dustin J. Mitchell Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M master/buildbot/buildslave/base.py Log Message: ----------- refactor AbstractBuildSlave.attached Commit: 5154215037801ad1f149510f4e4fb51f49f3b008 https://github.com/buildbot/buildbot/commit/5154215037801ad1f149510f4e4fb51f49f3b008 Author: Dustin J. Mitchell Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/data/buildslaves.py M master/buildbot/data/connector.py M master/buildbot/db/buildslaves.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildslaves.py M master/docs/developer/db.rst M master/docs/developer/rtype-buildslave.rst Log Message: ----------- add DB/data support for recording buildslave connections and disconnections Commit: d6c7aab6c7b31cacf175592c7aa3f6cd39d6d4ac https://github.com/buildbot/buildbot/commit/d6c7aab6c7b31cacf175592c7aa3f6cd39d6d4ac Author: Dustin J. Mitchell Date: 2013-07-12 (Fri, 12 Jul 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/unit/test_buildslave_base.py Log Message: ----------- fix tests Compare: https://github.com/buildbot/buildbot/compare/c815fc9b3b14...d6c7aab6c7b3 From noreply at github.com Sat Jul 13 15:41:01 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 08:41:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 478c79: Add support for passing keyword arguments to Build... Message-ID: <51e1750dc19ba_6e5531d5857854@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 478c79fe9024826403a6ee08d152859181178bfd https://github.com/buildbot/buildbot/commit/478c79fe9024826403a6ee08d152859181178bfd Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/process/factory.py M master/buildbot/test/unit/test_process_factory.py M master/docs/relnotes/index.rst Log Message: ----------- Add support for passing keyword arguments to BuildFactory.addStep. This was supported in old versions of buildbot, but there wasn't a release that supported both, making transitioning harder than necessary. Commit: 379603bc07b4ccef0993cedc025aeef1c63e5844 https://github.com/buildbot/buildbot/commit/379603bc07b4ccef0993cedc025aeef1c63e5844 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py R master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Revert 'try_client_available_builder_names'. This added ad-hoc support for overriding `getAvaliableBuilderNames` in a subclass of `TrySchedulerer`. But that support was undocumented and untested. This reverts commit 46a81edbecee41e9042b7d1bbf928e13d59e618d, reversing changes made to 9ec2372129b48842b5c3bc5e933b28ed728d46e3. Commit: 66f62be3dad57fcd7eb897807b5352c3e362e0ed https://github.com/buildbot/buildbot/commit/66f62be3dad57fcd7eb897807b5352c3e362e0ed Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Use `assertTrue`/`assertFalse` instead of `assertIdentical` where appropriate. Commit: e8147cc53069f1c73f10b7ab49016f45a90d934a https://github.com/buildbot/buildbot/commit/e8147cc53069f1c73f10b7ab49016f45a90d934a Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/process/factory.py M master/buildbot/test/unit/test_process_factory.py M master/docs/relnotes/index.rst Log Message: ----------- Merge 'support-depercated-addStep': Add support for passing keyword arguments to BuildFactory.addStep. We deprecated this in 0.8.6 and dropped support in 0.8.7. But 0.8.7 was the first version to support not needing to use .addFactoryArguments. But, passing keyword arguments to .addStep also avoid this. Commit: 7dfd05464983ca5c773f7764448a23968314a424 https://github.com/buildbot/buildbot/commit/7dfd05464983ca5c773f7764448a23968314a424 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/regressions/test_shell_command_properties.py Log Message: ----------- Don't use deprecated name SetProperty in regression tests. Compare: https://github.com/buildbot/buildbot/compare/cc8913b76c49...7dfd05464983 From noreply at github.com Sat Jul 13 19:00:09 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 12:00:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3b1b6e: Expose twisted.cred for change hook auth. Message-ID: <51e1a3b986a42_511b833d581838b@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 3b1b6e600ca5c95961ec14dd56e602e1ca62408b https://github.com/buildbot/buildbot/commit/3b1b6e600ca5c95961ec14dd56e602e1ca62408b Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Expose twisted.cred for change hook auth. Twisted provides a rich interface for defining authentication. Use it for defining change hook authorization, rather than just one specific bit of it. Commit: 90e94e2b59711b99a8b7f7350433f50f8cd12a5e https://github.com/buildbot/buildbot/commit/90e94e2b59711b99a8b7f7350433f50f8cd12a5e Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- Also skip adding hook if it IUsernamePassword isn't supported. Commit: 3b2f3c7661f9a51e7e1eb208669092ca47f6f89e https://github.com/buildbot/buildbot/commit/3b2f3c7661f9a51e7e1eb208669092ca47f6f89e Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Link to twisted.cred documentation. Commit: 61a20da2a79c4c0c9318ee758f8fd2132899913f https://github.com/buildbot/buildbot/commit/61a20da2a79c4c0c9318ee758f8fd2132899913f Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge 'web-auth': Expose twisted.cred for change hook auth. Twisted provides a rich interface for defining authentication. Use it for defining change hook authorization, rather than just one specific bit of it. Compare: https://github.com/buildbot/buildbot/compare/7dfd05464983...61a20da2a79c From noreply at github.com Sat Jul 13 19:00:10 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 12:00:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <51e1a3baf0567_6bc1157d58688db@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/tags/v0.8.8rc1 Home: https://github.com/buildbot/buildbot From noreply at github.com Sat Jul 13 19:43:54 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 12:43:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4a5cf6: PyFlakes: fix handling of syntax error Message-ID: <51e1adfa1f553_1c6ce67ddc1039d4@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4a5cf6e781971f30b90f7a50b754ff6be6f0d0fa https://github.com/buildbot/buildbot/commit/4a5cf6e781971f30b90f7a50b754ff6be6f0d0fa Author: K?lm?n Viktor Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/python.py Log Message: ----------- PyFlakes: fix handling of syntax error Commit: b1a6e23f5b0d4418b2f06eb3627e2816bf3d45e4 https://github.com/buildbot/buildbot/commit/b1a6e23f5b0d4418b2f06eb3627e2816bf3d45e4 Author: Dustin J. Mitchell Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/python.py Log Message: ----------- Merge branch 'master' of git://github.com/kviktor/buildbot Compare: https://github.com/buildbot/buildbot/compare/9cd7f9a097f1...b1a6e23f5b0d From noreply at github.com Sat Jul 13 21:15:27 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 14:15:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5a9574: fix errors on postgres Message-ID: <51e1c36fa523d_671b5bd501521f@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 5a9574d5df709b6694a9cd4d00de3c0169e11c16 https://github.com/buildbot/buildbot/commit/5a9574d5df709b6694a9cd4d00de3c0169e11c16 Author: Dustin J. Mitchell Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/db/buildslaves.py M master/buildbot/test/unit/test_db_buildslaves.py Log Message: ----------- fix errors on postgres From noreply at github.com Sat Jul 13 21:25:36 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 14:25:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 08ed40: remove bad JSON test: StatementError doesn't exist... Message-ID: <51e1c5d0ab7ee_1be895fde4622a9@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 08ed4098e5f3e81a55b7b2dc38d5fee0ddf2d2a0 https://github.com/buildbot/buildbot/commit/08ed4098e5f3e81a55b7b2dc38d5fee0ddf2d2a0 Author: Dustin J. Mitchell Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/unit/test_db_buildslaves.py Log Message: ----------- remove bad JSON test: StatementError doesn't exist on older SQLAlchemies, and it's not part of the API anyway From noreply at github.com Sat Jul 13 22:12:39 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 15:12:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b3c474: P4: Use config.error, instead of collecting errors... Message-ID: <51e1d0d77e781_6c459dfd504961c@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 https://github.com/buildbot/buildbot/commit/b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use config.error, instead of collecting errors by hand. Commit: f838d86fe563745123d56bf764dafd61ef3d52dc https://github.com/buildbot/buildbot/commit/f838d86fe563745123d56bf764dafd61ef3d52dc Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use tools provided by CompositeStepMixin. Commit: a958a020650557375144783fe52e5e79719703b8 https://github.com/buildbot/buildbot/commit/a958a020650557375144783fe52e5e79719703b8 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Merge pull request #767 from tomprince/p4-cleanups P4 cleanups Compare: https://github.com/buildbot/buildbot/compare/61a20da2a79c...a958a0206505 From noreply at github.com Sat Jul 13 22:21:12 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 15:21:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b3c474: P4: Use config.error, instead of collecting errors... Message-ID: <51e1d2d878208_378a913d54592d@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/tags/v0.8.8rc1 Home: https://github.com/buildbot/buildbot Commit: b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 https://github.com/buildbot/buildbot/commit/b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use config.error, instead of collecting errors by hand. Commit: f838d86fe563745123d56bf764dafd61ef3d52dc https://github.com/buildbot/buildbot/commit/f838d86fe563745123d56bf764dafd61ef3d52dc Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use tools provided by CompositeStepMixin. Commit: a958a020650557375144783fe52e5e79719703b8 https://github.com/buildbot/buildbot/commit/a958a020650557375144783fe52e5e79719703b8 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Merge pull request #767 from tomprince/p4-cleanups P4 cleanups Compare: https://github.com/buildbot/buildbot/compare/61a20da2a79c...d322677bc777 From noreply at github.com Sat Jul 13 22:28:57 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 15:28:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 68c711: new Buildbot presentation style Message-ID: <51e1d4a94c24b_3b4ce11d4c4603b@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/brownbag Home: https://github.com/buildbot/buildbot Commit: 68c7118c070e629b8de7b44a7fb23039ed0056f4 https://github.com/buildbot/buildbot/commit/68c7118c070e629b8de7b44a7fb23039ed0056f4 Author: Dustin J. Mitchell Date: 2013-06-14 (Fri, 14 Jun 2013) Changed paths: A media/buildbot-brownbag/.travis.yml A media/buildbot-brownbag/Gruntfile.js A media/buildbot-brownbag/LICENSE A media/buildbot-brownbag/README.md A media/buildbot-brownbag/css/print/paper.css A media/buildbot-brownbag/css/print/pdf.css A media/buildbot-brownbag/css/reveal.min.css A media/buildbot-brownbag/css/theme/README.md A media/buildbot-brownbag/css/theme/beige.css A media/buildbot-brownbag/css/theme/buildbot.css A media/buildbot-brownbag/css/theme/default.css A media/buildbot-brownbag/css/theme/moon.css A media/buildbot-brownbag/css/theme/night.css A media/buildbot-brownbag/css/theme/serif.css A media/buildbot-brownbag/css/theme/simple.css A media/buildbot-brownbag/css/theme/sky.css A media/buildbot-brownbag/css/theme/solarized.css A media/buildbot-brownbag/css/theme/source/beige.scss A media/buildbot-brownbag/css/theme/source/default.scss A media/buildbot-brownbag/css/theme/source/moon.scss A media/buildbot-brownbag/css/theme/source/night.scss A media/buildbot-brownbag/css/theme/source/serif.scss A media/buildbot-brownbag/css/theme/source/simple.scss A media/buildbot-brownbag/css/theme/source/sky.scss A media/buildbot-brownbag/css/theme/source/solarized.scss A media/buildbot-brownbag/css/theme/template/mixins.scss A media/buildbot-brownbag/css/theme/template/settings.scss A media/buildbot-brownbag/css/theme/template/theme.scss A media/buildbot-brownbag/img/nut.png A media/buildbot-brownbag/index.html A media/buildbot-brownbag/js/reveal.min.js A media/buildbot-brownbag/lib/css/zenburn.css A media/buildbot-brownbag/lib/font/league_gothic-webfont.eot A media/buildbot-brownbag/lib/font/league_gothic-webfont.svg A media/buildbot-brownbag/lib/font/league_gothic-webfont.ttf A media/buildbot-brownbag/lib/font/league_gothic-webfont.woff A media/buildbot-brownbag/lib/font/league_gothic_license A media/buildbot-brownbag/lib/js/classList.js A media/buildbot-brownbag/lib/js/head.min.js A media/buildbot-brownbag/lib/js/html5shiv.js A media/buildbot-brownbag/package.json A media/buildbot-brownbag/plugin/highlight/highlight.js A media/buildbot-brownbag/plugin/notes/notes.html A media/buildbot-brownbag/plugin/notes/notes.js A media/buildbot-brownbag/plugin/postmessage/example.html A media/buildbot-brownbag/plugin/postmessage/postmessage.js A media/buildbot-brownbag/plugin/print-pdf/print-pdf.js Log Message: ----------- new Buildbot presentation style Commit: d6bae4aee78792d1033f56e3fffbecc253b83357 https://github.com/buildbot/buildbot/commit/d6bae4aee78792d1033f56e3fffbecc253b83357 Author: Dustin J. Mitchell Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: A content.rst Log Message: ----------- (WIP) content.rst Compare: https://github.com/buildbot/buildbot/compare/68c7118c070e^...d6bae4aee787 From noreply at github.com Sat Jul 13 22:40:55 2013 From: noreply at github.com (GitHub) Date: Sat, 13 Jul 2013 15:40:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <51e1d7778a08f_6ba3f4dd50266f5@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/brownbag Home: https://github.com/buildbot/buildbot From noreply at github.com Sun Jul 14 13:02:38 2013 From: noreply at github.com (GitHub) Date: Sun, 14 Jul 2013 06:02:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9861c5: fix pyflakes Message-ID: <51e2a16e88d33_3b03f05d4884298@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 9861c5863b4f83ab87b7ff78e7101a0491006b43 https://github.com/buildbot/buildbot/commit/9861c5863b4f83ab87b7ff78e7101a0491006b43 Author: Dustin J. Mitchell Date: 2013-07-14 (Sun, 14 Jul 2013) Changed paths: M master/buildbot/test/unit/test_db_buildslaves.py Log Message: ----------- fix pyflakes From trac at buildbot.net Mon Jul 15 14:57:47 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 15 Jul 2013 14:57:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2529: GitPoller Splits Changed Files list on spaces instead of newline Message-ID: <046.60d91b58e38f9a67cbe67b8f9f1f33a5@buildbot.net> #2529: GitPoller Splits Changed Files list on spaces instead of newline ---------------------------+----------------------- Reporter: Jeremy.Cornett | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ---------------------------+----------------------- When a file is committed/checked in with Git, the Git Poller will catch that change and a scheduler will then kick off a builder. If you look at the change in buildbot, it will list the modified files in that check-in. If the file path or name has a space in it, each part will be displayed on a separate line. 'Service Modules\Test 1.txt' will become 'Service', 'Modules\Test', '1.txt'. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 15 15:02:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 15 Jul 2013 15:02:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2529: GitPoller Splits Changed Files list on spaces instead of newline In-Reply-To: <046.60d91b58e38f9a67cbe67b8f9f1f33a5@buildbot.net> References: <046.60d91b58e38f9a67cbe67b8f9f1f33a5@buildbot.net> Message-ID: <061.c1c7ca8df6a4d02eefdb3283fd21f25b@buildbot.net> #2529: GitPoller Splits Changed Files list on spaces instead of newline ---------------------------+------------------------ Reporter: Jeremy.Cornett | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------------+------------------------ Comment (by Jeremy.Cornett): Attached it a git patch that will fix this defect. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jul 16 02:57:30 2013 From: noreply at github.com (GitHub) Date: Mon, 15 Jul 2013 19:57:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9b0598: remove typo in builddir and workdir properties Message-ID: <51e4b69aa36e5_6cbaa21d5415494f@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 9b0598a8f52b646e06f32b8df53793e4de7d6a64 https://github.com/buildbot/buildbot/commit/9b0598a8f52b646e06f32b8df53793e4de7d6a64 Author: Dustin J. Mitchell Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/process/build.py Log Message: ----------- remove typo in builddir and workdir properties From noreply at github.com Tue Jul 16 03:50:28 2013 From: noreply at github.com (GitHub) Date: Mon, 15 Jul 2013 20:50:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 66a642: - Removed "cmd = " as it's not being used. Message-ID: <51e4c304a1046_6ff3b45d4820437e@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 66a6428df813f1eb9649860bb78151497eef14c6 https://github.com/buildbot/buildbot/commit/66a6428df813f1eb9649860bb78151497eef14c6 Author: Edmund Wong Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- - Removed "cmd = " as it's not being used. From trac at buildbot.net Tue Jul 16 13:16:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Jul 2013 13:16:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2530: RSS feed date is non-conformant with RFC822 Message-ID: <037.fc704cc34c23ca509e158c6d1b174e1c@buildbot.net> #2530: RSS feed date is non-conformant with RFC822 --------------------+----------------------- Reporter: voyta | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: --------------------+----------------------- Date format provided in RSS feed does not conform to RFC822 required by RSS 2.0 specification (http://feed2.w3.org/docs/rss2.html). Day-of-week and month are reported as numbers instead of abbreviated names, example: current: {{{2, 16 7 2013 11:55:33 GMT}}} correct: {{{Tue, 16 Jul 2013 11:55:33 GMT}}} This can cause clients expecting the standard format to display the date incorrectly (e.g. Microsoft Outlook 2010). This bug has been introduced in https://github.com/buildbot/buildbot/commit/4ce04c06ee328f4491d1f51e18b94ae4dd0e12d7 The "fixed-english-locale" arrays introduced in the patch are not used, and only the index is reported. Suggested fix is changing line 69 (in that broken commit) {{{res = res % (tstamp.tm_wday, tstamp.tm_mon)}}} to {{{res = res % (_abbr_day[tstamp.tm_wday], _abbr_mon[tstamp.tm_mon])}}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Jul 17 15:21:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 17 Jul 2013 15:21:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.45c18e76be113f3c73fe175dfbd32a0a@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by srinup): @rutsky. do you have any updates on this? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jul 17 17:23:20 2013 From: noreply at github.com (GitHub) Date: Wed, 17 Jul 2013 10:23:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0ecb1a: SVN source steps mode=export support authenticatio... Message-ID: <51e6d30881d11_5232961dd8754b7@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0ecb1aef26a14f955f4ffa9fdc009277c30b1a97 https://github.com/buildbot/buildbot/commit/0ecb1aef26a14f955f4ffa9fdc009277c30b1a97 Author: Srinu P Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- SVN source steps mode=export support authentication. Fixes #2463 Commit: 021ff42c63721361ff2f1c6d15a5b717ef60d724 https://github.com/buildbot/buildbot/commit/021ff42c63721361ff2f1c6d15a5b717ef60d724 Author: Dustin J. Mitchell Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2463' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/b1a6e23f5b0d...021ff42c6372 From noreply at github.com Wed Jul 17 17:32:45 2013 From: noreply at github.com (GitHub) Date: Wed, 17 Jul 2013 10:32:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] feb582: Master side source checkout steps support retry op... Message-ID: <51e6d53d9b46_6623c2dd5047823@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: feb582a6bbb9839b408f84ba3c438a583e099cd7 https://github.com/buildbot/buildbot/commit/feb582a6bbb9839b408f84ba3c438a583e099cd7 Author: Srinu P Date: 2013-07-14 (Sun, 14 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Master side source checkout steps support retry option. Fixes #2465, #2357 Commit: 97eff1c0b23a41c8bd6735e4a4fcee20eb6051f8 https://github.com/buildbot/buildbot/commit/97eff1c0b23a41c8bd6735e4a4fcee20eb6051f8 Author: Dustin J. Mitchell Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2465-sqash' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/021ff42c6372...97eff1c0b23a From trac at buildbot.net Thu Jul 18 05:55:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 18 Jul 2013 05:55:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2531: Git step fails, if workdir exists but isn't a git checkout. Message-ID: <042.2e717142f8d778004b389c50f2cfc5d5@buildbot.net> #2531: Git step fails, if workdir exists but isn't a git checkout. ------------------------+------------------------------------------ Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: git master-side-source-steps ------------------------+------------------------------------------ If the workdir exists, but isn't a git checkout, buildbot will try to clone to that directory, but will fail, since `git clone` fails on a non- empty directory. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Jul 18 20:07:15 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 18 Jul 2013 20:07:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2532: Support using interlocks for sequences of steps Message-ID: <045.da71f29098b2fd32a7820a5290c3a83b@buildbot.net> #2532: Support using interlocks for sequences of steps --------------------------+----------------------- Reporter: shirokuroneko | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: --------------------------+----------------------- Using interlocks for mutual exclusion of builders is quite useful, but in many cases we don't want to lock the whole build process but rather a sequence of steps within the builder. This becomes a problem when some steps are potentially expensive, yet they don't really require being exclusive. Here's a real world example of this case. Let's say we have a set of builders building and testing different branches/configurations for a embedded device. A simplification of the builder steps could look something like this: 1. Sync branch for the builder. 2. Build the code. 3. Upload/flash to the device. 4. Run tests on the device. In this case steps 1 and 2 and run in parallel in all builders, but steps 3 and 4 are limited to the actual availability of devices. If we have less devices than builders, then we need interlocks to arbitrate access. However, with the current interlock approach we would need to lock the whole builders, therefore forcing steps 1 and 2 to be sequential with no real reason. My suggestion is to introduce the ability to lock not only full builders, but also sequences of steps. In this case the device availability lock could be limited to the sequence of steps 3 to 4. If for any reason the execution of the sequence were halted (e.g. flashing fails and it aborts the build) the lock would be automatically released. Similarly, the lock would also take action even if some steps in the sequence are skipped, including the first and the last. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Jul 18 21:37:51 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 18 Jul 2013 21:37:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.53f53d4901ad3c8f1f2145872c163d10@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by rutsky): Replying to [comment:18 srinup]: > @rutsky. do you have any updates on this? Sorry, no progress yet. I have plans to implement this, but not sure when I will have time for it. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 19 18:58:28 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 19 Jul 2013 18:58:28 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.eab7a3544a9b552de6ce50b9ac7951eb@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+-------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: sprint | ------------------------+-------------------- Comment (by rutsky): Let me add some notes about how I planned to implement this feature. Commands started on buildslave from master side using `buildbot.process.buildstep.RemoteCommand` and it's subclasses. `RemoteCommand` allows to start commands registered in slave's `buildslave.commands.registry` module. In registry there are utility commands such as `"uploadFile"`, `"mkdir"`; custom shell command `"shell"`, and (I think) obsolete source commands like `"svn"`, `"git"`. I think only "shell" command arguments, implemented on slave in `buildslave.commands.shell.SlaveShellCommand`, requires obfuscation (since source commands like `"svn"`, `"git"` shouldn't be used). `buildslave.commands.shell.SlaveShellCommand` uses `buildslave.runprocess.RunProcess` to actually run commands, and it already supports in some way obfuscation using `buildslave.util.Obfuscated`: if one of arguments to `buildslave.commands.shell.SlaveShellCommand` is `Obfuscated` instance it's being obfuscated. This obfuscation is available only from slave side steps, because it's not possible to pass `Obfuscated` instance from master side. My plan was to: 1. Create class `Obfuscated` for wrapping command arguments for obfuscating in buildbot.process.buildstep: {{{ class Obfuscated: def __init__(self, real, fake="*" * 8): ... }}} 2. Extend `buildbot.process.buildstep.RemoteCommand` and `buildbot.process.buildstep.RemoteShellCommand` command arguments semantics so that it will accept instances of newly created `Obfuscated` class: {{{ cmd = buildstep.RemoteShellCommand(self.workdir, ['some_cmd', '--password', Obfuscated(self.password, "*" * 8), ...) }}} `Obfuscated` instances should be expanded to tuples with escaping semantics such as ('obfuscated', 'password', 'fake') as discussed in bug report and transferred to slave. 3. Support tuples with escape semantics on slave side either in `buildslave.runprocess.RunProcess` or in `buildslave.util.Obfuscated`. Working Proof-of-Concept implementation for these changes (without Obfuscated class on master side and with disabled arguments flattening) available in this branch https://github.com/vrutsky/buildbot/commits/POC_obfuscate_slave_side. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 19 21:02:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 19 Jul 2013 21:02:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.8d6ec79bc7d6ddaed45226e5854cca85@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+------------------------ Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: duplicate Keywords: | --------------------+------------------------ Comment (by buck): I've hacked up a solution that (apparently) fixes this issue for 0.8.3: http://paste.pound-python.org/show/4Hc81gexH1lTqxsZXi4v/ I wouldn't say this issue is duplicate, but rather blocked on #1039; even after 1039 is implemented, there will need to be work done to verify that this issue is in fact closed. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 20 18:29:57 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 20 Jul 2013 18:29:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2533: issue on ver. 0.8.7 reconciled Message-ID: <040.9a9e6447d5b32918c23d8eff789b8e1b@buildbot.net> #2533: issue on ver. 0.8.7 reconciled ----------------------+----------------------- Reporter: CarlLane | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7 | Keywords: ----------------------+----------------------- {{{ #!html

????-?????? ?? ?????? ??????

}}} ???????? ? ???? ??? ? ?? ?????? ???????? ??? ?????? ???????, ??? ? ???????? ???????? ??? ????, ??? ??????? ??????????. Web-???????, ??????????? ???????? ????-?????, ???????????????? ??????? ?????? ????????????? ? ????????????. ???? ??????????? ????????? ??? ???????. [[br]] ?? web-???????, ???????????? ?????? ????????? ?????????, ????????? ????????? ??????????? ?????. ????? ?? ???????? ??????????? ????? ??????? ? ???????????? ? ?????, ????????? ? ???????????? ????????. ???????????, ????-???????? '''[http://escort-models.com ??????????? ????]''' ????? ??? ??? ?? ?????-???? ?????? ????? ??????? ??????????????? ?????? ???????. ? ??????? ????? ???? ?????: - ????????? ????? ? ?????;- ??????? ???????? ??????? ???????? ???? ?? ??????? ?????????; - ???????? ????? ????;- ?????????? ?? ??????????;- ??????? ???? ???????? ????????;- ????????????????????. ?????????????? ????? ?????, ???????? ???????????? ? ??????????????????????? ???? ?????? ?? ??????? ?????? ??????????????? ???????????? ????????. ???? ??????????? ??????? ? ????? ????? ?????? ????????? ??????? ???????? ? ?? ???? ?????? ??????? ?? ?????, ??? ??? ??????? ?????? ???????? ?? ??? ??? ???????? ?? ??? ????. [[br]] ????? ??????????????? ?????-???????? ?????????????? ???? ?????????? ???? ???????? ???-????, ??????? ????????????? ??????? ? ?? ??????????? ?????? ???????? ????????? ? ??????????????. ????? ??????????? ??????? ?????, ? ??????? ?? ?????? ??????????? ? ???????? ? ??????? ???????. ????????? ??? ????????? ????? ?????? ?????????. [[br]] ?????? ???? ?????? ???? ??????? - ??? ??, ??? ???? ???????????? ??????????? ? ?????, ?? ????? ??? ?????? ???????????? ????? ????-?? ????????, ? ????? ????? ????? ??????????????? ???????? ???????? ????????. [[br]] ??? ??????? ?????????? ?????????? ?????????? ???????, ????? ??????????? ?????? ??????????? ?????. ? ????? ?? ????????? ?????????? ????? ????????? ???????, ???????? ??????? ????? ????? ????????? ????????????. [[br]] ?????????, ??????????? ????-??????, ?????? ?? ?????? ????? ??????? ????????????. ???? ?????? ?????? ???? ???????. ? ?????? ????? ?????????? ??????? ?? ????? ????? ? ?????. [[br]] ? ??? ??????, ???? ??????? ????? ?????????????? ?????-?? ???????????? ??????????? ???? ?? ???????? ????????????, ?? ? ????-???????? ?? ?? ?????? ???????????? ??????. ??? ??? ???? ????? ???? ????????????? ????????? ??????. [[br]] ???????????? ??????????? ????? ?????????? ? ?????? ????. ??? ?????? ???????, ???? ????? ?????????? ????????? ?? ??????????? ???? ??? ????? ????????. ?????????????? ???????? ? ???? ???????? ???????????? ?????? ???????? ??????????? ????????????: ???-??????, ?????-????. ?????? ?????? ??? ????? ?????? ??????? ?? ???, ??? ???? ??????????? ? ????????? ?????, ? ???? ?????????? ? ??????????? ????????. ????? ????, ????? ???? ????????? ? ???, ??? ??? ????????? ? ???????? ? ??????????? ?????????, ?????? ??????????? ?? ??????? ?????? ? ?????????? ????????? ????????? ????????????????. [[br]] ?????????? ? ???????? ??????? ????? ?? ?????? ??? ????, ????? ??????? ???????? ??????? ????? ???? ?????? ?????????. ????? ???????? ????? ??????? ?? ???????????. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Jul 20 18:34:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 20 Jul 2013 18:34:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2533: issue on ver. 0.8.7 reconciled In-Reply-To: <040.9a9e6447d5b32918c23d8eff789b8e1b@buildbot.net> References: <040.9a9e6447d5b32918c23d8eff789b8e1b@buildbot.net> Message-ID: <055.3f1c40ecc70c0add8bca88cf4436eb13@buildbot.net> #2533: issue on ver. 0.8.7 reconciled ----------------------+------------------------ Reporter: CarlLane | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.7 | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by CarlLane): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 22 17:51:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Jul 2013 17:51:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.260f27eb5eee187c68544d86e79de787@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+------------------------ Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: duplicate Keywords: | --------------------+------------------------ Comment (by buck): I'll submit a well-tested patch for this issue versus buildbot master this week, if the maintainers will welcome it. I'm aware that you all would prefer a patch versus the "nine" branch, but I need to patch a branch that we can actually upgrade to: this is a production problem for us. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 22 18:04:13 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Jul 2013 18:04:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.f5f9d49a020d8c02420b0797cf97934e@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | --------------------+----------------------- Changes (by buck): * status: closed => reopened * resolution: duplicate => Comment: I plan to provide a patch for this, independent of the status of #1039. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 23 18:17:50 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 23 Jul 2013 18:17:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.3a6bf119b6a3a5138a576de2cf34c205@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | --------------------+----------------------- Comment (by buck): In short, if a graceful-shutdown command is sent to a buildbot, which then runs a trigger-and-wait step, that buildbot cluster will then cease to do anything useful indefinitely. The deadlock consists of three blocking parts: 1. The graceful-shutdown command blocks, waiting for all builders to finish. 2. The trigger-and-wait step blocks, waiting for its triggered builds to finish. 3. The triggered build blocks, waiting for the graceful-shutdown to complete before *starting* itself. My essential strategy is to edit part 3. We'll make sure that builds which have steps blocking on them are allowed to run, even if we're in the process of a graceful shutdown. This image demonstrates the necessary behavior. When the "clean shutdown" command comes in, queued builds and non-blocking triggered builds pend until after the master restarts, while blocking triggered builds are allowed to run. [[Image(Selection_029.png)]] This image was generated on buildbot 0.8.3 using this patch: http://paste .pound-python.org/show/N3QKBAISKJpsLJWAWISD/ I plan to provide a similar patch (in spirit if not implementation) and integration tests for buildbot/master branch (0.8.8). -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Jul 25 02:34:13 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Jul 2013 02:34:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2534: unify/remove duplicates naming of pollInterval vs pollinterval Message-ID: <042.32dda6ad0ac22002207fe947bbd42335@buildbot.net> #2534: unify/remove duplicates naming of pollInterval vs pollinterval -----------------------+----------------------- Reporter: yarikoptic | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: -----------------------+----------------------- First spotted in GitPoller.__init__ interface reported in IPython ``` GitPoller(self, repourl, branches=None, branch=None, workdir=None, pollInterval=600, gitbin='git', usetimestamps=True, category=None, project=None, pollinterval=-2, fetch_refspec=None, encoding='utf-8') ``` mention there are both pollInterval and pollinterval. http://docs.buildbot.net/latest/manual/cfg-changesources.html#gitpoller has only pollInterval for Git and Hg but pollinterval for GoogleCodeAtomPoller -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Jul 25 02:35:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Jul 2013 02:35:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2534: unify/remove duplicates naming of pollInterval vs pollinterval In-Reply-To: <042.32dda6ad0ac22002207fe947bbd42335@buildbot.net> References: <042.32dda6ad0ac22002207fe947bbd42335@buildbot.net> Message-ID: <057.2001b01b475b7d9237d04f9d04a96862@buildbot.net> #2534: unify/remove duplicates naming of pollInterval vs pollinterval -----------------------+------------------------ Reporter: yarikoptic | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | -----------------------+------------------------ Comment (by yarikoptic): please pardon my github-rotten fingers in the original post -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jul 25 17:47:51 2013 From: noreply at github.com (GitHub) Date: Thu, 25 Jul 2013 10:47:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ccdf00: skip 'stop slave' test on windows Message-ID: <51f164c75e528_769756bd501043c8@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ccdf00f370fe0f05628e3baa802cfe40622da99a https://github.com/buildbot/buildbot/commit/ccdf00f370fe0f05628e3baa802cfe40622da99a Author: Elmir Jagudin Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_stop.py Log Message: ----------- skip 'stop slave' test on windows Windows does not have os.kill() function, which is used in the tested code path. Skip the test for now. Commit: 9ec3f3a57ca946a0960304c90ae694323bfdbdcf https://github.com/buildbot/buildbot/commit/9ec3f3a57ca946a0960304c90ae694323bfdbdcf Author: Dustin J. Mitchell Date: 2013-07-25 (Thu, 25 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_stop.py Log Message: ----------- Merge branch 'skip-slave-kill' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/97eff1c0b23a...9ec3f3a57ca9 From noreply at github.com Thu Jul 25 20:42:10 2013 From: noreply at github.com (GitHub) Date: Thu, 25 Jul 2013 13:42:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4b9db3: SVN source step and Shell command support password... Message-ID: <51f18da2eacbd_1139120fd54102171@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4b9db3e64a47985675a2975bb8348a4bcbaf08b3 https://github.com/buildbot/buildbot/commit/4b9db3e64a47985675a2975bb8348a4bcbaf08b3 Author: Srinu P Date: 2013-07-25 (Thu, 25 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/cls-remotecommands.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- SVN source step and Shell command support password obfuscation. Fixes #2468, #1478 Commit: 3152107f23d6891263de7a89c7741dab8fbe3b84 https://github.com/buildbot/buildbot/commit/3152107f23d6891263de7a89c7741dab8fbe3b84 Author: Dustin J. Mitchell Date: 2013-07-25 (Thu, 25 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/cls-remotecommands.rst M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'bug2468-squash' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/9ec3f3a57ca9...3152107f23d6 From trac at buildbot.net Fri Jul 26 01:39:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 01:39:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2468: source.SVN doesn't obfuscate Subversion password In-Reply-To: <038.1701f17be2409a0a4c11aea03e7f3664@buildbot.net> References: <038.1701f17be2409a0a4c11aea03e7f3664@buildbot.net> Message-ID: <053.d44407fcd1ef130ac918297cf2a44873@buildbot.net> #2468: source.SVN doesn't obfuscate Subversion password -----------------------------------------+--------------------- Reporter: rutsky | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.7 | Resolution: fixed Keywords: master-side-source-steps svn | -----------------------------------------+--------------------- Changes (by srinup): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 01:41:07 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 01:41:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1748: Allow obfuscating passwords, etc. on the master In-Reply-To: <039.910168808e260ab34929252b74922c44@buildbot.net> References: <039.910168808e260ab34929252b74922c44@buildbot.net> Message-ID: <054.ce207478dce4324af9ada0b264007ddd@buildbot.net> #1748: Allow obfuscating passwords, etc. on the master ------------------------+--------------------- Reporter: GreYFoX | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.+ Version: 0.8.3 | Resolution: fixed Keywords: sprint | ------------------------+--------------------- Changes (by srinup): * cc: srinupiits@? (added) * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 01:44:02 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 01:44:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2465: "retry" option for checking out sources seems obsolete In-Reply-To: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> References: <040.483012c8218309e0c0edec5ed0d316ea@buildbot.net> Message-ID: <055.2439c2f1940f7a4f580afec70cccef43@buildbot.net> #2465: "retry" option for checking out sources seems obsolete --------------------------------------------+--------------------- Reporter: hwoarang | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: fixed Keywords: master-side-source-steps sprint | --------------------------------------------+--------------------- Changes (by srinup): * cc: srinupiits@? (added) * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 01:44:31 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 01:44:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2357: SVN source step does not support "retry" argument In-Reply-To: <038.85170ff4863b32d655e4491dc5924c44@buildbot.net> References: <038.85170ff4863b32d655e4491dc5924c44@buildbot.net> Message-ID: <053.1bc8a66e06bfe35f24337eb3b38627ac@buildbot.net> #2357: SVN source step does not support "retry" argument ------------------------------------------+--------------------- Reporter: flashm | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: fixed Keywords: svn, master-side-source-steps | ------------------------------------------+--------------------- Changes (by srinup): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 01:45:13 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 01:45:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2463: SVN export does not recieve username/password In-Reply-To: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> References: <038.012ecf9a0cfb80d9a112a76fea1222a2@buildbot.net> Message-ID: <053.92f34d1a27ca9e18e88870e143d26470@buildbot.net> #2463: SVN export does not recieve username/password ------------------------------------------+----------------------- Reporter: cscott | Owner: ShriramK Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: svn, master-side-source-steps | ------------------------------------------+----------------------- Changes (by srinup): * cc: srinupiits@? (added) * status: assigned => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 01:45:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 01:45:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2098: support for patches in master-side source steps In-Reply-To: <038.7bf88629819eaedd012609f66bc29db2@buildbot.net> References: <038.7bf88629819eaedd012609f66bc29db2@buildbot.net> Message-ID: <053.ec4ab53a36d413544e08e93b2fc32d7c@buildbot.net> #2098: support for patches in master-side source steps --------------------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: critical | Milestone: 0.8.+ Version: 0.8.4p2 | Resolution: fixed Keywords: master-side-source-steps sprint | --------------------------------------------+--------------------- Changes (by srinup): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 19:49:16 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 19:49:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing Message-ID: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing ------------------------+--------------------------------- Reporter: kkryger | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.6p1 | Keywords: svn, steps, windows ------------------------+--------------------------------- The issue is not fixing the reason for the failure to remove the directory, a process was holding onto a folder that the SVN step ('clobber') was attempting to delete. It's for a possible failure being added. It would be a nice addition that the SVN step would flag the exception below as a failure to checkout, instead of continuing on and reporting success. I also get this for WindowsError: [Error 5] The exceptions is below: {{{ starting svn operation exception from rmdirRecursive Traceback (most recent call last): File "C:\python25\lib\threading.py", line 462, in __bootstrap self.__bootstrap_inner() File "C:\python25\lib\threading.py", line 486, in __bootstrap_inner self.run() File "C:\python25\lib\threading.py", line 446, in run self.__target(*self.__args, **self.__kwargs) --- --- File "C:\Python25\lib\site-packages\twisted\python\threadpool.py", line 207, in _worker result = context.call(ctx, function, *args, **kwargs) File "C:\Python25\lib\site-packages\twisted\python\context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "C:\Python25\lib\site-packages\twisted\python\context.py", line 81, in callWithContext return func(*args,**kw) File "C:\Python25\lib\site- packages\buildbot_slave-0.8.6p1-py2.5.egg\buildslave\commands\utils.py", line 91, in rmdirRecursive rmdirRecursive(full_name) File "C:\Python25\lib\site- packages\buildbot_slave-0.8.6p1-py2.5.egg\buildslave\commands\utils.py", line 91, in rmdirRecursive rmdirRecursive(full_name) File "C:\Python25\lib\site- packages\buildbot_slave-0.8.6p1-py2.5.egg\buildslave\commands\utils.py", line 91, in rmdirRecursive rmdirRecursive(full_name) File "C:\Python25\lib\site- packages\buildbot_slave-0.8.6p1-py2.5.egg\buildslave\commands\utils.py", line 91, in rmdirRecursive rmdirRecursive(full_name) File "C:\Python25\lib\site- packages\buildbot_slave-0.8.6p1-py2.5.egg\buildslave\commands\utils.py", line 95, in rmdirRecursive os.remove(full_name) exceptions.WindowsError: [Error 32] The process cannot access the file because it is being used by another process: u'someFile.cpp' exception from rmdirRecursive }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Jul 26 22:22:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Jul 2013 22:22:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2532: Support using interlocks for sequences of steps In-Reply-To: <045.da71f29098b2fd32a7820a5290c3a83b@buildbot.net> References: <045.da71f29098b2fd32a7820a5290c3a83b@buildbot.net> Message-ID: <060.399847b969a098602615e442e864b727@buildbot.net> #2532: Support using interlocks for sequences of steps --------------------------+------------------------ Reporter: shirokuroneko | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | --------------------------+------------------------ Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 29 03:48:34 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 29 Jul 2013 03:48:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2504: Older Git Versions Don't Support --branch In-Reply-To: <041.aa2b3c897313323a81cc67f8e38875f4@buildbot.net> References: <041.aa2b3c897313323a81cc67f8e38875f4@buildbot.net> Message-ID: <056.b25760600b63ccf01dc1944b68cb3adc@buildbot.net> #2504: Older Git Versions Don't Support --branch -----------------------------------------+-------------------- Reporter: s0undt3ch | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: git master-side-source-steps | -----------------------------------------+-------------------- Comment (by srinup): Looks like it is more than 4 years old. @dustin We will still support it? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 29 03:49:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 29 Jul 2013 03:49:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2531: Git step fails, if workdir exists but isn't a git checkout. In-Reply-To: <042.2e717142f8d778004b389c50f2cfc5d5@buildbot.net> References: <042.2e717142f8d778004b389c50f2cfc5d5@buildbot.net> Message-ID: <057.4ba734abc5010341148da748742883d7@buildbot.net> #2531: Git step fails, if workdir exists but isn't a git checkout. -----------------------------------------+------------------------ Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Resolution: Keywords: git master-side-source-steps | -----------------------------------------+------------------------ Comment (by srinup): Now git source step has retry option(http://docs.buildbot.net/latest/manual/cfg-buildsteps.html#id3). If git checkout fail because of some reason it will remove the build directory and clone again. If the directory is created by buildbot I think it should be empty before clone. Can you please tell when(use case) the build directory is not empty before git tries to clone. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 29 14:03:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 29 Jul 2013 14:03:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 Message-ID: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 ----------------------+------------------------ Reporter: krf | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Keywords: regression ----------------------+------------------------ Just upgraded from 0.8.7 to 0.8.9-pre: Now I am getting this: 2013-07-29 15:44:44+0200 [-] Exception caught notifying of buildFinished event 2013-07-29 15:44:44+0200 [-] Unhandled Error Traceback (most recent call last): File "/home/build/opt/lib/python2.7/site- packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/build.py", line 307, in buildFinished w.callback(self) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "/home/build/opt/lib/python2.7/site- packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/builder.py", line 535, in _buildFinished w.buildFinished(name, s, results) File "/home/build/opt/lib/python2.7/site- packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/status_gerrit.py", line 96, in buildFinished message, verified, reviewed = self.reviewCB(builderName, build, result, self.reviewArg) exceptions.TypeError: customGerritReviewCB() takes exactly 5 arguments (4 given) This commit breaks compatibility for custom GerritStatusPush's reviewCB implementations when upgrading from 0.8.7 -> 0.8.8: commit 70002d7b24f5d32c1a4a3650c3b69e1509e164ba Author: Jacob Stultz Date: Fri Jul 27 17:23:29 2012 -0700 Add optional start callback to GerritStatusPush The source-incompatible change: (...) + message, verified, reviewed = self.reviewCB(builderName, build, result, self.reviewArg) (...) - message, verified, reviewed = self.reviewCB(builderName, build, result, self.status, self.reviewArg) This change is not listed in the release notes, so I'm assuming it is not wanted(?) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Jul 29 14:07:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 29 Jul 2013 14:07:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 In-Reply-To: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> References: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> Message-ID: <050.b58dc306fededde899dfb86f5a221387@buildbot.net> #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 -----------------------+------------------------ Reporter: krf | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: regression | -----------------------+------------------------ Comment (by krf): Whoops, sorry for not using WikiFormatting here. I forgot about that. Can't edit the description either, anymore. Maybe you should fix your Trac setup? :) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 30 05:21:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Jul 2013 05:21:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2537: nextSlave is given a list of slavebuilders, not slaves Message-ID: <040.005dd5df97fd32cf74de9f27497ffb67@buildbot.net> #2537: nextSlave is given a list of slavebuilders, not slaves ---------------------+----------------------- Reporter: LegNeato | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ---------------------+----------------------- nextSlave is given a list of slavebuilders, not slaves. The docs says it is slaves: http://buildbot.readthedocs.org/en/v0.8.7p1/manual/cfg-builders.html "The function is passed two arguments, the Builder object which is assigning a new job, and a list of BuildSlave objects. The function should return one of the BuildSlave objects, or None if none of the available slaves should be used" Also, returning a slavebuilder works just fine. Either the docs are wrong or this is a bug. Happy to put up a patch for either, just not sure what is expected. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 30 14:53:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Jul 2013 14:53:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2504: Older Git Versions Don't Support --branch In-Reply-To: <041.aa2b3c897313323a81cc67f8e38875f4@buildbot.net> References: <041.aa2b3c897313323a81cc67f8e38875f4@buildbot.net> Message-ID: <056.1d098ee9c7cdf5e35c0ac778f66c0209@buildbot.net> #2504: Older Git Versions Don't Support --branch -----------------------------------------+-------------------- Reporter: s0undt3ch | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: git master-side-source-steps | -----------------------------------------+-------------------- Comment (by srinup): http://docs.buildbot.net/current/manual/cfg-buildsteps.html#git. Apparently we support version 1.2.0 and later -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 30 22:22:33 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Jul 2013 22:22:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2530: RSS feed date is non-conformant with RFC822 In-Reply-To: <037.fc704cc34c23ca509e158c6d1b174e1c@buildbot.net> References: <037.fc704cc34c23ca509e158c6d1b174e1c@buildbot.net> Message-ID: <052.b30fae0d6b2b7f43710aae7cc603e5f8@buildbot.net> #2530: RSS feed date is non-conformant with RFC822 --------------------+------------------------ Reporter: voyta | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: fixed Keywords: | --------------------+------------------------ Changes (by clepple): * status: new => closed * resolution: => fixed Comment: The suggested fix works for me. Created a pull request: https://github.com/buildbot/buildbot/pull/806 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Jul 30 22:58:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Jul 2013 22:58:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2538: LibVirtSlave issues Message-ID: <035.33a8fa281980ccece13fa46eaa0dd40a@buildbot.net> #2538: LibVirtSlave issues -------------------+----------------------- Reporter: gg0 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: -------------------+----------------------- virtslave is a kvm vm. buildbot user can manage it successfully via virsh. Added "sid-hurd-i386" LibVirtSlave to c[slaves]. Added "sid-hurd-i386" builder with slavenames=["sid-hurd-i386"]. a) It complains they can't have same name: exceptions.RuntimeError: cannot have two services with same name 'sid- hurd-i386' Renamed builder. b) Build starts, I expect it fires up virtslave. I get: "Not accepting builds as existing domains not iterated" c) If I manually start slave, I get: "Slave sid-hurd-i386-0 received connection while not trying to substantiate." Tried 0.8.7p1, 0.8.8rc1 and 0.8.9pre git snapshot. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Jul 31 23:31:27 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 31 Jul 2013 23:31:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2529: GitPoller Splits Changed Files list on spaces instead of newline In-Reply-To: <046.60d91b58e38f9a67cbe67b8f9f1f33a5@buildbot.net> References: <046.60d91b58e38f9a67cbe67b8f9f1f33a5@buildbot.net> Message-ID: <061.d2c59c84cead9f8925e86614ad20539b@buildbot.net> #2529: GitPoller Splits Changed Files list on spaces instead of newline ---------------------------+------------------------ Reporter: Jeremy.Cornett | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------------+------------------------ Comment (by dustin): This looks great. Can you add a unit test to catch this situation? -- Ticket URL: Buildbot Buildbot: build/test automation