[Buildbot-commits] [buildbot/buildbot] 8b32e5: cli: removed unreachable code in scripts.runner

GitHub noreply at github.com
Tue Feb 26 01:17:46 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 8b32e52d2d9dd9a35683c1bdb51e13d7f2a4f8bb
      https://github.com/buildbot/buildbot/commit/8b32e52d2d9dd9a35683c1bdb51e13d7f2a4f8bb
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py

  Log Message:
  -----------
  cli: removed unreachable code in scripts.runner

Removed unreachable code in
scripts.runner.SendChangeOptions.postOptions() method. 'who' and
'master' are listed as required options for 'sendchange'
subcommand. The postOptions() will not be called unless both 'who'
and 'master' options are specified.


  Commit: 80d5819a20be6b80ef3795f3e148854e2127e12e
      https://github.com/buildbot/buildbot/commit/80d5819a20be6b80ef3795f3e148854e2127e12e
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  unit tests of invalid 'buildbot user' command's options

Unit tests on exception code paths in
scripts.runner.UserOptions.postOptions(). Check that various
invalid options combinations for 'buildbot user' subcommand
raises the usage.UsageError exception.


  Commit: 838dfdb6fc796aec8fdf47f5139b1dcfe704647d
      https://github.com/buildbot/buildbot/commit/838dfdb6fc796aec8fdf47f5139b1dcfe704647d
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py

  Log Message:
  -----------
  cli: broke-out code to validate master option into a function


  Commit: b19daf57d49b644a10d0ce79e75979e4aa12dfca
      https://github.com/buildbot/buildbot/commit/b19daf57d49b644a10d0ce79e75979e4aa12dfca
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  cli: validate master option for 'buildbot sendchange' command

If master (-m, --master) option is not valid, print user friendly
error message "master must have the form 'hostname:port'".


  Commit: 41f22d8be699523012f5e01b31027f5eae5717f1
      https://github.com/buildbot/buildbot/commit/41f22d8be699523012f5e01b31027f5eae5717f1
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  cli: validate master option for 'statuslog' and 'statusgui' commands

For 'buildbot statuslog' and 'buildbot statusgui' subcommands, validate
master (-m, --master) option. If not valid print user friendly
error message "master must have the form 'hostname:port'".


  Commit: 3d3c8bad8c7957b7b06658211d866432c4ad4ded
      https://github.com/buildbot/buildbot/commit/3d3c8bad8c7957b7b06658211d866432c4ad4ded
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  cli: validate master option for 'buildbot debugclient' command

If master (-m, --master) option is not valid, print user friendly
error message "master must have the form 'hostname:port'".


  Commit: 055896ae8bbfc29142032cf7a0c1a41c9dc38ae5
      https://github.com/buildbot/buildbot/commit/055896ae8bbfc29142032cf7a0c1a41c9dc38ae5
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  cli: validate master option for 'buildbot try' command

When connection type 'pb' is specified, check that master option
(-m, --master) is present and have valid syntax. If master is missing
or have invalid syntax, print user friendly error message.


  Commit: ede2a911e3229bf4bf2fa3180d6252a06adf082a
      https://github.com/buildbot/buildbot/commit/ede2a911e3229bf4bf2fa3180d6252a06adf082a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-02-25 (Mon, 25 Feb 2013)

  Changed paths:
    M master/buildbot/scripts/runner.py
    M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Merge branch 'cli-option-master' of git://github.com/elmirjagudin/buildbot


Compare: https://github.com/buildbot/buildbot/compare/2b1544684208...ede2a911e322


More information about the Commits mailing list