[Buildbot-commits] [buildbot/buildbot] 176d3f: BuildChooser: refactor (slave, breq) logic into str...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 176d3f17ad7eb2818e9a0864acf93b1e348688fa
      https://github.com/buildbot/buildbot/commit/176d3f17ad7eb2818e9a0864acf93b1e348688fa
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/config.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/build.py
    M master/buildbot/process/builder.py
    M master/buildbot/test/fake/fakedb.py
    M master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_process_builder.py
    M master/docs/developer/config.rst
    M master/docs/manual/cfg-builders.rst

  Log Message:
  -----------
  BuildChooser: refactor (slave,breq) logic into strategy object

 * moved the following logic from Builder to BuildChooser
   - slave choice
   - build choice
   - build merging
 * move the following logic from Builder to BuildRequestDistributor
   - managing the brid reclamation

The slave-choice logic now checks if slaves can grab build locks. Slaves that
can are preferred to slaves that cant.

Also adding a customization point that lets slaves to be chosen based on
particular builds; for example, a patch is coming that will add a ForceScheduler
parameter to force a build onto a particular buildslave.


  Commit: e2d18c201149005ca87fef13f5dd76da977ba204
      https://github.com/buildbot/buildbot/commit/e2d18c201149005ca87fef13f5dd76da977ba204
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/process/botmaster.py

  Log Message:
  -----------
  BuildChooser: Fix up comments


  Commit: 0b862a1ae55376d0cf518ff69d2033bfe7fd90f3
      https://github.com/buildbot/buildbot/commit/0b862a1ae55376d0cf518ff69d2033bfe7fd90f3
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/builder.py

  Log Message:
  -----------
  BuildChooser: minor enhancements


  Commit: c59d43d83cd7e34c60c893f0bf4b05fa988f7474
      https://github.com/buildbot/buildbot/commit/c59d43d83cd7e34c60c893f0bf4b05fa988f7474
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/builder.py
    M master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py
    M master/buildbot/test/unit/test_process_builder.py

  Log Message:
  -----------
  BuildChooser: address review comments; pyflakes too


  Commit: c3775cebdf9fd10d069cd14c78169dd2e5a73690
      https://github.com/buildbot/buildbot/commit/c3775cebdf9fd10d069cd14c78169dd2e5a73690
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/test/unit/test_process_build.py

  Log Message:
  -----------
  Fix pyflakes issue


  Commit: 432f73386934c522512cff93f33c65a436f58bac
      https://github.com/buildbot/buildbot/commit/432f73386934c522512cff93f33c65a436f58bac
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/process/botmaster.py

  Log Message:
  -----------
  BuildChooser: address review issues; beef up comments


  Commit: b286054f6597eacf38a68f2b6047c3a44c95fe89
      https://github.com/buildbot/buildbot/commit/b286054f6597eacf38a68f2b6047c3a44c95fe89
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/process/botmaster.py
    A master/buildbot/process/buildrequestdistributor.py
    R master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py
    A master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py

  Log Message:
  -----------
  Create process/buildrequestdistributor.py; move BRD from botmaster.py


  Commit: 894de08e6314f4f20f1cc14045ffbfc99f5e7824
      https://github.com/buildbot/buildbot/commit/894de08e6314f4f20f1cc14045ffbfc99f5e7824
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-02-19 (Tue, 19 Feb 2013)

  Changed paths:
    M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py

  Log Message:
  -----------
  BuildChooser: Fix up test comments a bit; fix one unit test broken by 'rejectedSlaves' rename in earlier patch


  Commit: f3825308db6a7260120b6f38cf3f0bc6e15303e1
      https://github.com/buildbot/buildbot/commit/f3825308db6a7260120b6f38cf3f0bc6e15303e1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-02-20 (Wed, 20 Feb 2013)

  Changed paths:
    M master/buildbot/config.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/build.py
    M master/buildbot/process/builder.py
    A master/buildbot/process/buildrequestdistributor.py
    M master/buildbot/test/fake/fakedb.py
    R master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_process_builder.py
    A master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py
    M master/docs/developer/config.rst
    M master/docs/manual/cfg-builders.rst

  Log Message:
  -----------
  Merge branch 'BuildChooser' of git://github.com/jaredgrubb/buildbot


  Commit: 37c1ea9754f7547d047175da1d14ac69fb07e8f2
      https://github.com/buildbot/buildbot/commit/37c1ea9754f7547d047175da1d14ac69fb07e8f2
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-02-20 (Wed, 20 Feb 2013)

  Changed paths:
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  update relnotes for pull 615


  Commit: 0aa4bdad330fcf7d21a632707dc5625a5c33ab17
      https://github.com/buildbot/buildbot/commit/0aa4bdad330fcf7d21a632707dc5625a5c33ab17
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-02-20 (Wed, 20 Feb 2013)

  Changed paths:
    M common/validate.sh

  Log Message:
  -----------
  fix relnote validation


Compare: https://github.com/buildbot/buildbot/compare/ee1b6d76904a...0aa4bdad330f