[Buildbot-commits] [Buildbot] #2186: github change_hook needs security by default

[Buildbot]

#2186: github change_hook needs security by default
------------------------------+--------------------
Reporter:  stefanha           |       Owner:
    Type:  enhancement        |      Status:  new
Priority:  critical           |   Milestone:  0.8.+
 Version:  0.8.5              |  Resolution:
Keywords:  github web sprint  |
------------------------------+--------------------

Comment (by clepple):

 Replying to [comment:3 tom.prince]:
 > I wonder if github hooks support HTTP basic auth? If they do, specifying
 a user/passwd in the url, and supporting it in buildbot is all that is
 required.

 It looks like they support HTTP basic auth now:
 https://help.github.com/articles/what-ip-addresses-does-github-use-that-i
 -should-whitelist#service-hook-ip-addresses

 I'm interested in taking a crack at this, but I haven't delved into User
 objects yet. Are they a good match for verifying Basic auth credentials?
 Any other items I should be aware of?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2186#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation