[Buildbot-commits] [buildbot/buildbot] fa06e8: fix: Correct DebCowbuilder handling for existing i...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: fa06e817ba1ad6e1f6aab310f49e833d3a6c3116
      https://github.com/buildbot/buildbot/commit/fa06e817ba1ad6e1f6aab310f49e833d3a6c3116
  Author: Alexandre Lissy <alissy at mandriva.com>
  Date:   2013-02-16 (Sat, 16 Feb 2013)

  Changed paths:
    M master/buildbot/steps/package/deb/pbuilder.py
    M master/buildbot/test/unit/test_steps_package_deb_pbuilder.py

  Log Message:
  -----------
  fix: Correct DebCowbuilder handling for existing images

In pull request #482 introducing the DebCowbuilder class, there is a
wrong assumption being made on the type of the file system entry holding
the chroot. While it is correct for the base pbuilder case that this
entry have to be a file, the cowbuilder case handles directories. But
the base class used by DebCowbuilder only checks for regular file.
Hence, it triggers an error in twistd.log and makes the step failing
after a first run.


  Commit: 7e36ecf76fc1cadc3794913ecf321f7cbdb5ef0b
      https://github.com/buildbot/buildbot/commit/7e36ecf76fc1cadc3794913ecf321f7cbdb5ef0b
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-02-17 (Sun, 17 Feb 2013)

  Changed paths:
    M master/buildbot/steps/package/deb/pbuilder.py
    M master/buildbot/test/unit/test_steps_package_deb_pbuilder.py

  Log Message:
  -----------
  Merge branch 'fix-cowbuilder' of git://github.com/lissyx/buildbot


Compare: https://github.com/buildbot/buildbot/compare/21ee2e35b71e...7e36ecf76fc1