[Buildbot-commits] [Buildbot] #2601: Properties sent by sendchange command are not used during build

[Buildbot trac]

#2601: Properties sent by sendchange command are not used during build
-----------------------+-------------------
Reporter:  jollyroger  |      Owner:
    Type:  defect      |     Status:  new
Priority:  major       |  Milestone:  0.9.+
 Version:  master      |   Keywords:
-----------------------+-------------------
 I use sendchange command to pass properties, but since nine release these
 are not used during build that causes KeyError:

 {{{
 2013-12-02 14:21:57+0200 [-] starting build <Build wheezy-backports at i386>
 using slave <SlaveBuilder build
 er=u'wheezy-backports at i386' slave=u'sid'>
 2013-12-02 14:21:57+0200 [-] acquireLocks(slave <BuildSlave u'sid'>, locks
 [])
 2013-12-02 14:21:57+0200 [-] starting build <Build wheezy-
 backports at i386>.. pinging the slave <SlaveBuild
 er builder=u'wheezy-backports at i386' slave=u'sid'>
 2013-12-02 14:21:57+0200 [-] sending ping
 2013-12-02 14:21:57+0200 [Broker,0,127.0.0.1] ping finished: success
 2013-12-02 14:21:57+0200 [-] <Build wheezy-backports at i386>.startBuild
 2013-12-02 14:21:57+0200 [-] BuildStep.failed; traceback follows
         Traceback (most recent call last):
         Failure: twisted.internet.defer.FirstError: FirstError[#14,
 [Failure instance: Traceback: <type 'exceptions.KeyError'>: 'deb-dsc'
         /usr/lib/python2.7/dist-
 packages/twisted/internet/defer.py:1070:_inlineCallbacks
 /home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/buildstep.py:260:startStep
 /home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py:200:render
 /home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py:159:render
         --- <exception caught here> ---
         /usr/lib/python2.7/dist-
 packages/twisted/internet/defer.py:137:maybeDeferred
 /home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py:311:getRenderingFor
 /home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py:268:__getitem__
 /home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py:86:__getitem__
         ]]

 2013-12-02 14:21:57+0200 [-] addCompleteLog(err.text)
 2013-12-02 14:21:57+0200 [-] addHTMLLog(err.html)
 2013-12-02 14:21:57+0200 [-]
 releaseLocks(<debbot.steps.source.debian.DebDsc object at
 0x7fcbfc06d250>): []
 2013-12-02 14:21:57+0200 [-] BuildStep.failed now firing callback
 2013-12-02 14:21:57+0200 [-] Unhandled error in Deferred:
 2013-12-02 14:21:57+0200 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks
             result = g.send(result)
           File
 "/home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/buildstep.py",
 line 260, in startStep
             d = self.build.render(getattr(self, renderable))
           File
 "/home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py",
 line 200, in render
             return props.render(value)
           File
 "/home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py",
 line 159, in render
             return defer.maybeDeferred(renderable.getRenderingFor, self)
         --- <exception caught here> ---
           File "/usr/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 137, in maybeDeferred
             result = f(*args, **kw)
           File
 "/home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py",
 line 311, in getRenderingFor
             s = self.fmtstring % pmap
           File
 "/home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py",
 line 268, in __getitem__
             rv = properties[key]
           File
 "/home/jollyroger/debian/packages/buildbot/0.9/buildbot/master/buildbot/process/properties.py",
 line 86, in __getitem__
             rv = self.properties[name][0]
         exceptions.KeyError: 'deb-dsc'

 2013-12-02 14:21:57+0200 [-]  step 'dget' complete: exception
 2013-12-02 14:21:57+0200 [-]  <Build wheezy-backports at i386>: build
 finished
 2013-12-02 14:21:57+0200 [-] releaseLocks(<BuildSlave u'sid'>): []
 }}}

 Here are the logs that indicate that change was accepted.

 {{{
 2013-12-02 14:21:42+0200 [Broker,1,127.0.0.1] perspective_addChange called
 2013-12-02 14:21:43+0200 [-] added change with revision 0.1.1-1 to
 database
 2013-12-02 14:21:43+0200 [-] added buildset 2 to database
 }}}

 Properties that were sent by changes are found in the database as well.

 I'm not sure if other properties are used or if other sources of
 properties data (builders, schedulers, slaves) are working because new web
 interface shows neither properties used in the build or passed with the
 change nor the build step that failed with an exception.

 Buildbot version: 0.8.8-1443-ga9ef2fc (the recent nine branch head)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2601>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation