[Buildbot-commits] [Buildbot] #2556: Master-Side SVN step applying "extra_args" to svn info

[Buildbot trac]

#2556: Master-Side SVN step applying "extra_args" to svn info
--------------------+------------------------
Reporter:  kkryger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.6p1  |  Resolution:
Keywords:           |
--------------------+------------------------

Comment (by jaredgrubb):

 The issue is that SVN._dovccmd always appends extra_args, no matter which
 command is being run, and that fails for this particular use case.

 I'm not sure the best way to solve this, but ideas I had while triaging
 this:

 * never add extra_args for the "svn info" command (probably via a new arg
 to _dovccmd). This is easiest solution I can think of, but may be too
 restrictive (are there useful extra args that we should allow for even svn
 info?)
 * if we think we need something more expressive, the extreme solution
 would be to make extra_args into a dict keyed on the svn-command. This
 feels too free-form and would be verbose to express, but it would solve
 the above issue and still allow a hook for extra args for "svn info".

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2556#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation