[Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly

[Buildbot trac]

#2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource
Correctly
------------------------------------------------+---------------------
Reporter:  jroo                                 |       Owner:
    Type:  defect                               |      Status:  closed
Priority:  major                                |   Milestone:  0.8.+
 Version:  0.8.7p1                              |  Resolution:  fixed
Keywords:  gerrit git master-side-source-steps  |
------------------------------------------------+---------------------

Comment (by jroo):

 I tested the new gerrit step and it seems to work fine for updates. But if
 the build slave clones (i.e. when the build slave runs for the first time)
 and the change is due to new review the slave does not get the correct
 commit for building.

 The following git clone is run:
 git clone --branch refs/changes/60/10760/2 <my-git-repo-url> .

 And the following warning is issued by git:
 warning: Remote branch refs/changes/60/10760/2 not found in upstream
 origin, using HEAD instead

 This is because the refs/changes/xx/yyy is not a branch and thus does not
 work for clone command.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2485#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation