[Buildbot-commits] [Buildbot] #739: HTML logs are included in pickles

[Buildbot trac]

#739: HTML logs are included in pickles
---------------------+--------------------
Reporter:  marcusl   |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.+
 Version:  0.7.12    |  Resolution:
Keywords:  sprint    |
---------------------+--------------------

Old description:

> I recently started adding HTML logs from my buildsystem to buildbot, and
> these are between 1 and 5 mb per buildstep.
>
> They do not seem to be compressed at all, so there is quite a lot of
> memory and disk-space taken up by these log files.
> (One of my masters is using 450mb)
>
> Having the logs gzipped would be neat, since they could then be sent raw
> to clients who accept gzipped html (most browsers nowadays).
>
> Either that, or we fold the HTML-log and text-log into a generic logging
> store (with mime-type or something).

New description:

 I recently started adding HTML logs from my buildsystem to buildbot, and
 these are between 1 and 5 mb per buildstep.

 They do not seem to be compressed at all, so there is quite a lot of
 memory and disk-space taken up by these log files.
 (One of my masters is using 450mb)

 Having the logs gzipped would be neat, since they could then be sent raw
 to clients who accept gzipped html (most browsers nowadays).

 Either that, or we fold the HTML-log and text-log into a generic logging
 store (with mime-type or something).

--

Comment (by dustin):

 That looks like an accurate reproduction of the bug!  I'm surprised that
 the HTML file doesn't exist, though - that makes it a little more complex
 to fix.  The patch would need to look in both locations for the HTML data,
 write the logfile out if it didn't already exist, and remove the HTML data
 from the stream written to the pickle.

 I'm in the process of removing this code for 'nine' anyway, so personally
 I don't feel motivated to work on a fix, but certainly others are welcome
 to do so!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/739#comment:11>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation