[Buildbot-commits] [buildbot/buildbot] b3c474: P4: Use config.error, instead of collecting errors...

Mon Aug 19 00:53:28 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: b3c474c8a960d8822d0330172ed1d7ae85d8c5f3
      https://github.com/buildbot/buildbot/commit/b3c474c8a960d8822d0330172ed1d7ae85d8c5f3
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-06-19 (Wed, 19 Jun 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  P4: Use config.error, instead of collecting errors by hand.

  Commit: f838d86fe563745123d56bf764dafd61ef3d52dc
      https://github.com/buildbot/buildbot/commit/f838d86fe563745123d56bf764dafd61ef3d52dc
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-06-19 (Wed, 19 Jun 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  P4: Use tools provided by CompositeStepMixin.

  Commit: ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3
      https://github.com/buildbot/buildbot/commit/ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3
  Author: Jared Grubb <jgrubb at apple.com>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/docs/developer/cls-iproperties.rst
    M master/docs/developer/cls-irenderable.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-properties.rst

  Log Message:
  -----------
  Docs: update some index references

  Commit: 789dedd66cf7b4064ce5f8ad0582717c336692ea
      https://github.com/buildbot/buildbot/commit/789dedd66cf7b4064ce5f8ad0582717c336692ea
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/buildbot/steps/source/repo.py
    M master/buildbot/test/unit/test_changes_gerritchangesource.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  repo codingStyle fixes

- repo step and unit tests are now pep8 compliant
- fixed camelCase for repo step parameters
- removed usage of properties as input of the step.
  Its now job of use to choose which property name he wants via renderable
- added test on repo download from changesource
- update doc and release notes

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>

  Commit: 75149f365576a97d2d7a486aab2aa00774991b28
      https://github.com/buildbot/buildbot/commit/75149f365576a97d2d7a486aab2aa00774991b28
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/buildbot/steps/source/repo.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  repo: add RepoDownloadsFromChangeSource renderable

Suggestion from Tom to put this away from the step code.
In cunjunction with FlattenList, this works well.

+ some more minor review handling

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>

  Commit: dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51
      https://github.com/buildbot/buildbot/commit/dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Update release notes.

  Commit: 1199199a3f4ce54a85a30f959ba5a4fee2f179db
      https://github.com/buildbot/buildbot/commit/1199199a3f4ce54a85a30f959ba5a4fee2f179db
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/buildbot/steps/source/repo.py
    M master/buildbot/test/unit/test_changes_gerritchangesource.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge branch 'repo-coding-style' into buildbot-0.8.8.

- repo step and unit tests are now pep8 compliant
- fixed camelCase for repo step parameters
- removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable
- added test on repo download from changesource
- update doc and release notes

  Commit: cc8913b76c4932465f496c7262a4afb81ec1fe78
      https://github.com/buildbot/buildbot/commit/cc8913b76c4932465f496c7262a4afb81ec1fe78
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/interfaces/test_remotecommand.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/introduction.rst
    M master/docs/relnotes/index.rst
    M slave/buildslave/commands/base.py
    M slave/buildslave/commands/shell.py
    M slave/buildslave/runprocess.py
    M slave/buildslave/test/fake/runprocess.py
    M slave/buildslave/test/unit/test_commands_shell.py
    M slave/buildslave/test/unit/test_runprocess.py

  Log Message:
  -----------
  Revert adding slave-side support for sudo.

Adding sudo to a command can easily be handled by on the master-side. Also,
different people will have different expectations, which a single argument
isn't enough to capture.

See https://github.com/fabric/fabric/issues/503 for some discussions.

This reverts commit b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e, reversing
changes made to d0cd62b6049759d89b09b1512dab2268132fd30d.

  Commit: 478c79fe9024826403a6ee08d152859181178bfd
      https://github.com/buildbot/buildbot/commit/478c79fe9024826403a6ee08d152859181178bfd
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M master/buildbot/process/factory.py
    M master/buildbot/test/unit/test_process_factory.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Add support for passing keyword arguments to BuildFactory.addStep.

This was supported in old versions of buildbot, but there wasn't a release that
supported both, making transitioning harder than necessary.

  Commit: 379603bc07b4ccef0993cedc025aeef1c63e5844
      https://github.com/buildbot/buildbot/commit/379603bc07b4ccef0993cedc025aeef1c63e5844
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/clients/tryclient.py
    M master/buildbot/process/buildrequestdistributor.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/test/unit/test_clients_sendchange.py
    M master/buildbot/test/unit/test_clients_tryclient.py
    M master/buildbot/test/unit/test_schedulers_trysched.py
    R master/buildbot/test/util/pbclient.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Revert 'try_client_available_builder_names'.

This added ad-hoc support for overriding `getAvaliableBuilderNames` in a
subclass of `TrySchedulerer`. But that support was undocumented and untested.

This reverts commit 46a81edbecee41e9042b7d1bbf928e13d59e618d, reversing
changes made to 9ec2372129b48842b5c3bc5e933b28ed728d46e3.

  Commit: 66f62be3dad57fcd7eb897807b5352c3e362e0ed
      https://github.com/buildbot/buildbot/commit/66f62be3dad57fcd7eb897807b5352c3e362e0ed
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/test/unit/test_process_build.py

  Log Message:
  -----------
  Use `assertTrue`/`assertFalse` instead of `assertIdentical` where appropriate.

  Commit: e8147cc53069f1c73f10b7ab49016f45a90d934a
      https://github.com/buildbot/buildbot/commit/e8147cc53069f1c73f10b7ab49016f45a90d934a
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/process/factory.py
    M master/buildbot/test/unit/test_process_factory.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge 'support-depercated-addStep': Add support for passing keyword arguments to BuildFactory.addStep.

We deprecated this in 0.8.6 and dropped support in 0.8.7. But 0.8.7 was the
first version to support not needing to use .addFactoryArguments. But, passing
keyword arguments to .addStep also avoid this.

  Commit: 7dfd05464983ca5c773f7764448a23968314a424
      https://github.com/buildbot/buildbot/commit/7dfd05464983ca5c773f7764448a23968314a424
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/test/regressions/test_shell_command_properties.py

  Log Message:
  -----------
  Don't use deprecated name SetProperty in regression tests.

  Commit: 3b1b6e600ca5c95961ec14dd56e602e1ca62408b
      https://github.com/buildbot/buildbot/commit/3b1b6e600ca5c95961ec14dd56e602e1ca62408b
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/status/web/baseweb.py
    M master/docs/manual/cfg-statustargets.rst

  Log Message:
  -----------
  Expose twisted.cred for change hook auth.

Twisted provides a rich interface for defining authentication. Use it
for defining change hook authorization, rather than just one specific
bit of it.

  Commit: 90e94e2b59711b99a8b7f7350433f50f8cd12a5e
      https://github.com/buildbot/buildbot/commit/90e94e2b59711b99a8b7f7350433f50f8cd12a5e
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/status/web/baseweb.py

  Log Message:
  -----------
  Also skip adding hook if it IUsernamePassword isn't supported.

  Commit: 3b2f3c7661f9a51e7e1eb208669092ca47f6f89e
      https://github.com/buildbot/buildbot/commit/3b2f3c7661f9a51e7e1eb208669092ca47f6f89e
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/docs/manual/cfg-statustargets.rst

  Log Message:
  -----------
  Link to twisted.cred documentation.

  Commit: 61a20da2a79c4c0c9318ee758f8fd2132899913f
      https://github.com/buildbot/buildbot/commit/61a20da2a79c4c0c9318ee758f8fd2132899913f
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/status/web/baseweb.py
    M master/docs/manual/cfg-statustargets.rst

  Log Message:
  -----------
  Merge 'web-auth':  Expose twisted.cred for change hook auth.

Twisted provides a rich interface for defining authentication. Use it
for defining change hook authorization, rather than just one specific
bit of it.

  Commit: a958a020650557375144783fe52e5e79719703b8
      https://github.com/buildbot/buildbot/commit/a958a020650557375144783fe52e5e79719703b8
  Author: Tom Prince <tom.prince at twistedmatrix.com>
  Date:   2013-07-13 (Sat, 13 Jul 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  Merge pull request #767 from tomprince/p4-cleanups

P4 cleanups

  Commit: 9b0598a8f52b646e06f32b8df53793e4de7d6a64
      https://github.com/buildbot/buildbot/commit/9b0598a8f52b646e06f32b8df53793e4de7d6a64
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M master/buildbot/process/build.py

  Log Message:
  -----------
  remove typo in builddir and workdir properties

  Commit: 66a6428df813f1eb9649860bb78151497eef14c6
      https://github.com/buildbot/buildbot/commit/66a6428df813f1eb9649860bb78151497eef14c6
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  - Removed "cmd = " as it's not being used.

  Commit: 3fd99955d710e3bd0ffd504edcc8547c21b07144
      https://github.com/buildbot/buildbot/commit/3fd99955d710e3bd0ffd504edcc8547c21b07144
  Author: Charles Lepple <clepple+buildbot at gmail.com>
  Date:   2013-07-30 (Tue, 30 Jul 2013)

  Changed paths:
    M master/buildbot/status/web/feeds.py

  Log Message:
  -----------
  status/web/feeds.py: fix pubDate format

A prior localization fix caused RFC822-style dates to be rendered as follows:

1, 23 7 2013 13:04:18 GMT

This implements the fix proposed in http://trac.buildbot.net/ticket/2530

  Commit: c69495157713f76ef60b2a23f0bf8de8255c2446
      https://github.com/buildbot/buildbot/commit/c69495157713f76ef60b2a23f0bf8de8255c2446
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-08-10 (Sat, 10 Aug 2013)

  Changed paths:
    M master/buildbot/status/web/base.py
    M master/buildbot/test/unit/test_status_web_base.py

  Log Message:
  -----------
  Generate correct relative paths even for pages in the root

Previous code generated '/' for the path to the root, which is not
relative and causes problems when changing paths with http proxies.
Fixes #2544.

  Commit: 2799d21d4ec2a58461c6dd606f2bb0d46655c71d
      https://github.com/buildbot/buildbot/commit/2799d21d4ec2a58461c6dd606f2bb0d46655c71d
  Author: Kevin Funk <kevin.funk at kdab.com>
  Date:   2013-08-10 (Sat, 10 Aug 2013)

  Changed paths:
    M master/buildbot/status/status_gerrit.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Patch for bug #2536

Fixes #2536

See http://trac.buildbot.net/ticket/2536

  Commit: 153d359de450dcf1f71142340d8b2f52093c4189
      https://github.com/buildbot/buildbot/commit/153d359de450dcf1f71142340d8b2f52093c4189
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-08-10 (Sat, 10 Aug 2013)

  Changed paths:
    M master/buildbot/status/web/feeds.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge branch 'bug2530' of git://github.com/clepple/buildbot into buildbot-0.8.8

  Commit: 8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4
      https://github.com/buildbot/buildbot/commit/8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4
  Author: Gabriele Giacone <1o5g4r8o at gmail.com>
  Date:   2013-08-10 (Sat, 10 Aug 2013)

  Changed paths:
    M master/buildbot/buildslave/libvirt.py

  Log Message:
  -----------
  Fix libvirt module load after internal module rename. Thanks Jc2k.

See #2538

  Commit: 755d0cb9edee00c3e2346b8a15613ebdd3f5c960
      https://github.com/buildbot/buildbot/commit/755d0cb9edee00c3e2346b8a15613ebdd3f5c960
  Author: Dominic Chen <d.c.ddcc at gmail.com>
  Date:   2013-08-10 (Sat, 10 Aug 2013)

  Changed paths:
    M master/buildbot/scripts/base.py

  Log Message:
  -----------
  set __file__ before calling execfile on tacFile for relocatable buildmasters

  Commit: 4a6c106dacb1734c2a234dcc159ecce476a9a29b
      https://github.com/buildbot/buildbot/commit/4a6c106dacb1734c2a234dcc159ecce476a9a29b
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-08-18 (Sun, 18 Aug 2013)

  Changed paths:
    M master/buildbot/buildslave/libvirt.py
    M master/buildbot/clients/tryclient.py
    M master/buildbot/process/buildrequestdistributor.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/factory.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/scripts/base.py
    M master/buildbot/status/status_gerrit.py
    M master/buildbot/status/web/base.py
    M master/buildbot/status/web/baseweb.py
    M master/buildbot/status/web/feeds.py
    M master/buildbot/steps/source/p4.py
    M master/buildbot/steps/source/repo.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/interfaces/test_remotecommand.py
    M master/buildbot/test/regressions/test_shell_command_properties.py
    M master/buildbot/test/unit/test_changes_gerritchangesource.py
    M master/buildbot/test/unit/test_clients_sendchange.py
    M master/buildbot/test/unit/test_clients_tryclient.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_process_factory.py
    M master/buildbot/test/unit/test_schedulers_trysched.py
    M master/buildbot/test/unit/test_status_web_base.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    R master/buildbot/test/util/pbclient.py
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-statustargets.rst
    M master/docs/manual/introduction.rst
    M master/docs/relnotes/0.8.8.rst
    M slave/buildslave/commands/base.py
    M slave/buildslave/commands/shell.py
    M slave/buildslave/runprocess.py
    M slave/buildslave/test/fake/runprocess.py
    M slave/buildslave/test/unit/test_commands_shell.py
    M slave/buildslave/test/unit/test_runprocess.py

  Log Message:
  -----------
  Merge branch 'buildbot-0.8.8'

Compare: https://github.com/buildbot/buildbot/compare/5c7625d4b07c...4a6c106dacb1