[Buildbot-commits] [Buildbot] #2542: GitPoller fails on branch not existing, but doesnt poll the other branches

[Buildbot trac]

#2542: GitPoller fails on branch not existing, but doesnt poll the other branches
----------------------+-----------------------
Reporter:  mlakewood  |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.7p1    |   Keywords:  GitPoller
----------------------+-----------------------
 Hi,

 My git poller is setup like so

 GitPoller(
         'git://192.168.1.118/repo/',
         workdir='gitpoller-workdir', branches=['master', 'develop',
 'something', 'feature'],
         pollinterval=30)

 No If one of these branches is not available. ie someone deleted the
 branch on the repository that we are polling, the we get the following
 error:

 2013-08-06 16:16:50+0800 [-] while polling for changes
         Traceback (most recent call last):
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 380, in callback
             self._startRunCallbacks(result)
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 488, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 575, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 1126, in gotResult
             _inlineCallbacks(r, g, deferred)
         --- <exception caught here> ---
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 1068, in _inlineCallbacks
             result = result.throwExceptionIntoGenerator(g)
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/python/failure.py", line 389, in
 throwExceptionIntoGenerator
             return g.throw(self.type, self.value, self.tb)
           File "/usr/local/lib/python2.7/dist-
 packages/buildbot/changes/gitpoller.py", line 109, in poll
             [self.repourl] + refspecs, path=self.workdir)
           File "/usr/local/lib/python2.7/dist-
 packages/twisted/internet/defer.py", line 575, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/local/lib/python2.7/dist-
 packages/buildbot/changes/gitpoller.py", line 238, in
 _convert_nonzero_to_failure
             % (code, stderr))
         exceptions.EnvironmentError: command failed with exit code 128:
 fatal: Couldn't find remote ref develop


 I think its good it throws this error. The issue I have is that it stops
 the other polling from continuing, So if you have a few branches and you
 delete one of them the entire buildbot setup stops working.

 What IMHO is that it loops through, fails for than branch, and continues
 with the others?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2542>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation