From trac at buildbot.net Thu Aug 1 02:03:04 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 01 Aug 2013 02:03:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2534: unify/remove duplicates naming of pollInterval vs pollinterval In-Reply-To: <042.32dda6ad0ac22002207fe947bbd42335@buildbot.net> References: <042.32dda6ad0ac22002207fe947bbd42335@buildbot.net> Message-ID: <057.c411ab265703f1dcbee6208339838dd7@buildbot.net> #2534: unify/remove duplicates naming of pollInterval vs pollinterval ------------------------+-------------------- Reporter: yarikoptic | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: docs | ------------------------+-------------------- Changes (by dustin): * keywords: => docs * type: undecided => enhancement * milestone: undecided => 0.8.+ Old description: > First spotted in GitPoller.__init__ interface reported in IPython > > ``` > GitPoller(self, repourl, branches=None, branch=None, workdir=None, > pollInterval=600, gitbin='git', usetimestamps=True, category=None, > project=None, pollinterval=-2, fetch_refspec=None, encoding='utf-8') > ``` > mention there are both pollInterval and pollinterval. > http://docs.buildbot.net/latest/manual/cfg-changesources.html#gitpoller > has only pollInterval for Git and Hg but pollinterval for > GoogleCodeAtomPoller New description: First spotted in GitPoller.__init__ interface reported in IPython {{{ GitPoller(self, repourl, branches=None, branch=None, workdir=None, pollInterval=600, gitbin='git', usetimestamps=True, category=None, project=None, pollinterval=-2, fetch_refspec=None, encoding='utf-8') }}} mention there are both pollInterval and pollinterval. http://docs.buildbot.net/latest/manual/cfg-changesources.html#gitpoller has only pollInterval for Git and Hg but pollinterval for GoogleCodeAtomPoller -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Aug 1 02:57:26 2013 From: noreply at github.com (GitHub) Date: Wed, 31 Jul 2013 19:57:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3c899b: fix bootstrap at version 2.3.2 Message-ID: <51f9ce961f4e4_2a0b73bd4c1565e6@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 3c899b047c7478dea7d7d024e2b1c64f31fbb0c6 https://github.com/buildbot/buildbot/commit/3c899b047c7478dea7d7d024e2b1c64f31fbb0c6 Author: Dustin J. Mitchell Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: M www/setup.py Log Message: ----------- fix bootstrap at version 2.3.2 From noreply at github.com Thu Aug 1 03:01:33 2013 From: noreply at github.com (GitHub) Date: Wed, 31 Jul 2013 20:01:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5a2b8e: Gerrit integration with Git on master side Message-ID: <51f9cf8d9026a_4a10137dd58120620@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5a2b8ee0b559712d6413100aeee49a42ec5cd0cf https://github.com/buildbot/buildbot/commit/5a2b8ee0b559712d6413100aeee49a42ec5cd0cf Author: Srinu P Date: 2013-07-30 (Tue, 30 Jul 2013) Changed paths: A master/buildbot/steps/source/gerrit.py A master/buildbot/test/unit/test_steps_source_gerrit.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Gerrit integration with Git on master side Commit: e4e40a26a634664169fcb78fcbe1d55ec0881806 https://github.com/buildbot/buildbot/commit/e4e40a26a634664169fcb78fcbe1d55ec0881806 Author: Dustin J. Mitchell Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: A master/buildbot/steps/source/gerrit.py A master/buildbot/test/unit/test_steps_source_gerrit.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2485-squash' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/3152107f23d6...e4e40a26a634 From noreply at github.com Thu Aug 1 03:10:12 2013 From: noreply at github.com (GitHub) Date: Wed, 31 Jul 2013 20:10:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] afae17: fix pyflakes Message-ID: <51f9d194e681f_4b0d13f5d581942c2@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: afae17b166df8e7a61a56ce2d6ffc9520ec8e090 https://github.com/buildbot/buildbot/commit/afae17b166df8e7a61a56ce2d6ffc9520ec8e090 Author: Dustin J. Mitchell Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_gerrit.py Log Message: ----------- fix pyflakes From trac at buildbot.net Thu Aug 1 03:28:33 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 01 Aug 2013 03:28:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.1acf8208cd2f7e28f3a9301156bc5cea@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+--------------------- Reporter: jroo | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: fixed Keywords: gerrit git master-side-source-steps | ------------------------------------------------+--------------------- Changes (by srinup): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Aug 1 15:35:46 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 01 Aug 2013 15:35:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2539: setting branch to a property in a Git step causes a TypeError Message-ID: <038.fd96bcc3a25eebaaf60115b797cff449@buildbot.net> #2539: setting branch to a property in a Git step causes a TypeError --------------------+----------------------- Reporter: dickon | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: --------------------+----------------------- I got a TypeError exception out of buildbot/steps/source/git.py since I was specifying a Property instance for the branch constructor parameter. The relevant part of my config was: fbuild.addStep(Git(name='checkout build-scripts',workdir='build/build- scripts', repourl=Interpolate('%(prop:git_base)s/xenclient/build- scripts.git'), branch=Property('tag'), alwaysUseLatest=True, progress=True)) I worked around this by subclassing Git and setting renderables=['repourl', 'branch']. The Git class only has renderables=['repourl']. At the time of writing: https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source/git.py: renderables = [ "repourl", "reference"] The backtrace is below: : sequence item 2: expected string, list found /usr/lib/python2.6/dist-packages/twisted/internet/defer.py, line 893 in _inlineCallbacks 891 result = result.throwExceptionIntoGenerator(g) 892 else: 893 result = g.send(result) 894 except StopIteration: Locals result False g /usr/local/lib/python2.6/dist-packages/buildbot/steps/source/git.py, line 171 in incremental 169 # if not updateable, do a full checkout 170 if not updatable: 171 yield self._doFull() 172 return Locals self updatable False /usr/local/lib/python2.6/dist-packages/buildbot/steps/source/git.py, line 393 in _doFull 391 392 def _doFull(self): 393 d = self._full() 394 def clobber(res): Locals self /usr/local/lib/python2.6/dist-packages/buildbot/steps/source/git.py, line 378 in _full 376 command.append('--progress') 377 378 d = self._dovccmd(command, not self.clobberOnFailure) 379 # If revision specified checkout that revision Self clobberOnFailure False Locals self command List instance @ 0x31c42d8 'clone' '--branch' List instance @ 0x308ac68 buildbot.process.properties.Property instance @ 0x308d170 'git://git.xci-test.com/xenclient/build-scripts.git' '.' '--progress' /usr/local/lib/python2.6/dist-packages/buildbot/steps/source/git.py, line 301 in _dovccmd 299 initialStdin=initialStdin) 300 cmd.useLog(self.stdio_log, False) 301 log.msg("Starting git command : git %s" % (" ".join(command), )) 302 d = self.runCommand(cmd) Self stdio_log buildbot.status.logfile.LogFile instance @ 0x31d09e0 Locals command List instance @ 0x31c42d8 'clone' '--branch' List instance @ 0x308ac68 buildbot.process.properties.Property instance @ 0x308d170 'git://git.xci-test.com/xenclient/build-scripts.git' '.' '--progress' initialStdin None self cmd buildbot.process.buildstep.RemoteShellCommand instance @ 0x31cb7e8 ], 'git://git .xci-test.com/xenclient/build-scripts.git', '.', '--progress']'> Globals log : sequence item 2: expected string, list found -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Aug 1 19:12:58 2013 From: noreply at github.com (GitHub) Date: Thu, 01 Aug 2013 12:12:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6784f5: Check git version for --branch support. Fixes #250... Message-ID: <51fab33a8412f_205bbe9d589349d@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6784f5f218393add82e8c352d9de8d82c76d5224 https://github.com/buildbot/buildbot/commit/6784f5f218393add82e8c352d9de8d82c76d5224 Author: Srinu P Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Check git version for --branch support. Fixes #2504 Commit: a5790f15b995b02d23db8e73c79d98a6c704160d https://github.com/buildbot/buildbot/commit/a5790f15b995b02d23db8e73c79d98a6c704160d Author: Dustin J. Mitchell Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Merge branch 'bug2504' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/afae17b166df...a5790f15b995 From trac at buildbot.net Thu Aug 1 23:54:05 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 01 Aug 2013 23:54:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2538: LibVirtSlave issues In-Reply-To: <035.33a8fa281980ccece13fa46eaa0dd40a@buildbot.net> References: <035.33a8fa281980ccece13fa46eaa0dd40a@buildbot.net> Message-ID: <050.486598b18cbf3da23aa9066e08aa949a@buildbot.net> #2538: LibVirtSlave issues -------------------+------------------------ Reporter: gg0 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | -------------------+------------------------ Comment (by gg0): Solved b) and c) by applying attached patch suggested by Jc2k to git master. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Aug 2 01:18:04 2013 From: noreply at github.com (GitHub) Date: Thu, 01 Aug 2013 18:18:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 03572e: fix error reporting in ClusteredService (patch by ... Message-ID: <51fb08cc7218d_1ce8128bd501440a7@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 03572e54fe845b958aefbcf3b3d654ab599ec504 https://github.com/buildbot/buildbot/commit/03572e54fe845b958aefbcf3b3d654ab599ec504 Author: Dustin J. Mitchell Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/util/service.py Log Message: ----------- fix error reporting in ClusteredService (patch by buck1) From trac at buildbot.net Fri Aug 2 01:16:54 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 02 Aug 2013 01:16:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2504: Older Git Versions Don't Support --branch In-Reply-To: <041.aa2b3c897313323a81cc67f8e38875f4@buildbot.net> References: <041.aa2b3c897313323a81cc67f8e38875f4@buildbot.net> Message-ID: <056.5c74b6a80ad866e200a556ea36a0d037@buildbot.net> #2504: Older Git Versions Don't Support --branch -----------------------------------------+--------------------- Reporter: s0undt3ch | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: fixed Keywords: git master-side-source-steps | -----------------------------------------+--------------------- Changes (by srinup): * cc: srinupiits@? (added) * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Aug 2 01:19:53 2013 From: noreply at github.com (GitHub) Date: Thu, 01 Aug 2013 18:19:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ca9a53: actually include the changesource connectors Message-ID: <51fb093992008_29981411d50159768@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: ca9a5343deb43ceb936cab0265c2a68a5745a381 https://github.com/buildbot/buildbot/commit/ca9a5343deb43ceb936cab0265c2a68a5745a381 Author: Dustin J. Mitchell Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/data/connector.py M master/buildbot/db/connector.py Log Message: ----------- actually include the changesource connectors From noreply at github.com Fri Aug 2 01:17:09 2013 From: noreply at github.com (GitHub) Date: Thu, 01 Aug 2013 18:17:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 57e653: Check git version for --branch support. Fixes #250... Message-ID: <51fb08955bfc_43ebca5d50126081@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 57e6532527a0f9bc6ba2ade554b1d01a692b2557 https://github.com/buildbot/buildbot/commit/57e6532527a0f9bc6ba2ade554b1d01a692b2557 Author: Srinu P Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_gerrit.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Check git version for --branch support. Fixes #2504 Commit: 31189748efc53c3faaa789a8d4ace6952c36ca1b https://github.com/buildbot/buildbot/commit/31189748efc53c3faaa789a8d4ace6952c36ca1b Author: Dustin J. Mitchell Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_gerrit.py Log Message: ----------- Merge branch 'bug2504' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/a5790f15b995...31189748efc5 From trac at buildbot.net Fri Aug 2 20:38:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 02 Aug 2013 20:38:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2540: Lots of ignored exceptions in buildbot Message-ID: <036.814ed66edb9dfe1f3d0dff19ce47126e@buildbot.net> #2540: Lots of ignored exceptions in buildbot ----------------------+----------------------- Reporter: buck | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- I've been bitten twice by ignored, unlogged exceptions in the "nine" branch preventing buildbot from running correctly. I did a quick scan and found a bunch of questionable exception handlers. As a bare minimum, these should log the exception. http://paste.pound-python.org/show/onIO4YLupocZ8IoOiQW9/ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Aug 2 20:40:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 02 Aug 2013 20:40:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2541: Lots of ignored exceptions in buildbot Message-ID: <036.bb7fc56ae19591023439f4394cdb3b45@buildbot.net> #2541: Lots of ignored exceptions in buildbot ----------------------+----------------------- Reporter: buck | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- I've been bitten twice by ignored, unlogged exceptions in the "nine" branch preventing buildbot from running correctly. I did a quick scan and found a bunch of questionable exception handlers. As a bare minimum, these should log the exception. http://paste.pound-python.org/show/onIO4YLupocZ8IoOiQW9/ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Aug 2 20:41:41 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 02 Aug 2013 20:41:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2541: Lots of ignored exceptions in buildbot In-Reply-To: <036.bb7fc56ae19591023439f4394cdb3b45@buildbot.net> References: <036.bb7fc56ae19591023439f4394cdb3b45@buildbot.net> Message-ID: <051.14b978a85a1bfef238e83f217f3f20ec@buildbot.net> #2541: Lots of ignored exceptions in buildbot ----------------------+------------------------ Reporter: buck | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by buck): Dup of #2540. My bad. Please close. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Aug 3 18:09:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 03 Aug 2013 18:09:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 In-Reply-To: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> References: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> Message-ID: <050.6ce716cdc40bab5983f455cf24233283@buildbot.net> #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 -------------------+-------------------- Reporter: krf | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: master | Resolution: Keywords: gerrit | -------------------+-------------------- Changes (by dustin): * keywords: regression => gerrit * type: undecided => defect * milestone: undecided => 0.8.8 Old description: > Just upgraded from 0.8.7 to 0.8.9-pre: > > Now I am getting this: > > 2013-07-29 15:44:44+0200 [-] Exception caught notifying > of > buildFinished event > 2013-07-29 15:44:44+0200 [-] Unhandled Error > Traceback (most recent call last): > File "/home/build/opt/lib/python2.7/site- > packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/build.py", > line 307, in buildFinished > w.callback(self) > File "/usr/local/lib/python2.7/dist- > packages/twisted/internet/defer.py", line 368, in callback > self._startRunCallbacks(result) > File "/usr/local/lib/python2.7/dist- > packages/twisted/internet/defer.py", line 464, in _startRunCallbacks > self._runCallbacks() > File "/usr/local/lib/python2.7/dist- > packages/twisted/internet/defer.py", line 551, in _runCallbacks > current.result = callback(current.result, *args, **kw) > --- --- > File "/home/build/opt/lib/python2.7/site- > packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/builder.py", > line 535, in _buildFinished > w.buildFinished(name, s, results) > File "/home/build/opt/lib/python2.7/site- > packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/status_gerrit.py", > line 96, in buildFinished > message, verified, reviewed = self.reviewCB(builderName, > build, result, self.reviewArg) > exceptions.TypeError: customGerritReviewCB() takes exactly 5 > arguments (4 given) > > This commit breaks compatibility for custom GerritStatusPush's reviewCB > implementations when upgrading from 0.8.7 -> 0.8.8: > > commit 70002d7b24f5d32c1a4a3650c3b69e1509e164ba > Author: Jacob Stultz > Date: Fri Jul 27 17:23:29 2012 -0700 > > Add optional start callback to GerritStatusPush > > The source-incompatible change: > (...) > + message, verified, reviewed = self.reviewCB(builderName, build, > result, self.reviewArg) > (...) > - message, verified, reviewed = self.reviewCB(builderName, > build, result, self.status, self.reviewArg) > > This change is not listed in the release notes, so I'm assuming it is not > wanted(?) New description: Just upgraded from 0.8.7 to 0.8.9-pre: Now I am getting this: {{{ 2013-07-29 15:44:44+0200 [-] Exception caught notifying of buildFinished event 2013-07-29 15:44:44+0200 [-] Unhandled Error Traceback (most recent call last): File "/home/build/opt/lib/python2.7/site- packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/build.py", line 307, in buildFinished w.callback(self) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "/home/build/opt/lib/python2.7/site- packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/builder.py", line 535, in _buildFinished w.buildFinished(name, s, results) File "/home/build/opt/lib/python2.7/site- packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/status_gerrit.py", line 96, in buildFinished message, verified, reviewed = self.reviewCB(builderName, build, result, self.reviewArg) exceptions.TypeError: customGerritReviewCB() takes exactly 5 arguments (4 given) }}} This commit breaks compatibility for custom GerritStatusPush's reviewCB implementations when upgrading from 0.8.7 -> 0.8.8: {{{ commit 70002d7b24f5d32c1a4a3650c3b69e1509e164ba Author: Jacob Stultz Date: Fri Jul 27 17:23:29 2012 -0700 Add optional start callback to GerritStatusPush }}} The source-incompatible change: {{{ (...) + message, verified, reviewed = self.reviewCB(builderName, build, result, self.reviewArg) (...) - message, verified, reviewed = self.reviewCB(builderName, build, result, self.status, self.reviewArg) }}} This change is not listed in the release notes, so I'm assuming it is not wanted(?) -- -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 6 08:48:18 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 06 Aug 2013 08:48:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2542: GitPoller fails on branch not existing, but doesnt poll the other branches Message-ID: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> #2542: GitPoller fails on branch not existing, but doesnt poll the other branches ----------------------+----------------------- Reporter: mlakewood | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: GitPoller ----------------------+----------------------- Hi, My git poller is setup like so GitPoller( 'git://192.168.1.118/repo/', workdir='gitpoller-workdir', branches=['master', 'develop', 'something', 'feature'], pollinterval=30) No If one of these branches is not available. ie someone deleted the branch on the repository that we are polling, the we get the following error: 2013-08-06 16:16:50+0800 [-] while polling for changes Traceback (most recent call last): File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 380, in callback self._startRunCallbacks(result) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 488, in _startRunCallbacks self._runCallbacks() File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 575, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 1126, in gotResult _inlineCallbacks(r, g, deferred) --- --- File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 1068, in _inlineCallbacks result = result.throwExceptionIntoGenerator(g) File "/usr/local/lib/python2.7/dist- packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/usr/local/lib/python2.7/dist- packages/buildbot/changes/gitpoller.py", line 109, in poll [self.repourl] + refspecs, path=self.workdir) File "/usr/local/lib/python2.7/dist- packages/twisted/internet/defer.py", line 575, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/local/lib/python2.7/dist- packages/buildbot/changes/gitpoller.py", line 238, in _convert_nonzero_to_failure % (code, stderr)) exceptions.EnvironmentError: command failed with exit code 128: fatal: Couldn't find remote ref develop I think its good it throws this error. The issue I have is that it stops the other polling from continuing, So if you have a few branches and you delete one of them the entire buildbot setup stops working. What IMHO is that it loops through, fails for than branch, and continues with the others? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 6 08:51:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 06 Aug 2013 08:51:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2542: GitPoller fails on branch not existing, but doesnt poll the other branches In-Reply-To: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> References: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> Message-ID: <056.148a53c994d4a84c2a2748238d6b4b15@buildbot.net> #2542: GitPoller fails on branch not existing, but doesnt poll the other branches ----------------------+------------------------ Reporter: mlakewood | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: GitPoller | ----------------------+------------------------ Changes (by mlakewood): * cc: underplank@? (added) Comment: Sorry, What I wanted to say on the last line is What IMHO is a better behavior is that it loops through the branches, fails for than branch, and continues with the others? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 6 15:30:09 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 06 Aug 2013 15:30:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.9a5fcbc70df1e11e94cedeea2743c884@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by cmumford): I did implement a workaround: {{{ @implementer(IRenderable) class StepDescription(object): def getRenderingFor(self, props): if props.hasProperty('test_build_num'): build_no = props['test_build_num'] else: build_no = '?' return ['Test %s' % build_no] def __getitem__(self, key): return unicode('') }}} And then just set the description of a BuildFactory step to a new instance of this renderable. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 6 17:57:51 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 06 Aug 2013 17:57:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2462: add a master-side p4 step In-Reply-To: <038.08192b7f2b9cb9b85648d0fcaf5876ee@buildbot.net> References: <038.08192b7f2b9cb9b85648d0fcaf5876ee@buildbot.net> Message-ID: <053.b8e1fa76d808b893402e09b2733b34ad@buildbot.net> #2462: add a master-side p4 step -----------------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: master | Resolution: fixed Keywords: p4, master-side-source-steps | -----------------------------------------+--------------------- Changes (by srinup): * cc: srinupiits@? (added) * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 7 00:14:28 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 07 Aug 2013 00:14:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2454: SiGHUP doesn't always work In-Reply-To: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> References: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> Message-ID: <054.cfb09f79df4ccc3e5a5f7682521e64df@buildbot.net> #2454: SiGHUP doesn't always work ----------------------------+---------------------- Reporter: virgilg | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: | ----------------------------+---------------------- Comment (by virgilg): I can repro this as follows: 1) save the attached script as e.g. test.py 2) comment and uncomment line 12: time.sleep(1) With time.sleep(1) uncommented, one cannot deliver a SIG to the process, since the MainThread is too busy inside the while True: loop and python is not really multithreaded. With time.sleep(1) commented out, handler() will get a chance to run. In our case, buildbot's MainThread is in this loop: file: buildbot/status/persistent_queue.py 224 def _findNext(self, id): while True: path = os.path.join(self.path, str(id)) if os.path.isfile(path): return id id += 1 return None I see it process a ton of "events" that never finish: events_company.com/11305023 Where do these events come from? What generates them? events_company.com/state is not the droid I'm looking for, is it? The other 6 threads are all stuck in threading.py: > thread List of active threads known to the debugger: No Tid Name State ----------------------------------------------- > 0 139697960785664 MainThread waiting at break point 1 139697837831936 PoolThread-DBThreadPool-1 running 2 139697149482752 PoolThread-DBThreadPool-2 running 3 139697787475712 PoolThread-twisted.internet.reactor-2 running 4 139697132697344 PoolThread-twisted.internet.reactor-1 running 5 139697111598848 PoolThread-DBThreadPool-5 running 6 139697119991552 PoolThread-DBThreadPool-4 running 7 139697141090048 PoolThread-DBThreadPool-3 running threading.py 242 try: # restore state no matter what (e.g., KeyboardInterrupt) if timeout is None: waiter.acquire() So therefore, SIGHUP will never be intercepted in the MainThread because of how tight st = os.stat(path) is in the above while True: loop. If we "wait" sending the SIGHUP until the queue has been processed, then it will be caught and honored. I think deferring the queue processing on a separate thread and leaving MainThread free to catch SIG would be a good thing to do here. But the real question is still unanswered: what generates those events and why aren't they eventually "consumed"? At what point is the queue empty? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 7 13:46:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 07 Aug 2013 13:46:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2543: GerritChangeSource should ignore incoming ref-updated events to refs/meta/config branch Message-ID: <035.5e0de5b2ec24d9461634834f9d00ea5f@buildbot.net> #2543: GerritChangeSource should ignore incoming ref-updated events to refs/meta/config branch --------------------+----------------------- Reporter: krf | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: --------------------+----------------------- The branch 'refs/meta/config' [1] contains some project specific rules for Gerrit. It's a branch that contains only a few config files for parametrizing Gerrit. There are no project-related source files. Gerrit sends out 'ref-updated' events for that branch and hence builds will be triggered in Buildbot if you configured the GerritChangeSource change source. This will of course fail, because this particular branch contains no source files. GerritChangeSource should ignore that branch completely, imo. [1] https://gerrit-review.googlesource.com/Documentation/prolog- cookbook.html -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 7 17:42:07 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 07 Aug 2013 17:42:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2454: SiGHUP doesn't always work In-Reply-To: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> References: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> Message-ID: <054.5e385e1184bc8810039dec53c89b02e8@buildbot.net> #2454: SiGHUP doesn't always work ----------------------------+---------------------- Reporter: virgilg | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: | ----------------------------+---------------------- Comment (by virgilg): Per stack.png I see no eventual.py being involved at all. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 7 17:49:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 07 Aug 2013 17:49:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2544: updated path_to_root fails for links from the root Message-ID: <038.946578b692a04cb5c64f579ea8e210ba@buildbot.net> #2544: updated path_to_root fails for links from the root -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: master | Keywords: web -------------------+------------------- If `request.prepath` has only one element in it, then the new `path_to_root` returns `"/"` instead of `""`. This isn't correct, as that is an absolute, not relative, URL. It should return `"./"` instead. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Aug 8 03:20:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 08 Aug 2013 03:20:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2545: dynamic buildsteps/buildstep detection Message-ID: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> #2545: dynamic buildsteps/buildstep detection ----------------------+----------------------- Reporter: vlovich | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- Having the build logic for a project live statically in a separate location from the project itself is problematic. If the project build steps change, then the buildbot script needs to be changed + all branches updated before they are re-built. We have a CI system where each branch is tested before being merged into master. Since build changes would happen on a separate branch, there's no way to review it without stopping the world so we can update the buildbot script. The workaround would be to just have buildbot call a single run.sh script that lives in the project, but that suffers from then hiding the individual steps that go into a build from buildbot. There needs to be a way for each particular build to be queried for the steps for that particular build. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Aug 8 03:25:27 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 08 Aug 2013 03:25:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2545: dynamic buildsteps/buildstep detection In-Reply-To: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> References: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> Message-ID: <054.c834d1ae2efb3629691771798532567b@buildbot.net> #2545: dynamic buildsteps/buildstep detection ----------------------+------------------------ Reporter: vlovich | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by vlovich): A simple approach might be the original run.sh idea, except the buildslave will export an environment variable BUILDSLAVE_PIPE with an fd that it had opened before spawning the step. BUILDSLAVE_PIPE is a simple-line oriented protocol where run.sh can write things like new_step="My Custom build step" log_file= step_started="Step name" step_finished=OK (or failed) Another alternative is for the buildslave to create a directory & export the path to it in BUILDSLAVE_STEPS or something like that. The script could then create log files there .log, .started, .finished. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Aug 9 07:22:59 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 09 Aug 2013 07:22:59 -0000 Subject: [Buildbot-commits] [Buildbot] #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log Message-ID: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log --------------------+----------------------- Reporter: chaica | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: hg --------------------+----------------------- hi guys, I do have a weird bug with buildbot 0.8.6p1 from Debian Wheezy, I can start bot buildbot master and buildbot slave but in my log when the mercurial hook is launched I do have the following error in the twistd.log of the buildbot master. {{{ 2013-08-09 01:27:57+0200 [HTTPChannel,3,82.67.197.68] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/twisted/web/http.py", line 773, in requestReceived self.process() File "/usr/lib/python2.7/dist-packages/twisted/web/server.py", line 132, in process self.render(resrc) File "/usr/lib/python2.7/dist-packages/twisted/web/server.py", line 167, in render body = resrc.render(self) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/base.py", line 326, in render d = defer.maybeDeferred(lambda : self.content(request, ctx)) --- --- File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 134, in maybeDeferred result = f(*args, **kw) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/base.py", line 326, in d = defer.maybeDeferred(lambda : self.content(request, ctx)) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/build.py", line 266, in content return template.render(**cxt) File "/usr/lib/python2.7/dist-packages/jinja2/environment.py", line 894, in render return self.environment.handle_exception(exc_info, True) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/templates/build.html", line 3, in top-level template code {% from "change_macros.html" import change with context %} File "/usr/lib/python2.7/dist- packages/buildbot/status/web/templates/layout.html", line 52, in top-level template code {%- block barecontent -%} File "/usr/lib/python2.7/dist- packages/buildbot/status/web/templates/layout.html", line 62, in block "barecontent" {%- block content -%} File "/usr/lib/python2.7/dist- packages/buildbot/status/web/templates/build.html", line 213, in block "content" {{ change(c.asDict()) }} File "/usr/lib/python2.7/dist- packages/buildbot/status/web/templates/change_macros.html", line 37, in template {%- else -%}{{ c.rev|revlink(c.repository) }} {%- endif -%} File "/usr/lib/python2.7/dist- packages/buildbot/status/web/base.py", line 659, in filter url = url_f(rev, repo) File "/usr/lib/python2.7/dist- packages/buildbot/status/web/base.py", line 567, in return lambda rev, repo: replace(rev, repo) File "/usr/lib/python2.7/dist-packages/buildbot/revlinks.py", line 54, in __call__ url = revlink(rev, repo) File "/usr/lib/python2.7/dist-packages/buildbot/revlinks.py", line 26, in __call__ m = url.match(repo) exceptions.TypeError: expected string or buffer }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Aug 9 07:33:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 09 Aug 2013 07:33:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log In-Reply-To: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> References: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> Message-ID: <053.d18115ea2b94466293eff23bf25384d1@buildbot.net> #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log --------------------+------------------------ Reporter: chaica | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: hg | --------------------+------------------------ Comment (by chaica): I forgot to add that in fact my setting was perfectly fine in 0.8.1, I upgrade to 0.8.6p1 and the bug appeared. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Aug 10 15:09:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 10 Aug 2013 15:09:22 -0000 Subject: [Buildbot-commits] [Buildbot] #751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out In-Reply-To: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net> References: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net> Message-ID: <054.5389c9bc02724d2eb9b88ca8478d9729@buildbot.net> #751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out -------------------------+----------------------- Reporter: Fabrice | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: kill, sprint | -------------------------+----------------------- Comment (by markberger): I opened a pull request for this ticket here: https://github.com/buildbot/buildbot/pull/824 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Aug 10 16:24:31 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 10 Aug 2013 16:24:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log In-Reply-To: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> References: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> Message-ID: <053.bcc210cc0eeb18cbe78072caddd87e86@buildbot.net> #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log --------------------+------------------------ Reporter: chaica | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: hg | --------------------+------------------------ Comment (by chaica): Had to rewrite the configuration file (master.cfg) to successfully migrate from 0.8.1 to 0.8.6p1 as far as I'm concerned and if it is ok for you, you can close this ticket. thanks for your time. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Aug 10 18:34:57 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 11:34:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] efd0d6: Fix StrictVersion issue Message-ID: <520687d16590c_2924aebd48103259@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: efd0d6a14683df2a0e08601da7dea5771fb18c6d https://github.com/buildbot/buildbot/commit/efd0d6a14683df2a0e08601da7dea5771fb18c6d Author: Srinu P Date: 2013-08-05 (Mon, 05 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Fix StrictVersion issue Commit: dbdc3293cd8f339a66f9cdb19d0aaf7bbc73f668 https://github.com/buildbot/buildbot/commit/dbdc3293cd8f339a66f9cdb19d0aaf7bbc73f668 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Merge branch 'bug2504-1' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/31189748efc5...dbdc3293cd8f From noreply at github.com Sat Aug 10 18:51:05 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 11:51:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 47ef75: Added Windows-specific buildsteps module. Message-ID: <52068b99a3a9c_29df10ebd4c660a8@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 47ef757bf9fa8244da7408c1e6af7f2d22e12372 https://github.com/buildbot/buildbot/commit/47ef757bf9fa8244da7408c1e6af7f2d22e12372 Author: ludovicchabant Date: 2013-05-07 (Tue, 07 May 2013) Changed paths: A master/buildbot/steps/mswin.py Log Message: ----------- Added Windows-specific buildsteps module. Right now it only contains a `Robocopy` step. Commit: bea09883783f56149fb978e1acfda2246b5b41da https://github.com/buildbot/buildbot/commit/bea09883783f56149fb978e1acfda2246b5b41da Author: ludovicchabant Date: 2013-05-08 (Wed, 08 May 2013) Changed paths: M master/buildbot/changes/p4poller.py Log Message: ----------- Ability to specify a timezone for a P4 server The Perforce server used with `P4Source` may be in a different time zone than the Buildbot master, which would cause, for example, changes to be displayed in the wrong place on the Waterfall display. This change lets you specify a timezone for the server. Changelist times will be converted from that timezone to the local timezone before being added to the Buildbot master. Commit: 926badd856f863af4ef4b881ea76f413fe7de035 https://github.com/buildbot/buildbot/commit/926badd856f863af4ef4b881ea76f413fe7de035 Author: ludovicchabant Date: 2013-05-09 (Thu, 09 May 2013) Changed paths: M master/buildbot/steps/mswin.py Log Message: ----------- Fixed Robocopy step status Robocopy actually returns a combination of flags to indicate success/warning/failure status. Commit: ff9404be98a7f2d4082fab0ac2a897dea2fc9090 https://github.com/buildbot/buildbot/commit/ff9404be98a7f2d4082fab0ac2a897dea2fc9090 Author: Ludovic Chabant Date: 2013-05-28 (Tue, 28 May 2013) Changed paths: M master/buildbot/steps/mswin.py Log Message: ----------- Added information about Robocopy exit codes. Commit: f3032198239393e66469d53b3d2753e2bbfd611c https://github.com/buildbot/buildbot/commit/f3032198239393e66469d53b3d2753e2bbfd611c Author: ludovicchabant Date: 2013-05-28 (Tue, 28 May 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Added documentation about Robocopy step. Commit: 41f865f110dd84a70a50196a775c226f2e39b5f1 https://github.com/buildbot/buildbot/commit/41f865f110dd84a70a50196a775c226f2e39b5f1 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/buildbot/steps/mswin.py Log Message: ----------- Removed docstring for Robocopy step. All usage information is only in the documentation page now. Commit: 6336819584472892651732e3e93a0d941ed5f1c7 https://github.com/buildbot/buildbot/commit/6336819584472892651732e3e93a0d941ed5f1c7 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- Documentation about timezone support in P4 changesource Commit: f915175d48680e49c4a09e4b020a61123b9b3c79 https://github.com/buildbot/buildbot/commit/f915175d48680e49c4a09e4b020a61123b9b3c79 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Release notes for Robocopy and P4 changes. Commit: 2bc2399d5ec2861ac8fda42402d73e55eedbb71a https://github.com/buildbot/buildbot/commit/2bc2399d5ec2861ac8fda42402d73e55eedbb71a Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Fixed P4 source unit tests on Windows This is because P4 normalizes slashes/backslashes, so we need to set our expectations right. Commit: 13b870b7dbb071f70ab685992c18e4ff2efd4a96 https://github.com/buildbot/buildbot/commit/13b870b7dbb071f70ab685992c18e4ff2efd4a96 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/buildbot/steps/mswin.py A master/buildbot/test/unit/test_steps_mswin.py Log Message: ----------- Added unit tests for Robocopy step. Fixed whitespace. Commit: 8f2e82a1fe3d3cb8b64cc6c72178f429c5cebede https://github.com/buildbot/buildbot/commit/8f2e82a1fe3d3cb8b64cc6c72178f429c5cebede Author: Ludovic Chabant Date: 2013-07-04 (Thu, 04 Jul 2013) Changed paths: M master/buildbot/steps/mswin.py M master/buildbot/test/unit/test_steps_mswin.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Don't pass `/UNICODE` to Robocopy by default. Commit: 1800e21c86ef79d5616ed1f4c1db04dd1dadb10a https://github.com/buildbot/buildbot/commit/1800e21c86ef79d5616ed1f4c1db04dd1dadb10a Author: Ludovic Chabant Date: 2013-07-04 (Thu, 04 Jul 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Added more information about Robocopy in the docs. Commit: 99b38cd99afb854a52ecb579c2fb439a1d2291e9 https://github.com/buildbot/buildbot/commit/99b38cd99afb854a52ecb579c2fb439a1d2291e9 Author: Ludovic Chabant Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Fixed 2.5 incompatibility in p4 tests Commit: 44c52eb4d83d56c0195a94478ccd7b4fa072ed59 https://github.com/buildbot/buildbot/commit/44c52eb4d83d56c0195a94478ccd7b4fa072ed59 Author: Ludovic Chabant Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/test/unit/test_changes_p4poller.py Log Message: ----------- Fixed p4 poller tests Commit: f465a19a69530ffb11e2238e3e2b1b060353e0aa https://github.com/buildbot/buildbot/commit/f465a19a69530ffb11e2238e3e2b1b060353e0aa Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/steps/mswin.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_steps_mswin.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- fix bugs in handling unkown return codes, pyflakes ..and return Deferreds from test methods. Commit: 86d8ba49c19a4099a30fe0584cc0419fc1afadff https://github.com/buildbot/buildbot/commit/86d8ba49c19a4099a30fe0584cc0419fc1afadff Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/changes/p4poller.py A master/buildbot/steps/mswin.py M master/buildbot/test/unit/test_changes_p4poller.py A master/buildbot/test/unit/test_steps_mswin.py M master/buildbot/test/unit/test_steps_source_p4.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pull728' Compare: https://github.com/buildbot/buildbot/compare/dbdc3293cd8f...86d8ba49c19a From noreply at github.com Sat Aug 10 19:35:43 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 12:35:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c69495: Generate correct relative paths even for pages in ... Message-ID: <5206960f1cc3c_148c8cdd5493d0@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: c69495157713f76ef60b2a23f0bf8de8255c2446 https://github.com/buildbot/buildbot/commit/c69495157713f76ef60b2a23f0bf8de8255c2446 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/base.py M master/buildbot/test/unit/test_status_web_base.py Log Message: ----------- Generate correct relative paths even for pages in the root Previous code generated '/' for the path to the root, which is not relative and causes problems when changing paths with http proxies. Fixes #2544. From trac at buildbot.net Sat Aug 10 19:36:03 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 10 Aug 2013 19:36:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2544: updated path_to_root fails for links from the root In-Reply-To: <038.946578b692a04cb5c64f579ea8e210ba@buildbot.net> References: <038.946578b692a04cb5c64f579ea8e210ba@buildbot.net> Message-ID: <053.1949414b0d76641a77ebe283bb35c403@buildbot.net> #2544: updated path_to_root fails for links from the root -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: master | Resolution: fixed Keywords: web | -------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Fixed in 0.8.8: {{{ commit c69495157713f76ef60b2a23f0bf8de8255c2446 Author: Dustin J. Mitchell Date: Sat Aug 10 15:32:54 2013 -0400 Generate correct relative paths even for pages in the root Previous code generated '/' for the path to the root, which is not relative and causes problems when changing paths with http proxies. Fixes #2544. }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Aug 10 19:42:01 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 12:42:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d99f53: new pylint configuration Message-ID: <520697891fe8e_2906f93d506519@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d99f53b0f5a32caa0a79817657fc2be8f09bea54 https://github.com/buildbot/buildbot/commit/d99f53b0f5a32caa0a79817657fc2be8f09bea54 Author: Elmir Jagudin Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: M common/pylintrc Log Message: ----------- new pylint configuration * disable all currently reported messages * document checks that we don't care about * tweaked symbol name regexps to match buildbot's style Commit: a5dbf75b8e615c6d05e6fe0b8e6d5a1f8f35e037 https://github.com/buildbot/buildbot/commit/a5dbf75b8e615c6d05e6fe0b8e6d5a1f8f35e037 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M common/pylintrc Log Message: ----------- Merge branch 'pylint' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/86d8ba49c19a...a5dbf75b8e61 From noreply at github.com Sat Aug 10 19:45:38 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 12:45:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 45430e: Fix buildslave init script errors saying "buildmas... Message-ID: <5206986271644_159eb6dd485473c@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 45430e1e670b9cd43666f4bf6e6c1f2a30733255 https://github.com/buildbot/buildbot/commit/45430e1e670b9cd43666f4bf6e6c1f2a30733255 Author: ????? ???????? Date: 2013-07-20 (Sat, 20 Jul 2013) Changed paths: M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Fix buildslave init script errors saying "buildmaster" Also, change ${i} to ${index} for consistency with surrounding code. Commit: d6bf7573cd3d182dc1f169206b38171e8a5660f6 https://github.com/buildbot/buildbot/commit/d6bf7573cd3d182dc1f169206b38171e8a5660f6 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Merge branch 'slave-not-master' of git://github.com/SpecLad/buildbot Compare: https://github.com/buildbot/buildbot/compare/a5dbf75b8e61...d6bf7573cd3d From noreply at github.com Sat Aug 10 19:45:55 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 12:45:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2753fc: more explicit description of symbol styles Message-ID: <52069873e78cc_29ca13f1d4889642@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2753fc4e79b0a530945d67f3272c287323c0756c https://github.com/buildbot/buildbot/commit/2753fc4e79b0a530945d67f3272c287323c0756c Author: Dustin J. Mitchell Date: 2013-04-24 (Wed, 24 Apr 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- more explicit description of symbol styles Commit: 5584042f8a0e398c0ad597ed40cdc61341333042 https://github.com/buildbot/buildbot/commit/5584042f8a0e398c0ad597ed40cdc61341333042 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- Merge branch 'symbol-style' of git://github.com/djmitche/buildbot Compare: https://github.com/buildbot/buildbot/compare/d6bf7573cd3d...5584042f8a0e From noreply at github.com Sat Aug 10 19:59:58 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 12:59:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 28ddd0: Add RevlinkMatch for new SourceForge platform Message-ID: <52069bbe652a1_181d7cdd509648@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 28ddd095e3295ec9d74b3fe56ac77a3e782f4958 https://github.com/buildbot/buildbot/commit/28ddd095e3295ec9d74b3fe56ac77a3e782f4958 Author: Kevin Funk Date: 2013-07-22 (Mon, 22 Jul 2013) Changed paths: M master/buildbot/revlinks.py M master/buildbot/test/unit/test_revlinks.py Log Message: ----------- Add RevlinkMatch for new SourceForge platform Also add tests Commit: 38ee978cc0e5a9e1e9eda5ef80f0e56fcf9a80ab https://github.com/buildbot/buildbot/commit/38ee978cc0e5a9e1e9eda5ef80f0e56fcf9a80ab Author: Kevin Funk Date: 2013-07-22 (Mon, 22 Jul 2013) Changed paths: M master/buildbot/test/unit/test_revlinks.py Log Message: ----------- Improve coverage: Add test for RevlinkMultiplexer Commit: 15dd0f1805cd514d6fbc47bb56bde808d8eb01db https://github.com/buildbot/buildbot/commit/15dd0f1805cd514d6fbc47bb56bde808d8eb01db Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/revlinks.py M master/buildbot/test/unit/test_revlinks.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'add-sourceforge_allura-revlinkmatch' of git://github.com/krf/buildbot Compare: https://github.com/buildbot/buildbot/compare/5584042f8a0e...15dd0f1805cd From noreply at github.com Sat Aug 10 20:00:28 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 13:00:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5c5c29: Minor: Improve debugging output in words.py Message-ID: <52069bdc16fb7_2d4ed1bd486155f@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5c5c2961cb94b3ce44be77e4e9ba26bc4d9b02e0 https://github.com/buildbot/buildbot/commit/5c5c2961cb94b3ce44be77e4e9ba26bc4d9b02e0 Author: Kevin Funk Date: 2013-07-29 (Mon, 29 Jul 2013) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Minor: Improve debugging output in words.py Commit: 7d6df157dd284c8b655becaedb90cf137cd97dd7 https://github.com/buildbot/buildbot/commit/7d6df157dd284c8b655becaedb90cf137cd97dd7 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Merge branch 'small-fixes' of git://github.com/krf/buildbot Compare: https://github.com/buildbot/buildbot/compare/15dd0f1805cd...7d6df157dd28 From noreply at github.com Sat Aug 10 20:03:16 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 13:03:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2799d2: Patch for bug #2536 Message-ID: <52069c84dc004_2965ac1d5458723@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 2799d21d4ec2a58461c6dd606f2bb0d46655c71d https://github.com/buildbot/buildbot/commit/2799d21d4ec2a58461c6dd606f2bb0d46655c71d Author: Kevin Funk Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/status_gerrit.py M master/docs/relnotes/index.rst Log Message: ----------- Patch for bug #2536 Fixes #2536 See http://trac.buildbot.net/ticket/2536 From noreply at github.com Sat Aug 10 20:10:14 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 13:10:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3a5631: logs: implement on the fly parsing of ansi code Message-ID: <52069e26617f4_29df10ebd4c67828@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3a563189374737aa2ebf3f6467bf461bc3ec5443 https://github.com/buildbot/buildbot/commit/3a563189374737aa2ebf3f6467bf461bc3ec5443 Author: Pierre Tardy Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/status/web/files/default.css M master/buildbot/status/web/logs.py Log Message: ----------- logs: implement on the fly parsing of ansi code grunt and js tools have the habit of using ansi code a lot, which are ugly inside python log window. http://en.wikipedia.org/wiki/ANSI_escape_code This is a simple enough implementation of ansicode parser which integrates well into buildbot's way of displaying logs Signed-off-by: Pierre Tardy Commit: c94cd9abb0a166d71cc73953ccec589b67bc2e81 https://github.com/buildbot/buildbot/commit/c94cd9abb0a166d71cc73953ccec589b67bc2e81 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/files/default.css M master/buildbot/status/web/logs.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'ansicodes' of git://github.com/tardyp/buildbot Compare: https://github.com/buildbot/buildbot/compare/7d6df157dd28...c94cd9abb0a1 From trac at buildbot.net Sat Aug 10 20:14:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 10 Aug 2013 20:14:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 In-Reply-To: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> References: <035.eeff5d88e7a310534d32ffc871ec980d@buildbot.net> Message-ID: <050.a48ddce443197b5f94e49da835d5de52@buildbot.net> #2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8 -------------------+--------------------- Reporter: krf | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: master | Resolution: fixed Keywords: gerrit | -------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Fixed in 0.8.8 - Thanks, krf! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Aug 10 20:15:10 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 13:15:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3fd999: status/web/feeds.py: fix pubDate format Message-ID: <52069f4e2a615_2a3a1487d48339a7@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 3fd99955d710e3bd0ffd504edcc8547c21b07144 https://github.com/buildbot/buildbot/commit/3fd99955d710e3bd0ffd504edcc8547c21b07144 Author: Charles Lepple Date: 2013-07-30 (Tue, 30 Jul 2013) Changed paths: M master/buildbot/status/web/feeds.py Log Message: ----------- status/web/feeds.py: fix pubDate format A prior localization fix caused RFC822-style dates to be rendered as follows: 1, 23 7 2013 13:04:18 GMT This implements the fix proposed in http://trac.buildbot.net/ticket/2530 Commit: 153d359de450dcf1f71142340d8b2f52093c4189 https://github.com/buildbot/buildbot/commit/153d359de450dcf1f71142340d8b2f52093c4189 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/feeds.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2530' of git://github.com/clepple/buildbot into buildbot-0.8.8 Compare: https://github.com/buildbot/buildbot/compare/2799d21d4ec2...153d359de450 From noreply at github.com Sat Aug 10 20:19:04 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 13:19:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3e7411: Buildbot interrupts master-side source steps. Fixe... Message-ID: <5206a038e8fdd_24f71067d58487f4@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3e741154f7dfccbce33d2109c3b6f2b9c069fbdf https://github.com/buildbot/buildbot/commit/3e741154f7dfccbce33d2109c3b6f2b9c069fbdf Author: Srinu P Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/unit/test_process_buildstep.py Log Message: ----------- Buildbot interrupts master-side source steps. Fixes #2356 Commit: d04cd8bee344244333d5b6205db28077c1cbddcd https://github.com/buildbot/buildbot/commit/d04cd8bee344244333d5b6205db28077c1cbddcd Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2356-1' of git://github.com/srinupiits/buildbot Compare: https://github.com/buildbot/buildbot/compare/c94cd9abb0a1...d04cd8bee344 From noreply at github.com Sat Aug 10 21:25:09 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 14:25:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8e01ed: gitorious change hook dialect Message-ID: <5206afb5bdc60_1642c33d547417a@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8e01ed68c1ae84c2345e79d4b6be076865e4e8ed https://github.com/buildbot/buildbot/commit/8e01ed68c1ae84c2345e79d4b6be076865e4e8ed Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: A master/buildbot/status/web/hooks/gitorious.py Log Message: ----------- gitorious change hook dialect Commit: 1302fc6941cb10e3cb9b450ec84296027140c53d https://github.com/buildbot/buildbot/commit/1302fc6941cb10e3cb9b450ec84296027140c53d Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: A master/buildbot/test/unit/test_status_web_hooks_gitorious.py Log Message: ----------- gitorious test cases Commit: 6f4f3e48b09d7ee2a3a234e8e713c214087d7c98 https://github.com/buildbot/buildbot/commit/6f4f3e48b09d7ee2a3a234e8e713c214087d7c98 Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- gitorious web hook docs Commit: 5955deb57d7b352b7c259837fcb2452e7e97226f https://github.com/buildbot/buildbot/commit/5955deb57d7b352b7c259837fcb2452e7e97226f Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/status/web/hooks/gitorious.py M master/docs/relnotes/index.rst Log Message: ----------- removed docstrings from gitorious.py and added relnotes Commit: 517d485a54552d165f970941330cab620a36d0a4 https://github.com/buildbot/buildbot/commit/517d485a54552d165f970941330cab620a36d0a4 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: A master/buildbot/status/web/hooks/gitorious.py A master/buildbot/test/unit/test_status_web_hooks_gitorious.py M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'buildbot-gitorious-hook' of git://github.com/kviktor/buildbot Conflicts: master/docs/relnotes/index.rst Compare: https://github.com/buildbot/buildbot/compare/d04cd8bee344...517d485a5455 From noreply at github.com Sat Aug 10 21:25:34 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 14:25:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7f472e: tweak gitignore of vim swap files Message-ID: <5206afce872cb_2a1a9cbd504887b@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7f472e329d8bf9d3abdf17b6d239afbe014c2f7f https://github.com/buildbot/buildbot/commit/7f472e329d8bf9d3abdf17b6d239afbe014c2f7f Author: Buck Golemon Date: 2013-08-02 (Fri, 02 Aug 2013) Changed paths: M .gitignore Log Message: ----------- tweak gitignore of vim swap files Commit: 016178a600c019c4e0f42f2461713882dbe7368a https://github.com/buildbot/buildbot/commit/016178a600c019c4e0f42f2461713882dbe7368a Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M .gitignore Log Message: ----------- Merge branch 'master-buck' of git://github.com/bukzor/buildbot Compare: https://github.com/buildbot/buildbot/compare/517d485a5455...016178a600c0 From noreply at github.com Sat Aug 10 21:39:29 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 14:39:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8c27b4: Fix libvirt module load after internal module rena... Message-ID: <5206b311d903_1820b31d4881184@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4 https://github.com/buildbot/buildbot/commit/8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4 Author: Gabriele Giacone <1o5g4r8o at gmail.com> Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/buildslave/libvirt.py Log Message: ----------- Fix libvirt module load after internal module rename. Thanks Jc2k. See #2538 From noreply at github.com Sat Aug 10 21:40:24 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 14:40:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 334d5a: fix up TempSourceStamp.asDict so that TriggerStep ... Message-ID: <5206b3484598e_2a3a1487d4835745@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 334d5aa9e22873db92894400cabc1da47dcf937a https://github.com/buildbot/buildbot/commit/334d5aa9e22873db92894400cabc1da47dcf937a Author: Buck Golemon Date: 2013-08-02 (Fri, 02 Aug 2013) Changed paths: M master/buildbot/process/buildrequest.py Log Message: ----------- fix up TempSourceStamp.asDict so that TriggerStep can succeed Commit: bda1c6dbcbae91caa7f9e19b1d8d3b69ea329cb1 https://github.com/buildbot/buildbot/commit/bda1c6dbcbae91caa7f9e19b1d8d3b69ea329cb1 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/buildrequest.py Log Message: ----------- Merge branch 'buck-tempsourcestamp-asdict' of git://github.com/bukzor/buildbot into nine Compare: https://github.com/buildbot/buildbot/compare/ca9a5343deb4...bda1c6dbcbae From trac at buildbot.net Sat Aug 10 21:41:07 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 10 Aug 2013 21:41:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2356: Buildbot doesn't interrupt master-side source steps In-Reply-To: <038.b3c924236585f33303ff27706d58cee3@buildbot.net> References: <038.b3c924236585f33303ff27706d58cee3@buildbot.net> Message-ID: <053.70716a872291f6751ec43f9606811a55@buildbot.net> #2356: Buildbot doesn't interrupt master-side source steps -------------------------------------+--------------------- Reporter: flashm | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.8 Version: 0.8.6p1 | Resolution: fixed Keywords: master-side-source-steps | -------------------------------------+--------------------- Changes (by srinup): * cc: srinupiits@? (added) * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Aug 10 21:47:51 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 14:47:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 755d0c: set __file__ before calling execfile on tacFile fo... Message-ID: <5206b5073cdc0_75944bdd54195d3@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 755d0cb9edee00c3e2346b8a15613ebdd3f5c960 https://github.com/buildbot/buildbot/commit/755d0cb9edee00c3e2346b8a15613ebdd3f5c960 Author: Dominic Chen Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/scripts/base.py Log Message: ----------- set __file__ before calling execfile on tacFile for relocatable buildmasters From noreply at github.com Sat Aug 10 22:44:47 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 15:44:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c59cbb: don't let errors in nextBuild silently prevent any... Message-ID: <5206c25fd5be9_290ea11d50725b7@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c59cbbfaad4ef03a6e1b0ef1f911a178598e9c74 https://github.com/buildbot/buildbot/commit/c59cbbfaad4ef03a6e1b0ef1f911a178598e9c74 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- don't let errors in nextBuild silently prevent any build from starting Commit: 0cb82385e761fdfe7b5027f67544fafa986d3397 https://github.com/buildbot/buildbot/commit/0cb82385e761fdfe7b5027f67544fafa986d3397 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- Merge branch 'buck-silent-nextBuild' of git://github.com/bukzor/buildbot Compare: https://github.com/buildbot/buildbot/compare/016178a600c0...0cb82385e761 From noreply at github.com Sat Aug 10 22:58:32 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 15:58:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e359d0: builddir and workdir properties should be strings, ... Message-ID: <5206c5981ba43_29fce2fd4c55268@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e359d0026c223520df79096bc934c0e37fb0ba43 https://github.com/buildbot/buildbot/commit/e359d0026c223520df79096bc934c0e37fb0ba43 Author: Olof Johansson Date: 2013-08-08 (Thu, 08 Aug 2013) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- builddir and workdir properties should be strings, not tuples Commit: f50722369168085235c795cd7997abc07a790c7c https://github.com/buildbot/buildbot/commit/f50722369168085235c795cd7997abc07a790c7c Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Merge branch 'fix/dont_tuplify_builddir' of git://github.com/olof/buildbot Compare: https://github.com/buildbot/buildbot/compare/0cb82385e761...f50722369168 From noreply at github.com Sun Aug 11 00:22:32 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 17:22:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 576476: modernize the test_db_buildrequests. Message-ID: <5206d948477c1_29df10ebd4c7449b@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5764763bbaf316b5f8c63687581f9b5185232477 https://github.com/buildbot/buildbot/commit/5764763bbaf316b5f8c63687581f9b5185232477 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- modernize the test_db_buildrequests. Commit: 92b12b4bb33b2ad402d141ed2909dc6521e1cdc7 https://github.com/buildbot/buildbot/commit/92b12b4bb33b2ad402d141ed2909dc6521e1cdc7 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- Merge branch 'buck-modernize-test-db-buildrequests' of git://github.com/bukzor/buildbot (with tabs -> spaces) Compare: https://github.com/buildbot/buildbot/compare/f50722369168...92b12b4bb33b From noreply at github.com Sun Aug 11 01:32:51 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 18:32:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d3b9ce: Add test for checking generated .tac file Message-ID: <5206e9c33debb_15b2b4dd54245c0@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: d3b9ce11d67d2dfe0d372917d80b4e1fcd19dc44 https://github.com/buildbot/buildbot/commit/d3b9ce11d67d2dfe0d372917d80b4e1fcd19dc44 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Add test for checking generated .tac file It checks that .tac file is valid Python script by exec()-uting it with mocked globals imports, such as twisted.application.service.Application and buildslave.bot.BuildSlave. Then it checks, that Application was created and stored in global variable "application" (as .tac specification requires); checks that BuildSlave created with passed arguments and attached to application. Commit: 7f557d5f225b42e19eb6d7e9787ce57711fdf07e https://github.com/buildbot/buildbot/commit/7f557d5f225b42e19eb6d7e9787ce57711fdf07e Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Add tests for basedir containing quotes, spaces and backslashes Quotes test failing with master Buildbot. In one of the older Buildbot releases I tried to create slave on Windows end ended with invalid .tac file due to something like this: basedir = 'C:\basedir\' Looks like this is fixed in master, but adding test won't hurt. Commit: 48447b43c94d8a55ee4900a2819ed7486170d75d https://github.com/buildbot/buildbot/commit/48447b43c94d8a55ee4900a2819ed7486170d75d Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- Fix handling basedir with quotes Commit: a252a91485700467b13b990592186d111a002421 https://github.com/buildbot/buildbot/commit/a252a91485700467b13b990592186d111a002421 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Add tests for invalid --umask and --allow-shutdown options Currently fails. Commit: 247d0f3ce8976d8efbf9ec8e688d8d4ea5fc7e6b https://github.com/buildbot/buildbot/commit/247d0f3ce8976d8efbf9ec8e688d8d4ea5fc7e6b Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- Handle invalid --umask and --allow-shutdown options Commit: 12dc3f4b4a0c8bbb83c5aac17bdfc19fa0dcb38e https://github.com/buildbot/buildbot/commit/12dc3f4b4a0c8bbb83c5aac17bdfc19fa0dcb38e Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Add test for handling special characters in all options fields Currently fails. Commit: 66a5a8db5efb1531444def57da237f7495403445 https://github.com/buildbot/buildbot/commit/66a5a8db5efb1531444def57da237f7495403445 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- Fix options fields writing in .tac file Commit: 1d12db6aa257cd5ab7948ff087b29860eb2d05e6 https://github.com/buildbot/buildbot/commit/1d12db6aa257cd5ab7948ff087b29860eb2d05e6 Author: Vladimir Rutsky Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- Write "log-size" as numeric, since it's always integer Commit: 815fad842a9a6cf18366a7e777e95e0897a1fe72 https://github.com/buildbot/buildbot/commit/815fad842a9a6cf18366a7e777e95e0897a1fe72 Author: Elmir Jagudin Date: 2013-07-04 (Thu, 04 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_base.py Log Message: ----------- fixed PEP8 violation Commit: 059a37ad9348162e9080dcc25037ea7f1c12de5a https://github.com/buildbot/buildbot/commit/059a37ad9348162e9080dcc25037ea7f1c12de5a Author: Dustin J. Mitchell Date: 2013-07-06 (Sat, 06 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_create_slave.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'slave_tac_check_and_fix' of git://github.com/vrutsky/buildbot Commit: f61a9241bbf36df71bb395d818b25673aeb1e141 https://github.com/buildbot/buildbot/commit/f61a9241bbf36df71bb395d818b25673aeb1e141 Author: Elmir Jagudin Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py Log Message: ----------- create slave: use OS specific path in messages Commit: a4cbf6ff56b2b8700fbfcd15cee7ade957377b58 https://github.com/buildbot/buildbot/commit/a4cbf6ff56b2b8700fbfcd15cee7ade957377b58 Author: Elmir Jagudin Date: 2013-07-07 (Sun, 07 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- use OS specific paths in unit tests Commit: 270ae42dbb073cccaea70f4cbf1046922620e112 https://github.com/buildbot/buildbot/commit/270ae42dbb073cccaea70f4cbf1046922620e112 Author: Dustin J. Mitchell Date: 2013-07-08 (Mon, 08 Jul 2013) Changed paths: M slave/buildslave/scripts/create_slave.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_create_slave.py Log Message: ----------- Merge branch 'fix-utests-win' of https://github.com/elmirjagudin/buildbot Commit: 866794ae336a8fce92e005aad1e8e416961e387d https://github.com/buildbot/buildbot/commit/866794ae336a8fce92e005aad1e8e416961e387d Author: Srinu P Date: 2013-07-08 (Mon, 08 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Master-side source steps support patches. Fixes #2098 Commit: 9cd7f9a097f16bc8e0e1f8dbcf52b1946b5c1756 https://github.com/buildbot/buildbot/commit/9cd7f9a097f16bc8e0e1f8dbcf52b1946b5c1756 Author: Dustin J. Mitchell Date: 2013-07-08 (Mon, 08 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2098-squash' of git://github.com/srinupiits/buildbot Commit: 0ecb1aef26a14f955f4ffa9fdc009277c30b1a97 https://github.com/buildbot/buildbot/commit/0ecb1aef26a14f955f4ffa9fdc009277c30b1a97 Author: Srinu P Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py Log Message: ----------- SVN source steps mode=export support authentication. Fixes #2463 Commit: ccdf00f370fe0f05628e3baa802cfe40622da99a https://github.com/buildbot/buildbot/commit/ccdf00f370fe0f05628e3baa802cfe40622da99a Author: Elmir Jagudin Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_stop.py Log Message: ----------- skip 'stop slave' test on windows Windows does not have os.kill() function, which is used in the tested code path. Skip the test for now. Commit: 4a5cf6e781971f30b90f7a50b754ff6be6f0d0fa https://github.com/buildbot/buildbot/commit/4a5cf6e781971f30b90f7a50b754ff6be6f0d0fa Author: K?lm?n Viktor Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/python.py Log Message: ----------- PyFlakes: fix handling of syntax error Commit: b1a6e23f5b0d4418b2f06eb3627e2816bf3d45e4 https://github.com/buildbot/buildbot/commit/b1a6e23f5b0d4418b2f06eb3627e2816bf3d45e4 Author: Dustin J. Mitchell Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/python.py Log Message: ----------- Merge branch 'master' of git://github.com/kviktor/buildbot Commit: feb582a6bbb9839b408f84ba3c438a583e099cd7 https://github.com/buildbot/buildbot/commit/feb582a6bbb9839b408f84ba3c438a583e099cd7 Author: Srinu P Date: 2013-07-14 (Sun, 14 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Master side source checkout steps support retry option. Fixes #2465, #2357 Commit: 021ff42c63721361ff2f1c6d15a5b717ef60d724 https://github.com/buildbot/buildbot/commit/021ff42c63721361ff2f1c6d15a5b717ef60d724 Author: Dustin J. Mitchell Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2463' of git://github.com/srinupiits/buildbot Commit: 97eff1c0b23a41c8bd6735e4a4fcee20eb6051f8 https://github.com/buildbot/buildbot/commit/97eff1c0b23a41c8bd6735e4a4fcee20eb6051f8 Author: Dustin J. Mitchell Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2465-sqash' of git://github.com/srinupiits/buildbot Commit: 9ec3f3a57ca946a0960304c90ae694323bfdbdcf https://github.com/buildbot/buildbot/commit/9ec3f3a57ca946a0960304c90ae694323bfdbdcf Author: Dustin J. Mitchell Date: 2013-07-25 (Thu, 25 Jul 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_stop.py Log Message: ----------- Merge branch 'skip-slave-kill' of git://github.com/elmirjagudin/buildbot Commit: 4b9db3e64a47985675a2975bb8348a4bcbaf08b3 https://github.com/buildbot/buildbot/commit/4b9db3e64a47985675a2975bb8348a4bcbaf08b3 Author: Srinu P Date: 2013-07-25 (Thu, 25 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/cls-remotecommands.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- SVN source step and Shell command support password obfuscation. Fixes #2468, #1478 Commit: 3152107f23d6891263de7a89c7741dab8fbe3b84 https://github.com/buildbot/buildbot/commit/3152107f23d6891263de7a89c7741dab8fbe3b84 Author: Dustin J. Mitchell Date: 2013-07-25 (Thu, 25 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/cls-remotecommands.rst M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'bug2468-squash' of git://github.com/srinupiits/buildbot Commit: 5a2b8ee0b559712d6413100aeee49a42ec5cd0cf https://github.com/buildbot/buildbot/commit/5a2b8ee0b559712d6413100aeee49a42ec5cd0cf Author: Srinu P Date: 2013-07-30 (Tue, 30 Jul 2013) Changed paths: A master/buildbot/steps/source/gerrit.py A master/buildbot/test/unit/test_steps_source_gerrit.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Gerrit integration with Git on master side Commit: e4e40a26a634664169fcb78fcbe1d55ec0881806 https://github.com/buildbot/buildbot/commit/e4e40a26a634664169fcb78fcbe1d55ec0881806 Author: Dustin J. Mitchell Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: A master/buildbot/steps/source/gerrit.py A master/buildbot/test/unit/test_steps_source_gerrit.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2485-squash' of git://github.com/srinupiits/buildbot Commit: afae17b166df8e7a61a56ce2d6ffc9520ec8e090 https://github.com/buildbot/buildbot/commit/afae17b166df8e7a61a56ce2d6ffc9520ec8e090 Author: Dustin J. Mitchell Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_gerrit.py Log Message: ----------- fix pyflakes Commit: 6784f5f218393add82e8c352d9de8d82c76d5224 https://github.com/buildbot/buildbot/commit/6784f5f218393add82e8c352d9de8d82c76d5224 Author: Srinu P Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Check git version for --branch support. Fixes #2504 Commit: a5790f15b995b02d23db8e73c79d98a6c704160d https://github.com/buildbot/buildbot/commit/a5790f15b995b02d23db8e73c79d98a6c704160d Author: Dustin J. Mitchell Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Merge branch 'bug2504' of git://github.com/srinupiits/buildbot Commit: 57e6532527a0f9bc6ba2ade554b1d01a692b2557 https://github.com/buildbot/buildbot/commit/57e6532527a0f9bc6ba2ade554b1d01a692b2557 Author: Srinu P Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_gerrit.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Check git version for --branch support. Fixes #2504 Commit: 31189748efc53c3faaa789a8d4ace6952c36ca1b https://github.com/buildbot/buildbot/commit/31189748efc53c3faaa789a8d4ace6952c36ca1b Author: Dustin J. Mitchell Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_gerrit.py Log Message: ----------- Merge branch 'bug2504' of git://github.com/srinupiits/buildbot Commit: 60ab1c0efc2f34a614804b6832f531bd22bd9bde https://github.com/buildbot/buildbot/commit/60ab1c0efc2f34a614804b6832f531bd22bd9bde Author: Buck Golemon Date: 2013-08-06 (Tue, 06 Aug 2013) Changed paths: M master/buildbot/test/unit/test_status_github.py Log Message: ----------- fix the github tests Commit: 5764763bbaf316b5f8c63687581f9b5185232477 https://github.com/buildbot/buildbot/commit/5764763bbaf316b5f8c63687581f9b5185232477 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- modernize the test_db_buildrequests. Commit: 0ce4f16c2bda88b31ac7ca19b94d5dc0c01796a4 https://github.com/buildbot/buildbot/commit/0ce4f16c2bda88b31ac7ca19b94d5dc0c01796a4 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/python.py M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py A master/buildbot/steps/source/gerrit.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py A master/buildbot/test/unit/test_steps_source_gerrit.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/cls-remotecommands.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/scripts/create_slave.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_runprocess.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_create_slave.py M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/unit/test_scripts_stop.py Log Message: ----------- Merge branch 'buck-modernize-test-db-buildrequests' into nine Conflicts: master/buildbot/test/fake/fakedb.py master/buildbot/test/unit/test_db_buildrequests.py Commit: d0daf958da68f8deb46f5b29b592a3708c6f11ec https://github.com/buildbot/buildbot/commit/d0daf958da68f8deb46f5b29b592a3708c6f11ec Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/data/masters.py M master/buildbot/test/unit/test_data_masters.py Log Message: ----------- fix the one failing test Commit: c59cbbfaad4ef03a6e1b0ef1f911a178598e9c74 https://github.com/buildbot/buildbot/commit/c59cbbfaad4ef03a6e1b0ef1f911a178598e9c74 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- don't let errors in nextBuild silently prevent any build from starting Commit: 027cada2ceb46363baee3c772ce71e330d68d715 https://github.com/buildbot/buildbot/commit/027cada2ceb46363baee3c772ce71e330d68d715 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M .gitignore A README.md M common/validate.sh M master/MANIFEST.in M master/buildbot/buildslave/base.py M master/buildbot/changes/base.py M master/buildbot/changes/bonsaipoller.py M master/buildbot/changes/changes.py M master/buildbot/changes/gerritchangesource.py M master/buildbot/changes/gitpoller.py M master/buildbot/changes/hgpoller.py M master/buildbot/changes/mail.py M master/buildbot/changes/p4poller.py M master/buildbot/changes/pb.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/debug.py M master/buildbot/clients/tryclient.py M master/buildbot/config.py A master/buildbot/data/__init__.py A master/buildbot/data/base.py A master/buildbot/data/builders.py A master/buildbot/data/builds.py A master/buildbot/data/buildsets.py A master/buildbot/data/buildslaves.py A master/buildbot/data/changes.py A master/buildbot/data/changesources.py A master/buildbot/data/connector.py A master/buildbot/data/exceptions.py A master/buildbot/data/logchunks.py A master/buildbot/data/logs.py A master/buildbot/data/masters.py A master/buildbot/data/patches.py A master/buildbot/data/resultspec.py A master/buildbot/data/root.py A master/buildbot/data/schedulers.py A master/buildbot/data/sourcestamps.py A master/buildbot/data/steps.py A master/buildbot/data/types.py M master/buildbot/db/base.py A master/buildbot/db/builders.py M master/buildbot/db/buildrequests.py M master/buildbot/db/builds.py M master/buildbot/db/buildsets.py M master/buildbot/db/buildslaves.py M master/buildbot/db/changes.py A master/buildbot/db/changesources.py M master/buildbot/db/connector.py A master/buildbot/db/logs.py A master/buildbot/db/masters.py M master/buildbot/db/migrate/versions/001_initial.py A master/buildbot/db/migrate/versions/025_add_master_table.py A master/buildbot/db/migrate/versions/026_add_schedulers_table.py A master/buildbot/db/migrate/versions/027_builders_table.py A master/buildbot/db/migrate/versions/028_sourcestamps_refactor.py A master/buildbot/db/migrate/versions/029_replace_builds_table.py A master/buildbot/db/migrate/versions/030_statusdb_tables.py A master/buildbot/db/migrate/versions/031_add_changesources_table.py A master/buildbot/db/migrate/versions/032_slave_connections.py M master/buildbot/db/model.py M master/buildbot/db/schedulers.py M master/buildbot/db/sourcestamps.py R master/buildbot/db/sourcestampsets.py M master/buildbot/db/state.py A master/buildbot/db/steps.py M master/buildbot/db/users.py M master/buildbot/interfaces.py M master/buildbot/master.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/decorators.py A master/buildbot/mq/__init__.py A master/buildbot/mq/base.py A master/buildbot/mq/connector.py A master/buildbot/mq/simple.py M master/buildbot/pbmanager.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py M master/buildbot/process/buildrequest.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/process/debug.py M master/buildbot/process/metrics.py M master/buildbot/process/properties.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/forcesched.py M master/buildbot/schedulers/timed.py M master/buildbot/schedulers/triggerable.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/scripts/sample.cfg A master/buildbot/scripts/uitestserver.py R master/buildbot/sourcestamp.py M master/buildbot/status/build.py M master/buildbot/status/builder.py M master/buildbot/status/buildrequest.py M master/buildbot/status/mail.py M master/buildbot/status/master.py M master/buildbot/status/persistent_queue.py M master/buildbot/status/results.py M master/buildbot/status/tinderbox.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/files/default.css M master/buildbot/status/web/grid.py M master/buildbot/status/web/status_json.py M master/buildbot/status/words.py M master/buildbot/steps/trigger.py M master/buildbot/test/__init__.py A master/buildbot/test/fake/endpoint.py A master/buildbot/test/fake/fakedata.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/fakemaster.py A master/buildbot/test/fake/fakemq.py M master/buildbot/test/fuzz/test_lru.py M master/buildbot/test/integration/test_master.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/integration/test_upgrade.py A master/buildbot/test/integration/test_www.py R master/buildbot/test/interfaces/__init__.py R master/buildbot/test/interfaces/test_logfile.py R master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/regressions/test_bad_change_properties_rows.py M master/buildbot/test/regressions/test_import_unicode_changes.py M master/buildbot/test/regressions/test_oldpaths.py M master/buildbot/test/regressions/test_shell_command_properties.py R master/buildbot/test/regressions/test_sourcestamp_revision.py M master/buildbot/test/regressions/test_unpickling.py M master/buildbot/test/unit/test_buildslave_base.py M master/buildbot/test/unit/test_changes_base.py M master/buildbot/test/unit/test_changes_bonsaipoller.py M master/buildbot/test/unit/test_changes_changes.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_changes_mail.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_changes_pb.py M master/buildbot/test/unit/test_changes_svnpoller.py M master/buildbot/test/unit/test_config.py A master/buildbot/test/unit/test_data_base.py A master/buildbot/test/unit/test_data_builders.py A master/buildbot/test/unit/test_data_builds.py A master/buildbot/test/unit/test_data_buildsets.py A master/buildbot/test/unit/test_data_buildslaves.py A master/buildbot/test/unit/test_data_changes.py A master/buildbot/test/unit/test_data_changesources.py A master/buildbot/test/unit/test_data_connector.py A master/buildbot/test/unit/test_data_logchunks.py A master/buildbot/test/unit/test_data_logs.py A master/buildbot/test/unit/test_data_masters.py A master/buildbot/test/unit/test_data_patches.py A master/buildbot/test/unit/test_data_resultspec.py A master/buildbot/test/unit/test_data_root.py A master/buildbot/test/unit/test_data_schedulers.py A master/buildbot/test/unit/test_data_sourcestamps.py A master/buildbot/test/unit/test_data_steps.py A master/buildbot/test/unit/test_data_types.py M master/buildbot/test/unit/test_db_base.py A master/buildbot/test/unit/test_db_builders.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_db_builds.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_db_buildslaves.py M master/buildbot/test/unit/test_db_changes.py A master/buildbot/test/unit/test_db_changesources.py M master/buildbot/test/unit/test_db_connector.py A master/buildbot/test/unit/test_db_logs.py A master/buildbot/test/unit/test_db_masters.py A master/buildbot/test/unit/test_db_migrate_versions_025_add_master_table.py A master/buildbot/test/unit/test_db_migrate_versions_026_add_schedulers_table.py A master/buildbot/test/unit/test_db_migrate_versions_027_builders_table.py A master/buildbot/test/unit/test_db_migrate_versions_028_sourcestamps_refactor.py A master/buildbot/test/unit/test_db_migrate_versions_029_replace_builds_table.py A master/buildbot/test/unit/test_db_migrate_versions_030_statusdb_tables.py A master/buildbot/test/unit/test_db_migrate_versions_031_add_changesources_table.py A master/buildbot/test/unit/test_db_migrate_versions_032_slave_connections.py M master/buildbot/test/unit/test_db_schedulers.py M master/buildbot/test/unit/test_db_sourcestamps.py R master/buildbot/test/unit/test_db_sourcestampsets.py A master/buildbot/test/unit/test_db_steps.py M master/buildbot/test/unit/test_db_users.py A master/buildbot/test/unit/test_logfile.py M master/buildbot/test/unit/test_master.py A master/buildbot/test/unit/test_mq.py A master/buildbot/test/unit/test_mq_base.py A master/buildbot/test/unit/test_mq_connector.py A master/buildbot/test/unit/test_mq_simple.py M master/buildbot/test/unit/test_process_botmaster_BotMaster.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_builder.py M master/buildbot/test/unit/test_process_buildrequest.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_metrics.py M master/buildbot/test/unit/test_process_users_manual.py M master/buildbot/test/unit/test_process_users_users.py A master/buildbot/test/unit/test_remotecommand.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_dependent.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/buildbot/test/unit/test_schedulers_timed_NightlyTriggerable.py M master/buildbot/test/unit/test_schedulers_timed_Periodic.py M master/buildbot/test/unit/test_schedulers_timed_Timed.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_scripts_create_master.py M master/buildbot/test/unit/test_scripts_stop.py M master/buildbot/test/unit/test_scripts_upgrade_master.py R master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_build.py M master/buildbot/test/unit/test_status_client.py M master/buildbot/test/unit/test_status_logfile.py M master/buildbot/test/unit/test_status_mail.py M master/buildbot/test/unit/test_status_master.py M master/buildbot/test/unit/test_status_web_hooks_poller.py M master/buildbot/test/unit/test_steps_trigger.py A master/buildbot/test/unit/test_test_util_validation.py M master/buildbot/test/unit/test_util.py A master/buildbot/test/unit/test_util_pathmatch.py A master/buildbot/test/unit/test_util_pickle.py A master/buildbot/test/unit/test_util_service.py A master/buildbot/test/unit/test_util_tuplematch.py A master/buildbot/test/unit/test_util_typechecks.py A master/buildbot/test/unit/test_www_resource.py A master/buildbot/test/unit/test_www_rest.py A master/buildbot/test/unit/test_www_service.py M master/buildbot/test/util/change_import.py M master/buildbot/test/util/changesource.py M master/buildbot/test/util/connector_component.py M master/buildbot/test/util/db.py A master/buildbot/test/util/endpoint.py A master/buildbot/test/util/fuzz.py M master/buildbot/test/util/interfaces.py M master/buildbot/test/util/pbmanager.py M master/buildbot/test/util/scheduler.py A master/buildbot/test/util/tuplematching.py A master/buildbot/test/util/txghost.py A master/buildbot/test/util/validation.py A master/buildbot/test/util/www.py M master/buildbot/util/__init__.py A master/buildbot/util/pathmatch.py A master/buildbot/util/pickle.py M master/buildbot/util/sautils.py A master/buildbot/util/service.py A master/buildbot/util/tuplematch.py A master/buildbot/util/typechecks.py A master/buildbot/www/__init__.py A master/buildbot/www/resource.py A master/buildbot/www/rest.py A master/buildbot/www/service.py A master/buildbot/www/sse.py A master/buildbot/www/websocket.py A master/buildbot/www/ws.py M master/contrib/bzr_buildbot.py M master/contrib/fix_changes_pickle_encoding.py M master/contrib/googlecode_atom.py M master/docs/bbdocs/ext.py A master/docs/developer/apis.rst A master/docs/developer/br-claiming.rst M master/docs/developer/classes.rst A master/docs/developer/cls-basescheduler.rst A master/docs/developer/cls-clusteredservice.rst A master/docs/developer/cls-resultspec.rst M master/docs/developer/config.rst A master/docs/developer/data.rst R master/docs/developer/database.rst A master/docs/developer/db.rst A master/docs/developer/general.rst M master/docs/developer/index.rst M master/docs/developer/master-overview.rst A master/docs/developer/mq.rst M master/docs/developer/results.rst A master/docs/developer/rtype-build.rst A master/docs/developer/rtype-builder.rst A master/docs/developer/rtype-buildset.rst A master/docs/developer/rtype-buildslave.rst A master/docs/developer/rtype-change.rst A master/docs/developer/rtype-changesource.rst A master/docs/developer/rtype-log.rst A master/docs/developer/rtype-logchunk.rst A master/docs/developer/rtype-master.rst A master/docs/developer/rtype-patch.rst A master/docs/developer/rtype-scheduler.rst A master/docs/developer/rtype-sourcestamp.rst A master/docs/developer/rtype-step.rst A master/docs/developer/schedulers.rst M master/docs/developer/tests.rst M master/docs/developer/utils.rst A master/docs/developer/www.rst M master/docs/index.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-global.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cmdline.rst M master/docs/manual/customization.rst M master/docs/manual/installation.rst M master/docs/relnotes/index.rst M master/setup.py A www/Gruntfile.coffee A www/MANIFEST.in A www/README.txt A www/buildbot_www.py A www/karma.conf.js A www/sample_plugin/.gitignore A www/sample_plugin/Gruntfile.coffee A www/sample_plugin/buildbot_sample_plugin.py A www/sample_plugin/setup.py A www/sample_plugin/src/img/logo.png A www/sample_plugin/src/scripts/controllers/demoController.coffee A www/sample_plugin/src/scripts/directives/d3demo.coffee A www/sample_plugin/src/scripts/libs/d3.js A www/sample_plugin/src/scripts/routes.coffee A www/sample_plugin/src/scripts/views.coffee A www/sample_plugin/src/styles/styles.less A www/sample_plugin/src/views/demo.jade A www/setup.py A www/src/font/FontAwesome.otf A www/src/font/fontawesome-webfont.eot A www/src/font/fontawesome-webfont.svg A www/src/font/fontawesome-webfont.ttf A www/src/font/fontawesome-webfont.woff A www/src/img/favicon.ico A www/src/index.jade A www/src/layout.jade A www/src/scripts/app.coffee A www/src/scripts/controllers/aboutController.coffee A www/src/scripts/controllers/buildersController.coffee A www/src/scripts/controllers/changesController.coffee A www/src/scripts/controllers/homeController.coffee A www/src/scripts/directives/topmenu.coffee A www/src/scripts/libs/angular-resource.js A www/src/scripts/libs/angular.js A www/src/scripts/libs/html5shiv-printshiv.js A www/src/scripts/libs/jquery.js A www/src/scripts/libs/json2.js A www/src/scripts/libs/require.js A www/src/scripts/responseInterceptors/dispatcher.coffee A www/src/scripts/routes.coffee A www/src/scripts/run.coffee A www/src/scripts/services/buildbotService.coffee A www/src/scripts/services/messageService.coffee A www/src/scripts/services/recentStorage.coffee A www/src/scripts/views.coffee A www/src/styles/bootstrap A www/src/styles/bootstrap.less A www/src/styles/font-awesome A www/src/styles/font-awesome.less A www/src/styles/styles.less A www/src/styles/variables.less A www/src/views/about.jade A www/src/views/builders.jade A www/src/views/changes.jade A www/src/views/directives/topmenu.jade A www/src/views/home.jade A www/tasks/requiregen.coffee A www/test/scripts/libs/angular-mocks.js A www/test/scripts/libs/jasmine-html.js A www/test/scripts/libs/jasmine.js A www/test/scripts/services/buildbotService.coffee A www/tosource Log Message: ----------- Merge branches 'buck-fix-github', 'buck-modernize-test-db-buildrequests-on-nine', 'buck-silent-nextBuild' and 'buck-tempsourcestamp-asdict' into buck-nine-2013-08-06 Commit: 2a7ff92599bccac6738219e98c85c8f42b390123 https://github.com/buildbot/buildbot/commit/2a7ff92599bccac6738219e98c85c8f42b390123 Author: Buck Golemon Date: 2013-08-07 (Wed, 07 Aug 2013) Changed paths: M master/buildbot/db/buildrequests.py A master/buildbot/db/migrate/versions/033_buildrequests_waited_for.py M master/buildbot/db/model.py M master/buildbot/process/buildrequest.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- add a buildrequests.waited_for column fix the fake buildrequest.waited_for Commit: a8ead99cc8c505fb19e8e3bd018696e16b6759ee https://github.com/buildbot/buildbot/commit/a8ead99cc8c505fb19e8e3bd018696e16b6759ee Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/data/masters.py M master/buildbot/db/buildrequests.py A master/buildbot/db/migrate/versions/033_buildrequests_waited_for.py M master/buildbot/db/model.py M master/buildbot/process/buildrequest.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/steps/python.py M master/buildbot/steps/source/base.py M master/buildbot/steps/source/bzr.py M master/buildbot/steps/source/cvs.py A master/buildbot/steps/source/gerrit.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/mercurial.py M master/buildbot/steps/source/svn.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_data_masters.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_status_github.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_cvs.py A master/buildbot/test/unit/test_steps_source_gerrit.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/unit/test_steps_source_svn.py M master/docs/developer/cls-remotecommands.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/scripts/create_slave.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_runprocess.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_create_slave.py M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/unit/test_scripts_stop.py Log Message: ----------- Merge branch 'buck-buildrequest-waited_for' of git://github.com/bukzor/buildbot into nine (and a bunch of other stuff from master) Commit: 4274eb8b22a4694e8046cb919cae5bf1de473d35 https://github.com/buildbot/buildbot/commit/4274eb8b22a4694e8046cb919cae5bf1de473d35 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/db/buildrequests.py M master/buildbot/db/migrate/versions/033_buildrequests_waited_for.py A master/buildbot/test/unit/test_db_migrate_versions_033_buildrequests_waited_for.py Log Message: ----------- tabs, copyright headers, and tests for migration 033 Compare: https://github.com/buildbot/buildbot/compare/bda1c6dbcbae...4274eb8b22a4 From noreply at github.com Sun Aug 11 01:35:56 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 18:35:56 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1d9e2c: fix pyflakes Message-ID: <5206ea7c878be_18f2136dd54715e1@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 1d9e2c941974cbbce2f02d60c2798063a792aefd https://github.com/buildbot/buildbot/commit/1d9e2c941974cbbce2f02d60c2798063a792aefd Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/test/unit/test_db_migrate_versions_033_buildrequests_waited_for.py Log Message: ----------- fix pyflakes From trac at buildbot.net Sun Aug 11 01:37:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 01:37:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.bebed71ed4236917c1e00f2a26bbc8fa@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Changes (by dustin): * type: enhancement => defect * milestone: undecided => 0.8.+ Comment: Is this with the slave-side svn step or the master-side step? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 01:38:44 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 01:38:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2532: Support using interlocks for sequences of steps In-Reply-To: <045.da71f29098b2fd32a7820a5290c3a83b@buildbot.net> References: <045.da71f29098b2fd32a7820a5290c3a83b@buildbot.net> Message-ID: <060.4f846bf4d9787a8c64a52f3f693443e3@buildbot.net> #2532: Support using interlocks for sequences of steps --------------------------+-------------------- Reporter: shirokuroneko | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: locks | --------------------------+-------------------- Changes (by dustin): * keywords: => locks * milestone: undecided => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 01:42:14 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 01:42:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2531: Git step fails, if workdir exists but isn't a git checkout. In-Reply-To: <042.2e717142f8d778004b389c50f2cfc5d5@buildbot.net> References: <042.2e717142f8d778004b389c50f2cfc5d5@buildbot.net> Message-ID: <057.6d94e3c80393dee0a7490fed8a3ea132@buildbot.net> #2531: Git step fails, if workdir exists but isn't a git checkout. -----------------------------------------+------------------------ Reporter: tom.prince | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Resolution: Keywords: git master-side-source-steps | -----------------------------------------+------------------------ Comment (by dustin): In irc, tomprince suggested that the best we can do here is this: if the builddir exists, but the `.git` subdirectory does not, then clobber. That requires adding a ListDir command on the slave, and checking for its existence on the master, but I think that's a good addition to the protocol anyway. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 01:43:00 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 01:43:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2537: nextSlave is given a list of slavebuilders, not slaves In-Reply-To: <040.005dd5df97fd32cf74de9f27497ffb67@buildbot.net> References: <040.005dd5df97fd32cf74de9f27497ffb67@buildbot.net> Message-ID: <055.5d15276f9b87121045ca14bc630a6c40@buildbot.net> #2537: nextSlave is given a list of slavebuilders, not slaves ---------------------+------------------------ Reporter: LegNeato | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): Hi LegNeato :) The docs are wrong, and a patch to fix that would be great! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Aug 11 01:50:55 2013 From: noreply at github.com (GitHub) Date: Sat, 10 Aug 2013 18:50:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 344d85: Keep the config arguments for RPMLint Message-ID: <5206edff9f751_18911363d54944@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 344d85983a17c7571672135dc4da57f72f4dc5b2 https://github.com/buildbot/buildbot/commit/344d85983a17c7571672135dc4da57f72f4dc5b2 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/steps/package/rpm/rpmlint.py Log Message: ----------- Keep the config arguments for RPMLint Based on the patch in https://bugzilla.redhat.com/show_bug.cgi?id=836624 From trac at buildbot.net Sun Aug 11 01:52:14 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 01:52:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2539: setting branch to a property in a Git step causes a TypeError In-Reply-To: <038.fd96bcc3a25eebaaf60115b797cff449@buildbot.net> References: <038.fd96bcc3a25eebaaf60115b797cff449@buildbot.net> Message-ID: <053.cd95c5ac1385926a8ce258e79ef1e4af@buildbot.net> #2539: setting branch to a property in a Git step causes a TypeError --------------------+------------------------ Reporter: dickon | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | --------------------+------------------------ Comment (by dustin): Your fix is correct. Do you mind putting it into a pull request? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 02:03:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 02:03:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2547: Can't have slaves and builders with the same name Message-ID: <038.a740ebe4f23af60338bde94b17707632@buildbot.net> #2547: Can't have slaves and builders with the same name -----------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.7p1 | Keywords: simple -----------------------------+-------------------- Slaves and builders are both child services of the same !MultiService, and as such can't have the same name. This was noted in #2538. The fix for this is to create two !MultiService objects, one to be the parent of every slave, and one to be the parent of every Builder. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 02:04:15 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 02:04:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2538: LibVirtSlave issues In-Reply-To: <035.33a8fa281980ccece13fa46eaa0dd40a@buildbot.net> References: <035.33a8fa281980ccece13fa46eaa0dd40a@buildbot.net> Message-ID: <050.33ae06c8e054c207d027e57fb87b972d@buildbot.net> #2538: LibVirtSlave issues -------------------+------------------------ Reporter: gg0 | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Resolution: Keywords: | -------------------+------------------------ Comment (by dustin): I moved a) to #2547. So all that remains here is to be sure the patch Jc2k suggested got merged.. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 02:20:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 02:20:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2541: Lots of ignored exceptions in buildbot In-Reply-To: <036.bb7fc56ae19591023439f4394cdb3b45@buildbot.net> References: <036.bb7fc56ae19591023439f4394cdb3b45@buildbot.net> Message-ID: <051.511d40814c825de2f5a842f567662468@buildbot.net> #2541: Lots of ignored exceptions in buildbot ----------------------+------------------------ Reporter: buck | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: invalid Keywords: | ----------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => invalid -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 02:29:24 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 02:29:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2542: GitPoller fails on branch not existing, but doesnt poll the other branches In-Reply-To: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> References: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> Message-ID: <056.406f95289fe54e3b4ef278773cabfe74@buildbot.net> #2542: GitPoller fails on branch not existing, but doesnt poll the other branches ------------------------+-------------------- Reporter: mlakewood | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: GitPoller | ------------------------+-------------------- Changes (by dustin): * type: undecided => enhancement * milestone: undecided => 0.8.+ Comment: We don't have a good way for !GitPoller (or anything not part of a build) to report errors right now, except for logging to the master log. So, yes, I think that logging this failure and moving on to the next branch is the right thing to do. Do you want to work up a patch to do so, with tests and all that? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 02:30:47 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 02:30:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.ed2db651bfa9ba8a4660e7fdccf554c4@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): That's a good, smart workaround. Do you want to try your hand at the fix I suggested in comment 1? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 02:32:00 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 02:32:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2543: GerritChangeSource should ignore incoming ref-updated events to refs/meta/config branch In-Reply-To: <035.5e0de5b2ec24d9461634834f9d00ea5f@buildbot.net> References: <035.5e0de5b2ec24d9461634834f9d00ea5f@buildbot.net> Message-ID: <050.3ef6e0e650064316535b925ef2e23211@buildbot.net> #2543: GerritChangeSource should ignore incoming ref-updated events to refs/meta/config branch --------------------+-------------------- Reporter: krf | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: gerrit | --------------------+-------------------- Changes (by dustin): * keywords: => gerrit * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 03:23:33 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 03:23:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2454: SiGHUP doesn't always work In-Reply-To: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> References: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> Message-ID: <054.f51687b19553f649a51ca98028a5ec7f@buildbot.net> #2454: SiGHUP doesn't always work ----------------------------+---------------------- Reporter: virgilg | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: | ----------------------------+---------------------- Comment (by dustin): Replying to [comment:12 virgilg]: > I can repro this as follows: > > 1) save the attached script as e.g. test.py[[BR]] > 2) comment and uncomment line 12: time.sleep(1) > > With time.sleep(1) uncommented, one cannot deliver a SIG to the process, since the MainThread is too busy inside the while True: loop and python is not really multithreaded. > > With time.sleep(1) commented out, handler() will get a chance to run. I can't reproduce this. In either case - sleep or not - I see "Interrupt received" when I send it a SIGINT. On both Mountain Lion (using the system Python) and on Linux. Given the way signal handling works, that's not terribly surprising. UNIX will deliver a signal to the main thread of a process immediately, either by pre-empting the process (if it's currently running), by scheduling it (if it's ready to run), or by returning early from a syscall (if it's currently in a syscall). In any of those cases, Python sets an internal flag for the signal, sets the global is_tripped, adds a pending call to PyErr_CheckSignals, and if necessary uses a selfpipe to wake up the main process. Python checks for pending calls every few Python opcodes. A tight python loop (`while True: pass`) is still executing opcodes, so the pending call gets checked, and the exception gets handled. You indicated that the loop *with* `time.sleep(1)` was not interruptible. In that case, the signal is most likely delivered during the sleep, which is either a syscall that will be awakened, or a select() that includes the selfpipe, so the signal should *still* be delivered immediately. Which is what I'm seeing. Since we're seeing different behavior from a very simple Python script, I think we should look toward the version and build of Python that we're using. If we get those to match and we're *still* seeing different behavior, then we'll have to look more closely at the reproduction recipe, and try to find a suitable machine we both have access to. > I see it process a ton of "events" that never finish: events_company.com/11305023 > Where do these events come from? What generates them? events_company.com/state is not the droid I'm looking for, is it? This is a separate issue, which I think you filed a different bug on. Your events shouldn't be backing up into the disk storage like that. But let's focus on this bug for now. If I accept for a moment your hypothesis that "tight" Python loops preclude UNIX signals, then I see how this would be related. But I don't know what "tight" means - if I loop over a list with two elements, then for a moment the CPU is just as busy as it would be if I were looping over 1,000,000 elements. If a signal's delivered during that time, is it ignored? What if it's delivered while a multiplication operation is taking place? What defines "tight"? > The other 6 threads are all stuck in threading.py: Yep, that's the `Condition` class, Those are all worker threads helpfully waiting for work. I think that we should talk through some medium other than Trac. I'll try to send you an email at the address in Trac, but if that fails, please get in touch. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 03:29:10 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 03:29:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2545: dynamic buildsteps/buildstep detection In-Reply-To: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> References: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> Message-ID: <054.7fe05ed28e4780f2a46297ea322b488f@buildbot.net> #2545: dynamic buildsteps/buildstep detection ------------------------+-------------------- Reporter: vlovich | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * type: undecided => enhancement * milestone: undecided => 1.0.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 03:35:17 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 03:35:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log In-Reply-To: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> References: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> Message-ID: <053.4c7154a90e5a33b741e5fb2f1aa25df5@buildbot.net> #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log --------------------+------------------------- Reporter: chaica | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: worksforme Keywords: hg | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: I'm curious what the change was that fixed this? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 03:40:35 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 03:40:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2454: SiGHUP doesn't always work In-Reply-To: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> References: <039.a8c10414c6c598f3df6dfcbf8c458fa0@buildbot.net> Message-ID: <054.90d0dde0d12e0952d1d1ffbf69d2b674@buildbot.net> #2454: SiGHUP doesn't always work ----------------------------+---------------------- Reporter: virgilg | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: | ----------------------------+---------------------- Comment (by virgilg): > You indicated that the loop *with* time.sleep(1) was not interruptible. Err, that should read: *without* it's not interruptible because of the tight loop; *with* it is interruptible because we can 'catch' the signal. In our cases we're in a os.stat call for each of the events in the queue. My email address on file should be very reachable. Thanks! VV -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 09:01:57 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 09:01:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log In-Reply-To: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> References: <038.43255cfbba162f4c33201a2b98544c6d@buildbot.net> Message-ID: <053.d2cdeb30936d04249a8a14a336fe5e98@buildbot.net> #2546: Error message about buildbot/revlinks.py : exceptions.TypeError: expected string or buffer in twistd.log --------------------+------------------------- Reporter: chaica | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: worksforme Keywords: hg | --------------------+------------------------- Comment (by chaica): Replying to [comment:3 dustin]: > I'm curious what the change was that fixed this? Hi, In fact I have been keeping my old master.cfg from 0.8.1, I manually merged with the new one from 0.8.6p1, trying to follow new syntaxes and it worked. I don't know exactly what was triggering the initial issue. I'm providing the old master.cfg from 0.8.1 if you want to have a look. Regards, Carl Chenet -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Aug 11 12:18:07 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 11 Aug 2013 12:18:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2548: Git builder silently drops back to HEAD (master) if a branch isn't found Message-ID: <040.fb3a30906f32efd8fcc109b631bfbd2f@buildbot.net> #2548: Git builder silently drops back to HEAD (master) if a branch isn't found ---------------------+----------------------- Reporter: chmorgan | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: git ---------------------+----------------------- There is no option to cause a git builder to fail if the specified branch isn't found. We've had several cases where people have plugged in an invalid branch, or a partial sha in place of the branch field and gotten the wrong build. The build runs and completes without error but you can see from the log that it didn't do what was expected: {{{ ... Cloning into '.'... warning: Remote branch aa7391a not found in upstream origin, using HEAD instead ... }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Aug 11 15:18:57 2013 From: noreply at github.com (GitHub) Date: Sun, 11 Aug 2013 08:18:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 62e244: coding style fixes Message-ID: <5207ab61553d1_1dd5fffd487709f@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 62e24436bfaaad1e0d14846f48ced872ffcac0d3 https://github.com/buildbot/buildbot/commit/62e24436bfaaad1e0d14846f48ced872ffcac0d3 Author: Pierre Tardy Date: 2013-07-29 (Mon, 29 Jul 2013) Changed paths: M www/src/scripts/routes.coffee M www/src/scripts/run.coffee Log Message: ----------- coding style fixes running pep8 on coffee script kinda works. Its better than nothing at finding silly styling issues Signed-off-by: Pierre Tardy Commit: c7cd656e6368c20d4c75b5b3ece8b6b97bbeaaa1 https://github.com/buildbot/buildbot/commit/c7cd656e6368c20d4c75b5b3ece8b6b97bbeaaa1 Author: Pierre Tardy Date: 2013-08-03 (Sat, 03 Aug 2013) Changed paths: M master/buildbot/data/builds.py M master/buildbot/data/connector.py M master/buildbot/data/root.py M master/buildbot/data/types.py A master/buildbot/scripts/dataspec.py M master/buildbot/scripts/runner.py R master/buildbot/scripts/uitestserver.py M master/buildbot/test/unit/test_data_root.py Log Message: ----------- dataTypes: add endpoint and cmdline to dump the application spec All our data api is already described in python, we need to export that to the coffeescript testsuite in order to make sure the mocked api is the same as the python one. As we are at it, we export it to the data api as well, so that we can have a UI showing the API to the potential developer Commit: c496548ee5f574a78df92d4227ba1024adf0c576 https://github.com/buildbot/buildbot/commit/c496548ee5f574a78df92d4227ba1024adf0c576 Author: Pierre Tardy Date: 2013-08-03 (Sat, 03 Aug 2013) Changed paths: M www/src/styles/bootstrap.less M www/src/styles/variables.less Log Message: ----------- upgrade bootstrap and fontawesome bootstrap 3.0 and fontawesome again changed its path! Signed-off-by: Pierre Tardy Commit: c353ddd4150dc78f9eda4be6b249f1c7f87d1781 https://github.com/buildbot/buildbot/commit/c353ddd4150dc78f9eda4be6b249f1c7f87d1781 Author: Pierre Tardy Date: 2013-08-03 (Sat, 03 Aug 2013) Changed paths: M master/docs/developer/www.rst M www/Gruntfile.coffee M www/karma.conf.js M www/setup.py M www/src/scripts/app.coffee A www/src/scripts/libs/lodash.js A www/src/scripts/libs/restangular.js M www/src/scripts/run.coffee M www/src/scripts/services/buildbotService.coffee A www/test/scripts/services/EventSourceMock.coffee M www/test/scripts/services/buildbotService.coffee A www/test/scripts/services/httpMock.coffee Log Message: ----------- buildbotService: based on Restangular buildbotService is a typical restangular object, but adds methods to automatically update scope based on 'sse' events Add unit tests: - EventSourceMock simulates events - httpMock simulates the whole backend, with help from dataspec json info. This will be used to unittest controllers, for E2E tests, and for backendless development add restangular and lodash deps. Commit: 28dccf98b69f0e3d8bff48fa4c0b36a7c34dec8b https://github.com/buildbot/buildbot/commit/28dccf98b69f0e3d8bff48fa4c0b36a7c34dec8b Author: Pierre Tardy Date: 2013-08-05 (Mon, 05 Aug 2013) Changed paths: M master/buildbot/data/builders.py M www/Gruntfile.coffee M www/karma.conf.js M www/src/index.jade M www/src/scripts/controllers/buildersController.coffee M www/src/scripts/controllers/changesController.coffee M www/src/scripts/directives/topmenu.coffee M www/src/scripts/routes.coffee M www/src/scripts/run.coffee M www/src/scripts/services/buildbotService.coffee M www/src/views/about.jade M www/src/views/builders.jade M www/src/views/changes.jade M www/src/views/directives/topmenu.jade M www/src/views/home.jade R www/test/scripts/libs/jasmine-html.js R www/test/scripts/libs/jasmine.js A www/test/scripts/mocks/EventSourceMock.coffee A www/test/scripts/mocks/httpMock.coffee A www/test/scripts/scenarios/devapp.coffee R www/test/scripts/services/EventSourceMock.coffee M www/test/scripts/services/buildbotService.coffee R www/test/scripts/services/httpMock.coffee Log Message: ----------- www: enable backendless development When the web app is served by generic file server, in grunt dev mode, we use ngMock and dataspec to serve mocked data to the UI. Thus web development can happen independantly from data api progress as soon as the spec is written refactor the few existing views to match bootstrap3 and the new buildbotService apis Signed-off-by: Pierre Tardy Commit: 4a7896ac736b6503d017e0e5edb5ca0dc15d4863 https://github.com/buildbot/buildbot/commit/4a7896ac736b6503d017e0e5edb5ca0dc15d4863 Author: Pierre Tardy Date: 2013-08-06 (Tue, 06 Aug 2013) Changed paths: M .gitignore M www/setup.py R www/src/font/FontAwesome.otf M www/src/font/fontawesome-webfont.eot M www/src/font/fontawesome-webfont.svg M www/src/font/fontawesome-webfont.ttf M www/src/font/fontawesome-webfont.woff M www/src/scripts/app.coffee R www/src/scripts/libs/angular-resource.js M www/src/scripts/libs/angular.js M www/src/scripts/libs/html5shiv-printshiv.js M www/src/scripts/libs/jquery.js M www/src/scripts/libs/json2.js M www/src/scripts/libs/lodash.js M www/src/scripts/libs/require.js M www/src/scripts/libs/restangular.js A www/src/scripts/libs/ui-bootstrap-tpls.js M www/src/styles/bootstrap M www/src/styles/bootstrap.less M www/src/styles/font-awesome R www/src/styles/font-awesome.less M www/test/scripts/libs/angular-mocks.js Log Message: ----------- upgrade bower version make component move to bower_component Commit: c1b7e5b6985f44a028c723d2dd3a1e509059a7b0 https://github.com/buildbot/buildbot/commit/c1b7e5b6985f44a028c723d2dd3a1e509059a7b0 Author: Pierre Tardy Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M www/src/index.jade A www/src/scripts/controllers/alertPanelController.coffee A www/src/scripts/services/alertService.coffee M www/src/styles/styles.less Log Message: ----------- www: add global alert alert service can be called from anywhere do display an alert bar on top of the window. Signed-off-by: Pierre Tardy Commit: 88dee4cd8b9ff5a3bd69a2524a9a6f9d3463980d https://github.com/buildbot/buildbot/commit/88dee4cd8b9ff5a3bd69a2524a9a6f9d3463980d Author: Pierre Tardy Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M www/Gruntfile.coffee R www/karma.conf.js M www/sample_plugin/Gruntfile.coffee M www/sample_plugin/setup.py M www/setup.py M www/src/scripts/app.coffee M www/src/scripts/run.coffee M www/src/scripts/views.coffee R www/tasks/requiregen.coffee A www/test/scripts/main.coffee R www/test/scripts/services/buildbotService.coffee A www/test/scripts/services/buildbotServiceSpec.coffee Log Message: ----------- modernization of buildscripts upgrade to karma to 0.10 upgrade grunt-watch -> no need for 2 extra parallel grunt command for karma and livereload added incremental build for coffee scripts. only modified files are recompiled Suppress depend on grunt-hustler in favor of equivalent single module (ngTemplateCache->html2js) put requiregen task in its own grunt module Commit: 36d3e977c2fc6414c210eab2207afa22f2340007 https://github.com/buildbot/buildbot/commit/36d3e977c2fc6414c210eab2207afa22f2340007 Author: Pierre Tardy Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M www/src/index.jade M www/src/views/home.jade Log Message: ----------- fix minor bootstrap move issues Commit: 3d30dc1b2b280d2e2f51aed1f76674dfb08644d8 https://github.com/buildbot/buildbot/commit/3d30dc1b2b280d2e2f51aed1f76674dfb08644d8 Author: Pierre Tardy Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M www/Gruntfile.coffee Log Message: ----------- enable tests for prod build as well Commit: 53db29ea32a25bcd48fdfc91ad4092ab3b6e8752 https://github.com/buildbot/buildbot/commit/53db29ea32a25bcd48fdfc91ad4092ab3b6e8752 Author: Pierre Tardy Date: 2013-08-11 (Sun, 11 Aug 2013) Changed paths: M master/buildbot/data/connector.py M master/buildbot/data/root.py M master/buildbot/data/types.py M master/buildbot/scripts/dataspec.py M master/buildbot/scripts/runner.py M master/buildbot/util/pathmatch.py M master/docs/developer/www.rst M www/setup.py M www/src/scripts/services/alertService.coffee Log Message: ----------- fixes for dustin Commit: dbdcdf6bc5d9f7c7c98948317533582460b92522 https://github.com/buildbot/buildbot/commit/dbdcdf6bc5d9f7c7c98948317533582460b92522 Author: Dustin J. Mitchell Date: 2013-08-11 (Sun, 11 Aug 2013) Changed paths: M .gitignore M master/buildbot/data/builders.py M master/buildbot/data/builds.py M master/buildbot/data/connector.py M master/buildbot/data/root.py M master/buildbot/data/types.py A master/buildbot/scripts/dataspec.py M master/buildbot/scripts/runner.py R master/buildbot/scripts/uitestserver.py M master/buildbot/test/unit/test_data_root.py M master/buildbot/util/pathmatch.py M master/docs/developer/www.rst M www/Gruntfile.coffee R www/karma.conf.js M www/sample_plugin/Gruntfile.coffee M www/sample_plugin/setup.py M www/setup.py R www/src/font/FontAwesome.otf M www/src/font/fontawesome-webfont.eot M www/src/font/fontawesome-webfont.svg M www/src/font/fontawesome-webfont.ttf M www/src/font/fontawesome-webfont.woff M www/src/index.jade M www/src/scripts/app.coffee A www/src/scripts/controllers/alertPanelController.coffee M www/src/scripts/controllers/buildersController.coffee M www/src/scripts/controllers/changesController.coffee M www/src/scripts/directives/topmenu.coffee R www/src/scripts/libs/angular-resource.js M www/src/scripts/libs/angular.js M www/src/scripts/libs/html5shiv-printshiv.js M www/src/scripts/libs/jquery.js M www/src/scripts/libs/json2.js A www/src/scripts/libs/lodash.js M www/src/scripts/libs/require.js A www/src/scripts/libs/restangular.js A www/src/scripts/libs/ui-bootstrap-tpls.js M www/src/scripts/routes.coffee M www/src/scripts/run.coffee A www/src/scripts/services/alertService.coffee M www/src/scripts/services/buildbotService.coffee M www/src/scripts/views.coffee M www/src/styles/bootstrap M www/src/styles/bootstrap.less M www/src/styles/font-awesome R www/src/styles/font-awesome.less M www/src/styles/styles.less M www/src/styles/variables.less M www/src/views/about.jade M www/src/views/builders.jade M www/src/views/changes.jade M www/src/views/directives/topmenu.jade M www/src/views/home.jade R www/tasks/requiregen.coffee M www/test/scripts/libs/angular-mocks.js R www/test/scripts/libs/jasmine-html.js R www/test/scripts/libs/jasmine.js A www/test/scripts/main.coffee A www/test/scripts/mocks/EventSourceMock.coffee A www/test/scripts/mocks/httpMock.coffee A www/test/scripts/scenarios/devapp.coffee R www/test/scripts/services/buildbotService.coffee A www/test/scripts/services/buildbotServiceSpec.coffee Log Message: ----------- Merge branch 'buildbotapi' of git://github.com/tardyp/buildbot into nine Commit: da92a2c0fc4f1188a0e193ff857a27e322477024 https://github.com/buildbot/buildbot/commit/da92a2c0fc4f1188a0e193ff857a27e322477024 Author: Dustin J. Mitchell Date: 2013-08-11 (Sun, 11 Aug 2013) Changed paths: M master/docs/developer/utils.rst Log Message: ----------- add docs for Matcher.iterPatterns Commit: 30788834d8886046c6faf645f2577dc17d25bfde https://github.com/buildbot/buildbot/commit/30788834d8886046c6faf645f2577dc17d25bfde Author: Dustin J. Mitchell Date: 2013-08-11 (Sun, 11 Aug 2013) Changed paths: M master/docs/developer/www.rst Log Message: ----------- minor docs edits Commit: 30794e8030be891ef5beaa8772044de26d0e782b https://github.com/buildbot/buildbot/commit/30794e8030be891ef5beaa8772044de26d0e782b Author: Dustin J. Mitchell Date: 2013-08-11 (Sun, 11 Aug 2013) Changed paths: M master/buildbot/data/connector.py M master/buildbot/data/root.py M master/buildbot/test/unit/test_data_root.py M master/docs/developer/data.rst M master/docs/developer/www.rst Log Message: ----------- verify spec formatting Compare: https://github.com/buildbot/buildbot/compare/1d9e2c941974...30794e8030be From trac at buildbot.net Mon Aug 12 01:20:18 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 01:20:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.2397d92d5b082e2771fe21e5421d6e26@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by cmumford): Replying to [comment:3 dustin]: > That's a good, smart workaround. Do you want to try your hand at the fix I suggested in comment 1? Sure I'll give it a try, send me the info. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 12:15:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 12:15:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2542: GitPoller fails on branch not existing, but doesnt poll the other branches In-Reply-To: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> References: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> Message-ID: <056.d7ec8189d6f299ed211f5f57eaa622dd@buildbot.net> #2542: GitPoller fails on branch not existing, but doesnt poll the other branches ------------------------+-------------------- Reporter: mlakewood | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: GitPoller | ------------------------+-------------------- Comment (by mlakewood): Sure, i'll have a crack. Any pointers on where to start looking, im not vary familiar with where the GitPoller tests etc are. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 13:30:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 13:30:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.d114b86db5ab99c733c75a1936231bcd@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): Sure - see `_describe` in master/buildbot/steps/shell.py. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 13:32:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 13:32:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2542: GitPoller fails on branch not existing, but doesnt poll the other branches In-Reply-To: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> References: <041.93f3279ac976d653b4dbbe61e4bcc6fb@buildbot.net> Message-ID: <056.1bacdafbcdcfa5a444fe7cc0c4e20f6a@buildbot.net> #2542: GitPoller fails on branch not existing, but doesnt poll the other branches ------------------------+-------------------- Reporter: mlakewood | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: GitPoller | ------------------------+-------------------- Comment (by dustin): Cool! They're in `master/buildbot/changes/gitpoller.py` and `master/buildbot/test/unit/test_changes_gitpoller.py` -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 14:57:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 14:57:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.db02374af4b1165511eaad8f4ce8e791@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by kkryger): Slave-side. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 15:05:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 15:05:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.bb9798443b3e1d1f0fb9161e962f382c@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by dustin): You'll be happier switching to the master-side steps. The slave-side are deprecated. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Aug 12 17:45:50 2013 From: noreply at github.com (GitHub) Date: Mon, 12 Aug 2013 10:45:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 60ab1c: fix the github tests Message-ID: <52091f4e42505_2229c7dd5086821@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 60ab1c0efc2f34a614804b6832f531bd22bd9bde https://github.com/buildbot/buildbot/commit/60ab1c0efc2f34a614804b6832f531bd22bd9bde Author: Buck Golemon Date: 2013-08-06 (Tue, 06 Aug 2013) Changed paths: M master/buildbot/test/unit/test_status_github.py Log Message: ----------- fix the github tests Commit: bde326cbc283ea0d57c44a08d938d3f0e08b4244 https://github.com/buildbot/buildbot/commit/bde326cbc283ea0d57c44a08d938d3f0e08b4244 Author: Buck Golemon Date: 2013-08-12 (Mon, 12 Aug 2013) Changed paths: M master/buildbot/test/unit/test_status_github.py Log Message: ----------- assert statements are bad, mkay? Commit: ca5353e458b25ceb19402f47ca564532a9ba513e https://github.com/buildbot/buildbot/commit/ca5353e458b25ceb19402f47ca564532a9ba513e Author: Dustin J. Mitchell Date: 2013-08-12 (Mon, 12 Aug 2013) Changed paths: M master/buildbot/test/unit/test_status_github.py Log Message: ----------- Merge branch 'buck-fix-github' of git://github.com/bukzor/buildbot Compare: https://github.com/buildbot/buildbot/compare/344d85983a17...ca5353e458b2 From trac at buildbot.net Mon Aug 12 18:03:46 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 18:03:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2549: Repo buildstep AttributeError no attribute 'pathmodule' on force scheduler Message-ID: <039.560cc427fe9d184868771290be0d2e67@buildbot.net> #2549: Repo buildstep AttributeError no attribute 'pathmodule' on force scheduler --------------------+----------------------- Reporter: y2kenny | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: --------------------+----------------------- Buildbot version: 0.8.8rc1 (master), with 0.8.7p1 (slave) Twisted version: 13.1.0 Step triggered using ForceScheduler Traceback (most recent call last): File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1213, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks result = g.send(result) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 237, in doStartVC d = self.doRepoSync() File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1213, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) --- --- File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks result = g.send(result) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 264, in doRepoSync updatable = yield self.sourcedirIsUpdateable() File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 220, in sourcedirIsUpdateable return self.pathExists(self.repoDir()) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 217, in repoDir return self.build.pathmodule.join(self.workdir, ".repo") exceptions.AttributeError: Build instance has no attribute 'pathmodule' -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 18:05:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 18:05:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2549: Repo buildstep AttributeError no attribute 'pathmodule' on force scheduler In-Reply-To: <039.560cc427fe9d184868771290be0d2e67@buildbot.net> References: <039.560cc427fe9d184868771290be0d2e67@buildbot.net> Message-ID: <054.4768a17b9ce39827b84616f4260647ad@buildbot.net> #2549: Repo buildstep AttributeError no attribute 'pathmodule' on force scheduler --------------------+-------------------- Reporter: y2kenny | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: master | Resolution: Keywords: gerrit | --------------------+-------------------- Changes (by dustin): * cc: tardyp (added) * keywords: => gerrit * milestone: undecided => 0.8.8 Old description: > Buildbot version: 0.8.8rc1 (master), with 0.8.7p1 (slave) > Twisted version: 13.1.0 > > Step triggered using ForceScheduler > > Traceback (most recent call last): > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/twisted/internet/defer.py", line 1213, in unwindGenerator > return _inlineCallbacks(None, gen, Deferred()) > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks > result = g.send(result) > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/buildbot/steps/source/repo.py", line 237, in doStartVC > d = self.doRepoSync() > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/twisted/internet/defer.py", line 1213, in unwindGenerator > return _inlineCallbacks(None, gen, Deferred()) > --- --- > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks > result = g.send(result) > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/buildbot/steps/source/repo.py", line 264, in doRepoSync > updatable = yield self.sourcedirIsUpdateable() > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/buildbot/steps/source/repo.py", line 220, in > sourcedirIsUpdateable > return self.pathExists(self.repoDir()) > File "/home/jba/buildbot088/local/lib/python2.7/site- > packages/buildbot/steps/source/repo.py", line 217, in repoDir > return self.build.pathmodule.join(self.workdir, ".repo") > exceptions.AttributeError: Build instance has no attribute 'pathmodule' New description: Buildbot version: 0.8.8rc1 (master), with 0.8.7p1 (slave) Twisted version: 13.1.0 Step triggered using ForceScheduler {{{ Traceback (most recent call last): File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1213, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks result = g.send(result) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 237, in doStartVC d = self.doRepoSync() File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1213, in unwindGenerator return _inlineCallbacks(None, gen, Deferred()) --- --- File "/home/jba/buildbot088/local/lib/python2.7/site- packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks result = g.send(result) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 264, in doRepoSync updatable = yield self.sourcedirIsUpdateable() File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 220, in sourcedirIsUpdateable return self.pathExists(self.repoDir()) File "/home/jba/buildbot088/local/lib/python2.7/site- packages/buildbot/steps/source/repo.py", line 217, in repoDir return self.build.pathmodule.join(self.workdir, ".repo") exceptions.AttributeError: Build instance has no attribute 'pathmodule' }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 18:36:00 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 18:36:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2525: Uninterruptible git step In-Reply-To: <039.6fc3d6efa946a969c853f18cc7a793df@buildbot.net> References: <039.6fc3d6efa946a969c853f18cc7a793df@buildbot.net> Message-ID: <054.b34390ade9c300975a165e2c09167ef1@buildbot.net> #2525: Uninterruptible git step --------------------+------------------------ Reporter: brendan | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: Keywords: git | --------------------+------------------------ Comment (by brendan): https://gist.github.com/srinupiits/5959434 appears to have fixed the problem. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 18:45:34 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 18:45:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2525: Uninterruptible git step In-Reply-To: <039.6fc3d6efa946a969c853f18cc7a793df@buildbot.net> References: <039.6fc3d6efa946a969c853f18cc7a793df@buildbot.net> Message-ID: <054.cfd98ff882e7f9f68e375acc6f41ee60@buildbot.net> #2525: Uninterruptible git step --------------------+------------------------ Reporter: brendan | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.5 | Resolution: duplicate Keywords: git | --------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: That was for #2356 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 19:06:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 19:06:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.18f989b51caad3469e66e6432d596a6f@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by kkryger): That may be an eventuality, but for right now, what can I do about it? And, how long will the deprecated steps be around? When will they be removed? Should this behavior be documented? Does the master-side step error correctly if the same scenario described above happens? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Aug 12 19:18:19 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 12 Aug 2013 19:18:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.84c648ded2a1f766cc91851b6ad18819@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by dustin): Certainly if there's a fix for this, we'll merge it, but I don't personally intend to work on this. The slave-side steps will be around for 0.8.8, but perhaps not after that. We've been waiting until a few bugs and annoyances in the master-side steps were fixed, and Srinu is taking care of that as his Google Summer of Code project. I haven't tested it directly, but yes, I expect that the master-side step will treat that as a failure. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 13 14:26:50 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 13 Aug 2013 14:26:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.0d91b0739117940a2f4e60ea26127765@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by cmumford): Replying to [comment:5 dustin]: > Sure - see `_describe` in master/buildbot/steps/shell.py. I see - cool. Nothing beats reading the code. So if I understand correctly, you're suggesting that I override the ShellCommand.describe method with my own. I think that would be about the same amount of code - possibly just a bit more. BTW I do think the problem is a bit more complicated than just the descriptions because the shell command, which also passes in a property as a command-line argument, also passes in 'None' on the first build - and I've had to work around that as well. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Aug 13 15:09:05 2013 From: noreply at github.com (GitHub) Date: Tue, 13 Aug 2013 08:09:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dadd9a: Those new fancy npm tools need npm >1.2 (peerDepen... Message-ID: <520a4c11d8f7e_3e07ba9d485114d@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: dadd9a6079de587a0b993a29c2416235b62afc4d https://github.com/buildbot/buildbot/commit/dadd9a6079de587a0b993a29c2416235b62afc4d Author: Pierre Tardy Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M www/setup.py Log Message: ----------- Those new fancy npm tools need npm >1.2 (peerDependancy feature) + bootstap 3.0.0 dependancy Signed-off-by: Pierre Tardy Commit: 61e776849bbdf466f452ba4edbfd5b6a0448e6e5 https://github.com/buildbot/buildbot/commit/61e776849bbdf466f452ba4edbfd5b6a0448e6e5 Author: Dustin J. Mitchell Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M www/setup.py Log Message: ----------- Merge branch 'nine' of git://github.com/tardyp/buildbot into nine Compare: https://github.com/buildbot/buildbot/compare/30794e8030be...61e776849bbd From noreply at github.com Tue Aug 13 15:09:08 2013 From: noreply at github.com (GitHub) Date: Tue, 13 Aug 2013 08:09:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 393be2: Possibility to select categories to show in waterf... Message-ID: <520a4c14ad947_4c3112d3d5867444@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 393be2a31d6cac5eb3ddf2de431bb21b477984fc https://github.com/buildbot/buildbot/commit/393be2a31d6cac5eb3ddf2de431bb21b477984fc Author: llloret Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/web/waterfall.py Log Message: ----------- Possibility to select categories to show in waterfall help Commit: bdb06f054dba41fdf938317d18dacaa7982c5e7c https://github.com/buildbot/buildbot/commit/bdb06f054dba41fdf938317d18dacaa7982c5e7c Author: llloret Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Added comment in release notes Commit: 0ebd2051141932c892f9ef2115034001382a88d8 https://github.com/buildbot/buildbot/commit/0ebd2051141932c892f9ef2115034001382a88d8 Author: Dustin J. Mitchell Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/web/waterfall.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'show_categories_in_waterfallhelp' of git://github.com/llloret/buildbot Compare: https://github.com/buildbot/buildbot/compare/ca5353e458b2...0ebd20511419 From trac at buildbot.net Tue Aug 13 15:12:27 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 13 Aug 2013 15:12:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.ff9101745c050326c7b6b1b8afab6c79@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by dustin): Well, I'm suggesting a patch that would modify `describe` directly. There are some escapes you can use in Interpolate references to translate None to an empty string or some other string. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 13 22:22:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 13 Aug 2013 22:22:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.0262c2a2dd64493886f1e5fac298b68b@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by kkryger): Sure does fail correctly. Now I just have to convert around 30 factories to use the master side step. Oh joy xD Both ways call rmDirRecursive from 'buildslave\commands\utils.py', and both fail the same way. Odd that one considers it a failure and the other doesn't. Do you have a way to make notes to previous version docs for caveats such as this? Like, for 0.8.6p1->~0.8.8(and presumably lower), 'the slave-side can fail an svn purge in Windows and not report it as a failure'? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 13 22:24:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 13 Aug 2013 22:24:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.d0b20b67dd7cac3130cbc998aaa9f3c6@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by dustin): This bug is probably good documentation for that -- Google finds it :) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 13 22:51:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 13 Aug 2013 22:51:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.6bb366ef2fa54f52c735b4f45b88220e@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by kkryger): I guess it can be closed however you see fit, then :) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 13 23:07:29 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 13 Aug 2013 23:07:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2535: SVN Update steps are not marked failures due to rmDirRecursive failing In-Reply-To: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> References: <039.98f8a8c98ca8e9901b3b472d2a2f5919@buildbot.net> Message-ID: <054.d55ce319e2f32fdc2881d3ea873a39ef@buildbot.net> #2535: SVN Update steps are not marked failures due to rmDirRecursive failing --------------------------------+-------------------- Reporter: kkryger | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: svn, steps, windows | --------------------------------+-------------------- Comment (by dustin): Only when it's fixed or no longer relevant -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 14 16:57:28 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 14 Aug 2013 16:57:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.bae2d591211c89ee874359458abc5711@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+--------------------- Reporter: jroo | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: fixed Keywords: gerrit git master-side-source-steps | ------------------------------------------------+--------------------- Comment (by cbessette): Using https://raw.github.com/buildbot/buildbot/5a2b8ee0b559712d6413100aeee49a42ec5cd0cf/master/buildbot/steps/source/gerrit.py with Buildbot 0.8.7p1 worked for me. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 14 20:34:47 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 14 Aug 2013 20:34:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2550: GerritStatusPush: fatal: "--verified" is not a valid option Message-ID: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> #2550: GerritStatusPush: fatal: "--verified" is not a valid option ----------------------+----------------------- Reporter: cbessette | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: gerrit ----------------------+----------------------- As of Gerrit 2.6, "--verified" is no longer an option for gerrit review, even though it exists in the documentation: http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/cmd- review.html You now must do "--label Verified=+1" to verify. Even with the Verify label correctly installed and working, "--verified" still doesn't work. Please update master/buildbot/status/status_gerrit.py to support the label syntax to Verify. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 14 21:10:51 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 14 Aug 2013 21:10:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2550: GerritStatusPush: fatal: "--verified" is not a valid option In-Reply-To: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> References: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> Message-ID: <056.e5396bdbba483478f36f5c5eb9771ec3@buildbot.net> #2550: GerritStatusPush: fatal: "--verified" is not a valid option ----------------------+------------------------ Reporter: cbessette | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: gerrit | ----------------------+------------------------ Comment (by cbessette): The necessary change: {{{ -command.extend(["--verified %d" % int(verified)]) +command.extend(["--label Verified=%d" % int(verified)]) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 14 21:20:31 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 14 Aug 2013 21:20:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2550: GerritStatusPush: fatal: "--verified" is not a valid option In-Reply-To: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> References: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> Message-ID: <056.58549fc176744f93fa5de220d9164f90@buildbot.net> #2550: GerritStatusPush: fatal: "--verified" is not a valid option ----------------------+------------------------ Reporter: cbessette | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: gerrit | ----------------------+------------------------ Comment (by dustin): Want to make a Github pull req so you can get due credit? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 14 21:46:02 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 14 Aug 2013 21:46:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2550: GerritStatusPush: fatal: "--verified" is not a valid option In-Reply-To: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> References: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> Message-ID: <056.84c220af476bac4d9a1557e84f881d61@buildbot.net> #2550: GerritStatusPush: fatal: "--verified" is not a valid option ----------------------+------------------------ Reporter: cbessette | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: gerrit | ----------------------+------------------------ Comment (by cbessette): Will do! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Aug 15 14:47:44 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 15 Aug 2013 14:47:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2550: GerritStatusPush: fatal: "--verified" is not a valid option In-Reply-To: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> References: <041.a8eb05ccb9ffecccf4e2b8befee0f532@buildbot.net> Message-ID: <056.879b4c4859d04eb4c80b7b0bef2bf018@buildbot.net> #2550: GerritStatusPush: fatal: "--verified" is not a valid option ----------------------+------------------------ Reporter: cbessette | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: gerrit | ----------------------+------------------------ Comment (by cbessette): https://github.com/buildbot/buildbot/pull/830 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Aug 15 18:41:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 15 Aug 2013 18:41:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2551: Triggered builds containing steps synchronized by a SlaveLock (counting or exclusive) are sometimes not run. Message-ID: <040.d17453a9a5b8a08bf38aa0d9df97dfb3@buildbot.net> #2551: Triggered builds containing steps synchronized by a SlaveLock (counting or exclusive) are sometimes not run. ---------------------+------------------------- Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: Triggerable ---------------------+------------------------- I have a test buildbot configuration with two builders (that build), one of which triggers six other test builds. There are only two test build slaves which use a SlaveLock to ensure that a slave only runs one test at a time. In this configuration if I make changes to the monitored Git repository, which in turn fires off four builds, there will often be several test slaves which are never run. There is no evidence in either the master or slave logs to indicate the cause (that I can see). Steps to reproduce: 1. Expand the attached archive. 2. $ cd bbtest/bbtest 3. $ make # This starts both server and a few slaves. 4. $ make bumpseveral; sleep 8; make bumpseveral 5. Wait for builds/tests to finish (approx 1-2 minutes). 6. $ tree /tmp/build_artifacts Each android build artifact should have six test results files as so: {{{ /tmp/build_artifacts ??? build_0 ??? ??? android ??? ??? ??? test1 ??? ??? ??? test1_results.txt ??? ??? ??? test2 ??? ??? ??? test2_results.txt ??? ??? ??? test3 ??? ??? ??? test3_results.txt ??? ??? ??? test4 ??? ??? ??? test4_results.txt ??? ??? ??? test5 ??? ??? ??? test5_results.txt ??? ??? ??? test6 ??? ??? ??? test6_results.txt ??? ??? gtk ??? ??? test1 ??? ??? test2 ??? ??? test3 ??? ??? test4 ??? ??? test5 ??? ??? test6 }}} But sometimes you will see a build with one or more tests which are '''not''' run: {{{ ??? build_2 ??? ??? android ??? ??? ??? test1 ??? ??? ??? test2 ??? ??? ??? test3 ??? ??? ??? test4 ??? ??? ??? test4_results.txt ??? ??? ??? test5 ??? ??? ??? test5_results.txt ??? ??? ??? test6 ??? ??? ??? test6_results.txt ??? ??? gtk ??? ??? test1 ??? ??? test2 ??? ??? test3 ??? ??? test4 ??? ??? test5 ??? ??? test6 }}} If you look in the waterfall or grid you will see that the test is not run. If I bump the maxCountForSlave's from 1 to 10 then I cannot reproduce the problem. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Aug 15 20:41:49 2013 From: noreply at github.com (GitHub) Date: Thu, 15 Aug 2013 13:41:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2753fc: more explicit description of symbol styles Message-ID: <520d3d0d23b1b_40216e9d586415f@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 2753fc4e79b0a530945d67f3272c287323c0756c https://github.com/buildbot/buildbot/commit/2753fc4e79b0a530945d67f3272c287323c0756c Author: Dustin J. Mitchell Date: 2013-04-24 (Wed, 24 Apr 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- more explicit description of symbol styles Commit: 47ef757bf9fa8244da7408c1e6af7f2d22e12372 https://github.com/buildbot/buildbot/commit/47ef757bf9fa8244da7408c1e6af7f2d22e12372 Author: ludovicchabant Date: 2013-05-07 (Tue, 07 May 2013) Changed paths: A master/buildbot/steps/mswin.py Log Message: ----------- Added Windows-specific buildsteps module. Right now it only contains a `Robocopy` step. Commit: bea09883783f56149fb978e1acfda2246b5b41da https://github.com/buildbot/buildbot/commit/bea09883783f56149fb978e1acfda2246b5b41da Author: ludovicchabant Date: 2013-05-08 (Wed, 08 May 2013) Changed paths: M master/buildbot/changes/p4poller.py Log Message: ----------- Ability to specify a timezone for a P4 server The Perforce server used with `P4Source` may be in a different time zone than the Buildbot master, which would cause, for example, changes to be displayed in the wrong place on the Waterfall display. This change lets you specify a timezone for the server. Changelist times will be converted from that timezone to the local timezone before being added to the Buildbot master. Commit: 926badd856f863af4ef4b881ea76f413fe7de035 https://github.com/buildbot/buildbot/commit/926badd856f863af4ef4b881ea76f413fe7de035 Author: ludovicchabant Date: 2013-05-09 (Thu, 09 May 2013) Changed paths: M master/buildbot/steps/mswin.py Log Message: ----------- Fixed Robocopy step status Robocopy actually returns a combination of flags to indicate success/warning/failure status. Commit: ff9404be98a7f2d4082fab0ac2a897dea2fc9090 https://github.com/buildbot/buildbot/commit/ff9404be98a7f2d4082fab0ac2a897dea2fc9090 Author: Ludovic Chabant Date: 2013-05-28 (Tue, 28 May 2013) Changed paths: M master/buildbot/steps/mswin.py Log Message: ----------- Added information about Robocopy exit codes. Commit: f3032198239393e66469d53b3d2753e2bbfd611c https://github.com/buildbot/buildbot/commit/f3032198239393e66469d53b3d2753e2bbfd611c Author: ludovicchabant Date: 2013-05-28 (Tue, 28 May 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Added documentation about Robocopy step. Commit: 41f865f110dd84a70a50196a775c226f2e39b5f1 https://github.com/buildbot/buildbot/commit/41f865f110dd84a70a50196a775c226f2e39b5f1 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/buildbot/steps/mswin.py Log Message: ----------- Removed docstring for Robocopy step. All usage information is only in the documentation page now. Commit: 6336819584472892651732e3e93a0d941ed5f1c7 https://github.com/buildbot/buildbot/commit/6336819584472892651732e3e93a0d941ed5f1c7 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/docs/manual/cfg-changesources.rst Log Message: ----------- Documentation about timezone support in P4 changesource Commit: f915175d48680e49c4a09e4b020a61123b9b3c79 https://github.com/buildbot/buildbot/commit/f915175d48680e49c4a09e4b020a61123b9b3c79 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Release notes for Robocopy and P4 changes. Commit: 2bc2399d5ec2861ac8fda42402d73e55eedbb71a https://github.com/buildbot/buildbot/commit/2bc2399d5ec2861ac8fda42402d73e55eedbb71a Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Fixed P4 source unit tests on Windows This is because P4 normalizes slashes/backslashes, so we need to set our expectations right. Commit: 13b870b7dbb071f70ab685992c18e4ff2efd4a96 https://github.com/buildbot/buildbot/commit/13b870b7dbb071f70ab685992c18e4ff2efd4a96 Author: Ludovic Chabant Date: 2013-07-03 (Wed, 03 Jul 2013) Changed paths: M master/buildbot/steps/mswin.py A master/buildbot/test/unit/test_steps_mswin.py Log Message: ----------- Added unit tests for Robocopy step. Fixed whitespace. Commit: 8f2e82a1fe3d3cb8b64cc6c72178f429c5cebede https://github.com/buildbot/buildbot/commit/8f2e82a1fe3d3cb8b64cc6c72178f429c5cebede Author: Ludovic Chabant Date: 2013-07-04 (Thu, 04 Jul 2013) Changed paths: M master/buildbot/steps/mswin.py M master/buildbot/test/unit/test_steps_mswin.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Don't pass `/UNICODE` to Robocopy by default. Commit: 1800e21c86ef79d5616ed1f4c1db04dd1dadb10a https://github.com/buildbot/buildbot/commit/1800e21c86ef79d5616ed1f4c1db04dd1dadb10a Author: Ludovic Chabant Date: 2013-07-04 (Thu, 04 Jul 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Added more information about Robocopy in the docs. Commit: 3a563189374737aa2ebf3f6467bf461bc3ec5443 https://github.com/buildbot/buildbot/commit/3a563189374737aa2ebf3f6467bf461bc3ec5443 Author: Pierre Tardy Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/status/web/files/default.css M master/buildbot/status/web/logs.py Log Message: ----------- logs: implement on the fly parsing of ansi code grunt and js tools have the habit of using ansi code a lot, which are ugly inside python log window. http://en.wikipedia.org/wiki/ANSI_escape_code This is a simple enough implementation of ansicode parser which integrates well into buildbot's way of displaying logs Signed-off-by: Pierre Tardy Commit: 99b38cd99afb854a52ecb579c2fb439a1d2291e9 https://github.com/buildbot/buildbot/commit/99b38cd99afb854a52ecb579c2fb439a1d2291e9 Author: Ludovic Chabant Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Fixed 2.5 incompatibility in p4 tests Commit: 44c52eb4d83d56c0195a94478ccd7b4fa072ed59 https://github.com/buildbot/buildbot/commit/44c52eb4d83d56c0195a94478ccd7b4fa072ed59 Author: Ludovic Chabant Date: 2013-07-17 (Wed, 17 Jul 2013) Changed paths: M master/buildbot/test/unit/test_changes_p4poller.py Log Message: ----------- Fixed p4 poller tests Commit: 45430e1e670b9cd43666f4bf6e6c1f2a30733255 https://github.com/buildbot/buildbot/commit/45430e1e670b9cd43666f4bf6e6c1f2a30733255 Author: ????? ???????? Date: 2013-07-20 (Sat, 20 Jul 2013) Changed paths: M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Fix buildslave init script errors saying "buildmaster" Also, change ${i} to ${index} for consistency with surrounding code. Commit: 28ddd095e3295ec9d74b3fe56ac77a3e782f4958 https://github.com/buildbot/buildbot/commit/28ddd095e3295ec9d74b3fe56ac77a3e782f4958 Author: Kevin Funk Date: 2013-07-22 (Mon, 22 Jul 2013) Changed paths: M master/buildbot/revlinks.py M master/buildbot/test/unit/test_revlinks.py Log Message: ----------- Add RevlinkMatch for new SourceForge platform Also add tests Commit: 38ee978cc0e5a9e1e9eda5ef80f0e56fcf9a80ab https://github.com/buildbot/buildbot/commit/38ee978cc0e5a9e1e9eda5ef80f0e56fcf9a80ab Author: Kevin Funk Date: 2013-07-22 (Mon, 22 Jul 2013) Changed paths: M master/buildbot/test/unit/test_revlinks.py Log Message: ----------- Improve coverage: Add test for RevlinkMultiplexer Commit: 5c5c2961cb94b3ce44be77e4e9ba26bc4d9b02e0 https://github.com/buildbot/buildbot/commit/5c5c2961cb94b3ce44be77e4e9ba26bc4d9b02e0 Author: Kevin Funk Date: 2013-07-29 (Mon, 29 Jul 2013) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Minor: Improve debugging output in words.py Commit: d99f53b0f5a32caa0a79817657fc2be8f09bea54 https://github.com/buildbot/buildbot/commit/d99f53b0f5a32caa0a79817657fc2be8f09bea54 Author: Elmir Jagudin Date: 2013-07-31 (Wed, 31 Jul 2013) Changed paths: M common/pylintrc Log Message: ----------- new pylint configuration * disable all currently reported messages * document checks that we don't care about * tweaked symbol name regexps to match buildbot's style Commit: 8e01ed68c1ae84c2345e79d4b6be076865e4e8ed https://github.com/buildbot/buildbot/commit/8e01ed68c1ae84c2345e79d4b6be076865e4e8ed Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: A master/buildbot/status/web/hooks/gitorious.py Log Message: ----------- gitorious change hook dialect Commit: 1302fc6941cb10e3cb9b450ec84296027140c53d https://github.com/buildbot/buildbot/commit/1302fc6941cb10e3cb9b450ec84296027140c53d Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: A master/buildbot/test/unit/test_status_web_hooks_gitorious.py Log Message: ----------- gitorious test cases Commit: 6f4f3e48b09d7ee2a3a234e8e713c214087d7c98 https://github.com/buildbot/buildbot/commit/6f4f3e48b09d7ee2a3a234e8e713c214087d7c98 Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- gitorious web hook docs Commit: 3e741154f7dfccbce33d2109c3b6f2b9c069fbdf https://github.com/buildbot/buildbot/commit/3e741154f7dfccbce33d2109c3b6f2b9c069fbdf Author: Srinu P Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/unit/test_process_buildstep.py Log Message: ----------- Buildbot interrupts master-side source steps. Fixes #2356 Commit: 5955deb57d7b352b7c259837fcb2452e7e97226f https://github.com/buildbot/buildbot/commit/5955deb57d7b352b7c259837fcb2452e7e97226f Author: K?lm?n Viktor Date: 2013-08-01 (Thu, 01 Aug 2013) Changed paths: M master/buildbot/status/web/hooks/gitorious.py M master/docs/relnotes/index.rst Log Message: ----------- removed docstrings from gitorious.py and added relnotes Commit: 7f472e329d8bf9d3abdf17b6d239afbe014c2f7f https://github.com/buildbot/buildbot/commit/7f472e329d8bf9d3abdf17b6d239afbe014c2f7f Author: Buck Golemon Date: 2013-08-02 (Fri, 02 Aug 2013) Changed paths: M .gitignore Log Message: ----------- tweak gitignore of vim swap files Commit: efd0d6a14683df2a0e08601da7dea5771fb18c6d https://github.com/buildbot/buildbot/commit/efd0d6a14683df2a0e08601da7dea5771fb18c6d Author: Srinu P Date: 2013-08-05 (Mon, 05 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Fix StrictVersion issue Commit: e359d0026c223520df79096bc934c0e37fb0ba43 https://github.com/buildbot/buildbot/commit/e359d0026c223520df79096bc934c0e37fb0ba43 Author: Olof Johansson Date: 2013-08-08 (Thu, 08 Aug 2013) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- builddir and workdir properties should be strings, not tuples Commit: dbdc3293cd8f339a66f9cdb19d0aaf7bbc73f668 https://github.com/buildbot/buildbot/commit/dbdc3293cd8f339a66f9cdb19d0aaf7bbc73f668 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py Log Message: ----------- Merge branch 'bug2504-1' of git://github.com/srinupiits/buildbot Commit: f465a19a69530ffb11e2238e3e2b1b060353e0aa https://github.com/buildbot/buildbot/commit/f465a19a69530ffb11e2238e3e2b1b060353e0aa Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/steps/mswin.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_steps_mswin.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- fix bugs in handling unkown return codes, pyflakes ..and return Deferreds from test methods. Commit: 86d8ba49c19a4099a30fe0584cc0419fc1afadff https://github.com/buildbot/buildbot/commit/86d8ba49c19a4099a30fe0584cc0419fc1afadff Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/changes/p4poller.py A master/buildbot/steps/mswin.py M master/buildbot/test/unit/test_changes_p4poller.py A master/buildbot/test/unit/test_steps_mswin.py M master/buildbot/test/unit/test_steps_source_p4.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'pull728' Commit: a5dbf75b8e615c6d05e6fe0b8e6d5a1f8f35e037 https://github.com/buildbot/buildbot/commit/a5dbf75b8e615c6d05e6fe0b8e6d5a1f8f35e037 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M common/pylintrc Log Message: ----------- Merge branch 'pylint' of git://github.com/elmirjagudin/buildbot Commit: d6bf7573cd3d182dc1f169206b38171e8a5660f6 https://github.com/buildbot/buildbot/commit/d6bf7573cd3d182dc1f169206b38171e8a5660f6 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Merge branch 'slave-not-master' of git://github.com/SpecLad/buildbot Commit: 5584042f8a0e398c0ad597ed40cdc61341333042 https://github.com/buildbot/buildbot/commit/5584042f8a0e398c0ad597ed40cdc61341333042 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/docs/developer/style.rst Log Message: ----------- Merge branch 'symbol-style' of git://github.com/djmitche/buildbot Commit: 15dd0f1805cd514d6fbc47bb56bde808d8eb01db https://github.com/buildbot/buildbot/commit/15dd0f1805cd514d6fbc47bb56bde808d8eb01db Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/revlinks.py M master/buildbot/test/unit/test_revlinks.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'add-sourceforge_allura-revlinkmatch' of git://github.com/krf/buildbot Commit: 7d6df157dd284c8b655becaedb90cf137cd97dd7 https://github.com/buildbot/buildbot/commit/7d6df157dd284c8b655becaedb90cf137cd97dd7 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/words.py Log Message: ----------- Merge branch 'small-fixes' of git://github.com/krf/buildbot Commit: c94cd9abb0a166d71cc73953ccec589b67bc2e81 https://github.com/buildbot/buildbot/commit/c94cd9abb0a166d71cc73953ccec589b67bc2e81 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/files/default.css M master/buildbot/status/web/logs.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'ansicodes' of git://github.com/tardyp/buildbot Commit: d04cd8bee344244333d5b6205db28077c1cbddcd https://github.com/buildbot/buildbot/commit/d04cd8bee344244333d5b6205db28077c1cbddcd Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2356-1' of git://github.com/srinupiits/buildbot Commit: 517d485a54552d165f970941330cab620a36d0a4 https://github.com/buildbot/buildbot/commit/517d485a54552d165f970941330cab620a36d0a4 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: A master/buildbot/status/web/hooks/gitorious.py A master/buildbot/test/unit/test_status_web_hooks_gitorious.py M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'buildbot-gitorious-hook' of git://github.com/kviktor/buildbot Conflicts: master/docs/relnotes/index.rst Commit: 016178a600c019c4e0f42f2461713882dbe7368a https://github.com/buildbot/buildbot/commit/016178a600c019c4e0f42f2461713882dbe7368a Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M .gitignore Log Message: ----------- Merge branch 'master-buck' of git://github.com/bukzor/buildbot Commit: 0cb82385e761fdfe7b5027f67544fafa986d3397 https://github.com/buildbot/buildbot/commit/0cb82385e761fdfe7b5027f67544fafa986d3397 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/buildrequestdistributor.py M master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py Log Message: ----------- Merge branch 'buck-silent-nextBuild' of git://github.com/bukzor/buildbot Commit: f50722369168085235c795cd7997abc07a790c7c https://github.com/buildbot/buildbot/commit/f50722369168085235c795cd7997abc07a790c7c Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/process/build.py M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Merge branch 'fix/dont_tuplify_builddir' of git://github.com/olof/buildbot Commit: 92b12b4bb33b2ad402d141ed2909dc6521e1cdc7 https://github.com/buildbot/buildbot/commit/92b12b4bb33b2ad402d141ed2909dc6521e1cdc7 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- Merge branch 'buck-modernize-test-db-buildrequests' of git://github.com/bukzor/buildbot (with tabs -> spaces) Commit: 344d85983a17c7571672135dc4da57f72f4dc5b2 https://github.com/buildbot/buildbot/commit/344d85983a17c7571672135dc4da57f72f4dc5b2 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/steps/package/rpm/rpmlint.py Log Message: ----------- Keep the config arguments for RPMLint Based on the patch in https://bugzilla.redhat.com/show_bug.cgi?id=836624 Commit: bde326cbc283ea0d57c44a08d938d3f0e08b4244 https://github.com/buildbot/buildbot/commit/bde326cbc283ea0d57c44a08d938d3f0e08b4244 Author: Buck Golemon Date: 2013-08-12 (Mon, 12 Aug 2013) Changed paths: M master/buildbot/test/unit/test_status_github.py Log Message: ----------- assert statements are bad, mkay? Commit: ca5353e458b25ceb19402f47ca564532a9ba513e https://github.com/buildbot/buildbot/commit/ca5353e458b25ceb19402f47ca564532a9ba513e Author: Dustin J. Mitchell Date: 2013-08-12 (Mon, 12 Aug 2013) Changed paths: M master/buildbot/test/unit/test_status_github.py Log Message: ----------- Merge branch 'buck-fix-github' of git://github.com/bukzor/buildbot Commit: 393be2a31d6cac5eb3ddf2de431bb21b477984fc https://github.com/buildbot/buildbot/commit/393be2a31d6cac5eb3ddf2de431bb21b477984fc Author: llloret Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/web/waterfall.py Log Message: ----------- Possibility to select categories to show in waterfall help Commit: bdb06f054dba41fdf938317d18dacaa7982c5e7c https://github.com/buildbot/buildbot/commit/bdb06f054dba41fdf938317d18dacaa7982c5e7c Author: llloret Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Added comment in release notes Commit: 0ebd2051141932c892f9ef2115034001382a88d8 https://github.com/buildbot/buildbot/commit/0ebd2051141932c892f9ef2115034001382a88d8 Author: Dustin J. Mitchell Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/web/waterfall.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'show_categories_in_waterfallhelp' of git://github.com/llloret/buildbot Commit: 02e9dfcf051418a7d8ca16b81f3180e530bd575c https://github.com/buildbot/buildbot/commit/02e9dfcf051418a7d8ca16b81f3180e530bd575c Author: Dustin J. Mitchell Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M .gitignore M common/pylintrc M master/buildbot/changes/p4poller.py M master/buildbot/process/build.py M master/buildbot/process/buildstep.py M master/buildbot/revlinks.py M master/buildbot/status/web/files/default.css A master/buildbot/status/web/hooks/gitorious.py M master/buildbot/status/web/logs.py M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/web/waterfall.py M master/buildbot/status/words.py A master/buildbot/steps/mswin.py M master/buildbot/steps/package/rpm/rpmlint.py M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_changes_p4poller.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_revlinks.py M master/buildbot/test/unit/test_status_github.py A master/buildbot/test/unit/test_status_web_hooks_gitorious.py A master/buildbot/test/unit/test_steps_mswin.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_p4.py M master/docs/developer/style.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Merge branch 'master' into nine Conflicts: master/buildbot/changes/p4poller.py master/buildbot/test/unit/test_changes_p4poller.py master/buildbot/test/unit/test_db_buildrequests.py Compare: https://github.com/buildbot/buildbot/compare/61e776849bbd...02e9dfcf0514 From trac at buildbot.net Sat Aug 17 00:24:20 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 17 Aug 2013 00:24:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2548: Git builder silently drops back to HEAD (master) if a branch isn't found In-Reply-To: <040.fb3a30906f32efd8fcc109b631bfbd2f@buildbot.net> References: <040.fb3a30906f32efd8fcc109b631bfbd2f@buildbot.net> Message-ID: <055.338b7eeaa3acb2fb41e603842195f3d4@buildbot.net> #2548: Git builder silently drops back to HEAD (master) if a branch isn't found ---------------------+------------------------ Reporter: chmorgan | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: git | ---------------------+------------------------ Comment (by dank): This burnt me today. In my case, on ubuntu, the warning was {{{ git version 1.7.0.4 ... git clone --branch rel-3.10 --recursive git.oblong.com:/ob/git/repo/staging.git . warning: Remote branch rel-3.10 not found in upstream origin, using HEAD instead }}} Happily, one of my bots did notice and fail. The good bot is running git 1.8.0.2, installed with 'sudo port install git-core'. {{{ git version 1.8.0.2 ... git clone --branch rel-3.10 --recursive git.oblong.com:/ob/git/repo/staging.git . Cloning into '.'... fatal: Remote branch rel-3.10 not found in upstream origin }}} So perhaps this is fixed in git-1.8 and higher? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Aug 17 14:04:38 2013 From: noreply at github.com (GitHub) Date: Sat, 17 Aug 2013 07:04:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 908590: Fix typos Message-ID: <520f82f6933c1_28fbbcbd587844a@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 908590dc81b43f7aeecb7d3f51037bef537bfaf8 https://github.com/buildbot/buildbot/commit/908590dc81b43f7aeecb7d3f51037bef537bfaf8 Author: Vladimir Rutsky Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildstep.py M master/buildbot/process/properties.py Log Message: ----------- Fix typos "doesn not", "certaily", "availble", "compatability", "positial", "availble" Commit: de730a9b1cd7b4002db52efd2a91d1ec5b8d1e78 https://github.com/buildbot/buildbot/commit/de730a9b1cd7b4002db52efd2a91d1ec5b8d1e78 Author: Vladimir Rutsky Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/changes/svnpoller.py Log Message: ----------- Fix method name in log Commit: 5c7625d4b07c61cd89919c91d153680fffa0409b https://github.com/buildbot/buildbot/commit/5c7625d4b07c61cd89919c91d153680fffa0409b Author: Dustin J. Mitchell Date: 2013-08-17 (Sat, 17 Aug 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildstep.py M master/buildbot/process/properties.py Log Message: ----------- Merge branch 'typos3' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/0ebd20511419...5c7625d4b07c From noreply at github.com Mon Aug 19 00:53:28 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 17:53:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b3c474: P4: Use config.error, instead of collecting errors... Message-ID: <52116c88a1637_5be6bbd541116a5@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 https://github.com/buildbot/buildbot/commit/b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use config.error, instead of collecting errors by hand. Commit: f838d86fe563745123d56bf764dafd61ef3d52dc https://github.com/buildbot/buildbot/commit/f838d86fe563745123d56bf764dafd61ef3d52dc Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use tools provided by CompositeStepMixin. Commit: ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3 https://github.com/buildbot/buildbot/commit/ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3 Author: Jared Grubb Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/docs/developer/cls-iproperties.rst M master/docs/developer/cls-irenderable.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-properties.rst Log Message: ----------- Docs: update some index references Commit: 789dedd66cf7b4064ce5f8ad0582717c336692ea https://github.com/buildbot/buildbot/commit/789dedd66cf7b4064ce5f8ad0582717c336692ea Author: Pierre Tardy Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- repo codingStyle fixes - repo step and unit tests are now pep8 compliant - fixed camelCase for repo step parameters - removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable - added test on repo download from changesource - update doc and release notes Signed-off-by: Pierre Tardy Commit: 75149f365576a97d2d7a486aab2aa00774991b28 https://github.com/buildbot/buildbot/commit/75149f365576a97d2d7a486aab2aa00774991b28 Author: Pierre Tardy Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- repo: add RepoDownloadsFromChangeSource renderable Suggestion from Tom to put this away from the step code. In cunjunction with FlattenList, this works well. + some more minor review handling Signed-off-by: Pierre Tardy Commit: dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51 https://github.com/buildbot/buildbot/commit/dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51 Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Update release notes. Commit: 1199199a3f4ce54a85a30f959ba5a4fee2f179db https://github.com/buildbot/buildbot/commit/1199199a3f4ce54a85a30f959ba5a4fee2f179db Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'repo-coding-style' into buildbot-0.8.8. - repo step and unit tests are now pep8 compliant - fixed camelCase for repo step parameters - removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable - added test on repo download from changesource - update doc and release notes Commit: cc8913b76c4932465f496c7262a4afb81ec1fe78 https://github.com/buildbot/buildbot/commit/cc8913b76c4932465f496c7262a4afb81ec1fe78 Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Revert adding slave-side support for sudo. Adding sudo to a command can easily be handled by on the master-side. Also, different people will have different expectations, which a single argument isn't enough to capture. See https://github.com/fabric/fabric/issues/503 for some discussions. This reverts commit b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e, reversing changes made to d0cd62b6049759d89b09b1512dab2268132fd30d. Commit: 478c79fe9024826403a6ee08d152859181178bfd https://github.com/buildbot/buildbot/commit/478c79fe9024826403a6ee08d152859181178bfd Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/process/factory.py M master/buildbot/test/unit/test_process_factory.py M master/docs/relnotes/index.rst Log Message: ----------- Add support for passing keyword arguments to BuildFactory.addStep. This was supported in old versions of buildbot, but there wasn't a release that supported both, making transitioning harder than necessary. Commit: 379603bc07b4ccef0993cedc025aeef1c63e5844 https://github.com/buildbot/buildbot/commit/379603bc07b4ccef0993cedc025aeef1c63e5844 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py R master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Revert 'try_client_available_builder_names'. This added ad-hoc support for overriding `getAvaliableBuilderNames` in a subclass of `TrySchedulerer`. But that support was undocumented and untested. This reverts commit 46a81edbecee41e9042b7d1bbf928e13d59e618d, reversing changes made to 9ec2372129b48842b5c3bc5e933b28ed728d46e3. Commit: 66f62be3dad57fcd7eb897807b5352c3e362e0ed https://github.com/buildbot/buildbot/commit/66f62be3dad57fcd7eb897807b5352c3e362e0ed Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Use `assertTrue`/`assertFalse` instead of `assertIdentical` where appropriate. Commit: e8147cc53069f1c73f10b7ab49016f45a90d934a https://github.com/buildbot/buildbot/commit/e8147cc53069f1c73f10b7ab49016f45a90d934a Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/process/factory.py M master/buildbot/test/unit/test_process_factory.py M master/docs/relnotes/index.rst Log Message: ----------- Merge 'support-depercated-addStep': Add support for passing keyword arguments to BuildFactory.addStep. We deprecated this in 0.8.6 and dropped support in 0.8.7. But 0.8.7 was the first version to support not needing to use .addFactoryArguments. But, passing keyword arguments to .addStep also avoid this. Commit: 7dfd05464983ca5c773f7764448a23968314a424 https://github.com/buildbot/buildbot/commit/7dfd05464983ca5c773f7764448a23968314a424 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/regressions/test_shell_command_properties.py Log Message: ----------- Don't use deprecated name SetProperty in regression tests. Commit: 3b1b6e600ca5c95961ec14dd56e602e1ca62408b https://github.com/buildbot/buildbot/commit/3b1b6e600ca5c95961ec14dd56e602e1ca62408b Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Expose twisted.cred for change hook auth. Twisted provides a rich interface for defining authentication. Use it for defining change hook authorization, rather than just one specific bit of it. Commit: 90e94e2b59711b99a8b7f7350433f50f8cd12a5e https://github.com/buildbot/buildbot/commit/90e94e2b59711b99a8b7f7350433f50f8cd12a5e Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- Also skip adding hook if it IUsernamePassword isn't supported. Commit: 3b2f3c7661f9a51e7e1eb208669092ca47f6f89e https://github.com/buildbot/buildbot/commit/3b2f3c7661f9a51e7e1eb208669092ca47f6f89e Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Link to twisted.cred documentation. Commit: 61a20da2a79c4c0c9318ee758f8fd2132899913f https://github.com/buildbot/buildbot/commit/61a20da2a79c4c0c9318ee758f8fd2132899913f Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge 'web-auth': Expose twisted.cred for change hook auth. Twisted provides a rich interface for defining authentication. Use it for defining change hook authorization, rather than just one specific bit of it. Commit: a958a020650557375144783fe52e5e79719703b8 https://github.com/buildbot/buildbot/commit/a958a020650557375144783fe52e5e79719703b8 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Merge pull request #767 from tomprince/p4-cleanups P4 cleanups Commit: 9b0598a8f52b646e06f32b8df53793e4de7d6a64 https://github.com/buildbot/buildbot/commit/9b0598a8f52b646e06f32b8df53793e4de7d6a64 Author: Dustin J. Mitchell Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/process/build.py Log Message: ----------- remove typo in builddir and workdir properties Commit: 66a6428df813f1eb9649860bb78151497eef14c6 https://github.com/buildbot/buildbot/commit/66a6428df813f1eb9649860bb78151497eef14c6 Author: Edmund Wong Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- - Removed "cmd = " as it's not being used. Commit: 3fd99955d710e3bd0ffd504edcc8547c21b07144 https://github.com/buildbot/buildbot/commit/3fd99955d710e3bd0ffd504edcc8547c21b07144 Author: Charles Lepple Date: 2013-07-30 (Tue, 30 Jul 2013) Changed paths: M master/buildbot/status/web/feeds.py Log Message: ----------- status/web/feeds.py: fix pubDate format A prior localization fix caused RFC822-style dates to be rendered as follows: 1, 23 7 2013 13:04:18 GMT This implements the fix proposed in http://trac.buildbot.net/ticket/2530 Commit: c69495157713f76ef60b2a23f0bf8de8255c2446 https://github.com/buildbot/buildbot/commit/c69495157713f76ef60b2a23f0bf8de8255c2446 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/base.py M master/buildbot/test/unit/test_status_web_base.py Log Message: ----------- Generate correct relative paths even for pages in the root Previous code generated '/' for the path to the root, which is not relative and causes problems when changing paths with http proxies. Fixes #2544. Commit: 2799d21d4ec2a58461c6dd606f2bb0d46655c71d https://github.com/buildbot/buildbot/commit/2799d21d4ec2a58461c6dd606f2bb0d46655c71d Author: Kevin Funk Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/status_gerrit.py M master/docs/relnotes/index.rst Log Message: ----------- Patch for bug #2536 Fixes #2536 See http://trac.buildbot.net/ticket/2536 Commit: 153d359de450dcf1f71142340d8b2f52093c4189 https://github.com/buildbot/buildbot/commit/153d359de450dcf1f71142340d8b2f52093c4189 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/feeds.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2530' of git://github.com/clepple/buildbot into buildbot-0.8.8 Commit: 8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4 https://github.com/buildbot/buildbot/commit/8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4 Author: Gabriele Giacone <1o5g4r8o at gmail.com> Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/buildslave/libvirt.py Log Message: ----------- Fix libvirt module load after internal module rename. Thanks Jc2k. See #2538 Commit: 755d0cb9edee00c3e2346b8a15613ebdd3f5c960 https://github.com/buildbot/buildbot/commit/755d0cb9edee00c3e2346b8a15613ebdd3f5c960 Author: Dominic Chen Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/scripts/base.py Log Message: ----------- set __file__ before calling execfile on tacFile for relocatable buildmasters Commit: 4a6c106dacb1734c2a234dcc159ecce476a9a29b https://github.com/buildbot/buildbot/commit/4a6c106dacb1734c2a234dcc159ecce476a9a29b Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M master/buildbot/buildslave/libvirt.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/process/factory.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/base.py M master/buildbot/status/status_gerrit.py M master/buildbot/status/web/base.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/feeds.py M master/buildbot/steps/source/p4.py M master/buildbot/steps/source/repo.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/regressions/test_shell_command_properties.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_process_factory.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_status_web_base.py M master/buildbot/test/unit/test_steps_source_repo.py R master/buildbot/test/util/pbclient.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/introduction.rst M master/docs/relnotes/0.8.8.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'buildbot-0.8.8' Compare: https://github.com/buildbot/buildbot/compare/5c7625d4b07c...4a6c106dacb1 From noreply at github.com Mon Aug 19 01:13:38 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 18:13:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b3c474: P4: Use config.error, instead of collecting errors... Message-ID: <5211714228c86_59aaa7d503526d@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 https://github.com/buildbot/buildbot/commit/b3c474c8a960d8822d0330172ed1d7ae85d8c5f3 Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use config.error, instead of collecting errors by hand. Commit: f838d86fe563745123d56bf764dafd61ef3d52dc https://github.com/buildbot/buildbot/commit/f838d86fe563745123d56bf764dafd61ef3d52dc Author: Tom Prince Date: 2013-06-19 (Wed, 19 Jun 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- P4: Use tools provided by CompositeStepMixin. Commit: ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3 https://github.com/buildbot/buildbot/commit/ec85bdc3f2be7494e0bf7c7d22c19d73f52038e3 Author: Jared Grubb Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/docs/developer/cls-iproperties.rst M master/docs/developer/cls-irenderable.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-properties.rst Log Message: ----------- Docs: update some index references Commit: 789dedd66cf7b4064ce5f8ad0582717c336692ea https://github.com/buildbot/buildbot/commit/789dedd66cf7b4064ce5f8ad0582717c336692ea Author: Pierre Tardy Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- repo codingStyle fixes - repo step and unit tests are now pep8 compliant - fixed camelCase for repo step parameters - removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable - added test on repo download from changesource - update doc and release notes Signed-off-by: Pierre Tardy Commit: 75149f365576a97d2d7a486aab2aa00774991b28 https://github.com/buildbot/buildbot/commit/75149f365576a97d2d7a486aab2aa00774991b28 Author: Pierre Tardy Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- repo: add RepoDownloadsFromChangeSource renderable Suggestion from Tom to put this away from the step code. In cunjunction with FlattenList, this works well. + some more minor review handling Signed-off-by: Pierre Tardy Commit: dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51 https://github.com/buildbot/buildbot/commit/dd34e3cde87d80aa6f6456f6e8bae95d17a8cc51 Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Update release notes. Commit: 1199199a3f4ce54a85a30f959ba5a4fee2f179db https://github.com/buildbot/buildbot/commit/1199199a3f4ce54a85a30f959ba5a4fee2f179db Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_steps_source_repo.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'repo-coding-style' into buildbot-0.8.8. - repo step and unit tests are now pep8 compliant - fixed camelCase for repo step parameters - removed usage of properties as input of the step. Its now job of use to choose which property name he wants via renderable - added test on repo download from changesource - update doc and release notes Commit: cc8913b76c4932465f496c7262a4afb81ec1fe78 https://github.com/buildbot/buildbot/commit/cc8913b76c4932465f496c7262a4afb81ec1fe78 Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Revert adding slave-side support for sudo. Adding sudo to a command can easily be handled by on the master-side. Also, different people will have different expectations, which a single argument isn't enough to capture. See https://github.com/fabric/fabric/issues/503 for some discussions. This reverts commit b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e, reversing changes made to d0cd62b6049759d89b09b1512dab2268132fd30d. Commit: 478c79fe9024826403a6ee08d152859181178bfd https://github.com/buildbot/buildbot/commit/478c79fe9024826403a6ee08d152859181178bfd Author: Tom Prince Date: 2013-07-09 (Tue, 09 Jul 2013) Changed paths: M master/buildbot/process/factory.py M master/buildbot/test/unit/test_process_factory.py M master/docs/relnotes/index.rst Log Message: ----------- Add support for passing keyword arguments to BuildFactory.addStep. This was supported in old versions of buildbot, but there wasn't a release that supported both, making transitioning harder than necessary. Commit: 379603bc07b4ccef0993cedc025aeef1c63e5844 https://github.com/buildbot/buildbot/commit/379603bc07b4ccef0993cedc025aeef1c63e5844 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py R master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Revert 'try_client_available_builder_names'. This added ad-hoc support for overriding `getAvaliableBuilderNames` in a subclass of `TrySchedulerer`. But that support was undocumented and untested. This reverts commit 46a81edbecee41e9042b7d1bbf928e13d59e618d, reversing changes made to 9ec2372129b48842b5c3bc5e933b28ed728d46e3. Commit: 66f62be3dad57fcd7eb897807b5352c3e362e0ed https://github.com/buildbot/buildbot/commit/66f62be3dad57fcd7eb897807b5352c3e362e0ed Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/unit/test_process_build.py Log Message: ----------- Use `assertTrue`/`assertFalse` instead of `assertIdentical` where appropriate. Commit: e8147cc53069f1c73f10b7ab49016f45a90d934a https://github.com/buildbot/buildbot/commit/e8147cc53069f1c73f10b7ab49016f45a90d934a Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/process/factory.py M master/buildbot/test/unit/test_process_factory.py M master/docs/relnotes/index.rst Log Message: ----------- Merge 'support-depercated-addStep': Add support for passing keyword arguments to BuildFactory.addStep. We deprecated this in 0.8.6 and dropped support in 0.8.7. But 0.8.7 was the first version to support not needing to use .addFactoryArguments. But, passing keyword arguments to .addStep also avoid this. Commit: 7dfd05464983ca5c773f7764448a23968314a424 https://github.com/buildbot/buildbot/commit/7dfd05464983ca5c773f7764448a23968314a424 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/test/regressions/test_shell_command_properties.py Log Message: ----------- Don't use deprecated name SetProperty in regression tests. Commit: 3b1b6e600ca5c95961ec14dd56e602e1ca62408b https://github.com/buildbot/buildbot/commit/3b1b6e600ca5c95961ec14dd56e602e1ca62408b Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Expose twisted.cred for change hook auth. Twisted provides a rich interface for defining authentication. Use it for defining change hook authorization, rather than just one specific bit of it. Commit: 90e94e2b59711b99a8b7f7350433f50f8cd12a5e https://github.com/buildbot/buildbot/commit/90e94e2b59711b99a8b7f7350433f50f8cd12a5e Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py Log Message: ----------- Also skip adding hook if it IUsernamePassword isn't supported. Commit: 3b2f3c7661f9a51e7e1eb208669092ca47f6f89e https://github.com/buildbot/buildbot/commit/3b2f3c7661f9a51e7e1eb208669092ca47f6f89e Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Link to twisted.cred documentation. Commit: 61a20da2a79c4c0c9318ee758f8fd2132899913f https://github.com/buildbot/buildbot/commit/61a20da2a79c4c0c9318ee758f8fd2132899913f Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/status/web/baseweb.py M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Merge 'web-auth': Expose twisted.cred for change hook auth. Twisted provides a rich interface for defining authentication. Use it for defining change hook authorization, rather than just one specific bit of it. Commit: a958a020650557375144783fe52e5e79719703b8 https://github.com/buildbot/buildbot/commit/a958a020650557375144783fe52e5e79719703b8 Author: Tom Prince Date: 2013-07-13 (Sat, 13 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Merge pull request #767 from tomprince/p4-cleanups P4 cleanups Commit: 9b0598a8f52b646e06f32b8df53793e4de7d6a64 https://github.com/buildbot/buildbot/commit/9b0598a8f52b646e06f32b8df53793e4de7d6a64 Author: Dustin J. Mitchell Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/process/build.py Log Message: ----------- remove typo in builddir and workdir properties Commit: 66a6428df813f1eb9649860bb78151497eef14c6 https://github.com/buildbot/buildbot/commit/66a6428df813f1eb9649860bb78151497eef14c6 Author: Edmund Wong Date: 2013-07-15 (Mon, 15 Jul 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- - Removed "cmd = " as it's not being used. Commit: 3fd99955d710e3bd0ffd504edcc8547c21b07144 https://github.com/buildbot/buildbot/commit/3fd99955d710e3bd0ffd504edcc8547c21b07144 Author: Charles Lepple Date: 2013-07-30 (Tue, 30 Jul 2013) Changed paths: M master/buildbot/status/web/feeds.py Log Message: ----------- status/web/feeds.py: fix pubDate format A prior localization fix caused RFC822-style dates to be rendered as follows: 1, 23 7 2013 13:04:18 GMT This implements the fix proposed in http://trac.buildbot.net/ticket/2530 Commit: c69495157713f76ef60b2a23f0bf8de8255c2446 https://github.com/buildbot/buildbot/commit/c69495157713f76ef60b2a23f0bf8de8255c2446 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/base.py M master/buildbot/test/unit/test_status_web_base.py Log Message: ----------- Generate correct relative paths even for pages in the root Previous code generated '/' for the path to the root, which is not relative and causes problems when changing paths with http proxies. Fixes #2544. Commit: 2799d21d4ec2a58461c6dd606f2bb0d46655c71d https://github.com/buildbot/buildbot/commit/2799d21d4ec2a58461c6dd606f2bb0d46655c71d Author: Kevin Funk Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/status_gerrit.py M master/docs/relnotes/index.rst Log Message: ----------- Patch for bug #2536 Fixes #2536 See http://trac.buildbot.net/ticket/2536 Commit: 153d359de450dcf1f71142340d8b2f52093c4189 https://github.com/buildbot/buildbot/commit/153d359de450dcf1f71142340d8b2f52093c4189 Author: Dustin J. Mitchell Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/status/web/feeds.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'bug2530' of git://github.com/clepple/buildbot into buildbot-0.8.8 Commit: 8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4 https://github.com/buildbot/buildbot/commit/8c27b44507fa9e0ea520cc26e5a1f73dad9c40f4 Author: Gabriele Giacone <1o5g4r8o at gmail.com> Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/buildslave/libvirt.py Log Message: ----------- Fix libvirt module load after internal module rename. Thanks Jc2k. See #2538 Commit: 755d0cb9edee00c3e2346b8a15613ebdd3f5c960 https://github.com/buildbot/buildbot/commit/755d0cb9edee00c3e2346b8a15613ebdd3f5c960 Author: Dominic Chen Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/buildbot/scripts/base.py Log Message: ----------- set __file__ before calling execfile on tacFile for relocatable buildmasters Commit: 908590dc81b43f7aeecb7d3f51037bef537bfaf8 https://github.com/buildbot/buildbot/commit/908590dc81b43f7aeecb7d3f51037bef537bfaf8 Author: Vladimir Rutsky Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildstep.py M master/buildbot/process/properties.py Log Message: ----------- Fix typos "doesn not", "certaily", "availble", "compatability", "positial", "availble" Commit: de730a9b1cd7b4002db52efd2a91d1ec5b8d1e78 https://github.com/buildbot/buildbot/commit/de730a9b1cd7b4002db52efd2a91d1ec5b8d1e78 Author: Vladimir Rutsky Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/changes/svnpoller.py Log Message: ----------- Fix method name in log Commit: 5c7625d4b07c61cd89919c91d153680fffa0409b https://github.com/buildbot/buildbot/commit/5c7625d4b07c61cd89919c91d153680fffa0409b Author: Dustin J. Mitchell Date: 2013-08-17 (Sat, 17 Aug 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildstep.py M master/buildbot/process/properties.py Log Message: ----------- Merge branch 'typos3' of git://github.com/vrutsky/buildbot Commit: 4a6c106dacb1734c2a234dcc159ecce476a9a29b https://github.com/buildbot/buildbot/commit/4a6c106dacb1734c2a234dcc159ecce476a9a29b Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M master/buildbot/buildslave/libvirt.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/process/factory.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/base.py M master/buildbot/status/status_gerrit.py M master/buildbot/status/web/base.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/feeds.py M master/buildbot/steps/source/p4.py M master/buildbot/steps/source/repo.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/regressions/test_shell_command_properties.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_process_factory.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_status_web_base.py M master/buildbot/test/unit/test_steps_source_repo.py R master/buildbot/test/util/pbclient.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/introduction.rst M master/docs/relnotes/0.8.8.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'buildbot-0.8.8' Commit: 92754a93600b618adc33a561028ed0b3453b023f https://github.com/buildbot/buildbot/commit/92754a93600b618adc33a561028ed0b3453b023f Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M master/buildbot/buildslave/base.py M master/buildbot/buildslave/libvirt.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/process/factory.py M master/buildbot/process/properties.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/base.py M master/buildbot/status/status_gerrit.py M master/buildbot/status/web/base.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/feeds.py M master/buildbot/steps/source/p4.py M master/buildbot/steps/source/repo.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/regressions/test_shell_command_properties.py M master/buildbot/test/unit/test_changes_gerritchangesource.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_process_factory.py M master/buildbot/test/unit/test_remotecommand.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_status_web_base.py M master/buildbot/test/unit/test_steps_source_repo.py R master/buildbot/test/util/pbclient.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/introduction.rst M master/docs/relnotes/0.8.8.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'master' into nine Conflicts: master/buildbot/changes/svnpoller.py master/buildbot/test/regressions/test_shell_command_properties.py master/buildbot/test/unit/test_changes_gerritchangesource.py Compare: https://github.com/buildbot/buildbot/compare/02e9dfcf0514...92754a93600b From noreply at github.com Mon Aug 19 01:20:12 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 18:20:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec7459: Buildslave fires SIGTERM before SIGKILL Message-ID: <521172cc9ab50_4c568fdd4c6391e@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ec74598986de335ab69eabdd572ec2f217292968 https://github.com/buildbot/buildbot/commit/ec74598986de335ab69eabdd572ec2f217292968 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/buildslave/runprocess.py Log Message: ----------- Buildslave fires SIGTERM before SIGKILL Before forcefully killing the process, we fire a SIGTERM in case the developer wants to capture some debugging information. Fixes trac ticket #751. Commit: dbb4781ab507daf28e32bc13bebc12947c407d84 https://github.com/buildbot/buildbot/commit/dbb4781ab507daf28e32bc13bebc12947c407d84 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Updates test_simple to check if process was killed by SIGTERM Commit: 98f3c9fb59f99d465cf612a1a8eb2ffd2e8be337 https://github.com/buildbot/buildbot/commit/98f3c9fb59f99d465cf612a1a8eb2ffd2e8be337 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Adds test_kill to buildslave tests Adds a unit test which ensures the process will receive SIGKILL if SIGTERM fails to end the process. Commit: 6555a836acfa51bf90aba8fbe6debb198e166780 https://github.com/buildbot/buildbot/commit/6555a836acfa51bf90aba8fbe6debb198e166780 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Updates relnotes to reflect new behavior States that processes will receive a SIGTERM before a SIGKILL Commit: a577c74ae29e3098f494994c683b2ccf9c54eeba https://github.com/buildbot/buildbot/commit/a577c74ae29e3098f494994c683b2ccf9c54eeba Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch '751-fire-sigterm-before-sigkill' of git://github.com/markberger/buildbot Compare: https://github.com/buildbot/buildbot/compare/4a6c106dacb1...a577c74ae29e From noreply at github.com Mon Aug 19 03:01:20 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 20:01:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c89a6d: don't skip 'pylint' target on slave when master fa... Message-ID: <52118a80669d1_3e61205d5422837@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c89a6df8dd59db983ef30fa2be52b9f1ea4317b3 https://github.com/buildbot/buildbot/commit/c89a6df8dd59db983ef30fa2be52b9f1ea4317b3 Author: Elmir Jagudin Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M Makefile Log Message: ----------- don't skip 'pylint' target on slave when master fails On 'make pylint' make sure pylint target is run in both 'master' and 'slave' directories. Previously, the pylint target in 'slave' was skipped if any errors where reported for 'master'. Commit: 3dd851cebcdaa55b38bd21070a0422d844957399 https://github.com/buildbot/buildbot/commit/3dd851cebcdaa55b38bd21070a0422d844957399 Author: Elmir Jagudin Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M common/pylintrc Log Message: ----------- disable some pylint 1.0.0 checks for now Disable new failing checks that were introduced in pylint 1.0.0 release. To be fixed an enabled in the future. Commit: b3f9331a225e4a42a5256c5c16a32907e989f0e1 https://github.com/buildbot/buildbot/commit/b3f9331a225e4a42a5256c5c16a32907e989f0e1 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M Makefile M common/pylintrc Log Message: ----------- Merge branch 'pylint-1.0.0' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/a577c74ae29e...b3f9331a225e From noreply at github.com Mon Aug 19 03:01:26 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 20:01:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0105a8: fix sourcestamps for unknown codebases Message-ID: <52118a86daa1_7e8144bd481044cc@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 0105a85f5bff13c7f2ce181f604772627e94b442 https://github.com/buildbot/buildbot/commit/0105a85f5bff13c7f2ce181f604772627e94b442 Author: Buck Golemon Date: 2013-08-14 (Wed, 14 Aug 2013) Changed paths: M master/buildbot/schedulers/base.py M master/buildbot/test/unit/test_schedulers_base.py Log Message: ----------- fix sourcestamps for unknown codebases Commit: 478d246866d29aac6742c0b259c82898b103fdc8 https://github.com/buildbot/buildbot/commit/478d246866d29aac6742c0b259c82898b103fdc8 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M master/buildbot/schedulers/base.py M master/buildbot/test/unit/test_schedulers_base.py Log Message: ----------- Merge branch 'buck-nine-fix-sourcestamps-with-unknown-codebase' of git://github.com/bukzor/buildbot into nine Compare: https://github.com/buildbot/buildbot/compare/92754a93600b...478d246866d2 From noreply at github.com Mon Aug 19 03:01:31 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 20:01:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec7459: Buildslave fires SIGTERM before SIGKILL Message-ID: <52118a8bb94b4_5b72ba7d54505f@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: ec74598986de335ab69eabdd572ec2f217292968 https://github.com/buildbot/buildbot/commit/ec74598986de335ab69eabdd572ec2f217292968 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/buildslave/runprocess.py Log Message: ----------- Buildslave fires SIGTERM before SIGKILL Before forcefully killing the process, we fire a SIGTERM in case the developer wants to capture some debugging information. Fixes trac ticket #751. Commit: dbb4781ab507daf28e32bc13bebc12947c407d84 https://github.com/buildbot/buildbot/commit/dbb4781ab507daf28e32bc13bebc12947c407d84 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Updates test_simple to check if process was killed by SIGTERM Commit: 98f3c9fb59f99d465cf612a1a8eb2ffd2e8be337 https://github.com/buildbot/buildbot/commit/98f3c9fb59f99d465cf612a1a8eb2ffd2e8be337 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Adds test_kill to buildslave tests Adds a unit test which ensures the process will receive SIGKILL if SIGTERM fails to end the process. Commit: 6555a836acfa51bf90aba8fbe6debb198e166780 https://github.com/buildbot/buildbot/commit/6555a836acfa51bf90aba8fbe6debb198e166780 Author: Mark J. Berger Date: 2013-08-10 (Sat, 10 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Updates relnotes to reflect new behavior States that processes will receive a SIGTERM before a SIGKILL Commit: c89a6df8dd59db983ef30fa2be52b9f1ea4317b3 https://github.com/buildbot/buildbot/commit/c89a6df8dd59db983ef30fa2be52b9f1ea4317b3 Author: Elmir Jagudin Date: 2013-08-13 (Tue, 13 Aug 2013) Changed paths: M Makefile Log Message: ----------- don't skip 'pylint' target on slave when master fails On 'make pylint' make sure pylint target is run in both 'master' and 'slave' directories. Previously, the pylint target in 'slave' was skipped if any errors where reported for 'master'. Commit: 3dd851cebcdaa55b38bd21070a0422d844957399 https://github.com/buildbot/buildbot/commit/3dd851cebcdaa55b38bd21070a0422d844957399 Author: Elmir Jagudin Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M common/pylintrc Log Message: ----------- disable some pylint 1.0.0 checks for now Disable new failing checks that were introduced in pylint 1.0.0 release. To be fixed an enabled in the future. Commit: a577c74ae29e3098f494994c683b2ccf9c54eeba https://github.com/buildbot/buildbot/commit/a577c74ae29e3098f494994c683b2ccf9c54eeba Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch '751-fire-sigterm-before-sigkill' of git://github.com/markberger/buildbot Commit: b3f9331a225e4a42a5256c5c16a32907e989f0e1 https://github.com/buildbot/buildbot/commit/b3f9331a225e4a42a5256c5c16a32907e989f0e1 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M Makefile M common/pylintrc Log Message: ----------- Merge branch 'pylint-1.0.0' of git://github.com/elmirjagudin/buildbot Commit: 415da10434d894414142da3084df207bbed616a9 https://github.com/buildbot/buildbot/commit/415da10434d894414142da3084df207bbed616a9 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M Makefile M common/pylintrc M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/478d246866d2...415da10434d8 From noreply at github.com Mon Aug 19 03:27:54 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 20:27:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 34a4bb: Run pyflakes in validate.sh Message-ID: <521190ba40885_53fc1449d542987d@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 34a4bb3b65aa6c2e31841418bbb7afd21823f848 https://github.com/buildbot/buildbot/commit/34a4bb3b65aa6c2e31841418bbb7afd21823f848 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M common/validate.sh Log Message: ----------- Run pyflakes in validate.sh From noreply at github.com Mon Aug 19 03:28:04 2013 From: noreply at github.com (GitHub) Date: Sun, 18 Aug 2013 20:28:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 34a4bb: Run pyflakes in validate.sh Message-ID: <521190c4643ff_3e074fd4c1172ea@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 34a4bb3b65aa6c2e31841418bbb7afd21823f848 https://github.com/buildbot/buildbot/commit/34a4bb3b65aa6c2e31841418bbb7afd21823f848 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M common/validate.sh Log Message: ----------- Run pyflakes in validate.sh Commit: 27e1b287886c5900848b6f3a7884f955668c2ba3 https://github.com/buildbot/buildbot/commit/27e1b287886c5900848b6f3a7884f955668c2ba3 Author: Dustin J. Mitchell Date: 2013-08-18 (Sun, 18 Aug 2013) Changed paths: M common/validate.sh Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/415da10434d8...27e1b287886c From trac at buildbot.net Tue Aug 20 01:57:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 20 Aug 2013 01:57:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2551: Triggered builds containing steps synchronized by a SlaveLock (counting or exclusive) are sometimes not run. In-Reply-To: <040.d17453a9a5b8a08bf38aa0d9df97dfb3@buildbot.net> References: <040.d17453a9a5b8a08bf38aa0d9df97dfb3@buildbot.net> Message-ID: <055.22b123a066874e4fb40035443afec473@buildbot.net> #2551: Triggered builds containing steps synchronized by a SlaveLock (counting or exclusive) are sometimes not run. ---------------------+-------------------- Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: locks | ---------------------+-------------------- Changes (by dustin): * keywords: Triggerable => locks * milestone: undecided => 0.8.+ Comment: Do the builds *never* run? One possibility here is that the release of the locks is not correctly initiating a check for runnable build requests. But if that's the case, then eventually (I think at a 30-minute interval) the builds would be run anyway. The 30-minute timer is a kind of backup process for missed triggers like this. Otherwise, something deeper is wrong :( -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 20 01:58:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 20 Aug 2013 01:58:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2548: Git builder silently drops back to HEAD (master) if a branch isn't found In-Reply-To: <040.fb3a30906f32efd8fcc109b631bfbd2f@buildbot.net> References: <040.fb3a30906f32efd8fcc109b631bfbd2f@buildbot.net> Message-ID: <055.6ce35d2f61c06279e5a2c65256bebb46@buildbot.net> #2548: Git builder silently drops back to HEAD (master) if a branch isn't found ---------------------+------------------------ Reporter: chmorgan | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: git | ---------------------+------------------------ Comment (by dustin): Hopefully - that would make this an easy fix for Buildbot! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Aug 20 02:55:50 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 20 Aug 2013 02:55:50 -0000 Subject: [Buildbot-commits] [Buildbot] #751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out In-Reply-To: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net> References: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net> Message-ID: <054.3f46d0ec311029683a771b493b58ef48@buildbot.net> #751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out -------------------------+----------------------- Reporter: Fabrice | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: kill, sprint | -------------------------+----------------------- Old description: > I have a test step that does not produce output for one hour (the test or > one of its subtest hangs for some reason). My buildbot is configured to > timeout this step/command after 3600 seconds of inactivity on stdout or > stderr. Thus buildbot sends correctly, as expected, a signal SIGKILL(9) > to it and writes in the log: > > {{{ > command timed out: 3600 seconds without output, killing pid > process killed by signal 9 > }}} > > However, my problem is the following. There is no way for me to > catch/trap SIGKILL(9) in my test step process running on the slave and > thus, I am missing test logs. Is it possible to make buildbot send a > couple of SIGTERM(15) signals before sending a SIGKILL(9) signal? New description: I have a test step that does not produce output for one hour (the test or one of its subtest hangs for some reason). My buildbot is configured to timeout this step/command after 3600 seconds of inactivity on stdout or stderr. Thus buildbot sends correctly, as expected, a signal SIGKILL(9) to it and writes in the log: {{{ command timed out: 3600 seconds without output, killing pid process killed by signal 9 }}} However, my problem is the following. There is no way for me to catch/trap SIGKILL(9) in my test step process running on the slave and thus, I am missing test logs. Is it possible to make buildbot send a couple of SIGTERM(15) signals before sending a SIGKILL(9) signal? -- Comment (by dustin): I ended up backing that out. From the message there: I think that the correct approach is what a lot of initscripts do: send SIGTERM, poll for process exit for some mid-length time, and if it doesn't exit, send SIGKILL. In other words, "please quit", wait, "die". We'll probably also need this to be configurable from the master side - both the inter-signal timeout, and whether to try SIGTERM at all. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Aug 20 02:58:38 2013 From: noreply at github.com (GitHub) Date: Mon, 19 Aug 2013 19:58:38 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5f8c13: Revert "Merge branch '751-fire-sigterm-before-sigk... Message-ID: <5212db5eb3dd6_18271181d4c8397e@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5f8c133f97b41d1f1ce5c1e4f15919fbc33602f2 https://github.com/buildbot/buildbot/commit/5f8c133f97b41d1f1ce5c1e4f15919fbc33602f2 Author: Dustin J. Mitchell Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Revert "Merge branch '751-fire-sigterm-before-sigkill' of git://github.com/markberger/buildbot" This reverts commit a577c74ae29e3098f494994c683b2ccf9c54eeba, reversing changes made to 4a6c106dacb1734c2a234dcc159ecce476a9a29b. From noreply at github.com Tue Aug 20 03:24:52 2013 From: noreply at github.com (GitHub) Date: Mon, 19 Aug 2013 20:24:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0933fe: Improve error handling in status_push.py Message-ID: <5212e184539ca_5743bd1d48130496@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0933fea9d21c0fa730941a8b08a103421300c7fe https://github.com/buildbot/buildbot/commit/0933fea9d21c0fa730941a8b08a103421300c7fe Author: Dustin J. Mitchell Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M master/buildbot/status/status_push.py Log Message: ----------- Improve error handling in status_push.py This file is still full of fail, but slightly less of it now. From trac at buildbot.net Wed Aug 21 00:36:29 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 21 Aug 2013 00:36:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2526: Un-started build steps with properties in descriptions fail In-Reply-To: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> References: <040.33b80c27a1c64d1f20ebd87a86fa6e5a@buildbot.net> Message-ID: <055.7392b13872c97c0ae3272dbbedb09a99@buildbot.net> #2526: Un-started build steps with properties in descriptions fail ---------------------+------------------------ Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ---------------------+------------------------ Comment (by cmumford): Replying to [comment:7 dustin]: > Well, I'm suggesting a patch that would modify `describe` directly. > > There are some escapes you can use in Interpolate references to translate None to an empty string or some other string. So I originally stuck with my IRenderable solution, but later on started to use Buildbot's JSON API and discovered that these new classes also needed to be JSON serializable. So I switched to your solution which worked around that problem as well: {{{ class TestShellCommand(ShellCommand): def __init__(self, workdir=None, description=None, descriptionDone=None, descriptionSuffix=None, command=None, usePTY="slave-config", title='Default Title', **kwargs): super(TestShellCommand, self).__init__(workdir, description, descriptionDone, descriptionSuffix, command, usePTY, **kwargs) self.title = title def describe(self, done=False): build_no = self.getProperty("test_build_num", '0') build_no_class = GetBuildNumberCssStyle(build_no) branch = self.getProperty("branch", 'master?') if branch == '': branch = 'master?' ret = ["Branch: %s" % branch, "Build: %s"%(build_no_class, build_no), self.title] if not done: ret.append("(Running)") return ret }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Aug 21 02:30:23 2013 From: noreply at github.com (GitHub) Date: Tue, 20 Aug 2013 19:30:23 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cde570: simplify trigger logic a little Message-ID: <5214263f229be_3827d2dd541028cb@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: cde57024b2a9244e4c4a3fccdb894a627d445ddf https://github.com/buildbot/buildbot/commit/cde57024b2a9244e4c4a3fccdb894a627d445ddf Author: Buck Golemon Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M master/buildbot/steps/trigger.py Log Message: ----------- simplify trigger logic a little Commit: 272d4710833d81f6e98fffaa63025ffcdbff5cb8 https://github.com/buildbot/buildbot/commit/272d4710833d81f6e98fffaa63025ffcdbff5cb8 Author: Buck Golemon Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M master/buildbot/schedulers/triggerable.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/unit/test_schedulers_triggerable.py Log Message: ----------- Improve TriggerableScheduler tests to be less fake. Commit: 72371252ef208da1480b436cb18a579543174b64 https://github.com/buildbot/buildbot/commit/72371252ef208da1480b436cb18a579543174b64 Author: Buck Golemon Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M master/buildbot/data/buildsets.py M master/buildbot/db/buildsets.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/triggerable.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_data_buildsets.py M master/buildbot/test/unit/test_data_connector.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_triggerable.py Log Message: ----------- add support for buildrequest.waited_for Commit: d3503ea87024740fe457d56095e3e1abf8618465 https://github.com/buildbot/buildbot/commit/d3503ea87024740fe457d56095e3e1abf8618465 Author: Buck Golemon Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M master/buildbot/interfaces.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/util/interfaces.py Log Message: ----------- fix ITriggerableScheduler, add interface coverage Commit: a34373291a18fdf74a9f6b8c83bcbe125fe175ae https://github.com/buildbot/buildbot/commit/a34373291a18fdf74a9f6b8c83bcbe125fe175ae Author: Buck Golemon Date: 2013-08-15 (Thu, 15 Aug 2013) Changed paths: M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- fix fake TriggerableScheduler. Add coverage. Fix Trigger step. Commit: 250b84c521c5abb9e8b706dcb5cfe3c2843ca446 https://github.com/buildbot/buildbot/commit/250b84c521c5abb9e8b706dcb5cfe3c2843ca446 Author: Buck Golemon Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/db/buildsets.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_db_buildsets.py Log Message: ----------- assert waited_for type checking Commit: 7fa9df58590c148e14a1a875ac0efc800b488e93 https://github.com/buildbot/buildbot/commit/7fa9df58590c148e14a1a875ac0efc800b488e93 Author: Buck Golemon Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/test/unit/test_schedulers_triggerable.py Log Message: ----------- coverage for triggered buildrequest.submitted_at Commit: c90125e88eaf169b710c7a32a403ec57393b46a6 https://github.com/buildbot/buildbot/commit/c90125e88eaf169b710c7a32a403ec57393b46a6 Author: Dustin J. Mitchell Date: 2013-08-20 (Tue, 20 Aug 2013) Changed paths: M master/buildbot/data/buildsets.py M master/buildbot/db/buildsets.py M master/buildbot/interfaces.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/triggerable.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_data_buildsets.py M master/buildbot/test/unit/test_data_connector.py M master/buildbot/test/unit/test_db_buildsets.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/util/interfaces.py Log Message: ----------- Merge branch 'buck-nine-triggerstep-sets-wait_for' of git://github.com/bukzor/buildbot into nine Commit: d8b3bad68b0005dcfef7e5dc1033c3461c121d36 https://github.com/buildbot/buildbot/commit/d8b3bad68b0005dcfef7e5dc1033c3461c121d36 Author: Dustin J. Mitchell Date: 2013-08-20 (Tue, 20 Aug 2013) Changed paths: M master/buildbot/db/buildsets.py Log Message: ----------- remove assertion from production code Commit: 0e12bca24e41b34da9fb224da1bd125c6a724eae https://github.com/buildbot/buildbot/commit/0e12bca24e41b34da9fb224da1bd125c6a724eae Author: Dustin J. Mitchell Date: 2013-08-20 (Tue, 20 Aug 2013) Changed paths: M master/buildbot/test/unit/test_schedulers_triggerable.py M master/buildbot/test/unit/test_steps_trigger.py Log Message: ----------- rename classes so as not to make pylint think they're interfaces Compare: https://github.com/buildbot/buildbot/compare/27e1b287886c...0e12bca24e41 From noreply at github.com Wed Aug 21 02:43:04 2013 From: noreply at github.com (GitHub) Date: Tue, 20 Aug 2013 19:43:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1463de: only check that assertion is raised on fake DB Message-ID: <52142938436fb_3813e0fd58198bc@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 1463de8ae13c3dec89f219da283cc70ec0b7bf1b https://github.com/buildbot/buildbot/commit/1463de8ae13c3dec89f219da283cc70ec0b7bf1b Author: Dustin J. Mitchell Date: 2013-08-20 (Tue, 20 Aug 2013) Changed paths: M master/buildbot/test/unit/test_db_buildsets.py Log Message: ----------- only check that assertion is raised on fake DB and don't unit-test the Python interpreter's scoping rules.. From trac at buildbot.net Wed Aug 21 03:05:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 21 Aug 2013 03:05:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2551: Triggered builds containing steps synchronized by a SlaveLock (counting or exclusive) are sometimes not run. In-Reply-To: <040.d17453a9a5b8a08bf38aa0d9df97dfb3@buildbot.net> References: <040.d17453a9a5b8a08bf38aa0d9df97dfb3@buildbot.net> Message-ID: <055.c573b91cab3a2f6f82e1bcdf1eafd6fd@buildbot.net> #2551: Triggered builds containing steps synchronized by a SlaveLock (counting or exclusive) are sometimes not run. ---------------------+-------------------- Reporter: cmumford | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: locks | ---------------------+-------------------- Comment (by cmumford): Sorry to say that I waited > 90 min. and still no change in the run/not- run status of builders. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 21 18:07:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 21 Aug 2013 18:07:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2552: Buildbot fails to init Git submodules on relative paths in .gitmodules Message-ID: <035.c7854c1c9f1379bd9799f810731e07a0@buildbot.net> #2552: Buildbot fails to init Git submodules on relative paths in .gitmodules ----------------------+----------------------- Reporter: krf | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- Example: Configure buildbot.steps.source.Git to download the repository for Qt Creator, URL: git://gitorious.org/qt-creator/qt-creator.git. Qt Creator has a submodule called 'qbs', configured to be pulled from '../../qt-labs/qbs.git'. Behavior: The source step will download the repository data via: {{{ /usr/bin/git fetch -t git://gitorious.org/qt-creator/qt-creator.git +master --progress (...) }}} Then tries to init submodules via: {{{ /usr/bin/git submodule init }}} Problem: This fails in case there are relative paths inside .gitmodules. The paths are relative to the superproject's origin but Buildbot's Git step '''does not''' set the remote's origin, hence it will fall-back to the local project root in the file system. Also see: http://git-scm.com/docs/git-submodule, cite from 'git submodule add': ''" is the URL of the new submodule's origin repository. This may be either an absolute URL, or (if it begins with ./ or ../), the location relative to the superproject's origin repository"'' Error output: {{{ Submodule 'qbs' (/home/build/Buildbot/qt-labs/qbs.git) registered for path 'src/shared/qbs' }}} (Git now actually tries to clone from a local path instead of a remote, because ''remote.origin.url'' is missing) Proposed fix: Set ''remote.origin.url'' during the checkout, before fetching the submodules? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Aug 21 18:10:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 21 Aug 2013 18:10:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2552: Buildbot fails to init Git submodules in case of relative paths in .gitmodules (was: Buildbot fails to init Git submodules on relative paths in .gitmodules) In-Reply-To: <035.c7854c1c9f1379bd9799f810731e07a0@buildbot.net> References: <035.c7854c1c9f1379bd9799f810731e07a0@buildbot.net> Message-ID: <050.4f0a7841e4992e5da6b359de40f91c37@buildbot.net> #2552: Buildbot fails to init Git submodules in case of relative paths in .gitmodules ----------------------+------------------------ Reporter: krf | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Aug 22 10:26:15 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 22 Aug 2013 10:26:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2552: Buildbot fails to init Git submodules in case of relative paths in .gitmodules In-Reply-To: <035.c7854c1c9f1379bd9799f810731e07a0@buildbot.net> References: <035.c7854c1c9f1379bd9799f810731e07a0@buildbot.net> Message-ID: <050.06259a31cbc0febc98ad1bce27238ac0@buildbot.net> #2552: Buildbot fails to init Git submodules in case of relative paths in .gitmodules ----------------------+------------------------ Reporter: krf | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by krf): Just noticed that this is not reproducable for the (new) master-side Git step. There, ''git clone'' is used to initially checkout the repository, hence ''remote.origin.url'' is set properly. Not sure if it's worth to fix for the deprecated slave-side Git step. Feel free to close if not. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Aug 22 14:49:50 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 07:49:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d26b8c: update README to reflect current status Message-ID: <5216250ed835d_3583f57d5059758@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: d26b8c968f72114bc9b7abc9056293415b7ae66c https://github.com/buildbot/buildbot/commit/d26b8c968f72114bc9b7abc9056293415b7ae66c Author: Dustin J. Mitchell Date: 2013-08-21 (Wed, 21 Aug 2013) Changed paths: M README.md Log Message: ----------- update README to reflect current status From noreply at github.com Thu Aug 22 14:50:03 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 07:50:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 692e17: adjust docs to match reality Message-ID: <5216251b309d_43a49afd589160@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 692e17c0ade193c9f10c9b084e4e357221b6b871 https://github.com/buildbot/buildbot/commit/692e17c0ade193c9f10c9b084e4e357221b6b871 Author: Dustin J. Mitchell Date: 2013-08-21 (Wed, 21 Aug 2013) Changed paths: M master/docs/developer/cls-remotecommands.rst Log Message: ----------- adjust docs to match reality From noreply at github.com Thu Aug 22 20:42:39 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 13:42:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a2413d: Define `__file__`, when interpreting `buildbot.tac... Message-ID: <521677bfcef88_43f411e7d541220ce@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: a2413d500f91eb3ef0449812fece7540d6fb57a5 https://github.com/buildbot/buildbot/commit/a2413d500f91eb3ef0449812fece7540d6fb57a5 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/test/unit/test_scripts_base.py Log Message: ----------- Define `__file__`, when interpreting `buildbot.tac`. Commit: 65c6c6e8a42461630fe7d803047f81a54cf656f9 https://github.com/buildbot/buildbot/commit/65c6c6e8a42461630fe7d803047f81a54cf656f9 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/test/unit/test_scripts_base.py Log Message: ----------- Merge branch 'runner-__file__' into buildbot-0.8.8 Conflicts: master/buildbot/scripts/base.py Compare: https://github.com/buildbot/buildbot/compare/755d0cb9edee...65c6c6e8a424 From noreply at github.com Thu Aug 22 21:12:58 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 14:12:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 28755e: Fix usage of path_module in master-side repo step. Message-ID: <52167eda2c537_5a4b53dd4c14153b@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 28755e77133959d360eedcf7e81bdd021b81406a https://github.com/buildbot/buildbot/commit/28755e77133959d360eedcf7e81bdd021b81406a Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/util/sourcesteps.py Log Message: ----------- Fix usage of path_module in master-side repo step. From trac at buildbot.net Thu Aug 22 21:13:16 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 22 Aug 2013 21:13:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2549: Repo buildstep AttributeError no attribute 'pathmodule' on force scheduler In-Reply-To: <039.560cc427fe9d184868771290be0d2e67@buildbot.net> References: <039.560cc427fe9d184868771290be0d2e67@buildbot.net> Message-ID: <054.20d8886a4879374eb391e6659f9fe971@buildbot.net> #2549: Repo buildstep AttributeError no attribute 'pathmodule' on force scheduler --------------------+--------------------- Reporter: y2kenny | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: master | Resolution: fixed Keywords: gerrit | --------------------+--------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Aug 22 21:29:49 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 14:29:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 27793f: Move some dangling release notes. Message-ID: <521682cd4369e_59d2e97d48727b5@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 27793f5a56285f9edbf7c0d565a96df92fa89ed7 https://github.com/buildbot/buildbot/commit/27793f5a56285f9edbf7c0d565a96df92fa89ed7 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Move some dangling release notes. Commit: 2ab0e16ed0c46249f1d33308fd6878a1fc953f6e https://github.com/buildbot/buildbot/commit/2ab0e16ed0c46249f1d33308fd6878a1fc953f6e Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Update release notes. Compare: https://github.com/buildbot/buildbot/compare/28755e771339...2ab0e16ed0c4 From noreply at github.com Thu Aug 22 22:28:58 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 15:28:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 99f81a: make fake and real addBuildsetFor.. methods match Message-ID: <521690aac4ec2_35b911afd501354c1@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 99f81a0384a6d189c1b11ad942726640a88c8727 https://github.com/buildbot/buildbot/commit/99f81a0384a6d189c1b11ad942726640a88c8727 Author: Dustin J. Mitchell Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M README.md M master/buildbot/schedulers/base.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_schedulers_timed_NightlyTriggerable.py M master/buildbot/test/util/scheduler.py Log Message: ----------- make fake and real addBuildsetFor.. methods match From noreply at github.com Thu Aug 22 22:29:36 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 15:29:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5f8c13: Revert "Merge branch '751-fire-sigterm-before-sigk... Message-ID: <521690d0aee64_5a501137d50113490@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 5f8c133f97b41d1f1ce5c1e4f15919fbc33602f2 https://github.com/buildbot/buildbot/commit/5f8c133f97b41d1f1ce5c1e4f15919fbc33602f2 Author: Dustin J. Mitchell Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Revert "Merge branch '751-fire-sigterm-before-sigkill' of git://github.com/markberger/buildbot" This reverts commit a577c74ae29e3098f494994c683b2ccf9c54eeba, reversing changes made to 4a6c106dacb1734c2a234dcc159ecce476a9a29b. Commit: 0933fea9d21c0fa730941a8b08a103421300c7fe https://github.com/buildbot/buildbot/commit/0933fea9d21c0fa730941a8b08a103421300c7fe Author: Dustin J. Mitchell Date: 2013-08-19 (Mon, 19 Aug 2013) Changed paths: M master/buildbot/status/status_push.py Log Message: ----------- Improve error handling in status_push.py This file is still full of fail, but slightly less of it now. Commit: 692e17c0ade193c9f10c9b084e4e357221b6b871 https://github.com/buildbot/buildbot/commit/692e17c0ade193c9f10c9b084e4e357221b6b871 Author: Dustin J. Mitchell Date: 2013-08-21 (Wed, 21 Aug 2013) Changed paths: M master/docs/developer/cls-remotecommands.rst Log Message: ----------- adjust docs to match reality Commit: 354d9af4be547c0fb8bb4f890e88c4ce393db641 https://github.com/buildbot/buildbot/commit/354d9af4be547c0fb8bb4f890e88c4ce393db641 Author: Dustin J. Mitchell Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/status/status_push.py M master/docs/developer/cls-remotecommands.rst M master/docs/relnotes/index.rst M slave/buildslave/runprocess.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/99f81a0384a6...354d9af4be54 From noreply at github.com Thu Aug 22 22:36:16 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 15:36:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a2413d: Define `__file__`, when interpreting `buildbot.tac... Message-ID: <521692602fbcf_59b0110dd48865d2@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a2413d500f91eb3ef0449812fece7540d6fb57a5 https://github.com/buildbot/buildbot/commit/a2413d500f91eb3ef0449812fece7540d6fb57a5 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/scripts/base.py M master/buildbot/test/unit/test_scripts_base.py Log Message: ----------- Define `__file__`, when interpreting `buildbot.tac`. Commit: 65c6c6e8a42461630fe7d803047f81a54cf656f9 https://github.com/buildbot/buildbot/commit/65c6c6e8a42461630fe7d803047f81a54cf656f9 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/test/unit/test_scripts_base.py Log Message: ----------- Merge branch 'runner-__file__' into buildbot-0.8.8 Conflicts: master/buildbot/scripts/base.py Commit: 28755e77133959d360eedcf7e81bdd021b81406a https://github.com/buildbot/buildbot/commit/28755e77133959d360eedcf7e81bdd021b81406a Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/util/sourcesteps.py Log Message: ----------- Fix usage of path_module in master-side repo step. Commit: 27793f5a56285f9edbf7c0d565a96df92fa89ed7 https://github.com/buildbot/buildbot/commit/27793f5a56285f9edbf7c0d565a96df92fa89ed7 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Move some dangling release notes. Commit: 2ab0e16ed0c46249f1d33308fd6878a1fc953f6e https://github.com/buildbot/buildbot/commit/2ab0e16ed0c46249f1d33308fd6878a1fc953f6e Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Update release notes. Commit: 90ee997fa8ffbcb6960ddda3c2378909bf68aa71 https://github.com/buildbot/buildbot/commit/90ee997fa8ffbcb6960ddda3c2378909bf68aa71 Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/util/sourcesteps.py Log Message: ----------- Merge v0.8.8 into master. Conflicts: master/docs/relnotes/index.rst Compare: https://github.com/buildbot/buildbot/compare/692e17c0ade1...90ee997fa8ff From noreply at github.com Thu Aug 22 22:36:22 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 15:36:22 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <52169266a1336_47f9e37d581600ab@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/tags/v0.8.8 Home: https://github.com/buildbot/buildbot From noreply at github.com Thu Aug 22 22:43:25 2013 From: noreply at github.com (GitHub) Date: Thu, 22 Aug 2013 15:43:25 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 529c3f: Merge v0.8.8 into master. Message-ID: <5216940d4a345_78d7bc1d588127b@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 529c3f8ae44a5722b03b302b90ef0b94bf0854eb https://github.com/buildbot/buildbot/commit/529c3f8ae44a5722b03b302b90ef0b94bf0854eb Author: Tom Prince Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/util/sourcesteps.py M master/docs/relnotes/0.8.8.rst Log Message: ----------- Merge v0.8.8 into master. Conflicts: master/docs/relnotes/index.rst From trac at buildbot.net Fri Aug 23 05:11:00 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 23 Aug 2013 05:11:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2502: GNUAutoconf factory is using old version of addStep In-Reply-To: <037.faf002bdb39f217dff529b91b6b3d193@buildbot.net> References: <037.faf002bdb39f217dff529b91b6b3d193@buildbot.net> Message-ID: <052.ea12f3fa117b90650c9f49c5f425fc26@buildbot.net> #2502: GNUAutoconf factory is using old version of addStep ---------------------+--------------------- Reporter: matsl | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: simple | ---------------------+--------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed * milestone: 0.8.9 => 0.8.8 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Aug 23 05:12:21 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 23 Aug 2013 05:12:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2332: Add ability to SetProperty so that you can set a property without a command In-Reply-To: <041.e941f425a6abe45883ee064fcb2a06e5@buildbot.net> References: <041.e941f425a6abe45883ee064fcb2a06e5@buildbot.net> Message-ID: <056.90433b14d93ebe063bdff5ddbc69f3bf@buildbot.net> #2332: Add ability to SetProperty so that you can set a property without a command ------------------------+--------------------- Reporter: tcooperma | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.8 Version: 0.8.6p1 | Resolution: fixed Keywords: sprint | ------------------------+--------------------- Changes (by tom.prince): * status: new => closed * resolution: => fixed * milestone: 0.8.9 => 0.8.8 Old description: > Adding an option to SetProperty to do the equivalent of "echo foobar" > where foobar is some string that you generated in Python using > WIthProperties or something else. Perhaps this is done with another > parameter? > > > From: Philippe McLean > > > One option is to extend/modify the definition of SetProperty in > buildbot/steps/shell.py. > > Another possibility would be to use addFactoryArguments on any custom > buildsteps. New description: Adding an option to SetProperty to do the equivalent of "echo foobar" where foobar is some string that you generated in Python using WIthProperties or something else. Perhaps this is done with another parameter? > From: Philippe McLean > One option is to extend/modify the definition of SetProperty in buildbot/steps/shell.py. > Another possibility would be to use addFactoryArguments on any custom buildsteps. -- -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Aug 23 07:39:06 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 23 Aug 2013 07:39:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2545: dynamic buildsteps/buildstep detection In-Reply-To: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> References: <039.816b850d86bdb15fe8d31bdcf2e98b08@buildbot.net> Message-ID: <054.93a0c07136ef0df99d7086a8edca4e28@buildbot.net> #2545: dynamic buildsteps/buildstep detection ------------------------+-------------------- Reporter: vlovich | Owner: Type: enhancement | Status: new Priority: major | Milestone: 1.0.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by rutsky): * cc: rutsky.vladimir@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Aug 23 23:34:40 2013 From: noreply at github.com (GitHub) Date: Fri, 23 Aug 2013 16:34:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 40d5bf: Use list.append() instead list.extend() for single... Message-ID: <5217f190cde19_605273dd5477894@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 40d5bf9f9960b5a5e2fa1bf58592378697010367 https://github.com/buildbot/buildbot/commit/40d5bf9f9960b5a5e2fa1bf58592378697010367 Author: Vladimir Rutsky Date: 2013-08-16 (Fri, 16 Aug 2013) Changed paths: M master/buildbot/changes/svnpoller.py Log Message: ----------- Use list.append() instead list.extend() for single element Commit: a973e2f775b90de69d9e3e343abc7ec9d9d0c7f5 https://github.com/buildbot/buildbot/commit/a973e2f775b90de69d9e3e343abc7ec9d9d0c7f5 Author: Elmir Jagudin Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/status/web/change_hook.py Log Message: ----------- web change hook: rename exception variable name Use a more descriptive name of the cought instance of ValueError exception. The generic 'err' was redefined as a local function on line 81. This fixes pylint error 'E0102 (function-redefined)' in this file. Commit: 971b42b9eefbf4f504283862c18099541dc6b635 https://github.com/buildbot/buildbot/commit/971b42b9eefbf4f504283862c18099541dc6b635 Author: Elmir Jagudin Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- DB Pool: avoid redefining local variable Instead of redefining the 'log_msg' variable, assign it a new value when verbose logging is requested. This fixes pylint error 'E0102 (function-redefined)' in this file. Commit: a2d1c35ee66a7ee6ab72b85b69e0b0e596392438 https://github.com/buildbot/buildbot/commit/a2d1c35ee66a7ee6ab72b85b69e0b0e596392438 Author: Elmir Jagudin Date: 2013-08-22 (Thu, 22 Aug 2013) Changed paths: M common/pylintrc Log Message: ----------- enable pylint 'E0102 (function-redefined)' check. Commit: e27a088ac8bd989e9b61f59e62a056499301fecf https://github.com/buildbot/buildbot/commit/e27a088ac8bd989e9b61f59e62a056499301fecf Author: Dustin J. Mitchell Date: 2013-08-23 (Fri, 23 Aug 2013) Changed paths: M common/pylintrc M master/buildbot/db/pool.py M master/buildbot/status/web/change_hook.py M master/buildbot/steps/source/repo.py M master/buildbot/test/unit/test_scripts_base.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/util/sourcesteps.py M master/docs/relnotes/0.8.8.rst Log Message: ----------- Merge branch 'fix-pylint-function-redefined' of git://github.com/elmirjagudin/buildbot Commit: e81d6bdf58dc6a336406adc0ece4a5936f354583 https://github.com/buildbot/buildbot/commit/e81d6bdf58dc6a336406adc0ece4a5936f354583 Author: Dustin J. Mitchell Date: 2013-08-23 (Fri, 23 Aug 2013) Changed paths: M master/buildbot/changes/svnpoller.py Log Message: ----------- Merge branch 'minor' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/529c3f8ae44a...e81d6bdf58dc From trac at buildbot.net Sat Aug 24 02:45:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 24 Aug 2013 02:45:39 -0000 Subject: [Buildbot-commits] [Buildbot] #739: HTML logs are included in pickles In-Reply-To: <039.2b0ebe3105f086521fea6a5dd8cfc947@buildbot.net> References: <039.2b0ebe3105f086521fea6a5dd8cfc947@buildbot.net> Message-ID: <054.63b7e8de2e66ea8c7319a7b8e587c4b6@buildbot.net> #739: HTML logs are included in pickles ---------------------+-------------------- Reporter: marcusl | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: sprint | ---------------------+-------------------- Comment (by dcoshea): I'm running from git master commit ID 9cd7f9a (around 6 weeks ago). I have a build where the web status shows the following due to some error in my config (a doStepIf lambda that took the wrong number of parameters, I think). I assume this is basically a reproduction of this bug, unless there is some threshold below which the log content is ''meant'' to be stored inside the pickle: {{{ [...] Build #3 [...] Steps and Logfiles: [...] 4. exception ( 0 secs ) err.text err.html }}} In the builder's directory on the master, the file 3-log--err.text exists but there is no corresponding .html file. {{{ >>> o = pickle.load(open("3")) >>> o.steps[3].logs [, ] >>> o.steps[3].logs[1].filename '3-log--err.html' }}} No such file exists, though. There seem to be two ways to get the content of the log from the object: {{{ >>> o.steps[3].logs[1].html '
\n