[Buildbot-commits] [buildbot/buildbot] 18e61a: - set compare_attrs to be accumulateClassList() [...

Tue Apr 30 01:12:18 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 18e61a35b1dcbfbb2b7c65d5226469c7471985c8
      https://github.com/buildbot/buildbot/commit/18e61a35b1dcbfbb2b7c65d5226469c7471985c8
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-28 (Mon, 28 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - set compare_attrs to be accumulateClassList()  [wip]


  Commit: 1e6c659914a2fbffca4ff9436a6191a668060771
      https://github.com/buildbot/buildbot/commit/1e6c659914a2fbffca4ff9436a6191a668060771
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-28 (Mon, 28 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - turn compare_attr into an accumulatedClassList.


  Commit: dce8f0a208e8706133eb864d42842216c107a547
      https://github.com/buildbot/buildbot/commit/dce8f0a208e8706133eb864d42842216c107a547
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-28 (Mon, 28 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Fixed spelling.


  Commit: e7c9dbc46471af9023933e9900d04b171cc84b9f
      https://github.com/buildbot/buildbot/commit/e7c9dbc46471af9023933e9900d04b171cc84b9f
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-28 (Mon, 28 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - compare_attrs belongs to self.


  Commit: 3a74221bdf43c6d16a8dc1a071f358804ebc1ad2
      https://github.com/buildbot/buildbot/commit/3a74221bdf43c6d16a8dc1a071f358804ebc1ad2
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-28 (Mon, 28 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Revert all changes except the first.


  Commit: 559de65f6843198b87a5971ac9cc45505659a6b4
      https://github.com/buildbot/buildbot/commit/559de65f6843198b87a5971ac9cc45505659a6b4
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-29 (Tue, 29 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Added accumulate(self) method.


  Commit: dcd495b7f07e3f03b659fe14cc562d1d7b574a5d
      https://github.com/buildbot/buildbot/commit/dcd495b7f07e3f03b659fe14cc562d1d7b574a5d
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-29 (Tue, 29 Jan 2013)

  Changed paths:
    M master/buildbot/test/unit/test_util_ComparableMixin.py
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Added self.accumulate() method to accumulate compare_attrs.


  Commit: 7bfe283a78cd18d525b4ad113bd002ea28becc9f
      https://github.com/buildbot/buildbot/commit/7bfe283a78cd18d525b4ad113bd002ea28becc9f
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-29 (Tue, 29 Jan 2013)

  Changed paths:
    M master/buildbot/test/unit/test_util_ComparableMixin.py

  Log Message:
  -----------
  - test_equality_unimportantDifferences_subclass needs to be changed since b123 no longer equals to b223.


  Commit: 2ff7e8187ce03e0421e88b7fbd035c68fe36ad32
      https://github.com/buildbot/buildbot/commit/2ff7e8187ce03e0421e88b7fbd035c68fe36ad32
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M master/buildbot/test/unit/test_util_ComparableMixin.py
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - removed accumulate().  Changed ComparableMixin to statelessly use accumulatedClassList.


  Commit: f6b2d68863b898643b3e061a996d4313e2d86c0a
      https://github.com/buildbot/buildbot/commit/f6b2d68863b898643b3e061a996d4313e2d86c0a
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Import reflect, instead of importing the function.


  Commit: d7d7e512abdeca417280fa5e362e6b97a87a8eed
      https://github.com/buildbot/buildbot/commit/d7d7e512abdeca417280fa5e362e6b97a87a8eed
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-02 (Tue, 02 Apr 2013)

  Changed paths:
    M master/buildbot/test/unit/test_util_ComparableMixin.py

  Log Message:
  -----------
  - Removed a test. (Don't remember what it was for).
- Renamed test_inequality_sameClass_differentCompareAttrs to test_instance_attribute_not_used.


  Commit: 905471f7838374b584071de3d05f28e2011f23d0
      https://github.com/buildbot/buildbot/commit/905471f7838374b584071de3d05f28e2011f23d0
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Removed extraneous arguments from accumulateClassList.


  Commit: 6a04f1486f51a68150ef1cf94dc1c0579e0ac30d
      https://github.com/buildbot/buildbot/commit/6a04f1486f51a68150ef1cf94dc1c0579e0ac30d
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Fixed __cmp__ method.


  Commit: a5b114693fccfd3b3a313749c61db49b78856812
      https://github.com/buildbot/buildbot/commit/a5b114693fccfd3b3a313749c61db49b78856812
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-19 (Fri, 19 Apr 2013)

  Changed paths:
    M master/buildbot/test/unit/test_util_ComparableMixin.py

  Log Message:
  -----------
  - Changed test_equality_unimportantDifferences_subclass to test_inequality_unimportDifferences_subclass.


  Commit: 0c1b1e808e9c920b6e1e43b38c95fd04d3f2c7e3
      https://github.com/buildbot/buildbot/commit/0c1b1e808e9c920b6e1e43b38c95fd04d3f2c7e3
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/docs/developer/utils.rst

  Log Message:
  -----------
  - Update utils.rst for compare_attrs note.


  Commit: 72b8890d38b435456265e624452859b745ce7b08
      https://github.com/buildbot/buildbot/commit/72b8890d38b435456265e624452859b745ce7b08
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/changes/mail.py

  Log Message:
  -----------
  - Changed mail.py to use accumulateClassList.


  Commit: 601e6dbabac80de4214e0129b66f1d26141c4ef2
      https://github.com/buildbot/buildbot/commit/601e6dbabac80de4214e0129b66f1d26141c4ef2
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/dependent.py
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  - Add reflect to the imports.


  Commit: af657ac467c352da396b92496f26750797a24544
      https://github.com/buildbot/buildbot/commit/af657ac467c352da396b92496f26750797a24544
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/basic.py

  Log Message:
  -----------
  - Update BaseBasicScheduler to use accumulateClassList.


  Commit: e0aae2a1a58c7bde991b6abe7ee48027b76e87de
      https://github.com/buildbot/buildbot/commit/e0aae2a1a58c7bde991b6abe7ee48027b76e87de
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/dependent.py

  Log Message:
  -----------
  - Updated dependent.py to use accumulateClassList.


  Commit: 63437fd8b773e913465ed3f8e8dcad5912f414ab
      https://github.com/buildbot/buildbot/commit/63437fd8b773e913465ed3f8e8dcad5912f414ab
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  - Update timed.py to use accumulateClassList.


  Commit: 4e05b1ee89cf4612442da0baef80e1c236e8910b
      https://github.com/buildbot/buildbot/commit/4e05b1ee89cf4612442da0baef80e1c236e8910b
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/trysched.py

  Log Message:
  -----------
  - Update trysched.py to use accumulateClassList.


  Commit: bc9d417cb9ba4c6c7a150be0e448c500266c1c6d
      https://github.com/buildbot/buildbot/commit/bc9d417cb9ba4c6c7a150be0e448c500266c1c6d
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_manager.py

  Log Message:
  -----------
  -Update test_schedulers_manager.py - remove the concatentation of compare_attrs.


  Commit: 4e85c1b1cf2c5dda50c69b00fa441d997fd4b5c0
      https://github.com/buildbot/buildbot/commit/4e85c1b1cf2c5dda50c69b00fa441d997fd4b5c0
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Removed unneeded lines.


  Commit: c7caf905d01887e36a9975e4b5fc7786f3888706
      https://github.com/buildbot/buildbot/commit/c7caf905d01887e36a9975e4b5fc7786f3888706
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - re-added back some lines.


  Commit: d16ef7a4fb60b143809fb121243f8f677125130d
      https://github.com/buildbot/buildbot/commit/d16ef7a4fb60b143809fb121243f8f677125130d
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Compare classes and not names.


  Commit: adab8cacc82d51f21db28076e9cc5298a9fc65af
      https://github.com/buildbot/buildbot/commit/adab8cacc82d51f21db28076e9cc5298a9fc65af
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/changes/mail.py
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/dependent.py
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  - Removed unneeded code from constructors.


  Commit: 965058019a12bfe50589ef7d2f71202b441e7c9b
      https://github.com/buildbot/buildbot/commit/965058019a12bfe50589ef7d2f71202b441e7c9b
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/test/unit/test_util_ComparableMixin.py
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Changed test : f123 < b123.
- Used acomp instead of having acomp and bcomp.


  Commit: ec259532cfa7284fe4a61be5bedd46131d848fe7
      https://github.com/buildbot/buildbot/commit/ec259532cfa7284fe4a61be5bedd46131d848fe7
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/dependent.py
    M master/buildbot/schedulers/timed.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/util/__init__.py

  Log Message:
  -----------
  - Removed references to reflect. (No longer used)
- Changed acomp to compare_attrs.
- Removed unnecessary code.


  Commit: b3c5ded917b0313f4b666357c5927c8cc7ed417e
      https://github.com/buildbot/buildbot/commit/b3c5ded917b0313f4b666357c5927c8cc7ed417e
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-23 (Tue, 23 Apr 2013)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  - Removed unnecessary line.


  Commit: a217ca26f8d0b570b7084e240399a57176ad68b0
      https://github.com/buildbot/buildbot/commit/a217ca26f8d0b570b7084e240399a57176ad68b0
  Author: Edmund Wong <ewongbb at pw-wspx.org>
  Date:   2013-04-24 (Wed, 24 Apr 2013)

  Changed paths:
    M master/buildbot/changes/mail.py
    M master/buildbot/test/unit/test_schedulers_manager.py

  Log Message:
  -----------
  - Removed mentions of reflect.


  Commit: 2e5980ffee856ec830f380d23b3c59629b0630c1
      https://github.com/buildbot/buildbot/commit/2e5980ffee856ec830f380d23b3c59629b0630c1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M master/buildbot/changes/mail.py
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/dependent.py
    M master/buildbot/schedulers/timed.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/test/unit/test_schedulers_manager.py
    M master/buildbot/test/unit/test_util_ComparableMixin.py
    M master/buildbot/util/__init__.py
    M master/docs/developer/utils.rst

  Log Message:
  -----------
  use inequality instead of lt - order doesn't really matter


Compare: https://github.com/buildbot/buildbot/compare/30f8579333c7...2e5980ffee85