[Buildbot-commits] [buildbot/buildbot] 348681: tests: move IsBuildslaveDirMixin class to misc mod...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 348681302ce0dd61f197d58061fc111151ad9bd3
      https://github.com/buildbot/buildbot/commit/348681302ce0dd61f197d58061fc111151ad9bd3
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-20 (Sat, 20 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py
    M slave/buildslave/test/util/misc.py

  Log Message:
  -----------
  tests: move IsBuildslaveDirMixin class to misc module

Make it possible to use IsBuildslaveDirMixin class from other
test modules.


  Commit: b10c8b78effe5c952dc2c453c7f4ec8f9c3fdbb8
      https://github.com/buildbot/buildbot/commit/b10c8b78effe5c952dc2c453c7f4ec8f9c3fdbb8
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py
    M slave/buildslave/scripts/startup.py
    M slave/buildslave/test/unit/test_scripts_runner.py
    A slave/buildslave/test/unit/test_scripts_startup.py

  Log Message:
  -----------
  don't call isBuildslaveDir() twice on buildslave restart

Broke out code to start buildslave process into a utility function
startSlave(). Use it from restart() and startCommand().


  Commit: 6037af3ddc26f37a79d205aca31dd8a9c540491e
      https://github.com/buildbot/buildbot/commit/6037af3ddc26f37a79d205aca31dd8a9c540491e
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py

  Log Message:
  -----------
  specify buildslave subcommand function in it's Options class

Use subcommandFunction class variable of the subcommand's Option flag
to specify the implementing function. This is the same style used in
master cli commands implementation.


  Commit: b1041faa139262422f15c2e7aba687af58501bbc
      https://github.com/buildbot/buildbot/commit/b1041faa139262422f15c2e7aba687af58501bbc
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py
    M slave/buildslave/scripts/startup.py
    M slave/buildslave/test/unit/test_scripts_runner.py
    M slave/buildslave/test/unit/test_scripts_startup.py

  Log Message:
  -----------
  return exit code from buildslave subcommands functions

Use 'return' to communicate buildslave subcommand exit code. This is
how buildbot subcommands are implemented.


  Commit: 272246fba02389a078f30a8294f1178951bb6875
      https://github.com/buildbot/buildbot/commit/272246fba02389a078f30a8294f1178951bb6875
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  test handling of invalid arguments to 'buildslave' cli command

Added unit tests on code in buildslave.scripts.runner.run() that
handles invalid command line arguments.


  Commit: 0875f29b577a488760dec82afe175eeeca18377c
      https://github.com/buildbot/buildbot/commit/0875f29b577a488760dec82afe175eeeca18377c
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  unit test successful invocation of 'buildslave' cli command


  Commit: ec62eca18d933c837b42c41dfadeb3dfa68b23a7
      https://github.com/buildbot/buildbot/commit/ec62eca18d933c837b42c41dfadeb3dfa68b23a7
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  unit test options parsing for 'buildslave' command without arguments

Test that buildslave.scripts.runner.Options class flags invocation of
'buildslave' command without arguments, as invalid.


  Commit: 73d2b5b93598033758c6d56129672c1bf4ec7a2f
      https://github.com/buildbot/buildbot/commit/73d2b5b93598033758c6d56129672c1bf4ec7a2f
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  unit test handling of '--verbose' option for 'buildslave' command


  Commit: e31e40389e1c52abc3f308eb72e2a62a663f5529
      https://github.com/buildbot/buildbot/commit/e31e40389e1c52abc3f308eb72e2a62a663f5529
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  unit test handling of '--version' option for 'buildslave' command


  Commit: d8626361079a9e5a4fc32ed8619794e7ac9b4f82
      https://github.com/buildbot/buildbot/commit/d8626361079a9e5a4fc32ed8619794e7ac9b4f82
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  added unit tests on buildslave cli Options classes


  Commit: 41702af666a1b9575cf8b5cf7bd7e936d9c1d939
      https://github.com/buildbot/buildbot/commit/41702af666a1b9575cf8b5cf7bd7e936d9c1d939
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-21 (Sun, 21 Apr 2013)

  Changed paths:
    A slave/buildslave/scripts/create_slave.py
    A slave/buildslave/scripts/restart.py
    M slave/buildslave/scripts/runner.py
    A slave/buildslave/scripts/start.py
    R slave/buildslave/scripts/startup.py
    A slave/buildslave/scripts/stop.py
    A slave/buildslave/scripts/upgrade_slave.py
    M slave/buildslave/test/test_extra_coverage.py
    A slave/buildslave/test/unit/test_scripts_restart.py
    M slave/buildslave/test/unit/test_scripts_runner.py
    A slave/buildslave/test/unit/test_scripts_start.py
    R slave/buildslave/test/unit/test_scripts_startup.py
    A slave/buildslave/test/unit/test_scripts_stop.py
    A slave/buildslave/test/unit/test_scripts_upgrade_slave.py

  Log Message:
  -----------
  buildslave cli: broke out subcommand code to separate modules

Moved sumcommands implementations from buildslave.scripts.runner to
separate modules, one for each subcommand.


  Commit: ad302035cf476ad0aa141a57f995987545a37cf3
      https://github.com/buildbot/buildbot/commit/ad302035cf476ad0aa141a57f995987545a37cf3
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-22 (Mon, 22 Apr 2013)

  Changed paths:
    A slave/buildslave/scripts/create_slave.py
    A slave/buildslave/scripts/restart.py
    M slave/buildslave/scripts/runner.py
    A slave/buildslave/scripts/start.py
    R slave/buildslave/scripts/startup.py
    A slave/buildslave/scripts/stop.py
    A slave/buildslave/scripts/upgrade_slave.py
    M slave/buildslave/test/test_extra_coverage.py
    A slave/buildslave/test/unit/test_scripts_restart.py
    M slave/buildslave/test/unit/test_scripts_runner.py
    A slave/buildslave/test/unit/test_scripts_start.py
    A slave/buildslave/test/unit/test_scripts_stop.py
    A slave/buildslave/test/unit/test_scripts_upgrade_slave.py
    M slave/buildslave/test/util/misc.py

  Log Message:
  -----------
  Merge branch 'slave-cli-fixes' of git://github.com/elmirjagudin/buildbot


Compare: https://github.com/buildbot/buildbot/compare/1ef0b6a8161b...ad302035cf47