[Buildbot-commits] [buildbot/buildbot] a24972: removed unused feature in buildslave.scripts.runne...

GitHub noreply at github.com
Fri Apr 12 01:17:58 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: a24972f01562164a5bb6c1fec887b8cfa9076182
      https://github.com/buildbot/buildbot/commit/a24972f01562164a5bb6c1fec887b8cfa9076182
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-07 (Sun, 07 Apr 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py

  Log Message:
  -----------
  removed unused feature in buildslave.scripts.runner.stop()

No code calls stop() with wait flag disabled. Remove wait parameter,
and changed stop() to always wait for the process to finish.


  Commit: 10dceeb46689cc59986d8fa6e8b12d37bf06a2b8
      https://github.com/buildbot/buildbot/commit/10dceeb46689cc59986d8fa6e8b12d37bf06a2b8
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-07 (Sun, 07 Apr 2013)

  Changed paths:
    M slave/buildslave/test/util/misc.py

  Log Message:
  -----------
  copy StdoutAssertionsMixin class to slave test util package


  Commit: d22a54d17a6f4fea44b96d908c45668c296b8a77
      https://github.com/buildbot/buildbot/commit/d22a54d17a6f4fea44b96d908c45668c296b8a77
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-07 (Sun, 07 Apr 2013)

  Changed paths:
    M slave/buildslave/test/unit/test_scripts_base.py
    M slave/buildslave/test/util/misc.py

  Log Message:
  -----------
  tests: broke out open() patching code to a mix in class

Created buildslave.test.util.misc.OpenFileMixin class with methods
for patching open() to simulate successful reads and I/O errors.


  Commit: c7da46f05c0e282aaa59666dfa32325e27a9db4f
      https://github.com/buildbot/buildbot/commit/c7da46f05c0e282aaa59666dfa32325e27a9db4f
  Author: Elmir Jagudin <elmir at axis.com>
  Date:   2013-04-07 (Sun, 07 Apr 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py
    M slave/buildslave/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  fixed incorrectly printed message on 'buildslave restart'

Don't print 'no old buildslave process found to stop' when old
slave process was successfully terminated.

Previously stop() returned 'None' when slave was successfully
stoped. To restart() it looked like we failed to stop the slave.

Broke out the code to stop slave into a new stopSlave() utility
function, which will raise an exception if no slave is running.
Use stopSlave() from stop() and restart(), handle the exception
as appropriate for each case.


  Commit: eb51c2766d96e7921347260d88608f44409af2ef
      https://github.com/buildbot/buildbot/commit/eb51c2766d96e7921347260d88608f44409af2ef
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-11 (Thu, 11 Apr 2013)

  Changed paths:
    M slave/buildslave/scripts/runner.py
    M slave/buildslave/test/unit/test_scripts_base.py
    M slave/buildslave/test/unit/test_scripts_runner.py
    M slave/buildslave/test/util/misc.py

  Log Message:
  -----------
  Merge branch 'slave-restart-msg' of git://github.com/elmirjagudin/buildbot


Compare: https://github.com/buildbot/buildbot/compare/b885a23c2455...eb51c2766d96


More information about the Commits mailing list