[Buildbot-commits] [buildbot/buildbot] 1ef73e: initial master side P4() source step

Fri Apr 5 19:35:13 UTC 2013

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 1ef73eaff39effcda5ed2a76d3628ac2c40c52cc
      https://github.com/buildbot/buildbot/commit/1ef73eaff39effcda5ed2a76d3628ac2c40c52cc
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2012-12-23 (Sun, 23 Dec 2012)

  Changed paths:
    A master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  initial master side P4() source step


  Commit: e00cd0cf42d85cbf8ce9b81f849bd665d9edee0a
      https://github.com/buildbot/buildbot/commit/e00cd0cf42d85cbf8ce9b81f849bd665d9edee0a
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2012-12-26 (Wed, 26 Dec 2012)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  removed defaultBranch argument which has no purpose. Improved API docs. Added P4:.. prefixing on logging.


  Commit: eee944a003b58fdb9e039c35d4cec447a631211f
      https://github.com/buildbot/buildbot/commit/eee944a003b58fdb9e039c35d4cec447a631211f
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2012-12-26 (Wed, 26 Dec 2012)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  added docs for P4 master side source step


  Commit: f6696011982cdcff04d0d9294c507642dbabacf9
      https://github.com/buildbot/buildbot/commit/f6696011982cdcff04d0d9294c507642dbabacf9
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-01-05 (Sat, 05 Jan 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  address jaredgrubb's pull feedback


  Commit: 783768390bf4ef5814d8fb22839f461af737a123
      https://github.com/buildbot/buildbot/commit/783768390bf4ef5814d8fb22839f461af737a123
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-18 (Mon, 18 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  remove possible_methods per pull request comment since it doesn't really apply to perforce


  Commit: 59424080de21601f35de7489a8ca657ebdca1792
      https://github.com/buildbot/buildbot/commit/59424080de21601f35de7489a8ca657ebdca1792
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-18 (Mon, 18 Mar 2013)

  Changed paths:
    M MAINTAINERS.txt
    M common/validate.sh
    M master/buildbot/__init__.py
    M master/buildbot/buildslave.py
    M master/buildbot/changes/hgpoller.py
    M master/buildbot/changes/svnpoller.py
    M master/buildbot/clients/gtkPanes.py
    M master/buildbot/clients/tryclient.py
    M master/buildbot/config.py
    M master/buildbot/db/buildrequests.py
    M master/buildbot/db/pool.py
    M master/buildbot/db/schedulers.py
    M master/buildbot/interfaces.py
    M master/buildbot/libvirtbuildslave.py
    M master/buildbot/locks.py
    M master/buildbot/manhole.py
    M master/buildbot/master.py
    M master/buildbot/monkeypatches/__init__.py
    A master/buildbot/monkeypatches/gatherResults.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/build.py
    M master/buildbot/process/builder.py
    A master/buildbot/process/buildrequestdistributor.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/metrics.py
    M master/buildbot/schedulers/base.py
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/forcesched.py
    M master/buildbot/scripts/runner.py
    M master/buildbot/scripts/stop.py
    M master/buildbot/scripts/user.py
    M master/buildbot/sourcestamp.py
    M master/buildbot/status/base.py
    M master/buildbot/status/buildrequest.py
    M master/buildbot/status/client.py
    M master/buildbot/status/logfile.py
    M master/buildbot/status/slave.py
    M master/buildbot/status/status_push.py
    M master/buildbot/status/web/authz.py
    M master/buildbot/status/web/baseweb.py
    M master/buildbot/status/web/build.py
    M master/buildbot/status/web/builder.py
    M master/buildbot/status/web/files/default.css
    M master/buildbot/status/web/grid.py
    M master/buildbot/status/web/logs.py
    M master/buildbot/status/web/slaves.py
    M master/buildbot/status/web/templates/build.html
    M master/buildbot/status/web/templates/builder.html
    M master/buildbot/status/web/templates/buildslave.html
    M master/buildbot/status/web/templates/buildslaves.html
    M master/buildbot/status/web/templates/forms.html
    M master/buildbot/status/web/templates/grid_macros.html
    M master/buildbot/status/web/templates/waterfallhelp.html
    M master/buildbot/status/words.py
    M master/buildbot/steps/package/deb/pbuilder.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/git.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/fake/botmaster.py
    M master/buildbot/test/fake/fakedb.py
    M master/buildbot/test/fake/fakemaster.py
    M master/buildbot/test/integration/test_master.py
    M master/buildbot/test/integration/test_slave_comm.py
    M master/buildbot/test/unit/test_buildslave.py
    M master/buildbot/test/unit/test_changes_gitpoller.py
    M master/buildbot/test/unit/test_changes_hgpoller.py
    M master/buildbot/test/unit/test_config.py
    M master/buildbot/test/unit/test_db_buildrequests.py
    M master/buildbot/test/unit/test_master.py
    R master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py
    M master/buildbot/test/unit/test_process_botmaster_DuplicateSlaveArbitrator.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_process_builder.py
    A master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    M master/buildbot/test/unit/test_schedulers_forcesched.py
    M master/buildbot/test/unit/test_scripts_restart.py
    M master/buildbot/test/unit/test_scripts_runner.py
    M master/buildbot/test/unit/test_scripts_start.py
    M master/buildbot/test/unit/test_scripts_stop.py
    M master/buildbot/test/unit/test_sourcestamp.py
    M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py
    M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py
    M master/buildbot/test/unit/test_status_words.py
    M master/buildbot/test/unit/test_steps_master.py
    M master/buildbot/test/unit/test_steps_package_deb_pbuilder.py
    M master/buildbot/test/unit/test_steps_python_twisted.py
    M master/buildbot/test/unit/test_steps_source_bzr.py
    M master/buildbot/test/unit/test_steps_source_git.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/test/unit/test_steps_source_svn.py
    M master/buildbot/test/unit/test_steps_trigger.py
    M master/buildbot/test/unit/test_steps_vstudio.py
    M master/buildbot/test/unit/test_util_misc.py
    M master/buildbot/test/util/steps.py
    M master/buildbot/util/maildir.py
    M master/contrib/bzr_buildbot.py
    M master/contrib/googlecode_atom.py
    M master/contrib/post_build_request.py
    M master/contrib/windows/buildbot_service.py
    M master/docs/developer/config.rst
    M master/docs/developer/database.rst
    M master/docs/developer/style.rst
    M master/docs/index.rst
    M master/docs/manual/cfg-builders.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/cfg-changesources.rst
    M master/docs/manual/cfg-properties.rst
    M master/docs/manual/cfg-schedulers.rst
    M master/docs/manual/cfg-statustargets.rst
    M master/docs/manual/cmdline.rst
    M master/docs/manual/concepts.rst
    M master/docs/manual/customization.rst
    M master/docs/relnotes/index.rst
    M master/docs/tutorial/firstrun.rst
    A master/docs/tutorial/fiveminutes.rst
    A master/docs/tutorial/further.rst
    M master/docs/tutorial/index.rst
    M master/setup.py
    M slave/buildslave/scripts/runner.py
    M slave/buildslave/test/__init__.py
    A slave/buildslave/test/unit/test_scripts_runner.py
    M slave/contrib/windows/buildbot_service.py

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/buildbot/buildbot into p4_master_step_2012


  Commit: 69e865c5ba9789f7e62420e60b5c13557fa1cc24
      https://github.com/buildbot/buildbot/commit/69e865c5ba9789f7e62420e60b5c13557fa1cc24
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-20 (Wed, 20 Mar 2013)

  Changed paths:
    A master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer


  Commit: 4717b652f5ddfe50beaf051214c96ab84da0e96e
      https://github.com/buildbot/buildbot/commit/4717b652f5ddfe50beaf051214c96ab84da0e96e
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-20 (Wed, 20 Mar 2013)

  Changed paths:
    M master/buildbot/process/properties.py
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer


  Commit: e4c2c364f13231289173567e34bf6571474f0053
      https://github.com/buildbot/buildbot/commit/e4c2c364f13231289173567e34bf6571474f0053
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-20 (Wed, 20 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  fixed merge conflict


  Commit: 160188ee1384f94fe40839fd4ee21353c5763cb5
      https://github.com/buildbot/buildbot/commit/160188ee1384f94fe40839fd4ee21353c5763cb5
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-22 (Fri, 22 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  improved validation logic in __init__, and added tests to cover this. Also address comment by jaredgrubb regarding clipped comment


  Commit: e84d29118308e7c45c90861a91aa7168565615d7
      https://github.com/buildbot/buildbot/commit/e84d29118308e7c45c90861a91aa7168565615d7
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-22 (Fri, 22 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  Added test for incremental mode checkout


  Commit: 57f2d0d5c29b66d741e2d9f1ea3a390c0030866f
      https://github.com/buildbot/buildbot/commit/57f2d0d5c29b66d741e2d9f1ea3a390c0030866f
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  Remove some code copied from SVN tests. Add comment to clarify purpose of setting property in setupStep


  Commit: 312a7e181e15fd7798152018155cf53eb9db50e4
      https://github.com/buildbot/buildbot/commit/312a7e181e15fd7798152018155cf53eb9db50e4
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  added test for full checkout. Added _rmdir() method to P4 needed for full command.


  Commit: 637aa88872fc66235dacc444bca8a6781a33b2a6
      https://github.com/buildbot/buildbot/commit/637aa88872fc66235dacc444bca8a6781a33b2a6
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  revised P4 step docs to match changes in code.


  Commit: 6756c8cfee0261f35943e2b958239be2bc8becb8
      https://github.com/buildbot/buildbot/commit/6756c8cfee0261f35943e2b958239be2bc8becb8
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  fix pyflakes issues with new P4 and test code


  Commit: 0ada49ba81bf86e952c29d567d3bba3457118bd1
      https://github.com/buildbot/buildbot/commit/0ada49ba81bf86e952c29d567d3bba3457118bd1
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  Handle skipping some config checking if either p4base or p4branch is a renderanble


  Commit: 9db15b26599e797aa930af94816048fcea8f3942
      https://github.com/buildbot/buildbot/commit/9db15b26599e797aa930af94816048fcea8f3942
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  removed extra tests copied from SVN's test. Reorganized tests to have simpler logic. Added tests for Renderable parameters


  Commit: f5f31c5a558635d48cba8584530061458cace9a1
      https://github.com/buildbot/buildbot/commit/f5f31c5a558635d48cba8584530061458cace9a1
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-24 (Sun, 24 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  added test to check that specifying a revision works properly. Required setting the revision property on the mocked sourcestamp


  Commit: 48445b56f6d02d26f7f2780413f3f47d154a2740
      https://github.com/buildbot/buildbot/commit/48445b56f6d02d26f7f2780413f3f47d154a2740
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  address feedback on pull request by deleting logic no longer required in __init__ method of P4.


  Commit: 91b5b23199890aeae663657e1d6d2124fb43ee84
      https://github.com/buildbot/buildbot/commit/91b5b23199890aeae663657e1d6d2124fb43ee84
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-27 (Wed, 27 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  Remove some commented out logic


  Commit: 74bac041deaf9784f7d8ff108888e928c6e2032d
      https://github.com/buildbot/buildbot/commit/74bac041deaf9784f7d8ff108888e928c6e2032d
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-31 (Sun, 31 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  Move extra logging to be toggled by debug_logging variable. Migrate doc string to comment


  Commit: e037ca6e4a5d17d2c4d0bbfdf46540708165618a
      https://github.com/buildbot/buildbot/commit/e037ca6e4a5d17d2c4d0bbfdf46540708165618a
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-03-31 (Sun, 31 Mar 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  PEP8'd code. Addressed formatting issues minus some long lines


  Commit: c810644b3590ca5488491cc1861f8588ed273894
      https://github.com/buildbot/buildbot/commit/c810644b3590ca5488491cc1861f8588ed273894
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  strip trailing whitespace


  Commit: e79fe1c6e7e475bfbae388e661a7f1d43b230c25
      https://github.com/buildbot/buildbot/commit/e79fe1c6e7e475bfbae388e661a7f1d43b230c25
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  remove docstrings that are redundant to the real documentation


  Commit: 5d7e518970a26fdeb756c5a7694d3d947ec3d47b
      https://github.com/buildbot/buildbot/commit/5d7e518970a26fdeb756c5a7694d3d947ec3d47b
  Author: William Deegan <bill at baddogconsulting.com>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  used textwrap.dedent() to get rid of long lines per pull feedback. Addressed djmitche's comments regarding full tests not having any variation in the expected generated clientspec by varying the parameters


  Commit: 89e73cec43b66da44197aa96a6ace757b6849104
      https://github.com/buildbot/buildbot/commit/89e73cec43b66da44197aa96a6ace757b6849104
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M master/buildbot/process/properties.py
    A master/buildbot/steps/source/p4.py
    A master/buildbot/test/unit/test_steps_source_p4.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  Merge branch 'p4_master_step_2012' of git://github.com/bdbaddog/buildbot


  Commit: e0cf99d372eeb02439757e78ea4b3499b7f6426c
      https://github.com/buildbot/buildbot/commit/e0cf99d372eeb02439757e78ea4b3499b7f6426c
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_p4.py

  Log Message:
  -----------
  trivial whitespace, line-length fixups


  Commit: a8befb363661ca51275ff0260abb3af6c2577a82
      https://github.com/buildbot/buildbot/commit/a8befb363661ca51275ff0260abb3af6c2577a82
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  add relnotes


Compare: https://github.com/buildbot/buildbot/compare/c4f4cfad37ca...a8befb363661