From trac at buildbot.net Mon Apr 1 18:48:48 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Apr 2013 18:48:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2464: gitpoller dying In-Reply-To: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> References: <039.bc288698b5a1a9442f1f05bfb814a4e9@buildbot.net> Message-ID: <054.b9a66b00f81c271d61375fb9b7059817@buildbot.net> #2464: gitpoller dying ---------------------------+-------------------- Reporter: virgilg | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: simple, sprint | ---------------------------+-------------------- Old description: > After a buildmaster restart (buildmaster 0.8.7p1 on OS X 10.8.2) we're > getting the following traceback: > > {{{ > 2013-03-05 15:02:14-0800 [-] > /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/utils.py:25: > exceptions.DeprecationWarning: Argument strings and environment > keys/values passed to reactor.spawnProcess should be str, not unicode. > 2013-03-05 15:02:14-0800 [-] gitpoller: processing 0 changes: [] from > "https://gitrepo.domain.com/Project/branch" > 2013-03-05 15:02:14-0800 [-] while polling for changes > Traceback (most recent call last): > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 368, in callback > self._startRunCallbacks(result) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 464, in _startRunCallbacks > self._runCallbacks() > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 551, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 1101, in gotResult > _inlineCallbacks(r, g, deferred) > --- --- > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 1043, in _inlineCallbacks > result = result.throwExceptionIntoGenerator(g) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/python/failure.py", > line 382, in throwExceptionIntoGenerator > return g.throw(self.type, self.value, self.tb) > File "/Library/Python/2.7/site- > packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line > 109, in poll > [self.repourl] + refspecs, path=self.workdir) > File > "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", > line 551, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File "/Library/Python/2.7/site- > packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line > 238, in _convert_nonzero_to_failure > % (code, stderr)) > exceptions.EnvironmentError: command failed with exit code 128: > fatal: https://gitrepo.domain.com/Project/branch/info/refs not found: did > you run git update-server-info on the server? > }}} > > The work directory looks fine. > {{{ > ~/buildmaster/gitpoller_work/Project-Branch-Version$ ls -al > total 16 > drwxr-xr-x 7 buildbot staff 238 Mar 5 18:22 . > drwxr-xr-x 8 buildbot staff 272 Feb 28 14:31 .. > -rw-r--r-- 1 buildbot staff 0 Mar 5 18:22 FETCH_HEAD > -rw-r--r-- 1 buildbot staff 23 Feb 26 20:27 HEAD > -rw-r--r-- 1 buildbot staff 85 Mar 5 18:22 config > drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 objects > drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 refs > }}} New description: After a buildmaster restart (buildmaster 0.8.7p1 on OS X 10.8.2) we're getting the following traceback: {{{ 2013-03-05 15:02:14-0800 [-] /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/utils.py:25: exceptions.DeprecationWarning: Argument strings and environment keys/values passed to reactor.spawnProcess should be str, not unicode. 2013-03-05 15:02:14-0800 [-] gitpoller: processing 0 changes: [] from "https://gitrepo.domain.com/Project/branch" 2013-03-05 15:02:14-0800 [-] while polling for changes Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 368, in callback self._startRunCallbacks(result) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 464, in _startRunCallbacks self._runCallbacks() File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1101, in gotResult _inlineCallbacks(r, g, deferred) --- --- File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1043, in _inlineCallbacks result = result.throwExceptionIntoGenerator(g) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/Library/Python/2.7/site- packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 109, in poll [self.repourl] + refspecs, path=self.workdir) File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/Library/Python/2.7/site- packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 238, in _convert_nonzero_to_failure % (code, stderr)) exceptions.EnvironmentError: command failed with exit code 128: fatal: https://gitrepo.domain.com/Project/branch/info/refs not found: did you run git update-server-info on the server? }}} The work directory looks fine. {{{ ~/buildmaster/gitpoller_work/Project-Branch-Version$ ls -al total 16 drwxr-xr-x 7 buildbot staff 238 Mar 5 18:22 . drwxr-xr-x 8 buildbot staff 272 Feb 28 14:31 .. -rw-r--r-- 1 buildbot staff 0 Mar 5 18:22 FETCH_HEAD -rw-r--r-- 1 buildbot staff 23 Feb 26 20:27 HEAD -rw-r--r-- 1 buildbot staff 85 Mar 5 18:22 config drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 objects drwxr-xr-x 4 buildbot staff 136 Feb 26 20:27 refs }}} -- Comment (by dustin): Rachel was working on this on the Sunday of the !PyCon sprints, but I haven't heard anything since. I don't have any contact info for her. So I'm assuming this is open and available for others to work on at this point. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 1 18:49:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 01 Apr 2013 18:49:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2439: add upgrade tests for 0.8.6p1 and 0.8.7p1 In-Reply-To: <038.3f37a3bf013b806e1b09f22ba0812e2d@buildbot.net> References: <038.3f37a3bf013b806e1b09f22ba0812e2d@buildbot.net> Message-ID: <053.82d0083c3932d289e024c1e18367b22c@buildbot.net> #2439: add upgrade tests for 0.8.6p1 and 0.8.7p1 --------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: tests, simple | --------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Old description: > We have upgrade tests for several previous versions, and need to add them > for these two versions. > > The task is this: > * set up a test config of the old version > * run a build or two > * trim down the results and make a tarball > * include that tarball in the source > * use it from `master/buildbot/test/integration/test_upgrade.py` > * make some worthwhile assertions about the resulting builds. > > This is a good chance both to set up a simple Buildbot install, and to > have a look at how some of Buildbot's tests are written. New description: We have upgrade tests for several previous versions, and need to add them for these two versions. The task is this: * set up a test config of the old version * run a build or two * trim down the results and make a tarball * include that tarball in the source * use it from `master/buildbot/test/integration/test_upgrade.py` * make some worthwhile assertions about the resulting builds. This is a good chance both to set up a simple Buildbot install, and to have a look at how some of Buildbot's tests are written. -- Comment: Erik wrapped this up during the !PyCon sprints. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Apr 2 20:59:43 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Apr 2013 13:59:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d80533: update README Message-ID: <515b46bf3cc09_36e8d7e13c982e@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: d80533bd40cee5af4dc35e7d000f110bcea2fd42 https://github.com/buildbot/buildbot/commit/d80533bd40cee5af4dc35e7d000f110bcea2fd42 Author: Dustin J. Mitchell Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M README.md Log Message: ----------- update README From noreply at github.com Tue Apr 2 20:59:46 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Apr 2013 13:59:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 3edede: tryclient: support commas in property CLI Message-ID: <515b46c24f03b_112711f013458114@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 3ededede704a9f9ac8a1035c534dca16e90ca3d4 https://github.com/buildbot/buildbot/commit/3ededede704a9f9ac8a1035c534dca16e90ca3d4 Author: Andrew Gallagher Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py M master/docs/manual/cmdline.rst M master/docs/relnotes/index.rst Log Message: ----------- tryclient: support commas in property CLI This adds a '--property' flag which contains single a property setting and can be set multiple times (allowing for comments in property values). Commit: 3ebf87be6ddd1390ff7f74e3db02a421439ed79a https://github.com/buildbot/buildbot/commit/3ebf87be6ddd1390ff7f74e3db02a421439ed79a Author: Dustin J. Mitchell Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py M master/docs/manual/cmdline.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'try_properties' of git://github.com/andrewjcg/buildbot Compare: https://github.com/buildbot/buildbot/compare/b5607c9929cf...3ebf87be6ddd From trac at buildbot.net Wed Apr 3 01:45:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 03 Apr 2013 01:45:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2370: check ShellCommand args against RemoteShellCommand In-Reply-To: <038.ef79cdc33c7e67d458efd1dc6db87eb7@buildbot.net> References: <038.ef79cdc33c7e67d458efd1dc6db87eb7@buildbot.net> Message-ID: <053.25d351d7dc27af66ec82a517b7114a14@buildbot.net> #2370: check ShellCommand args against RemoteShellCommand -------------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: reconfig, sprint, simple | -------------------------------------+-------------------- Old description: > Many of the args to !ShellCommand are passed on verbatim to > !RemoteShellCommand, but this doesn't happen during the configuration > load, leading to nasty landmines for users. > > For example, `ShellCommand(some_unknown_argument=10)` will pass a > configuration check just fine, but will fail when the step runs. > > If possible, we should figure out a way to check these at install time, > perhaps just by using {{{inspect}}} to see what args > {{{RemoteShellCommand.__init__}}} takes, and ensuring that the arguments > to !ShellCommand match that set. New description: Many of the args to !ShellCommand are passed on verbatim to !RemoteShellCommand, but this doesn't happen during the configuration load, leading to nasty landmines for users. For example, `ShellCommand(some_unknown_argument=10)` will pass a configuration check just fine, but will fail when the step runs. If possible, we should figure out a way to check these at install time, perhaps just by using {{{inspect}}} to see what args {{{RemoteShellCommand.__init__}}} takes, and ensuring that the arguments to !ShellCommand match that set. -- Comment (by dustin): This needs a release note, and a minor change to the tests: use `assertRaisesConfigError` (`from buildbot.test.util import config` and mix in `config.ConfigErrorsMixin`). And submit a GitHub pull request. Other than that, it looks great. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Apr 3 02:17:16 2013 From: noreply at github.com (GitHub) Date: Tue, 02 Apr 2013 19:17:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9205de: Add 'config' parameter to Git source build step to... Message-ID: <515b912c723ef_39d2a011309141a@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9205de58093c04c6871994105a34333f8c5dde07 https://github.com/buildbot/buildbot/commit/9205de58093c04c6871994105a34333f8c5dde07 Author: Andrew Gallagher Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Add 'config' parameter to Git source build step to enable git-config settings when running the low-level git commands. Commit: 9ec2372129b48842b5c3bc5e933b28ed728d46e3 https://github.com/buildbot/buildbot/commit/9ec2372129b48842b5c3bc5e933b28ed728d46e3 Author: Dustin J. Mitchell Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'git_config' of git://github.com/andrewjcg/buildbot Compare: https://github.com/buildbot/buildbot/compare/3ebf87be6ddd...9ec2372129b4 From noreply at github.com Wed Apr 3 14:24:27 2013 From: noreply at github.com (GitHub) Date: Wed, 03 Apr 2013 07:24:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f49a23: Pass tryclient properties to getAvailableBuilderNa... Message-ID: <515c3b9b7f406_311512e713c119f@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f49a23baad31a37599679362404f9f2b3e78aa1d https://github.com/buildbot/buildbot/commit/f49a23baad31a37599679362404f9f2b3e78aa1d Author: Andrew Gallagher Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py A master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Pass tryclient properties to getAvailableBuilderNames call Commit: 46a81edbecee41e9042b7d1bbf928e13d59e618d https://github.com/buildbot/buildbot/commit/46a81edbecee41e9042b7d1bbf928e13d59e618d Author: Dustin J. Mitchell Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py A master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'try_client_available_builder_names' of git://github.com/andrewjcg/buildbot (with pyflakes fix) Compare: https://github.com/buildbot/buildbot/compare/9ec2372129b4...46a81edbecee From trac at buildbot.net Wed Apr 3 17:24:36 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 03 Apr 2013 17:24:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2482: add timestamping to log streams Message-ID: <039.42c4ce421b91866ae7b5510c40355055@buildbot.net> #2482: add timestamping to log streams ------------------------+----------------------------- Reporter: brendan | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: metrics logging ------------------------+----------------------------- It would be very helpful for diagnosing build performance (among other things) to record the times at which log messages were received by the slave step, for log files or stderr/stdout. We could perhaps extend the stream tags (stdout/stderr etc) with alternate versions that include timestamps. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Apr 3 18:12:15 2013 From: noreply at github.com (GitHub) Date: Wed, 03 Apr 2013 11:12:15 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b6bdd8: don't print error message until after checking exc... Message-ID: <515c70ff92227_48791385134297e0@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b6bdd89a47f31efb32148622a12017170450d6ee https://github.com/buildbot/buildbot/commit/b6bdd89a47f31efb32148622a12017170450d6ee Author: Dustin J. Mitchell Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- don't print error message until after checking exception type From trac at buildbot.net Wed Apr 3 19:25:50 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 03 Apr 2013 19:25:50 -0000 Subject: [Buildbot-commits] [Buildbot] #2482: add timestamping to log streams In-Reply-To: <039.42c4ce421b91866ae7b5510c40355055@buildbot.net> References: <039.42c4ce421b91866ae7b5510c40355055@buildbot.net> Message-ID: <054.954532b1b8fe0633e2454fd0172e46ba@buildbot.net> #2482: add timestamping to log streams ------------------------+-------------------- Reporter: brendan | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * keywords: metrics logging => * milestone: undecided => 0.9.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Apr 3 23:10:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 03 Apr 2013 23:10:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2370: check ShellCommand args against RemoteShellCommand In-Reply-To: <038.ef79cdc33c7e67d458efd1dc6db87eb7@buildbot.net> References: <038.ef79cdc33c7e67d458efd1dc6db87eb7@buildbot.net> Message-ID: <053.5886a062e97bc95b63bd93d0922b881b@buildbot.net> #2370: check ShellCommand args against RemoteShellCommand -------------------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: fixed Keywords: reconfig, sprint, simple | -------------------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: {{{ commit 6757fe9cecf51bcdfd7b2129a0e4decc6e02e444 Merge: b6bdd89 41cc80c Author: Dustin J. Mitchell Date: Wed Apr 3 19:08:11 2013 -0400 Merge branch 'ticket2370' of git://github.com/ffledgling/buildbot }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Apr 3 23:09:52 2013 From: noreply at github.com (GitHub) Date: Wed, 03 Apr 2013 16:09:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0adba8: Bugfix for ticket #2370, ShellCommand now checks v... Message-ID: <515cb6c09d230_4ae6ef112c601f2@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0adba8feae98d8efd6f24e5d6a8cf4534668e005 https://github.com/buildbot/buildbot/commit/0adba8feae98d8efd6f24e5d6a8cf4534668e005 Author: Anhad Jai Singh Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/relnotes/index.rst Log Message: ----------- Bugfix for ticket #2370, ShellCommand now checks validity of args during config rather than build Commit: 41cc80c4a12dd2c4dc0f0988f46fba79d5f9c65f https://github.com/buildbot/buildbot/commit/41cc80c4a12dd2c4dc0f0988f46fba79d5f9c65f Author: Anhad Jai Singh Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- removed unused variables from unit test Commit: 6757fe9cecf51bcdfd7b2129a0e4decc6e02e444 https://github.com/buildbot/buildbot/commit/6757fe9cecf51bcdfd7b2129a0e4decc6e02e444 Author: Dustin J. Mitchell Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'ticket2370' of git://github.com/ffledgling/buildbot Compare: https://github.com/buildbot/buildbot/compare/b6bdd89a47f3...6757fe9cecf5 From trac at buildbot.net Thu Apr 4 21:54:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 04 Apr 2013 21:54:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2483: Order of 'Force All Builds' in builder page is random Message-ID: <036.1a227c809f49e67fe98e23ffaaeaafd5@buildbot.net> #2483: Order of 'Force All Builds' in builder page is random ------------------------+----------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ------------------------+----------------------- If you have more than a few builders, it gets hard to find the force button for any particular builder. Let's sort them by name. See attached patch. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Apr 5 00:24:07 2013 From: noreply at github.com (GitHub) Date: Thu, 04 Apr 2013 17:24:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 21a8cb: sort force schedulers by name Message-ID: <515e19a773286_22ff11d313825823@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 21a8cbd186bd3cab9bdcb87cc51191f0ffa3e604 https://github.com/buildbot/buildbot/commit/21a8cbd186bd3cab9bdcb87cc51191f0ffa3e604 Author: Dan Kegel Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/status/web/templates/forms.html M master/docs/relnotes/index.rst Log Message: ----------- sort force schedulers by name From trac at buildbot.net Fri Apr 5 00:24:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Apr 2013 00:24:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2483: Order of 'Force All Builds' in builder page is random In-Reply-To: <036.1a227c809f49e67fe98e23ffaaeaafd5@buildbot.net> References: <036.1a227c809f49e67fe98e23ffaaeaafd5@buildbot.net> Message-ID: <051.0ed1a31408c7224889c1c750066c7a12@buildbot.net> #2483: Order of 'Force All Builds' in builder page is random ------------------------+--------------------- Reporter: dank | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: force | ------------------------+--------------------- Changes (by dustin): * keywords: => force * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.8 Comment: {{{ commit 21a8cbd186bd3cab9bdcb87cc51191f0ffa3e604 Author: Dan Kegel Date: Thu Apr 4 20:23:55 2013 -0400 sort force schedulers by name }}} Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Apr 5 00:38:14 2013 From: noreply at github.com (GitHub) Date: Thu, 04 Apr 2013 17:38:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fc728b: fix hgpoller keep inserting the change set Message-ID: <515e1cf6c6fcb_73b9e0c130760df@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fc728bfdabdd9d9bf421ec7f8604072bfa5fd52a https://github.com/buildbot/buildbot/commit/fc728bfdabdd9d9bf421ec7f8604072bfa5fd52a Author: maria marcano Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- fix hgpoller keep inserting the change set Commit: dfcfe3ae3d495ccaefec46a62ad21a8ef9dc2b8b https://github.com/buildbot/buildbot/commit/dfcfe3ae3d495ccaefec46a62ad21a8ef9dc2b8b Author: maria marcano Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- changed function named to_int -> addOid Commit: 3cfc97a7b905bc986b54fd3fe4bc9d90205eceaa https://github.com/buildbot/buildbot/commit/3cfc97a7b905bc986b54fd3fe4bc9d90205eceaa Author: maria marcano Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- fix failing tests - some tests were expecting an int value some tests were expecting an int value and string was return Commit: d0cd62b6049759d89b09b1512dab2268132fd30d https://github.com/buildbot/buildbot/commit/d0cd62b6049759d89b09b1512dab2268132fd30d Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- Merge branch 'pull675' Compare: https://github.com/buildbot/buildbot/compare/21a8cbd186bd...d0cd62b60497 From noreply at github.com Fri Apr 5 00:40:07 2013 From: noreply at github.com (GitHub) Date: Thu, 04 Apr 2013 17:40:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8d4bf1: RemoteShellCommand: add parameters to override use... Message-ID: <515e1d675cf39_3eaeae013c547c7@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8d4bf15fc6110676ed2b6e0968ace502fa1b710f https://github.com/buildbot/buildbot/commit/8d4bf15fc6110676ed2b6e0968ace502fa1b710f Author: Andrew Gallagher Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- RemoteShellCommand: add parameters to override user the command is run as Commit: b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e https://github.com/buildbot/buildbot/commit/b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'uid_gid' of git://github.com/andrewjcg/buildbot Compare: https://github.com/buildbot/buildbot/compare/d0cd62b60497...b5cbb73bdd1f From noreply at github.com Fri Apr 5 00:49:24 2013 From: noreply at github.com (GitHub) Date: Thu, 04 Apr 2013 17:49:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 537a7a: Add latent buildslave for OpenStack Message-ID: <515e1f94c0f4d_7548e5c13074f7@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 537a7a78e857c70e928d3cb1a54ff7156393a616 https://github.com/buildbot/buildbot/commit/537a7a78e857c70e928d3cb1a54ff7156393a616 Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: A master/buildbot/openstackbuildslave.py A master/buildbot/test/fake/openstack.py A master/buildbot/test/unit/test_openstackbuildslave.py Log Message: ----------- Add latent buildslave for OpenStack The buildslave has limited functionality for interacting with OpenStack's Nova component. Booting and terminating instances works correctly, but no interfacing with the network part. Commit: 868b5888e39941676db7e3d30568b611d39a5217 https://github.com/buildbot/buildbot/commit/868b5888e39941676db7e3d30568b611d39a5217 Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: R master/buildbot/buildslave.py A master/buildbot/buildslave/__init__.py Log Message: ----------- Move buildslave.py into buildbot.buildslave Commit: e598df1772e30b05bd69f9a864d5ce20647a8f59 https://github.com/buildbot/buildbot/commit/e598df1772e30b05bd69f9a864d5ce20647a8f59 Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: A master/buildbot/buildslave/openstack.py R master/buildbot/openstackbuildslave.py A master/buildbot/test/unit/test_buildslave_openstack.py R master/buildbot/test/unit/test_openstackbuildslave.py Log Message: ----------- Move openstackbuildslave.py into buildbot.buildslave.openstack Commit: eabb0efb91a9c305d6184b3007f96c86fecd84cf https://github.com/buildbot/buildbot/commit/eabb0efb91a9c305d6184b3007f96c86fecd84cf Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Add blurb in release notes Commit: 6e01658e3c4a90e2a41deb3f195df60306437ffa https://github.com/buildbot/buildbot/commit/6e01658e3c4a90e2a41deb3f195df60306437ffa Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Add documentation on how to use new Openstack latent slave Commit: a65d53c8c9d5dceb94c21ce4724f6a5787f474cf https://github.com/buildbot/buildbot/commit/a65d53c8c9d5dceb94c21ce4724f6a5787f474cf Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Use callable instead Commit: a7cccfe2bd81054143bde46b490e2e11fbd26c7e https://github.com/buildbot/buildbot/commit/a7cccfe2bd81054143bde46b490e2e11fbd26c7e Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/buildslave/openstack.py M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- Use camelCase instead of underscores Commit: 3c2f14caccad14f183d3aeba823b2e027da1e607 https://github.com/buildbot/buildbot/commit/3c2f14caccad14f183d3aeba823b2e027da1e607 Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- Drop creating and using ConcreteBuildSlave Not using an abstract slave, so do not need a concrete version. Some of the lines are a bit long; this will be fixed later. Commit: 109e5af8c8191bd0d2e357fe6d3ffc3e10d4c033 https://github.com/buildbot/buildbot/commit/109e5af8c8191bd0d2e357fe6d3ffc3e10d4c033 Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- Use keyword args in test Due to the number of required arguments, use keywords for them to be clearer about what's being specified. Also changed the flavor to be an integer because the docs say to pass the flavor ID, not name. Commit: 3bea6083c9e625560a77c10c415422c87e07f4b3 https://github.com/buildbot/buildbot/commit/3bea6083c9e625560a77c10c415422c87e07f4b3 Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Update docs Use keyword arguments in the examples and list the keyword arguments with a brief description on each. Commit: 6cdebaca0d58a0e2fdf2c1a949421a286863add6 https://github.com/buildbot/buildbot/commit/6cdebaca0d58a0e2fdf2c1a949421a286863add6 Author: Sean Kelly Date: 2013-03-29 (Fri, 29 Mar 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Include the image UUID in the log The instance name was included in the log message, but this is identical to the slave name. Instead, include the image UUID as this could actually help in debugging. Commit: fa0e6215766144949a7d5ac7472533a09ffb3127 https://github.com/buildbot/buildbot/commit/fa0e6215766144949a7d5ac7472533a09ffb3127 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: R master/buildbot/buildslave.py A master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/openstack.py A master/buildbot/test/fake/openstack.py A master/buildbot/test/unit/test_buildslave_openstack.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'openstack' of git://github.com/crayinc/buildbot Commit: 845cba944cedb4eab496aa68a8c5dceba6fb2521 https://github.com/buildbot/buildbot/commit/845cba944cedb4eab496aa68a8c5dceba6fb2521 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/buildslave/openstack.py M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- fix pyflakes Compare: https://github.com/buildbot/buildbot/compare/b5cbb73bdd1f...845cba944ced From noreply at github.com Fri Apr 5 01:18:47 2013 From: noreply at github.com (GitHub) Date: Thu, 04 Apr 2013 18:18:47 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 60c07f: fix repr for Interpolate Message-ID: <515e267774bc_687690b12c18075@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 60c07f3d32987515c7b79f62eed101ef4c164d48 https://github.com/buildbot/buildbot/commit/60c07f3d32987515c7b79f62eed101ef4c164d48 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- fix repr for Interpolate Commit: 852c0dfbe07d27fd6c254b925b44b60e9ecc1f24 https://github.com/buildbot/buildbot/commit/852c0dfbe07d27fd6c254b925b44b60e9ecc1f24 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- strip trailing whitespace Compare: https://github.com/buildbot/buildbot/compare/845cba944ced...852c0dfbe07d From noreply at github.com Fri Apr 5 01:19:48 2013 From: noreply at github.com (GitHub) Date: Thu, 04 Apr 2013 18:19:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 537a7a: Add latent buildslave for OpenStack Message-ID: <515e26b4bfe4b_4739122c134319c0@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 537a7a78e857c70e928d3cb1a54ff7156393a616 https://github.com/buildbot/buildbot/commit/537a7a78e857c70e928d3cb1a54ff7156393a616 Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: A master/buildbot/openstackbuildslave.py A master/buildbot/test/fake/openstack.py A master/buildbot/test/unit/test_openstackbuildslave.py Log Message: ----------- Add latent buildslave for OpenStack The buildslave has limited functionality for interacting with OpenStack's Nova component. Booting and terminating instances works correctly, but no interfacing with the network part. Commit: 868b5888e39941676db7e3d30568b611d39a5217 https://github.com/buildbot/buildbot/commit/868b5888e39941676db7e3d30568b611d39a5217 Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: R master/buildbot/buildslave.py A master/buildbot/buildslave/__init__.py Log Message: ----------- Move buildslave.py into buildbot.buildslave Commit: e598df1772e30b05bd69f9a864d5ce20647a8f59 https://github.com/buildbot/buildbot/commit/e598df1772e30b05bd69f9a864d5ce20647a8f59 Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: A master/buildbot/buildslave/openstack.py R master/buildbot/openstackbuildslave.py A master/buildbot/test/unit/test_buildslave_openstack.py R master/buildbot/test/unit/test_openstackbuildslave.py Log Message: ----------- Move openstackbuildslave.py into buildbot.buildslave.openstack Commit: eabb0efb91a9c305d6184b3007f96c86fecd84cf https://github.com/buildbot/buildbot/commit/eabb0efb91a9c305d6184b3007f96c86fecd84cf Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- Add blurb in release notes Commit: 6e01658e3c4a90e2a41deb3f195df60306437ffa https://github.com/buildbot/buildbot/commit/6e01658e3c4a90e2a41deb3f195df60306437ffa Author: Sean Kelly Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Add documentation on how to use new Openstack latent slave Commit: a65d53c8c9d5dceb94c21ce4724f6a5787f474cf https://github.com/buildbot/buildbot/commit/a65d53c8c9d5dceb94c21ce4724f6a5787f474cf Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Use callable instead Commit: a7cccfe2bd81054143bde46b490e2e11fbd26c7e https://github.com/buildbot/buildbot/commit/a7cccfe2bd81054143bde46b490e2e11fbd26c7e Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/buildslave/openstack.py M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- Use camelCase instead of underscores Commit: 3c2f14caccad14f183d3aeba823b2e027da1e607 https://github.com/buildbot/buildbot/commit/3c2f14caccad14f183d3aeba823b2e027da1e607 Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- Drop creating and using ConcreteBuildSlave Not using an abstract slave, so do not need a concrete version. Some of the lines are a bit long; this will be fixed later. Commit: 109e5af8c8191bd0d2e357fe6d3ffc3e10d4c033 https://github.com/buildbot/buildbot/commit/109e5af8c8191bd0d2e357fe6d3ffc3e10d4c033 Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- Use keyword args in test Due to the number of required arguments, use keywords for them to be clearer about what's being specified. Also changed the flavor to be an integer because the docs say to pass the flavor ID, not name. Commit: 3bea6083c9e625560a77c10c415422c87e07f4b3 https://github.com/buildbot/buildbot/commit/3bea6083c9e625560a77c10c415422c87e07f4b3 Author: Sean Kelly Date: 2013-03-19 (Tue, 19 Mar 2013) Changed paths: M master/docs/manual/cfg-buildslaves.rst Log Message: ----------- Update docs Use keyword arguments in the examples and list the keyword arguments with a brief description on each. Commit: 6cdebaca0d58a0e2fdf2c1a949421a286863add6 https://github.com/buildbot/buildbot/commit/6cdebaca0d58a0e2fdf2c1a949421a286863add6 Author: Sean Kelly Date: 2013-03-29 (Fri, 29 Mar 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Include the image UUID in the log The instance name was included in the log message, but this is identical to the slave name. Instead, include the image UUID as this could actually help in debugging. Commit: 9205de58093c04c6871994105a34333f8c5dde07 https://github.com/buildbot/buildbot/commit/9205de58093c04c6871994105a34333f8c5dde07 Author: Andrew Gallagher Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Add 'config' parameter to Git source build step to enable git-config settings when running the low-level git commands. Commit: 8d4bf15fc6110676ed2b6e0968ace502fa1b710f https://github.com/buildbot/buildbot/commit/8d4bf15fc6110676ed2b6e0968ace502fa1b710f Author: Andrew Gallagher Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- RemoteShellCommand: add parameters to override user the command is run as Commit: 3ededede704a9f9ac8a1035c534dca16e90ca3d4 https://github.com/buildbot/buildbot/commit/3ededede704a9f9ac8a1035c534dca16e90ca3d4 Author: Andrew Gallagher Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py M master/docs/manual/cmdline.rst M master/docs/relnotes/index.rst Log Message: ----------- tryclient: support commas in property CLI This adds a '--property' flag which contains single a property setting and can be set multiple times (allowing for comments in property values). Commit: 3ebf87be6ddd1390ff7f74e3db02a421439ed79a https://github.com/buildbot/buildbot/commit/3ebf87be6ddd1390ff7f74e3db02a421439ed79a Author: Dustin J. Mitchell Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/scripts/runner.py M master/buildbot/test/unit/test_scripts_runner.py M master/docs/manual/cmdline.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'try_properties' of git://github.com/andrewjcg/buildbot Commit: 9ec2372129b48842b5c3bc5e933b28ed728d46e3 https://github.com/buildbot/buildbot/commit/9ec2372129b48842b5c3bc5e933b28ed728d46e3 Author: Dustin J. Mitchell Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/steps/source/git.py M master/buildbot/test/unit/test_steps_source_git.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'git_config' of git://github.com/andrewjcg/buildbot Commit: f49a23baad31a37599679362404f9f2b3e78aa1d https://github.com/buildbot/buildbot/commit/f49a23baad31a37599679362404f9f2b3e78aa1d Author: Andrew Gallagher Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py A master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Pass tryclient properties to getAvailableBuilderNames call Commit: 46a81edbecee41e9042b7d1bbf928e13d59e618d https://github.com/buildbot/buildbot/commit/46a81edbecee41e9042b7d1bbf928e13d59e618d Author: Dustin J. Mitchell Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_schedulers_trysched.py A master/buildbot/test/util/pbclient.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'try_client_available_builder_names' of git://github.com/andrewjcg/buildbot (with pyflakes fix) Commit: b6bdd89a47f31efb32148622a12017170450d6ee https://github.com/buildbot/buildbot/commit/b6bdd89a47f31efb32148622a12017170450d6ee Author: Dustin J. Mitchell Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/buildslave.py Log Message: ----------- don't print error message until after checking exception type Commit: 0adba8feae98d8efd6f24e5d6a8cf4534668e005 https://github.com/buildbot/buildbot/commit/0adba8feae98d8efd6f24e5d6a8cf4534668e005 Author: Anhad Jai Singh Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/relnotes/index.rst Log Message: ----------- Bugfix for ticket #2370, ShellCommand now checks validity of args during config rather than build Commit: 41cc80c4a12dd2c4dc0f0988f46fba79d5f9c65f https://github.com/buildbot/buildbot/commit/41cc80c4a12dd2c4dc0f0988f46fba79d5f9c65f Author: Anhad Jai Singh Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- removed unused variables from unit test Commit: 6757fe9cecf51bcdfd7b2129a0e4decc6e02e444 https://github.com/buildbot/buildbot/commit/6757fe9cecf51bcdfd7b2129a0e4decc6e02e444 Author: Dustin J. Mitchell Date: 2013-04-03 (Wed, 03 Apr 2013) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'ticket2370' of git://github.com/ffledgling/buildbot Commit: 21a8cbd186bd3cab9bdcb87cc51191f0ffa3e604 https://github.com/buildbot/buildbot/commit/21a8cbd186bd3cab9bdcb87cc51191f0ffa3e604 Author: Dan Kegel Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/status/web/templates/forms.html M master/docs/relnotes/index.rst Log Message: ----------- sort force schedulers by name Commit: fc728bfdabdd9d9bf421ec7f8604072bfa5fd52a https://github.com/buildbot/buildbot/commit/fc728bfdabdd9d9bf421ec7f8604072bfa5fd52a Author: maria marcano Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- fix hgpoller keep inserting the change set Commit: dfcfe3ae3d495ccaefec46a62ad21a8ef9dc2b8b https://github.com/buildbot/buildbot/commit/dfcfe3ae3d495ccaefec46a62ad21a8ef9dc2b8b Author: maria marcano Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- changed function named to_int -> addOid Commit: 3cfc97a7b905bc986b54fd3fe4bc9d90205eceaa https://github.com/buildbot/buildbot/commit/3cfc97a7b905bc986b54fd3fe4bc9d90205eceaa Author: maria marcano Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- fix failing tests - some tests were expecting an int value some tests were expecting an int value and string was return Commit: d0cd62b6049759d89b09b1512dab2268132fd30d https://github.com/buildbot/buildbot/commit/d0cd62b6049759d89b09b1512dab2268132fd30d Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/changes/hgpoller.py Log Message: ----------- Merge branch 'pull675' Commit: b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e https://github.com/buildbot/buildbot/commit/b5cbb73bdd1fae2fd19ac4e3e7c14aa27419cd4e Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/interfaces/test_remotecommand.py M master/buildbot/test/unit/test_process_buildstep.py M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'uid_gid' of git://github.com/andrewjcg/buildbot Commit: fa0e6215766144949a7d5ac7472533a09ffb3127 https://github.com/buildbot/buildbot/commit/fa0e6215766144949a7d5ac7472533a09ffb3127 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: R master/buildbot/buildslave.py A master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/openstack.py A master/buildbot/test/fake/openstack.py A master/buildbot/test/unit/test_buildslave_openstack.py M master/docs/manual/cfg-buildslaves.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'openstack' of git://github.com/crayinc/buildbot Commit: 845cba944cedb4eab496aa68a8c5dceba6fb2521 https://github.com/buildbot/buildbot/commit/845cba944cedb4eab496aa68a8c5dceba6fb2521 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/buildslave/openstack.py M master/buildbot/test/unit/test_buildslave_openstack.py Log Message: ----------- fix pyflakes Commit: 60c07f3d32987515c7b79f62eed101ef4c164d48 https://github.com/buildbot/buildbot/commit/60c07f3d32987515c7b79f62eed101ef4c164d48 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- fix repr for Interpolate Commit: 852c0dfbe07d27fd6c254b925b44b60e9ecc1f24 https://github.com/buildbot/buildbot/commit/852c0dfbe07d27fd6c254b925b44b60e9ecc1f24 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M master/buildbot/process/properties.py Log Message: ----------- strip trailing whitespace Commit: 51a86b05c9a0a50f6f534b0e34c92b1420c077c4 https://github.com/buildbot/buildbot/commit/51a86b05c9a0a50f6f534b0e34c92b1420c077c4 Author: Dustin J. Mitchell Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: R master/buildbot/buildslave.py A master/buildbot/buildslave/__init__.py A master/buildbot/buildslave/openstack.py M master/buildbot/changes/hgpoller.py M master/buildbot/clients/tryclient.py M master/buildbot/process/buildstep.py M master/buildbot/process/properties.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/status/web/templates/forms.html M master/buildbot/steps/shell.py M master/buildbot/steps/source/git.py A master/buildbot/test/fake/openstack.py M master/buildbot/test/fake/remotecommand.py A master/buildbot/test/unit/test_buildslave_openstack.py M master/buildbot/test/unit/test_clients_sendchange.py M master/buildbot/test/unit/test_clients_tryclient.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_remotecommand.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/unit/test_steps_source_git.py A master/buildbot/test/util/pbclient.py M master/docs/manual/cfg-buildslaves.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cmdline.rst M master/docs/manual/introduction.rst M master/docs/relnotes/index.rst M slave/buildslave/commands/base.py M slave/buildslave/commands/shell.py M slave/buildslave/runprocess.py M slave/buildslave/test/fake/runprocess.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_runprocess.py Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/d80533bd40ce...51a86b05c9a0 From trac at buildbot.net Fri Apr 5 12:08:52 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Apr 2013 12:08:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2484: statusgui broken in 0.8.7p1 Message-ID: <039.541d1780cf77415e7c814e5d543ed14f@buildbot.net> #2484: statusgui broken in 0.8.7p1 --------------------+----------------------- Reporter: jbeuken | Owner: jbeuken Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: statusgui --------------------+----------------------- buildbot/clients/gtkPanes.py 30c30,31[[BR]] < from buildbot.clients.base import TextClient, StatusClient[[BR]] --- > from buildbot.clients.base import StatusClient[[BR]] > from buildbot.clients.text import TextClient[[BR]] -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 5 12:17:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Apr 2013 12:17:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2484: statusgui broken in 0.8.7p1 In-Reply-To: <039.541d1780cf77415e7c814e5d543ed14f@buildbot.net> References: <039.541d1780cf77415e7c814e5d543ed14f@buildbot.net> Message-ID: <054.fef8628a2b5b33540329de633d18788c@buildbot.net> #2484: statusgui broken in 0.8.7p1 --------------------+---------------------- Reporter: jbeuken | Owner: jbeuken Type: defect | Status: closed Priority: minor | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: | --------------------+---------------------- Changes (by dustin): * keywords: statusgui => * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.8 Comment: Elmir already caught this one, but thanks: {{{ commit e88030484e91e569741a4efc727a383cabc865a9 Author: Elmir Jagudin Date: Mon Feb 11 08:14:27 2013 +0100 fixed import of TextClient class in gtkPanes module The TextClient class have been moved to text module. Now it should be possible to run 'buildbot statusgui' again. }}} It would be great if this feature could get some tests and documentation for the API. As it is, I really don't know how it works and what it does, so I'm going to have a hard time porting it to nine. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Apr 5 12:41:17 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Apr 2013 05:41:17 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 815519: renamed SlaveOption class to CreateSlaveOption Message-ID: <515ec66d4471_7cd2104012c4308c@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 815519f2d10b7b7c495eec466b287aad15c44d8a https://github.com/buildbot/buildbot/commit/815519f2d10b7b7c495eec466b287aad15c44d8a Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- renamed SlaveOption class to CreateSlaveOption CreateSlaveOption is a more descriptive name, and follows the naming style of other subcommand's options classes. Commit: 7ced54fe5344bb877ec4d8ba654b3c6431974fd5 https://github.com/buildbot/buildbot/commit/7ced54fe5344bb877ec4d8ba654b3c6431974fd5 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/monkeypatches/__init__.py A slave/buildslave/monkeypatches/testcase_assert.py M slave/buildslave/test/__init__.py Log Message: ----------- add local assertRaisesRegexp() on python older then 2.7 When running tests on python older then 2.7, monkeypatch unittest.TestCase class to include assertRaisesRegexp() method. Commit: 24ba3ffd534a66c90b6441906be04368de475a8a https://github.com/buildbot/buildbot/commit/24ba3ffd534a66c90b6441906be04368de475a8a Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- catch invalid numeric parameters to 'buildslave create-slave' command When converting 'usepty', 'keepalive', 'maxdelay' and 'log-size' parameters to ints, catch ValueError exceptions and print error message. This way it is easier to troubleshoot incorrect parameters to create-slave command. Commit: 7ebed1efe42532982324ff6a6865eee41ade6ab4 https://github.com/buildbot/buildbot/commit/7ebed1efe42532982324ff6a6865eee41ade6ab4 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- accept exactly 4 arguments to 'buildslave create-slave' command Check that 'buildslave create-slave' command was invoked with exactly 4 arguments. Previously when create-slave was given more then 4 arguments, an 'ValueError: too many values to unpack' exception was raised. Commit: f19157bae5724c4decea254bfebbddf52610e856 https://github.com/buildbot/buildbot/commit/f19157bae5724c4decea254bfebbddf52610e856 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- added unit tests on CreateSlaveOptions class Test arguments parsing of valid 'buildslave create-slave' commands. Commit: 3ea680f22780bb45697fa46313dd536f726ced47 https://github.com/buildbot/buildbot/commit/3ea680f22780bb45697fa46313dd536f726ced47 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- test ' not URL' error for 'buildslave create-slave' command Commit: c479cf2ba8138b323b6bbecf2aebfacee5a2c46d https://github.com/buildbot/buildbot/commit/c479cf2ba8138b323b6bbecf2aebfacee5a2c46d Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M slave/buildslave/monkeypatches/__init__.py A slave/buildslave/monkeypatches/testcase_assert.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/__init__.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'create-slave-cli-args' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/852c0dfbe07d...c479cf2ba813 From noreply at github.com Fri Apr 5 12:48:34 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Apr 2013 05:48:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c4f4cf: actually apply the bug5079 patch on the slave Message-ID: <515ec822b7ef_79ad6c130498c1@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c4f4cfad37cac9630e9f456b34296e78006d67c7 https://github.com/buildbot/buildbot/commit/c4f4cfad37cac9630e9f456b34296e78006d67c7 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/docs/relnotes/index.rst M slave/buildslave/monkeypatches/__init__.py Log Message: ----------- actually apply the bug5079 patch on the slave Fixes #1958. From noreply at github.com Fri Apr 5 19:35:13 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Apr 2013 12:35:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1ef73e: initial master side P4() source step Message-ID: <515f277169552_39a095612c3412d@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1ef73eaff39effcda5ed2a76d3628ac2c40c52cc https://github.com/buildbot/buildbot/commit/1ef73eaff39effcda5ed2a76d3628ac2c40c52cc Author: William Deegan Date: 2012-12-23 (Sun, 23 Dec 2012) Changed paths: A master/buildbot/steps/source/p4.py Log Message: ----------- initial master side P4() source step Commit: e00cd0cf42d85cbf8ce9b81f849bd665d9edee0a https://github.com/buildbot/buildbot/commit/e00cd0cf42d85cbf8ce9b81f849bd665d9edee0a Author: William Deegan Date: 2012-12-26 (Wed, 26 Dec 2012) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- removed defaultBranch argument which has no purpose. Improved API docs. Added P4:.. prefixing on logging. Commit: eee944a003b58fdb9e039c35d4cec447a631211f https://github.com/buildbot/buildbot/commit/eee944a003b58fdb9e039c35d4cec447a631211f Author: William Deegan Date: 2012-12-26 (Wed, 26 Dec 2012) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- added docs for P4 master side source step Commit: f6696011982cdcff04d0d9294c507642dbabacf9 https://github.com/buildbot/buildbot/commit/f6696011982cdcff04d0d9294c507642dbabacf9 Author: William Deegan Date: 2013-01-05 (Sat, 05 Jan 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- address jaredgrubb's pull feedback Commit: 783768390bf4ef5814d8fb22839f461af737a123 https://github.com/buildbot/buildbot/commit/783768390bf4ef5814d8fb22839f461af737a123 Author: William Deegan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- remove possible_methods per pull request comment since it doesn't really apply to perforce Commit: 59424080de21601f35de7489a8ca657ebdca1792 https://github.com/buildbot/buildbot/commit/59424080de21601f35de7489a8ca657ebdca1792 Author: William Deegan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M MAINTAINERS.txt M common/validate.sh M master/buildbot/__init__.py M master/buildbot/buildslave.py M master/buildbot/changes/hgpoller.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/gtkPanes.py M master/buildbot/clients/tryclient.py M master/buildbot/config.py M master/buildbot/db/buildrequests.py M master/buildbot/db/pool.py M master/buildbot/db/schedulers.py M master/buildbot/interfaces.py M master/buildbot/libvirtbuildslave.py M master/buildbot/locks.py M master/buildbot/manhole.py M master/buildbot/master.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/gatherResults.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py A master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/process/metrics.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/forcesched.py M master/buildbot/scripts/runner.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/user.py M master/buildbot/sourcestamp.py M master/buildbot/status/base.py M master/buildbot/status/buildrequest.py M master/buildbot/status/client.py M master/buildbot/status/logfile.py M master/buildbot/status/slave.py M master/buildbot/status/status_push.py M master/buildbot/status/web/authz.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/files/default.css M master/buildbot/status/web/grid.py M master/buildbot/status/web/logs.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/templates/build.html M master/buildbot/status/web/templates/builder.html M master/buildbot/status/web/templates/buildslave.html M master/buildbot/status/web/templates/buildslaves.html M master/buildbot/status/web/templates/forms.html M master/buildbot/status/web/templates/grid_macros.html M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/words.py M master/buildbot/steps/package/deb/pbuilder.py M master/buildbot/steps/python_twisted.py M master/buildbot/steps/source/base.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/svn.py M master/buildbot/steps/transfer.py M master/buildbot/steps/vstudio.py M master/buildbot/test/fake/botmaster.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/fakemaster.py M master/buildbot/test/integration/test_master.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/unit/test_buildslave.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_master.py R master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_botmaster_DuplicateSlaveArbitrator.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_builder.py A master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_stop.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_status_words.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_package_deb_pbuilder.py M master/buildbot/test/unit/test_steps_python_twisted.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/unit/test_steps_source_svn.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/unit/test_steps_vstudio.py M master/buildbot/test/unit/test_util_misc.py M master/buildbot/test/util/steps.py M master/buildbot/util/maildir.py M master/contrib/bzr_buildbot.py M master/contrib/googlecode_atom.py M master/contrib/post_build_request.py M master/contrib/windows/buildbot_service.py M master/docs/developer/config.rst M master/docs/developer/database.rst M master/docs/developer/style.rst M master/docs/index.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-properties.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/cmdline.rst M master/docs/manual/concepts.rst M master/docs/manual/customization.rst M master/docs/relnotes/index.rst M master/docs/tutorial/firstrun.rst A master/docs/tutorial/fiveminutes.rst A master/docs/tutorial/further.rst M master/docs/tutorial/index.rst M master/setup.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/__init__.py A slave/buildslave/test/unit/test_scripts_runner.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'master' of https://github.com/buildbot/buildbot into p4_master_step_2012 Commit: 69e865c5ba9789f7e62420e60b5c13557fa1cc24 https://github.com/buildbot/buildbot/commit/69e865c5ba9789f7e62420e60b5c13557fa1cc24 Author: William Deegan Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: A master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer Commit: 4717b652f5ddfe50beaf051214c96ab84da0e96e https://github.com/buildbot/buildbot/commit/4717b652f5ddfe50beaf051214c96ab84da0e96e Author: William Deegan Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/process/properties.py M master/buildbot/steps/source/p4.py Log Message: ----------- Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer Commit: e4c2c364f13231289173567e34bf6571474f0053 https://github.com/buildbot/buildbot/commit/e4c2c364f13231289173567e34bf6571474f0053 Author: William Deegan Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- fixed merge conflict Commit: 160188ee1384f94fe40839fd4ee21353c5763cb5 https://github.com/buildbot/buildbot/commit/160188ee1384f94fe40839fd4ee21353c5763cb5 Author: William Deegan Date: 2013-03-22 (Fri, 22 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- improved validation logic in __init__, and added tests to cover this. Also address comment by jaredgrubb regarding clipped comment Commit: e84d29118308e7c45c90861a91aa7168565615d7 https://github.com/buildbot/buildbot/commit/e84d29118308e7c45c90861a91aa7168565615d7 Author: William Deegan Date: 2013-03-22 (Fri, 22 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Added test for incremental mode checkout Commit: 57f2d0d5c29b66d741e2d9f1ea3a390c0030866f https://github.com/buildbot/buildbot/commit/57f2d0d5c29b66d741e2d9f1ea3a390c0030866f Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Remove some code copied from SVN tests. Add comment to clarify purpose of setting property in setupStep Commit: 312a7e181e15fd7798152018155cf53eb9db50e4 https://github.com/buildbot/buildbot/commit/312a7e181e15fd7798152018155cf53eb9db50e4 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- added test for full checkout. Added _rmdir() method to P4 needed for full command. Commit: 637aa88872fc66235dacc444bca8a6781a33b2a6 https://github.com/buildbot/buildbot/commit/637aa88872fc66235dacc444bca8a6781a33b2a6 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- revised P4 step docs to match changes in code. Commit: 6756c8cfee0261f35943e2b958239be2bc8becb8 https://github.com/buildbot/buildbot/commit/6756c8cfee0261f35943e2b958239be2bc8becb8 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- fix pyflakes issues with new P4 and test code Commit: 0ada49ba81bf86e952c29d567d3bba3457118bd1 https://github.com/buildbot/buildbot/commit/0ada49ba81bf86e952c29d567d3bba3457118bd1 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Handle skipping some config checking if either p4base or p4branch is a renderanble Commit: 9db15b26599e797aa930af94816048fcea8f3942 https://github.com/buildbot/buildbot/commit/9db15b26599e797aa930af94816048fcea8f3942 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- removed extra tests copied from SVN's test. Reorganized tests to have simpler logic. Added tests for Renderable parameters Commit: f5f31c5a558635d48cba8584530061458cace9a1 https://github.com/buildbot/buildbot/commit/f5f31c5a558635d48cba8584530061458cace9a1 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- added test to check that specifying a revision works properly. Required setting the revision property on the mocked sourcestamp Commit: 48445b56f6d02d26f7f2780413f3f47d154a2740 https://github.com/buildbot/buildbot/commit/48445b56f6d02d26f7f2780413f3f47d154a2740 Author: William Deegan Date: 2013-03-27 (Wed, 27 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- address feedback on pull request by deleting logic no longer required in __init__ method of P4. Commit: 91b5b23199890aeae663657e1d6d2124fb43ee84 https://github.com/buildbot/buildbot/commit/91b5b23199890aeae663657e1d6d2124fb43ee84 Author: William Deegan Date: 2013-03-27 (Wed, 27 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Remove some commented out logic Commit: 74bac041deaf9784f7d8ff108888e928c6e2032d https://github.com/buildbot/buildbot/commit/74bac041deaf9784f7d8ff108888e928c6e2032d Author: William Deegan Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Move extra logging to be toggled by debug_logging variable. Migrate doc string to comment Commit: e037ca6e4a5d17d2c4d0bbfdf46540708165618a https://github.com/buildbot/buildbot/commit/e037ca6e4a5d17d2c4d0bbfdf46540708165618a Author: William Deegan Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- PEP8'd code. Addressed formatting issues minus some long lines Commit: c810644b3590ca5488491cc1861f8588ed273894 https://github.com/buildbot/buildbot/commit/c810644b3590ca5488491cc1861f8588ed273894 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- strip trailing whitespace Commit: e79fe1c6e7e475bfbae388e661a7f1d43b230c25 https://github.com/buildbot/buildbot/commit/e79fe1c6e7e475bfbae388e661a7f1d43b230c25 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- remove docstrings that are redundant to the real documentation Commit: 5d7e518970a26fdeb756c5a7694d3d947ec3d47b https://github.com/buildbot/buildbot/commit/5d7e518970a26fdeb756c5a7694d3d947ec3d47b Author: William Deegan Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- used textwrap.dedent() to get rid of long lines per pull feedback. Addressed djmitche's comments regarding full tests not having any variation in the expected generated clientspec by varying the parameters Commit: 89e73cec43b66da44197aa96a6ace757b6849104 https://github.com/buildbot/buildbot/commit/89e73cec43b66da44197aa96a6ace757b6849104 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/process/properties.py A master/buildbot/steps/source/p4.py A master/buildbot/test/unit/test_steps_source_p4.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Merge branch 'p4_master_step_2012' of git://github.com/bdbaddog/buildbot Commit: e0cf99d372eeb02439757e78ea4b3499b7f6426c https://github.com/buildbot/buildbot/commit/e0cf99d372eeb02439757e78ea4b3499b7f6426c Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- trivial whitespace, line-length fixups Commit: a8befb363661ca51275ff0260abb3af6c2577a82 https://github.com/buildbot/buildbot/commit/a8befb363661ca51275ff0260abb3af6c2577a82 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- add relnotes Compare: https://github.com/buildbot/buildbot/compare/c4f4cfad37ca...a8befb363661 From trac at buildbot.net Fri Apr 5 21:28:31 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 05 Apr 2013 21:28:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2320: P4Source: ignore PATH In-Reply-To: <039.26a5bd41c427c12d70ca4798f1916e8d@buildbot.net> References: <039.26a5bd41c427c12d70ca4798f1916e8d@buildbot.net> Message-ID: <054.5a4797ccaa230f5c9daf0bb4e7ab417d@buildbot.net> #2320: P4Source: ignore PATH -----------------------------+----------------------- Reporter: sanxiyn | Owner: bdbaddog Type: defect | Status: closed Priority: patches-accepted | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: fixed Keywords: p4 | -----------------------------+----------------------- Changes (by bdbaddog): * status: assigned => closed * resolution: => fixed Comment: Fixed checked and pull request sent: Change is: 17c00be0c01f48b4c3fd15c662c950d1189019f5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Apr 5 22:11:26 2013 From: noreply at github.com (GitHub) Date: Fri, 05 Apr 2013 15:11:26 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 17c00b: fix ticket 2320. P4Poller was not propagating the ... Message-ID: <515f4c0eacff6_a1982313879826@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 17c00be0c01f48b4c3fd15c662c950d1189019f5 https://github.com/buildbot/buildbot/commit/17c00be0c01f48b4c3fd15c662c950d1189019f5 Author: William Deegan Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/changes/p4poller.py Log Message: ----------- fix ticket 2320. P4Poller was not propagating the PATH from the user who starts the buildbot master. PATH has been added to the short list of environment variables propagated when calling p4 to get changes Commit: 2ff378fd82c18602ec4e8484ea351c5591588ba3 https://github.com/buildbot/buildbot/commit/2ff378fd82c18602ec4e8484ea351c5591588ba3 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/changes/p4poller.py Log Message: ----------- Merge branch 'ticket_2320_p4poller_path_issue' of git://github.com/bdbaddog/buildbot Compare: https://github.com/buildbot/buildbot/compare/a8befb363661...2ff378fd82c1 From noreply at github.com Sat Apr 6 16:03:18 2013 From: noreply at github.com (GitHub) Date: Sat, 06 Apr 2013 09:03:18 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4c0e8e: Combine two FakeBuild implementations into one Message-ID: <51604746c0d17_36a2e7f13067758@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4c0e8e2f3586c8843891d6a9523da71d01944956 https://github.com/buildbot/buildbot/commit/4c0e8e2f3586c8843891d6a9523da71d01944956 Author: Dustin J. Mitchell Date: 2013-04-06 (Sat, 06 Apr 2013) Changed paths: M master/buildbot/test/fake/fakebuild.py M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Combine two FakeBuild implementations into one From noreply at github.com Sun Apr 7 12:59:36 2013 From: noreply at github.com (GitHub) Date: Sun, 07 Apr 2013 05:59:36 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 91ff2b: buildslave: don't fork when '--nodaemon' flag is p... Message-ID: <51616db8c98ec_5e3f6c413497819@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 91ff2b3648fd4c3fcba84a3465aa252ff3cad7da https://github.com/buildbot/buildbot/commit/91ff2b3648fd4c3fcba84a3465aa252ff3cad7da Author: Andrew Gallagher Date: 2013-04-06 (Sat, 06 Apr 2013) Changed paths: M slave/buildslave/scripts/startup.py Log Message: ----------- buildslave: don't fork when '--nodaemon' flag is passed The '--nodaemon' flag was added in 2ae0ecb6347c2fd7b9301fe4dc3aaeebea235280 and efc3b6853ab7b03ba35de5820292a8bd7de96596 later fixed the build master to not fork when this flag was used. This commit applies roughly the same fix to the buildslave. Commit: 09d91e82961fb739bfaf2bff892fd46971e1f06b https://github.com/buildbot/buildbot/commit/09d91e82961fb739bfaf2bff892fd46971e1f06b Author: Dustin J. Mitchell Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/scripts/startup.py Log Message: ----------- Merge branch 'buildslave_noademon_fork' of git://github.com/andrewjcg/buildbot Commit: b885a23c24557567af95b2a96b6d91466c846814 https://github.com/buildbot/buildbot/commit/b885a23c24557567af95b2a96b6d91466c846814 Author: Dustin J. Mitchell Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- release notes Compare: https://github.com/buildbot/buildbot/compare/4c0e8e2f3586...b885a23c2455 From noreply at github.com Sun Apr 7 20:53:08 2013 From: noreply at github.com (GitHub) Date: Sun, 07 Apr 2013 13:53:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1ef73e: initial master side P4() source step Message-ID: <5161dcb4d8da5_1cd8fa413c467bf@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 1ef73eaff39effcda5ed2a76d3628ac2c40c52cc https://github.com/buildbot/buildbot/commit/1ef73eaff39effcda5ed2a76d3628ac2c40c52cc Author: William Deegan Date: 2012-12-23 (Sun, 23 Dec 2012) Changed paths: A master/buildbot/steps/source/p4.py Log Message: ----------- initial master side P4() source step Commit: e00cd0cf42d85cbf8ce9b81f849bd665d9edee0a https://github.com/buildbot/buildbot/commit/e00cd0cf42d85cbf8ce9b81f849bd665d9edee0a Author: William Deegan Date: 2012-12-26 (Wed, 26 Dec 2012) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- removed defaultBranch argument which has no purpose. Improved API docs. Added P4:.. prefixing on logging. Commit: eee944a003b58fdb9e039c35d4cec447a631211f https://github.com/buildbot/buildbot/commit/eee944a003b58fdb9e039c35d4cec447a631211f Author: William Deegan Date: 2012-12-26 (Wed, 26 Dec 2012) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- added docs for P4 master side source step Commit: f6696011982cdcff04d0d9294c507642dbabacf9 https://github.com/buildbot/buildbot/commit/f6696011982cdcff04d0d9294c507642dbabacf9 Author: William Deegan Date: 2013-01-05 (Sat, 05 Jan 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- address jaredgrubb's pull feedback Commit: 783768390bf4ef5814d8fb22839f461af737a123 https://github.com/buildbot/buildbot/commit/783768390bf4ef5814d8fb22839f461af737a123 Author: William Deegan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- remove possible_methods per pull request comment since it doesn't really apply to perforce Commit: 59424080de21601f35de7489a8ca657ebdca1792 https://github.com/buildbot/buildbot/commit/59424080de21601f35de7489a8ca657ebdca1792 Author: William Deegan Date: 2013-03-18 (Mon, 18 Mar 2013) Changed paths: M MAINTAINERS.txt M common/validate.sh M master/buildbot/__init__.py M master/buildbot/buildslave.py M master/buildbot/changes/hgpoller.py M master/buildbot/changes/svnpoller.py M master/buildbot/clients/gtkPanes.py M master/buildbot/clients/tryclient.py M master/buildbot/config.py M master/buildbot/db/buildrequests.py M master/buildbot/db/pool.py M master/buildbot/db/schedulers.py M master/buildbot/interfaces.py M master/buildbot/libvirtbuildslave.py M master/buildbot/locks.py M master/buildbot/manhole.py M master/buildbot/master.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/gatherResults.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/builder.py A master/buildbot/process/buildrequestdistributor.py M master/buildbot/process/buildstep.py M master/buildbot/process/metrics.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/forcesched.py M master/buildbot/scripts/runner.py M master/buildbot/scripts/stop.py M master/buildbot/scripts/user.py M master/buildbot/sourcestamp.py M master/buildbot/status/base.py M master/buildbot/status/buildrequest.py M master/buildbot/status/client.py M master/buildbot/status/logfile.py M master/buildbot/status/slave.py M master/buildbot/status/status_push.py M master/buildbot/status/web/authz.py M master/buildbot/status/web/baseweb.py M master/buildbot/status/web/build.py M master/buildbot/status/web/builder.py M master/buildbot/status/web/files/default.css M master/buildbot/status/web/grid.py M master/buildbot/status/web/logs.py M master/buildbot/status/web/slaves.py M master/buildbot/status/web/templates/build.html M master/buildbot/status/web/templates/builder.html M master/buildbot/status/web/templates/buildslave.html M master/buildbot/status/web/templates/buildslaves.html M master/buildbot/status/web/templates/forms.html M master/buildbot/status/web/templates/grid_macros.html M master/buildbot/status/web/templates/waterfallhelp.html M master/buildbot/status/words.py M master/buildbot/steps/package/deb/pbuilder.py M master/buildbot/steps/python_twisted.py M master/buildbot/steps/source/base.py M master/buildbot/steps/source/git.py M master/buildbot/steps/source/svn.py M master/buildbot/steps/transfer.py M master/buildbot/steps/vstudio.py M master/buildbot/test/fake/botmaster.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/fake/fakemaster.py M master/buildbot/test/integration/test_master.py M master/buildbot/test/integration/test_slave_comm.py M master/buildbot/test/unit/test_buildslave.py M master/buildbot/test/unit/test_changes_gitpoller.py M master/buildbot/test/unit/test_changes_hgpoller.py M master/buildbot/test/unit/test_config.py M master/buildbot/test/unit/test_db_buildrequests.py M master/buildbot/test/unit/test_master.py R master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_botmaster_DuplicateSlaveArbitrator.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_process_builder.py A master/buildbot/test/unit/test_process_buildrequestdistributor_BuildRequestDistributor.py M master/buildbot/test/unit/test_process_buildstep.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_forcesched.py M master/buildbot/test/unit/test_scripts_restart.py M master/buildbot/test/unit/test_scripts_runner.py M master/buildbot/test/unit/test_scripts_start.py M master/buildbot/test/unit/test_scripts_stop.py M master/buildbot/test/unit/test_sourcestamp.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAprAuth.py M master/buildbot/test/unit/test_status_web_auth_HTPasswdAuth.py M master/buildbot/test/unit/test_status_words.py M master/buildbot/test/unit/test_steps_master.py M master/buildbot/test/unit/test_steps_package_deb_pbuilder.py M master/buildbot/test/unit/test_steps_python_twisted.py M master/buildbot/test/unit/test_steps_source_bzr.py M master/buildbot/test/unit/test_steps_source_git.py M master/buildbot/test/unit/test_steps_source_repo.py M master/buildbot/test/unit/test_steps_source_svn.py M master/buildbot/test/unit/test_steps_trigger.py M master/buildbot/test/unit/test_steps_vstudio.py M master/buildbot/test/unit/test_util_misc.py M master/buildbot/test/util/steps.py M master/buildbot/util/maildir.py M master/contrib/bzr_buildbot.py M master/contrib/googlecode_atom.py M master/contrib/post_build_request.py M master/contrib/windows/buildbot_service.py M master/docs/developer/config.rst M master/docs/developer/database.rst M master/docs/developer/style.rst M master/docs/index.rst M master/docs/manual/cfg-builders.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-changesources.rst M master/docs/manual/cfg-properties.rst M master/docs/manual/cfg-schedulers.rst M master/docs/manual/cfg-statustargets.rst M master/docs/manual/cmdline.rst M master/docs/manual/concepts.rst M master/docs/manual/customization.rst M master/docs/relnotes/index.rst M master/docs/tutorial/firstrun.rst A master/docs/tutorial/fiveminutes.rst A master/docs/tutorial/further.rst M master/docs/tutorial/index.rst M master/setup.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/__init__.py A slave/buildslave/test/unit/test_scripts_runner.py M slave/contrib/windows/buildbot_service.py Log Message: ----------- Merge branch 'master' of https://github.com/buildbot/buildbot into p4_master_step_2012 Commit: 69e865c5ba9789f7e62420e60b5c13557fa1cc24 https://github.com/buildbot/buildbot/commit/69e865c5ba9789f7e62420e60b5c13557fa1cc24 Author: William Deegan Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: A master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer Commit: 4717b652f5ddfe50beaf051214c96ab84da0e96e https://github.com/buildbot/buildbot/commit/4717b652f5ddfe50beaf051214c96ab84da0e96e Author: William Deegan Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/process/properties.py M master/buildbot/steps/source/p4.py Log Message: ----------- Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer Commit: e4c2c364f13231289173567e34bf6571474f0053 https://github.com/buildbot/buildbot/commit/e4c2c364f13231289173567e34bf6571474f0053 Author: William Deegan Date: 2013-03-20 (Wed, 20 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- fixed merge conflict Commit: 160188ee1384f94fe40839fd4ee21353c5763cb5 https://github.com/buildbot/buildbot/commit/160188ee1384f94fe40839fd4ee21353c5763cb5 Author: William Deegan Date: 2013-03-22 (Fri, 22 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- improved validation logic in __init__, and added tests to cover this. Also address comment by jaredgrubb regarding clipped comment Commit: e84d29118308e7c45c90861a91aa7168565615d7 https://github.com/buildbot/buildbot/commit/e84d29118308e7c45c90861a91aa7168565615d7 Author: William Deegan Date: 2013-03-22 (Fri, 22 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Added test for incremental mode checkout Commit: 57f2d0d5c29b66d741e2d9f1ea3a390c0030866f https://github.com/buildbot/buildbot/commit/57f2d0d5c29b66d741e2d9f1ea3a390c0030866f Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- Remove some code copied from SVN tests. Add comment to clarify purpose of setting property in setupStep Commit: 312a7e181e15fd7798152018155cf53eb9db50e4 https://github.com/buildbot/buildbot/commit/312a7e181e15fd7798152018155cf53eb9db50e4 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- added test for full checkout. Added _rmdir() method to P4 needed for full command. Commit: 637aa88872fc66235dacc444bca8a6781a33b2a6 https://github.com/buildbot/buildbot/commit/637aa88872fc66235dacc444bca8a6781a33b2a6 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- revised P4 step docs to match changes in code. Commit: 6756c8cfee0261f35943e2b958239be2bc8becb8 https://github.com/buildbot/buildbot/commit/6756c8cfee0261f35943e2b958239be2bc8becb8 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- fix pyflakes issues with new P4 and test code Commit: 0ada49ba81bf86e952c29d567d3bba3457118bd1 https://github.com/buildbot/buildbot/commit/0ada49ba81bf86e952c29d567d3bba3457118bd1 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Handle skipping some config checking if either p4base or p4branch is a renderanble Commit: 9db15b26599e797aa930af94816048fcea8f3942 https://github.com/buildbot/buildbot/commit/9db15b26599e797aa930af94816048fcea8f3942 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- removed extra tests copied from SVN's test. Reorganized tests to have simpler logic. Added tests for Renderable parameters Commit: f5f31c5a558635d48cba8584530061458cace9a1 https://github.com/buildbot/buildbot/commit/f5f31c5a558635d48cba8584530061458cace9a1 Author: William Deegan Date: 2013-03-24 (Sun, 24 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- added test to check that specifying a revision works properly. Required setting the revision property on the mocked sourcestamp Commit: 48445b56f6d02d26f7f2780413f3f47d154a2740 https://github.com/buildbot/buildbot/commit/48445b56f6d02d26f7f2780413f3f47d154a2740 Author: William Deegan Date: 2013-03-27 (Wed, 27 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- address feedback on pull request by deleting logic no longer required in __init__ method of P4. Commit: 91b5b23199890aeae663657e1d6d2124fb43ee84 https://github.com/buildbot/buildbot/commit/91b5b23199890aeae663657e1d6d2124fb43ee84 Author: William Deegan Date: 2013-03-27 (Wed, 27 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Remove some commented out logic Commit: 74bac041deaf9784f7d8ff108888e928c6e2032d https://github.com/buildbot/buildbot/commit/74bac041deaf9784f7d8ff108888e928c6e2032d Author: William Deegan Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- Move extra logging to be toggled by debug_logging variable. Migrate doc string to comment Commit: e037ca6e4a5d17d2c4d0bbfdf46540708165618a https://github.com/buildbot/buildbot/commit/e037ca6e4a5d17d2c4d0bbfdf46540708165618a Author: William Deegan Date: 2013-03-31 (Sun, 31 Mar 2013) Changed paths: M master/buildbot/steps/source/p4.py M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- PEP8'd code. Addressed formatting issues minus some long lines Commit: 815519f2d10b7b7c495eec466b287aad15c44d8a https://github.com/buildbot/buildbot/commit/815519f2d10b7b7c495eec466b287aad15c44d8a Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- renamed SlaveOption class to CreateSlaveOption CreateSlaveOption is a more descriptive name, and follows the naming style of other subcommand's options classes. Commit: 7ced54fe5344bb877ec4d8ba654b3c6431974fd5 https://github.com/buildbot/buildbot/commit/7ced54fe5344bb877ec4d8ba654b3c6431974fd5 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/monkeypatches/__init__.py A slave/buildslave/monkeypatches/testcase_assert.py M slave/buildslave/test/__init__.py Log Message: ----------- add local assertRaisesRegexp() on python older then 2.7 When running tests on python older then 2.7, monkeypatch unittest.TestCase class to include assertRaisesRegexp() method. Commit: 24ba3ffd534a66c90b6441906be04368de475a8a https://github.com/buildbot/buildbot/commit/24ba3ffd534a66c90b6441906be04368de475a8a Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- catch invalid numeric parameters to 'buildslave create-slave' command When converting 'usepty', 'keepalive', 'maxdelay' and 'log-size' parameters to ints, catch ValueError exceptions and print error message. This way it is easier to troubleshoot incorrect parameters to create-slave command. Commit: 7ebed1efe42532982324ff6a6865eee41ade6ab4 https://github.com/buildbot/buildbot/commit/7ebed1efe42532982324ff6a6865eee41ade6ab4 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- accept exactly 4 arguments to 'buildslave create-slave' command Check that 'buildslave create-slave' command was invoked with exactly 4 arguments. Previously when create-slave was given more then 4 arguments, an 'ValueError: too many values to unpack' exception was raised. Commit: f19157bae5724c4decea254bfebbddf52610e856 https://github.com/buildbot/buildbot/commit/f19157bae5724c4decea254bfebbddf52610e856 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- added unit tests on CreateSlaveOptions class Test arguments parsing of valid 'buildslave create-slave' commands. Commit: 3ea680f22780bb45697fa46313dd536f726ced47 https://github.com/buildbot/buildbot/commit/3ea680f22780bb45697fa46313dd536f726ced47 Author: Elmir Jagudin Date: 2013-04-04 (Thu, 04 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- test ' not URL' error for 'buildslave create-slave' command Commit: c479cf2ba8138b323b6bbecf2aebfacee5a2c46d https://github.com/buildbot/buildbot/commit/c479cf2ba8138b323b6bbecf2aebfacee5a2c46d Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M slave/buildslave/monkeypatches/__init__.py A slave/buildslave/monkeypatches/testcase_assert.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/__init__.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'create-slave-cli-args' of git://github.com/elmirjagudin/buildbot Commit: c4f4cfad37cac9630e9f456b34296e78006d67c7 https://github.com/buildbot/buildbot/commit/c4f4cfad37cac9630e9f456b34296e78006d67c7 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/docs/relnotes/index.rst M slave/buildslave/monkeypatches/__init__.py Log Message: ----------- actually apply the bug5079 patch on the slave Fixes #1958. Commit: c810644b3590ca5488491cc1861f8588ed273894 https://github.com/buildbot/buildbot/commit/c810644b3590ca5488491cc1861f8588ed273894 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- strip trailing whitespace Commit: e79fe1c6e7e475bfbae388e661a7f1d43b230c25 https://github.com/buildbot/buildbot/commit/e79fe1c6e7e475bfbae388e661a7f1d43b230c25 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/steps/source/p4.py Log Message: ----------- remove docstrings that are redundant to the real documentation Commit: 5d7e518970a26fdeb756c5a7694d3d947ec3d47b https://github.com/buildbot/buildbot/commit/5d7e518970a26fdeb756c5a7694d3d947ec3d47b Author: William Deegan Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- used textwrap.dedent() to get rid of long lines per pull feedback. Addressed djmitche's comments regarding full tests not having any variation in the expected generated clientspec by varying the parameters Commit: 89e73cec43b66da44197aa96a6ace757b6849104 https://github.com/buildbot/buildbot/commit/89e73cec43b66da44197aa96a6ace757b6849104 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/process/properties.py A master/buildbot/steps/source/p4.py A master/buildbot/test/unit/test_steps_source_p4.py M master/docs/manual/cfg-buildsteps.rst Log Message: ----------- Merge branch 'p4_master_step_2012' of git://github.com/bdbaddog/buildbot Commit: e0cf99d372eeb02439757e78ea4b3499b7f6426c https://github.com/buildbot/buildbot/commit/e0cf99d372eeb02439757e78ea4b3499b7f6426c Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/test/unit/test_steps_source_p4.py Log Message: ----------- trivial whitespace, line-length fixups Commit: a8befb363661ca51275ff0260abb3af6c2577a82 https://github.com/buildbot/buildbot/commit/a8befb363661ca51275ff0260abb3af6c2577a82 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- add relnotes Commit: 17c00be0c01f48b4c3fd15c662c950d1189019f5 https://github.com/buildbot/buildbot/commit/17c00be0c01f48b4c3fd15c662c950d1189019f5 Author: William Deegan Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/changes/p4poller.py Log Message: ----------- fix ticket 2320. P4Poller was not propagating the PATH from the user who starts the buildbot master. PATH has been added to the short list of environment variables propagated when calling p4 to get changes Commit: 2ff378fd82c18602ec4e8484ea351c5591588ba3 https://github.com/buildbot/buildbot/commit/2ff378fd82c18602ec4e8484ea351c5591588ba3 Author: Dustin J. Mitchell Date: 2013-04-05 (Fri, 05 Apr 2013) Changed paths: M master/buildbot/changes/p4poller.py Log Message: ----------- Merge branch 'ticket_2320_p4poller_path_issue' of git://github.com/bdbaddog/buildbot Commit: 4c0e8e2f3586c8843891d6a9523da71d01944956 https://github.com/buildbot/buildbot/commit/4c0e8e2f3586c8843891d6a9523da71d01944956 Author: Dustin J. Mitchell Date: 2013-04-06 (Sat, 06 Apr 2013) Changed paths: M master/buildbot/test/fake/fakebuild.py M master/buildbot/test/unit/test_process_properties.py Log Message: ----------- Combine two FakeBuild implementations into one Commit: 91ff2b3648fd4c3fcba84a3465aa252ff3cad7da https://github.com/buildbot/buildbot/commit/91ff2b3648fd4c3fcba84a3465aa252ff3cad7da Author: Andrew Gallagher Date: 2013-04-06 (Sat, 06 Apr 2013) Changed paths: M slave/buildslave/scripts/startup.py Log Message: ----------- buildslave: don't fork when '--nodaemon' flag is passed The '--nodaemon' flag was added in 2ae0ecb6347c2fd7b9301fe4dc3aaeebea235280 and efc3b6853ab7b03ba35de5820292a8bd7de96596 later fixed the build master to not fork when this flag was used. This commit applies roughly the same fix to the buildslave. Commit: 09d91e82961fb739bfaf2bff892fd46971e1f06b https://github.com/buildbot/buildbot/commit/09d91e82961fb739bfaf2bff892fd46971e1f06b Author: Dustin J. Mitchell Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/scripts/startup.py Log Message: ----------- Merge branch 'buildslave_noademon_fork' of git://github.com/andrewjcg/buildbot Commit: b885a23c24557567af95b2a96b6d91466c846814 https://github.com/buildbot/buildbot/commit/b885a23c24557567af95b2a96b6d91466c846814 Author: Dustin J. Mitchell Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- release notes Commit: 87e6d73a33b829eb6db5e551656c0ec1c606cd2a https://github.com/buildbot/buildbot/commit/87e6d73a33b829eb6db5e551656c0ec1c606cd2a Author: Dustin J. Mitchell Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M master/buildbot/changes/p4poller.py M master/buildbot/process/properties.py A master/buildbot/steps/source/p4.py M master/buildbot/test/fake/fakebuild.py M master/buildbot/test/unit/test_process_properties.py A master/buildbot/test/unit/test_steps_source_p4.py M master/docs/manual/cfg-buildsteps.rst M master/docs/relnotes/index.rst M slave/buildslave/monkeypatches/__init__.py A slave/buildslave/monkeypatches/testcase_assert.py M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py M slave/buildslave/test/__init__.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- Merge branch 'master' into nine Compare: https://github.com/buildbot/buildbot/compare/51a86b05c9a0...87e6d73a33b8 From trac at buildbot.net Sun Apr 7 22:16:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 07 Apr 2013 22:16:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2410: ForceScheduler doesn't verify that its arguments are Parameter classes In-Reply-To: <042.745d0c4f864ede022ba617def63f5674@buildbot.net> References: <042.745d0c4f864ede022ba617def63f5674@buildbot.net> Message-ID: <057.adf0eefa6730bc5875e72cb4d3bf0c1b@buildbot.net> #2410: ForceScheduler doesn't verify that its arguments are Parameter classes -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: Keywords: force | -----------------------+-------------------- Comment (by ffledgling): For the current version of buildbot, the type checking is already in place. The ForceScheduler raises a ConfigError as expected for the input mentioned in #2231. Please refer to the attachment: http://trac.buildbot.net/attachment/ticket/2410/OutputOfForceScheduler.txt -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 8 13:51:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 08 Apr 2013 13:51:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2437: New Master-Slave Protocol In-Reply-To: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> References: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> Message-ID: <053.d401e87a5855ec54b77821effb36bb18@buildbot.net> #2437: New Master-Slave Protocol -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Comment (by marchael): test -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 8 14:56:27 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 08 Apr 2013 14:56:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly Message-ID: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly --------------------+------------------------ Reporter: jroo | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: gerrit git --------------------+------------------------ The implementation from buildbot.steps.sources.Git handles review changes from GerritChangeSource correctly but the new implementation from buildbot.steps.sources.git.Git does not. The following bits should be in master.cfg for reproducing the issue: {{{ from buildbot.changes.gerritchangesource import GerritChangeSource c[ 'change_source' ] = [ GerritChangeSource( gerritserver = 'gerrit.example.com', gerritport = 29418, username = 'gerrit-user', ), ] # .... c['schedulers'] = [ AnyBranchScheduler( name = 'all', change_filter = filter.ChangeFilter( project = 'MyProject' ), treeStableTimer = None, builderNames = [ 'Some Builder', ], ), ] # ... factory = BuildFactory() factory.addStep( Git( repourl = GitRepoUrl, mode = 'update', submodules = True, ) ) c[ 'builders' ] = [ BuilderConfig( name = 'Some Builder', slavenames = [ 'Slave', ], mergeRequests = False, factory = factory, ), ] }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 9 14:40:08 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 09 Apr 2013 14:40:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2437: New Master-Slave Protocol In-Reply-To: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> References: <038.a71aa733c82a4dfdff82e0bd81f69317@buildbot.net> Message-ID: <053.233113da767053661ea42bc133a673da@buildbot.net> #2437: New Master-Slave Protocol -------------------------+-------------------- Reporter: dustin | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.7p1 | Resolution: Keywords: | -------------------------+-------------------- Old description: > Buildbot currently uses Twisted Python's ''perspective broker'' to > communicate with slaves. This is a remote procedure call library that > operates on TCP connections, and has a few disadvantages: > * It is Python-only, so slaves must be implemented in Python > * It keeps the TCP connection open for many hours, and does not handle > connection failure well > * The RPC model is complex and does not map well to the operations > Buildbot performs > * The RPC implementation is inefficient and imposes some arbitrary > limits on Buildbot's flexibility. > > == Scope == > Here be dragons! Several people have attempted this before: > * http://src.chromium.org/viewvc/chrome/trunk/tools/slavelastic/ > (maruel) > * http://github.com/djmitche/remsh (djmitche) > either of these may be a great starting point for this project, but at > any rate this is a challenging project that will require a lot of > thoughtful design work. The current plan is to use [http://amp- > protocol.net amp] over > [http://twistedmatrix.com/documents/current/conch/index.html ssh] as the > default slave protocol. > > It's probably worth looking at off-the-shelf Message Queuing projects > like [http://www.zeromq.org/intro:read-the-manual zeromq], > [http://www.rabbitmq.com/tutorials/tutorial-six-python.html RabbitMQ] or > [http://ask.github.com/celery/getting-started/introduction.html Celery]. > > The best approach is to find a way to get some working code put together > quickly, while still allowing Buildbot to do everything its users expect. > For example, if you can write your new protocol such that Buildbot can > use perspective broker ''or'' your protocol, but you only get as far as a > simple slave that can run {{{echo hello world}}}, that's great! We can > ship that code, and someone else can pick up where you've left off to add > more capabilities to your protocol -- assuming your design does not make > that impossible. > > It would be great to select a communication protocol that is not Python- > specific, so that a non-Python slave could be used to run Buildbot on > more limited hardware (e.g., mobile devices). New description: Buildbot currently uses Twisted Python's ''perspective broker'' to communicate with slaves. This is a remote procedure call library that operates on TCP connections, and has a few disadvantages: * It is Python-only, so slaves must be implemented in Python * It keeps the TCP connection open for many hours, and does not handle connection failure well * The RPC model is complex and does not map well to the operations Buildbot performs * The RPC implementation is inefficient and imposes some arbitrary limits on Buildbot's flexibility. == Scope == Here be dragons! Several people have attempted this before: * http://src.chromium.org/viewvc/chrome/trunk/tools/slavelastic/ (maruel) * http://github.com/djmitche/remsh (djmitche) either of these may be a great starting point for this project, but at any rate this is a challenging project that will require a lot of thoughtful design work. The current plan is to use [http://amp-protocol.net amp] over [http://twistedmatrix.com/documents/current/conch/index.html ssh] as the default slave protocol. It's probably worth looking at off-the-shelf Message Queuing projects like [http://www.zeromq.org/intro:read-the-manual zeromq], [http://www.rabbitmq.com/tutorials/tutorial-six-python.html RabbitMQ] or [http://ask.github.com/celery/getting-started/introduction.html Celery]. The best approach is to find a way to get some working code put together quickly, while still allowing Buildbot to do everything its users expect. For example, if you can write your new protocol such that Buildbot can use perspective broker ''or'' your protocol, but you only get as far as a simple slave that can run {{{echo hello world}}}, that's great! We can ship that code, and someone else can pick up where you've left off to add more capabilities to your protocol -- assuming your design does not make that impossible. It would be great to select a communication protocol that is not Python- specific, so that a non-Python slave could be used to run Buildbot on more limited hardware (e.g., mobile devices). -- Comment (by dustin): You actually mention *four* protocols - AMP, SSH, JSON, and TCP. I'd like to focus on AMP over sockets (so, TCP or TLS) for Buildbot's default implementation, but write the specification and implementation in a generic fashion that could also be implemented with JSON-over-AMQP or XML- over-HTTP or YAML-over-email or whatever a user would like. So the choice of protocol isn't really the question to be focusing on up-front. Rather, let's describe a message-based interaction between master and slave that can then be implemented in one of several on-the-wire formats. In IRC, you asked {{{ 09:10 < marchael> for now we determined protocol for exchanging messages, but I still confused about how I should try to implement this without breaking existing perspective broker }}} and this is indeed a difficult question. In general, the approach should be: * maintain a PB implementation on the master side, but deprecate it * add a new AMP-based implementation on the master side, parallel to the PB implementation * replace the slave-side PB implementation with an AMP implementation The tricky bits will be in maintaining both the existing PB implementation (which has complex interactions with lots of classes on the master) and the AMP-based implementation (which should avoid much of that mess) in parallel. It's hard to say what that will look like without digging into the code. Tom, do you have some thoughts on that based on last year's work? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 11 17:31:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 11 Apr 2013 17:31:38 -0000 Subject: [Buildbot-commits] [Buildbot] #978: Changes should have multiple users In-Reply-To: <041.98f857cbb54e3c6c85643e2bff7f4435@buildbot.net> References: <041.98f857cbb54e3c6c85643e2bff7f4435@buildbot.net> Message-ID: <056.39990350bcf2225ea90af05724190f69@buildbot.net> #978: Changes should have multiple users -----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: git, users | -----------------------+-------------------- Changes (by mikesorrenti): * cc: msorrenti@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 11 17:40:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 11 Apr 2013 17:40:37 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.92f8051ce95f2ac46085bc089e4c1e4b@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Changes (by mikesorrenti): * cc: msorrenti@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 11 18:10:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 11 Apr 2013 18:10:30 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.a9eedf963cedf10b08a8e2acaf99173e@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Comment (by jachen): True. I wanted to use the try scheduler. But, seemed a lot of work for developers to set up, etc. Also not into setting up a bunch of user name/passwords to maintain this. Would prefer a loose general password for this type of stuff. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 11 18:10:33 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 11 Apr 2013 18:10:33 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.3360d5d8b7604852683270526f35cce2@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Comment (by jachen): True. I wanted to use the try scheduler. But, seemed a lot of work for developers to set up, etc. Also not into setting up a bunch of user name/passwords to maintain this. Would prefer a loose general password for this type of stuff. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 11 23:53:27 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 11 Apr 2013 23:53:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2410: ForceScheduler doesn't verify that its arguments are Parameter classes In-Reply-To: <042.745d0c4f864ede022ba617def63f5674@buildbot.net> References: <042.745d0c4f864ede022ba617def63f5674@buildbot.net> Message-ID: <057.eb88f2f1091152924237cc2801bc9499@buildbot.net> #2410: ForceScheduler doesn't verify that its arguments are Parameter classes -----------------------+--------------------- Reporter: tom.prince | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Resolution: fixed Keywords: force | -----------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: {{{ commit f93061ec70b09750ad5ee5d20669af838753fc43 Merge: 149c535 356bd4c Author: Dustin J. Mitchell Date: Mon Jan 28 19:10:41 2013 -0500 Merge branch 'ticket_2231' of git://github.com/ewongbb/buildbot }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 12 01:07:01 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 12 Apr 2013 01:07:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.276e05abb54f6f2c35d65064556cd392@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+-------------------- Reporter: jroo | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: gerrit git master-side-source-steps | ------------------------------------------------+-------------------- Changes (by dustin): * keywords: gerrit git => gerrit git master-side-source-steps * milestone: undecided => 0.8.+ Comment: There's some code to handle gerrit-specific properties in oldsource.py {{{ def startVC(self, branch, revision, patch): self.args['branch'] = branch self.args['repourl'] = self.repourl self.args['revision'] = revision self.args['patch'] = patch # check if there is any patchset we should fetch from Gerrit if self.build.hasProperty("event.patchSet.ref"): # GerritChangeSource self.args['gerrit_branch'] = self.build.getProperty("event.patchSet.ref") self.updateSourceProperty("gerrit_branch", self.args['gerrit_branch']) else: try: # forced build change = self.build.getProperty("gerrit_change", '').split('/') if len(change) == 2: self.args['gerrit_branch'] = "refs/changes/%2.2d/%d/%d" \ % (int(change[0]) % 100, int(change[0]), int(change[1])) self.updateSourceProperty("gerrit_branch", self.args['gerrit_branch']) except: pass }}} I'm not sure what the advantage is of supporting this in the Git step rather than the Gerrit step. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Apr 12 01:17:58 2013 From: noreply at github.com (GitHub) Date: Thu, 11 Apr 2013 18:17:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a24972: removed unused feature in buildslave.scripts.runne... Message-ID: <516760c6366bc_50ff56b13496f7@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a24972f01562164a5bb6c1fec887b8cfa9076182 https://github.com/buildbot/buildbot/commit/a24972f01562164a5bb6c1fec887b8cfa9076182 Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- removed unused feature in buildslave.scripts.runner.stop() No code calls stop() with wait flag disabled. Remove wait parameter, and changed stop() to always wait for the process to finish. Commit: 10dceeb46689cc59986d8fa6e8b12d37bf06a2b8 https://github.com/buildbot/buildbot/commit/10dceeb46689cc59986d8fa6e8b12d37bf06a2b8 Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/test/util/misc.py Log Message: ----------- copy StdoutAssertionsMixin class to slave test util package Commit: d22a54d17a6f4fea44b96d908c45668c296b8a77 https://github.com/buildbot/buildbot/commit/d22a54d17a6f4fea44b96d908c45668c296b8a77 Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/util/misc.py Log Message: ----------- tests: broke out open() patching code to a mix in class Created buildslave.test.util.misc.OpenFileMixin class with methods for patching open() to simulate successful reads and I/O errors. Commit: c7da46f05c0e282aaa59666dfa32325e27a9db4f https://github.com/buildbot/buildbot/commit/c7da46f05c0e282aaa59666dfa32325e27a9db4f Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- fixed incorrectly printed message on 'buildslave restart' Don't print 'no old buildslave process found to stop' when old slave process was successfully terminated. Previously stop() returned 'None' when slave was successfully stoped. To restart() it looked like we failed to stop the slave. Broke out the code to stop slave into a new stopSlave() utility function, which will raise an exception if no slave is running. Use stopSlave() from stop() and restart(), handle the exception as appropriate for each case. Commit: eb51c2766d96e7921347260d88608f44409af2ef https://github.com/buildbot/buildbot/commit/eb51c2766d96e7921347260d88608f44409af2ef Author: Dustin J. Mitchell Date: 2013-04-11 (Thu, 11 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/util/misc.py Log Message: ----------- Merge branch 'slave-restart-msg' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/b885a23c2455...eb51c2766d96 From noreply at github.com Fri Apr 12 16:05:01 2013 From: noreply at github.com (GitHub) Date: Fri, 12 Apr 2013 09:05:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <516830ad92767_3d129c813c217b6@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot From trac at buildbot.net Fri Apr 12 16:42:19 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 12 Apr 2013 16:42:19 -0000 Subject: [Buildbot-commits] [Buildbot] #77: Better way for python to kill subprocesses on win32? In-Reply-To: <039.d1705b33e5cd83225dd65bafca80d5f3@buildbot.net> References: <039.d1705b33e5cd83225dd65bafca80d5f3@buildbot.net> Message-ID: <054.9c061963bf898767b1bfc4748a5e6066@buildbot.net> #77: Better way for python to kill subprocesses on win32? --------------------------+----------------------- Reporter: joduinn | Owner: warner Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows, kill | --------------------------+----------------------- Changes (by dustin): * keywords: => windows, kill Old description: > From offline discussions, seems that there might be a better way to kill > subprocesses when running on win32. Details are at: > http://benjamin.smedbergs.us/blog/2006-12-11/killableprocesspy/ > > Source code available at: SVN: http://svn.smedbergs.us/python- > processes/trunk/ New description: From offline discussions, seems that there might be a better way to kill subprocesses when running on win32. Details are at: http://benjamin.smedbergs.us/blog/2006-12-11/killableprocesspy/ Source code available at: SVN: http://svn.smedbergs.us/python- processes/trunk/ -- -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 12 16:45:05 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 12 Apr 2013 16:45:05 -0000 Subject: [Buildbot-commits] [Buildbot] #77: Better way for python to kill subprocesses on win32? In-Reply-To: <039.d1705b33e5cd83225dd65bafca80d5f3@buildbot.net> References: <039.d1705b33e5cd83225dd65bafca80d5f3@buildbot.net> Message-ID: <054.25007e608eb7919adabce6f9c29479d7@buildbot.net> #77: Better way for python to kill subprocesses on win32? --------------------------+----------------------- Reporter: joduinn | Owner: warner Type: defect | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.8.5 | Resolution: Keywords: windows, kill | --------------------------+----------------------- Comment (by tom.prince): This seems like something that it would be worthwhile addressing upstream in twisted (and then monkey-patching the fix in buildbot) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 12 20:38:44 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 12 Apr 2013 20:38:44 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Replace try with a client for the force scheduler In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.74b5b008cd3162aa7836a70754da60cb@buildbot.net> #896: Replace try with a client for the force scheduler ------------------------------+-------------------- Reporter: marcusl | Owner: Type: project-idea | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.0 | Resolution: Keywords: try, users, force | ------------------------------+-------------------- Changes (by ffledgling): * cc: ffledgling@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 12 21:17:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 12 Apr 2013 21:17:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2486: Property() is not rendered in {halt, flunk}OnFailure build step arguments Message-ID: <045.e914ef329b0348b8fdb7a042729e0643@buildbot.net> #2486: Property() is not rendered in {halt,flunk}OnFailure build step arguments --------------------------+----------------------- Reporter: seb_kuzminsky | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Keywords: --------------------------+----------------------- The issue was discussed in #buildbot on 2013-04-12 around 19:45 UTC. djmitche came up with this simple workaround. When inserted into master.cfg, it makes my config work: shell.Configure.renderables.extend(['haltOnFailure', 'flunkOnFailure']) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sat Apr 13 13:54:57 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 13 Apr 2013 13:54:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2486: Property() is not rendered in {halt, flunk}OnFailure build step arguments In-Reply-To: <045.e914ef329b0348b8fdb7a042729e0643@buildbot.net> References: <045.e914ef329b0348b8fdb7a042729e0643@buildbot.net> Message-ID: <060.051c747ce71a4fdc9c87b41391e24a9c@buildbot.net> #2486: Property() is not rendered in {halt,flunk}OnFailure build step arguments --------------------------+-------------------- Reporter: seb_kuzminsky | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: simple | --------------------------+-------------------- Changes (by dustin): * keywords: => simple * type: undecided => defect * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Apr 14 15:25:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 14 Apr 2013 15:25:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.ef5919cc0ac9e21bc84620dc7bfacd55@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+-------------------- Reporter: jroo | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: gerrit git master-side-source-steps | ------------------------------------------------+-------------------- Comment (by jroo): In my use case it does not matter if Git and Gerrit source steps are implemented in different classes. For some it might; someone could have GitPoller and GerritChangeSource objects as change source and if the source fetch steps would be in different classes the build steps would be required to be different depending on the source of the change. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Apr 14 17:02:57 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 14 Apr 2013 17:02:57 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.b5e2bb41b7706d1c70b09ec1e52246c3@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+-------------------- Reporter: jroo | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: gerrit git master-side-source-steps | ------------------------------------------------+-------------------- Comment (by dustin): Right, my point is just that you wouldn't expect a !GitPoller and an SVN step to work together, so I'm not sure why !GerritChangeSource and Git should work together, rather than !GerritChangeSource and Repo, or a new Gerrit class (that may be a subclass of Git). I'm really just looking for the most appropriate design. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Apr 14 22:06:39 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 14 Apr 2013 22:06:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2487: Hardcoded Number of Changes on Console Page Message-ID: <037.8abb8e904523dded544c82fb3d2a0d8b@buildbot.net> #2487: Hardcoded Number of Changes on Console Page ------------------------+----------------------- Reporter: jpihl | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: console ------------------------+----------------------- The number of changes retrieved on the console page is hardcoded to 25 (line 170 in console.py). This is especially a problem when having many different projects and the console page is specified to only to show the changes of a single project. In this case only few or possibly no changes will be shown, as the 25 newest changes may have been related to other projects. A fix could be to get the number as a get value. It would also be nice if master.db.changes.getRecentChanges could pick the newest changes from a specified project, instead of all global changes. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Apr 14 22:14:54 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 14 Apr 2013 22:14:54 -0000 Subject: [Buildbot-commits] [Buildbot] #2487: Hardcoded Number of Changes on Console Page In-Reply-To: <037.8abb8e904523dded544c82fb3d2a0d8b@buildbot.net> References: <037.8abb8e904523dded544c82fb3d2a0d8b@buildbot.net> Message-ID: <052.b920c00964931e2588e319650508979b@buildbot.net> #2487: Hardcoded Number of Changes on Console Page ------------------------+-------------------- Reporter: jpihl | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * keywords: console => web * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Apr 15 12:27:58 2013 From: noreply at github.com (GitHub) Date: Mon, 15 Apr 2013 05:27:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 004bfe: Monkey patch in synchronous test helpers. Message-ID: <516bf24eb1ea6_2be2b1f13451246@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 004bfebd0a5c31f7066042176ee072fe9903d0ed https://github.com/buildbot/buildbot/commit/004bfebd0a5c31f7066042176ee072fe9903d0ed Author: Tom Prince Date: 2013-04-13 (Sat, 13 Apr 2013) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/testcase_synctest.py Log Message: ----------- Monkey patch in synchronous test helpers. These methods make it easy to test code involving deferreds in a synchronous and deterministic manner, rather than having to spin the reactor. Commit: 7e68b03aa8f57627e72e38101075163a98774b49 https://github.com/buildbot/buildbot/commit/7e68b03aa8f57627e72e38101075163a98774b49 Author: Dustin J. Mitchell Date: 2013-04-14 (Sun, 14 Apr 2013) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/testcase_synctest.py Log Message: ----------- Merge branch 'sync-test-helpers' of git://github.com/tomprince/buildbot Commit: f7dd314430c3d6b3b61336386b32bb9895a431d7 https://github.com/buildbot/buildbot/commit/f7dd314430c3d6b3b61336386b32bb9895a431d7 Author: Sleft Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Fixed grep command for IRC in log With grep IRC there is not output from cat on the log file but with grep -i irc there is, see e.g. ``` $ cat master/twistd.log | grep IRC $ cat master/twistd.log | grep -i irc 2013-04-15 13:26:44+0200 [-] Starting factory 2013-04-15 13:26:58+0200 [IrcStatusBot,client] : I have joined #buildbot-test 2013-04-15 13:27:29+0200 [-] Starting factory 2013-04-15 13:27:29+0200 [IrcStatusBot,client] not scheduling reconnection attempt 2013-04-15 13:27:29+0200 [IrcStatusBot,client] Stopping factory 2013-04-15 13:27:42+0200 [IrcStatusBot,client] : I have joined #buildbot-test ``` Thus, maybe the example line from the log should be changed too? I use Buildbot version: 0.8.6p1 Twisted version: 12.2.0 Commit: e3d3e8e18da8f234a5779b4e93b891ea066756ce https://github.com/buildbot/buildbot/commit/e3d3e8e18da8f234a5779b4e93b891ea066756ce Author: Dustin J. Mitchell Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Merge branch 'master' of git://github.com/Sleft/buildbot Compare: https://github.com/buildbot/buildbot/compare/eb51c2766d96...e3d3e8e18da8 From noreply at github.com Mon Apr 15 12:36:31 2013 From: noreply at github.com (GitHub) Date: Mon, 15 Apr 2013 05:36:31 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d00f6a: fix typo in gh-pull 693 Message-ID: <516bf44f21f1a_787572213084076@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d00f6a9819b4a43b77db294e5ebbc5bfa70d8f6a https://github.com/buildbot/buildbot/commit/d00f6a9819b4a43b77db294e5ebbc5bfa70d8f6a Author: Dustin J. Mitchell Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/buildbot/monkeypatches/__init__.py Log Message: ----------- fix typo in gh-pull 693 From noreply at github.com Mon Apr 15 13:35:08 2013 From: noreply at github.com (GitHub) Date: Mon, 15 Apr 2013 06:35:08 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c20760: Fixed inline code and command formatting Message-ID: <516c020c3ef5e_41f051412c3401d@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c2076072314d7d9aeaed5900ccd9389f43cce9ba https://github.com/buildbot/buildbot/commit/c2076072314d7d9aeaed5900ccd9389f43cce9ba Author: Sleft Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Fixed inline code and command formatting Inline code and command formatting should be consistent and clear. Commit: 68c08eded0226d00f5c05ff326d55263f33c5edc https://github.com/buildbot/buildbot/commit/68c08eded0226d00f5c05ff326d55263f33c5edc Author: Dustin J. Mitchell Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Merge pull request #695 from Sleft/master Fixed inline code and command formatting Compare: https://github.com/buildbot/buildbot/compare/d00f6a9819b4...68c08eded022 From trac at buildbot.net Tue Apr 16 08:53:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 08:53:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2488: The tutorial and the manual seems to recommend different ways of installing Message-ID: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> #2488: The tutorial and the manual seems to recommend different ways of installing --------------------+----------------------- Reporter: Sleft | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: docs --------------------+----------------------- [http://docs.buildbot.net/current/tutorial/firstrun.html#getting-the-code The tutorial] says (The preferred method would be to install buildbot from packages of your distribution.) [http://docs.buildbot.net/current/manual/installation.html#installing-the- code The manual] does not say anything about preferred method but it says The easiest way to install Buildbot is using 'pip'. which seems to imply that using 'pip' is the preferred way. So which way is it? Should the documents be changed so that they do not seem contradictory? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 12:19:56 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 12:19:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2488: The tutorial and the manual seems to recommend different ways of installing In-Reply-To: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> References: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> Message-ID: <052.0048ace789f72a75623c350de004e935@buildbot.net> #2488: The tutorial and the manual seems to recommend different ways of installing --------------------+------------------------ Reporter: Sleft | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: docs | --------------------+------------------------ Comment (by dustin): The tutorial is trying to find the simplest way, and generally 'apt-get install' or 'port install' or the like is the easiest way. The manual, on the other hand, is looking for the most general way, and that's pip -- it allows you to upgrade or downgrade (or stay put) easily, without waiting for downstream packages. The manual should probably *also* mention using packages, but include a warning about version lag and possible difficulty upgrading. Do you want to make a patch for that? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 12:45:04 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 12:45:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2488: The tutorial and the manual seems to recommend different ways of installing In-Reply-To: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> References: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> Message-ID: <052.263d6163fe092f43b862edf36b99367d@buildbot.net> #2488: The tutorial and the manual seems to recommend different ways of installing --------------------+------------------------ Reporter: Sleft | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: docs | --------------------+------------------------ Comment (by Sleft): As I sent patches via github before I guess that is the correct way to proceed here too, right? I have added patches for this - https://github.com/Sleft/buildbot/commit/6bef3b75a25b6b9d77caeae48aad3e32f0181664 - https://github.com/Sleft/buildbot/commit/b5329b58fde24ef0d5a0603baa188e98eb192e82 to a pending pull request of mine. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 13:08:38 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 13:08:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.b84c8ac5f7ec42b02359b55f425a13b8@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+-------------------- Reporter: jroo | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: gerrit git master-side-source-steps | ------------------------------------------------+-------------------- Comment (by jroo): But Gerrit implements Git repository so you might expect Git and Gerrit to work together. In my opinion it would be good solution to just inherit the gerrit step from git step if not implement both of those in single class; after all Gerrit is a Git repository + something else. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 20:22:41 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 20:22:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2489: Events getting repeatedly pushed via httpstatus Message-ID: <038.4139e215307e9432e005224ce44dc8dd@buildbot.net> #2489: Events getting repeatedly pushed via httpstatus ----------------------+----------------------- Reporter: jachen | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- I've recently upgraded from 0.8.5 to 0.8.7p1. I have a campfire status push which basically inherits from http status underneath, with some minor changes. I noticed 'Unhanded error' in twistd.log. Referring to http://trac.buildbot.net/ticket/2450 I manually added the patch. Now the error is gone. However, I am still seeing events get pushed repeatedly, which didn't happen before the upgrade. Below is a snippet of twistd.log, showing a build is finished. A build event is supposed to get pushed to a couple of campfire rooms. Instead, it gets pushed multiple times. 2013-04-16 12:35:21-0700 [-] : build finished 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584-log-git-stdio.bz2' 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584-log-tar-stdio.bz2' 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584' 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584-log-tar-interrupt' 2013-04-16 12:35:21-0700 [-] setting expectations for next time 2013-04-16 12:35:21-0700 [-] new expectations: 1303.23785007 seconds 2013-04-16 12:35:21-0700 [-] releaseLocks(): [] 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [-] Starting factory 2013-04-16 12:35:22-0700 [-] Starting factory 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 21:10:32 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 21:10:32 -0000 Subject: [Buildbot-commits] [Buildbot] #2490: Scheduler build clones head instead of revision from previous build in multi-repo setup Message-ID: <041.56591301e381fe539b2ed88c74608227@buildbot.net> #2490: Scheduler build clones head instead of revision from previous build in multi-repo setup ----------------------+------------------------ Reporter: thedylman | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.8 Version: 0.8.7p1 | Keywords: schedulers ----------------------+------------------------ The setup is: Builder Y with mercurial repos A and B. SingleBranchScheduler with codebases for A and B. The steps: Commit with id 5 to repo A. After treeStableTimer finishes build is queued on builder Y and waiting for slave. Commit with id 3 to repo B. Builder Y starts build/clone step with change for repo A and head for repo B. The problem is repo B is updating to head because revision id is set to None. Instead it should update to the revision id 2 from the previous build on builder Y. In a single repo setup the sourcestamp always has a change so it updates to the revision id of that change. For a multirepo setup only repos with changes have the revision field set, so all other repos are updated to head which then includes changes that are not listed in the sourcestamps. The effects of this is the web interface and emails do not show the correct changes and users for a build. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 23:51:20 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 23:51:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2488: The tutorial and the manual seems to recommend different ways of installing In-Reply-To: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> References: <037.9fb94b22d347a38cbad10f4d300c68ef@buildbot.net> Message-ID: <052.547c9c80dd38661181832e26b78780e7@buildbot.net> #2488: The tutorial and the manual seems to recommend different ways of installing --------------------+------------------------ Reporter: Sleft | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: fixed Keywords: docs | --------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Thanks - merging it now -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 16 23:56:53 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 16 Apr 2013 23:56:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly In-Reply-To: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> References: <036.7c8117f0bcab921ee9381f0956870715@buildbot.net> Message-ID: <051.972702f2fec4a3ab353d183d4621a367@buildbot.net> #2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource Correctly ------------------------------------------------+-------------------- Reporter: jroo | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: gerrit git master-side-source-steps | ------------------------------------------------+-------------------- Comment (by dustin): Fair enough. I'd prefer to see this as a subclass, when it gets implemented. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Apr 17 00:08:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 17 Apr 2013 00:08:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2489: Events getting repeatedly pushed via httpstatus In-Reply-To: <038.4139e215307e9432e005224ce44dc8dd@buildbot.net> References: <038.4139e215307e9432e005224ce44dc8dd@buildbot.net> Message-ID: <053.6dce9fffdefd73ca93667c24d5a80a0c@buildbot.net> #2489: Events getting repeatedly pushed via httpstatus --------------------+-------------------- Reporter: jachen | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.+ Old description: > I've recently upgraded from 0.8.5 to 0.8.7p1. > > I have a campfire status push which basically inherits from http status > underneath, with some minor changes. > > I noticed 'Unhanded error' in twistd.log. > Referring to > http://trac.buildbot.net/ticket/2450 > > I manually added the patch. Now the error is gone. > > However, I am still seeing events get pushed repeatedly, which didn't > happen before the upgrade. > > Below is a snippet of twistd.log, showing a build is finished. A build > event is supposed to get pushed to a couple of campfire rooms. Instead, > it gets pushed multiple times. > > 2013-04-16 12:35:21-0700 [-] : build finished > 2013-04-16 12:35:21-0700 [-] Starting factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:21-0700 [-] Starting factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- > runner/bbot/master/coi_buildout/584-log-git-stdio.bz2' > 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- > runner/bbot/master/coi_buildout/584-log-tar-stdio.bz2' > 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- > runner/bbot/master/coi_buildout/584' > 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- > runner/bbot/master/coi_buildout/584-log-tar-interrupt' > 2013-04-16 12:35:21-0700 [-] setting expectations for next time > 2013-04-16 12:35:21-0700 [-] new expectations: 1303.23785007 seconds > 2013-04-16 12:35:21-0700 [-] releaseLocks( 0x2c54a50>): [] > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://nimbusproject.campfirenow.com/room/387760/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://nimbusproject.campfirenow.com/room/387760/speak.json>2013-04-16 > 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 > events to https://ooici.campfirenow.com/room/449376/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://nimbusproject.campfirenow.com/room/387760/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://ooici.campfirenow.com/room/449376/speak.json2013-04-16 > 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping > factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://nimbusproject.campfirenow.com/room/387760/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://nimbusproject.campfirenow.com/room/387760/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://nimbusproject.campfirenow.com/room/387760/speak.json>2013-04-16 > 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 > events to https://nimbusproject.campfirenow.com/room/387760/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://ooici.campfirenow.com/room/449376/speak.json2013-04-16 > 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping > factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json > 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://ooici.campfirenow.com/room/449376/speak.json>2013-04-16 > 12:35:22-0700 [-] Starting factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:22-0700 [-] Starting factory https://nimbusproject.campfirenow.com/room/387760/speak.json> > 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json > 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://ooici.campfirenow.com/room/449376/speak.json> > 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Sent 1 events to > https://nimbusproject.campfirenow.com/room/387760/speak.json > 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] > Stopping factory https://nimbusproject.campfirenow.com/room/387760/speak.json> New description: I've recently upgraded from 0.8.5 to 0.8.7p1. I have a campfire status push which basically inherits from http status underneath, with some minor changes. I noticed 'Unhanded error' in twistd.log. Referring to http://trac.buildbot.net/ticket/2450 I manually added the patch. Now the error is gone. However, I am still seeing events get pushed repeatedly, which didn't happen before the upgrade. Below is a snippet of twistd.log, showing a build is finished. A build event is supposed to get pushed to a couple of campfire rooms. Instead, it gets pushed multiple times. {{{ 2013-04-16 12:35:21-0700 [-] : build finished 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] Starting factory 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584-log-git-stdio.bz2' 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584-log-tar-stdio.bz2' 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584' 2013-04-16 12:35:21-0700 [-] pruning '/home/buildbot- runner/bbot/master/coi_buildout/584-log-tar-interrupt' 2013-04-16 12:35:21-0700 [-] setting expectations for next time 2013-04-16 12:35:21-0700 [-] new expectations: 1303.23785007 seconds 2013-04-16 12:35:21-0700 [-] releaseLocks(): [] 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:22-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:22-0700 [-] Starting factory 2013-04-16 12:35:22-0700 [-] Starting factory 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://ooici.campfirenow.com/room/449376/speak.json 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Sent 1 events to https://nimbusproject.campfirenow.com/room/387760/speak.json 2013-04-16 12:35:23-0700 [HTTPPageGetter (TLSMemoryBIOProtocol),client] Stopping factory }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Apr 17 00:11:45 2013 From: noreply at github.com (GitHub) Date: Tue, 16 Apr 2013 17:11:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a3d2fc: Fixed phrasing and formatted commands and code as ... Message-ID: <516de8c182032_479dfd7e104377b@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a3d2fcad22c5fc106f49a4914409d41a22aa8c47 https://github.com/buildbot/buildbot/commit/a3d2fcad22c5fc106f49a4914409d41a22aa8c47 Author: Sleft Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/firstrun.rst Log Message: ----------- Fixed phrasing and formatted commands and code as such Commit: a21c7984991204731f3c4835d30cba41a16982d8 https://github.com/buildbot/buildbot/commit/a21c7984991204731f3c4835d30cba41a16982d8 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/tutorial/fiveminutes.rst Log Message: ----------- Fixed inline code and command formatting Commit: b5329b58fde24ef0d5a0603baa188e98eb192e82 https://github.com/buildbot/buildbot/commit/b5329b58fde24ef0d5a0603baa188e98eb192e82 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- Note and warning about distribution specific package managers Commit: 6bef3b75a25b6b9d77caeae48aad3e32f0181664 https://github.com/buildbot/buildbot/commit/6bef3b75a25b6b9d77caeae48aad3e32f0181664 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/tutorial/firstrun.rst Log Message: ----------- Preferred way to install is via pip To be consistent with the manual Commit: 113582fca6ab5af2ca61df1a7b08de1a414fef43 https://github.com/buildbot/buildbot/commit/113582fca6ab5af2ca61df1a7b08de1a414fef43 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- Less repetetive when using synonym Also fixed command formatting Commit: 83bc2954aebdc532608fa59a8894fedacef9119b https://github.com/buildbot/buildbot/commit/83bc2954aebdc532608fa59a8894fedacef9119b Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/concepts.rst Log Message: ----------- Fixed link Commit: e31048a402018fe5d108c13f27db316785c69d1d https://github.com/buildbot/buildbot/commit/e31048a402018fe5d108c13f27db316785c69d1d Author: Dustin J. Mitchell Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/concepts.rst M master/docs/manual/installation.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst Log Message: ----------- Merge branch 'master' of git://github.com/Sleft/buildbot Commit: 0946659b0fd776ba5b5a0b464b086fcfbc47ba4e https://github.com/buildbot/buildbot/commit/0946659b0fd776ba5b5a0b464b086fcfbc47ba4e Author: Dustin J. Mitchell Date: 2013-04-16 (Tue, 16 Apr 2013) Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot Compare: https://github.com/buildbot/buildbot/compare/68c08eded022...0946659b0fd7 From trac at buildbot.net Wed Apr 17 00:24:53 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 17 Apr 2013 00:24:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2490: scheduler that remembers last-seen revisions for each codebase (was: Scheduler build clones head instead of revision from previous build in multi-repo setup) In-Reply-To: <041.56591301e381fe539b2ed88c74608227@buildbot.net> References: <041.56591301e381fe539b2ed88c74608227@buildbot.net> Message-ID: <056.551ececb04d13f7a190401b7e4239df7@buildbot.net> #2490: scheduler that remembers last-seen revisions for each codebase ------------------------+-------------------- Reporter: thedylman | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * keywords: schedulers => * type: defect => enhancement * milestone: 0.8.8 => 0.8.+ Comment: The !SingleBranchScheduler doesn't support this behavior. It can either use the latest revision or, by customizing the `codebases` parameter, fix a revision, branch, etc. It might be nice for a *different* scheduler to support this kind of "remember the last revision I saw" behavior. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Apr 17 09:07:55 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 17 Apr 2013 09:07:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2490: scheduler that remembers last-seen revisions for each codebase In-Reply-To: <041.56591301e381fe539b2ed88c74608227@buildbot.net> References: <041.56591301e381fe539b2ed88c74608227@buildbot.net> Message-ID: <056.29be8f7b4fd57d3b424616ee159accb5@buildbot.net> #2490: scheduler that remembers last-seen revisions for each codebase ------------------------+-------------------- Reporter: thedylman | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by Ham022): * cc: ian.pozella@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Apr 17 18:22:29 2013 From: noreply at github.com (GitHub) Date: Wed, 17 Apr 2013 11:22:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a594a6: Skip unit tests when buildbot-www isn't available Message-ID: <516ee865d528f_5449bde1c65592@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: a594a60d95d403453fd5cbcb7afaae4d80f6c540 https://github.com/buildbot/buildbot/commit/a594a60d95d403453fd5cbcb7afaae4d80f6c540 Author: Olof Johansson Date: 2013-04-17 (Wed, 17 Apr 2013) Changed paths: M master/buildbot/test/unit/test_scripts_create_master.py M master/buildbot/test/unit/test_scripts_upgrade_master.py M master/buildbot/test/unit/test_util_namespace.py Log Message: ----------- Skip unit tests when buildbot-www isn't available Commit: 64e26df79f1db5cc1f7ae821a8a796f3f9b4f260 https://github.com/buildbot/buildbot/commit/64e26df79f1db5cc1f7ae821a8a796f3f9b4f260 Author: Dustin J. Mitchell Date: 2013-04-17 (Wed, 17 Apr 2013) Changed paths: M master/buildbot/test/unit/test_scripts_create_master.py M master/buildbot/test/unit/test_scripts_upgrade_master.py M master/buildbot/test/unit/test_util_namespace.py Log Message: ----------- Merge branch 'skip_www_tests' of git://github.com/olof/buildbot into nine Compare: https://github.com/buildbot/buildbot/compare/87e6d73a33b8...64e26df79f1d From trac at buildbot.net Thu Apr 18 18:49:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 18 Apr 2013 18:49:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2491: gitpoller doesn't provide enough of a clue when branch doesn't exist Message-ID: <036.352eda19a281f0bf8fcaf7c5b258475c@buildbot.net> #2491: gitpoller doesn't provide enough of a clue when branch doesn't exist ------------------------+----------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ------------------------+----------------------- Masters with many projects using gitpoller will sometimes be misconfigured to poll a git repo that lacks a 'master' branch. The error in this case is shown in the log as exceptions.EnvironmentError: command failed with exit code 128: fatal: Couldn't find remote ref master with no clue which project or repo is to blame. Adding the repourl to the error message, a la - raise EnvironmentError('command failed with exit code %d: %s' - % (code, stderr)) + raise EnvironmentError('command on repourl %s failed with exit code %d: %s' + % (self.repourl, code, stderr)) makes the error message much more helpful. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Apr 18 19:34:13 2013 From: noreply at github.com (GitHub) Date: Thu, 18 Apr 2013 12:34:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7a619b: Include error message in gitpoller failure excepti... Message-ID: <51704ab510758_5a731279e2073785@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7a619b31d12a1f595c7f265965cf1e66a14705ec https://github.com/buildbot/buildbot/commit/7a619b31d12a1f595c7f265965cf1e66a14705ec Author: Dan Kegel Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/changes/gitpoller.py Log Message: ----------- Include error message in gitpoller failure exception - Fixes #2491. From trac at buildbot.net Thu Apr 18 21:47:43 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 18 Apr 2013 21:47:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure In-Reply-To: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> References: <036.e448b76e7eb65ba03be07b9e06c0f1fa@buildbot.net> Message-ID: <051.7eb13108e7cebf96cd0e530c64cd36a2@buildbot.net> #2480: Thundering herd of pollers overwhelms ssh server, causing nearly silent GitPoller failure ----------------------+------------------------ Reporter: dank | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dank): Users can also try ssh multiplexing to reduce number of ssh connections, see http://frankenbyte.tumblr.com/ but fuzz is good regardless. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Apr 19 01:43:01 2013 From: noreply at github.com (GitHub) Date: Thu, 18 Apr 2013 18:43:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cc3427: Install buildbot.buildslave master package Message-ID: <5170a12516bd2_5d19147be1c1000a9@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cc3427cbc77385bcb00975cef677c8f46dbe3a87 https://github.com/buildbot/buildbot/commit/cc3427cbc77385bcb00975cef677c8f46dbe3a87 Author: Olof Johansson Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/setup.py Log Message: ----------- Install buildbot.buildslave master package Commit: f745ce05c68d9e250338f4b12ef89b50d7da531c https://github.com/buildbot/buildbot/commit/f745ce05c68d9e250338f4b12ef89b50d7da531c Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/setup.py Log Message: ----------- Merge branch 'buildbot-0.8.8' Commit: 1d0dca0488e02777cff23108b65b2fc06869cf2c https://github.com/buildbot/buildbot/commit/1d0dca0488e02777cff23108b65b2fc06869cf2c Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: A master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst Log Message: ----------- archive release notes Compare: https://github.com/buildbot/buildbot/compare/7a619b31d12a...1d0dca0488e0 From noreply at github.com Fri Apr 19 01:43:00 2013 From: noreply at github.com (GitHub) Date: Thu, 18 Apr 2013 18:43:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cc3427: Install buildbot.buildslave master package Message-ID: <5170a124e13f1_40c21279e20737b0@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: cc3427cbc77385bcb00975cef677c8f46dbe3a87 https://github.com/buildbot/buildbot/commit/cc3427cbc77385bcb00975cef677c8f46dbe3a87 Author: Olof Johansson Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/setup.py Log Message: ----------- Install buildbot.buildslave master package Commit: fdb851e85f453b13740cbc65e9cf0e8f95d9e77b https://github.com/buildbot/buildbot/commit/fdb851e85f453b13740cbc65e9cf0e8f95d9e77b Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- fix git log message in relnotes Compare: https://github.com/buildbot/buildbot/compare/eb51c2766d96...fdb851e85f45 From noreply at github.com Fri Apr 19 01:43:06 2013 From: noreply at github.com (GitHub) Date: Thu, 18 Apr 2013 18:43:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] Message-ID: <5170a12aa0f07_5e1ffbfe14491c3@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/tags/v0.8.9-pre Home: https://github.com/buildbot/buildbot From noreply at github.com Fri Apr 19 02:13:16 2013 From: noreply at github.com (GitHub) Date: Thu, 18 Apr 2013 19:13:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a24972: removed unused feature in buildslave.scripts.runne... Message-ID: <5170a83c61915_4a6aefbe10249a@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: a24972f01562164a5bb6c1fec887b8cfa9076182 https://github.com/buildbot/buildbot/commit/a24972f01562164a5bb6c1fec887b8cfa9076182 Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- removed unused feature in buildslave.scripts.runner.stop() No code calls stop() with wait flag disabled. Remove wait parameter, and changed stop() to always wait for the process to finish. Commit: 10dceeb46689cc59986d8fa6e8b12d37bf06a2b8 https://github.com/buildbot/buildbot/commit/10dceeb46689cc59986d8fa6e8b12d37bf06a2b8 Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/test/util/misc.py Log Message: ----------- copy StdoutAssertionsMixin class to slave test util package Commit: d22a54d17a6f4fea44b96d908c45668c296b8a77 https://github.com/buildbot/buildbot/commit/d22a54d17a6f4fea44b96d908c45668c296b8a77 Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/util/misc.py Log Message: ----------- tests: broke out open() patching code to a mix in class Created buildslave.test.util.misc.OpenFileMixin class with methods for patching open() to simulate successful reads and I/O errors. Commit: c7da46f05c0e282aaa59666dfa32325e27a9db4f https://github.com/buildbot/buildbot/commit/c7da46f05c0e282aaa59666dfa32325e27a9db4f Author: Elmir Jagudin Date: 2013-04-07 (Sun, 07 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- fixed incorrectly printed message on 'buildslave restart' Don't print 'no old buildslave process found to stop' when old slave process was successfully terminated. Previously stop() returned 'None' when slave was successfully stoped. To restart() it looked like we failed to stop the slave. Broke out the code to stop slave into a new stopSlave() utility function, which will raise an exception if no slave is running. Use stopSlave() from stop() and restart(), handle the exception as appropriate for each case. Commit: eb51c2766d96e7921347260d88608f44409af2ef https://github.com/buildbot/buildbot/commit/eb51c2766d96e7921347260d88608f44409af2ef Author: Dustin J. Mitchell Date: 2013-04-11 (Thu, 11 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/util/misc.py Log Message: ----------- Merge branch 'slave-restart-msg' of git://github.com/elmirjagudin/buildbot Commit: 004bfebd0a5c31f7066042176ee072fe9903d0ed https://github.com/buildbot/buildbot/commit/004bfebd0a5c31f7066042176ee072fe9903d0ed Author: Tom Prince Date: 2013-04-13 (Sat, 13 Apr 2013) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/testcase_synctest.py Log Message: ----------- Monkey patch in synchronous test helpers. These methods make it easy to test code involving deferreds in a synchronous and deterministic manner, rather than having to spin the reactor. Commit: 7e68b03aa8f57627e72e38101075163a98774b49 https://github.com/buildbot/buildbot/commit/7e68b03aa8f57627e72e38101075163a98774b49 Author: Dustin J. Mitchell Date: 2013-04-14 (Sun, 14 Apr 2013) Changed paths: M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/testcase_synctest.py Log Message: ----------- Merge branch 'sync-test-helpers' of git://github.com/tomprince/buildbot Commit: f7dd314430c3d6b3b61336386b32bb9895a431d7 https://github.com/buildbot/buildbot/commit/f7dd314430c3d6b3b61336386b32bb9895a431d7 Author: Sleft Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Fixed grep command for IRC in log With grep IRC there is not output from cat on the log file but with grep -i irc there is, see e.g. ``` $ cat master/twistd.log | grep IRC $ cat master/twistd.log | grep -i irc 2013-04-15 13:26:44+0200 [-] Starting factory 2013-04-15 13:26:58+0200 [IrcStatusBot,client] : I have joined #buildbot-test 2013-04-15 13:27:29+0200 [-] Starting factory 2013-04-15 13:27:29+0200 [IrcStatusBot,client] not scheduling reconnection attempt 2013-04-15 13:27:29+0200 [IrcStatusBot,client] Stopping factory 2013-04-15 13:27:42+0200 [IrcStatusBot,client] : I have joined #buildbot-test ``` Thus, maybe the example line from the log should be changed too? I use Buildbot version: 0.8.6p1 Twisted version: 12.2.0 Commit: e3d3e8e18da8f234a5779b4e93b891ea066756ce https://github.com/buildbot/buildbot/commit/e3d3e8e18da8f234a5779b4e93b891ea066756ce Author: Dustin J. Mitchell Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Merge branch 'master' of git://github.com/Sleft/buildbot Commit: d00f6a9819b4a43b77db294e5ebbc5bfa70d8f6a https://github.com/buildbot/buildbot/commit/d00f6a9819b4a43b77db294e5ebbc5bfa70d8f6a Author: Dustin J. Mitchell Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/buildbot/monkeypatches/__init__.py Log Message: ----------- fix typo in gh-pull 693 Commit: c2076072314d7d9aeaed5900ccd9389f43cce9ba https://github.com/buildbot/buildbot/commit/c2076072314d7d9aeaed5900ccd9389f43cce9ba Author: Sleft Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Fixed inline code and command formatting Inline code and command formatting should be consistent and clear. Commit: 68c08eded0226d00f5c05ff326d55263f33c5edc https://github.com/buildbot/buildbot/commit/68c08eded0226d00f5c05ff326d55263f33c5edc Author: Dustin J. Mitchell Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/tour.rst Log Message: ----------- Merge pull request #695 from Sleft/master Fixed inline code and command formatting Commit: a3d2fcad22c5fc106f49a4914409d41a22aa8c47 https://github.com/buildbot/buildbot/commit/a3d2fcad22c5fc106f49a4914409d41a22aa8c47 Author: Sleft Date: 2013-04-15 (Mon, 15 Apr 2013) Changed paths: M master/docs/tutorial/firstrun.rst Log Message: ----------- Fixed phrasing and formatted commands and code as such Commit: a21c7984991204731f3c4835d30cba41a16982d8 https://github.com/buildbot/buildbot/commit/a21c7984991204731f3c4835d30cba41a16982d8 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/tutorial/fiveminutes.rst Log Message: ----------- Fixed inline code and command formatting Commit: b5329b58fde24ef0d5a0603baa188e98eb192e82 https://github.com/buildbot/buildbot/commit/b5329b58fde24ef0d5a0603baa188e98eb192e82 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- Note and warning about distribution specific package managers Commit: 6bef3b75a25b6b9d77caeae48aad3e32f0181664 https://github.com/buildbot/buildbot/commit/6bef3b75a25b6b9d77caeae48aad3e32f0181664 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/tutorial/firstrun.rst Log Message: ----------- Preferred way to install is via pip To be consistent with the manual Commit: 113582fca6ab5af2ca61df1a7b08de1a414fef43 https://github.com/buildbot/buildbot/commit/113582fca6ab5af2ca61df1a7b08de1a414fef43 Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/installation.rst Log Message: ----------- Less repetetive when using synonym Also fixed command formatting Commit: 83bc2954aebdc532608fa59a8894fedacef9119b https://github.com/buildbot/buildbot/commit/83bc2954aebdc532608fa59a8894fedacef9119b Author: Sleft Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/concepts.rst Log Message: ----------- Fixed link Commit: e31048a402018fe5d108c13f27db316785c69d1d https://github.com/buildbot/buildbot/commit/e31048a402018fe5d108c13f27db316785c69d1d Author: Dustin J. Mitchell Date: 2013-04-16 (Tue, 16 Apr 2013) Changed paths: M master/docs/manual/concepts.rst M master/docs/manual/installation.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst Log Message: ----------- Merge branch 'master' of git://github.com/Sleft/buildbot Commit: 0946659b0fd776ba5b5a0b464b086fcfbc47ba4e https://github.com/buildbot/buildbot/commit/0946659b0fd776ba5b5a0b464b086fcfbc47ba4e Author: Dustin J. Mitchell Date: 2013-04-16 (Tue, 16 Apr 2013) Log Message: ----------- Merge branch 'master' of github.com:buildbot/buildbot Commit: 7a619b31d12a1f595c7f265965cf1e66a14705ec https://github.com/buildbot/buildbot/commit/7a619b31d12a1f595c7f265965cf1e66a14705ec Author: Dan Kegel Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/changes/gitpoller.py Log Message: ----------- Include error message in gitpoller failure exception - Fixes #2491. Commit: cc3427cbc77385bcb00975cef677c8f46dbe3a87 https://github.com/buildbot/buildbot/commit/cc3427cbc77385bcb00975cef677c8f46dbe3a87 Author: Olof Johansson Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/setup.py Log Message: ----------- Install buildbot.buildslave master package Commit: f745ce05c68d9e250338f4b12ef89b50d7da531c https://github.com/buildbot/buildbot/commit/f745ce05c68d9e250338f4b12ef89b50d7da531c Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/setup.py Log Message: ----------- Merge branch 'buildbot-0.8.8' Commit: 1d0dca0488e02777cff23108b65b2fc06869cf2c https://github.com/buildbot/buildbot/commit/1d0dca0488e02777cff23108b65b2fc06869cf2c Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: A master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst Log Message: ----------- archive release notes Commit: 8c40c659bab2560afbd57128db232e115268a77e https://github.com/buildbot/buildbot/commit/8c40c659bab2560afbd57128db232e115268a77e Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/changes/gitpoller.py M master/buildbot/monkeypatches/__init__.py A master/buildbot/monkeypatches/testcase_synctest.py M master/docs/manual/concepts.rst M master/docs/manual/installation.rst A master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst M master/docs/tutorial/firstrun.rst M master/docs/tutorial/fiveminutes.rst M master/docs/tutorial/tour.rst M master/setup.py M slave/buildslave/scripts/runner.py M slave/buildslave/test/unit/test_scripts_base.py M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/util/misc.py Log Message: ----------- Merge branch 'master' into nine Conflicts: master/buildbot/monkeypatches/__init__.py Commit: 18323882c760ad13f3ef7202a7735690bbf3c3c9 https://github.com/buildbot/buildbot/commit/18323882c760ad13f3ef7202a7735690bbf3c3c9 Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M www/grunt.js M www/src/scripts/controllers/buildersController.coffee M www/src/scripts/controllers/changesController.coffee M www/src/scripts/controllers/homeController.coffee M www/src/scripts/directives/topmenu.coffee R www/src/scripts/filters/twitterfy.coffee M www/src/scripts/main.coffee M www/src/scripts/responseInterceptors/dispatcher.coffee M www/src/scripts/routes.coffee M www/src/scripts/run.coffee M www/src/scripts/services/buildbotService.coffee M www/src/scripts/services/messageService.coffee M www/src/scripts/services/recentStorage.coffee Log Message: ----------- clean up coffeeLint Compare: https://github.com/buildbot/buildbot/compare/64e26df79f1d...18323882c760 From noreply at github.com Fri Apr 19 02:32:28 2013 From: noreply at github.com (GitHub) Date: Thu, 18 Apr 2013 19:32:28 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4f89f4: allow undercores in path variables Message-ID: <5170acbc2d398_469b8f7e103695@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 4f89f4cbefbaa6cb6adb27263f61ec06e6a67340 https://github.com/buildbot/buildbot/commit/4f89f4cbefbaa6cb6adb27263f61ec06e6a67340 Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_pathmatch.py M master/buildbot/util/pathmatch.py Log Message: ----------- allow undercores in path variables Commit: 2d6ae177a4116c02bb1a76c327ec7856f74c662c https://github.com/buildbot/buildbot/commit/2d6ae177a4116c02bb1a76c327ec7856f74c662c Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/data/base.py M master/buildbot/data/connector.py A master/buildbot/data/root.py M master/buildbot/test/unit/test_data_base.py M master/buildbot/test/unit/test_data_connector.py M master/buildbot/test/util/endpoint.py Log Message: ----------- Add an rtype attribute to all endpoints Compare: https://github.com/buildbot/buildbot/compare/18323882c760...2d6ae177a411 From noreply at github.com Fri Apr 19 11:45:07 2013 From: noreply at github.com (GitHub) Date: Fri, 19 Apr 2013 04:45:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] dccd8d: - Updated README.md file: Nine is now using Angula... Message-ID: <51712e43db305_736fb31e10650d8@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: dccd8da483f01911f38cbbac4363e13a9daac4dd https://github.com/buildbot/buildbot/commit/dccd8da483f01911f38cbbac4363e13a9daac4dd Author: Edmund Wong Date: 2013-04-19 (Fri, 19 Apr 2013) Changed paths: M README.md Log Message: ----------- - Updated README.md file: Nine is now using AngularJS and not Dojo. Commit: df2dbc064f3afa1b542a51c8cf4301fa000f7ee0 https://github.com/buildbot/buildbot/commit/df2dbc064f3afa1b542a51c8cf4301fa000f7ee0 Author: Dustin J. Mitchell Date: 2013-04-19 (Fri, 19 Apr 2013) Changed paths: M README.md Log Message: ----------- Merge pull request #703 from ewongbb/readmeupdate - Updated README.md file: Nine is now using AngularJS and not Dojo. Compare: https://github.com/buildbot/buildbot/compare/2d6ae177a411...df2dbc064f3a From noreply at github.com Sat Apr 20 11:51:51 2013 From: noreply at github.com (GitHub) Date: Sat, 20 Apr 2013 04:51:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d8ecc2: Handle both json and simplejson in unit tests Message-ID: <51728157c1c5d_1e7456fe14925f6@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: d8ecc28a191f2e836c8a878d6dd45d1b04a8bf47 https://github.com/buildbot/buildbot/commit/d8ecc28a191f2e836c8a878d6dd45d1b04a8bf47 Author: Olof Johansson Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/buildbot/test/unit/test_www_rest.py Log Message: ----------- Handle both json and simplejson in unit tests The simplejson and the json modules differ in the way they handle trailing whitespace when indent is set. >>> json.dumps({"foo":[1,2]}, indent=2) '{\n "foo": [\n 1, \n 2\n ]\n}' >>> simplejson.dumps({"foo":[1,2]}, indent=2) '{\n "foo": [\n 1,\n 2\n ]\n}' With this change, the unit tests use the same json implementation as the tested code instead of hardcoding the expected json string in this situation. Commit: 5b86ae071331944ef9969dda8c7d8681397b849f https://github.com/buildbot/buildbot/commit/5b86ae071331944ef9969dda8c7d8681397b849f Author: Dustin J. Mitchell Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/buildbot/test/unit/test_www_rest.py Log Message: ----------- Merge branch 'topic/unit-simplejson_vs_json' of git://github.com/olof/buildbot into nine Compare: https://github.com/buildbot/buildbot/compare/e145f0290e52...5b86ae071331 From noreply at github.com Sat Apr 20 18:21:32 2013 From: noreply at github.com (GitHub) Date: Sat, 20 Apr 2013 11:21:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 603e90: fix pyflakes Message-ID: <5172dcac4cb87_448b6dfe20470b4@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 603e909a3bf9ef95ceff4a2b362694b121c12344 https://github.com/buildbot/buildbot/commit/603e909a3bf9ef95ceff4a2b362694b121c12344 Author: Dustin J. Mitchell Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/buildbot/data/connector.py M master/buildbot/data/root.py Log Message: ----------- fix pyflakes From noreply at github.com Sat Apr 20 18:21:34 2013 From: noreply at github.com (GitHub) Date: Sat, 20 Apr 2013 11:21:34 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1cf18e: Update documentation for ForceScheduler Message-ID: <5172dcae5d41f_49d9817e147979c@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: 1cf18e094774d9585d7a5d2bd9d29caeb177e6d8 https://github.com/buildbot/buildbot/commit/1cf18e094774d9585d7a5d2bd9d29caeb177e6d8 Author: Jared Grubb Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/docs/developer/cls-forcesched.rst Log Message: ----------- Update documentation for ForceScheduler From noreply at github.com Sat Apr 20 18:22:06 2013 From: noreply at github.com (GitHub) Date: Sat, 20 Apr 2013 11:22:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fdb851: fix git log message in relnotes Message-ID: <5172dcce7f02d_4b2d1305e20450e2@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fdb851e85f453b13740cbc65e9cf0e8f95d9e77b https://github.com/buildbot/buildbot/commit/fdb851e85f453b13740cbc65e9cf0e8f95d9e77b Author: Dustin J. Mitchell Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- fix git log message in relnotes Commit: 1cf18e094774d9585d7a5d2bd9d29caeb177e6d8 https://github.com/buildbot/buildbot/commit/1cf18e094774d9585d7a5d2bd9d29caeb177e6d8 Author: Jared Grubb Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/docs/developer/cls-forcesched.rst Log Message: ----------- Update documentation for ForceScheduler Commit: 8fd43ba9a5cfd650650f373d1f5a50443ad993ec https://github.com/buildbot/buildbot/commit/8fd43ba9a5cfd650650f373d1f5a50443ad993ec Author: Dustin J. Mitchell Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/docs/developer/cls-forcesched.rst Log Message: ----------- Merge branch 'buildbot-0.8.8' Compare: https://github.com/buildbot/buildbot/compare/1d0dca0488e0...8fd43ba9a5cf From noreply at github.com Sat Apr 20 18:33:04 2013 From: noreply at github.com (GitHub) Date: Sat, 20 Apr 2013 11:33:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2a0d34: Docs: update some index references Message-ID: <5172df6067ab4_5db75e7e14887d@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2a0d3487d24393187c55563b4efb5957d3262922 https://github.com/buildbot/buildbot/commit/2a0d3487d24393187c55563b4efb5957d3262922 Author: Jared Grubb Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/docs/developer/cls-iproperties.rst M master/docs/developer/cls-irenderable.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-properties.rst Log Message: ----------- Docs: update some index references Commit: 1ef0b6a8161be2665f13c998c976ac3090084aa4 https://github.com/buildbot/buildbot/commit/1ef0b6a8161be2665f13c998c976ac3090084aa4 Author: Dustin J. Mitchell Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M master/docs/developer/cls-iproperties.rst M master/docs/developer/cls-irenderable.rst M master/docs/manual/cfg-buildsteps.rst M master/docs/manual/cfg-properties.rst Log Message: ----------- Merge branch 'DocsIndexUpdates' of git://github.com/jaredgrubb/buildbot Compare: https://github.com/buildbot/buildbot/compare/8fd43ba9a5cf...1ef0b6a8161b From trac at buildbot.net Sat Apr 20 21:33:13 2013 From: trac at buildbot.net (Buildbot trac) Date: Sat, 20 Apr 2013 21:33:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2490: scheduler that remembers last-seen revisions for each codebase In-Reply-To: <041.56591301e381fe539b2ed88c74608227@buildbot.net> References: <041.56591301e381fe539b2ed88c74608227@buildbot.net> Message-ID: <056.34c656f8d8e2b736685337985c6661db@buildbot.net> #2490: scheduler that remembers last-seen revisions for each codebase ------------------------+-------------------- Reporter: thedylman | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Comment (by thedylman): What name should I use for this single branch scheduler with last-seen per codebase? 1. !SingleBranchLastSeenScheduler 2. !SingleBranchMultRepoScheduler 3. !SingleBranchScheduler with optional argument useLastSeen 4. Something else? -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Sun Apr 21 12:31:15 2013 From: trac at buildbot.net (Buildbot trac) Date: Sun, 21 Apr 2013 12:31:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2490: scheduler that remembers last-seen revisions for each codebase In-Reply-To: <041.56591301e381fe539b2ed88c74608227@buildbot.net> References: <041.56591301e381fe539b2ed88c74608227@buildbot.net> Message-ID: <056.06acac7b1dd4a22641be2af41f3e4fd1@buildbot.net> #2490: scheduler that remembers last-seen revisions for each codebase ------------------------+-------------------- Reporter: thedylman | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): How about !MultiCodebaseScheduler? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Apr 21 18:55:51 2013 From: noreply at github.com (GitHub) Date: Sun, 21 Apr 2013 11:55:51 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 767db4: ClusteredService: a utility class to help arbitrat... Message-ID: <51743637d671d_340fe91e202893e@hookshot-fe4-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 767db4ad4bbbb01cbffb9bb00fcf42e5662a975c https://github.com/buildbot/buildbot/commit/767db4ad4bbbb01cbffb9bb00fcf42e5662a975c Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: A master/buildbot/test/unit/test_util_service.py A master/buildbot/util/service.py Log Message: ----------- ClusteredService: a utility class to help arbitrate a service among multiple masters Commit: f19ce4a514d36abbd7600cafc904075f4fe2c009 https://github.com/buildbot/buildbot/commit/f19ce4a514d36abbd7600cafc904075f4fe2c009 Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_service.py M master/buildbot/util/service.py Log Message: ----------- ClusteredService: address review comments Commit: 945f7b62493374b7d629d0e54420d4c9ee618f0e https://github.com/buildbot/buildbot/commit/945f7b62493374b7d629d0e54420d4c9ee618f0e Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_service.py M master/buildbot/util/service.py M master/docs/developer/classes.rst A master/docs/developer/cls-clusteredservice.rst M master/docs/developer/config.rst Log Message: ----------- ClusteredService: add docs; add isActive() method Commit: 81eb20b189ee874021305831f5ec3ec2e8c060d0 https://github.com/buildbot/buildbot/commit/81eb20b189ee874021305831f5ec3ec2e8c060d0 Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_service.py M master/buildbot/util/service.py M master/docs/developer/cls-clusteredservice.rst Log Message: ----------- Remove evil tabs; fix a duplicated test name Commit: a5ac9760cf7bba9bf20fc2103b9a3334c0a4c303 https://github.com/buildbot/buildbot/commit/a5ac9760cf7bba9bf20fc2103b9a3334c0a4c303 Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_service.py Log Message: ----------- ClusteredService: fix unit test failure Commit: 29f5c8315ac253d176b0665701e59796d6feea50 https://github.com/buildbot/buildbot/commit/29f5c8315ac253d176b0665701e59796d6feea50 Author: Dustin J. Mitchell Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: A master/buildbot/test/unit/test_util_service.py A master/buildbot/util/service.py M master/docs/developer/classes.rst A master/docs/developer/cls-clusteredservice.rst M master/docs/developer/config.rst Log Message: ----------- Merge branch 'ClusteredService' of git://github.com/jaredgrubb/buildbot into nine Compare: https://github.com/buildbot/buildbot/compare/603e909a3bf9...29f5c8315ac2 From trac at buildbot.net Mon Apr 22 01:31:05 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Apr 2013 01:31:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2492: MySQL replication ignoring selected storage engine Message-ID: <041.f236c01db3be52b5729b8a3b514d0e0c@buildbot.net> #2492: MySQL replication ignoring selected storage engine ----------------------+----------------------- Reporter: andrewjcg | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: database ----------------------+----------------------- I am not 100% sure this is a buildbot problem, but the I'm seeing the following issue: When using a MySQL backend, buildbot sets the engine storage type using a "SET storage_engine=" command (https://github.com/buildbot/buildbot/blob/master/master/buildbot/db/enginestrategy.py#L113). As per (http://bugs.mysql.com/bug.php?id=41101), MySQL does not record this command to the binlog, so MySQL replication will use the default storage engine on the slave. Since buildbot can't use InnoDB (as per http://buildbot.readthedocs.org/en/v0.8.6/manual/cfg-global.html#mysql), this will break when its set as the default storage engine on the slaves, even when we explicitly set "MyISAM" as the storage engine in the buildbot config. I *think* this means the engine type should be included on the actual create table query, rather then using 'init_command', as this will get written to the binlog and the slaves will pick this up for replication. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 22 01:53:26 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Apr 2013 01:53:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2492: MySQL replication ignoring selected storage engine In-Reply-To: <041.f236c01db3be52b5729b8a3b514d0e0c@buildbot.net> References: <041.f236c01db3be52b5729b8a3b514d0e0c@buildbot.net> Message-ID: <056.7531d7a2a4068c467f6ae80b456e0570@buildbot.net> #2492: MySQL replication ignoring selected storage engine ----------------------+------------------------ Reporter: andrewjcg | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Resolution: Keywords: database | ----------------------+------------------------ Comment (by dustin): We'd like to get to a point where we can use InnoDB, but this wouldn't be a bad change to make in the interim. At the very least, we should document this. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 22 01:53:45 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Apr 2013 01:53:45 -0000 Subject: [Buildbot-commits] [Buildbot] #2492: MySQL replication ignoring selected storage engine In-Reply-To: <041.f236c01db3be52b5729b8a3b514d0e0c@buildbot.net> References: <041.f236c01db3be52b5729b8a3b514d0e0c@buildbot.net> Message-ID: <056.84fc81983261a90631ab5f412e91ac06@buildbot.net> #2492: MySQL replication ignoring selected storage engine ----------------------+-------------------- Reporter: andrewjcg | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: database | ----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 22 04:30:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Apr 2013 04:30:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2493: MySQL tables use default database character set Message-ID: <041.060b1e0cc0efda1fec22cabd3609c777@buildbot.net> #2493: MySQL tables use default database character set ----------------------+----------------------- Reporter: andrewjcg | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: database ----------------------+----------------------- This is another one thats either low-pri or not really a buildbot bug: Even though buildbot requires utf8, tables created for a MySQL backed use the default character set used by the database they are created in, which causes issues when this is not utf8. This is obviously a very minor issue since its easy to change the default character set or to fix the tables and this only has to be done once when the database tables are first created. However, it'd probably be nice if buildbot would work independently of what the default database character set is. I'm not sure of a great solution here, but it will probably be similar to http://trac.buildbot.net/ticket/2492. The SQAlchemy Table objects accept a 'mysql_charset' option which, when set to 'utf8', seems to fix the problem. However, there are several places where Table objects are instantiated and its probably undesirable to change all these call sites. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 22 11:47:13 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 22 Apr 2013 11:47:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2493: MySQL tables use default database character set In-Reply-To: <041.060b1e0cc0efda1fec22cabd3609c777@buildbot.net> References: <041.060b1e0cc0efda1fec22cabd3609c777@buildbot.net> Message-ID: <056.7d3ac3e29b47812f0621cfd2a1ab5946@buildbot.net> #2493: MySQL tables use default database character set ----------------------+-------------------- Reporter: andrewjcg | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: master | Resolution: Keywords: database | ----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ Comment: Well, since we assume utf-8, we don't necessarily need to write a migration script for this. However, we should find a way to test the tables after the fact to ensure the encoding is correct. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Apr 22 12:00:33 2013 From: noreply at github.com (GitHub) Date: Mon, 22 Apr 2013 05:00:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 348681: tests: move IsBuildslaveDirMixin class to misc mod... Message-ID: <51752661b9239_5b08657e1c324ba@hookshot-fe5-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 348681302ce0dd61f197d58061fc111151ad9bd3 https://github.com/buildbot/buildbot/commit/348681302ce0dd61f197d58061fc111151ad9bd3 Author: Elmir Jagudin Date: 2013-04-20 (Sat, 20 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/util/misc.py Log Message: ----------- tests: move IsBuildslaveDirMixin class to misc module Make it possible to use IsBuildslaveDirMixin class from other test modules. Commit: b10c8b78effe5c952dc2c453c7f4ec8f9c3fdbb8 https://github.com/buildbot/buildbot/commit/b10c8b78effe5c952dc2c453c7f4ec8f9c3fdbb8 Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py M slave/buildslave/test/unit/test_scripts_runner.py A slave/buildslave/test/unit/test_scripts_startup.py Log Message: ----------- don't call isBuildslaveDir() twice on buildslave restart Broke out code to start buildslave process into a utility function startSlave(). Use it from restart() and startCommand(). Commit: 6037af3ddc26f37a79d205aca31dd8a9c540491e https://github.com/buildbot/buildbot/commit/6037af3ddc26f37a79d205aca31dd8a9c540491e Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py Log Message: ----------- specify buildslave subcommand function in it's Options class Use subcommandFunction class variable of the subcommand's Option flag to specify the implementing function. This is the same style used in master cli commands implementation. Commit: b1041faa139262422f15c2e7aba687af58501bbc https://github.com/buildbot/buildbot/commit/b1041faa139262422f15c2e7aba687af58501bbc Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/scripts/runner.py M slave/buildslave/scripts/startup.py M slave/buildslave/test/unit/test_scripts_runner.py M slave/buildslave/test/unit/test_scripts_startup.py Log Message: ----------- return exit code from buildslave subcommands functions Use 'return' to communicate buildslave subcommand exit code. This is how buildbot subcommands are implemented. Commit: 272246fba02389a078f30a8294f1178951bb6875 https://github.com/buildbot/buildbot/commit/272246fba02389a078f30a8294f1178951bb6875 Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- test handling of invalid arguments to 'buildslave' cli command Added unit tests on code in buildslave.scripts.runner.run() that handles invalid command line arguments. Commit: 0875f29b577a488760dec82afe175eeeca18377c https://github.com/buildbot/buildbot/commit/0875f29b577a488760dec82afe175eeeca18377c Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- unit test successful invocation of 'buildslave' cli command Commit: ec62eca18d933c837b42c41dfadeb3dfa68b23a7 https://github.com/buildbot/buildbot/commit/ec62eca18d933c837b42c41dfadeb3dfa68b23a7 Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- unit test options parsing for 'buildslave' command without arguments Test that buildslave.scripts.runner.Options class flags invocation of 'buildslave' command without arguments, as invalid. Commit: 73d2b5b93598033758c6d56129672c1bf4ec7a2f https://github.com/buildbot/buildbot/commit/73d2b5b93598033758c6d56129672c1bf4ec7a2f Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- unit test handling of '--verbose' option for 'buildslave' command Commit: e31e40389e1c52abc3f308eb72e2a62a663f5529 https://github.com/buildbot/buildbot/commit/e31e40389e1c52abc3f308eb72e2a62a663f5529 Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- unit test handling of '--version' option for 'buildslave' command Commit: d8626361079a9e5a4fc32ed8619794e7ac9b4f82 https://github.com/buildbot/buildbot/commit/d8626361079a9e5a4fc32ed8619794e7ac9b4f82 Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M slave/buildslave/test/unit/test_scripts_runner.py Log Message: ----------- added unit tests on buildslave cli Options classes Commit: 41702af666a1b9575cf8b5cf7bd7e936d9c1d939 https://github.com/buildbot/buildbot/commit/41702af666a1b9575cf8b5cf7bd7e936d9c1d939 Author: Elmir Jagudin Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: A slave/buildslave/scripts/create_slave.py A slave/buildslave/scripts/restart.py M slave/buildslave/scripts/runner.py A slave/buildslave/scripts/start.py R slave/buildslave/scripts/startup.py A slave/buildslave/scripts/stop.py A slave/buildslave/scripts/upgrade_slave.py M slave/buildslave/test/test_extra_coverage.py A slave/buildslave/test/unit/test_scripts_restart.py M slave/buildslave/test/unit/test_scripts_runner.py A slave/buildslave/test/unit/test_scripts_start.py R slave/buildslave/test/unit/test_scripts_startup.py A slave/buildslave/test/unit/test_scripts_stop.py A slave/buildslave/test/unit/test_scripts_upgrade_slave.py Log Message: ----------- buildslave cli: broke out subcommand code to separate modules Moved sumcommands implementations from buildslave.scripts.runner to separate modules, one for each subcommand. Commit: ad302035cf476ad0aa141a57f995987545a37cf3 https://github.com/buildbot/buildbot/commit/ad302035cf476ad0aa141a57f995987545a37cf3 Author: Dustin J. Mitchell Date: 2013-04-22 (Mon, 22 Apr 2013) Changed paths: A slave/buildslave/scripts/create_slave.py A slave/buildslave/scripts/restart.py M slave/buildslave/scripts/runner.py A slave/buildslave/scripts/start.py R slave/buildslave/scripts/startup.py A slave/buildslave/scripts/stop.py A slave/buildslave/scripts/upgrade_slave.py M slave/buildslave/test/test_extra_coverage.py A slave/buildslave/test/unit/test_scripts_restart.py M slave/buildslave/test/unit/test_scripts_runner.py A slave/buildslave/test/unit/test_scripts_start.py A slave/buildslave/test/unit/test_scripts_stop.py A slave/buildslave/test/unit/test_scripts_upgrade_slave.py M slave/buildslave/test/util/misc.py Log Message: ----------- Merge branch 'slave-cli-fixes' of git://github.com/elmirjagudin/buildbot Compare: https://github.com/buildbot/buildbot/compare/1ef0b6a8161b...ad302035cf47 From noreply at github.com Tue Apr 23 01:06:01 2013 From: noreply at github.com (GitHub) Date: Mon, 22 Apr 2013 18:06:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1564a1: Move Schedulers base to ClusteredService Message-ID: <5175de7917db7_3a9da21e1c2053@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/nine Home: https://github.com/buildbot/buildbot Commit: 1564a13c777a1e448dc00883304ab73bc67dc388 https://github.com/buildbot/buildbot/commit/1564a13c777a1e448dc00883304ab73bc67dc388 Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/data/schedulers.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/forcesched.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/unit/test_data_schedulers.py M master/buildbot/test/unit/test_schedulers_base.py M master/docs/developer/db.rst Log Message: ----------- Move Schedulers base to ClusteredService Commit: 94219621ee82341a4dc2a968927ea8a64297114c https://github.com/buildbot/buildbot/commit/94219621ee82341a4dc2a968927ea8a64297114c Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/schedulers/base.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/util/scheduler.py M master/buildbot/util/service.py Log Message: ----------- TrySched: move to activate/deactivate Commit: ae7b5ce73e7b928cc8cf3030e7e8804e7d2e6adc https://github.com/buildbot/buildbot/commit/ae7b5ce73e7b928cc8cf3030e7e8804e7d2e6adc Author: Jared Grubb Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/data/schedulers.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/unit/test_data_schedulers.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_util_service.py M master/buildbot/util/service.py M master/docs/developer/rtype-scheduler.rst Log Message: ----------- Scheduler-ClusteredService: address review comments - fix up how the exception handling works - some comments and documentation Commit: 924c5e31a325a14e745f0bf2a361ae09abf80257 https://github.com/buildbot/buildbot/commit/924c5e31a325a14e745f0bf2a361ae09abf80257 Author: Dustin J. Mitchell Date: 2013-04-22 (Mon, 22 Apr 2013) Changed paths: M master/buildbot/data/schedulers.py M master/buildbot/schedulers/base.py M master/buildbot/schedulers/forcesched.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/fake/fakedata.py M master/buildbot/test/unit/test_data_schedulers.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_util_service.py M master/buildbot/test/util/scheduler.py M master/buildbot/util/service.py M master/docs/developer/db.rst M master/docs/developer/rtype-scheduler.rst Log Message: ----------- Merge branch 'SchedulerAsClusteredService' of git://github.com/jaredgrubb/buildbot into nine Commit: 670d898778f4fdaf37b8c3d60c4dd784eca4fcc0 https://github.com/buildbot/buildbot/commit/670d898778f4fdaf37b8c3d60c4dd784eca4fcc0 Author: Dustin J. Mitchell Date: 2013-04-22 (Mon, 22 Apr 2013) Changed paths: M master/buildbot/test/unit/test_data_schedulers.py Log Message: ----------- fix pyflake Compare: https://github.com/buildbot/buildbot/compare/29f5c8315ac2...670d898778f4 From noreply at github.com Tue Apr 23 01:08:53 2013 From: noreply at github.com (GitHub) Date: Mon, 22 Apr 2013 18:08:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fae7b3: JSONP: Add _ as a valid character for the callback... Message-ID: <5175df25d85ee_797f11f9e141768a@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fae7b3b379cf99a911bc6fa62b41867e0141f65c https://github.com/buildbot/buildbot/commit/fae7b3b379cf99a911bc6fa62b41867e0141f65c Author: Beno?t Allard Date: 2013-04-22 (Mon, 22 Apr 2013) Changed paths: M master/buildbot/status/web/status_json.py Log Message: ----------- JSONP: Add _ as a valid character for the callback name At least angularjs is using callbacks names with underscore in them, and that's a valid character in a JavaScript identifier name anyway. Commit: 62e35b1b2624a180da94f21d10f3371d34bace96 https://github.com/buildbot/buildbot/commit/62e35b1b2624a180da94f21d10f3371d34bace96 Author: Dustin J. Mitchell Date: 2013-04-22 (Mon, 22 Apr 2013) Changed paths: M master/buildbot/status/web/status_json.py Log Message: ----------- Merge branch 'patch-6' of git://github.com/benallard/buildbot Compare: https://github.com/buildbot/buildbot/compare/ad302035cf47...62e35b1b2624 From trac at buildbot.net Tue Apr 23 15:46:17 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 23 Apr 2013 15:46:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2494: It is not always clear what parameters each buildstep can have which can result in unexpected behavior Message-ID: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> #2494: It is not always clear what parameters each buildstep can have which can result in unexpected behavior ------------------------+--------------------------------------- Reporter: johnt | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: docs steps parameters api ------------------------+--------------------------------------- In cases where build steps fail or have warnings it is not always immediately clear what will happen to the build - will it stop or continue and what will it be marked as? To this end it might be a good idea to provide this information in a table in the documentation. It could contain a list of the possible build steps which have parameters set by default and possibly a link to the API reference. Example: Buildstep | Default Parameters | API ref Configure | haltOnFailures=True, flunkOnFailures=True | Link Compile | haltOnFailures=True, flunkOnFailures=True | Link ShellCommand | flunkOnFailures=True | Link ... This would make it clear to users why their builder is behaving as it is. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 23 15:52:12 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 23 Apr 2013 15:52:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. (was: It is not always clear what parameters each buildstep can have which can result in unexpected behavior) In-Reply-To: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> References: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> Message-ID: <052.68bd18ba1e00e4e24ca46ffa5379bae5@buildbot.net> #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. --------------------------------------+------------------------ Reporter: johnt | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: docs steps parameters api | --------------------------------------+------------------------ Changes (by johnt): * priority: minor => major -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 23 16:01:29 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 23 Apr 2013 16:01:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. In-Reply-To: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> References: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> Message-ID: <052.c390480ce7a5980134822086bfce02cf@buildbot.net> #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. --------------------------------------+------------------------ Reporter: johnt | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: docs steps parameters api | --------------------------------------+------------------------ Comment (by johnt): A good example of this is that Compile() and Configure() have haltOnFailures set to True by default but shellCommand() has it set to False -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 23 16:39:16 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 23 Apr 2013 16:39:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. In-Reply-To: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> References: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> Message-ID: <052.360e7a0d7a960d5f401decc381fbb9ef@buildbot.net> #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. --------------------------------------+------------------------ Reporter: johnt | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Resolution: Keywords: docs steps parameters api | --------------------------------------+------------------------ Comment (by johnt): Buildbot allows the use of a number of parameters for every buildstep which control how that step will behave in the case of warnings or errors being generated. Most steps can be successful (green), fail (red), have an exception such as incorrect buildbot code (purple), be skipped (blue) or in some cases generate warnings (orange). In general, if all steps succeed in a build (even if there are warnings) that build will be marked as successful (green). The following table shows the parameters which can be set to control how a builder will behave in some of these circumstances: ||Parameter||Result|| ||haltOnFailures||Halt if this step fails (except stems which are makred as alwaysRun=True)|| ||flunkOnWarnings||Warnings or failure in this step will mark the build as Failed|| ||flunkOnFailure||Failure in this step will mark the build as Failed|| ||warnOnWarnings||Warnings or failure in this step will mark the build as Warnings|| ||warnOnFailure||Failure in this step will mark the build as Failed|| ||alwaysRun||Always run this buildstep - this can be used for cleanup code|| Some types of buildsteps have default parameters which are different from the normal settings and can cause unexpected behavior: ||Buildstep||Parameters||API ref|| ||Configure||haltOnFailures=True, flunkOnFailures=True||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.shell .Configure-class.html link]|| ||Compile||haltOnFailures=True, flunkOnFailures=True||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.shell .Compile-class.html link]|| ||ShellCommand||flunkOnFailures=True||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.shell .ShellCommand-class.html link]|| ||RemoveDir||haltOnFailures=True, flunkOnFailures=True||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.slave .RemoveDirectory-class.html link]|| ||SetProperty|| ||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.shell .SetProperty-class.html link]|| ||MasterShellCommand||haltOnFailures=True, flunkOnFailures=True||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.master .MasterShellCommand-class.html link]|| ||Git|| ||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.source.git .Git-class.html link]|| ||DirectoryUpload|| ||[http://docs.buildbot.net/0.8.6p1/reference/buildbot.steps.transfer .DirectoryUpload-class.html link]|| -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 23 16:42:58 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 23 Apr 2013 16:42:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. In-Reply-To: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> References: <037.0d3b4d1cbec1de8aa05cf03a64fe08c3@buildbot.net> Message-ID: <052.a3dbbe40543a36fc31f3c778da24a95b@buildbot.net> #2494: Clarify and document the default vaules for haltOnFailures, flunkOnWarnings, warnOnFailures, etc. -------------------------------+-------------------- Reporter: johnt | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: docs sprint simple | -------------------------------+-------------------- Changes (by dustin): * keywords: docs steps parameters api => docs sprint simple * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Apr 24 23:11:01 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 24 Apr 2013 23:11:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage Message-ID: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------+----------------------- Reporter: jachen | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.7p1 | Keywords: ----------------------+----------------------- I was not able to use the 'Repository' field on the 'force build' form to build a repo other than the default one I coded in the master.cfg. Is the idea that I need to get the Repository property from the build and then dynamically pass it into the Git 'repourl'? This field seems to work differently from other fields that just auto work: 'Branch' seems to work when you enter something other than 'master'. Same with 'revision' when you enter a commit. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Wed Apr 24 23:49:06 2013 From: trac at buildbot.net (Buildbot trac) Date: Wed, 24 Apr 2013 23:49:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage In-Reply-To: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> References: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> Message-ID: <053.cd9e3a649bc8f071956d40ab8f0bd5fa@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------------+---------------------- Reporter: jachen | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: projrepo | ----------------------------+---------------------- Changes (by dustin): * keywords: => projrepo * type: undecided => support-request * milestone: undecided => ongoing Comment: Yes, you need to substitute it with interpolation, e.g., `repourl=Interpolate('%(src::repository)s')`. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 00:28:16 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 00:28:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2496: Be robust against empty pid files Message-ID: <036.5c710cf3a551e8bf9960d56160bd23d2@buildbot.net> #2496: Be robust against empty pid files ------------------------+----------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.7p1 | Keywords: ------------------------+----------------------- Don't fail to start up if pid file is empty, as it sometimes is when restarting after the disk fills up. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 00:38:42 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 00:38:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2496: Be robust against empty pid files In-Reply-To: <036.5c710cf3a551e8bf9960d56160bd23d2@buildbot.net> References: <036.5c710cf3a551e8bf9960d56160bd23d2@buildbot.net> Message-ID: <051.1adf735108eeef084a8985492150000c@buildbot.net> #2496: Be robust against empty pid files ------------------------+-------------------- Reporter: dank | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.7p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Apr 25 03:11:21 2013 From: noreply at github.com (GitHub) Date: Wed, 24 Apr 2013 20:11:21 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 905424: remove doctest-like thing that confuses pyflakes Message-ID: <51789ed98851f_5449e07e146092a@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 905424119a11f6470dee70323c056f4a3e9a957d https://github.com/buildbot/buildbot/commit/905424119a11f6470dee70323c056f4a3e9a957d Author: Dustin J. Mitchell Date: 2013-04-24 (Wed, 24 Apr 2013) Changed paths: M master/buildbot/test/util/change_import.py Log Message: ----------- remove doctest-like thing that confuses pyflakes From trac at buildbot.net Thu Apr 25 07:39:43 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 07:39:43 -0000 Subject: [Buildbot-commits] [Buildbot] #301: Allow a single buildslave to service multiple buildmasters In-Reply-To: <038.135489a6c8da4c3da37f03e84367f026@buildbot.net> References: <038.135489a6c8da4c3da37f03e84367f026@buildbot.net> Message-ID: <053.b66279e2531ace5d0b121549b823c15b@buildbot.net> #301: Allow a single buildslave to service multiple buildmasters ------------------------+----------------------- Reporter: dustin | Owner: sridhar Type: enhancement | Status: assigned Priority: major | Milestone: 2.0.+ Version: 0.7.7 | Resolution: Keywords: | ------------------------+----------------------- Comment (by asibilev): Was this problem resolved somehow in any release? I mean out-of-box solution. Does anybody have experience this using single slave for 2 masters with locks? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Apr 25 12:06:06 2013 From: noreply at github.com (GitHub) Date: Thu, 25 Apr 2013 05:06:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bad988: add relnotes for dad3bf98fe27cf821d5b4e08160071af4... Message-ID: <51791c2ef195e_68a71317e187901@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: bad9881d117d794f4af8d5c4e23237f992f7c9c7 https://github.com/buildbot/buildbot/commit/bad9881d117d794f4af8d5c4e23237f992f7c9c7 Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- add relnotes for dad3bf98fe27cf821d5b4e08160071af4777250d From noreply at github.com Thu Apr 25 12:15:20 2013 From: noreply at github.com (GitHub) Date: Thu, 25 Apr 2013 05:15:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e4c729: typo Message-ID: <51791e586de6c_22c5ffbe1431273@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: e4c7292200c215c1b5e1ead0fc46ece255a263b6 https://github.com/buildbot/buildbot/commit/e4c7292200c215c1b5e1ead0fc46ece255a263b6 Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- typo From trac at buildbot.net Thu Apr 25 12:28:46 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 12:28:46 -0000 Subject: [Buildbot-commits] [Buildbot] #119: add Builder description somewhere In-Reply-To: <038.92b0e7676a25919e9f80f1a066140c6a@buildbot.net> References: <038.92b0e7676a25919e9f80f1a066140c6a@buildbot.net> Message-ID: <053.568aedaacdf89ed224b93e619c657ca5@buildbot.net> #119: add Builder description somewhere ------------------------+---------------------- Reporter: warner | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: wontfix Keywords: | ------------------------+---------------------- Comment (by pepsiman): Fixed in 0.8.8 -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 12:29:44 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 12:29:44 -0000 Subject: [Buildbot-commits] [Buildbot] #301: Allow a single buildslave to service multiple buildmasters In-Reply-To: <038.135489a6c8da4c3da37f03e84367f026@buildbot.net> References: <038.135489a6c8da4c3da37f03e84367f026@buildbot.net> Message-ID: <053.5c836b81311ebc9188d090a754cc78d3@buildbot.net> #301: Allow a single buildslave to service multiple buildmasters ------------------------+----------------------- Reporter: dustin | Owner: sridhar Type: enhancement | Status: assigned Priority: major | Milestone: 2.0.+ Version: 0.7.7 | Resolution: Keywords: | ------------------------+----------------------- Old description: > We run a few different buildmasters -- they're monitoring different > repos, and in general are for different teams. But we use the same > (large) set of build VMs for both. Currently we run two buildslave > instances on each build VM, which is inefficient in a few ways: it's a > lot of duplicated data in RAM, since Python bytecode isn't shared the way > .so's are; and it means that builds for two different projects can be > taking place simultaneously on the same VM. > > It would be nice to have the option of pointing a single buildslave at > multiple buildmasters, with some sort of locking to only allow it to run > a single build at a time. New description: We run a few different buildmasters -- they're monitoring different repos, and in general are for different teams. But we use the same (large) set of build VMs for both. Currently we run two buildslave instances on each build VM, which is inefficient in a few ways: it's a lot of duplicated data in RAM, since Python bytecode isn't shared the way .so's are; and it means that builds for two different projects can be taking place simultaneously on the same VM. It would be nice to have the option of pointing a single buildslave at multiple buildmasters, with some sort of locking to only allow it to run a single build at a time. -- Comment (by dustin): There's been no action, that I know of, on this bug. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 12:30:25 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 12:30:25 -0000 Subject: [Buildbot-commits] [Buildbot] #119: add Builder description somewhere In-Reply-To: <038.92b0e7676a25919e9f80f1a066140c6a@buildbot.net> References: <038.92b0e7676a25919e9f80f1a066140c6a@buildbot.net> Message-ID: <053.ef521622de108a068796538042e438ec@buildbot.net> #119: add Builder description somewhere ------------------------+----------------------- Reporter: warner | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: | ------------------------+----------------------- Changes (by dustin): * status: closed => reopened * resolution: wontfix => Old description: > There ought to be a place to add a description of the Builder somewhere, > so that it can be displayed > on the web page when you look at /builders/BUILDERNAME . At the moment > the builder name is the best > clue you can get as to the purpose of the builder, and they need to be > short to fit on the waterfall > page. > > I'm thinking Builder(description="...") and then > IBuilderStatus.getDescription() New description: There ought to be a place to add a description of the Builder somewhere, so that it can be displayed on the web page when you look at /builders/BUILDERNAME . At the moment the builder name is the best clue you can get as to the purpose of the builder, and they need to be short to fit on the waterfall page. I'm thinking Builder(description="...") and then IBuilderStatus.getDescription() -- -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 12:30:37 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 12:30:37 -0000 Subject: [Buildbot-commits] [Buildbot] #119: add Builder description somewhere In-Reply-To: <038.92b0e7676a25919e9f80f1a066140c6a@buildbot.net> References: <038.92b0e7676a25919e9f80f1a066140c6a@buildbot.net> Message-ID: <053.e973a0630214df4f22e222df1314ce27@buildbot.net> #119: add Builder description somewhere ------------------------+--------------------- Reporter: warner | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.8 Version: 0.7.6 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: reopened => closed * resolution: => fixed * milestone: 0.8.+ => 0.8.8 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Apr 25 12:32:02 2013 From: noreply at github.com (GitHub) Date: Thu, 25 Apr 2013 05:32:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 706ad7: new Renderable FlattenList which flattens nested l... Message-ID: <5179224272256_693ce2be18107340@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 706ad7581e0c3a66ee107b29634169719e11ba82 https://github.com/buildbot/buildbot/commit/706ad7581e0c3a66ee107b29634169719e11ba82 Author: liucougar Date: 2013-04-24 (Wed, 24 Apr 2013) Changed paths: M master/buildbot/process/properties.py M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/util/__init__.py M master/docs/manual/cfg-properties.rst M master/docs/relnotes/0.8.8.rst Log Message: ----------- new Renderable FlattenList which flattens nested list Commit: 718815e1d429514b23a9f58f2002cc0f2b24c3e5 https://github.com/buildbot/buildbot/commit/718815e1d429514b23a9f58f2002cc0f2b24c3e5 Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/buildbot/process/properties.py M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/util/__init__.py M master/docs/manual/cfg-properties.rst M master/docs/relnotes/0.8.8.rst Log Message: ----------- Merge branch 'flatten-all-renderables' of git://github.com/liucougar/buildbot Commit: cf486cdbae379d64a41ef6a6c9d914b1791c1590 https://github.com/buildbot/buildbot/commit/cf486cdbae379d64a41ef6a6c9d914b1791c1590 Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/manual/cfg-properties.rst Log Message: ----------- touch up the docs Commit: 5d396a74d38c34b10618fd16be762acab14d5e6f https://github.com/buildbot/buildbot/commit/5d396a74d38c34b10618fd16be762acab14d5e6f Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/relnotes/0.8.8.rst M master/docs/relnotes/index.rst Log Message: ----------- move relnotes to the right file Compare: https://github.com/buildbot/buildbot/compare/905424119a11...5d396a74d38c From trac at buildbot.net Thu Apr 25 16:52:05 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 16:52:05 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage In-Reply-To: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> References: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> Message-ID: <053.726893b07d5229a11df978f34952a307@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------------+---------------------- Reporter: jachen | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: projrepo | ----------------------------+---------------------- Comment (by jachen): Worked out really well. Maybe this feature should be more documented? At least for us, with the github and the forks, it's equivalent to a try scheduler since now the user can just build their own fork on our builder. Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 17:54:10 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 17:54:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage In-Reply-To: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> References: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> Message-ID: <053.890fc1e319aa3f67b3fef773231d1512@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------------+---------------------- Reporter: jachen | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: projrepo | ----------------------------+---------------------- Comment (by dustin): There's some documentation of it, but you're probably in a good position to add more, perhaps at the places you did look in the documentation. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Thu Apr 25 20:03:11 2013 From: trac at buildbot.net (Buildbot trac) Date: Thu, 25 Apr 2013 20:03:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage In-Reply-To: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> References: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> Message-ID: <053.fb7a080b1e0e8e2c068402120438643f@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------------+---------------------- Reporter: jachen | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: projrepo | ----------------------------+---------------------- Comment (by jachen): I didn't even know we can do that.... -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 26 13:27:08 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Apr 2013 13:27:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2497: Function which returns the name of the last successful build of a given builder Message-ID: <037.5ed81e63a9327f429dc27b5f75079dba@buildbot.net> #2497: Function which returns the name of the last successful build of a given builder ------------------------+----------------------- Reporter: johnt | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: master | Keywords: ------------------------+----------------------- It would be very useful to be able to access the last build which succeeded for a given builder, for example: lastbuild = LastBuild(mybuilder) -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 26 13:33:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Apr 2013 13:33:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2498: method for setting default properties for all instances of a buildstep Message-ID: <037.c1a723ee002ca986c77338ac8380ab28@buildbot.net> #2498: method for setting default properties for all instances of a buildstep ------------------------+-------------------------- Reporter: johnt | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: shellCommand ------------------------+-------------------------- It should be repetitively simple to set all instances of shellCommand() to haltOnFailures=True without having to pass this to each instance. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 26 13:38:49 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Apr 2013 13:38:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2497: Function which returns the name of the last successful build of a given builder In-Reply-To: <037.5ed81e63a9327f429dc27b5f75079dba@buildbot.net> References: <037.5ed81e63a9327f429dc27b5f75079dba@buildbot.net> Message-ID: <052.386e26fdffe5032ac99d296a322999bc@buildbot.net> #2497: Function which returns the name of the last successful build of a given builder ------------------------+-------------------- Reporter: johnt | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: master | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.9.+ Comment: We'll have a way to do this in the data API in nine. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Fri Apr 26 13:40:03 2013 From: trac at buildbot.net (Buildbot trac) Date: Fri, 26 Apr 2013 13:40:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2498: method for setting default properties for all instances of a buildstep In-Reply-To: <037.c1a723ee002ca986c77338ac8380ab28@buildbot.net> References: <037.c1a723ee002ca986c77338ac8380ab28@buildbot.net> Message-ID: <052.ececc8824f7f9c7294dab73650ee1df8@buildbot.net> #2498: method for setting default properties for all instances of a buildstep ----------------------------+------------------------- Reporter: johnt | Owner: Type: support-request | Status: closed Priority: minor | Milestone: ongoing Version: master | Resolution: worksforme Keywords: | ----------------------------+------------------------- Changes (by dustin): * keywords: shellCommand => * status: new => closed * type: enhancement => support-request * resolution: => worksforme * milestone: undecided => ongoing Comment: You can do that within your configuration file - just write a function that creates ShellCommand objects with the desired settings. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Apr 27 14:52:23 2013 From: noreply at github.com (GitHub) Date: Sat, 27 Apr 2013 07:52:23 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bad988: add relnotes for dad3bf98fe27cf821d5b4e08160071af4... Message-ID: <517be6275fd43_aacbede1c2023782@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: bad9881d117d794f4af8d5c4e23237f992f7c9c7 https://github.com/buildbot/buildbot/commit/bad9881d117d794f4af8d5c4e23237f992f7c9c7 Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- add relnotes for dad3bf98fe27cf821d5b4e08160071af4777250d Commit: e4c7292200c215c1b5e1ead0fc46ece255a263b6 https://github.com/buildbot/buildbot/commit/e4c7292200c215c1b5e1ead0fc46ece255a263b6 Author: Dustin J. Mitchell Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- typo Commit: 9c2b15baf6d7cff78d94dfb6a2999f7a1fa3c797 https://github.com/buildbot/buildbot/commit/9c2b15baf6d7cff78d94dfb6a2999f7a1fa3c797 Author: Olof Johansson Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Update docs referring to the old getProjectName() The buildbot.status.master.getProjectName() has been renamed to getTitle(). Commit: 39fe2d6728ab467baead06742110d83d407ab12d https://github.com/buildbot/buildbot/commit/39fe2d6728ab467baead06742110d83d407ab12d Author: Dustin J. Mitchell Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst Log Message: ----------- Merge branch 'docfix/getprojectname_gettitle' of git://github.com/olof/buildbot Compare: https://github.com/buildbot/buildbot/compare/5d396a74d38c...39fe2d6728ab From noreply at github.com Sun Apr 28 02:45:07 2013 From: noreply at github.com (GitHub) Date: Sat, 27 Apr 2013 19:45:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d4d7e9: Update docs referring to the old getProjectName() Message-ID: <517c8d333440e_18a510efe108248d@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/buildbot-0.8.8 Home: https://github.com/buildbot/buildbot Commit: d4d7e95c4ea116b31b593801d6916529d2e37fd5 https://github.com/buildbot/buildbot/commit/d4d7e95c4ea116b31b593801d6916529d2e37fd5 Author: Olof Johansson Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- Update docs referring to the old getProjectName() The buildbot.status.master.getProjectName() has been renamed to getTitle(). From trac at buildbot.net Mon Apr 29 10:30:03 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 29 Apr 2013 10:30:03 -0000 Subject: [Buildbot-commits] [Buildbot] #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 In-Reply-To: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> References: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> Message-ID: <052.ad36c3b5d306be10ae526b10ea61dd69@buildbot.net> #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 --------------------+------------------------ Reporter: johnt | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.6p1 | Resolution: Keywords: git | --------------------+------------------------ Comment (by johnt): The machine I am using has an old version of git installed and I cant upgrade it at the moment so the following line in a builder wont work unless I use the workaround listed above: Git( repourl='/path/to/repo', branch='testing', mode='clobber' ) I dont think its necessary to make a change to the code so long as there is a note in the documentation stating that there is a minimum version of Git required for some features and possibly a link to the workaround if people need it. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Mon Apr 29 23:00:28 2013 From: trac at buildbot.net (Buildbot trac) Date: Mon, 29 Apr 2013 23:00:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage In-Reply-To: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> References: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> Message-ID: <053.900ad0ab758c10a4880750d8f719a730@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------------+---------------------- Reporter: jachen | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: projrepo | ----------------------------+---------------------- Comment (by jachen): I have another question on this. Now it seems I need to supply a 'repository' url in 'force build' form for this Interpolate('%(src::repository)s' to work. How do I supply a default repo url if a 'repository' url is not set during 'force build'? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Apr 30 00:59:54 2013 From: noreply at github.com (GitHub) Date: Mon, 29 Apr 2013 17:59:54 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7a29ec: added builds status png view (like travis png stat... Message-ID: <517f178a5febe_4c7858be20136975@hookshot-fe3-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7a29ec55a615e5282bd66a7224691b4397360552 https://github.com/buildbot/buildbot/commit/7a29ec55a615e5282bd66a7224691b4397360552 Author: @damnwidget Date: 2013-04-26 (Fri, 26 Apr 2013) Changed paths: M master/buildbot/status/web/baseweb.py A master/buildbot/status/web/files/exception_large.png A master/buildbot/status/web/files/exception_normal.png A master/buildbot/status/web/files/exception_small.png A master/buildbot/status/web/files/failure_large.png A master/buildbot/status/web/files/failure_normal.png A master/buildbot/status/web/files/failure_small.png A master/buildbot/status/web/files/readme_svg.txt A master/buildbot/status/web/files/retry_large.png A master/buildbot/status/web/files/retry_normal.png A master/buildbot/status/web/files/retry_small.png A master/buildbot/status/web/files/skipped_large.png A master/buildbot/status/web/files/skipped_normal.png A master/buildbot/status/web/files/skipped_small.png A master/buildbot/status/web/files/status.svg A master/buildbot/status/web/files/status_large.svg A master/buildbot/status/web/files/status_small.svg A master/buildbot/status/web/files/success_large.png A master/buildbot/status/web/files/success_normal.png A master/buildbot/status/web/files/success_small.png A master/buildbot/status/web/files/unknown_large.png A master/buildbot/status/web/files/unknown_normal.png A master/buildbot/status/web/files/unknown_small.png A master/buildbot/status/web/files/warnings_large.png A master/buildbot/status/web/files/warnings_normal.png A master/buildbot/status/web/files/warnings_small.png A master/buildbot/status/web/pngstatus.py A master/buildbot/test/unit/test_status_web_png_resource.py A master/docs/_images/success_normal.png M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst M master/setup.py Log Message: ----------- added builds status png view (like travis png status) with SVG models Commit: f2ab36fbe2276fbe1e94a952c49211418c229978 https://github.com/buildbot/buildbot/commit/f2ab36fbe2276fbe1e94a952c49211418c229978 Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/buildbot/status/web/baseweb.py A master/buildbot/status/web/files/exception_large.png A master/buildbot/status/web/files/exception_normal.png A master/buildbot/status/web/files/exception_small.png A master/buildbot/status/web/files/failure_large.png A master/buildbot/status/web/files/failure_normal.png A master/buildbot/status/web/files/failure_small.png A master/buildbot/status/web/files/readme_svg.txt A master/buildbot/status/web/files/retry_large.png A master/buildbot/status/web/files/retry_normal.png A master/buildbot/status/web/files/retry_small.png A master/buildbot/status/web/files/skipped_large.png A master/buildbot/status/web/files/skipped_normal.png A master/buildbot/status/web/files/skipped_small.png A master/buildbot/status/web/files/status.svg A master/buildbot/status/web/files/status_large.svg A master/buildbot/status/web/files/status_small.svg A master/buildbot/status/web/files/success_large.png A master/buildbot/status/web/files/success_normal.png A master/buildbot/status/web/files/success_small.png A master/buildbot/status/web/files/unknown_large.png A master/buildbot/status/web/files/unknown_normal.png A master/buildbot/status/web/files/unknown_small.png A master/buildbot/status/web/files/warnings_large.png A master/buildbot/status/web/files/warnings_normal.png A master/buildbot/status/web/files/warnings_small.png A master/buildbot/status/web/pngstatus.py A master/buildbot/test/unit/test_status_web_png_resource.py A master/docs/_images/success_normal.png M master/docs/manual/cfg-statustargets.rst M master/docs/relnotes/index.rst M master/setup.py Log Message: ----------- Merge branch 'pngstatus' of git://github.com/DamnWidget/buildbot Commit: 3c0c55fdf31e6be2e001e4c620429d2892df7fb3 https://github.com/buildbot/buildbot/commit/3c0c55fdf31e6be2e001e4c620429d2892df7fb3 Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/docs/relnotes/index.rst Log Message: ----------- edit relnotes Commit: 30f8579333c78d74ae8989ad95a57976fbcf2995 https://github.com/buildbot/buildbot/commit/30f8579333c78d74ae8989ad95a57976fbcf2995 Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/docs/manual/cfg-statustargets.rst Log Message: ----------- fix image link Compare: https://github.com/buildbot/buildbot/compare/39fe2d6728ab...30f8579333c7 From noreply at github.com Tue Apr 30 01:12:18 2013 From: noreply at github.com (GitHub) Date: Mon, 29 Apr 2013 18:12:18 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 18e61a: - set compare_attrs to be accumulateClassList() [... Message-ID: <517f1a725a96e_389dcbbe201339f8@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 18e61a35b1dcbfbb2b7c65d5226469c7471985c8 https://github.com/buildbot/buildbot/commit/18e61a35b1dcbfbb2b7c65d5226469c7471985c8 Author: Edmund Wong Date: 2013-01-28 (Mon, 28 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - set compare_attrs to be accumulateClassList() [wip] Commit: 1e6c659914a2fbffca4ff9436a6191a668060771 https://github.com/buildbot/buildbot/commit/1e6c659914a2fbffca4ff9436a6191a668060771 Author: Edmund Wong Date: 2013-01-28 (Mon, 28 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - turn compare_attr into an accumulatedClassList. Commit: dce8f0a208e8706133eb864d42842216c107a547 https://github.com/buildbot/buildbot/commit/dce8f0a208e8706133eb864d42842216c107a547 Author: Edmund Wong Date: 2013-01-28 (Mon, 28 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Fixed spelling. Commit: e7c9dbc46471af9023933e9900d04b171cc84b9f https://github.com/buildbot/buildbot/commit/e7c9dbc46471af9023933e9900d04b171cc84b9f Author: Edmund Wong Date: 2013-01-28 (Mon, 28 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - compare_attrs belongs to self. Commit: 3a74221bdf43c6d16a8dc1a071f358804ebc1ad2 https://github.com/buildbot/buildbot/commit/3a74221bdf43c6d16a8dc1a071f358804ebc1ad2 Author: Edmund Wong Date: 2013-01-28 (Mon, 28 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Revert all changes except the first. Commit: 559de65f6843198b87a5971ac9cc45505659a6b4 https://github.com/buildbot/buildbot/commit/559de65f6843198b87a5971ac9cc45505659a6b4 Author: Edmund Wong Date: 2013-01-29 (Tue, 29 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Added accumulate(self) method. Commit: dcd495b7f07e3f03b659fe14cc562d1d7b574a5d https://github.com/buildbot/buildbot/commit/dcd495b7f07e3f03b659fe14cc562d1d7b574a5d Author: Edmund Wong Date: 2013-01-29 (Tue, 29 Jan 2013) Changed paths: M master/buildbot/test/unit/test_util_ComparableMixin.py M master/buildbot/util/__init__.py Log Message: ----------- - Added self.accumulate() method to accumulate compare_attrs. Commit: 7bfe283a78cd18d525b4ad113bd002ea28becc9f https://github.com/buildbot/buildbot/commit/7bfe283a78cd18d525b4ad113bd002ea28becc9f Author: Edmund Wong Date: 2013-01-29 (Tue, 29 Jan 2013) Changed paths: M master/buildbot/test/unit/test_util_ComparableMixin.py Log Message: ----------- - test_equality_unimportantDifferences_subclass needs to be changed since b123 no longer equals to b223. Commit: 2ff7e8187ce03e0421e88b7fbd035c68fe36ad32 https://github.com/buildbot/buildbot/commit/2ff7e8187ce03e0421e88b7fbd035c68fe36ad32 Author: Edmund Wong Date: 2013-01-30 (Wed, 30 Jan 2013) Changed paths: M master/buildbot/test/unit/test_util_ComparableMixin.py M master/buildbot/util/__init__.py Log Message: ----------- - removed accumulate(). Changed ComparableMixin to statelessly use accumulatedClassList. Commit: f6b2d68863b898643b3e061a996d4313e2d86c0a https://github.com/buildbot/buildbot/commit/f6b2d68863b898643b3e061a996d4313e2d86c0a Author: Edmund Wong Date: 2013-01-30 (Wed, 30 Jan 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Import reflect, instead of importing the function. Commit: d7d7e512abdeca417280fa5e362e6b97a87a8eed https://github.com/buildbot/buildbot/commit/d7d7e512abdeca417280fa5e362e6b97a87a8eed Author: Edmund Wong Date: 2013-04-02 (Tue, 02 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_ComparableMixin.py Log Message: ----------- - Removed a test. (Don't remember what it was for). - Renamed test_inequality_sameClass_differentCompareAttrs to test_instance_attribute_not_used. Commit: 905471f7838374b584071de3d05f28e2011f23d0 https://github.com/buildbot/buildbot/commit/905471f7838374b584071de3d05f28e2011f23d0 Author: Edmund Wong Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Removed extraneous arguments from accumulateClassList. Commit: 6a04f1486f51a68150ef1cf94dc1c0579e0ac30d https://github.com/buildbot/buildbot/commit/6a04f1486f51a68150ef1cf94dc1c0579e0ac30d Author: Edmund Wong Date: 2013-04-18 (Thu, 18 Apr 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Fixed __cmp__ method. Commit: a5b114693fccfd3b3a313749c61db49b78856812 https://github.com/buildbot/buildbot/commit/a5b114693fccfd3b3a313749c61db49b78856812 Author: Edmund Wong Date: 2013-04-19 (Fri, 19 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_ComparableMixin.py Log Message: ----------- - Changed test_equality_unimportantDifferences_subclass to test_inequality_unimportDifferences_subclass. Commit: 0c1b1e808e9c920b6e1e43b38c95fd04d3f2c7e3 https://github.com/buildbot/buildbot/commit/0c1b1e808e9c920b6e1e43b38c95fd04d3f2c7e3 Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/docs/developer/utils.rst Log Message: ----------- - Update utils.rst for compare_attrs note. Commit: 72b8890d38b435456265e624452859b745ce7b08 https://github.com/buildbot/buildbot/commit/72b8890d38b435456265e624452859b745ce7b08 Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/changes/mail.py Log Message: ----------- - Changed mail.py to use accumulateClassList. Commit: 601e6dbabac80de4214e0129b66f1d26141c4ef2 https://github.com/buildbot/buildbot/commit/601e6dbabac80de4214e0129b66f1d26141c4ef2 Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/timed.py Log Message: ----------- - Add reflect to the imports. Commit: af657ac467c352da396b92496f26750797a24544 https://github.com/buildbot/buildbot/commit/af657ac467c352da396b92496f26750797a24544 Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/schedulers/basic.py Log Message: ----------- - Update BaseBasicScheduler to use accumulateClassList. Commit: e0aae2a1a58c7bde991b6abe7ee48027b76e87de https://github.com/buildbot/buildbot/commit/e0aae2a1a58c7bde991b6abe7ee48027b76e87de Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/schedulers/dependent.py Log Message: ----------- - Updated dependent.py to use accumulateClassList. Commit: 63437fd8b773e913465ed3f8e8dcad5912f414ab https://github.com/buildbot/buildbot/commit/63437fd8b773e913465ed3f8e8dcad5912f414ab Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/schedulers/timed.py Log Message: ----------- - Update timed.py to use accumulateClassList. Commit: 4e05b1ee89cf4612442da0baef80e1c236e8910b https://github.com/buildbot/buildbot/commit/4e05b1ee89cf4612442da0baef80e1c236e8910b Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/schedulers/trysched.py Log Message: ----------- - Update trysched.py to use accumulateClassList. Commit: bc9d417cb9ba4c6c7a150be0e448c500266c1c6d https://github.com/buildbot/buildbot/commit/bc9d417cb9ba4c6c7a150be0e448c500266c1c6d Author: Edmund Wong Date: 2013-04-21 (Sun, 21 Apr 2013) Changed paths: M master/buildbot/test/unit/test_schedulers_manager.py Log Message: ----------- -Update test_schedulers_manager.py - remove the concatentation of compare_attrs. Commit: 4e85c1b1cf2c5dda50c69b00fa441d997fd4b5c0 https://github.com/buildbot/buildbot/commit/4e85c1b1cf2c5dda50c69b00fa441d997fd4b5c0 Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/schedulers/trysched.py M master/buildbot/util/__init__.py Log Message: ----------- - Removed unneeded lines. Commit: c7caf905d01887e36a9975e4b5fc7786f3888706 https://github.com/buildbot/buildbot/commit/c7caf905d01887e36a9975e4b5fc7786f3888706 Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - re-added back some lines. Commit: d16ef7a4fb60b143809fb121243f8f677125130d https://github.com/buildbot/buildbot/commit/d16ef7a4fb60b143809fb121243f8f677125130d Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/util/__init__.py Log Message: ----------- - Compare classes and not names. Commit: adab8cacc82d51f21db28076e9cc5298a9fc65af https://github.com/buildbot/buildbot/commit/adab8cacc82d51f21db28076e9cc5298a9fc65af Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/changes/mail.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/timed.py Log Message: ----------- - Removed unneeded code from constructors. Commit: 965058019a12bfe50589ef7d2f71202b441e7c9b https://github.com/buildbot/buildbot/commit/965058019a12bfe50589ef7d2f71202b441e7c9b Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/test/unit/test_util_ComparableMixin.py M master/buildbot/util/__init__.py Log Message: ----------- - Changed test : f123 < b123. - Used acomp instead of having acomp and bcomp. Commit: ec259532cfa7284fe4a61be5bedd46131d848fe7 https://github.com/buildbot/buildbot/commit/ec259532cfa7284fe4a61be5bedd46131d848fe7 Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/timed.py M master/buildbot/schedulers/trysched.py M master/buildbot/util/__init__.py Log Message: ----------- - Removed references to reflect. (No longer used) - Changed acomp to compare_attrs. - Removed unnecessary code. Commit: b3c5ded917b0313f4b666357c5927c8cc7ed417e https://github.com/buildbot/buildbot/commit/b3c5ded917b0313f4b666357c5927c8cc7ed417e Author: Edmund Wong Date: 2013-04-23 (Tue, 23 Apr 2013) Changed paths: M master/buildbot/schedulers/timed.py Log Message: ----------- - Removed unnecessary line. Commit: a217ca26f8d0b570b7084e240399a57176ad68b0 https://github.com/buildbot/buildbot/commit/a217ca26f8d0b570b7084e240399a57176ad68b0 Author: Edmund Wong Date: 2013-04-24 (Wed, 24 Apr 2013) Changed paths: M master/buildbot/changes/mail.py M master/buildbot/test/unit/test_schedulers_manager.py Log Message: ----------- - Removed mentions of reflect. Commit: 2e5980ffee856ec830f380d23b3c59629b0630c1 https://github.com/buildbot/buildbot/commit/2e5980ffee856ec830f380d23b3c59629b0630c1 Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/buildbot/changes/mail.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/dependent.py M master/buildbot/schedulers/timed.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_schedulers_manager.py M master/buildbot/test/unit/test_util_ComparableMixin.py M master/buildbot/util/__init__.py M master/docs/developer/utils.rst Log Message: ----------- use inequality instead of lt - order doesn't really matter Compare: https://github.com/buildbot/buildbot/compare/30f8579333c7...2e5980ffee85 From noreply at github.com Tue Apr 30 01:18:16 2013 From: noreply at github.com (GitHub) Date: Mon, 29 Apr 2013 18:18:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 20d12f: Fix build start time retrieving Message-ID: <517f1bd8edf47_3885ac5e181632da@hookshot-fe1-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 20d12fbf3bb717a78ded123f5a0624d158c2ffde https://github.com/buildbot/buildbot/commit/20d12fbf3bb717a78ded123f5a0624d158c2ffde Author: Vladimir Rutsky Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Fix build start time retrieving When build is not finished getTimes() returns tuple (start_time, None), and min((start_time, None)) == None. This lead to incorrect sorting of builds in grid view --- not finished builds were displayed first and if there were more build revisions than grid width builds (five by default) not finished builds doesn't displayed at all. Commit: 2169457f2f28357277001669f8c3bbcbc00f069c https://github.com/buildbot/buildbot/commit/2169457f2f28357277001669f8c3bbcbc00f069c Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/buildbot/status/web/grid.py Log Message: ----------- Merge branch 'grid_build_time_bug' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/2e5980ffee85...2169457f2f28 From noreply at github.com Tue Apr 30 01:19:48 2013 From: noreply at github.com (GitHub) Date: Mon, 29 Apr 2013 18:19:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 682d9e: Fix typo: ths Message-ID: <517f1c34c594b_1fed1499e1c8613a@hookshot-fe6-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 682d9e0b28138ca1d354cdec1e812e45325277cf https://github.com/buildbot/buildbot/commit/682d9e0b28138ca1d354cdec1e812e45325277cf Author: Vladimir Rutsky Date: 2013-04-27 (Sat, 27 Apr 2013) Changed paths: M master/buildbot/status/build.py Log Message: ----------- Fix typo: ths Commit: 4095a96eb06501377c31fae00b153a248cacae6b https://github.com/buildbot/buildbot/commit/4095a96eb06501377c31fae00b153a248cacae6b Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/buildbot/status/build.py Log Message: ----------- Merge branch 'typos2' of git://github.com/vrutsky/buildbot Compare: https://github.com/buildbot/buildbot/compare/2169457f2f28...4095a96eb065 From noreply at github.com Tue Apr 30 01:27:06 2013 From: noreply at github.com (GitHub) Date: Mon, 29 Apr 2013 18:27:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b08cb7: Don't defer stopping OpenStack slave to a thread Message-ID: <517f1dead44c5_525bfafe101807bf@hookshot-fe2-pe1-prd.aws.github.net.mail> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: b08cb73804564cf13e905905128333a932120717 https://github.com/buildbot/buildbot/commit/b08cb73804564cf13e905905128333a932120717 Author: Sean Kelly Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Don't defer stopping OpenStack slave to a thread The thread didn't do anything but poll whether the instance was deleted or not. That's not very useful, so drop the polling and simply delete the instance. Commit: 63e6d17b39ef23a5996e6907d36c46b329083f10 https://github.com/buildbot/buildbot/commit/63e6d17b39ef23a5996e6907d36c46b329083f10 Author: Sean Kelly Date: 2013-04-25 (Thu, 25 Apr 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Don't reference self.instance in _start_instance Don't reference self.instance, since it could be set to None by stop_instance. This does not happen yet, but could in the future. Commit: 7268940c7b51cbebff8b425a01f8b47a3ebb95e9 https://github.com/buildbot/buildbot/commit/7268940c7b51cbebff8b425a01f8b47a3ebb95e9 Author: Dustin J. Mitchell Date: 2013-04-29 (Mon, 29 Apr 2013) Changed paths: M master/buildbot/buildslave/openstack.py Log Message: ----------- Merge branch 'openstack-cleanup' of git://github.com/seankelly/buildbot Compare: https://github.com/buildbot/buildbot/compare/4095a96eb065...7268940c7b51 From trac at buildbot.net Tue Apr 30 01:32:30 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Apr 2013 01:32:30 -0000 Subject: [Buildbot-commits] [Buildbot] #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 In-Reply-To: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> References: <037.c46416d8f50d647daf1522328905e37b@buildbot.net> Message-ID: <052.a5ae6e6ad10d785fe75d7867af2ee9fc@buildbot.net> #2473: using the branch option to choose a tag fails if using a git version older than 1.7.10 ------------------------+-------------------- Reporter: johnt | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.6p1 | Resolution: Keywords: git, simple | ------------------------+-------------------- Changes (by dustin): * keywords: git => git, simple * milestone: undecided => 0.8.+ Comment: Let's leave this here, then. The tricky bit about a code change is that Buildbot doesn't know if it's looking at a tag or a branch, so it doesn't know when to add a "refs/tags/" prefix. If someone can come up with a way to figure that out, then we'll merge a patch. Otherwise, folks running into this problem will find this bug and use the workaround. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 30 01:54:43 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Apr 2013 01:54:43 -0000 Subject: [Buildbot-commits] [Buildbot] #2495: 'Force build' form 'repository' field usage In-Reply-To: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> References: <038.e251e3a6ce7e78b00061ba37249c1f52@buildbot.net> Message-ID: <053.e33f3f9a497a66a57e8cf0255ec59b84@buildbot.net> #2495: 'Force build' form 'repository' field usage ----------------------------+---------------------- Reporter: jachen | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: 0.8.7p1 | Resolution: Keywords: projrepo | ----------------------------+---------------------- Comment (by dustin): Interpolate has some ways to specify default values for various circumstances. Check the docs for details. -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 30 08:40:44 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Apr 2013 08:40:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2219: Make sample configuration modular. In-Reply-To: <042.df4164f479ee7ff6c9f328d81c903457@buildbot.net> References: <042.df4164f479ee7ff6c9f328d81c903457@buildbot.net> Message-ID: <057.c8f63bc807d01db062637f0a6482502c@buildbot.net> #2219: Make sample configuration modular. ------------------------+--------------------- Reporter: tom.prince | Owner: config Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: | ------------------------+--------------------- Comment (by ewong): I tried the following: {{{ import buildbot.status html=buildbot.status.html }}} I get the following error during checkconfig: {{{ (sandbox)bash-4.1$ buildbot checkconfig master error while parsing config file: Traceback (most recent call last): File "/home/cc/projs/bb9/master/bin/buildbot", line 4, in runner.run() File "/home/cc/projs/bb9/master/buildbot/scripts/runner.py", line 743, in run sys.exit(subcommandFunction(subconfig)) File "/home/cc/projs/bb9/master/buildbot/scripts/checkconfig.py", line 50, in checkconfig return cl.load(quiet=quiet) File "/home/cc/projs/bb9/master/buildbot/scripts/checkconfig.py", line 29, in load self.basedir, self.configFileName) --- --- File "/home/cc/projs/bb9/master/buildbot/config.py", line 156, in loadConfig exec f in localDict File "/home/cc/projs/playground/c-c/master/master.cfg", line 116, in html=buildbot.status.html exceptions.AttributeError: 'module' object has no attribute 'html' Configuration Errors: error while parsing config file: 'module' object has no attribute 'html' (traceback in logfile) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From trac at buildbot.net Tue Apr 30 21:40:22 2013 From: trac at buildbot.net (Buildbot trac) Date: Tue, 30 Apr 2013 21:40:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2219: Make sample configuration modular. In-Reply-To: <042.df4164f479ee7ff6c9f328d81c903457@buildbot.net> References: <042.df4164f479ee7ff6c9f328d81c903457@buildbot.net> Message-ID: <057.f4cc033e6313aac888bc80bc83cf759c@buildbot.net> #2219: Make sample configuration modular. ------------------------+--------------------- Reporter: tom.prince | Owner: config Type: enhancement | Status: new Priority: major | Milestone: 0.9.0 Version: 0.8.5 | Resolution: Keywords: | ------------------------+--------------------- Old description: > Best practices for buildbot configuration are to have modular config of > some sort. Don't ship with an example that doesn't follow best practices. > > <@exarkun> (Heck, the sample deployment _starts_ as a mess; to avoid a > mess, you'd have to clean it up the config distributed with buildbot) New description: Best practices for buildbot configuration are to have modular config of some sort. Don't ship with an example that doesn't follow best practices. <@exarkun> (Heck, the sample deployment _starts_ as a mess; to avoid a mess, you'd have to clean it up the config distributed with buildbot) -- Comment (by dustin): Right, that won't work - Python doesn't automatically import all sub- modules of a package. I'm not sure what prompted you to try that? -- Ticket URL: Buildbot Buildbot: build/test automation