[Buildbot-commits] [buildbot/buildbot] bf7132: RemoteCommand: add collectStderr

GitHub noreply at github.com
Fri Sep 21 14:05:47 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: bf7132b6dcc2f52f238df45b3296dd83aac45bab
      https://github.com/buildbot/buildbot/commit/bf7132b6dcc2f52f238df45b3296dd83aac45bab
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-09-21 (Fri, 21 Sep 2012)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/fake/remotecommand.py

  Log Message:
  -----------
  RemoteCommand: add collectStderr

Some master side steps also need to parse the stdout.
Clone the collectStdout feature for stderr

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 9c0d9d77986898782cd06fc56a64a6beac802271
      https://github.com/buildbot/buildbot/commit/9c0d9d77986898782cd06fc56a64a6beac802271
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-09-21 (Fri, 21 Sep 2012)

  Changed paths:
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/test/unit/test_steps_slave.py

  Log Message:
  -----------
  slave: factorize some common fs utils

Its very common in source steps to stat, rmdir, mkdir the hidden
repository used to store database (e.g. .svn, .git, etc)

We provide shortcuts to do so.

Unlike slave source old implementations, we choose not to
factorize too much logic, e.g clobber directories behind
the back of the source step.

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: c9294b41548ab981cf54123083652c77c1a58276
      https://github.com/buildbot/buildbot/commit/c9294b41548ab981cf54123083652c77c1a58276
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2012-09-21 (Fri, 21 Sep 2012)

  Changed paths:
    A master/buildbot/steps/source/repo.py
    M master/buildbot/test/fake/remotecommand.py
    A master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/test/util/sourcesteps.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  repo: implement repo as a master driven source step

This commit reimplements the same feature and API
as repo from oldsource.py
The big difference is the test coverage that is now 98%,
and thus the maintainability of the code.
Most of the code is also now written in inline callbacks which adds
a lot of readability.

Additionnal features compared to oldsource.py:

- repo is now capable of importing patches to the manifest directory
  This allows for gated-commit process to also verify that manifest patches
  does not break the build
- better handling of tarball (automatic update on a weekly basis)
- support for repo sync -c, which speeds up a lot in very big projects
- better clobbering behaviour. The working directory is kept as much as
  possible for obvious speed reasons

Version2:
- reworked the flow to use less unneeded methods (like continueVC)
- reworked setText for concision
- reworked manifest patch handling which did not actually work with repo
- also remove the lock for manifests repository

Version3:
- fix bug where tarball is not created the first time (+added a test for that)
- log the environ only once (and factorize it in tests)

Version4:
- Only encode manifest branches when needed
- make mirror retry to really be a retry number, and not a try number

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: a762941e2eb057c70e311433742596cf6769b85f
      https://github.com/buildbot/buildbot/commit/a762941e2eb057c70e311433742596cf6769b85f
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-09-21 (Fri, 21 Sep 2012)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    A master/buildbot/steps/source/repo.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/unit/test_steps_slave.py
    A master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/test/util/sourcesteps.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  Merge branch 'reposource' of git://github.com/tardyp/buildbot


  Commit: 9d25548f38c1d02a918a51dc034afba0d99bdd99
      https://github.com/buildbot/buildbot/commit/9d25548f38c1d02a918a51dc034afba0d99bdd99
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2012-09-21 (Fri, 21 Sep 2012)

  Changed paths:
    M master/buildbot/steps/source/repo.py

  Log Message:
  -----------
  fix whitespace


Compare: https://github.com/buildbot/buildbot/compare/0ce60c971639...9d25548f38c1


More information about the Commits mailing list