[Buildbot-commits] [Buildbot] #2365: got_revision isn't properly set to a dictionary when codebases are used.

[Buildbot]

#2365: got_revision isn't properly set to a dictionary when codebases are used.
-------------------------------------+--------------------
Reporter:  tom.prince                |       Owner:
    Type:  defect                    |      Status:  new
Priority:  blocker                   |   Milestone:  0.8.7
 Version:  0.8.6p1                   |  Resolution:
Keywords:  master-side-source-steps  |
-------------------------------------+--------------------

Comment (by pepsiman):

 I don't think things are as broken as your notes suggest.

 > getAbsoluteSourceStamp on SourceStamp sets cloned.revision to
 got_revision, which won't work if it's a dictionary

 ```getSourceStamps``` on ```BuildStatus``` doesn't call
 ```getAbsoluteSourceStamp``` with a dictionary.

 Adding an assert should be sufficient.

 > fix source steps to read-modify-write

 ```setProperty``` on ```Source``` does read-modify-write when codebases
 are in use.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2365#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation