[Buildbot-commits] [Buildbot] #2382: Blocker step broken on 0.8.7

Buildbot nobody at buildbot.net
Thu Oct 18 00:01:54 UTC 2012


#2382: Blocker step broken on 0.8.7
-----------------------+--------------------
Reporter:  tom.prince  |       Owner:
    Type:  defect      |      Status:  new
Priority:  minor       |   Milestone:  0.8.+
 Version:  0.8.7       |  Resolution:
Keywords:  blocker     |
-----------------------+--------------------

Comment (by dustin):

 {{{
 #!patch
 diff --git a/master/buildbot/steps/blocker.py
 b/master/buildbot/steps/blocker.py
 index ab672e6..dd2a46e 100644
 --- a/master/buildbot/steps/blocker.py
 +++ b/master/buildbot/steps/blocker.py
 @@ -138,8 +138,7 @@ class Blocker(BuildStep):
          # needed information. When that is implemented, then Blocker
          # needs to be adapted to use it, and *then* Blocker should be
          # safe to use.
 -        all_builds = (builderStatus.buildCache.values() +
 -                      builderStatus.getCurrentBuilds())
 +        all_builds = builderStatus.getCurrentBuilds()

          for buildStatus in all_builds:
              if self.buildsMatch(myBuildStatus, buildStatus):
 }}}
 might be a decent fix.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2382#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list