[Buildbot-commits] [Buildbot] #2380: getAllGotRevisions is broken with bzr, svn, ...

[Buildbot]

#2380: getAllGotRevisions is broken with bzr, svn, ...
-------------------+-------------------------
Reporter:  flox    |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  0.8.7p1
 Version:  0.8.7   |   Keywords:  bzr svn web
-------------------+-------------------------
 With a single codebase under Bzr, I got error viewing the Web status.

 The issue is that "status.build.getAllGotRevisions" assumes that
 'got_revision' is a <str>.
 The current implementations in "steps.source.Bzr" and "steps.source.SVN"
 will set an <int> for the revision.

 I've monkey patched my buildbot.


 {{{
 #!python
 def patch_status_build():
     def getAllGotRevisions(self):
         all_got_revisions = self.properties.getProperty('got_revision',
 {})
         # revisions might be 'str' or 'int'
         if isinstance(all_got_revisions, (str, int)):
             all_got_revisions = {'': all_got_revisions}
         return all_got_revisions
     from buildbot.status.build import BuildStatus
     BuildStatus.getAllGotRevisions = getAllGotRevisions
 patch_status_build()
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2380>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation